Re: [PATCH 2/2] [POWERPC] Size swapper_pg_dir correctly

2007-08-22 Thread Stephen Rothwell
On Wed, 22 Aug 2007 22:26:35 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > > +#ifdef CONFIG_PPC64 > > + DEFINE(PGD_TABLE_SIZE, PGD_TABLE_SIZE); > > +#endif > > Why limit this to ppc64? The cleanup should be reasonable for all ppc. Because PGD_TABLE_SIZE only exists for ppc64 :-) for ppc32 th

Re: Section mismatch warning

2007-08-22 Thread sivaji
Hi, I applied the patch(13066). After that i got following error. arch/powerpc/kernel/vmlinux.lds:59: parse error I added the following lines in the vmlinux.lds file ALIGN_FUNCTION(); *(.text.head) Then i removed the ALIGN_FUNCTION() in the vmlinux.lds file. The parse error was ove

Re: bogus vscsi dt node on iseries

2007-08-22 Thread Stephen Rothwell
On Thu, 23 Aug 2007 07:42:39 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote: > > On Thu, Aug 23, Stephen Rothwell wrote: > > > On Wed, 22 Aug 2007 19:51:21 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > > > > > > Does anyone know why dt_vdevices() creates a vscsi node on legacy iseries? > > >

Re: bogus vscsi dt node on iseries

2007-08-22 Thread Olaf Hering
On Thu, Aug 23, Stephen Rothwell wrote: > On Wed, 22 Aug 2007 19:51:21 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > > > Does anyone know why dt_vdevices() creates a vscsi node on legacy iseries? > > I'm sure only viodasd and viocd is required as blockdevice type. > > Because the IBM vscs

Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq

2007-08-22 Thread Fernando Luis Vázquez Cao
On Wed, 2007-08-22 at 13:28 -0500, Linas Vepstas wrote: > On Wed, Aug 22, 2007 at 07:44:41PM +1000, Paul Mackerras wrote: > > Fernando Luis Vázquez Cao writes: > > > > > amiga_request_irq and mach_request_irq are never used, so delete them. > > > > OK, but is there a particular reason you want t

Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq

2007-08-22 Thread Fernando Luis Vázquez Cao
On Wed, 2007-08-22 at 19:44 +1000, Paul Mackerras wrote: > Fernando Luis Vázquez Cao writes: > > > amiga_request_irq and mach_request_irq are never used, so delete them. > > OK, but is there a particular reason you want to do this? Hi Paul, Thank you for your reply. I am currently auditing all

Re: wmb vs mmiowb

2007-08-22 Thread Nick Piggin
On Wed, Aug 22, 2007 at 07:57:56PM -0700, Linus Torvalds wrote: > > > On Thu, 23 Aug 2007, Nick Piggin wrote: > > > > > Irix actually had an io_unlock() routine that did this > > > implicitly, but iirc that was shot down for Linux... > > > > Why was it shot down? Seems like a pretty good idea t

Please pull from 'for-2.6.24' branch

2007-08-22 Thread Kumar Gala
Please pull from 'for-2.6.24' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for-2.6.24 This has been rebased against your latest for-2.6.24 branch and includes the removal of to drivers/macintosh/adb-iop.c. All other driver related patches have been sent to the

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 10:33 PM, David Gibson wrote: > On Wed, Aug 22, 2007 at 10:33:55PM -0500, Kumar Gala wrote: >> >> On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote: >> >>> Guys, >>> >>> I was wondering if I could get your help with looking at the >>> following lists and determining if we have an

[PATCH] mpc8xx: Only build mpc8xx on arch/ppc

2007-08-22 Thread Kumar Gala
Currently the mpc8xx ide driver will only work on arch/ppc so only allow it to be built there. Also, killed a minor include that isn't actually used by the driver. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- drivers/ide/Kconfig |2 +- drivers/ide/ppc/mpc8xx.c |1 - 2 files cha

[PATCH 1/2] [POWERPC] Remove cmd_line from head*.S

2007-08-22 Thread Stephen Rothwell
It is just a C char array, so declare it thusly. Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- arch/powerpc/kernel/head_32.S|8 arch/powerpc/kernel/head_40x.S |7 --- arch/powerpc/kernel/head_44x.S |8 arch/powerpc/kernel/head_64.S

Please pull from 'mtd-2.6.24' branch

2007-08-22 Thread Kumar Gala
Please pull from 'mtd-2.6.24' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git mtd-2.6.24 to receive the following updates: drivers/mtd/maps/Kconfig | 12 - drivers/mtd/maps/Makefile |1 drivers/mtd/maps/pq2fads.c | 88 - drivers/mtd/maps/tq

Re: wmb vs mmiowb

2007-08-22 Thread Nick Piggin
On Wed, Aug 22, 2007 at 07:57:56PM -0700, Linus Torvalds wrote: > > > On Thu, 23 Aug 2007, Nick Piggin wrote: > > > > > Irix actually had an io_unlock() routine that did this > > > implicitly, but iirc that was shot down for Linux... > > > > Why was it shot down? Seems like a pretty good idea t

Re: How to port PReP to arch/powerpc?

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 07:29:56AM -0500, Josh Boyer wrote: > On Wed, 22 Aug 2007 14:50:07 +0300 (EEST) > Meelis Roos <[EMAIL PROTECTED]> wrote: > > > It seems no one cares for arch/ppc any more but the move to powerpc was > > not finished completely (PReP subarch was not migrated but sees users,

Re: bogus vscsi dt node on iseries

2007-08-22 Thread Stephen Rothwell
On Wed, 22 Aug 2007 19:51:21 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote: > > > Does anyone know why dt_vdevices() creates a vscsi node on legacy iseries? > I'm sure only viodasd and viocd is required as blockdevice type. Because the IBM vscsi client (in theory) works on legacy iSeries. -- Chee

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 10:33:55PM -0500, Kumar Gala wrote: > > On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote: > > >Guys, > > > >I was wondering if I could get your help with looking at the > >following lists and determining if we have an issue or not related > >the following files: > > > >Getti

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote: > Guys, > > I was wondering if I could get your help with looking at the > following lists and determining if we have an issue or not related > the following files: > > Getting some classification on these would be good. Possibly > classifications,

Re: [PATCH 1/2] [POWERPC] Remove cmd_line from head*.S

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 10:09 PM, Stephen Rothwell wrote: > It is just a C char array, so declare it thusly. > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> > --- > arch/powerpc/kernel/head_32.S|8 > arch/powerpc/kernel/head_44x.S |8 > arch/powerpc/ke

Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure on powerpc

2007-08-22 Thread Jason Wessel
Andrew Morton wrote: > On Wed, 22 Aug 2007 17:44:12 -0500 > Jason Wessel <[EMAIL PROTECTED]> wrote: > > >> +while (!atomic_read(&debugger_active)); >> > > eek. We're in the process of hunting down and eliminating exactly this > construct. There have been cases where the compiler cache

Re: [PATCH 2/2] [POWERPC] Size swapper_pg_dir correctly

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 10:10 PM, Stephen Rothwell wrote: > David Gibson pointed out that swapper_pg_dir actually need to be > PGD_TABLE_SIZE bytes long not PAGE_SIZE. This actually saves 64k in > the bss for a ppc64_defconfig kernel built with CONFIG_PPC_64K_PAGES. > > Signed-off-by: Stephen Rothwe

Re: [PATCH v6 1/2] [POWERPC] fsl_soc: add support for fsl_spi

2007-08-22 Thread Stephen Rothwell
Hi Anton, On Wed, 22 Aug 2007 18:57:32 +0400 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > + sysclk = *(u32 *)of_get_property(np, "bus-frequency", NULL); I just cringe everytime I see someone dereference a pointer they got from somewhere (effectively) external without checking for NULL. I r

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 9:47 PM, David Gibson wrote: > On Wed, Aug 22, 2007 at 10:19:21AM -0500, Kumar Gala wrote: >> Guys, >> >> I was wondering if I could get your help with looking at the >> following lists and determining if we have an issue or not related >> the following files: >> >> Getting so

Re: [PATCH 1/2] [POWERPC] Remove cmd_line from head*.S

2007-08-22 Thread David Gibson
On Thu, Aug 23, 2007 at 01:09:13PM +1000, Stephen Rothwell wrote: > It is just a C char array, so declare it thusly. > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson| I'll have my music baroque, and my code da

Re: [PATCH 2/2] [POWERPC] Size swapper_pg_dir correctly

2007-08-22 Thread David Gibson
On Thu, Aug 23, 2007 at 01:10:32PM +1000, Stephen Rothwell wrote: > David Gibson pointed out that swapper_pg_dir actually need to be > PGD_TABLE_SIZE bytes long not PAGE_SIZE. This actually saves 64k in > the bss for a ppc64_defconfig kernel built with CONFIG_PPC_64K_PAGES. > > Signed-off-by: Ste

[PATCH 2/2] [POWERPC] Size swapper_pg_dir correctly

2007-08-22 Thread Stephen Rothwell
David Gibson pointed out that swapper_pg_dir actually need to be PGD_TABLE_SIZE bytes long not PAGE_SIZE. This actually saves 64k in the bss for a ppc64_defconfig kernel built with CONFIG_PPC_64K_PAGES. Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- arch/powerpc/kernel/asm-offsets.c |

[PATCH 1/2] [POWERPC] Remove cmd_line from head*.S

2007-08-22 Thread Stephen Rothwell
It is just a C char array, so declare it thusly. Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- arch/powerpc/kernel/head_32.S|8 arch/powerpc/kernel/head_44x.S |8 arch/powerpc/kernel/head_4xx.S |7 --- arch/powerpc/kernel/head_64.S

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 9:49 PM, David Gibson wrote: > On Wed, Aug 22, 2007 at 02:30:47PM -0500, Josh Boyer wrote: >> On Wed, 22 Aug 2007 10:19:21 -0500 >> Kumar Gala <[EMAIL PROTECTED]> wrote: >> >>> Guys, >>> >>> I was wondering if I could get your help with looking at the >>> following lists and d

Re: [PATCH] ucc_geth: kill unused include

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 09:51:03PM -0500, Kumar Gala wrote: > The ucc_geth_mii code is based on the gianfar_mii code that use to include > ocp.h. ucc never need this and it causes issues when we want to kill > arch/ppc includes from arch/powerpc. > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>

Re: wmb vs mmiowb

2007-08-22 Thread Linus Torvalds
On Thu, 23 Aug 2007, Nick Piggin wrote: > > > Irix actually had an io_unlock() routine that did this > > implicitly, but iirc that was shot down for Linux... > > Why was it shot down? Seems like a pretty good idea to me ;) It's horrible. We'd need it for *every* single spinlock type. We have l

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 02:30:47PM -0500, Josh Boyer wrote: > On Wed, 22 Aug 2007 10:19:21 -0500 > Kumar Gala <[EMAIL PROTECTED]> wrote: > > > Guys, > > > > I was wondering if I could get your help with looking at the > > following lists and determining if we have an issue or not related > >

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 10:19:21AM -0500, Kumar Gala wrote: > Guys, > > I was wondering if I could get your help with looking at the > following lists and determining if we have an issue or not related > the following files: > > Getting some classification on these would be good. Possibly

[PATCH] ucc_geth: kill unused include

2007-08-22 Thread Kumar Gala
The ucc_geth_mii code is based on the gianfar_mii code that use to include ocp.h. ucc never need this and it causes issues when we want to kill arch/ppc includes from arch/powerpc. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Jeff, if you issue with this for 2.6.23, I'd prefer to push this

Re: Section mismatch warning

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 9:30 PM, sivaji wrote: > > Hi, > When compiling the 2.6.23-rc3 kernel, i got following warning > messages. > > WARNING: vmlinux.o(.text+0x18): Section mismatch: reference to > .init.text:early_init (between '__start' and '__after_mmu_off') > WARNING: vmlinux.o(.text+0

Section mismatch warning

2007-08-22 Thread sivaji
Hi, When compiling the 2.6.23-rc3 kernel, i got following warning messages. WARNING: vmlinux.o(.text+0x18): Section mismatch: reference to .init.text:early_init (between '__start' and '__after_mmu_off') WARNING: vmlinux.o(.text+0x3834): Section mismatch: reference to .init.text:machine_i

Re: wmb vs mmiowb

2007-08-22 Thread Nick Piggin
On Wed, Aug 22, 2007 at 12:02:11PM -0700, Jesse Barnes wrote: > On Wednesday, August 22, 2007 11:07 am Linus Torvalds wrote: > > > It really seems like it is some completely different concept from a > > > barrier. And it shows, on the platform where it really matters > > > (sn2), where the thing ac

Re: [PATCH 05/20] bootwrapper: flatdevtree fixes

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 12:24:56PM -0500, Scott Wood wrote: > On Wed, Aug 22, 2007 at 11:09:07AM +1000, David Gibson wrote: > > On Tue, Aug 21, 2007 at 11:09:58AM -0500, Scott Wood wrote: > > > The point of #2 was as part of the fix to #1 -- otherwise, the same > > > check for NULL would have to b

Re: wmb vs mmiowb

2007-08-22 Thread Nick Piggin
On Wed, Aug 22, 2007 at 11:07:32AM -0700, Linus Torvalds wrote: > > > On Wed, 22 Aug 2007, Nick Piggin wrote: > > > > It took me more than a glance to see what the difference is supposed to be > > between wmb() and mmiowb(). I think especially because mmiowb isn't really > > like a write barrier

Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure on powerpc

2007-08-22 Thread Jason Wessel
Andrew Morton wrote: On Wed, 22 Aug 2007 21:04:28 +0200 Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: Hello, Got that on imac g3. CC kernel/kgdb.o kernel/kgdb.c: In function 'kgdb_handle_exception': kernel/kgdb.c:940: error: invalid lvalue in unary '&' kernel/kgdb.c:940: warn

[PATCH] Move serial_dev_init to device_initcall()

2007-08-22 Thread Olof Johansson
With the I/O space rewrite by BenH, the legacy_serial serial_dev_init() initcall is now called before I/O space is setup, but it's dependent on it being available. Since there's no way to make dependencies between initcalls, we'll just have to move it to device_initcall(). Yes, it's suboptimal but

[POWERPC] add clrsetbits macros

2007-08-22 Thread Timur Tabi
This patch adds the clrsetbits_xxx() macros, which are used to set and clear multiple bits in a single read-modify-write operation. Specify the bits to clear in the 'clear' parameter and the bits to set in the 'set' parameter. These macros can also be used to set a multiple-bit bit pattern using a

Re: [PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-22 Thread Stephen Rothwell
Hi Olof, On Wed, 22 Aug 2007 09:12:48 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > -static unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int reg) > +static inline unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int > reg) ^^ For static functions in C f

Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure on powerpc

2007-08-22 Thread Andrew Morton
On Wed, 22 Aug 2007 17:44:12 -0500 Jason Wessel <[EMAIL PROTECTED]> wrote: > Perhaps there is a cleaner way to do the same thing and avoid the > cmpxchg all together. I used the attached patch to eliminate the > cmpxchg operation. > > > Jason. > > > [kgdb_enter_atomic.patch text/plain (2.0

Re: Patches added to powerpc.git for-2.6.24 branch

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 5:39 PM, Arnd Bergmann wrote: > On Wednesday 22 August 2007, Kumar Gala wrote: >> I think we can all agree that the amiga*.h, zorro.h and traps.h can >> be ignored since they have to do with amiga/apus support. > > arch/powerpc/kernel/setup_32.c unconditionally #includes amig

Re: Patches added to powerpc.git for-2.6.24 branch

2007-08-22 Thread Arnd Bergmann
On Wednesday 22 August 2007, Kumar Gala wrote: > I think we can all agree that the amiga*.h, zorro.h and traps.h can   > be ignored since they have to do with amiga/apus support. arch/powerpc/kernel/setup_32.c unconditionally #includes , the rest looks unused indeed. Arnd <><

RFC: SPE misalignment handling framework

2007-08-22 Thread Kumar Gala
This is just to see if the modification to fix_alignment is ok with people. Still need to fill in the actual implementation of emulate_spe(). diff --git a/arch/powerpc/kernel/align.c b/arch/powerpc/kernel/align.c index 4c47f9c..a9fcf25 100644 --- a/arch/powerpc/kernel/align.c +++ b/arch/powerpc/ke

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-22 Thread Scott Wood
Vitaly Bordug wrote: > yes, wrong snippet what about > > >> #ifdef CONFIG_CPM2 + r = fs_enet_mdio_bb_init(); + if (r != 0) + >> goto out_mdio_bb; +#endif +#ifdef CONFIG_8xx + r = >> fs_enet_mdio_fec_init(); + if (r != 0) + goto out_mdio_fec; >> +#endif > > > We had to pray

Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-22 Thread Scott Wood
Vitaly Bordug wrote: >>-#define W8(_p, _m, _v) __fcc_out8(&(_p)->_m, (_v)) >>-#define R8(_p, _m) __fcc_in8(&(_p)->_m) >>+#define W8(_p, _m, _v) out_8(&(_p)->_m, (_v)) >>+#define R8(_p, _m) in_8(&(_p)->_m) >> #define S8(_p, _m, _v) W8(_p, _m, R8(_p, _m) | (_v)) >> #define C8(_p

Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:54:02 -0500 Scott Wood wrote: > These macros accomplish nothing other than defeating type checking. > > This patch also fixes one instance of the wrong register size being > used that was revealed by enabling type checking. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]>

Re: [PATCH 2/7] fs_enet: Whitespace cleanup.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:53:59 -0500 Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> Acked-by: Vitaly Bordug <[EMAIL PROTECTED]> > --- > drivers/net/fs_enet/fs_enet-main.c | 85 > --- > drivers/net/fs_enet/fs_enet.h |4 +- > drivers/net/

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-22 Thread Vitaly Bordug
On Tue, 21 Aug 2007 11:47:41 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > Vitaly Bordug wrote: > > On Fri, 17 Aug 2007 13:17:18 -0500 > > Scott Wood wrote: > > > > > >>The existing OF glue code was crufty and broken. Rather than fix > >>it, it will be removed, and the ethernet driver now talks

Re: ppc Floating Point support status

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 1:37 PM, Ben Buchli wrote: > Hello everybody, > I was wondering what the status was on supporting floating-point > instructions > for the mpc8548. I found the suggested patch: > http://patchwork.ozlabs.org/linuxppc/patch? > order=patch&filter=none&id=9455, > but I'm not su

Re: [POWERPC] add clrsetbits macros

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 12:47 PM, Timur Tabi wrote: > This patch adds the clrsetbits() macro, which is used to set and clear > multiple bits in a single read-modify-write operation. Specify the > bits to > clear in the 'clear' parameter and the bits to set in the 'set' > parameter. > These macro

ppc Floating Point support status

2007-08-22 Thread Ben Buchli
Hello everybody, I was wondering what the status was on supporting floating-point instructions for the mpc8548. I found the suggested patch: http://patchwork.ozlabs.org/linuxppc/patch?order=patch&filter=none&id=9455, but I'm not sure for what kernel version this is and when it will be officia

Re: wmb vs mmiowb

2007-08-22 Thread Jesse Barnes
On Wednesday, August 22, 2007 11:07 am Linus Torvalds wrote: > > It really seems like it is some completely different concept from a > > barrier. And it shows, on the platform where it really matters > > (sn2), where the thing actually spins. > > I agree that it probably isn't a "write barrier" per

Re: 2.6.23-rc3-mm1: kgdb build failure on powerpc

2007-08-22 Thread Andrew Morton
On Wed, 22 Aug 2007 21:04:28 +0200 Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: > Hello, > > Got that on imac g3. > > CC kernel/kgdb.o > kernel/kgdb.c: In function 'kgdb_handle_exception': > kernel/kgdb.c:940: error: invalid lvalue in unary '&' > kernel/kgdb.c:940: warning: type def

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Josh Boyer
On Wed, 22 Aug 2007 10:19:21 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > Guys, > > I was wondering if I could get your help with looking at the > following lists and determining if we have an issue or not related > the following files: > > Getting some classification on these would be good

Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq

2007-08-22 Thread Linas Vepstas
On Wed, Aug 22, 2007 at 07:44:41PM +1000, Paul Mackerras wrote: > Fernando Luis Vázquez Cao writes: > > > amiga_request_irq and mach_request_irq are never used, so delete them. > > OK, but is there a particular reason you want to do this? > > The whole of arch/ppc is going away eventually, so I

Re: wmb vs mmiowb

2007-08-22 Thread Linus Torvalds
On Wed, 22 Aug 2007, Nick Piggin wrote: > > It took me more than a glance to see what the difference is supposed to be > between wmb() and mmiowb(). I think especially because mmiowb isn't really > like a write barrier. Well, it is, but it isn't. Not on its own - but together with a "normal" b

bogus vscsi dt node on iseries

2007-08-22 Thread Olaf Hering
Does anyone know why dt_vdevices() creates a vscsi node on legacy iseries? I'm sure only viodasd and viocd is required as blockdevice type. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[POWERPC] add clrsetbits macros

2007-08-22 Thread Timur Tabi
This patch adds the clrsetbits() macro, which is used to set and clear multiple bits in a single read-modify-write operation. Specify the bits to clear in the 'clear' parameter and the bits to set in the 'set' parameter. These macros can also be used to set a multiple-bit bit pattern using a mask,

git tree, Re: [patch 0/5] (hopefully) final 2.6.23 fixes for cell platform

2007-08-22 Thread Arnd Bergmann
On Wednesday 22 August 2007, Arnd Bergmann wrote: > Hi Paul, > > A few bugs came up on the cell platform when testing on the lastest > prototype version of a future hardware. The first three patches are > all meant to track changes required for the fixes that have gone > into the firmware. Patch 4

Re: [PATCH 05/20] bootwrapper: flatdevtree fixes

2007-08-22 Thread Scott Wood
On Wed, Aug 22, 2007 at 11:09:07AM +1000, David Gibson wrote: > On Tue, Aug 21, 2007 at 11:09:58AM -0500, Scott Wood wrote: > > The point of #2 was as part of the fix to #1 -- otherwise, the same > > check for NULL would have to be moved into ft_create_node to > > conditionally call ft_find_devic

[patch 0/5] (hopefully) final 2.6.23 fixes for cell platform

2007-08-22 Thread Arnd Bergmann
Hi Paul, A few bugs came up on the cell platform when testing on the lastest prototype version of a future hardware. The first three patches are all meant to track changes required for the fixes that have gone into the firmware. Patch 4 is for a bug that showed up during testing, and the final pat

[patch 4/5] axonram: do not delete gendisks queue in error path

2007-08-22 Thread Arnd Bergmann
From: Maxim Shchetynin <[EMAIL PROTECTED]> On exit do not delete gendisk's queue because this is already done by del_gendisk(). Doing it twice may cause memory damage. Signed-off-by: Maximilian <[EMAIL PROTECTED]> Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> --- Index: linux-2.6/arch/powerpc/

[patch 2/5] cell: support pinhole-reset on IBM cell blades

2007-08-22 Thread Arnd Bergmann
From: Arnd Bergmann <[EMAIL PROTECTED]> The Cell Broadband Engine has a method of injecting a system-reset-exception from an external source into the operating system, which should trigger the regular behaviour of entering xmon or kdump. Unfortunately, the exception handler cannot distinguish it f

[patch 1/5] spu_manage: use newer physical-id attribute

2007-08-22 Thread Arnd Bergmann
From: Christian Krafft <[EMAIL PROTECTED]> Legacy device tree used the reg property for the physical id of an spe. On newer device tree layouts the reg property contains the "correct" value in the reg attribute. So there has been intoduced the "physical-id" on newer devicetree layouts. The id is st

[patch 5/5] update cell_defconfig for 2.6.23

2007-08-22 Thread Arnd Bergmann
From: Arnd Bergmann <[EMAIL PROTECTED]> Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> --- Index: linux-2.6/arch/powerpc/configs/cell_defconfig === --- linux-2.6.orig/arch/powerpc/configs/cell_defconfig +++ linux-2.6/arch/powerpc/con

[patch 3/5] Axonram module modification for latest firmware API changes

2007-08-22 Thread Arnd Bergmann
From: Maxim Shchetynin <[EMAIL PROTECTED]> Firmware would not deliver two interrupt numbers in device-tree any more but only one, for correctable ECC, because uncorrectable ECC from now handles firmware itself. Changes in the axonram module are necessary because in the old version, if it is not al

Re: How to port PReP to arch/powerpc?

2007-08-22 Thread Josh Boyer
On Wed, 22 Aug 2007 10:27:16 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > On Wed, Aug 22, 2007 at 11:19:34AM -0500, Linas Vepstas wrote: > > On Wed, Aug 22, 2007 at 07:29:56AM -0500, Josh Boyer wrote: > > > > > > David Gibson and Rob Landley had a quite interesting discussion about > > > PRe

Re: How to port PReP to arch/powerpc?

2007-08-22 Thread Olof Johansson
On Wed, Aug 22, 2007 at 11:19:34AM -0500, Linas Vepstas wrote: > On Wed, Aug 22, 2007 at 07:29:56AM -0500, Josh Boyer wrote: > > > > David Gibson and Rob Landley had a quite interesting discussion about > > PReP last night on IRC. > > ?? Where? I scrolled back on #ppc64 on freenode, and see no s

Re: How to port PReP to arch/powerpc?

2007-08-22 Thread Linas Vepstas
On Wed, Aug 22, 2007 at 07:29:56AM -0500, Josh Boyer wrote: > > David Gibson and Rob Landley had a quite interesting discussion about > PReP last night on IRC. ?? Where? I scrolled back on #ppc64 on freenode, and see no such conversation. --linas ___

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Scott Wood
On Wed, Aug 22, 2007 at 10:19:21AM -0500, Kumar Gala wrote: > ./drivers/mtd/maps/tqm834x.c:#include > ./drivers/mtd/maps/pq2fads.c:#include These use the bd_t, and thus will only work on arch/ppc. On arch/powerpc, we can use the device tree to specify the mapping. -Scott __

asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
Guys, I was wondering if I could get your help with looking at the following lists and determining if we have an issue or not related the following files: Getting some classification on these would be good. Possibly classifications, doesn't build in ARCH=powerpc, remove include, real iss

Re: [PATCH v6 0/2] SPI support for fsl_soc and mpc832x_rdb

2007-08-22 Thread Anton Vorontsov
On Wed, Aug 22, 2007 at 10:01:13AM -0500, Kumar Gala wrote: > > On Aug 22, 2007, at 9:54 AM, Anton Vorontsov wrote: > >> On Wed, Aug 22, 2007 at 09:22:47AM -0500, Kumar Gala wrote: >>> >>> On Aug 21, 2007, at 10:27 AM, Anton Vorontsov wrote: >>> On Tue, Aug 21, 2007 at 05:45:37PM +0400, Anton

[PATCH] [10/10] pasemi_mac: Clean TX ring in poll

2007-08-22 Thread Olof Johansson
Unfortunately there's no timeout for how long a packet can sit on the TX ring after completion before an interrupt is generated, and we want to have a threshold that's larger than one packet per interrupt. So we have to have a timer that occasionally cleans the TX ring even though there hasn't bee

[PATCH] [09/10] pasemi_mac: Fix RX checksum flags

2007-08-22 Thread Olof Johansson
RX side flag to use is CHECKSUM_UNNECESSARY, not CHECKSUM_COMPLETE. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ mainline/drivers/net/pa

[PATCH] [08/10] pasemi_mac: Fix TX ring wrap checking

2007-08-22 Thread Olof Johansson
The old logic didn't detect full (tx) ring cases properly, causing overruns and general badness. Clean it up a bit and abstract out the ring size checks, always making sure to leave 1 slot open. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c ==

[PATCH] [07/10] pasemi_mac: Enable LLTX

2007-08-22 Thread Olof Johansson
Enable LLTX on pasemi_mac: we're already doing sufficient locking in the driver to enable it. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c

[PATCH] [06/10] pasemi_mac: Batch up TX buffer frees

2007-08-22 Thread Olof Johansson
Postpone pci unmap and skb free of the transmitted buffers to outside of the tx ring lock, batching them up 32 at a time. Also increase the count threshold to 128. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c =

[PATCH] [05/10] pasemi_mac: RX performance tweaks

2007-08-22 Thread Olof Johansson
Various RX performance tweaks, do some explicit prefetching of packet data, etc. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ mainline/d

[PATCH] [04/10] pasemi_mac: Fix memcpy amount for short receives

2007-08-22 Thread Olof Johansson
Fix up memcpy for short receives. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ mainline/drivers/net/pasemi_mac.c @@ -516,9 +516,7 @@ st

[PATCH] [03/10] pasemi_mac: Enable L2 caching of packet headers

2007-08-22 Thread Olof Johansson
Enable settings to target l2 for the first few cachelines of the packet, since we'll access them to get to the various headers. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- main

[PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-22 Thread Olof Johansson
Move away from using the pci config access functions for simple register access. Our device has all of the registers in the config space (hey, from the hardware point of view it looks reasonable :-), so we need to somehow get to it. Newer firmwares have it in the device tree such that we can just

[PATCH] [01/10] pasemi_mac: Abstract out register access

2007-08-22 Thread Olof Johansson
Abstract out the PCI config read/write accesses into reg read/write ones, still calling the pci accessors on the back end. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.o

[PATCH] [00/10] pasemi_mac patches for 2.6.24

2007-08-22 Thread Olof Johansson
Hi, pasemi_mac patches for 2.6.24: 01/10: pasemi_mac: Abstract out register access 02/10: pasemi_mac: Stop using the pci config space accessors for register read/writes 03/10: pasemi_mac: Enable L2 caching of packet headers 04/10: pasemi_mac: Fix memcpy amount for short receives 05/10: pasemi_ma

Re: [PATCH v6 0/2] SPI support for fsl_soc and mpc832x_rdb

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 9:54 AM, Anton Vorontsov wrote: > On Wed, Aug 22, 2007 at 09:22:47AM -0500, Kumar Gala wrote: >> >> On Aug 21, 2007, at 10:27 AM, Anton Vorontsov wrote: >> >>> On Tue, Aug 21, 2007 at 05:45:37PM +0400, Anton Vorontsov wrote: Hi all, Thanks for the previous revie

Re: Patches added to powerpc.git for-2.6.24 branch

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 8:25 AM, Kumar Gala wrote: > How do we want to handle the include cleanup I've got. > > I know you'd like some way of showing it complete. Any ideas? So I did the following: 1. generate a file listing of asm-powerpc vs asm-ppc and diff them to find all files in asm-ppc no

[PATCH v6 2/2] [POWERPC] MPC832x_RDB: update dts to use SPI1 in QE, register mmc_spi stub

2007-08-22 Thread Anton Vorontsov
mmc_spi already tested to work. When it will hit mainline the only change that will be needed is replacing "spidev" with "mmc_spi". Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc832x_rdb.dts |2 +- arch/powerpc/platforms/83xx/mpc832x_rdb.c | 50

[PATCH v6 1/2] [POWERPC] fsl_soc: add support for fsl_spi

2007-08-22 Thread Anton Vorontsov
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c | 81 + arch/powerpc/sysdev/fsl_soc.h |7 2 files changed, 88 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_

[PATCH 4/4] ehea: show physical port state

2007-08-22 Thread Jan-Bernd Themann
Introduces a module parameter to decide whether the physical port link state is propagated to the network stack or not. It makes sense not to take the physical port state into account on machines with more logical partitions that communicate with each other. This is always possible no matter what t

[PATCH v6 0/2] SPI support for fsl_soc and mpc832x_rdb

2007-08-22 Thread Anton Vorontsov
On Wed, Aug 22, 2007 at 09:22:47AM -0500, Kumar Gala wrote: > > On Aug 21, 2007, at 10:27 AM, Anton Vorontsov wrote: > >> On Tue, Aug 21, 2007 at 05:45:37PM +0400, Anton Vorontsov wrote: >>> Hi all, >>> >>> Thanks for the previous reviews, this is v4 against Linus' tree, >>> as of today. >> >> Okay

[PATCH 3/4] ehea: fix queue destructor

2007-08-22 Thread Jan-Bernd Themann
Includes hcp_epas_dtor in eq/cq/qp destructors to unmap HW register. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_qmr.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/ehea/ehea_qmr.c b/drivers/net/ehea/ehea_qmr.c index

[PATCH 2/4] ehea: fix module parameter description

2007-08-22 Thread Jan-Bernd Themann
Update the module parameter description of "use_mcs" to show correct default value Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_

[PATCH 1/4] ehea: fix interface to DLPAR tools

2007-08-22 Thread Jan-Bernd Themann
Userspace DLPAR tool expects decimal numbers to be written to and read from sysfs entries. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ehea/ehea_main.c b/drivers/n

Re: RFC: [PATCH v2] Fixup modpost warnings in head*.S for ppc32

2007-08-22 Thread Josh Boyer
On Wed, 22 Aug 2007 09:08:31 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Aug 22, 2007, at 9:03 AM, Josh Boyer wrote: > > > On Wed, 22 Aug 2007 08:58:31 -0500 (CDT) > > Kumar Gala <[EMAIL PROTECTED]> wrote: > > > >> Addess the following modpost warnings we get out of the ppc32 head > >> fi

Re: [PATCH v5 2/2] [POWERPC] MPC832x_RDB: update dts to use SPI1 in QE, register mmc_spi stub

2007-08-22 Thread Kumar Gala
On Aug 21, 2007, at 10:29 AM, Anton Vorontsov wrote: > mmc_spi already tested to work. When it will hit mainline > the only change that will be needed is replacing "spidev" > with "mmc_spi". > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc832x_rdb.dts

Re: Patches added to powerpc.git for-2.6.24 branch

2007-08-22 Thread Timur Tabi
Kumar Gala wrote: > I think the clrsetbits macros needs some further cleanup. I think > Stephen mentioned doing something like we do for DEF_MMIO_OUT_BE() to > only have one 'actual' macro. Yeah I saw that one, but on IRC a few people said they don't like ##, so I decided against it. Are you

Re: [PATCH v5 1/2] [POWERPC] fsl_soc: add support for fsl_spi

2007-08-22 Thread Kumar Gala
On Aug 21, 2007, at 10:29 AM, Anton Vorontsov wrote: > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- > arch/powerpc/sysdev/fsl_soc.c | 84 ++ > +++ > arch/powerpc/sysdev/fsl_soc.h |7 +++ > 2 files changed, 91 insertions(+), 0 deletions(-) >

Re: [PATCH v5 0/2] SPI support for fsl_soc and mpc832x_rdb

2007-08-22 Thread Kumar Gala
On Aug 21, 2007, at 10:27 AM, Anton Vorontsov wrote: > On Tue, Aug 21, 2007 at 05:45:37PM +0400, Anton Vorontsov wrote: >> Hi all, >> >> Thanks for the previous reviews, this is v4 against Linus' tree, >> as of today. > > Okay, here is brand-new, shiny v5. Today and only today it comes > without

Re: RFC: [PATCH v2] Fixup modpost warnings in head*.S for ppc32

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 9:03 AM, Josh Boyer wrote: > On Wed, 22 Aug 2007 08:58:31 -0500 (CDT) > Kumar Gala <[EMAIL PROTECTED]> wrote: > >> Addess the following modpost warnings we get out of the ppc32 head >> files: >> >> WARNING: vmlinux.o(.text+0x358): Section mismatch: reference >> to .init.text

  1   2   >