[PATCH] powerpc: Fix size check for hugetlbfs

2007-08-07 Thread Benjamin Herrenschmidt
My "slices" address space management code that was added in 2.6.22 implementation of get_unmapped_area() doesn't properly check that the size is a multiple of the requested page size. This allows userland to create VMAs that aren't a multiple of the huge page size with hugetlbfs (since hugetlbfs en

Re: Device tree aware EMAC driver

2007-08-07 Thread David Gibson
On Wed, Aug 08, 2007 at 01:16:43PM +1000, Tony Breeds wrote: > On Tue, Aug 07, 2007 at 04:22:31PM +1000, David Gibson wrote: > > Based on BenH's earlier work, this is a new version of the EMAC driver > > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > > same ASIC is also found

[patch 3/3] PS3: Update ps3_defconfig

2007-08-07 Thread geoffrey . levand
Update ps3_defconfig. Signed-off-by: Geoff Levand <[EMAIL PROTECTED]> --- arch/powerpc/configs/ps3_defconfig | 200 - 1 file changed, 65 insertions(+), 135 deletions(-) --- a/arch/powerpc/configs/ps3_defconfig +++ b/arch/powerpc/configs/ps3_defconfig @@ -1,9

[patch 1/3] PS3: Fix storage probe logic

2007-08-07 Thread geoffrey . levand
From: Geert Uytterhoeven <[EMAIL PROTECTED]> Fix the PS3 storage probe logic to properly find device regions on cold startup. o Change the storage probe event mask from notify_device_ready to notify_region_update. o Improve the storage probe error handling. o Change ps3_storage_wait_for_dev

[patch 2/3] PS3: Remove incomplete message

2007-08-07 Thread geoffrey . levand
Remove the Kconfig message that indicates the PS3 platform support is incomplete. Signed-off-by: Geoff Levand <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/arch/powerpc/platforms/ps3/Kconfig +++ b/arch/powerpc/

[patch 0/3] PS3 bugfix patches for 2.6.23

2007-08-07 Thread geoffrey . levand
Hi Paul, This small set of PS3 bugfix patches for 2.6.23. [patch 1/3] PS3: Fix storage probe logic [patch 2/3] PS3: Remove incomplete message [patch 3/3] PS3: Update ps3_defconfig Patch 1 fixes a cold startup timing bug in the hard disk probe logic. Patch 2 removes the 'incomplete' messag

Re: Device tree aware EMAC driver

2007-08-07 Thread Tony Breeds
On Tue, Aug 07, 2007 at 04:22:31PM +1000, David Gibson wrote: > Based on BenH's earlier work, this is a new version of the EMAC driver > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > same ASIC is also found in the Axon bridge chip. This new version is > designed to work in t

Re: [patch 04/10] 4xx bootwrapper reworks

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 08:10:38AM -0500, Josh Boyer wrote: > On Tue, 7 Aug 2007 13:05:47 +1000 > David Gibson <[EMAIL PROTECTED]> wrote: > > > > > Rather than just removing these defines and using hardcoded values, > > > > I'd prefer to see separate SPRN_DBCR0_40X and SPRN_DBCR0_44X defines. > >

Re: [PATCH] Remove dtc build cruft from DTS files

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 12:28:48PM -0500, Josh Boyer wrote: > The patch below removes the dtc incantation instructions from the > in-kernel DTS files. It's not needed, and is prone to being > out-of-date most of the time. > > Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> Acked-by: David Gibson <

Re: Device tree aware EMAC driver

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 07:15:39AM -0500, Josh Boyer wrote: > On Tue, 7 Aug 2007 16:22:31 +1000 > David Gibson <[EMAIL PROTECTED]> wrote: > > > Based on BenH's earlier work, this is a new version of the EMAC driver > > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > > same ASI

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 06:33:01PM +0200, Segher Boessenkool wrote: > > Yeah, better names please -- if possible, something that someone > > without knowledge of this SoC will understand what it is. > > I think the names are probably ok - I'm assuming they're in keeping > wit

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 06:51:04PM +0200, Segher Boessenkool wrote: > >> address-permutation = <0 1 3 2 4 5 7 6 e f d c a b 9 8>; > > > > Yes, I was contemplating something like that. > > Let's not define this until we need it though :-) Indeed. > >> I haven't heard or thought of anything better

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 06:58:20PM +0200, Segher Boessenkool wrote: > >> Most characters are allowed in the unit-address... The following > >> is just fine: "[EMAIL PROTECTED]". ISA uses letters to > >> distinguish between its different address spaces, for example. > > > > Yeah, I should probably

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 06:43:35PM +0200, Segher Boessenkool wrote: > >>> Aha! Ok, now I understand the sorts of situations you're talking > >>> about. By "not direct mapped", I thought you were talking about some > >>> kind of access via address/data registers on some indirect bus > >>> controll

[PATCH] turn on icplus phy in mpc8323rdb defconfig

2007-08-07 Thread Kim Phillips
support for the MPC8323E RDB's ICPlus PHY was recently added to the kernel, so now we can have it turned on by default. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- arch/powerpc/configs/mpc832x_rdb_defconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powe

[PATCH] powerpc: fix i2c device string format

2007-08-07 Thread Guennadi Liakhovetski
On Wed, 1 Aug 2007, Segher Boessenkool wrote: > strncpy() won't put a terminating zero on there, is everything > that uses the resulting string okay with that? Also, if the > name gets cut short, it might match some _other_ expected name. On Wed, 1 Aug 2007, Scott Wood wrote: > You could use st

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Jeff Garzik wrote: >> Brian King wrote: >>> This patch adds the appropriate ethtool hooks to allow for >>> enabling/disabling >>> of hypervisor assisted checksum offload for TCP. >>> >>> Signed-off-by: Brian King <[EMAIL PROTECTED]> >>> --- >>> >>> linux-2.6-bjking1/drivers/ne

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Brian King
Jeff Garzik wrote: > Brian King wrote: >> This patch adds the appropriate ethtool hooks to allow for enabling/disabling >> of hypervisor assisted checksum offload for TCP. >> >> Signed-off-by: Brian King <[EMAIL PROTECTED]> >> --- >> >> linux-2.6-bjking1/drivers/net/ibmveth.c | 118 >> ++

Re: [PATCH 6/6] ibmveth: Remove use of bitfields

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Removes the use of bitfields from the ibmveth driver. This results > in slightly smaller object code. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c | 90 > > linux-2.6-bjking1/drivers/ne

Re: [PATCH 4/6] ibmveth: Add ethtool driver stats hooks

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Add ethtool hooks to ibmveth to retrieve driver statistics. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > drivers/net/ibmveth.c | 53 > +- > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff -puN drivers

Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers

2007-08-07 Thread Jeff Garzik
Brian King wrote: > Add handlers for get_tso and get_ufo to prevent errors being printed > by ethtool. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > drivers/net/ibmveth.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff -puN drivers/net/ibmveth.c~ibmveth_etht

Re: [PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: > This patch adds the appropriate ethtool hooks to allow for enabling/disabling > of hypervisor assisted checksum offload for TCP. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c | 118 > +++- > l

Re: [PATCH 1/6] ibmveth: Enable TCP checksum offload

2007-08-07 Thread Jeff Garzik
Brian King wrote: > This patchset enables TCP checksum offload support for IPV4 > on ibmveth. This completely eliminates the generation and checking of > the checksum for packets that are completely virtual and never > touch a physical network. A simple TCP_STREAM netperf run on > a virtual network

Re: [RESEND][PATCH 1/3] ehea: Fix workqueue handling

2007-08-07 Thread Jeff Garzik
Thomas Klein wrote: > Fix: Workqueue ehea_driver_wq was not destroyed > > Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> > > --- > drivers/net/ehea/ehea.h |2 +- > drivers/net/ehea/ehea_main.c |1 + > 2 files changed, 2 insertions(+), 1 deletions(-) applied 1-3 to #upstream-fixes

[PATCH] Remove dtc build cruft from DTS files

2007-08-07 Thread Josh Boyer
The patch below removes the dtc incantation instructions from the in-kernel DTS files. It's not needed, and is prone to being out-of-date most of the time. Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> diff --git a/arch/powerpc/boot/dts/ebony.dts b/arch/powerpc/boot/dts/ebony.dts index c5f9961..

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread Segher Boessenkool
>> It would be possible, I guess, to define a 'swizzled-ranges' property >> or something which allows child devices to be embedded in the parent's >> address range in a not-direct way. However, the swizzling on the >> flash bank is really a property of the flash bank, not of the parent >> bus - re

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread Segher Boessenkool
>> Most characters are allowed in the unit-address... The following >> is just fine: "[EMAIL PROTECTED]". ISA uses letters to >> distinguish between its different address spaces, for example. > > Yeah, I should probably make dtc a bit more flexible about accepting > that, too. At present, it onl

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread Segher Boessenkool
>> address-permutation = <0 1 3 2 4 5 7 6 e f d c a b 9 8>; > > Yes, I was contemplating something like that. Let's not define this until we need it though :-) >> I haven't heard or thought of anything better either. Using "ranges" >> is conceptually wrong, even ignoring the technical problems t

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread Segher Boessenkool
>>> Aha! Ok, now I understand the sorts of situations you're talking >>> about. By "not direct mapped", I thought you were talking about some >>> kind of access via address/data registers on some indirect bus >>> controller, rather than weird variations on endianness and >>> bit-swizzling. >> >>

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread Segher Boessenkool
> Yeah, better names please -- if possible, something that someone > without knowledge of this SoC will understand what it is. I think the names are probably ok - I'm assuming they're in keeping with the convention I've used of using the same names / abbreviations

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-07 Thread Matt Sealey
Okay, you don't need to be an experienced Open Firmware developer. In fact I know we have had experienced Open Firmware developers who have said that our firmware sucks (some comment about "shitty German engineering", I really did quit caring after that point) because they could not run probe-all

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-07 Thread Matt Sealey
Segher Boessenkool wrote: > > That's hardly the only reason. But yeah, that's one way to > implement the workaround, but _we_ (the Linux community) cannot > do it like that (easily) for all users. But you're the guy who told us our firmware sucks and we should fix our firmware rather than clutt

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-07 Thread Segher Boessenkool
The hardware should be described in the device tree. This isn't the same as simply copying all your Linux code into it ;-) >>> >>> Ugh. SD/MMC slot is the hardware, isn't it? It have wired SPI pins, >>> and chip select pin. To set up this pin, I need mmc node, which means >>> that I can'

Re: [PATCH 2/6] PowerPC 440EPx: Sequoia DTS

2007-08-07 Thread Scott Wood
On Tue, Aug 07, 2007 at 01:28:06PM +1000, David Gibson wrote: > It would be possible, I guess, to define a 'swizzled-ranges' property > or something which allows child devices to be embedded in the parent's > address range in a not-direct way. However, the swizzling on the > flash bank is really a

Re: pci in arch/powerpc vs arch/ppc

2007-08-07 Thread Scott Wood
Alexandros Kostopoulos wrote: > Except from some macros arch/powerpc/include/asm/io.h / mpc8260_pci9.h, > I can seem to find anywhere the code regarding PCI Erratum 9. The > defined macros(in io.h) for read/write are sufficient as a workaround > for PCI9? Who does DMA and register initializat

Re: [patch 08/10] Bamboo DTS

2007-08-07 Thread Josh Boyer
On Mon, 6 Aug 2007 14:53:32 +1000 David Gibson <[EMAIL PROTECTED]> wrote: > On Fri, Aug 03, 2007 at 11:09:08AM -0500, Josh Boyer wrote: > > AMCC Bamboo board DTS > > All the compatible properties should have "-440ep" as the most > precise version, in addition to the more general strings. Don

Re: [patch 04/10] 4xx bootwrapper reworks

2007-08-07 Thread Josh Boyer
On Tue, 7 Aug 2007 13:05:47 +1000 David Gibson <[EMAIL PROTECTED]> wrote: > > > Rather than just removing these defines and using hardcoded values, > > > I'd prefer to see separate SPRN_DBCR0_40X and SPRN_DBCR0_44X defines. > > > > Ok. And place them where? In the same file since they aren't DC

Re: Device tree aware EMAC driver

2007-08-07 Thread Josh Boyer
On Tue, 7 Aug 2007 16:22:31 +1000 David Gibson <[EMAIL PROTECTED]> wrote: > Based on BenH's earlier work, this is a new version of the EMAC driver > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > same ASIC is also found in the Axon bridge chip. This new version is > designed

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-08-07 Thread Anton Vorontsov
On Mon, Aug 06, 2007 at 08:18:47PM +0200, Segher Boessenkool wrote: [...] >>> The hardware should be described in the device tree. This isn't >>> the same as simply copying all your Linux code into it ;-) >> >> Ugh. SD/MMC slot is the hardware, isn't it? It have wired SPI pins, >> and chip select

Re: pci in arch/powerpc vs arch/ppc

2007-08-07 Thread Alexandros Kostopoulos
Except from some macros arch/powerpc/include/asm/io.h / mpc8260_pci9.h, I can seem to find anywhere the code regarding PCI Erratum 9. The defined macros(in io.h) for read/write are sufficient as a workaround for PCI9? Who does DMA and register initialization for this (it used to be done in