Brian King wrote:
> Add handlers for get_tso and get_ufo to prevent errors being printed
> by ethtool.
> 
> Signed-off-by: Brian King <[EMAIL PROTECTED]>
> ---
> 
>  drivers/net/ibmveth.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers/net/ibmveth.c
> --- linux-2.6/drivers/net/ibmveth.c~ibmveth_ethtool_get_tso   2007-07-19 
> 11:18:38.000000000 -0500
> +++ linux-2.6-bjking1/drivers/net/ibmveth.c   2007-07-19 11:18:38.000000000 
> -0500
> @@ -759,7 +759,9 @@ static const struct ethtool_ops netdev_e
>       .get_tx_csum            = ethtool_op_get_tx_csum,
>       .set_tx_csum            = ibmveth_set_tx_csum,
>       .get_rx_csum            = ibmveth_get_rx_csum,
> -     .set_rx_csum            = ibmveth_set_rx_csum
> +     .set_rx_csum            = ibmveth_set_rx_csum,
> +     .get_tso                        = ethtool_op_get_tso,
> +     .get_ufo                        = ethtool_op_get_ufo

ACK, once you add a comma to the end of the final initializer

As you see from this patch, the practice of -not- having commas at the 
end of a list of struct initializers is not patch-friendly, since you 
must touch an unrelated line each time you patch the end of the struct. 
  For named initializers particularly, the lack of a comma is even more 
useless.

So, it might tweak some C perfectionists, but adding that 
seemingly-useless comma at the end of the last entry reduces maintenance 
headache and makes patch reviews slightly more clear.

        Jeff



_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to