Re: [ofa-general] [PATCH 5/5] ehca: Support small QP queues

2007-07-20 Thread Roland Dreier
thanks, applied. I fixed this up myself to work with commit 20c2df83, which got rid of the destructor argument to kmem_cache_create() -- you probably want to check my tree to make sure it's OK. Also the same as I said before about checkpatch.pl's warning: WARNING: externs should be avoided in .c

Re: [PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Roland Dreier
thanks, applied ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-20 Thread Roland Dreier
thanks, applied. BTW, does your SRQ-capable hardware support generating the "last WQE reached" event? There's not any reliable way to avoid problems when destroying QPs attached to an SRQ without it, and the IB spec requires CAs that support SRQs to generate it (o11-5.2.5 in chapter 11 of vol 1).

Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs

2007-07-20 Thread Roland Dreier
I applied this, but I agree with checkpatch.pl: > WARNING: externs should be avoided in .c files > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: > +extern int ehca_mr_largepage; > > WARNING: externs should be avoided in .c files > #949: FILE: drivers/infiniband/hw/ehca/hcp_if.c:753

Re: [PATCH] powerpc: mpic protected sources

2007-07-20 Thread Arnd Bergmann
On Saturday 21 July 2007, Benjamin Herrenschmidt wrote: > 0% probability of being spam. > > Full report: > No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham > version=3.1.7-deb   > Some HW platforms, such as the new cell blades, requires some MPIC sources > to be left alone by the ope

[PATCH] powerpc: mpic protected sources

2007-07-20 Thread Benjamin Herrenschmidt
Some HW platforms, such as the new cell blades, requires some MPIC sources to be left alone by the operating system. This patch implements support for a "protected-sources" property in the mpic controller node containing a list of source numbers to be protected against operating system interference

Re: [PATCH v3] pcmcia: CompactFlash driver for PA Semi Electra boards

2007-07-20 Thread Andrew Morton
On Thu, 5 Jul 2007 09:49:14 -0500 [EMAIL PROTECTED] (Olof Johansson) wrote: > Driver for the CompactFlash slot on the PA Semi Electra eval board. It's > a simple device sitting on localbus, with interrupts and detect/voltage > control over GPIO. > > The driver is implemented as an of_platform dri

Re: [PATCH 5/6 v2] 85xxCDS: Misc 8548 PCI Corrections.

2007-07-20 Thread Randy Vinson
>From 57501bb79c2d5212c02766a32685d415cc74a4ab Mon Sep 17 00:00:00 2001 From: Randy Vinson <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 10:40:53 -0700 Subject: [PATCH] 85xxCDS: Misc 8548 PCI Corrections. Setting the host bridge @8000 as primary. Also fixing a bug in setting the USB interrupt numbers

Re: [PATCH 5/6] 85xxCDS: Misc 8548 PCI Corrections.

2007-07-20 Thread Randy Vinson
Kumar Gala wrote: > > On Jul 20, 2007, at 1:56 PM, Randy Vinson wrote: > >>> From cf18185b4e201ff45f2e2a948103dd3dc088c046 Mon Sep 17 00:00:00 2001 >> From: Randy Vinson <[EMAIL PROTECTED]> >> Date: Thu, 19 Jul 2007 10:40:53 -0700 >> Subject: [PATCH] 85xxCDS: Misc 8548 PCI Corrections. >> >> Sett

Re: [PATCH 5/6] 85xxCDS: Misc 8548 PCI Corrections.

2007-07-20 Thread Kumar Gala
On Jul 20, 2007, at 1:56 PM, Randy Vinson wrote: >> From cf18185b4e201ff45f2e2a948103dd3dc088c046 Mon Sep 17 00:00:00 >> 2001 > From: Randy Vinson <[EMAIL PROTECTED]> > Date: Thu, 19 Jul 2007 10:40:53 -0700 > Subject: [PATCH] 85xxCDS: Misc 8548 PCI Corrections. > > Setting the host bridge @8000

Re: [PATCH 1/2] OProfile - Enable SPU switch notification to detect currently active SPU tasks - update

2007-07-20 Thread Arnd Bergmann
On Friday 20 July 2007, Andrew Morton wrote: > +   for_each_online_node(node) { > struct spu *spu; > mutex_lock(&spu_prio->active_mutex[node]); > list_for_each_entry(spu, &spu_prio->active_list[node], list) { > struct spu_c

Please pull for-2.6.23 branch of cell-2.6.git

2007-07-20 Thread Arnd Bergmann
Hi Linus, Please pull from master.kernel.org:/pub/scm/linux/kernel/git/arnd/cell-2.6.git for-2.6.23 This is a number of changes that fell through the cracks because it wasn't clear how we were going to merge it in the absence of paulus. Mostly bug fixes, except a few features that should

Re: [PATCH] powerpc: Add of_register_i2c_devices()

2007-07-20 Thread Guennadi Liakhovetski
On Fri, 20 Jul 2007, Segher Boessenkool wrote: > > + strncpy(info->driver_name, i2c_devices[i].i2c_driver, > > KOBJ_NAME_LEN); > > + strncpy(info->type, i2c_devices[i].i2c_type, I2C_NAME_SIZE); > > Why not just strcpy(), btw? Because target strings are finite length, and sour

Re: [PATCH 04/14] spufs: add spu stats in sysfs and ctx stat file in spufs

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 21:29:20 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Friday 20 July 2007, Andrew Morton wrote: > > > > I think it's better if you do it, please - I'm not doing anything useful > > here. > > Ok, I'm giving it some final testing, then send out the pull request. > > Do

Re: [PATCH 04/14] spufs: add spu stats in sysfs and ctx stat file in spufs

2007-07-20 Thread Arnd Bergmann
On Friday 20 July 2007, Andrew Morton wrote: > > I think it's better if you do it, please - I'm not doing anything useful > here. Ok, I'm giving it some final testing, then send out the pull request. Do you also want me to handle the ps3 drivers? I think I'd prefer to leave those to you if you d

Re: [PATCH 1/2] OProfile - Enable SPU switch notification to detect currently active SPU tasks - update

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 14:24:07 -0500 Bob Nelson <[EMAIL PROTECTED]> wrote: > From: Maynard Johnson <[EMAIL PROTECTED]> > > This patch adds to the capability of spu_switch_event_register so that > the caller is also notified of currently active SPU tasks. > Exports spu_switch_event_register and spu_

Re: [PATCH 04/14] spufs: add spu stats in sysfs and ctx stat file in spufs

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 20:59:25 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Friday 20 July 2007, Andrew Morton wrote: > > And what's up with all these powerpc people sending out patchbombs after > > the merge window has opened? __Formally, _all_ of this: > > > ... > > > > should be pushed b

Re: [PATCH 04/14] spufs: add spu stats in sysfs and ctx stat file in spufs

2007-07-20 Thread Arnd Bergmann
On Friday 20 July 2007, Andrew Morton wrote: > And what's up with all these powerpc people sending out patchbombs after > the merge window has opened?  Formally, _all_ of this: > ... > > should be pushed back into 2.6.24 because it all arrived too late. > > I guess you're all doing that to Paul

Re: [PATCH 04/14] spufs: add spu stats in sysfs and ctx stat file in spufs

2007-07-20 Thread Arnd Bergmann
On Friday 20 July 2007, Andrew Morton wrote: > And what's up with all these powerpc people sending out patchbombs after > the merge window has opened?  Formally, _all_ of this: > ... > > should be pushed back into 2.6.24 because it all arrived too late. > > I guess you're all doing that to Paul

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: > > On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > >> On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > >> > Hi Geert, > >> > > >> > On 7/20/07, Geert Uytterh

[PATCH 1/2] OProfile - Enable SPU switch notification to detect currently active SPU tasks - update

2007-07-20 Thread Bob Nelson
From: Maynard Johnson <[EMAIL PROTECTED]> This patch adds to the capability of spu_switch_event_register so that the caller is also notified of currently active SPU tasks. Exports spu_switch_event_register and spu_switch_event_unregister so that OProfile can get access to the notifications provide

Re: [PATCH 6/6] 85xxCDS: MPC8548 DTS cleanup.

2007-07-20 Thread Scott Wood
Randy Vinson wrote: > diff --git a/arch/powerpc/boot/dts/mpc8548cds.dts > b/arch/powerpc/boot/dts/mpc8548cds.dts > index c241e4f..2c6fd63 100644 > --- a/arch/powerpc/boot/dts/mpc8548cds.dts > +++ b/arch/powerpc/boot/dts/mpc8548cds.dts > @@ -44,8 +44,14 @@ > #size-cells = <1>; >

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: > On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: >> On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: >> > Hi Geert, >> > >> > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> >> From: Geert Uytterhoeven

[PATCH 6/6] 85xxCDS: MPC8548 DTS cleanup.

2007-07-20 Thread Randy Vinson
>From 5d2f1e916b0a88538370f93e8c58691ba3a57d92 Mon Sep 17 00:00:00 2001 From: Randy Vinson <[EMAIL PROTECTED]> Date: Tue, 17 Jul 2007 16:37:12 -0700 Subject: [PATCH] 85xxCDS: MPC8548 DTS cleanup. Added the P2P bridge present on the Arcadia base board and moved the VIA Southbridge behind the bridge

[PATCH 5/6] 85xxCDS: Misc 8548 PCI Corrections.

2007-07-20 Thread Randy Vinson
>From cf18185b4e201ff45f2e2a948103dd3dc088c046 Mon Sep 17 00:00:00 2001 From: Randy Vinson <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 10:40:53 -0700 Subject: [PATCH] 85xxCDS: Misc 8548 PCI Corrections. Setting the host bridge @8000 as primary and only calling setup_pci_atmu for the PCI Express hos

[PATCH 4/6] 85xxCDS: Delay 8259 cascade hookup.

2007-07-20 Thread Randy Vinson
>From d51ad0776259dea5402e3ba380e208ef735289eb Mon Sep 17 00:00:00 2001 From: Randy Vinson <[EMAIL PROTECTED]> Date: Thu, 14 Jun 2007 11:02:54 -0700 Subject: [PATCH] 85xxCDS: Delay 8259 cascade hookup. The interrupts of an E100 card inserted in PCI slot 4 may be on at bootup. The resulting interru

[PATCH 3/6] 85xxCDS: Make sure restart resets the PCI bus.

2007-07-20 Thread Randy Vinson
>From 5397a82c878055ead34070993acd89dd0d824a52 Mon Sep 17 00:00:00 2001 From: Randy Vinson <[EMAIL PROTECTED](none)> Date: Fri, 23 Mar 2007 15:43:37 -0700 Subject: [PATCH] 85xxCDS: Make sure restart resets the PCI bus. The current 85xxCDS restart code fails to reset the PCI bus which can lead to o

[PATCH 2/6] 85xxCDS: Allow 8259 cascade to share an MPIC interrupt line.

2007-07-20 Thread Randy Vinson
>From c9e25f41ca444d77f5527c1442550e70c46b9383 Mon Sep 17 00:00:00 2001 From: Randy Vinson <[EMAIL PROTECTED]> Date: Wed, 6 Jun 2007 16:26:15 -0700 Subject: [PATCH] 85xxCDS: Allow 8259 cascade to share an MPIC interrupt line. The Freescale MPC8555CDS and MPC8548CDS reference hardware has a legacy

[PATCH 1/6] 85xxCDS: Skip the fake PCI bridge (FPGA)

2007-07-20 Thread Randy Vinson
>From 83bfbe730b1fad2ac9b22d33990e7378d920e844 Mon Sep 17 00:00:00 2001 From: Randy Vinson <[EMAIL PROTECTED]> Date: Fri, 20 Jul 2007 11:18:26 -0700 Subject: [PATCH] 85xxCDS: Skip the fake PCI bridge (FPGA) The 85xxCDS has an FPGA that incorrectly appears as a PCI-to-PCI bridge. This patch adds a

[PATCH 0/6] 85xxCDS: MPC8548CDS Updates and Bug Fixes

2007-07-20 Thread Randy Vinson
Greetings, This patch series contains updates to the MPC8548CDS DTS and fixes several PCI-related bugs. I'm not 100% sure the DTS changes are in the proper form, so I'd appreciate any corrections. Note that some of these patches have been posted previously. These patches are based on Kumar's for

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > > Hi Geert, > > > > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> > >> > >> m68k/mac: Make mac_hid_mouse_emulate_butt

Re: [PATCH 04/14] spufs: add spu stats in sysfs and ctx stat file in spufs

2007-07-20 Thread Scott Wood
Andrew Morton wrote: > And what's up with all these powerpc people sending out patchbombs after > the merge window has opened? Formally, _all_ of this: I can't speak for the ones you listed, but in my case, I had people asking about the patches and posting conflicting things, so I wanted to get

Re: [PATCH 04/14] spufs: add spu stats in sysfs and ctx stat file in spufs

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 15:21:15 +1000 Jeremy Kerr <[EMAIL PROTECTED]> wrote: > This patch exports per-context statistics in spufs as long as spu > statistics in sysfs. > > It was formed by merging: > "spufs: add spu stats in sysfs" From: Christoph Hellwig > "spufs: add stat file to spufs" From:

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Adrian Bunk
On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: > Hi Geert, > > On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> >> >> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible >> >> drivers/char/keyboard.c: In funct

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
Hi Geert, On 7/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible > > drivers/char/keyboard.c: In function 'kbd_keycode': > drivers/char/keyboard.c:1142: error: implicit declarat

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Scott Wood
On Fri, Jul 20, 2007 at 12:57:02AM -0700, Andrew Morton wrote: > On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > > On Thu, 19 Jul 2007 23:23:37 -0700 > > Andrew Morton wrote: > > > Shouldn't these be runtime options (ie: module parameters)? > > > > > I thought about i

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-20 Thread Jerry Van Baren
Scott Wood wrote: > Jerry Van Baren wrote: >> Scott Wood wrote: >>> Kim Phillips wrote: The LIBFDT implementation replaces any existing /chosen with its fixed up version. >> >> Sort of. If /chosen doesn't exist, it creates it. >> >> If /chosen exists and "force" parameter is false, it do

[patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons' The forward declaration of ma

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-20 Thread Scott Wood
Jerry Van Baren wrote: > Scott Wood wrote: >> Kim Phillips wrote: >>> The LIBFDT implementation replaces any existing /chosen with its fixed >>> up version. > > > Sort of. If /chosen doesn't exist, it creates it. > > If /chosen exists and "force" parameter is false, it doesn't touch it. > If "

[RFC 1/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-20 Thread Jan-Bernd Themann
Generic LRO patch Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- include/linux/inet_lro.h | 154 + net/ipv4/inet_lro.c | 549 ++ 2 files changed, 703 insertions(+), 0 deletions(-) create mode 100644 include/linux/inet_lro.

[RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-20 Thread Jan-Bernd Themann
Hi, Thanks a lot for your comments so far. This generic LRO patch differs from the last one in several points. A new interface for a "receive in pages" mode has been added and tested with an eHEA prototype. Seems to work well. Does this extended interface seem to be sufficient? Below some more e

PS3: Fix build with 32-bit toolchains

2007-07-20 Thread Geoff Levand
The PS3 bootwrapper files use instructions only available on 64-bit CPUs. Add the code generation directive '.machine "ppc64"' for toolchains configured for 32-bit CPUs. Signed-off-by: Geoff Levand <[EMAIL PROTECTED]> Acked-by: Grant Likely <[EMAIL PROTECTED]> --- Hi Andrew, It seems Paul is out

Re: [PATCH] powerpc: mpc5200 low power mode, .globl fix

2007-07-20 Thread Grant Likely
On 7/20/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > flush_data_cache doesn't need to be global, and can cause problems. > Thanks to Milton Miller for noticing this. > > > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> Paulus, can you pick this up

[PATCH 5/5] ehca: Support small QP queues

2007-07-20 Thread Hoang-Nam Nguyen
From: Stefan Roscher Date: Fri, 20 Jul 2007 13:59:14 +0200 Subject: [PATCH 5/5] IB/ehca: Small QP queues eHCA2 supports QP queues that can be as small as 512 bytes. This greatly reduces memory overhead for consumers that use lots of QPs with small queues (e.g. RDMA-only QPs). Apart from dealing w

[PATCH 4/5] ehca: Make internal_create/destroy_qp() static

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:40:00 +0200 Subject: [PATCH 4/5] IB/ehca: Make internal_{create,destroy}_qp() static They're only used in ehca_qp.c Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_qp.c | 17 +--

[PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 21:13:57 +0200 Subject: [PATCH 3/5] IB/ehca: Make ehca2ib_return_code() non-inline It's nowhere in the main path and making it non-inline saves ~1.5K of code. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/

[PATCH 2/5] ehca: Generate event when SRQ limit reached

2007-07-20 Thread Hoang-Nam Nguyen
From: Joachim Fenkes <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:51:43 +0200 Subject: [PATCH 2/5] IB/ehca: Generate event when SRQ limit reached Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_irq.c | 42 ++--- 1 files changed,

[PATCH 1/5] ehca: Supports large page MRs

2007-07-20 Thread Hoang-Nam Nguyen
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 20:48:04 +0200 Subject: [PATCH 1/5] IB/ehca: Support large page MRs Add support for MR pages larger than 4K on eHCA2. This reduces firmware memory consumption. If enabled via the mr_largepage module parameter, the MR page size will

[PATCH 0/5] ehca: MR large page, small queue and fixes

2007-07-20 Thread Hoang-Nam Nguyen
Here is a patch set against Roland's git, branch for-2.6.23 for ehca. It adds support for MR large page and small queues. In addition of that it also contains various small fixes from previous comments and what we found. They are in details: [1/5] adds support for MR large page [2/5] generates eve

[PATCH] powerpc: mpc5200 low power mode, .globl fix

2007-07-20 Thread Domen Puncer
flush_data_cache doesn't need to be global, and can cause problems. Thanks to Milton Miller for noticing this. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- arch/powerpc/platforms/52xx/lite5200_sleep.S |1 - 1 file changed, 1 deletion(-) Index: work-powerpc.git/arch/powerpc/platforms/

Re: Possible eHEA performance issue

2007-07-20 Thread Thomas Klein
Michael Neuling wrote: > From ehea_start_xmit in ehea_main.c we have: > > if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) { > spin_lock_irqsave(&pr->netif_queue, flags); > if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) { > pr->p_stats.queue_stopped++; >

Re: [PATCH 2/2] fix showing xmon help

2007-07-20 Thread Ishizaki Kou
Milton Miller <[EMAIL PROTECTED]> wrote: > On Jul 18, 2007, at 11:12 AM, Andreas Schwab wrote: > > > Milton Miller <[EMAIL PROTECTED]> writes: > > > >>> case '?': > >>> - printf(help_string); > >>> + xmon_puts(help_string); > >>>

Re: [PATCH] of_detach_node()'s device node argument cannot be const

2007-07-20 Thread Segher Boessenkool
>> ...since it modifies it (when it sets the OF_DETACHED flag). > > http://patchwork.ozlabs.org/linuxppc/patch?q=Stephen% > 20Rothwell&id=12212 Ah okay :-) Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listin

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Andrew Morton
On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote: > On Thu, 19 Jul 2007 23:23:37 -0700 > Andrew Morton wrote: > > > On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug > > <[EMAIL PROTECTED]> wrote: > > > > > > > > device_bind_driver() error code returning has been fixed.

Re: [PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-20 Thread Vitaly Bordug
On Thu, 19 Jul 2007 23:23:37 -0700 Andrew Morton wrote: > On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug > <[EMAIL PROTECTED]> wrote: > > > > > device_bind_driver() error code returning has been fixed. > > release() function has been written, so that to free resources > > in correct way; th

Re: [PATCH] Treat ISI faults as read faults on classic 32-bit PowerPC

2007-07-20 Thread Segher Boessenkool
>> Should you really be testing VM_READ|VM_WRITE, or should it just >> be VM_READ? > > We test VM_READ | VM_WRITE | VM_EXEC in the read case below, and that > is because we have no HPTE encoding to say "writable but not readable" > or "executable but not readable". Similarly we have no encoding to

Re: [PATCH] powerpc: Add of_register_i2c_devices()

2007-07-20 Thread Segher Boessenkool
>> You might want to put vendor names in the "compatible" >> entries, dunno though, maybe these are "cross-vendor" >> ICs? > > You mean like > > compatible = "ricoh,rs5c372a" Yeah, like that. I'm not sure it is needed for these, but it won't hurt either. > + strncpy(info->drive

Re: [PATCH] Add StorCenter DTS first draft.

2007-07-20 Thread Segher Boessenkool
>> So your plan is to prefer the device tree over the cputable, and >> maybe even deprecate the cputable? > > Nah, you are fine not putting anything, but if it's in the DT it > should > be correct, not "0". Else, just don't put it in the DT. Ah okay. So we should recommend to not put any of tho