Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-03 Thread walt
On 01/02/2014 11:15 AM, Sarah Sharp wrote: > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: >> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote: >>> 3.12-stable review patch. If anyone has any objections, please let me know. >>> >>> -

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-03 Thread walt
On 01/03/2014 11:54 AM, Sarah Sharp wrote: > On Fri, Jan 03, 2014 at 07:40:33AM -0800, walt wrote: >> On 01/02/2014 11:15 AM, Sarah Sharp wrote: >>> On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: >>>> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote: >&

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-07 Thread walt
link TRB. >> >> I suspect David's patch triggers a bug in the command cancellation code. >> There's also the unlikely possibility that the no-op TRBs did indeed >> cause the host to hang. Either way, I'll have to look into it. >> >> I'll

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-07 Thread walt
On 01/07/2014 05:58 AM, David Laight wrote: > The dmesg contains: > > [ 538.728064] EXT4-fs warning (device dm-0): ext4_end_bio:316: I/O error > writing to inode 23330865 (offset 0 size 8388608 starting block 812628) > > An 8MB transfer will need at least 128 ring entries (TRB) even if the requ

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-07 Thread walt
Okay, I used log_buf_len to make dmesg bigger and now I think I have the whole thing. It's attached. dmesg2.gz Description: application/gzip

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread walt
On 01/03/2014 03:29 PM, Sarah Sharp wrote: > I'll let you know when I have some diagnostic patches ready. Hi Sarah. I see today gregkh committed the patches you've already sent me, so I assume someone (other than me) has tested those patches and discovered some benefit from them? I'm still wond

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-09 Thread walt
On 01/09/2014 02:05 AM, David Laight wrote: >> From: walt > ... >> I'm still wondering if I'm suffering from hardware quirks. From the >> first day I installed my usb3 adapter card and the usb3 disk docking >> station I've noticed some quirky behavi

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-10 Thread walt
On 01/09/2014 03:50 PM, Sarah Sharp wrote: >>> On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: >> >> The aftermarket usb3 adapter card and the usb3 outboard hard-drive docking >> station are the only two usb3 devices I have. >> >> I've won

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-13 Thread walt
On 01/09/2014 03:50 PM, Sarah Sharp wrote: >>> On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: >> >> I've wondered if my xhci problems might be caused by hardware quirks, and >> wondering why I seem to be the only one who has this problem. >> >&

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-14 Thread walt
On 01/14/2014 09:20 AM, Sarah Sharp wrote: > On Mon, Jan 13, 2014 at 03:39:07PM -0800, walt wrote: >> Sarah, I just fixed my xhci bug for US$19.99 :) >> >> #lspci | tail -1 >> 04:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host Controller >> (rev 03) &

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-18 Thread walt
On 01/17/2014 06:34 AM, David Laight wrote: > From: walt >> Oy, Sarah! ;) I put the ASMedia adapter in my older amd64 machine, and, >> well, >> the stupid thing Just Works(TM) with kernel 3.12.7! (Yes, with the same disk >> docking station, too.) >> >

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-18 Thread walt
On 01/17/2014 06:34 AM, David Laight wrote: > Can you try the patch I posted that stops the ownership on LINK TRBs > being changed before that on the linked-to TRB? Please disregard my earlier post about the patch not applying cleanly. That was the usual html corruption, so I found the original o

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-21 Thread walt
On 01/21/2014 01:51 AM, David Laight wrote: > From: Sarah Sharp >> On Mon, Jan 20, 2014 at 11:21:14AM +, David Laight wrote: > ... >>> A guess... >>> >>> In queue_bulk_sg_tx() try calling xhci_v1_0_td_remainder() instead >>> of xhci_td_re

Re: 174c:5106 1 TB External USB 3.0 Drive Fails to Automount through USB 3.0 dock with XHCI Enabled

2014-01-21 Thread walt
On 01/21/2014 04:51 PM, Jay S wrote: > [1.] 174c:5106 1 TB External USB 3.0 Drive Fails to Automount through USB 3.0 > dock with XHCI Enabled > [10823.816255] usb 4-5.3: Manufacturer: ASMedia I'm interested in ASMedia usb3 bugs :) > [4.] Linux version 3.13.0-031300-generic You're running a ble

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-22 Thread walt
On 01/22/2014 12:56 PM, Sarah Sharp wrote: > Walt, can you turn on xHCI debugging and look for whether the NEC host > that worked with David's patch is a 1.0 host? You'll see a line like: > > // @%p = 0x%x (CAPLENGTH AND HCIVERSION) Hi Sarah. This is from the NEC host

Re: [PATCH] xhci: Limit TD fragments to 1.0 xHCI hosts only.

2014-01-28 Thread walt
On 01/27/2014 03:49 PM, Sarah Sharp wrote: > Walt reports that the PCI add-in card for his 0.96 ASMedia host dies in > a particular machine. This symptom goes away when commit > 35773dac5f862cb1c82ea151eba3e2f6de51ec3e "usb: xhci: Link TRB must not > occur within a USB payload b

[XHCI] commit ec513b1 from Linus triggers ASMedia quirk

2014-01-29 Thread walt
Hi Sarah and David. I'm back with more ASMedia problems caused by this: commit ec513b16c480c6cdda1e3d597e611eafca05227b Merge: bcee634 2fc5a7d Author: Linus Torvalds Date: Mon Jan 20 16:13:02 2014 -0800 Merge tag 'usb-3.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb

Re: [XHCI] commit ec513b1 from Linus triggers ASMedia quirk

2014-01-30 Thread walt
On 01/29/2014 05:15 PM, Sarah Sharp wrote: > > On Wed, Jan 29, 2014 at 04:16:49PM -0800, walt wrote: >> Hi Sarah and David. I'm back with more ASMedia problems caused by this: >> >> commit ec513b16c480c6cdda1e3d597e611eafca05227b >> Merge: bcee634 2fc5a7d

Re: ASMedia xhci controller errors

2014-01-31 Thread walt
On 01/31/2014 11:23 AM, Sarah Sharp wrote: > On Fri, Jan 31, 2014 at 04:37:47PM +, David Laight wrote: >> In order to get an ASMedia xhci controller to even detect a device >> being inserted I had to split the writeq() and readq(). >> The following patch is sufficient on amd64. > > I've reve