Re: [Patch V3 1/8] phy: tegra: xusb: t210: add XUSB dual mode support

2019-05-20 Thread jckuo
Reviewed-by: JC Kuo On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: Configure the port capabilities based on usb_dr_mode settings. Based on work by JC Kuo . Signed-off-by: Nagarjuna Kristam --- drivers/phy/tegra/xusb-tegra210.c | 22 +++--- 1 file changed, 19 insertions(+),

Re: [Patch V3 2/8] phy: tegra: xusb: t210: add usb3 port fake support

2019-05-20 Thread jckuo
Hi Nagarjuna, Please check tegra_xusb_update_usb3_fake_port(). Thanks, JC On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: On Tegra210, usb2 only otg/peripheral ports dont work in device mode. They need an assosciated usb3 port to work in device mode. Identify an unused usb3 port and assign it as

Re: [Patch V3 3/8] phy: tegra: xusb: t210: add vbus override support

2019-05-20 Thread jckuo
Hi Nagarjuna, Please check tegra_phy_xusb_utmi_port_reset(). Thanks, JC On 5/16/19 2:39 PM, Nagarjuna Kristam wrote: Tegra XUSB device control driver needs to control vbus override during its operations, add API for the support. Signed-off-by: Nagarjuna Kristam --- drivers/phy/tegra/xusb-

Re: [PATCH 1/6] dt-bindings: usb: xhci-tegra: Add Tegra186 support

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: Thierry Reding Extend the bindings to cover the set of features found in Tegra186. Signed-off-by: Thierry Reding --- .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 4 1 file changed, 4 insertions(+)

Re: [PATCH 2/6] usb: host: xhci-tegra: Selectively program IPFS

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: JC Kuo Starting with Tegra186, the XUSB controller no longer has the IPFS wrapper. This commit adds a "has_ipfs" field to struct tegra_xusb_soc that can be used to declare the existence of the IPFS wrapper. For the existing

Re: [PATCH 3/6] usb: host: xhci-tegra: Add Tegra186 XUSB support

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: JC Kuo This commit adds Tegra186 XUSB host mode controller support. This is very similar to the existing support for Tegra124 and Tegra210, except that the number of ports and PHYs differs and the IPFS wrapper being gone. Si

Re: [PATCH 4/6] arm64: tegra: Add XUSB and pad controller on Tegra186

2019-01-28 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: Thierry Reding Adds the XUSB pad and XUSB controllers on Tegra186. Signed-off-by: Thierry Reding --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 135 +++ 1 file changed, 135 insertions(+) diff --git a

Re: [PATCH 4/8] arm64: tegra: Add xudc node for Tegra210

2019-01-28 Thread jckuo
Reviewed-by: JC Kuo On 1/3/19 6:04 PM, Nagarjuna Kristam wrote: Tegra210 has one XUSB device mode controller, which can be operated HS and SS modes. Add DT support for XUSB device mode controller. Signed-off-by: Nagarjuna Kristam --- arch/arm64/boot/dts/nvidia/tegra210.dtsi | 17 +++

Re: [PATCH 5/8] arm64: tegra: Enable xudc on Jetson TX1

2019-01-28 Thread jckuo
Hi Nagarjuna, avddio_usb-supply should be <&vdd_3v3_sys> . hvdd_usb-supply should be <&vdd__1v8> . Thanks, JC On 1/3/19 6:04 PM, Nagarjuna Kristam wrote: Enable XUSB device mode driver for USB0 slot on Jetson TX1. Signed-off-by: Nagarjuna Kristam --- arch/arm64/boot/dts/nvidia/tegra210-

Re: [PATCH 3/8] dt-bindings: phy: tegra-xusb-padctl: Add nvidia,usb3-port-fake entry

2019-02-14 Thread jckuo
There won't be a case that all of the super-speed ports are in used but none of the ports can be paired with the OTG capable USB2 port. T210/T210B01(aka T214) has 4 super-speed ports and 4 USB2 ports. A USB 3.0 connection (either host role or device role) must have one super-speed port pair wit