[PATCH] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-03 Thread Thierry Reding
From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for reset control assertions. The goal is to allow resets to be shared by multiple devices and an assert will take effect only when all instances have as

Re: [PATCH] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-03 Thread Thierry Reding
On Tue, May 03, 2016 at 08:05:55PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > controls") there is a reference count for reset control assertions. The > goal is to allow resets to be s

[PATCH v2 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for reset control assertions. The goal is to allow resets to be shared by multiple devices and an assert will take effect only when all instances have as

[PATCH v2 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-04 Thread Thierry Reding
From: Thierry Reding There are three EHCI controllers on Tegra SoCs, each with its own reset line. However, the first controller contains a set of UTMI configuration registers that are shared with its siblings. These registers will only be reset as part of the first controller's reset

Re: [PATCH v2 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
On Wed, May 04, 2016 at 04:22:02PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > controls") there is a reference count for reset control assertions. The > goal is to allow resets to be s

[PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-04 Thread Thierry Reding
From: Thierry Reding There are three EHCI controllers on Tegra SoCs, each with its own reset line. However, the first controller contains a set of UTMI configuration registers that are shared with its siblings. These registers will only be reset as part of the first controller's reset

Re: [PATCH] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
On Tue, May 03, 2016 at 03:16:56PM -0400, Alan Stern wrote: > On Tue, 3 May 2016, Thierry Reding wrote: > > > From: Thierry Reding > > > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > > controls") there is a reference count fo

[PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for reset control assertions. The goal is to allow resets to be shared by multiple devices and an assert will take effect only when all instances have as

Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-04 Thread Thierry Reding
On Wed, May 04, 2016 at 07:57:10AM -0700, Greg Kroah-Hartman wrote: > On Wed, May 04, 2016 at 04:39:59PM +0200, Thierry Reding wrote: > > From: Thierry Reding > > > > There are three EHCI controllers on Tegra SoCs, each with its own reset > > line. However, the first c

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
On Wed, May 04, 2016 at 07:22:54PM +0200, Philipp Zabel wrote: > Hi Thierry, > > Am Mittwoch, den 04.05.2016, 16:40 +0200 schrieb Thierry Reding: > > From: Thierry Reding > > > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > >

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: > On 05/04/2016 08:40 AM, Thierry Reding wrote: > > From: Thierry Reding > > > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > > controls") there is a reference co

Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-04 Thread Thierry Reding
On Wed, May 04, 2016 at 11:14:50AM -0600, Stephen Warren wrote: > On 05/04/2016 08:39 AM, Thierry Reding wrote: > > From: Thierry Reding > > > > There are three EHCI controllers on Tegra SoCs, each with its own reset > > line. However, the first controller contains

[PATCH v4 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-26 Thread Thierry Reding
From: Thierry Reding There are three EHCI controllers on Tegra SoCs, each with its own reset line. However, the first controller contains a set of UTMI configuration registers that are shared with its siblings. These registers will only be reset as part of the first controller's reset

[PATCH v4 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-26 Thread Thierry Reding
From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for reset control assertions. The goal is to allow resets to be shared by multiple devices and an assert will take effect only when all instances have as

Re: [PATCH v4 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-26 Thread Thierry Reding
On Thu, May 26, 2016 at 05:23:30PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > controls") there is a reference count for reset control assertions. The > goal is to allow resets to be s

[RFC 5/5] ARM: tegra: Enable UDC on Jetson TK1

2016-05-26 Thread Thierry Reding
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/tegra124

[RFC 2/5] ARM: tegra: Enable UDC on TrimSlice

2016-05-26 Thread Thierry Reding
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra20-trimslice.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/tegra20-trimslice.dts b/arch/arm/boot/dts

[RFC 4/5] ARM: tegra: Enable UDC on Dalmore

2016-05-26 Thread Thierry Reding
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra114-dalmore.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm

[RFC 1/5] usb: chipidea: Add support for Tegra20/30/114/124

2016-05-26 Thread Thierry Reding
From: Thierry Reding All of these Tegra SoC generations have a ChipIdea UDC IP block that can be used for device mode communication with a host. Implement rudimentary support that doesn't allow switching between host and device modes. Signed-off-by: Thierry Reding --- drivers/usb/chi

[RFC 0/5] usb: chipidea: Add support for Tegra20 through Tegra124

2016-05-26 Thread Thierry Reding
From: Thierry Reding All Tegra SoC generations from Tegra20 through Tegra124 have a ChipIdea USB device controller. This set of patches adds very rudimentary support for it to the existing ChipIdea driver and enables them on the set of boards that I could easily test on. I'm sending this o

[RFC 3/5] ARM: tegra: Enable UDC on Beaver

2016-05-26 Thread Thierry Reding
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra30-beaver.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-beaver.dts b/arch/arm/boot

[PATCH 29/33] usb: Convert to devm_ioremap_resource()

2013-01-21 Thread Thierry Reding
Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by: Thierry

Re: [PATCH 17/44] usb: host: xhci-tegra: don't print on ENOMEM

2016-09-05 Thread Thierry Reding
On Thu, Aug 25, 2016 at 07:39:09PM +0200, Wolfram Sang wrote: > All kmalloc-based functions print enough information on failures. > > Signed-off-by: Wolfram Sang > --- > drivers/usb/host/xhci-tegra.c | 1 - > 1 file changed, 1 deletion(-) Acked-by: Thierry Reding signatu

[PATCH v10 5/9] phy: tegra: Add Tegra210 support

2016-03-04 Thread Thierry Reding
From: Thierry Reding Add support for the XUSB pad controller found on Tegra210 SoCs. The hardware is roughly the same, but some of the registers have been moved around and the number and type of supported pads has changed. Signed-off-by: Thierry Reding --- Changes in v9: - expose more public

[PATCH v10 9/9] usb: xhci: tegra: Add Tegra210 support

2016-03-04 Thread Thierry Reding
From: Thierry Reding Parameterize more parts of the driver and add support for Tegra210. Cc: Greg Kroah-Hartman Cc: Mathias Nyman Signed-off-by: Thierry Reding --- drivers/usb/host/xhci-tegra.c | 59 +-- 1 file changed, 51 insertions(+), 8 deletions

[PATCH v10 6/9] dt-bindings: usb: Add NVIDIA Tegra XUSB controller binding

2016-03-04 Thread Thierry Reding
From: Thierry Reding Add device-tree binding documentation for the XUSB controller present on Tegra124 and later SoCs. This controller supports USB 3.0 via an xHCI compliant interface. Based on work by Andrew Bresticker . Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc

[PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-03-04 Thread Thierry Reding
From: Thierry Reding Add a new driver for the XUSB pad controller found on NVIDIA Tegra SoCs. This hardware block used to be exposed as a pin controller, but it turns out that this isn't a good fit. The new driver and DT binding much more accurately describe the hardware and are more flexib

[PATCH v10 7/9] dt-bindings: usb: xhci-tegra: Add Tegra210 XUSB controller support

2016-03-04 Thread Thierry Reding
From: Thierry Reding Extend the Tegra XUSB controller device tree binding with Tegra210 support. Signed-off-by: Thierry Reding --- .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v10 8/9] usb: xhci: Add NVIDIA Tegra XUSB controller driver

2016-03-04 Thread Thierry Reding
From: Thierry Reding Add support for the on-chip XUSB controller present on Tegra SoCs. This controller, when loaded with external firmware, exposes an interface compliant with xHCI. This driver loads the firmware, starts the controller, and is able to service host-specific messages sent by the

[PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

2016-03-04 Thread Thierry Reding
From: Thierry Reding Extend the binding to cover the set of feature found in Tegra210. Signed-off-by: Thierry Reding --- .../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 327 + 1 file changed, 327 insertions(+) diff --git a/Documentation/devicetree/bindings/phy

[PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-04 Thread Thierry Reding
From: Thierry Reding The NVIDIA Tegra XUSB pad controller provides a set of pads, each with a set of lanes that are used for PCIe, SATA and USB. Signed-off-by: Thierry Reding --- Changes in v10: - clarify that the hardware documentation means something different when referring to a "

[PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-03-04 Thread Thierry Reding
From: Thierry Reding This is an old version of the binding that isn't flexible enough to describe all aspects of the XUSB pad controller. Specifically with the addition of XUSB support (for SuperSpeed USB) the existing binding is no longer suitable. Signed-off-by: Thierry R

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-07 Thread Thierry Reding
On Fri, Mar 04, 2016 at 10:31:45PM -0600, Rob Herring wrote: > On Fri, Mar 04, 2016 at 05:19:31PM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > The NVIDIA Tegra XUSB pad controller provides a set of pads, each with a > > set of lanes that are

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-29 Thread Thierry Reding
On Tue, Mar 29, 2016 at 05:24:59PM +0200, Marcel Ziswiler wrote: > Hi Thierry > > On Fri, 2016-03-04 at 17:19 +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > > > The NVIDIA Tegra XUSB pad controller provides a set of pads, each > > with a

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-04-05 Thread Thierry Reding
Hi Kishon, The dependencies within this series somewhat complicated, so I'd prefer to take it all via one tree. Would you be willing to give an Acked-by on this patch? Thierry On Fri, Mar 04, 2016 at 05:19:34PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Add a new

Re: [PATCH v10 8/9] usb: xhci: Add NVIDIA Tegra XUSB controller driver

2016-04-05 Thread Thierry Reding
Hi Mathias, Greg, Due to the various dependencies within the series, I'd prefer this to go via the Tegra tree. Would you be okay with providing your Acked-by? Thanks, Thierry On Fri, Mar 04, 2016 at 05:19:38PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Add support f

Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

2016-04-05 Thread Thierry Reding
On Wed, Mar 16, 2016 at 11:59:44AM -0600, Stephen Warren wrote: > On 03/04/2016 09:19 AM, Thierry Reding wrote: > > From: Thierry Reding > > > > Extend the binding to cover the set of feature found in Tegra210. > > Acked-by: Stephen Warren > > > diff -

Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

2016-04-06 Thread Thierry Reding
On Tue, Apr 05, 2016 at 03:10:16PM -0600, Stephen Warren wrote: > On 04/05/2016 08:44 AM, Thierry Reding wrote: > > On Wed, Mar 16, 2016 at 11:59:44AM -0600, Stephen Warren wrote: > > > On 03/04/2016 09:19 AM, Thierry Reding wrote: > > > > From: Thierry Reding >

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-04-06 Thread Thierry Reding
On Wed, Apr 06, 2016 at 06:13:42PM +0530, Kishon Vijay Abraham I wrote: > On Friday 04 March 2016 09:49 PM, Thierry Reding wrote: [...] > > +struct tegra124_xusb_fuse_calibration { > > + u32 hs_curr_level[3]; > > + u32 hs_iref_cap; > > + u32 hs_term_range_adj; &

Re: [PATCH v10 8/9] usb: xhci: Add NVIDIA Tegra XUSB controller driver

2016-04-07 Thread Thierry Reding
On Thu, Apr 07, 2016 at 02:03:45PM +0300, Mathias Nyman wrote: > On 04.03.2016 18:19, Thierry Reding wrote: > > From: Thierry Reding > > > > Add support for the on-chip XUSB controller present on Tegra SoCs. This > > controller, when loaded with external fir

Re: [PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-04-18 Thread Thierry Reding
On Tue, Mar 15, 2016 at 10:01:25AM +0100, Linus Walleij wrote: > On Fri, Mar 4, 2016 at 5:19 PM, Thierry Reding > wrote: > > > From: Thierry Reding > > > > This is an old version of the binding that isn't flexible enough to > > describe all aspects of the

Re: [PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-04-18 Thread Thierry Reding
On Tue, Mar 15, 2016 at 10:01:25AM +0100, Linus Walleij wrote: > On Fri, Mar 4, 2016 at 5:19 PM, Thierry Reding > wrote: > > > From: Thierry Reding > > > > This is an old version of the binding that isn't flexible enough to > > describe all aspects of the

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-04-18 Thread Thierry Reding
On Fri, Mar 04, 2016 at 05:19:34PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Add a new driver for the XUSB pad controller found on NVIDIA Tegra SoCs. > This hardware block used to be exposed as a pin controller, but it turns > out that this isn't a good fit. T

Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

2016-04-18 Thread Thierry Reding
On Wed, Apr 06, 2016 at 07:08:24PM +0200, Thierry Reding wrote: [...] > I attached what I came up with. It extends the OF PHY provider registry > by allowing an additional node to be specified that if specified will > serve as the parent for the child lookup (and hence overrides the >

[GIT PULL 0/4] ARM: tegra: Add XUSB controller support

2016-04-29 Thread Thierry Reding
Hi everyone, This is a fairly complicated series of pull requests because of the dependencies involved. The goal is to take all of the patches through the ARM-SoC tree but I'm sending out these individual pull requests to document this. Also, if these branches were starting to cause conflicts they

[GIT PULL 2/4]: PCI: tegra: Changes for v4.7-rc1

2016-04-29 Thread Thierry Reding
update the Tegra PCIe host bridge controller device tree bindings and driver to cope with per-lane PHYs on Tegra124 and later. Thierry Reding (3): Merge branch 'for-4.7/phy' into for-4.7/pci dt-bindings: pci: teg

[GIT PULL 1/4]: phy: tegra: Changes for v4.7-rc1

2016-04-29 Thread Thierry Reding
). Thierry Reding (6): Merge branch 'for-4.7/clk' into for-4.7/phy phy: core: Allow children node to be overridden dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support phy: Add

[GIT PULL 3/4]: usb: host: xhci-tegra: Changes for v4.7-rc1

2016-04-29 Thread Thierry Reding
This set of patches introduces a driver for the XUSB controller found on NVIDIA Tegra SoCs. When loaded with a firmware (available via the linux- firmware repository), it provides an XHCI-compatible interface. Thierry Reding (5

[GIT PULL 4/4]: ARM: tegra: Enable the XUSB controller

2016-04-29 Thread Thierry Reding
that replaces the existing EHCI controllers. Support is enabled on Venice2, Jetson TK1 and Nyan-based Chromebooks. Andrew Bresticker (1): clk: tegra: Add interface to enable hardware control of SATA/XUSB PLLs Thierry Redin

[GIT PULL v2 4/4]: ARM: tegra: Enable the XUSB controller

2016-04-29 Thread Thierry Reding
. Andrew Bresticker (1): clk: tegra: Add interface to enable hardware control of SATA/XUSB PLLs Thierry Reding (22): Merge branch 'for-4.7/clk' into for-4.7/phy phy: core: Allow children node to be overridden d

Re: [PATCH] Usb: host - Fix possible NULL derefrence.

2017-01-29 Thread Thierry Reding
On Mon, Jan 30, 2017 at 07:45:21AM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 30, 2017 at 10:36:29AM +0530, Shailendra Verma wrote: > > of_device_get_match_data could return NULL, and so can cause > > a NULL pointer dereference later. > > > > Signed-off-by: Shailendra Verma > > --- > > drive

Re: [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct

2017-03-07 Thread Thierry Reding
drivers/usb/host/xhci-tegra.c |1 - > 2 files changed, 2 deletions(-) For Tegra: Tested-by: Thierry Reding Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [GIT PATCH] USB patches for 3.9-rc1

2013-02-21 Thread Thierry Reding
On Thu, Feb 21, 2013 at 01:58:39PM -0800, Greg KH wrote: > On Thu, Feb 21, 2013 at 12:25:24PM -0800, Linus Torvalds wrote: > > On Thu, Feb 21, 2013 at 10:40 AM, Greg KH > > wrote: > > > > > > USB patches for 3.9-rc1 > > > > > > Here's the big USB merge for 3.9-rc1 > > > > > > Nothing major, lots

Re: [PATCH 1/3] usb: phy: samsung: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
or messages can be removed from the failure code paths. > > Signed-off-by: Sachin Kamat Reviewed-by: Thierry Reding pgpR2wexD4ouX.pgp Description: PGP signature

Re: [PATCH 2/3] usb: phy: omap-usb3: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
or messages can be removed from the failure code paths. > > Signed-off-by: Sachin Kamat > Cc: Kishon Vijay Abraham I > --- > drivers/usb/phy/omap-usb3.c |8 +++- > 1 files changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Thierry Reding pgpECQm4gcqfC.pgp Description: PGP signature

Re: [PATCH 3/3] usb: phy: omap-control-usb: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
or messages can be removed from the failure code paths. > > Signed-off-by: Sachin Kamat > Cc: Kishon Vijay Abraham I > --- > drivers/usb/phy/omap-control-usb.c | 24 +--- > 1 files changed, 9 insertions(+), 15 deletions(-) Reviewed-by: Thierry Reding p

[PATCH] USB: EHCI: tegra: Fix oops in error cleanup

2013-06-14 Thread Thierry Reding
oops in tegra_ehci_probe(). This patch fixes the issue by adding an additional label into the cleanup path to separately take down the PHY and the transceiver. Signed-off-by: Thierry Reding --- Note: This is based on top of Stephen's latest patch series to allow building the driver as a modul

Re: [PATCH V3 REPOST 0/7] USB: tegra: support building as a module

2013-06-14 Thread Thierry Reding
t/ehci-hub.c | 4 +- > drivers/usb/host/ehci-tegra.c | 474 > > drivers/usb/host/ehci.h | 2 + > drivers/usb/phy/phy-tegra-usb.c | 43 +++- > drivers/usb/phy/phy-ulpi-viewport.c | 2 + > include/linux

Re: [PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-02 Thread Thierry Reding
gt; Thierry, can you please validate that the gpv group pull strength change > doesn't have any negative affect on your PCIe patches. Thanks. PCIe on Beaver seems to behave the same way whether that patch is applied or not, so: Tested-by: Thierry Reding I wonder if perhaps a similar change can

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-15 Thread Thierry Reding
On Wed, Jul 31, 2013 at 05:29:40PM -0600, Stephen Warren wrote: > On 07/31/2013 04:20 PM, Sergei Shtylyov wrote: > > On 08/01/2013 02:06 AM, Stephen Warren wrote: > ... > >>> That's really horrible design. > >> > >> Yup. Both USB PHY and EHCI controller registers really are interleaved > >> in

Re: [PATCH 27/31] USB: EHCI: tegra: use reset framework

2013-11-29 Thread Thierry Reding
> drivers/usb/host/ehci-tegra.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding pgpVJB4hRtMwz.pgp Description: PGP signature

[PATCH] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-02 Thread Thierry Reding
nding and initialize the transceiver field to ERR_PTR(-ENODEV) when the operating mode isn't TEGRA_USB_OTG to allow for consistent checking. Signed-off-by: Thierry Reding --- drivers/usb/host/ehci-tegra.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb

[PATCH v2] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-03 Thread Thierry Reding
nding and initialize the transceiver field to ERR_PTR(-ENODEV) when the operating mode isn't TEGRA_USB_OTG to allow for consistent checking. Signed-off-by: Thierry Reding Acked-by: Stephen Warren Acked-by: Venu Byravarasu --- Note that this has a conflict with Felipe's tree, but it sh

Re: [PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-04 Thread Thierry Reding
y/phy-tegra-usb.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thierry Reding pgpztN5vkmcF9.pgp Description: PGP signature

Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 11:02:36AM -0700, Andrew Bresticker wrote: [...] > > Maybe something like this patch would be more correct in handling > > this: > > > > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c > > index afcb430508ec..85691a7d8ca6 100644 > > --- a/drivers/mailbox/m

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: > >> diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c > >> b/drivers/pinctrl/pinctrl-tegra-xusb.c [...] > >> + > >> + for (i = 0; i < TEGRA_XUSB_USB3_PHYS; i++) { > >> + if (phy == padctl->phys[TEGRA_XUSB_PADCTL_US

Re: [PATCH RESEND V4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-10-30 Thread Thierry Reding
On Wed, Oct 29, 2014 at 09:37:14AM -0700, Andrew Bresticker wrote: > On Wed, Oct 29, 2014 at 2:43 AM, Thierry Reding > wrote: > > On Tue, Oct 28, 2014 at 03:27:50PM -0700, Andrew Bresticker wrote: > > [...] > >> diff --git > >> a/Documentation/devicetree/b

Re: [PATCH RESEND V4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-10-30 Thread Thierry Reding
On Thu, Oct 30, 2014 at 10:19:21AM -0700, Andrew Bresticker wrote: > On Thu, Oct 30, 2014 at 6:55 AM, Thierry Reding > wrote: > > On Wed, Oct 29, 2014 at 09:37:14AM -0700, Andrew Bresticker wrote: > >> On Wed, Oct 29, 2014 at 2:43 AM, Thierry Reding > >> wrote: >

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-31 Thread Thierry Reding
On Thu, Oct 30, 2014 at 10:10:06AM -0700, Andrew Bresticker wrote: > On Thu, Oct 30, 2014 at 6:45 AM, Thierry Reding > wrote: > > On Wed, Oct 29, 2014 at 12:43:36PM -0700, Andrew Bresticker wrote: > >> >> diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c > >>

Re: [PATCH RESEND V4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-10-31 Thread Thierry Reding
On Thu, Oct 30, 2014 at 10:26:47AM -0700, Andrew Bresticker wrote: > On Thu, Oct 30, 2014 at 10:24 AM, Thierry Reding > wrote: > > On Thu, Oct 30, 2014 at 10:19:21AM -0700, Andrew Bresticker wrote: > >> On Thu, Oct 30, 2014 at 6:55 AM, Thierry Reding > >> wrote: >

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Thierry Reding
On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > When __of_usb_find_phy() fails, it returns -ENODEV - its > error code has to be returned by devm_usb_get_phy_by_phandle(). > Only when the former function succeeds and try_module_get() > fails should -EPROBE_DEFER be returned. > >

Re: [PATCH] usb:phy: propagate __of_usb_find_phy()'s error on failure

2014-11-24 Thread Thierry Reding
On Mon, Nov 24, 2014 at 08:36:46AM -0600, Felipe Balbi wrote: > Hi, > > On Mon, Nov 24, 2014 at 02:10:41PM +0100, Thierry Reding wrote: > > On Thu, Nov 20, 2014 at 09:23:36PM +0530, Arjun Sreedharan wrote: > > > When __of_usb_find_phy() fails, it returns -ENODEV - its &g

Re: [PATCH V6 05/12] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-12-02 Thread Thierry Reding
On Mon, Nov 24, 2014 at 04:17:17PM -0800, Andrew Bresticker wrote: > The Tegra xHCI controller's firmware communicates requests to the host > processor through a mailbox interface. While there is only a single > physical channel, messages sent by the controller can be divided > into two groups: th

[PATCH] usb: phy: Restore deferred probing path

2014-12-04 Thread Thierry Reding
From: Thierry Reding Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on failure") broke platforms that rely on deferred probing to order probing of PHY and host controller drivers. The reason is that the commit simply propagates errors from __of_usb_fi

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-04 Thread Thierry Reding
On Thu, Dec 04, 2014 at 03:23:06PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/4/2014 3:06 PM, Thierry Reding wrote: > > >From: Thierry Reding > > >Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on > >failure") broke

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-17 Thread Thierry Reding
On Thu, Dec 04, 2014 at 01:06:07PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on > failure") broke platforms that rely on deferred probing to order probing > of PHY and host controll

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-18 Thread Thierry Reding
On Wed, Dec 17, 2014 at 09:34:48AM -0800, Greg Kroah-Hartman wrote: > On Wed, Dec 17, 2014 at 09:30:03AM +0100, Thierry Reding wrote: > > On Thu, Dec 04, 2014 at 01:06:07PM +0100, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > Commi

Re: [PATCH] usb: phy: Restore deferred probing path

2015-01-06 Thread Thierry Reding
On Mon, Jan 05, 2015 at 12:33:51PM -0700, Stephen Warren wrote: > On 12/23/2014 11:36 AM, Felipe Balbi wrote: > >On Thu, Dec 04, 2014 at 01:06:07PM +0100, Thierry Reding wrote: > >>From: Thierry Reding > >> > >>Commit 1290a958d48e ("usb: phy: propagate _

Re: [PATCH 1/4] usb: phy: Fix deferred probing

2015-01-08 Thread Thierry Reding
On Thu, Jan 08, 2015 at 11:24:11AM -0600, Felipe Balbi wrote: > * PGP Signed by an unknown key > > On Thu, Jan 08, 2015 at 06:32:27PM +0200, grygorii.stras...@linaro.org wrote: > > Hi, > > > > On 01/07/2015 06:41 AM, Olof Johansson wrote: > > > On Tue, Jan 6, 2015 at 7:45 AM, Maxime Ripard > > >

Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support

2014-02-12 Thread Thierry Reding
On Mon, Feb 10, 2014 at 01:33:39PM +0800, liujunliang_...@163.com wrote: > From: Liu Junliang > > > Signed-off-by: Liu Junliang > --- > drivers/net/usb/Kconfig | 16 + > drivers/net/usb/Makefile |1 + > drivers/net/usb/sr9800.c | 873 > ++ >

[PATCH] USB: EHCI: tegra: Drop unused defines

2014-02-25 Thread Thierry Reding
From: Thierry Reding Since commit 2d22b42db02f "usb: phy: registering Tegra USB PHY as platform driver" the driver no longer relies on the hard-coded physical addresses to determine the association between PHY and EHCI port, so these defines can be dropped. Signed-off-by: Thie

Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 10:17:10AM +0200, Arnd Bergmann wrote: > On Wednesday 14 May 2014 17:33:02 Andrew Bresticker wrote: [...] > > + /* Create child xhci-plat device */ > > + memset(xhci_resources, 0, sizeof(xhci_resources)); > > + res = platform_get_resource(to_platform_device(dev), IORES

Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 01:18:22PM -0700, Andrew Bresticker wrote: > Arnd, > > On Thu, May 15, 2014 at 1:17 AM, Arnd Bergmann wrote: > > On Wednesday 14 May 2014 17:33:02 Andrew Bresticker wrote: > >> + > >> +int tegra_xhci_register_mbox_notifier(struct notifier_block *nb) > >> +{ > >> + int

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-04 Thread Thierry Reding
On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: > Hi, > > > On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam > wrote: > > Using devm_ioremap_resource() API should actually be preferred over > > devm_ioremap(), since the former request the mem region first and then > > gives back the

Re: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap

2014-06-06 Thread Thierry Reding
On Fri, Jun 06, 2014 at 06:32:42PM +0530, Vivek Gautam wrote: > On Wed, Jun 4, 2014 at 6:43 PM, Thierry Reding > wrote: > > On Wed, Jun 04, 2014 at 03:41:20PM +0530, Vivek Gautam wrote: > >> On Sat, May 10, 2014 at 5:30 PM, Vivek Gautam > >> wrote: [...] > &

Re: [PATCH RESEND V4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:50PM -0700, Andrew Bresticker wrote: [...] > diff --git > a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt > b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt [...] > +Optional properties: > +--- >

Re: [PATCH RESEND V4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:52PM -0700, Andrew Bresticker wrote: [...] > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt > b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt [...] > +- pll_u_480m > +- clk_m > +- pll_e What are these used for

Re: [PATCH RESEND V4 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:53PM -0700, Andrew Bresticker wrote: [...] > diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c [...] > +#define TEGRA_XHCI_NUM_SUPPLIES 8 > +static const char *tegra_xhci_supply_names[TEGRA_XHCI_NUM_SUPPLIES] = { > + "avddio-pex", > + "

Re: [PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:49PM -0700, Andrew Bresticker wrote: [...] > diff --git a/drivers/mailbox/tegra-xusb-mailbox.c > b/drivers/mailbox/tegra-xusb-mailbox.c [...] > +struct tegra_xusb_mbox { > + struct mbox_controller mbox; > + int irq; It seems like this is unused outside of teg

Re: [PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-29 Thread Thierry Reding
On Tue, Oct 28, 2014 at 03:27:51PM -0700, Andrew Bresticker wrote: [...] > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index c6a66de..0f4cdef 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -163,6 +163,7 @@ config PINCTRL_TEGRA_XUSB > select GE

[PATCH] usb: phy: tegra: Do not include asm/mach-types.h

2014-07-07 Thread Thierry Reding
From: Thierry Reding It is no longer needed and keeping it will break 64-bit ARM builds. Signed-off-by: Thierry Reding --- drivers/usb/phy/phy-tegra-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index cd36cb43ecc0

Re: [PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs

2014-07-14 Thread Thierry Reding
On Thu, Jul 10, 2014 at 06:12:48PM +0300, Tuomas Tynkkynen wrote: > Thierry, > > Since Stephen's on a vacation, I'd like to double-check with you that the DT > changes looks good. Greg has applied these to the USB tree today. Yes, looks sane to me. Not sure how much people will like to see the DT

[PATCH] usb: phy: tegra: Avoid use of sizeof(void)

2014-07-21 Thread Thierry Reding
From: Thierry Reding The PHY configuration is stored in an opaque "config" field, but when allocating the structure, its proper size needs to be known. In the case of UTMI, the proper structure is tegra_utmip_config of which a local variable already exists, so we can use that to obtai

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-25 Thread Thierry Reding
On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] > >+static int tegra_xusb_mbox_probe(struct platform_device *pdev) > > >+res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >+if (!res) > >+return -ENOD

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: > > On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: > > > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: > > [...] > > > &

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: > > On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: > > > On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: > > > > On M

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote: > > On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: > > > On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: > > > > On T

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 01:35:34PM +0200, Arnd Bergmann wrote: > On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote: > > On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: > > > > I'm not sure if it's really worth it. One thing we might do is just

Re: [PATCH v8 4/9] mfd: Add binding document for NVIDIA Tegra XUSB

2015-05-20 Thread Thierry Reding
On Wed, May 20, 2015 at 07:35:51AM +0100, Lee Jones wrote: > On Tue, 19 May 2015, Andrew Bresticker wrote: > > > Lee, > > > > On Thu, May 14, 2015 at 10:38 AM, Andrew Bresticker > > wrote: > > > On Thu, May 14, 2015 at 12:40 AM, Lee Jones wrote: > > >> On Thu, 14 May 2015, Jon Hunter wrote: > >

Re: [PATCH v8 4/9] mfd: Add binding document for NVIDIA Tegra XUSB

2015-05-21 Thread Thierry Reding
On Thu, May 21, 2015 at 09:40:01AM +0100, Lee Jones wrote: > On Wed, 20 May 2015, Thierry Reding wrote: > > On Wed, May 20, 2015 at 07:35:51AM +0100, Lee Jones wrote: > > > On Tue, 19 May 2015, Andrew Bresticker wrote: > > > > On Thu, May 14, 2015 at 10:38 AM, An

  1   2   >