we provide editing

2018-07-20 Thread Scott
deliver testing for you, so that you get to know our quality first hand. If you want to explore further, please reply back. Thanks and Regards, Scott -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majo

we provide editing

2018-07-20 Thread Scott
deliver testing for you, so that you get to know our quality first hand. If you want to explore further, please reply back. Thanks and Regards, Scott -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH V3 RESEND] phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-05-24 Thread Scott Branden
usb3->phy = devm_phy_create(dev, NULL, &ops); > +if (IS_ERR(usb3->phy)) { > +dev_err(dev, "Failed to create PHY\n"); > +return PTR_ERR(usb3->phy); > +} > + > +phy_set_drvdata(usb3->phy, usb3); > +platform_set_drvdata(pd

[PATCH] Validate num_values for HIDIOCGUSAGES, HIDIOCSUSAGES commands.

2016-06-23 Thread Scott Bauer
This patch validates the num_values parameter from userland during the HIDIOCGUSAGES and HIDIOCSUSAGES commands. Previously, if the report id was set to HID_REPORT_ID_UNKNOWN, we would fail to validate the num_values parameter leading to a heap overflow. Signed-off-by: Scott Bauer --- drivers

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
s in linux today. If modified in the future adapt to it as needed? Regards, Scott -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
Hi Florian, On 17-01-19 11:40 AM, Florian Fainelli wrote: On 01/19/2017 11:30 AM, Scott Branden wrote: Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: This patch adds device tree bindings documentation for Synopsys USB

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

2017-01-19 Thread Scott Branden
On 17-01-19 01:55 PM, Ray Jui wrote: On 1/19/2017 12:17 PM, Florian Fainelli wrote: On 01/19/2017 12:07 PM, Scott Branden wrote: Hi Florian, On 17-01-19 11:40 AM, Florian Fainelli wrote: On 01/19/2017 11:30 AM, Scott Branden wrote: Hi Rob, On 17-01-19 09:36 AM, Rob Herring wrote: On

Re: [upstream-release] [PATCH 1/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver support

2016-11-14 Thread Scott Wood
gt;phy_base) { > + dev_err(dev, "failed to remap phy_base memory\n"); > + ret = -ENOMEM; > + goto err_out; > + } > + > + phy->has_erratum_flag = 0; > + for (i = 0; i < ARRAY_SIZE(phy_erratum_tbl); i++) &g

Re: [upstream-release] [PATCH 1/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver support

2016-11-16 Thread Scott Wood
On 11/15/2016 06:39 AM, Sriram Dash wrote: >> From: Scott Wood >> On 11/13/2016 11:27 PM, Sriram Dash wrote: >>> diff --git a/Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt >>> b/Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt >>> new file

Re: [upstream-release] [PATCH 1/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver support

2016-11-16 Thread Scott Wood
On 11/16/2016 05:33 AM, Sriram Dash wrote: >> From: Scott Wood >> On 11/15/2016 06:39 AM, Sriram Dash wrote: >>>> From: Scott Wood >>>> On 11/13/2016 11:27 PM, Sriram Dash wrote: >>>>> diff --git >>>>> a/Documentation/devicetre

Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-21 Thread Scott Branden
pt line + - phys: phandle to phy node. + +Example: + udc_dwc: usb@664e { + compatible = "brcm,ns2-udc", "brcm,cygnus-udc"; compatible = "brcm,ns2-udc", "brcm,iproc-udc"; + reg = <0x664e 0x2000>; + inter

Re: [PATCH v2 6/6] UDC: Add Synopsys UDC Platform driver

2017-02-21 Thread Scott Branden
dev_dbg(udc->dev, "idle -> device\n"); + start_udc(udc); + } + + return 0; +} +static const struct dev_pm_ops udc_plat_pm_ops = { + .suspend= udc_plat_suspend, + .resume = udc_plat_resume, +}; +#endif + +#if defined(CONFIG_OF) +static const struct of_device_id of_udc_match[] = { + { .compatible = "brcm,ns2-udc", }, + { .compatible = "brcm,cygnus-udc", }, { .compatible = "brcm,iproc-udc", }, + { } +}; +MODULE_DEVICE_TABLE(of, of_udc_match); +#endif + +static struct platform_driver udc_plat_driver = { + .probe = udc_plat_probe, + .remove = udc_plat_remove, + .driver = { + .name = "snps-udc-plat", + .of_match_table = of_match_ptr(of_udc_match), +#ifdef CONFIG_PM_SLEEP + .pm = &udc_plat_pm_ops, +#endif + }, +}; +module_platform_driver(udc_plat_driver); + +MODULE_DESCRIPTION(UDC_MOD_DESCRIPTION); +MODULE_AUTHOR("Broadcom"); +MODULE_LICENSE("GPL v2"); Regards, Scott -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] musb: don't reset endpoint data toggle on blackfin

2013-07-18 Thread Scott Jiang
Reset endpoint data toggle would lead to failure for musb RTL version 1.9 on blackfin. Signed-off-by: Scott Jiang --- drivers/usb/musb/musb_host.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index

Re: [PATCH] musb: don't reset endpoint data toggle on blackfin

2013-07-26 Thread Scott Jiang
Hi Balbi, > On Thu, Jul 18, 2013 at 07:04:14PM -0400, Scott Jiang wrote: >> Reset endpoint data toggle would lead to failure for musb >> RTL version 1.9 on blackfin. > > is this specific to musb 1.9 or to blackfin ? > I'm not sure about this. It failed in musb 1.9

Re: [PATCH] musb: don't reset endpoint data toggle on blackfin

2013-07-31 Thread Scott Jiang
Hi Balbi, >> >> > On Thu, Jul 18, 2013 at 07:04:14PM -0400, Scott Jiang wrote: >> >> Reset endpoint data toggle would lead to failure for musb >> >> RTL version 1.9 on blackfin. >> > >> > is this specific to musb 1.9 or to blackfin ? >&g

new USB serial device: Garmin USB ANT stick

2013-08-03 Thread Scott Alfter
need to add this device to the kernel so it will auto-load? Scott Alfter sc...@alfter.us -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQGcBAEBAgAGBQJR/TCAAAoJEArTX6uSx2icF+M

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

2008-02-21 Thread Scott Wood
Anton Vorontsov wrote: Without this patch it's impossible to select ehci-fsl on PPC_MPC837x. Another option would be to convert USB_EHCI_FSL to verbose bool, but I presume EHCI_FSL is purposely made silent. I think making it verbose bool would be better. -Scott - To unsubscribe from this

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

2008-02-21 Thread Scott Wood
don't have this hardware? There are very few cases where default y is justified. This isn't one of them. -Scott - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] usb: ohci-platform: add support for multiple phys per controller

2014-12-10 Thread Scott Branden
On 14-12-05 01:28 PM, arun.ramamur...@broadcom.com wrote: From: Arun Ramamurthy Added support for cases where one controller is connected to multiple phys Signed-off-by: Arun Ramamurthy Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- drivers/usb/host/ohci-platform.c | 70

[PATCH 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-08-18 Thread Scott Branden
toggle between even and odd parity until the Transfer Complete interrupt is received. Signed-off-by: Roman Bacik Reviewed-by: Abhinav Ratna Reviewed-by: Srinath Mannam Reviewed-by: Scott Branden Signed-off-by: Scott Branden --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c | 48

[PATCH 0/1] USB DWC2 parity fix in isochronous mode

2015-08-18 Thread Scott Branden
This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the commit message. Roman Bacik (1): usb: dwc2: gadget: parity fix in isochronous mode drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c

[PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-08-31 Thread Scott Branden
toggle between even and odd parity until the Transfer Complete interrupt is received. Signed-off-by: Roman Bacik Reviewed-by: Abhinav Ratna Reviewed-by: Srinath Mannam Signed-off-by: Scott Branden --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c | 51

[PATCH v2 0/1] USB DWC2 parity fix in isochronous mode

2015-08-31 Thread Scott Branden
This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the commit message. Changes from v1: - Address code review comments as per previous responses: - renamed parity_set to has_correct_parity and reorder

[PATCH v3 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-09-10 Thread Scott Branden
toggle between even and odd parity until the Transfer Complete interrupt is received. Signed-off-by: Roman Bacik Reviewed-by: Abhinav Ratna Reviewed-by: Srinath Mannam Signed-off-by: Scott Branden --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c | 58

[PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

2015-09-10 Thread Scott Branden
This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the commit message. Changes from v2: - created s2c_hsotg_chage_ep_iso_parity function to call function in 3 places in code - used hsotg->num_of_eps

Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

2015-09-23 Thread Scott Branden
Hi John, Could you please review the v3 Patch. I believe we have address all of your comments? On 15-09-10 06:13 PM, Scott Branden wrote: This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the

Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

2015-09-23 Thread Scott Branden
On 15-09-23 01:18 AM, John Youn wrote: On 9/23/2015 1:11 AM, John Youn wrote: On 9/23/2015 12:36 AM, Scott Branden wrote: Hi John, Could you please review the v3 Patch. I believe we have address all of your comments? Yes I've been meaning to test it on our platforms. I should be ab

Re: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-19 Thread Scott Feldman
On Sun, Jan 18, 2015 at 11:13 PM, Hayes Wang wrote: > If a error occurs when submitting rx, skip the remaining submissions > and try to submit them again next time. > > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions

Re: [PATCH net-next 1/7] r8152: adjust rx_bottom

2015-01-26 Thread Scott Feldman
uld change it. Therefore, I don't think it needs the spin lock. Sorry guys, I think I made a mistake in my review and caused some confusion/grief. My mistake was getting the params to list_add_tail() backwards. It's list_add_tail(entry, head). I saw list_add_tail(&agg->list, next

[PATCH 18/22] usb: gadget: serial: %pF is only for function pointers

2015-03-11 Thread Scott Wood
Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Signed-off-by: Scott Wood Cc: linux-usb@vger.kernel.org Cc: Felipe Balbi --- drivers/usb/gadget/function/u_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers

2015-03-11 Thread Scott Wood
On Wed, 2015-03-11 at 23:45 -0500, Felipe Balbi wrote: > On Wed, Mar 11, 2015 at 10:13:53PM -0500, Scott Wood wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. > > > > Signed-o

Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers

2015-03-12 Thread Scott Wood
On Thu, 2015-03-12 at 12:51 -0300, Fabio Estevam wrote: > On Thu, Mar 12, 2015 at 12:13 AM, Scott Wood wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. > > From Docume

Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers

2015-03-12 Thread Scott Wood
On Thu, 2015-03-12 at 15:36 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/12/2015 6:13 AM, Scott Wood wrote: > > > Use %pS for actual addresses, otherwise you'll get bad output > > %pS or %ps? > > > on arches like ppc64 where %pF expects a functio

[PATCH v2 18/22] usb: gadget: serial: %pf is only for function pointers

2015-03-12 Thread Scott Wood
Use %ps for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pf expects a function descriptor (which is not what __builtin_return_address returns). Signed-off-by: Scott Wood Cc: linux-usb@vger.kernel.org Cc: Felipe Balbi Cc: Fabio Estevam CC: Sergei Sht