Re: [PATCH v3 08/11] usb: phy-mxs: Enable IC fixes for related SoCs

2013-11-05 Thread Michał Mirosław
_ABNORAML_IN_SUSPEND, bit 17 is the effective bit > + * in HW_USBPHY_IP. > + */ > +#define MXS_PHY_FIX_ABNORAML_IN_SUSPENDBIT(17) [...] s/ABNORAML/ABNORMAL/ ? Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/5] usb: gadget: u_serial: console for multiple ports

2019-03-22 Thread Michał Mirosław
On Wed, Feb 27, 2019 at 11:46:56AM +0100, Michał Mirosław wrote: > This series makes it possible to have more control over console using > USB serial gadget ports. This can be useful when you need more than > one USB console or are configuring multiple serial port function via > config

Re: [PATCH v2 0/5] usb: gadget: u_serial: Fix and cleanup

2019-07-14 Thread Michał Mirosław
and following inittab: > console::respawn:/sbin/getty -L 115200 ttyS0 vt100 > console::respawn:/sbin/getty -L 115200 ttyGS0 vt100 > > However there is an issue remaining: > Disconnect triggers WARN_ON in gs_close: [...] Hi, Can you try a patchset I sent some time ago [1] if it f

Re: [PATCH v2 0/5] usb: gadget: u_serial: Fix and cleanup

2019-07-14 Thread Michał Mirosław
On Sun, Jul 14, 2019 at 12:04:26PM +0200, Michał Mirosław wrote: > On Sat, Jul 13, 2019 at 11:08:53PM +0200, Ladislav Michl wrote: > > Following patchset makes console work (patch 1 and 4) for an AT91SAM9G20 > > board connected to xhci_hcd and does some cleanup. > >

[PATCH v4 1/6] usb: gadget: u_serial: add missing port entry locking

2019-07-22 Thread Michał Mirosław
gserial_alloc_line() misses locking (for a release barrier) while resetting port entry on TTY allocation failure. Fix this. Cc: sta...@vger.kernel.org Signed-off-by: Michał Mirosław Reviewed-by: Greg Kroah-Hartman Tested-by: Ladislav Michl --- v4: no changes v3: cc-stable v2: no changes

[PATCH v4 3/6] usb: gadget: u_serial: make OBEX port not a console

2019-07-22 Thread Michał Mirosław
Prevent OBEX serial port from ever becoming a console. Console messages will definitely break the protocol, and since you have to instantiate the port making it explicitly for OBEX, there is no point in allowing console to break it by mistake. Signed-off-by: Michał Mirosław Reviewed-by: Greg

[PATCH v4 0/6] usb: gadget: u_serial: console improvements

2019-07-22 Thread Michał Mirosław
://rere.qmqm.pl/git/linux usb-console Michał Mirosław (6): usb: gadget: u_serial: add missing port entry locking usb: gadget: u_serial: reimplement console support usb: gadget: u_serial: make OBEX port not a console usb: gadget: u_serial: allow more console gadget ports usb: gadget: u_serial

[PATCH v4 6/6] USB: gadget: legacy/serial: allow dynamic removal

2019-07-22 Thread Michał Mirosław
Legacy serial USB gadget is still useful as an early console, before userspace is up. Later it could be replaced with proper configfs-configured composite gadget - that use case is enabled by this patch. Signed-off-by: Michał Mirosław --- v4: initial revision, new in the patchset

[PATCH v4 5/6] usb: gadget: u_serial: diagnose missed console messages

2019-07-22 Thread Michał Mirosław
[0.064130] pinctrl [missed 114987 bytes] [4.302299] udevd[134]: starting version 3.2.5 [4.306845] random: udevd: uninitialized urandom read (16 bytes read) Signed-off-by: Michał Mirosław Reviewed-by: Greg Kroah-Hartman --- v4: no changes v3: added example output + lowercase

[PATCH v4 2/6] usb: gadget: u_serial: reimplement console support

2019-07-22 Thread Michał Mirosław
Rewrite console support to fix a few shortcomings of the old code preventing its use with multiple ports. This removes some duplicated code and replaces a custom kthread with simpler workqueue item. Only port ttyGS0 gets to be a console for now. Signed-off-by: Michał Mirosław Reviewed-by: Greg

[PATCH v4 4/6] usb: gadget: u_serial: allow more console gadget ports

2019-07-22 Thread Michał Mirosław
Allow configuring more than one console using USB serial or ACM gadget. By default, only first (ttyGS0) is a console, but this may be changed using function's new "console" attribute. Signed-off-by: Michał Mirosław --- v4: fixed locking in gserial_set_console() v3: no c

[PATCH v5 0/6] usb: gadget: u_serial: console improvements

2019-07-22 Thread Michał Mirosław
://rere.qmqm.pl/git/linux usb-console Michał Mirosław (6): usb: gadget: u_serial: add missing port entry locking usb: gadget: u_serial: reimplement console support usb: gadget: u_serial: make OBEX port not a console usb: gadget: u_serial: allow more console gadget ports usb: gadget: u_serial

[PATCH v5 1/6] usb: gadget: u_serial: add missing port entry locking

2019-07-22 Thread Michał Mirosław
gserial_alloc_line() misses locking (for a release barrier) while resetting port entry on TTY allocation failure. Fix this. Cc: sta...@vger.kernel.org Signed-off-by: Michał Mirosław Reviewed-by: Greg Kroah-Hartman Tested-by: Ladislav Michl --- v5: no changes v4: no changes v3: cc-stable

[PATCH v5 5/6] usb: gadget: u_serial: diagnose missed console messages

2019-07-22 Thread Michał Mirosław
[0.064130] pinctrl [missed 114987 bytes] [4.302299] udevd[134]: starting version 3.2.5 [4.306845] random: udevd: uninitialized urandom read (16 bytes read) Signed-off-by: Michał Mirosław Reviewed-by: Greg Kroah-Hartman --- v5: no changes v4: no changes v3: added example output

[PATCH v5 2/6] usb: gadget: u_serial: reimplement console support

2019-07-22 Thread Michał Mirosław
Rewrite console support to fix a few shortcomings of the old code preventing its use with multiple ports. This removes some duplicated code and replaces a custom kthread with simpler workqueue item. Only port ttyGS0 gets to be a console for now. Signed-off-by: Michał Mirosław Reviewed-by: Greg

[PATCH v5 4/6] usb: gadget: u_serial: allow more console gadget ports

2019-07-22 Thread Michał Mirosław
Allow configuring more than one console using USB serial or ACM gadget. By default, only first (ttyGS0) is a console, but this may be changed using function's new "console" attribute. Signed-off-by: Michał Mirosław --- v5: fixed locking in gserial_get_console() v4: f

[PATCH v5 3/6] usb: gadget: u_serial: make OBEX port not a console

2019-07-22 Thread Michał Mirosław
Prevent OBEX serial port from ever becoming a console. Console messages will definitely break the protocol, and since you have to instantiate the port making it explicitly for OBEX, there is no point in allowing console to break it by mistake. Signed-off-by: Michał Mirosław Reviewed-by: Greg

[PATCH v5 6/6] usb: gadget: legacy/serial: allow dynamic removal

2019-07-22 Thread Michał Mirosław
Legacy serial USB gadget is still useful as an early console, before userspace is up. Later it could be replaced with proper configfs-configured composite gadget - that use case is enabled by this patch. Signed-off-by: Michał Mirosław --- v5: no changes v4: initial revision, new in the

Re: [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support

2019-07-23 Thread Michał Mirosław
On Tue, Jul 23, 2019 at 10:18:15AM +0800, Baolin Wang wrote: > Hi Michal, > > On Mon, 22 Jul 2019 at 23:26, Michał Mirosław wrote: > > > > Rewrite console support to fix a few shortcomings of the old code > > preventing its use with multiple ports. This removes s

Re: [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support

2019-08-10 Thread Michał Mirosław
On Fri, Aug 09, 2019 at 03:05:55PM +0300, Felipe Balbi wrote: > > Hi, > > Michał Mirosław writes: > > Rewrite console support to fix a few shortcomings of the old code > > preventing its use with multiple ports. This removes some duplicated > > code and replaces

[PATCH v6 4/7] usb: gadget: u_serial: allow more console gadget ports

2019-08-10 Thread Michał Mirosław
Allow configuring more than one console using USB serial or ACM gadget. By default, only first (ttyGS0) is a console, but this may be changed using function's new "console" attribute. Signed-off-by: Michał Mirosław --- v6: rebased on balbi/testing/next v5: f

[PATCH v6 3/7] usb: gadget: u_serial: make OBEX port not a console

2019-08-10 Thread Michał Mirosław
Prevent OBEX serial port from ever becoming a console. Console messages will definitely break the protocol, and since you have to instantiate the port making it explicitly for OBEX, there is no point in allowing console to break it by mistake. Signed-off-by: Michał Mirosław Reviewed-by: Greg

[PATCH v6 6/7] usb: gadget: legacy/serial: allow dynamic removal

2019-08-10 Thread Michał Mirosław
Legacy serial USB gadget is still useful as an early console, before userspace is up. Later it could be replaced with proper configfs-configured composite gadget - that use case is enabled by this patch. Signed-off-by: Michał Mirosław --- v6: rebased on balbi/testing/next v5: no changes

[PATCH v6 5/7] usb: gadget: u_serial: diagnose missed console messages

2019-08-10 Thread Michał Mirosław
[0.064130] pinctrl [missed 114987 bytes] [4.302299] udevd[134]: starting version 3.2.5 [4.306845] random: udevd: uninitialized urandom read (16 bytes read) Signed-off-by: Michał Mirosław Reviewed-by: Greg Kroah-Hartman --- v6: rebased on balbi/testing/next v5: no changes v4

[PATCH v6 2/7] usb: gadget: u_serial: reimplement console support

2019-08-10 Thread Michał Mirosław
Rewrite console support to fix a few shortcomings of the old code preventing its use with multiple ports. This removes some duplicated code and replaces a custom kthread with simpler workqueue item. Only port ttyGS0 gets to be a console for now. Signed-off-by: Michał Mirosław Reviewed-by: Greg

[PATCH v6 7/7] usb: gadget: u_serial: use mutex for serialising open()s

2019-08-10 Thread Michał Mirosław
Remove home-made waiting mechanism from gs_open() and rely on portmaster's mutex to do the job. Note: This releases thread waiting on close() when another thread open()s simultaneously. Signed-off-by: Michał Mirosław --- v6: initial revision, new in the patchset --- drivers/usb/g

[PATCH v6 0/7] usb: gadget: u_serial: console improvements

2019-08-10 Thread Michał Mirosław
: https://rere.qmqm.pl/git/linux usb-console Michał Mirosław (7): usb: gadget: u_serial: add missing port entry locking usb: gadget: u_serial: reimplement console support usb: gadget: u_serial: make OBEX port not a console usb: gadget: u_serial: allow more console gadget ports usb: gadget

[PATCH v6 1/7] usb: gadget: u_serial: add missing port entry locking

2019-08-10 Thread Michał Mirosław
gserial_alloc_line() misses locking (for a release barrier) while resetting port entry on TTY allocation failure. Fix this. Cc: sta...@vger.kernel.org Signed-off-by: Michał Mirosław Reviewed-by: Greg Kroah-Hartman Tested-by: Ladislav Michl --- v6: rebased on balbi/testing/next v5: no

Re: [PATCH v2 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-07-27 Thread Michał Mirosław
ing between host and device modes. > > Signed-off-by: Thierry Reding > [dig...@gmail.com: rebased patches and added DMA alignment quirk for Tegra20] > Signed-off-by: Dmitry Osipenko > Acked-by: Peter Chen This works on my Asus TF300T (Tegra3 device). Minor nit below. Tes

Re: [PATCH v2 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-07-28 Thread Michał Mirosław
On Fri, Jul 28, 2017 at 01:00:32PM +0300, Dmitry Osipenko wrote: > On 28.07.2017 01:32, Michał Mirosław wrote: > > On Thu, Jul 27, 2017 at 07:46:07PM +0300, Dmitry Osipenko wrote: > >> From: Thierry Reding > >> > >> All of these Tegra SoC generations have a Ch

[PATCH] usb: gadget: u_serial: process RX in workqueue instead of tasklet

2018-12-16 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- * against v4.19.9 --- drivers/usb/gadget/function/u_serial.c | 35 +++--- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index 29436f75bbe0..65

Re: [PATCH] usb: gadget: u_serial: process RX in workqueue instead of tasklet

2018-12-17 Thread Michał Mirosław
On Mon, Dec 17, 2018 at 08:59:42AM +0200, Felipe Balbi wrote: > > Hi, > > Michał Mirosław writes: > > Switch RX processing from tasklet to (delayed) work queue. This allows > > receiver more room to process incoming data and prevents flood of > > "ttyGS0

[PATCH 3/5] usb: gadget: u_serial: make OBEX port not a console

2019-02-26 Thread Michał Mirosław
Prevent OBEX serial port from ever becoming a console. Signed-off-by: Michał Mirosław --- drivers/usb/gadget/function/f_acm.c| 2 +- drivers/usb/gadget/function/f_obex.c | 2 +- drivers/usb/gadget/function/f_serial.c | 2 +- drivers/usb/gadget/function/u_serial.c | 4 ++-- drivers/usb

[PATCH 4/5] usb: gadget: u_serial: allow more console gadget ports

2019-02-26 Thread Michał Mirosław
Allow configuring more than one console using USB serial or ACM gadget. By default, only first (ttyGS0) is a console, but this may be changed using function's new "console" attribute. Signed-off-by: Michał Mirosław --- drivers/usb/gadget/function/f_acm.c| 21 ++

[PATCH 2/5] usb: gadget: u_serial: reimplement console support

2019-02-26 Thread Michał Mirosław
Rewrite console support to fix a few shortcomings of the old code preventing its use with multiple ports. This removes some duplicated code and replaces a custom kthread with simpler workqueue item. Only port ttyGS0 gets to be a console for now. Signed-off-by: Michał Mirosław --- drivers/usb

[PATCH 1/5] usb: gadget: u_serial: add missing port entry locking

2019-02-26 Thread Michał Mirosław
gserial_alloc_line() misses locking (for a release barrier) while resetting port entry on TTY allocation failure. Fix this. Signed-off-by: Michał Mirosław --- drivers/usb/gadget/function/u_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/function/u_serial.c b

[PATCH 0/5] usb: gadget: u_serial: console for multiple ports

2019-02-26 Thread Michał Mirosław
This series makes it possible to have more control over console using usb serial gadget ports. This can be useful when you need more than one USB console or are configuring multiple serial port function using configfs. The patches are against usb-next branch. Michał Mirosław (5): usb: gadget

[PATCH 5/5] usb: gadget: u_serial: diagnose missed console messages

2019-02-26 Thread Michał Mirosław
Insert markers in console stream instead of making console output glued together when drops happen. Signed-off-by: Michał Mirosław --- drivers/usb/gadget/function/u_serial.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function

Re: [PATCH 1/5] usb: gadget: u_serial: add missing port entry locking

2019-02-27 Thread Michał Mirosław
On Wed, Feb 27, 2019 at 09:41:07AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 27, 2019 at 08:48:56AM +0100, Michał Mirosław wrote: > > gserial_alloc_line() misses locking (for a release barrier) while > > resetting port entry on TTY allocation failure. Fix this. > > >

[PATCH v2 2/5] usb: gadget: u_serial: reimplement console support

2019-02-27 Thread Michał Mirosław
Rewrite console support to fix a few shortcomings of the old code preventing its use with multiple ports. This removes some duplicated code and replaces a custom kthread with simpler workqueue item. Only port ttyGS0 gets to be a console for now. Signed-off-by: Michał Mirosław --- v2: no

[PATCH v2 5/5] usb: gadget: u_serial: diagnose missed console messages

2019-02-27 Thread Michał Mirosław
Insert markers in console stream marking places where data is missing. This makes the hole in the data stand out clearly instead of glueing together unrelated messages. Signed-off-by: Michał Mirosław --- v2: commit message massage --- drivers/usb/gadget/function/u_serial.c | 15

[PATCH v2 4/5] usb: gadget: u_serial: allow more console gadget ports

2019-02-27 Thread Michał Mirosław
Allow configuring more than one console using USB serial or ACM gadget. By default, only first (ttyGS0) is a console, but this may be changed using function's new "console" attribute. Signed-off-by: Michał Mirosław --- v2: no changes --- drivers/usb/gadget/function/

[PATCH v2 1/5] usb: gadget: u_serial: add missing port entry locking

2019-02-27 Thread Michał Mirosław
gserial_alloc_line() misses locking (for a release barrier) while resetting port entry on TTY allocation failure. Fix this. Signed-off-by: Michał Mirosław --- v2: no changes --- drivers/usb/gadget/function/u_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget

[PATCH v2 3/5] usb: gadget: u_serial: make OBEX port not a console

2019-02-27 Thread Michał Mirosław
Prevent OBEX serial port from ever becoming a console. Console messages will definitely break the protocol, and since you have to instantiate the port making it explicitly for OBEX, there is no point in allowing console to break it by mistake. Signed-off-by: Michał Mirosław --- v2: change of

[PATCH v2 0/5] usb: gadget: u_serial: console for multiple ports

2019-02-27 Thread Michał Mirosław
This series makes it possible to have more control over console using USB serial gadget ports. This can be useful when you need more than one USB console or are configuring multiple serial port function via configfs. The patches are against usb-next branch. Michał Mirosław (5): usb: gadget

Re: [PATCH v2 3/5] usb: gadget: u_serial: make OBEX port not a console

2019-02-27 Thread Michał Mirosław
On Wed, Feb 27, 2019 at 10:36:25AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 27, 2019 at 10:29:38AM +0100, Michał Mirosław wrote: > > /* management of individual TTY ports */ > > +int gserial_alloc_line_raw(unsigned char *port_line); > > int gserial_alloc_line(uns

[PATCH v3 3/5] usb: gadget: u_serial: make OBEX port not a console

2019-02-27 Thread Michał Mirosław
Prevent OBEX serial port from ever becoming a console. Console messages will definitely break the protocol, and since you have to instantiate the port making it explicitly for OBEX, there is no point in allowing console to break it by mistake. Signed-off-by: Michał Mirosław --- v3: rename

[PATCH v3 1/5] usb: gadget: u_serial: add missing port entry locking

2019-02-27 Thread Michał Mirosław
gserial_alloc_line() misses locking (for a release barrier) while resetting port entry on TTY allocation failure. Fix this. Cc: sta...@vger.kernel.org Signed-off-by: Michał Mirosław --- v3: added cc-stable v2: no changes --- drivers/usb/gadget/function/u_serial.c | 2 ++ 1 file changed, 2

[PATCH v3 5/5] usb: gadget: u_serial: diagnose missed console messages

2019-02-27 Thread Michał Mirosław
[0.064130] pinctrl [missed 114987 bytes] [4.302299] udevd[134]: starting version 3.2.5 [4.306845] random: udevd: uninitialized urandom read (16 bytes read) Signed-off-by: Michał Mirosław --- v3: added example output + lowecase 'missed' v2: commit message massage --

[PATCH v3 4/5] usb: gadget: u_serial: allow more console gadget ports

2019-02-27 Thread Michał Mirosław
Allow configuring more than one console using USB serial or ACM gadget. By default, only first (ttyGS0) is a console, but this may be changed using function's new "console" attribute. Signed-off-by: Michał Mirosław --- v3: no changes v2: no changes --- drivers/usb/gadget/f

[PATCH v3 0/5] usb: gadget: u_serial: console for multiple ports

2019-02-27 Thread Michał Mirosław
This series makes it possible to have more control over console using USB serial gadget ports. This can be useful when you need more than one USB console or are configuring multiple serial port function via configfs. The patches are against usb-next branch. Michał Mirosław (5): usb: gadget

[PATCH v3 2/5] usb: gadget: u_serial: reimplement console support

2019-02-27 Thread Michał Mirosław
Rewrite console support to fix a few shortcomings of the old code preventing its use with multiple ports. This removes some duplicated code and replaces a custom kthread with simpler workqueue item. Only port ttyGS0 gets to be a console for now. Signed-off-by: Michał Mirosław --- v3: no