Dear Jiri Kosina,
> On Sun, 5 Aug 2012, Marek Vasut wrote:
> > > diff --git a/drivers/hid/usbhid/hid-quirks.c
> > > b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644
> > > --- a/drivers/hid/usbhid/hid-quirks.c
> > > +++ b/drivers/hid/usb
Dear Jiri Kosina,
> On Wed, 21 Nov 2012, Marek Vasut wrote:
> > > > > diff --git a/drivers/hid/usbhid/hid-quirks.c
> > > > > b/drivers/hid/usbhid/hid-quirks.c index 903eef3..6a09570 100644
> > > > > --- a/drivers/hid/usbhid/hid-quirks.c
Dear Peter Chen,
[...]
> +
> +#define CI_VBUS_STABLE_TIMEOUT 500
Shall we not change this to static const int instead ?
[...]
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1371,6 +1371,7 @@ static int ci13xxx_vbus_session(struct usb_gadget
> *_gadget, int is_active
Dear Peter Chen,
> On Thu, Dec 27, 2012 at 08:21:55AM +0100, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > [...]
> >
> > > +
> > > +#define CI_VBUS_STABLE_TIMEOUT 500
> >
> > Shall we not change this to static const int instead ?
&g
ays define possible values of
fields with offset, so keep this consistent, add the necessary offset
and fix the problem with speed detection.
Signed-off-by: Marek Vasut
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: John Youn
---
drivers/usb/dwc2/hw.h | 8
1 file changed, 4 insertions(+), 4
On Friday, December 18, 2015 at 12:45:56 AM, John Youn wrote:
> On 12/17/2015 2:49 PM, Marek Vasut wrote:
> > The "enumspd" field is located in register DSTS[2:1], but the current
> > set of macros define the possible values without the necessary offset.
> > This in
with speed detection.
Signed-off-by: Marek Vasut
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: John Youn
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
V2: - Modify the code itself by adding the necessary shift instead of
modifying the header.
- Update comm
hink this patch will not be needed if you switch the ar9331 to chipidea hdrc
driver. There is CI HDRC in the ar9331.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/18/2016 05:12 PM, Alan Stern wrote:
> On Tue, 9 Feb 2016, Antony Pavlov wrote:
>
>> This patch retrieves and configures the vbus control gpio via
>> the device tree.
>>
>> This patch is based on a ehci-s5p.c commit fd81d59c90d38661
>> ("USB: ehci-s5p: Add vbus setup function to the s5p ehci
On 02/13/2017 10:29 AM, Johan Hovold wrote:
> [+CC: linux-usb]
>
> Always make sure to CC linux-usb for USB patches.
Got it
> On Fri, Feb 10, 2017 at 05:16:12PM +0100, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT
c->base + id * 4);
1<< 7 ? This yearns for fixing with proper #defined value.
[...]
The rest of the patches looks OK, you can add my Reviewed-By:
to
those. This one though will need further investigation.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the lin
ol. After adding raw hid device support and one hid driver for fsl
> SoC's rom, it can work using hidraw interface.
>
> Thank you!
>
> > What type of device is this?
MX28 bootrom does this. I barely have words for the flubs I unveiled so far in
it.
Greg, do you please h
USB_VENDOR_ID_FRUCTEL 0x25B6
#define USB_DEVICE_ID_GAMETEL_MT_MODE 0x0002
-->8--
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
://bbs.archlinux.org/viewtopic.php?pid=1141340
[4] http://git.bfuser.eu/?p=marex/mxsldr.git;a=summary
Signed-off-by: Marek Vasut
Cc: Chen Peter
Cc: Greg KH
Cc: Jiri Kosina
---
drivers/hid/hid-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid
The USB recovery mode present in i.MX28 ROM emulates USB HID.
It needs this quirk to behave properly.
Signed-off-by: Marek Vasut
Cc: Chen Peter
Cc: Greg KH
Cc: Jiri Kosina
---
drivers/hid/hid-ids.h |3 +++
drivers/hid/usbhid/hid-quirks.c |1 +
2 files changed, 4 insertions
, USB_DEVICE_ID_FREESCALE_MX28,
> HID_QUIRK_NOGET }, { 0, 0 }
OT: btw. the comment mentioned the list should be sorted, yet it's not so for a
while. Maybe a sorting patch would be favored?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
th
d i.mx23.
I recall we had issues with the discon detector on MX28, but on mx28 the chip
was completely deaf (no messages in kernel log).
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Jiri Kosina,
> On Sun, 5 Aug 2012, Marek Vasut wrote:
> > The Freescale i.MX28 BootROM USB recovery mode implements the USB HID
> > protocol, yet the global item tag report size is 128. Linux checks if
> > this is 96 as of now, see [1]. This causes Linux to refuse to
specific?
> return 0;
> }
> @@ -91,6 +117,8 @@ static int mxs_phy_on_disconnect(struct usb_phy *phy,
> int port) {
> dev_dbg(phy->dev, "Disconnect on port %d\n", port);
>
> + /* No need to delay before clearing ENHOSTDISCONDETECT. */
> + dev_dbg(phy->dev, "Clearing ENHOSTDISCONDETECT\n");
> writel_relaxed(BM_USBPHY_CTRL_ENHOSTDISCONDETECT,
> phy->io_priv + HW_USBPHY_CTRL_CLR);
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Fabio Estevam,
> Hi Marek,
>
> On Thu, Aug 30, 2012 at 12:20 PM, Marek Vasut wrote:
> >> +#define MXY_PHY_ENHOSTDISCONDETECT_DELAY 250
> >> +
> >
> > Why 250 ? :)
>
> It is 250 ms. We found this one to be a safe value to enable
>
identify if the controller is OTG
> > supported.
>
> Yes, the next important step is getting the of propertys "dr_mode" and
> "phy_type" properly used in the chipidea core.
>
> [1] http://git.pengutronix.de/?p=mgr/linux.git;a=summary ->
> v3.10/to
Dear Michael Grzeschik,
> Hi Marek,
>
> On Fri, Jun 21, 2013 at 01:26:10PM +0200, Marek Vasut wrote:
> > Hi,
> >
> > > Hi,
> > >
> > > On Wed, May 29, 2013 at 08:07:55AM +, Chen Peter-B29397 wrote:
> > > > > Inde
Hi,
> Dear Michael Grzeschik,
>
> > Hi Marek,
> >
> > On Fri, Jun 21, 2013 at 01:26:10PM +0200, Marek Vasut wrote:
> > > Hi,
> > >
> > > > Hi,
> > > >
> > > > On Wed, May 29, 2013 at 08:07:55AM +, Chen Peter
mp;m=136537318510847&w=2
>
> It may not the USB itself problem, the mx23's usb is almost
> the same with mx28's.
This also happens on a different MX23-based board for me. This other board I
tried has mDDR DRAM and the DRAM is operating correctly. The 96MHz thing people
compla
.
Note that both have working USB peripheral mode in U-Boot too, but the driver
in
U-Boot is very minimalistic.
> Shawn, marek reported the udc function at mx23 works abnormal, but it works
> good at mx28. Have you tried mx23 udc recently?
Fabio, can you possibly test on MX23EVK please?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Fabio Estevam,
> On Tue, Jun 25, 2013 at 11:23 AM, Fabio Estevam wrote:
> > On Mon, Jun 24, 2013 at 10:51 AM, Marek Vasut wrote:
> >> Fabio, can you possibly test on MX23EVK please?
> >
> > I never used USB gadget with chipidea driver.
> >
>
>
> > Note that both have working USB peripheral mode in U-Boot too, but the
> > driver in
> > U-Boot is very minimalistic.
>
> You mean, the larger data transfer with USB peripheral mode is ok at
> u-boot? but it can't work at Linux Kernel?
Yes, but the U-Bo
eout. Do you have any hint for me?
btw. what is the plan about cleaning up and upstreaming all these patches we
have here? Is anyone working on it? I'd hate to stomp on anyones' efforts,but
I'd also like to see this mess sorted out.
Best regards,
Marek Vasut
--
To unsubscribe from t
;
> > efforts,but
> > I'd also like to see this mess sorted out.
>
> We had something un-decided before, now, things almost are cleared.
> But I am a little busy recently, I hope I can begin to work on it
> from next week.
Ok then, I won't interfere.
Best regards,
e problems that the vbus can't lower than 0.8v.
> >
> > How can I check that?
>
> Just measure the voltage of your otg vbus pin.
Ok, I see it's 2.25 volts after I disconnect the microB-A thing . I should see
0.8V constantly with nothing connected on the port?
Best regar
that the vbus can't lower than 0.8v.
> >
> > How can I check that?
>
> Just measure the voltage of your otg vbus pin.
It's 2.5 volt for me. What am I supposed to observe happening there?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubs
Hi Peter,
> > -Original Message-
> > From: Marek Vasut [mailto:ma...@denx.de]
> > Sent: Sunday, July 07, 2013 9:10 AM
> > To: Chen Peter-B29397
> > Cc: shawn@linaro.org; Michael Grzeschik; maxime.ripard@free-
> > electrons.com; Hector Palacios;
heck the hardware too, thanks.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
> Add shawn.
>
> Marek, have you tried mx23 evk?
Ok, I just tried the MX23EVK. Running "dmesg" via telnet connection resulted in
a hang of the USB driver (likely), but since I have serial connection to the
board, I was able to verify the board itself didn't crash. I
ci_hdrc *ci)
> +{
> + if (ci->platdata->otg_cap != OTG_CAP_ATTR_IS_NOT_EXISTED)
IS_NONEXISTENT , no?
[..]
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
S,
};
struct resource *res;
int ret;
[1]
http://git.pengutronix.de/?p=mgr/linux.git;a=shortlog;h=refs/heads/v3.10/topic/usb-
peterchen
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Peter Chen,
> On Thu, Jul 11, 2013 at 05:36:10PM +0200, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > > Since we need otgsc to know vbus's status at some chipidea
> > > controllers even it is peripheral-only mode. Besides, some
> > > SoCs
Hi Peter,
> On Thu, Jul 11, 2013 at 07:57:19PM +0200, Marek Vasut wrote:
> > Hi Peter,
> >
> > > This patchset adds tested otg id switch function and
> > > vbus connect and disconnect detection for chipidea driver.
> > > And fix kinds of bugs found at ch
Hi Peter,
> On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote:
> > Hi Peter,
> >
> > > On Thu, Jul 11, 2013 at 07:57:19PM +0200, Marek Vasut wrote:
> > > > Hi Peter,
> > > >
> > > > > This patchset adds tested otg id swit
Hi Peter,
> On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote:
> > Hi Peter,
> >
> > > On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote:
> > > > Hi Peter,
> > > >
> > > > > On Thu, Jul 11, 20
Dear Peter Chen,
> On Mon, Jul 22, 2013 at 03:15:28AM +0200, Marek Vasut wrote:
> > Hi Peter,
> >
> > > On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote:
> > > > Hi Peter,
> > > >
> > > > > On Fri, Jul 12, 20
Hi Peter,
> On Mon, Jul 22, 2013 at 03:40:32AM +0200, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > > On Mon, Jul 22, 2013 at 03:15:28AM +0200, Marek Vasut wrote:
> > > > Hi Peter,
> > > >
> > > > > On Fri, Jul 12, 20
orm.
> My chipidea repo: https://github.com/hzpeterchen/linux-usb.git
Patchset:
Tested-by: Marek Vasut
on two STMP3780-based boards (not yet mainline) and two MX28-based boards.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
Dear Peter Chen,
> On Thu, Jul 25, 2013 at 07:55:23AM +0200, Marek Vasut wrote:
> > Hi Peter,
> >
> > > I have not tried the manual switching, but first, you need to close
> > > your vbus supply.
> >
> > I think we can close this issue, I will no
> + disable-over-current;
> + dr_mode = "peripheral";
> + status = "okay";
> +};
> +
> &usdhc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usdhc1_2>;
>
>
> However, I am not able to g
ged to test g_ether on mx28, but not on mx6.
>
> Will try tomorrow on mx6q-sabresd.
>
Does OTG work for you on MX28 ?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
escale /$
> > root@freescale /$
> >
> > As you can see there is no g_ether being detected.
>
> Please compile g_ether as loadable module, not build-in.
Would that make a difference? If so (and I can guess it might), it's a bug
anyway.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
b/drivers/usb/phy/phy-mxs-usb.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright 2012 Freescale Semiconductor, Inc.
> + * Copyright 2012-2013 Freescale Semiconductor, Inc.
> * Copyright (C) 2012 Marek Vasut
> * on behalf of DENX Software Engineering GmbH
> *
> @@ -29,8 +29,17 @@
> #defi
Dear Peter Chen,
> On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > > With the auto setting, the PHY's clock and power can be
> > > recovered correctly from low power mode, it is ganranteed by IC logic.
> >
Dear Peter Chen,
> On Tue, Sep 10, 2013 at 10:18:04AM +0200, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > > On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote:
> > > > Dear Peter Chen,
> > >
> > > Please see my commit log, the
evk for vbus and id detection.
> I am afraid I have not updated my tree with mx28 updates.
Just curious, how do you boot the linux kernel on your EVK? Do you use imx
bootlets or uboot (which one, mainline?) or even some other setup ?
[...]
Best regards,
Marek Vasut
--
To unsubscribe from this
>bind fails?
>
> I will start debugging it, but would appreciate any suggestions.
gadgetfs_probe() returns -EISNAM unconditionally. That's rather strange.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
gt; return value for usb_gadget_probe_driver.
>
> Due to above reasons, mark gadget's init as late_initcall may be a
> moderate solution.
>
> Signed-off-by: Peter Chen
Seems this tries to paper over an issue with module dependencies , no?
Best regards,
Marek Vasut
--
To un
ation of udc
> (or its controller driver) is deferred, the composite gadget driver has no
> way to know it, unless we change gadget framework a lot, eg add probe API
> for composite driver, create a thread to check udc creation if there is no
> udc, etc.
I do see the problem. I'm
phy_hw_init(struct mxs_phy *mxs_phy)
> BM_USBPHY_CTRL_ENUTMILEVEL3,
> base + HW_USBPHY_CTRL_SET);
>
> + /* Enable IC solution */
> + if (is_mx6q_phy(mxs_phy) || is_mx6sl_phy(mxs_phy))
> + writel(BM_USBPHY_IP_FIX, base + HW_USBPHY_IP_SET);
&
Dear Peter Chen,
> Add notify_suspend and notify_resume according to different SoCs.
>
> Signed-off-by: Peter Chen
> ---
> drivers/usb/phy/phy-mxs-usb.c | 73
> + 1 files changed, 73
> insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-m
Dear Peter Chen,
> When we need the PHY can be waken up by external signals,
> we can call this API. Besides, we call mxs_phy_disconnect_line
> at this API to close the connection between USB PHY and
> controller, after that, the line state from controller is SE0.
> Once the PHY is out of power, w
d wakeup interrupt when the PHY is out of power
Uh oh, this might needs some rewording. I didn't understand the reason for this
prop before I checked the 12/12 patch.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the
t, all hardware using chipidea core should support runtime pm.
> But some of platforms need special glue layer operations to support
> it, it will break other platforms if enable chipidea core runtime pm.
> Since device tree describes hardware property, maybe I should move
> it to
Dear Peter Chen,
> On Sat, Oct 12, 2013 at 11:38:16AM +0200, Marek Vasut wrote:
> > Hi,
> >
> > > After adding IC fixes bits, some PHY bugs are fixed by
> > > IC logic.
> >
> > Can you please elaborate what those bits do exactly ? They seem like a
Dear Peter Chen,
> On Sat, Oct 12, 2013 at 11:42:06AM +0200, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > > Add notify_suspend and notify_resume according to different SoCs.
> > >
> > > Signed-off-by: Peter Chen
> > > ---
t struct ci_hdrc_imx_platform_flag imx28_usb_data = {
> + .flags = CI_HDRC_IMX_IMX28_WRITE_FIX,
> +};
> +
> +static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
> + { .compatible = "fsl,imx28-usb", .data = &imx28_usb_data},
> + { .compatible = "fsl,imx27-usb&qu
gt; - reg: Should contain registers location and length
> - interrupts: Should contain controller interrupt
Does the ERRATA apply to MX23 as well btw?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Shawn,
> On Sun, Oct 27, 2013 at 05:25:36PM +0100, Marek Vasut wrote:
> > > +static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
> > > + { .compatible = "fsl,imx28-usb", .data = &imx28_usb_data},
> > > + { .compatible = "fsl,imx27-usb&quo
Dear Hector Palacios,
> Dear Peter,
>
> On 10/25/2013 08:02 AM, Peter Chen wrote:
> > According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB
> > register error issue", All USB register write operations must
> > use the ARM SWP instruction. So, we implement special hw_write
> > and hw_te
Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will
get -EPROBE_DEFER from usbmisc when both are compiled into the kernel
and thus USB gadget mode won't work.
Signed-off-by: Marek Vasut
Cc: Alexander Shishkin
Cc: Peter Chen
---
drivers/usb/chipidea/usbmisc_imx.c
sing
> a better way to fix it.
>
> http://marc.info/?l=linux-usb&m=138060107809076&w=2
Argh, I see. So what's the solution here really ?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a mess
Hi Michael,
> Hi Marek,
>
> On Sun, Nov 17, 2013 at 11:59:10PM +0100, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > > > Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will
> > > > get -EPROBE_DEFER from usbmisc when both are compile
; - obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_imx.o usbmisc_imx.o
> + obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o ci_hdrc_imx.o
> endif
How is this supposed to work please? Can you explain me the trick here please?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the l
oes the compile order here matter please? What if I use 'make -j N', which
will cause the files to be compiled in parallel?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Greg,
> On Fri, Nov 22, 2013 at 04:34:14PM +0100, Marek Vasut wrote:
> > Hi Peter,
> >
> > > > > endif
> > > > >
> > > > > ifneq ($(CONFIG_OF),)
> > > > >
> > > > > - obj-$(CONFIG_U
Hello Michael,
> Hi Marek, Peter,
>
> On Sat, Aug 25, 2012 at 01:51:38AM +0200, Marek Vasut wrote:
> > Add the pinmux settings for USB PHY overcurrent pins.
> >
> > Signed-off-by: Marek Vasut
> > Cc: Chris Ball
> > Cc: Fabio Estevam
Dear Richard Zhao,
You know, commit message would be nice to have.
> Signed-off-by: Richard Zhao
Otherwise
Reviewed-by: Marek Vasut
> ---
> drivers/usb/chipidea/core.c |5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/chipide
Dear Peter Chen,
[...]
> +static void ci_wait_vbus_stable(struct ci13xxx *ci, bool low)
> +{
> + unsigned long timeout;
> + u32 otgsc = hw_read(ci, OP_OTGSC, ~0);
> +
> + timeout = jiffies + CI_WAIT_VBUS_STABLE_TIMEOUT;
> +
> + if (low) {
> + while (otgsc & OTGSC_BSV)
Dear Peter Chen,
> - For host, the vbus should always be on.
> - For otg, the vbus is off defaultly, the vbus needs to be
> turned on/off when usb role switches.
>
> Signed-off-by: Peter Chen
> ---
> drivers/usb/chipidea/ci.h |2 +
> drivers/usb/chipidea/ci13xxx_imx.c | 67
>
Dear Sachin Kamat,
fixing CC here
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat
> Cc: Marek Vasut
> ---
> drivers/usb/phy/phy-mxs-usb.c |2
g but patch number 6, which I've responded to
> with some questions about it.
That #6 emerged after discussion with Alan. It's unlikely on most hardware, but
there are a few pieces where that case will happen.
> thanks,
>
> greg k-h
Best regards,
Marek Vasut
--
To unsubscribe fr
re/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1924,6 +1924,11 @@ void usb_disconnect(struct usb_device **pdev)
>*/
> device_del(&udev->dev);
>
> + if (udev->parent && !udev->parent->parent) {
> + struct usb_hcd *hcd = bus_to_hcd(udev->bus);
&
uldn't that go before device_del() ?
>
> Any difference?
I was worried some corruption of other members in udev structure might happen,
but I'm not so sure anymore after taking deer look.
> Thanks
> Richard
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
as a GPIO ? ie. you should have such an
entry in the DTS pinmux setup -- MX23_PAD_SSP1_DETECT__GPIO_2_1 .
If it is, then it'd probably mean that the pin state is leaking into the USB
core even if it's muxed as GPIO, in which case this would be a silicon problem.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, April 13, 2015 at 07:59:29 AM, har...@ccbib.org wrote:
> On Mon, 13 Apr 2015 01:18:07 +0200, Marek Vasut wrote:
> > On Sunday, April 12, 2015 at 12:06:10 PM, Stefan Wahren wrote:
> >> Hi,
> >>
> >> toggling the green LED (GPIO 65) on Olinuxino Max
well with an ubuntu PC (make sure your codec works well).
ci_hdrc.0 request length too big for isochronous
Doesn't this just mean it cannot transfer such a long buffer via ISO pipe ?
I guess the UAC should send smaller buffers to work with the CI HDRC?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
d 'disable-over-current' binding to allow of the
> option of disabling the over-current condition.
>
> Signed-off-by: Dinh Nguyen
Reviewed-by: Marek Vasut
Similar patch was in U-Boot for two years now and it does the trick indeed.
> ---
> drivers/usb/dwc2/core.h |
t wondering if anyone might have an idea on what could be causing
> this error?
Maybe some clock are not enabled ?
--
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
c.
>>
>> Once I made sure that the configuration and setup was the same on both
>> board I could see that the behaved similarly. And that is the
>> following interrupt load:
>>
>> - BT USB (FS) = ~80k interrupts / second
>> - Keyboard (FS) = ~80k interrup
On 02/19/2018 09:19 AM, Minas Harutyunyan wrote:
> On 2/17/2018 12:07 AM, Marek Vasut wrote:
>> On 02/16/2018 06:59 AM, Minas Harutyunyan wrote:
>>> On 2/15/2018 5:20 PM, Mirza Krak wrote:
>>>> On 14 February 2018 at 13:07, Minas Harutyunyan
>>>> wrot
On 02/19/2018 11:11 AM, Minas Harutyunyan wrote:
> On 2/19/2018 12:51 PM, Marek Vasut wrote:
>> On 02/19/2018 09:19 AM, Minas Harutyunyan wrote:
>>> On 2/17/2018 12:07 AM, Marek Vasut wrote:
>>>> On 02/16/2018 06:59 AM, Minas Harutyunyan wrote:
>>>&g
erbose lsusb on connected to dwc2 device
See attached
> and driver debug log.
What exactly do you mean by this one ?
--
Best regards,
Marek Vasut
Bus 001 Device 003: ID 0781:5581 SanDisk Corp. Ultra
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB
On 03/06/2018 09:09 AM, Minas Harutyunyan wrote:
Hi,
On 3/6/2018 10:45 AM, Minas Harutyunyan wrote:
Hi,
On 3/5/2018 11:14 PM, Marek Vasut wrote:
On 02/20/2018 06:51 AM, Minas Harutyunyan wrote:
[...]
Is there a way to reduce that or is that the absolute minimum in HS mode?
We already
Linux USB
VID database, but that was acquired by Microsemi.
Signed-off-by: Marek Vasut
Cc: stable
Cc: usb
Cc: Johan Hovold
---
V2: - Move the ID in ftdi_sio_ids.h to keep it sorted by VIDs
- Use the JTAG quirk to avoid binding channel 0, this is needed by
the Libero software, otherwise
On 02/13/2017 10:29 AM, Johan Hovold wrote:
> [+CC: linux-usb]
>
> Always make sure to CC linux-usb for USB patches.
>
> On Fri, Feb 10, 2017 at 05:16:12PM +0100, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT4232 pr
Linux USB
VID database, but that was acquired by Microsemi.
Signed-off-by: Marek Vasut
Cc: stable
Cc: usb
Cc: Johan Hovold
---
V2: - Move the ID in ftdi_sio_ids.h to keep it sorted by VIDs
- Use the JTAG quirk to avoid binding channel 0, this is needed by
the Libero software, otherwise
On 04/18/2017 11:56 AM, Johan Hovold wrote:
> On Mon, Apr 17, 2017 at 01:56:54PM +0200, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT4232 provides four UARTs, but only two are used. The UART 0
>> is used by the FlashPro5
On 04/19/2017 10:00 AM, Johan Hovold wrote:
> On Tue, Apr 18, 2017 at 08:07:56PM +0200, Marek Vasut wrote:
>> This development kit has an FT4232 on it with a custom USB VID/PID.
>> The FT4232 provides four UARTs, but only two are used. The UART 0
>> is used by the FlashPro5
considered a MDIO
broadcast address by them. We want to obtain their real MDIO address
instead.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
---
drivers/net/usb/smsc95xx.c | 42 +-
1 file changed, 41 insertions(+), 1 deletion
manner and any duplex information.
This patch adds a quirk for such a setup. The PHY is detected by its
PHY ID register values and if present, link detection is not performed
and duplex is always forced to full.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
On 9/11/18 12:12 PM, Marek Vasut wrote:
> The SMSC95xx chip can use either the internal PHY or an external one.
> Currently, the driver hard-codes support for the internal PHY only.
>
> This patch reads out the HW_CFG register to determine whether external
> PHY is attached or not.
I_PHYSID2);
>>> + /* Check for valid response from the PHY */
>>> + if (id1 > 0 && id2 > 0 && id1 != 0x7fff && id2 != 0x)
>>> + return phyad;
>>> + }
>
> This would be so much easier if the driver used the core mdio/phy
> code. Just set mdio->phy_mask to ~BIT(0) and then use
> phy_find_first().
That's in the pipeline, along with PM cleanups, but low prio.
> Anyway, net is closed at the moment, so please repost in three weeks
> time.
OK
--
Best regards,
Marek Vasut
On 12/23/18 11:56 AM, Andrew Lunn wrote:
> On Sun, Dec 23, 2018 at 11:43:05AM +0100, Marek Vasut wrote:
>> On 12/23/18 11:23 AM, Andrew Lunn wrote:
>>>>> +static int smsc95xx_phy_address(struct usbnet *dev)
>>>>> +{
>>>>> + u32 read_buf;
ch checks whether the
usbdev->suspend_count is zero or not.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Nisar Sayed
Cc: Woojung Huh
Cc: Andrew Lunn
Cc: Florian Fainelli
Cc: linux-usb@vger.kernel.org
To: net...@vger.kernel.org
---
drivers/net/usb/sms
1 - 100 of 124 matches
Mail list logo
