Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader initialization

2016-05-04 Thread Krzysztof Kozlowski
On 05/03/2016 08:00 PM, Rob Herring wrote: > On Mon, May 02, 2016 at 11:55:01AM +0100, Mark Brown wrote: >> On Mon, May 02, 2016 at 11:49:12AM +0200, Krzysztof Kozlowski wrote: >> >>> This VDD regulator supply actually is not a usb3503 USB HUB regulator >>>

[RFC v2 05/13] power: pwrseq: Remove mmc prefix from mmc_pwrseq

2016-05-05 Thread Krzysztof Kozlowski
The "mmc" prefix is no longer needed after moving the pwrseq core code from mmc/ to power/. Signed-off-by: Krzysztof Kozlowski --- drivers/power/pwrseq/pwrseq.c| 18 +- drivers/power/pwrseq/pwrseq_emmc.c | 8 drivers/power/pwrseq/pwrseq_sim

[RFC v2 11/13] usb: port: Parse pwrseq phandle from Device Tree

2016-05-05 Thread Krzysztof Kozlowski
Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq device. The pwrseq device will be used by USB hub to cycle the power before activating ports. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.h | 3 +++ drivers/usb/core/port.c | 15 +++ 2 files

[RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-05-05 Thread Krzysztof Kozlowski
IT WORKS, which is nice. :) Best regards, Krzysztof Krzysztof Kozlowski (13): usb: misc: usb3503: Clean up on driver unbind power/mmc: Move pwrseq drivers to power/pwrseq MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq power: pwrseq: Enable COMPILE_TEST for drivers power: pw

[RFC v2 12/13] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3

2016-05-05 Thread Krzysztof Kozlowski
Switch the control of buck8 to GPIO mode. It is faster than I2C/register mode and it is the easiest way to disable it (regulator state is a logical OR state of GPIO and register value). Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 1 + 1 file changed, 1

[RFC v2 04/13] power: pwrseq: Enable COMPILE_TEST for drivers

2016-05-05 Thread Krzysztof Kozlowski
Allow build testing for power sequence drivers. Signed-off-by: Krzysztof Kozlowski --- drivers/power/pwrseq/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/pwrseq/Kconfig b/drivers/power/pwrseq/Kconfig index b5d2d6c65f28..4731ba01a958 100644 --- a

[RFC v2 10/13] usb: hub: Power sequence the ports on activation

2016-05-05 Thread Krzysztof Kozlowski
The autodetection of attached USB device might not work on certain boards where the power is delivered externally. These devices also might require a hard reset. Use pwrseq for that in USB hub. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.c | 11 +++ 1 file changed, 11

[RFC v2 13/13] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3

2016-05-05 Thread Krzysztof Kozlowski
t before configuring. Reset by GPIO (called RESET_N pin) and by RESET field in STCD register in usb3503 HUB are not sufficient. Instead full reset has to be done by disabling and enabling regulator. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +- arch/arm

[RFC v2 08/13] usb: hub: Handle deferred probe

2016-05-05 Thread Krzysztof Kozlowski
Add support for deferred probing to the usb hub. Currently EPROBE_DEFER does not exist in usb hub path but future patches will add it on the port level. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[RFC v2 06/13] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix

2016-05-05 Thread Krzysztof Kozlowski
ot; prefix and use the pointer to struct pwrseq as argument. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/core/core.c | 6 +++--- drivers/power/pwrseq/pwrseq.c| 24 +--- drivers/power/pwrseq/pwrseq_emmc.c | 4 ++-- drivers/power/pwrseq/pwrseq_sim

[RFC v2 09/13] power: pwrseq: Add support for USB hubs with external power

2016-05-05 Thread Krzysztof Kozlowski
Some USB devices on embedded boards have external power supply which has to be reset in certain conditions. Add pwrseq interface for this. Signed-off-by: Krzysztof Kozlowski --- drivers/power/pwrseq/pwrseq.c | 44 +++ include/linux/pwrseq.h| 8

[RFC v2 07/13] power: pwrseq: simple: Add support for toggling regulator

2016-05-05 Thread Krzysztof Kozlowski
Some devices need real hard-reset by cutting the power. During power sequence turn off and on the regulator, if it is provided. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/mmc/mmc-pwrseq-simple.txt | 2 + drivers/power/pwrseq/pwrseq_simple.c | 50

[RFC v2 01/13] usb: misc: usb3503: Clean up on driver unbind

2016-05-05 Thread Krzysztof Kozlowski
The driver should clean up after itself by unpreparing the clock when it is unbound. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/misc/usb3503.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index

[RFC v2 02/13] power/mmc: Move pwrseq drivers to power/pwrseq

2016-05-05 Thread Krzysztof Kozlowski
are prefixed with "mmc_pwrseq". However the MMC-specific pwrseq functions has to be now exported and everything is hidden not by CONFIG_OF but by new CONFIG_POWER_SEQ option. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/Kconfig| 2 -- driver

[RFC v2 03/13] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq

2016-05-05 Thread Krzysztof Kozlowski
Before moving pwrseq drivers from drivers/mmc/core/ to drivers/power/, they were maintained by Ulf Hansson. Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b016f447c6c9..2c501b795d18 100644 --- a

Re: [RFC v2 10/13] usb: hub: Power sequence the ports on activation

2016-05-05 Thread Krzysztof Kozlowski
On Thu, May 05, 2016 at 10:09:47AM -0400, Alan Stern wrote: > On Thu, 5 May 2016, Krzysztof Kozlowski wrote: > > > The autodetection of attached USB device might not work on certain > > boards where the power is delivered externally. These devices also might > > require

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-05-05 Thread Krzysztof Kozlowski
On 05/06/2016 12:42 AM, Rob Herring wrote: > On Thu, May 05, 2016 at 02:34:13PM +0200, Krzysztof Kozlowski wrote: >> Hi, >> >> This is a different, second try to fix usb3503+lan on Odroid U3 board >> if it was initialized by bootloader (e.g. for TFTP boot). &

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-05-05 Thread Krzysztof Kozlowski
On 05/06/2016 07:44 AM, Peter Chen wrote: > On Thu, May 05, 2016 at 05:42:40PM -0500, Rob Herring wrote: >> On Thu, May 05, 2016 at 02:34:13PM +0200, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> This is a different, second try to fix usb3503+lan on Odroid U

Re: [RFC v2 01/13] usb: misc: usb3503: Clean up on driver unbind

2016-05-05 Thread Krzysztof Kozlowski
On 05/05/2016 08:32 PM, Javier Martinez Canillas wrote: > Hello Krzysztof > > Patch looks good to me, I just have a trivial comment below. > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> The driver should clean up after itself by unpreparing the clock

Re: [RFC v2 02/13] power/mmc: Move pwrseq drivers to power/pwrseq

2016-05-05 Thread Krzysztof Kozlowski
On 05/05/2016 08:44 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> The MMC power sequence drivers are useful also outside of MMC world: for >> USB devices needed a hard-reset before probing. Before extending a

Re: [RFC v2 05/13] power: pwrseq: Remove mmc prefix from mmc_pwrseq

2016-05-05 Thread Krzysztof Kozlowski
On 05/05/2016 09:09 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> The "mmc" prefix is no longer needed after moving the pwrseq core code >> from mmc/ to power/. >> >> Signed-off

Re: [RFC v2 07/13] power: pwrseq: simple: Add support for toggling regulator

2016-05-05 Thread Krzysztof Kozlowski
On 05/05/2016 09:31 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> Some devices need real hard-reset by cutting the power. During power >> sequence turn off and on the regulator, if it is provided. >>

Re: [RFC v2 09/13] power: pwrseq: Add support for USB hubs with external power

2016-05-05 Thread Krzysztof Kozlowski
On 05/05/2016 09:52 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> Some USB devices on embedded boards have external power supply which has >> to be reset in certain conditions. Add pwrseq interface for this

Re: [RFC v2 11/13] usb: port: Parse pwrseq phandle from Device Tree

2016-05-05 Thread Krzysztof Kozlowski
On 05/05/2016 10:10 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq >> device. The pwrseq device will be used by USB hub to cycle the power

Re: [RFC v2 13/13] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3

2016-05-05 Thread Krzysztof Kozlowski
On 05/05/2016 10:16 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> On Odroid U3 (Exynos4412-based) board if USB was initialized by >> bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb35

Re: [PATCH] dwc3-exynos: Fix deferred probing storm.

2016-05-25 Thread Krzysztof Kozlowski
submitting or applying) add following tags: Fixes: d720f057fda4 ("usb: dwc3: exynos: add nop transceiver support") Cc: This will help downstream (like Debian) using stable kernels. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > --- > drivers/usb/dwc3/dwc3-exynos.c |

Re: [PATCH] dwc3-exynos: Fix deferred probing storm.

2016-05-27 Thread Krzysztof Kozlowski
On 05/27/2016 01:46 PM, Steinar H. Gunderson wrote: > On Fri, May 27, 2016 at 03:23:35PM +0530, Vivek Gautam wrote: >> I don't have any concerns with the patch apart from the ones >> Krzysztof has already pointed out. >> LGTM. > > Should I repost the patch, or will people just make these commit me

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-05-31 Thread Krzysztof Kozlowski
e in dts. >> 2. USB creates the similar driver under drivers/usb for its own use. >> >> Which one do you prefer, thanks. >> > > Hi Krzysztof Kozlowski, > > I think option 1 may be better according to Rob and Ulf's comment. Hi, I like the option #1 as w

[PATCH v2 1/2] usb: misc: usb3503: Set platform data

2016-06-01 Thread Krzysztof Kozlowski
Driver supports two paths of device instantiation: as platform and i2c device. In the platform path it lacks of storing the driver specific structure as drvdata. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch. --- drivers/usb/misc/usb3503.c | 1 + 1 file changed, 1

[PATCH v2 2/2] usb: misc: usb3503: Clean up on driver unbind

2016-06-01 Thread Krzysztof Kozlowski
The driver should clean up after itself by unpreparing the clock when it is unbound. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- Changes since v1: 1. Add Javier's tag. 2. Follow Javier's suggestion - the 'hub' cannot be null now. --- driv

[PATCH v3 09/12] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree

2016-06-01 Thread Krzysztof Kozlowski
Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq device. The pwrseq device will be used by USB hub to cycle the power before activating ports. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.h | 3 +++ drivers/usb/core/port.c | 15 +++ 2 files

[PATCH v3 05/12] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix

2016-06-01 Thread Krzysztof Kozlowski
ot; prefix and use the pointer to struct pwrseq as argument. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/mmc/core/core.c | 6 +++--- drivers/power/pwrseq/pwrseq.c| 24 +--- drivers/power/pwrseq/pwrseq_emm

[PATCH v3 08/12] usb: hub: Handle deferred probe

2016-06-01 Thread Krzysztof Kozlowski
Add support for deferred probing to the usb hub. Currently EPROBE_DEFER does not exist in usb hub path but future patches will add it on the port level. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/usb/core/hub.c | 6 -- 1 file changed, 4 insertions

[PATCH v3 07/12] power: pwrseq: Add support for USB hubs with external power

2016-06-01 Thread Krzysztof Kozlowski
Some USB devices on embedded boards have external power supply which has to be reset in certain conditions. Add pwrseq interface for this. Signed-off-by: Krzysztof Kozlowski --- drivers/power/pwrseq/pwrseq.c | 47 ++- include/linux/pwrseq.h| 11

[PATCH v3 11/12] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3

2016-06-01 Thread Krzysztof Kozlowski
Switch the control of buck8 to GPIO mode. It is faster than I2C/register mode and it is the easiest way to disable it (regulator state is a logical OR state of GPIO and register value). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos4412

[PATCH v3 12/12] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3

2016-06-01 Thread Krzysztof Kozlowski
t before configuring. Reset by GPIO (called RESET_N pin) and by RESET field in STCD register in usb3503 HUB are not sufficient. Instead full reset has to be done by disabling and enabling regulator. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 4 1 file c

[PATCH v3 01/12] power/mmc: Move pwrseq drivers to power/pwrseq

2016-06-01 Thread Krzysztof Kozlowski
are prefixed with "mmc_pwrseq". However the MMC-specific pwrseq functions has to be now exported and everything is hidden not by CONFIG_OF but by new CONFIG_POWER_SEQ option. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- .../pwrseq/pwrse

[PATCH v3 10/12] EXAMPLE CODE: usb: hub: Power sequence the ports on activation

2016-06-01 Thread Krzysztof Kozlowski
The autodetection of attached USB device might not work on certain boards where the power is delivered externally. These devices also might require a hard reset. Use pwrseq for that in USB hub. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.c | 10 ++ 1 file changed, 10

[PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-01 Thread Krzysztof Kozlowski
aining the property and parse the node's properties like reset-gpios, ext-supply etc. Signed-off-by: Krzysztof Kozlowski --- .../bindings/power/pwrseq/pwrseq-simple.txt| 29 +++- drivers/power/pwrseq/pwrseq_simple.c | 85 +- 2 files changed, 107 i

[PATCH v3 04/12] power: pwrseq: Remove mmc prefix from mmc_pwrseq

2016-06-01 Thread Krzysztof Kozlowski
The "mmc" prefix is no longer needed after moving the pwrseq core code from mmc/ to power/. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/power/pwrseq/pwrseq.c| 18 +- drivers/power/pwrseq/pwrseq_emmc.c | 8 ---

[PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting)

2016-06-01 Thread Krzysztof Kozlowski
This is very similar to the MMC pwrseq behavior so the idea is to: 1. Move MMC pwrseq drivers to generic place, 2. Extend the pwrseq-simple with regulator toggling, 3. Add support to USB hub and port core for pwrseq, 4. Toggle the regulator when needed. Best regards, Krzysztof Krzysztof Kozlo

[PATCH v3 03/12] power: pwrseq: Enable COMPILE_TEST for drivers

2016-06-01 Thread Krzysztof Kozlowski
Allow build testing for power sequence drivers. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/power/pwrseq/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/pwrseq/Kconfig b/drivers/power/pwrseq/Kconfig index

[PATCH v3 02/12] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq

2016-06-01 Thread Krzysztof Kozlowski
Before moving pwrseq drivers from drivers/mmc/core/ to drivers/power/, they were maintained by Ulf Hansson. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH v3 09/12] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree

2016-06-01 Thread Krzysztof Kozlowski
On 06/01/2016 10:57 AM, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2016-06-01 01:02:18) >> Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq >> device. The pwrseq device will be used by USB hub to cycle the power >> before activating ports

Re: [PATCH v3 12/12] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3

2016-06-02 Thread Krzysztof Kozlowski
On 06/01/2016 01:59 PM, Peter Chen wrote: > On Wed, Jun 01, 2016 at 10:02:21AM +0200, Krzysztof Kozlowski wrote: >> On Odroid U3 (Exynos4412-based) board if USB was initialized by >> bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) >> and LAN (s

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-03 Thread Krzysztof Kozlowski
On 06/03/2016 04:02 AM, Rob Herring wrote: > On Wed, Jun 01, 2016 at 10:02:15AM +0200, Krzysztof Kozlowski wrote: >> Some devices need real hard-reset by cutting the power. During power >> sequence turn off and on the regulator, if it is provided. >> >> Additionally ad

Re: [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting)

2016-06-06 Thread Krzysztof Kozlowski
On 06/06/2016 10:43 PM, Heiko Stübner wrote: > Hi, > > Am Mittwoch, 1. Juni 2016, 10:02:09 schrieb Krzysztof Kozlowski: >> My third approach for a USB power sequence which fixes usb3503+lan >> on Odroid U3 board if it was initialized by bootloader >> (e.g. for TFTP boot

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-07 Thread Krzysztof Kozlowski
On 06/03/2016 04:02 AM, Rob Herring wrote: >> Optional properties: >> - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are >> asserted >> @@ -16,6 +22,7 @@ Optional properties: >>See ../clocks/clock-bindings.txt for details. >> - clock-names : Must include the following e

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-08 Thread Krzysztof Kozlowski
On 06/09/2016 04:34 AM, Chen-Yu Tsai wrote: > Hi > > On Thu, Jun 9, 2016 at 3:03 AM, Rob Herring wrote: >> On Tue, Jun 07, 2016 at 11:29:02AM +0200, Krzysztof Kozlowski wrote: >>> On 06/03/2016 04:02 AM, Rob Herring wrote: >>>>> Optional properties: &g

[RFC v4 02/14] simplefb: Use new devm_of_regulator_all_get helper and bulk API

2016-06-09 Thread Krzysztof Kozlowski
bulk API does everything atomically. Signed-off-by: Krzysztof Kozlowski --- Not tested. --- drivers/video/fbdev/simplefb.c | 71 +- 1 file changed, 14 insertions(+), 57 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev

[RFC v4 11/14] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree

2016-06-09 Thread Krzysztof Kozlowski
Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq device. The pwrseq device will be used by USB hub to cycle the power before activating ports. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.h | 3 +++ drivers/usb/core/port.c | 16 2 files

[RFC v4 14/14] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3

2016-06-09 Thread Krzysztof Kozlowski
t before configuring. Reset by GPIO (called RESET_N pin) and by RESET field in STCD register in usb3503 HUB are not sufficient. Instead full reset has to be done by disabling and enabling regulator. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 4 1 file c

[RFC v4 10/14] usb: hub: Handle deferred probe

2016-06-09 Thread Krzysztof Kozlowski
Add support for deferred probing to the usb hub. Currently EPROBE_DEFER does not exist in usb hub path but future patches will add it on the port level. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/usb/core/hub.c | 6 -- 1 file changed, 4 insertions

[RFC v4 06/14] power: pwrseq: Remove mmc prefix from mmc_pwrseq

2016-06-09 Thread Krzysztof Kozlowski
The "mmc" prefix is no longer needed after moving the pwrseq core code from mmc/ to power/. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/power/pwrseq/pwrseq.c| 18 +- drivers/power/pwrseq/pwrseq_emmc.c | 8 ---

[RFC v4 13/14] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3

2016-06-09 Thread Krzysztof Kozlowski
Switch the control of buck8 to GPIO mode. It is faster than I2C/register mode and it is the easiest way to disable it (regulator state is a logical OR state of GPIO and register value). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos4412

[RFC v4 00/14] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting)

2016-06-09 Thread Krzysztof Kozlowski
milar to the MMC pwrseq behavior so the idea is to: 1. Move MMC pwrseq drivers to generic place, 2. Extend the pwrseq-simple with regulator toggling, 3. Add support to USB hub and port core for pwrseq, 4. Toggle the regulator when needed. Best regards, Krzysztof Krzysztof Kozlowski

[RFC v4 05/14] power: pwrseq: Enable COMPILE_TEST for drivers

2016-06-09 Thread Krzysztof Kozlowski
Allow build testing for power sequence drivers. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/power/pwrseq/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/pwrseq/Kconfig b/drivers/power/pwrseq/Kconfig index

[RFC v4 12/14] EXAMPLE CODE: usb: hub: Power sequence the ports on activation

2016-06-09 Thread Krzysztof Kozlowski
The autodetection of attached USB device might not work on certain boards where the power is delivered externally. These devices also might require a hard reset. Use pwrseq for that in USB hub. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.c | 10 ++ 1 file changed, 10

[RFC v4 08/14] power: pwrseq: simple: Add support for regulators and generic property

2016-06-09 Thread Krzysztof Kozlowski
e property and parse the node's properties like reset-gpios, supplies etc. Signed-off-by: Krzysztof Kozlowski --- .../bindings/power/pwrseq/pwrseq-simple.txt| 30 +- drivers/power/pwrseq/pwrseq_simple.c | 113 - 2 files changed, 136 insertions(

[RFC v4 09/14] power: pwrseq: Add support for USB hubs with external power

2016-06-09 Thread Krzysztof Kozlowski
Some USB devices on embedded boards have external power supply which has to be reset in certain conditions. Add pwrseq interface for this. Signed-off-by: Krzysztof Kozlowski --- drivers/power/pwrseq/pwrseq.c | 47 ++- include/linux/pwrseq.h| 11

[RFC v4 04/14] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq

2016-06-09 Thread Krzysztof Kozlowski
Before moving pwrseq drivers from drivers/mmc/core/ to drivers/power/, they were maintained by Ulf Hansson. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[RFC v4 03/14] power/mmc: Move pwrseq drivers to power/pwrseq

2016-06-09 Thread Krzysztof Kozlowski
are prefixed with "mmc_pwrseq". However the MMC-specific pwrseq functions has to be now exported and everything is hidden not by CONFIG_OF but by new CONFIG_POWER_SEQ option. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- .../pwrseq/pwrse

[RFC v4 07/14] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix

2016-06-09 Thread Krzysztof Kozlowski
ot; prefix and use the pointer to struct pwrseq as argument. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/mmc/core/core.c | 6 +++--- drivers/power/pwrseq/pwrseq.c| 24 +--- drivers/power/pwrseq/pwrseq_emm

[RFC v4 01/14] regulator: of: Add helper for getting all supplies

2016-06-09 Thread Krzysztof Kozlowski
"-supply" properties and returning allocated bulk regulator consumers. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/of_regulator.c | 86 ++ include/linux/regulator/of_regulator.h | 13 + 2 files changed, 99 insertions(+) diff --git

Re: [RFC v4 01/14] regulator: of: Add helper for getting all supplies

2016-06-09 Thread Krzysztof Kozlowski
On 06/09/2016 12:29 PM, Mark Brown wrote: > On Thu, Jun 09, 2016 at 11:44:18AM +0200, Krzysztof Kozlowski wrote: >> Few drivers have a need of getting regulator supplies without knowing >> their names: >> 1. The Simple Framebuffer driver works on setup provided by bootloa

Re: [PATCH 07/12] power: pwrseq: rename file name for generic driver

2016-06-20 Thread Krzysztof Kozlowski
On 06/17/2016 12:09 PM, Peter Chen wrote: > The individual driver file name is better to contain module name. > > Signed-off-by: Peter Chen > --- > .../power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} | 0 > drivers/power/pwrseq/Makefile |

[BUG] Regression, usb-dwc3 not working, Odroid XU3, usb 3.0

2016-07-04 Thread Krzysztof Kozlowski
Hi, Since three recent next releases (first on 20160630), on Odroid XU3 board the USB 3.0 host port (the only one) stopped working. This is a "samsung,exynos5250-dwusb3" (drivers/usb/dwc3/dwc3-exynos.c). Two issues here: 1. The port does not show up as USB 3.0 device. This one device is missing

Re: [PATCH 1/2] dt-bindings: usb: add DT binding for s3c2410 USB OHCI controller

2016-11-27 Thread Krzysztof Kozlowski
s3c2410-ohci" for USB host controller > + - reg: address and lenght of the controller memory mapped region s/lenght/length/ Acked-by: Krzysztof Kozlowski Best regards, Krzysztof > + - interrupts: interrupt number for the USB OHCI controller > + - clocks: Should reference the bus and host

Re: [PATCH 2/2] usb: ohci: s3c2410: allow probing from device tree

2016-11-27 Thread Krzysztof Kozlowski
esume(struct device > *dev) > .resume = ohci_hcd_s3c2410_drv_resume, > }; > > +static const struct of_device_id ohci_hcd_s3c2410_dt_ids[] = { > + { .compatible = "samsung,s3c2410-ohci" }, > + { /* sentinel */ } > +}; > + A nit, usually MODULE_DEVICE_TABLE com

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-12-13 Thread Krzysztof Kozlowski
On Tue, Dec 13, 2016 at 2:34 PM, Hans Verkuil wrote: > Try again, this time with Krzysztof's new email address... > > > On 13/12/16 13:20, Hans Verkuil wrote: >> >> Hi Krzysztof, >> >> This still seems to be broken with the latest 4.9 kernel, right? >> >> Has there been any progress on this? Do yo

Re: [PATCH v10 0/8] power: add power sequence library

2016-12-19 Thread Krzysztof Kozlowski
On Mon, Nov 14, 2016 at 09:35:51AM +0800, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_initcall, the match > criter

Re: [PATCH v11 0/8] power: add power sequence library

2017-01-06 Thread Krzysztof Kozlowski
On Thu, Jan 05, 2017 at 02:01:51PM +0800, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_initcall, the match > criter

Re: [PATCH v11 0/8] power: add power sequence library

2017-01-06 Thread Krzysztof Kozlowski
On Fri, Jan 06, 2017 at 05:18:41PM +0200, Krzysztof Kozlowski wrote: > On Thu, Jan 05, 2017 at 02:01:51PM +0800, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hansson&

[PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-07 Thread Krzysztof Kozlowski
PHYs") Signed-off-by: Krzysztof Kozlowski --- drivers/usb/host/ehci-exynos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 42e5b66353ef..7a603f66a9bc 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb

[PATCH 2/2] usb: host: ohci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-07 Thread Krzysztof Kozlowski
PHYs") Signed-off-by: Krzysztof Kozlowski --- drivers/usb/host/ohci-exynos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 2cd105be7319..6865b919403f 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb

[PATCH 4/4] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-07 Thread Krzysztof Kozlowski
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index

[PATCH 1/4] ARM: dts: exynos: Fix indentation of EHCI and OHCI ports

2017-01-07 Thread Krzysztof Kozlowski
Replace spaces with tabs in EHCI and OHCI ports indentation. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4.dtsi | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index

[PATCH 2/4] ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot

2017-01-07 Thread Krzysztof Kozlowski
e the generic power sequence driver and toggle the ENB8 (buck8) pin. Reset duration of 500 us was chosen by experiments (shortest working time was 400 us). This is an easiest way to fix the long standing LAN9730 reset issue. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odr

[PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-07 Thread Krzysztof Kozlowski
https://lwn.net/Articles/710736/ [2] https://github.com/krzk/linux/commits/for-next/odroid-u3-usb3503-pwrseq Krzysztof Kozlowski (4): ARM: dts: exynos: Fix indentation of EHCI and OHCI ports ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot ARM: exynos_defconfig: Enable power sequenc

Re: [PATCH v11 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2017-01-07 Thread Krzysztof Kozlowski
++ > 1 file changed, 48 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-u

[PATCH 3/4] ARM: exynos_defconfig: Enable power sequence for Odroid U3

2017-01-07 Thread Krzysztof Kozlowski
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Enable also GPIO_SYSFS which is useful for playing with GPIO during debug process. Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch

Re: [PATCH v11 2/8] power: add power sequence library

2017-01-07 Thread Krzysztof Kozlowski
create mode 100644 drivers/power/pwrseq/core.c > create mode 100644 drivers/power/pwrseq/pwrseq_generic.c > create mode 100644 include/linux/power/pwrseq.h > Acked-by: Krzysztof Kozlowski Tested on Odroid U3 (reset sequence for LAN9730): Tested-by: Krzysztof Kozlowski Best regards,

Re: [PATCH v11 3/8] binding-doc: usb: usb-device: add optional properties for power sequence

2017-01-07 Thread Krzysztof Kozlowski
rtions(+), 1 deletion(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 4/8] usb: core: add power sequence handling for USB devices

2017-01-07 Thread Krzysztof Kozlowski
t; drivers/usb/Kconfig| 1 + > drivers/usb/core/hub.c | 48 > drivers/usb/core/hub.h | 1 + > 3 files changed, 46 insertions(+), 4 deletions(-) > Acked-by: Krzysztof Kozlowski Tested on Odroid U3 (reset sequence for LAN9730): Tested-by: Krzysztof Kozlows

[PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-07 Thread Krzysztof Kozlowski
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device is present on Odroid U3). Signed-off-by: Krzysztof Kozlowski --- Changes since v1 (v1 -> v1.1): 1. Enable also usb3503 driver. --- arch/arm/conf

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 9, 2017 at 6:24 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > I think it would had been clearer if the subject prefix was "[PATCH v1.1 > 4/4]" :) Ah, yes. > > On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: >> Odroid U3 needs a pow

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 09, 2017 at 11:34:48PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 7 January 2017 at 14:21, Krzysztof Kozlowski wrote: > > Hi, > > > > Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter > > Chen, we got a power sequence gen

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 09, 2017 at 11:56:41PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 9 January 2017 at 23:47, Krzysztof Kozlowski wrote: > > On Mon, Jan 09, 2017 at 11:34:48PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 7 January 2017 at 14

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

2017-01-10 Thread Krzysztof Kozlowski
On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: > BTW What is interesting is that the Exynos7 dts patch [2] has never > made it into upstream for some reason. In the meantime however > Exynos5433 (similar to Exynos7 to some degree) became the user of > susp_clk. > > [1]

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

2017-01-10 Thread Krzysztof Kozlowski
On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: > On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > > I also think that regardless of what is decided on making susp_clk > > non-optional for some Exynos SoCs we should probably remove the debug > > message as it doesn't bring use

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-24 Thread Krzysztof Kozlowski
On Tue, Jan 24, 2017 at 02:48:09PM +0100, Richard Genoud wrote: > Since commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), > the USB ports on odroid-XU4 don't work anymore. Hi, Thanks for the patch. Please: 1. Use recent kernel to test it, which could be one of: mainline (Linus

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-24 Thread Krzysztof Kozlowski
On Wed, Jan 25, 2017 at 7:51 AM, Anand Moon wrote: > Hi Richard, > > On 24 January 2017 at 19:18, Richard Genoud wrote: >> Since commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), >> the USB ports on odroid-XU4 don't work anymore. >> >> Inserting an usb key (USB2.0) on the USB3.0

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-25 Thread Krzysztof Kozlowski
On Wed, Jan 25, 2017 at 3:48 PM, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-01-25 08:55, Krzysztof Kozlowski wrote: >> >> On Wed, Jan 25, 2017 at 7:51 AM, Anand Moon wrote: >>> >>> On 24 January 2017 at 19:18, Richard Genoud >>> wrote: &

Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

2016-10-09 Thread Krzysztof Kozlowski
On Sun, Oct 09, 2016 at 02:34:14PM +, Anand Moon wrote: > Move the ehci-exynos system PM callbacks within #ifdef CONFIG_PM_SLEEP > as to avoid them being build when not used. This also allows us to use the > SET_SYSTEM_SLEEP_PM_OPS macro which simplifies the code. > > Signed-off-by: Anand Moon

Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

2016-10-09 Thread Krzysztof Kozlowski
On Sun, Oct 09, 2016 at 10:45:40PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 9 October 2016 at 22:04, Krzysztof Kozlowski wrote: > > On Sun, Oct 09, 2016 at 02:34:14PM +, Anand Moon wrote: > >> Move the ehci-exynos system PM callbacks within #ifdef CONFIG_PM_SLE

Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

2016-10-09 Thread Krzysztof Kozlowski
On Sun, Oct 09, 2016 at 11:57:59PM +0530, Anand Moon wrote: > hi Krzysztof, > > On 9 October 2016 at 22:57, Krzysztof Kozlowski wrote: > > On Sun, Oct 09, 2016 at 10:45:40PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 9 October 2016 at 22

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-16 Thread Krzysztof Kozlowski
2015-12-17 3:07 GMT+09:00 Sergei Shtylyov : > Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > enable a system with an integrated USB OTG dual-role transceiver to > function as an USB OTG dual-role device. In addition to sensing/controlling > Vbus, the chip also passes t

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-17 Thread Krzysztof Kozlowski
On 17.12.2015 23:36, Sergei Shtylyov wrote: > Hello. > > On 12/17/2015 3:53 AM, Krzysztof Kozlowski wrote: > >>> Maxim Integrated MAX3355E chip integrates a charge pump and >>> comparators to >>> enable a system with an integrated USB OTG dual-role transce

Re: [BUG] Regression, usb-dwc3 not working, Odroid XU3, usb 3.0

2016-07-04 Thread Krzysztof Kozlowski
On 07/04/2016 01:33 PM, Felipe Balbi wrote: > > Hi, > > Krzysztof Kozlowski writes: > >> Hi, >> >> >> Since three recent next releases (first on 20160630), on Odroid XU3 board >> the USB 3.0 host port (the only one) stopped working. >> >>

[RFC 06/15] pinctrl: rockchip: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet direct dependencies. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index fb8200b8e8ec..dc7ab58d4d74 100644

  1   2   3   >