Re: Linux USB file storage gadget with new UDC

2012-12-14 Thread Felipe Balbi
On Fri, Dec 14, 2012 at 01:58:03PM +0800, victor wrote: > Hi, > > > > > > > > > > > # ls /dev/mmc* > > > > > /dev/mmc0 /dev/mmc2 /dev/mmcblk0p1 > > > > > /dev/mmc1 /dev/mmcblk0/dev/mmcblk0p2 > > > > > > > > > > # mount /dev/mmcblk0 /mnt > > > > > # ls /mnt/ > > > > > initramf

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 01:53:07AM -0800, Ian Coolidge wrote: > Hi, > > We're using Linux 3.3 on DM3730 with TPS6595xx PMIC for an embedded > product. > For a particular board, we have musb-hdrc (RTL 1.4) configured in peripheral > mode. > We use the Ethernet gadget configured for cdc_eem to

Re: Linux USB file storage gadget with new UDC

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 06:22:27PM +0800, victor wrote: > > > Thanks. The driver's probe() can be called. Now when insmod > > > g_file_storage.ko, it says the file-backed storage gadget failed to > > > start. I have defined the udc_start() function in usb_gadget_ops > > > structure and added t

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 02:13:07PM +0200, Grazvydas Ignotas wrote: > On Fri, Dec 14, 2012 at 11:53 AM, Ian Coolidge wrote: > > we find that with about a 2% chance, the gadget comes up in some kind of > > firmware failed state, driving VBUS. > > In this condition, we found that MUSB_DEVCTL_SE

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 03:50:57PM +0400, Sergei Shtylyov wrote: > Hello. > > On 26-11-2012 23:14, Sergei Shtylyov wrote: > > >>WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference > >>from the function dma_controller_create() to the function > >>.init.text:cppi_controll

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-17 Thread Felipe Balbi
On Fri, Dec 14, 2012 at 05:38:10PM -0800, ian coolidge wrote: > Felipe, Tony, Grazvydas, Thanks for the responses, > > On Fri, Dec 14, 2012 at 4:13 AM, Felipe Balbi wrote: > > > Hi, > > > > On Fri, Dec 14, 2012 at 02:13:07PM +0200, Grazvydas Ignotas wrote: > >

Re: Linux USB file storage gadget with new UDC

2012-12-17 Thread Felipe Balbi
On Mon, Dec 17, 2012 at 04:12:13PM +0800, victor wrote: > Hi, > > > > > > > > > > > # insmod kagen2_udc.ko > > > > > # insmod g_file_storage.ko file=/dev/mmcblk0 > > > > > gadget: controller 'kagen2_usb' not recognized > > > > > > > > this should have caught your attention!! Also, rebase to a new

Re: help with f_loopback

2012-12-18 Thread Felipe Balbi
Hi, (avoid top-posting, please) On Tue, Dec 18, 2012 at 08:43:52AM -0600, ricardo garcia wrote: > im using a self-made Windows-WinUsb application that handles the g_zero device > it sends simple raw data to it, like "hello" or "bye"nothing > fancybut I dont think > this has something to d

Re: Linux USB file storage gadget with new UDC

2012-12-18 Thread Felipe Balbi
On Tue, Dec 18, 2012 at 09:59:16PM +0800, victor yeo wrote: > Hi, > > >> > > > >> > > The udc_start() function is being called now. Before this, it was not > >> > > called because of driver->max_speed checking in udc_start(). After > >> > > udc_start(), which function is to be called when the gadg

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-18 Thread Felipe Balbi
On Tue, Dec 18, 2012 at 08:40:26PM +0530, Vivek Gautam wrote: > Adding support for USB3.0 phy for dwc3 controller on > exynos5250 SOC. > > Signed-off-by: Vivek Gautam > --- > drivers/usb/phy/samsung-usbphy.c | 339 > +- let's make the phy names standard from

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-19 Thread Felipe Balbi
Hi, On Wed, Dec 19, 2012 at 11:52:01AM +0530, Vivek Gautam wrote: > >>> @@ -736,7 +1035,41 @@ static int __devinit samsung_usbphy_probe(struct > >>> platform_device *pdev) > >>> > >>> sphy->clk = clk; > >>> > >>> - return usb_add_phy(&sphy->phy, USB_PHY_TYPE_USB2); > >>> + sphy->has

Re: help with f_loopback

2012-12-19 Thread Felipe Balbi
On Wed, Dec 19, 2012 at 09:19:53AM +0100, Sebastian Andrzej Siewior wrote: > On Tue, Dec 18, 2012 at 07:29:40PM -0600, ricardo garcia wrote: > > > > my controller its: PHY dwc_otg (Broadcom BCMxxx) > > That one is not in tree. I'm afraid you are on your own here. It might be the > fault of the UD

Re: [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95

2012-12-21 Thread Felipe Balbi
On Fri, Dec 21, 2012 at 01:59:06AM +0400, Mikhail Kshevetskiy wrote: please respin this patch with a real commit log. > Signed-off-by: Mikhail Kshevetskiy > --- > drivers/usb/musb/da8xx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/da8xx.c b/dri

Re: usb: multi phy support

2013-01-07 Thread Felipe Balbi
Hi, On Mon, Jan 07, 2013 at 12:57:15PM +0100, Mohammed, Afzal wrote: > AM335x SoC's used in boards like beagle bone has two instances of USB > modules (2.0) at the hardware level, each having a dedicated phy. > Currently in mainline, only one instance of USB is supported > (including a fix in your

[BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-10 Thread Felipe Balbi
Hi, Some recent patch has caused fsl_mxc_udc.c driver to fail compilation because it can't find anymore. I would like this to be fixed still during this -rc cycle. Thank you -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: gadget: move the global the_dev variable to their users

2013-01-10 Thread Felipe Balbi
On Thu, Nov 08, 2012 at 07:24:13PM +0100, Sebastian Andrzej Siewior wrote: > the u_ether.c file has a global variable named the_dev which keeps a > pointer to the network device after it has been created via > gether_setup_name(). It is only used internally by u_ether. This patches > moves the vari

Re: [V2 PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:00PM -0500, Chao Xie wrote: > This patches converts the driver into the new style start/stop > interface. As a result the driver no longer uses the static > global the_conroller variable. > > Signed-off-by: Chao Xie Care to refresh ? patching file drivers/usb/gadge

Re: [V2 PATCH 02/27] usb: gadget: mv_udc: use devm_xxx for probe

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:01PM -0500, Chao Xie wrote: > use devm_xxx for udc driver probe. So we do need care about > the resources release in driver remove or failure handling > in driver probe. > > Signed-off-by: Chao Xie care to refresh ? patching file drivers/usb/gadget/mv_udc_core.c Hu

Re: [V2 PATCH 08/27] usb: gadget: mv_udc: fix the value of tranceiver

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:07PM -0500, Chao Xie wrote: > usally we will use udc->tranceiver == NULL or > udc->tranceiver != NULL. > So when failed to get the udc->tranceiver by usb_get_phy(), we > directly set udc->tranceiver to be NULL. > Then the source code will not need macro IS_ERR_OR_NULL(

Re: [V2 PATCH 20/27] usb: gadget: mv_udc: add extern chip support

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:19PM -0500, Chao Xie wrote: > Because arch-mmp will make use of irq domain for irq > allocation, the irqs allocated for PMIC is dynamical. > The vbus/idpin irqs from PMIC can not be passed by platform data. > Using the extern chip APIs provides by PHY driver can solve

Re: [V2 PATCH 20/27] usb: gadget: mv_udc: add extern chip support

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:19PM -0500, Chao Xie wrote: > Because arch-mmp will make use of irq domain for irq > allocation, the irqs allocated for PMIC is dynamical. > The vbus/idpin irqs from PMIC can not be passed by platform data. > Using the extern chip APIs provides by PHY driver can solve

Re: [V2 PATCH 25/27] usb: gadget: mv_udc: add device tree support

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:24PM -0500, Chao Xie wrote: > In original driver, we have callbacks in platform data, and some > dynamically allocations variables in platform data. > Now, these blocks are removed, the device tree support is easier > now. > > Signed-off-by: Chao Xie care to refresh

Re: [V2 PATCH 00/27] mv-usb fix and enhancement patches

2013-01-10 Thread Felipe Balbi
, 2012 at 3:34 PM, Haojian Zhuang > > wrote: > >> On Fri, Nov 30, 2012 at 10:10 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >>> On Tue, Nov 27, 2012 at 10:05:59PM -0500, Chao Xie wrote: > >>>> The patches are divied into 4 parts > >

Re: [PATCH 2/8] usb/dwc3: Fix missed isoc

2013-01-10 Thread Felipe Balbi
On Thu, Jan 10, 2013 at 03:23:16PM +0530, Pratyush Anand wrote: > There are two reasons to generate missed isoc. > > 1. when the host does not poll for all the data. > 2. because of application-side delays that prevent all the data from > being transferred in programmed microframe. > > Current co

Re: [PATCH 2/8] usb/dwc3: Fix missed isoc

2013-01-10 Thread Felipe Balbi
On Thu, Jan 10, 2013 at 04:47:05PM +0530, Pratyush Anand wrote: > On 1/10/2013 4:20 PM, Felipe Balbi wrote: > >On Thu, Jan 10, 2013 at 03:23:16PM +0530, Pratyush Anand wrote: > >>There are two reasons to generate missed isoc. > >> > >>1. when the host does not p

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2013-01-10 Thread Felipe Balbi
On Mon, Nov 12, 2012 at 09:01:33PM +0300, Sergei Shtylyov wrote: > This patch fixes the following: > > WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference from > the function dma_controller_create() to the function > .init.text:cppi_controller_start() > The function __devinit

Re: [V2 PATCH 00/27] mv-usb fix and enhancement patches

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:05:59PM -0500, Chao Xie wrote: > The patches are divied into 4 parts > 1. bug fixes > usb: gadget: mv_udc: use udc_start and udc_stop functions > usb: gadget: mv_udc: use devm_xxx for probe > usb: gadget: mv_udc: fix the clk APIs > usb: otg: mv_otg: use devm_xxx f

Re: [PATCH] usb: musb: Double buffering issues in host mode TX

2013-01-10 Thread Felipe Balbi
On Fri, Jan 04, 2013 at 05:10:33PM +0530, Supriya Karanth wrote: > From: supriya karanth > > Whenever an URB is programmed for transfer, the TXFIFO > is flushed. This results in valid packets of the > previous transfer to get flushed when double buffering > is enabled (The MUSB_TXCSR_FIFONOTEMPTY

ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi Alan, with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" redefined [enabled by default] drivers/usb/host/ehci-hcd.c:1255:0: note: this is the location of the previous definition drivers/usb/host/ehci-mxc.c:28

[PATCH 2/2] usb: host: ohci-tmio: fix compile warning

2013-01-10 Thread Felipe Balbi
#x27;, but argument 4 has type 'resource_size_t' [-Wformat] seen on ARM 32-bit builds. Signed-off-by: Felipe Balbi --- drivers/usb/host/ohci-tmio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c index d370245..5e

[PATCH 1/2] usb: host: imx21: fix compile error

2013-01-10 Thread Felipe Balbi
hcd.c:1931:16: error: expected declaration specifiers or '...' before string constant drivers/usb/host/imx21-hcd.c:1932:14: error: expected declaration specifiers or '...' before string constant by including Signed-off-by: Felipe Balbi --- drivers/usb/host/imx21-hcd.c | 1

Re: [PATCH 1/2] usb: host: imx21: fix compile error

2013-01-10 Thread Felipe Balbi
On Thu, Jan 10, 2013 at 10:41:44AM -0200, Fabio Estevam wrote: > On Thu, Jan 10, 2013 at 10:32 AM, Felipe Balbi wrote: > > Fix the following compile errors: > > > > drivers/usb/host/imx21-hcd.c:1929:20: error: expected declaration > > specifiers or '...' b

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-10 Thread Felipe Balbi
Hi, On Mon, Dec 24, 2012 at 07:28:33PM +0530, Vivek Gautam wrote: > DWC3 controller curretly depends on CONFIG_USB and CONFIG_USB_GADGET. > Some hardware may like to use only host feature on dwc3. > So, removing the dependency of USB_DWC3 on USB_GADGET > and further modulating the dwc3 core to ena

Re: [balbi-usb:gadget 13/13] drivers/usb/gadget/m66592-udc.c:1756:1: warning: data definition has no type or storage class

2013-01-10 Thread Felipe Balbi
Hi, On Thu, Jan 10, 2013 at 10:10:02PM +0800, Fengguang Wu wrote: > > Hi Fabio, > > FYI, there are new compile warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget > head: df2167b3770a6ed33eb567d390b1a24a7efddcd9 > commit: df2167b3770a6ed33eb567d3

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi, On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > Hi Alan, > > > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: > > > > drivers/usb/host/ehci-hcd.c:1285:0:

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > Hi, > > > > On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > >

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
-ENOROGER :-p On Thu, Jan 10, 2013 at 08:23:56PM +0200, Felipe Balbi wrote: > Hi > > On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > Hi, > > > > > > On Thu, Jan 10, 2013 at 10:36:

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-11 Thread Felipe Balbi
On Fri, Jan 11, 2013 at 03:23:59AM +, Chen Peter-B29397 wrote: > > > > > > > > > Some recent patch has caused fsl_mxc_udc.c driver to fail compilation > > > > because it can't find anymore. > > > > > > > > I would like this to be fixed still during this -rc cycle. > > > > > > Me too, who's s

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 08:35:29AM +, Chen Peter-B29397 wrote: > > > I am working on it, but there are two versions, this one and chipidea's. > > > > > > Anyway, I will send a patch to fix this problem. > > > > if you're already using chipidea, then send me a patch removing this > > drive

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 09:24:16AM +, Li Yang-R58472 wrote: > > > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, January 11, 2013 4:41 PM > > To: Chen Peter-B29397 > > Cc: ba...@ti.com; ker...@pengutroni

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 05:56:28PM +0800, Peter Chen wrote: > It changes the driver to use platform_device_id rather than cpu_is_xxx > to determine the SoC type, and updates the platform code accordingly. > > Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable. > Tested at mx51

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 05:56:28PM +0800, Peter Chen wrote: > It changes the driver to use platform_device_id rather than cpu_is_xxx > to determine the SoC type, and updates the platform code accordingly. > > Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable. > Tested at mx51

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 06:10:48PM +0530, Vivek Gautam wrote: > Hi Doug, > > Sorry!! for the delayed response. > > > On Thu, Dec 20, 2012 at 4:31 AM, Doug Anderson wrote: > > Vivek, > > > > I don't really have a good 1 foot view about how all of the USB > > bits fit together, but a fe

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 07:13:55PM +0530, Vivek Gautam wrote: > On Thu, Jan 10, 2013 at 6:32 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Dec 24, 2012 at 07:28:33PM +0530, Vivek Gautam wrote: > >> DWC3 controller curretly depends on CONFIG_USB and CONFIG_USB_

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-13 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote: > It changes the driver to use platform_device_id rather than cpu_is_xxx > to determine the SoC type, and updates the platform code accordingly. > > Compile ok at imx_v6_v7_defconfig with CONFIG_USB_FSL_USB2 enable. > Tested at mx51

Re: [PATCH 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-13 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 09:12:43AM +0800, Shawn Guo wrote: > Balbi, > > On Fri, Jan 11, 2013 at 02:50:59PM +0200, Felipe Balbi wrote: > > As I said before, this patch is too big for -rc and is unnecessary > > considering patch I wrote above. Note that there is no problems in

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-13 Thread Felipe Balbi
On Fri, Jan 11, 2013 at 07:58:23PM +0530, Vivek Gautam wrote: > Hi, > > > On Fri, Jan 11, 2013 at 7:29 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Jan 11, 2013 at 07:13:55PM +0530, Vivek Gautam wrote: > >> On Thu, Jan 10, 2013 at 6:32 PM, Felipe Balbi

Re: [RFC PATCH 1/6] Core files for the DWC2 driver

2013-01-14 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 10:22:08PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, January 11, 2013 1:44 AM > > > > Hi, > > Hi Felipe, thanks for the review. > > > On Mon, Jan 07, 2013 at 11:51:36AM -0800, P

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote: > On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote: > > > It changes the driver to use platform_device_id r

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 05:13:44PM +0800, Peter Chen wrote: > On Mon, Jan 14, 2013 at 10:50:27AM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote: > > > On Mon, Jan 14, 2013 at 09:48:58AM +0200,

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: > @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct device *dev) > > return fsl_udc_resume(NULL); > } > - > /*- > Register entry point

Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: > As mach/hardware.h is deleted, we can't visit platform code at driver. > It has no phy driver to combine with this controller, so it has to use > ioremap to map phy address as a workaround. > > Signed-off-by: Peter Chen > --- > driver

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:16 AM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: > >> @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct devi

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 03:59:31PM +0530, Pratyush Anand wrote: > Synopsys says: > The HIRD Threshold field must be set to ‘0’ when the device core is > operating in super speed mode. > > This patch implements above statement. why move HIRD settings to another part of the code ? Patch otherw

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:24 AM, Felipe Balbi wrote: > > On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: > >> On 01/14/2013 11:16 AM, Felipe Balbi wrote: > >>> Hi, > >>> >

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:39 AM, Felipe Balbi wrote: > > On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: > >> On 01/14/2013 11:24 AM, Felipe Balbi wrote: > >>> On Mon, Jan 14, 2013 at

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 12:03:04PM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:53 AM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: > >> On 01/14/2013 11:39 AM, Felipe Balbi wrote: > >>> On M

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: > I think, Paul can comment better. What I got feedback from SNPS that > if HIRD settings are > programmed in SS mode, it might result in some weird issue. However, > our issue was resolved > with some other fix in application and

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 04:52:58PM +0530, Pratyush Anand wrote: > Hi, > > On 1/14/2013 4:42 PM, Felipe Balbi wrote: > >Hi, > > > >On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: > >>I think, Paul can comment better. What I got feedback fro

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: > > > Usually there isn't any Changelog between IP cores used in the different > > > fsl processors (at least available outside of fsl), that makes it quite > > > difficult to say if something found on one imx is really the same as

Re: close blocks, if FIFO full on gagdet serial

2013-01-14 Thread Felipe Balbi
Hi, On Sun, Jan 13, 2013 at 08:09:14PM +0100, mas...@georadis.com wrote: > Hello guys, > I've found a following problems on BeagleBoard and Kernel 3.0.8 with > gadget serial driver. > > Attached is a small program, which opens gadget serial tty at > /dev/ttyGS0. USB is NOT connected to host. Then

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 06:54:22PM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 06:40 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: > > > > > > > >>>> Usually there isn't any

[150813.679919] kworker/u:2: page allocation failure: order:4, mode:0x2000d0

2013-01-14 Thread Felipe Balbi
Hi folks, not sure if someone has seen this before but I'm running v3.8-rc2 and have just gotten a page allocation failure by connecting a usb memory stick to my PC's root hub port. [150217.845632] usb 7-3: new high-speed USB device number 10 using ehci-pci [150218.217559] usb 7-3: New USB device

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread Felipe Balbi
Hi, On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: > Hi Arnd, > > On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: > >On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: > >>Added a new driver for the usb part of control module. This has an API > >>to power on the USB2 phy

Re: When and how is the probe() function called?

2013-01-15 Thread Felipe Balbi
Hi, On Tue, Jan 15, 2013 at 04:09:42PM +0100, stl wrote: > Hello all, > I want to write a usb driver for our usb controller. > I aim to use it as "device-side" driver, so if I well understood > as a "gadget driver". > Is "gadget driver" really what I need? you need to write a "UDC driver" just li

Re: Clarifications on some usb driver terms

2013-01-15 Thread Felipe Balbi
Hi, On Tue, Jan 15, 2013 at 04:18:00PM +0100, stl wrote: > Hello all, > I need some clarifications concerning the terms used in the linux usb > documentation > for usb driver: > > Firstly, what is the difference between: > - device driver > - chipset driver > - interface driver > - gadget driver

Re: [PATCH] usb: phy: remove unused APIs from Tegra PHY.

2013-01-15 Thread Felipe Balbi
the Tegra tree. I think the next > set of patches that Venu posts should actually expose the dependencies > between his USB patches and the Tegra clock framework rework, which are > why I want to do this. that should be ok: Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 11:31:32AM +0530, kishon wrote: > Hi Ravi, > > On Tuesday 15 January 2013 09:36 PM, B, Ravi wrote: > >>Hi, > >> > >>On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: > >>>Hi Arnd, > >>> > >>>On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: > On Tuesday 15

Re: [PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:58:12PM +0530, Venu Byravarasu wrote: > As Tegra PHY driver need to access one of the Host registers, > added few APIs to ehci tegra driver. > > Signed-off-by: Venu Byravarasu Stephen is this another of those patches you're gonna take care of yourself ? > --- > d

Re: [V3 PATCH 11/25] arm: mmp2: change the defintion of usb devices

2013-01-17 Thread Felipe Balbi
On Tue, Jan 15, 2013 at 01:19:04AM -0500, Chao Xie wrote: > add the udc/otg/ehci devices for mmp2 > > Signed-off-by: Chao Xie Haojian, can I get an Acked-by for this patch or will you carry it yourself ? Likewise for all other arch/arm/* patches in this series -- balbi signature.asc Descrip

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 09:48:25AM +0800, Peter Chen wrote: > On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote: > > On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: > > > As mach/hardware.h is deleted, we need to use platform_device_id to > > > differentiate SoCs. Besides, one c

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 05:28:30PM +0800, Peter Chen wrote: > > > > From what I understand balbi's comment, he dislikes this full list of > > > > device id. Instead, he prefers to something like below. > > > > > > > > static const struct platform_device_id fsl_udc_devtype[] = { > > > >

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 11:46:30AM +0100, Linus Walleij wrote: > On Thu, Jan 10, 2013 at 2:38 PM, Fabio Baltieri > wrote: > > On Thu, Jan 10, 2013 at 12:23:32PM +0100, Linus Walleij wrote: > >> On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri > >> wrote: > >> > >> > This patch converts the module t

Re: [PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 04:14:38PM +0530, Pratyush Anand wrote: > dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by > default initialize ep->maxburst to 0 for ep0. to 0 or to 1 ? -- balbi signature.asc Description: Digital signature

Re: [PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 06:03:17PM +0800, Peter Chen wrote: > As we use platform_device_id for fsl-usb2-udc driver, it needs to > change clk connection-id, or the related devm_clk_get will be failed. > > Signed-off-by: Peter Chen do I get Acked-by for this one ? -- balbi signature.asc Descri

Re: [V3 PATCH 11/25] arm: mmp2: change the defintion of usb devices

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 05:59:20PM +0800, Haojian Zhuang wrote: > On Thu, Jan 17, 2013 at 5:12 PM, Felipe Balbi wrote: > > On Tue, Jan 15, 2013 at 01:19:04AM -0500, Chao Xie wrote: > >> add the udc/otg/ehci devices for mmp2 > >> > >> Signed-off-by: Cha

Re: [PATCH 17/30] usb/gadget: nokia: use function framework for ACM

2013-01-17 Thread Felipe Balbi
On Sun, Dec 23, 2012 at 09:10:11PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts the acm_ms gadget to make use of the function > framework to request the ACM function. > > The "old" include interface for acm is now removed since nokia was the > last user of it (for ACM). > > Signe

Re: [PATCH 18/30] usb/gadget: move the global the_dev variable to their users

2013-01-17 Thread Felipe Balbi
On Sun, Dec 23, 2012 at 09:10:12PM +0100, Sebastian Andrzej Siewior wrote: > the u_ether.c file has a global variable named the_dev which keeps a > pointer to the network device after it has been created via > gether_setup_name(). It is only used internally by u_ether. This patches > moves the vari

Re: [PATCH 24/30] usb/gadget: push tty port allocation from gadget into f_acm

2013-01-17 Thread Felipe Balbi
On Sun, Dec 23, 2012 at 09:10:18PM +0100, Sebastian Andrzej Siewior wrote: > It possible to allocate the tty port number within the "instance" > structure of the function and there is no need to expose this > information within the gadget and therefore it is removed here. > This patch converts only

Re: [PATCH 30/30] usb/gadget: the start of the configfs interface

2013-01-17 Thread Felipe Balbi
Hi, On Sun, Dec 23, 2012 at 09:10:24PM +0100, Sebastian Andrzej Siewior wrote: > |# modprobe dummy_hcd num=2 > |# modprobe libcomposite > > |# lsmod > |Module Size Used by > |libcomposite 31648 0 > |dummy_hcd 19871 0 > > |# mkdir /sys/kernel/config/usb_

Re: [PATCH v7 14/22] mfd: omap-usb-host: cleanup clock management code

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 01:30:23PM +0200, Roger Quadros wrote: > All ports have similarly named port clocks so we can > bunch them into a port data structure and use for loop > to enable/disable the clocks. > > Dynamically allocate and get clocks based on number of ports > available on the platfor

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote: > @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct platform_device *pdev) > clkname, PTR_ERR(pclk)); > else > omap->utmi_clk[i] = pclk; > + > + sn

Re: [PATCH v7 17/22] mfd: omap-usb-host: clean up omap_usbhs_init()

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:30:26PM +0200, Roger Quadros wrote: > + if (is_omap_usbhs_rev1(omap)) > + reg = omap_usbhs_rev1_hostconfig(omap, reg); > + else if (is_omap_usbhs_rev2(omap)) > + reg = omap_usbhs_rev2_hostconfig(omap, reg); Any way you could maybe: r

Re: [PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 01:30:27PM +0200, Roger Quadros wrote: > This driver does not request any gpios so don't free them. > Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd > with ehci-omap in use. > > CC: Alan Stern > > Signed-off-by: Roger Quadros should this go to stable ? -- b

Re: [PATCH v7 22/22] mdf: omap-usb-host: get rid of build warning

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 01:30:31PM +0200, Roger Quadros wrote: > Fixes the below build warning when driver is built-in. > > drivers/mfd/omap-usb-host.c:750:12: warning: > ‘usbhs_omap_remove’ defined but not used [-Wunused-function] > > Signed-off-by: Roger Quadros should this go to stable too ?

Re: [PATCH v7 00/22] OMAP USB Host cleanup

2013-01-17 Thread Felipe Balbi
> > are available in the git repository at: > g...@github.com:rogerq/linux.git linux-usbhost12-part not everybody has account on github, you need to set url to something non-authenticated and pushurl to the ssh url. anyway, after fixing a few comments on the patches below, I guess this is all ready for mailine, you can add to the entire series: Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 04:34:45PM +0530, Pratyush Anand wrote: > Hi Felip, > > On 1/17/2013 4:14 PM, Pratyush ANAND wrote: > >dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by > >default initialize ep->maxburst to 0 for ep0. > > > > Although , this patch fixes issue of

Re: [PATCH] usb: musb: Double buffering issues in host mode TX

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 12:32:12PM +0100, Supriya s KARANTH wrote: > Hi Felipe, > > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Subject: Re: [PATCH] usb: musb: Double buffering issues in host mode TX > > > From: supriya

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote: > On 01/17/2013 01:45 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote: > >> @@ -598,6 +639,24 @@ static int usbhs_omap_probe(stru

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 02:45:16PM +0200, Roger Quadros wrote: > On 01/17/2013 02:27 PM, Felipe Balbi wrote: > > On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote: > >> On 01/17/2013 01:45 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >&g

Re: [balbi-usb:gadget 4/59] drivers/usb/gadget/f_uac2.c:263:20: warning: unused variable 'agdev'

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 08:46:06PM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget > head: a95bf2624aecc790d8803995818038bb89a99e6c > commit: b642435333b23ab01d526bd854d118704434fc88 [4/59] usb: gadget: remove > unused variable in

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:57:02PM +0100, Fabio Baltieri wrote: > On Thu, Jan 17, 2013 at 12:51:04PM +0200, Felipe Balbi wrote: > > > > Thanks for the ACK. This bug was here unnoticed since 3.6 merge window, > > > > > > Then it should have Cc: sta...@kerne

[PATCH] usb: gadget: f_uac2: fix compile warning

2013-01-17 Thread Felipe Balbi
this warning was introduced by previous patches, fix it. Reported-by: Fengguang Wu Signed-off-by: Felipe Balbi --- drivers/usb/gadget/f_uac2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/f_uac2.c b/drivers/usb/gadget/f_uac2.c index 07fde05..c7468b6 100644 --- a

Re: [PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 06:07:56PM +0530, Venu Byravarasu wrote: > > > @@ -605,6 +615,53 @@ static const struct dev_pm_ops > > tegra_ehci_pm_ops = { > > > > > > #endif > > > > > > +/* Bits of PORTSC1, which will get cleared by writing 1 into them */ > > > +#define TEGRA_PORTSC_RWC_BITS (USB_P

Re: [PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 10:21:53AM -0500, Alan Stern wrote: > On Thu, 17 Jan 2013, Felipe Balbi wrote: > > > > Bits 31 & 30 from PORTSC register were allocated by our SOC designers > > > to inform the host controller about the PHY type to be used. > > > >

Re: [PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 07:00:00PM +, Paul Walmsley wrote: > Hi Roger, > > On Thu, 17 Jan 2013, Tony Lindgren wrote: > > > * Roger Quadros [130117 03:34]: > > > We don't need multiple aliases for the OMAP USB host clocks and neither > > > the dummy clocks so remove them. > > > > It's b

Re: [PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 10:29:52PM +, Paul Walmsley wrote: > On Thu, 17 Jan 2013, Felipe Balbi wrote: > > > do you mean v3.9 ? > > It sounds like the other patches need to be merged first before these > cleanups can be merged. So rather than adding a merge order dep

[PATCH] usb: dwc3: debugfs: convert our regdump to use regsets

2013-01-18 Thread Felipe Balbi
regset is a generic implementation of regdump utility through debugfs. Signed-off-by: Felipe Balbi --- Hi Greg, would you take the patch below to debugfs ? I don't think debugfs should ever change whatever's passed through struct debugfs_reg32 anyway. struct debugfs_regset32 { -

[LINKING BREAKAGE] mv_udc_core has unmet dependencies

2013-01-18 Thread Felipe Balbi
Hi Chao, You latest patches caused another breakage for x86. Please fix it asap or I will have to drop all your changes from my pull request. ERROR: "mv_usb2_unregister_notifier" [drivers/usb/gadget/mv_udc.ko] undefined! ERROR: "mv_usb2_register_notifier" [drivers/usb/gadget/mv_udc.ko] undefined!

[PATCH] usb: gadget: fix two sparse warnings

2013-01-18 Thread Felipe Balbi
drivers/usb/gadget/u_serial.c:1291:5: sparse: symbol \ 'userial_init' was not declared. Should it be static? drivers/usb/gadget/zero.c:66:25: sparse: symbol \ 'gzero_options' was not declared. Should it be static? Reported-by: Fengguang Wu Signed-

<    1   2   3   4   5   6   7   8   9   10   >