Re: [PATCH v2] usbnet: smsc95xx: dereferencing NULL pointer

2014-11-11 Thread David Miller
From: Sudip Mukherjee Date: Tue, 11 Nov 2014 14:10:47 +0530 > we were dereferencing dev to initialize pdata. but just after that we > have a BUG_ON(!dev). so we were basically dereferencing the pointer > first and then tesing it for NULL. > > Signed-off-by: Sudip Mukherjee > --- > > change in

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 01:45:08 + > David Miller [mailto:da...@davemloft.net] >> Sent: Saturday, November 08, 2014 12:35 AM > [...] >> Does this even work? >> >> If you leave a hole in the ring, the device is going to stop there >> an

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Mon, 10 Nov 2014 03:29:27 + > The behavior is different for PCI(e) and USB ethernet device. > The PCI nic could know the ring buffer by certain way, so > the device could fill the data into the buffer one by one > automatically. However, for usb nic, the driver has to >

Re: [net-next PATCH v3 0/5] Replace __skb_alloc_pages with simpler function

2014-11-11 Thread David Miller
From: Alexander Duyck Date: Tue, 11 Nov 2014 09:26:26 -0800 > This patch series replaces __skb_alloc_pages with a much simpler function, > __dev_alloc_pages. The main difference between the two is that > __skb_alloc_pages had an sk_buff pointer that was being passed as NULL in > call places wher

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 05:07:40 + > How about that when a error occurs, add the remaining rx > to the list without submission? Then, the remianing rx > could be re-submitted later, and the rtl_start_rx() could > be completed as soon as possible. I really want to know why you

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-11 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 05:23:03 + > David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, November 12, 2014 1:13 PM > [...] >> I really want to know why you are spending so much effort on this. >> >> Is there a real situation that

Re: "asix: Don't reset PHY on if_up for ASIX 88772" breaks net on arndale platform

2014-11-12 Thread David Miller
Please do not top-post. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next v3 0/3] Code adjustment

2014-11-12 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 10:05:02 +0800 > v3: > Remove the test_bit for patch #2. > > v2: > Correct the spelling error for the comment of patch #3. > > v1: > Adjust some codes to make them more reasonable. Series applied, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-12 Thread David Miller
From: Hayes Wang Date: Wed, 12 Nov 2014 06:29:46 + > David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, November 12, 2014 1:44 PM > [...] >> What do other USB network drivers do in similar situations? > > According to the usbnet.c, it would make sure t

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-12 Thread David Miller
From: Hayes Wang Date: Thu, 13 Nov 2014 02:31:14 + > My last method which I mentioned yesterday is similar to > this one. The difference is that I would re-use the rx > buffers, so I have to add them to the list for re-submitting, > not alwayes allocate new one. > > Although one rx buffer co

Re: [PATCH net-next 2/2] r8152: adjust rtl_start_rx

2014-11-13 Thread David Miller
From: David Miller Date: Wed, 12 Nov 2014 22:31:46 -0500 (EST) > From: Hayes Wang > Date: Thu, 13 Nov 2014 02:31:14 + > >> My last method which I mentioned yesterday is similar to >> this one. The difference is that I would re-use the rx >> buffers, so I have to

Re: [PATCH v2] usbnet: rtl8150: remove unused variable

2014-11-19 Thread David Miller
From: Sudip Mukherjee Date: Tue, 18 Nov 2014 21:55:21 +0530 > remove unused variable > > Signed-off-by: Sudip Mukherjee > --- > > change in v2: changed the commit message Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to ma

Re: [PATCH net-next v3 0/2] r8152: adjust rx functions

2014-11-21 Thread David Miller
From: Hayes Wang Date: Thu, 20 Nov 2014 10:29:04 +0800 > v3: > For patch #1, remove unnecessary initialization for ret and > unnecessary blank line in r8152_submit_rx(). > > v2: > For patch #1, set actual_length to 0 before adding the rx to the > list, when a error occurs. > > For patch #2, cha

Re: [PATCH 1/1] net: USB: Deletion of unnecessary checks before the function call "kfree"

2014-11-21 Thread David Miller
From: SF Markus Elfring Date: Thu, 20 Nov 2014 16:16:16 +0100 > From: Markus Elfring > Date: Thu, 20 Nov 2014 16:11:56 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by u

Re: [PATCH net-next 0/2] r8152: use ECM mode for future chips

2014-11-23 Thread David Miller
From: Hayes Wang Date: Mon, 24 Nov 2014 11:09:47 +0800 > For the future chips which the r8152 doesn't support yet, we could > still use ECM mode for basic transmission. Gross, please don't do this. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message t

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-11-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Nov 2014 08:52:28 -0800 > On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote: >> Drop the tx packet which is more than the size of agg_buf_sz. When >> creating a bridge with the device, we may get the tx packet with >> TSO and the length is more than the gso_max_

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-11-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Nov 2014 10:44:19 -0800 > On Wed, 2014-11-26 at 12:06 -0500, David Miller wrote: >> From: Eric Dumazet >> Date: Wed, 26 Nov 2014 08:52:28 -0800 >> >> > On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote: >> >> Drop th

Re: [PATCH net-next] r8152: redefine REALTEK_USB_DEVICE

2014-12-09 Thread David Miller
From: Hayes Wang Date: Thu, 4 Dec 2014 10:43:11 +0800 > Redefine REALTEK_USB_DEVICE for the desired USB interface for probe(). > There are three USB interfaces for the device. USB_CLASS_COMM and > USB_CLASS_CDC_DATA are for ECM mode (config #2). USB_CLASS_VENDOR_SPEC > is for the vendor mode (con

Re: [PATCH net-next 2/2] r8152: check the status before submitting rx

2014-12-19 Thread David Miller
From: Hayes Wang Date: Fri, 19 Dec 2014 16:56:00 +0800 > Don't submit the rx if the device is unplugged, linking down, > or stopped. ... > @@ -1789,6 +1789,11 @@ int r8152_submit_rx(struct r8152 *tp, struct rx_agg > *agg, gfp_t mem_flags) > { > int ret; > > + /* The rx would be sto

Re: [PATCH net-next 2/2] r8152: check the status before submittingrx

2014-12-21 Thread David Miller
From: Hayes Wang Date: Mon, 22 Dec 2014 02:53:42 + > David Miller [mailto:da...@davemloft.net] >> Sent: Saturday, December 20, 2014 4:44 AM > [...] >> > Don't submit the rx if the device is unplugged, linking down, >> > or stopped. >> ... >&g

Re: [PATCH] qmi_wwan: Set random MAC on devices with buggy fw

2015-01-02 Thread David Miller
From: Kristian Evensen Date: Fri, 2 Jan 2015 16:21:45 +0100 > From: Kristian Evensen > > Some buggy firmwares export an incorrect MAC address (00:a0:c6:00:00:00). This > makes for example checking devices for random MAC addresses tricky, and you > might end up with multiple network interfaces

Re: [PATCH net] r8152: support ndo_features_check

2015-01-06 Thread David Miller
From: Hayes Wang Date: Tue, 6 Jan 2015 17:41:58 +0800 > Support ndo_features_check to avoid: > - the transport offset is more than the hw limitation when using hw checksum. > - the skb->len of a GSO packet is more than the limitation. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsu

Re: [PATCH net-next v2 0/2 RESEND] r8152: adjust r8152_submit_rx

2015-01-12 Thread David Miller
From: Hayes Wang Date: Fri, 9 Jan 2015 10:26:34 +0800 > v2: > Replace the patch #1 with "call rtl_start_rx after netif_carrier_on". > > For patch #2, replace checking tp->speed with netif_carrier_ok. > > v1: > Avoid r8152_submit_rx() from submitting rx during unexpected > moment. This could red

Re: [PATCH] usb/kaweth: use GFP_ATOMIC under spin_lock in usb_start_wait_urb()

2015-01-12 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 10 Jan 2015 02:16:22 +0300 > Commit e4c7f259c5be ("USB: kaweth.c: use GFP_ATOMIC under spin_lock") > makes sure that kaweth_internal_control_msg() allocates memory with > GFP_ATOMIC, > but kaweth_internal_control_msg() also calls usb_start_wait_urb() > that st

Re: [PATCH net-next] r8152: replace tasklet with NAPI

2015-01-14 Thread David Miller
From: Hayes Wang Date: Mon, 12 Jan 2015 12:06:23 +0800 > Replace tasklet with NAPI. > > Add rx_queue to queue the remaining rx packets if the number of the > rx packets is more than the request from poll(). > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send

Re: [PATCH] net: qmi_wwan: add support for Cinterion PXS8 and PHS8

2014-02-13 Thread David Miller
From: Aleksander Morgado Date: Wed, 12 Feb 2014 15:55:14 +0100 > When the PXS8 and PHS8 devices show up with PID 0x0053 they will expose both a > QMI port and a WWAN interface. > > CC: Hans-Christoph Schemmel > CC: Christian Schmiedl > CC: Nicolaus Colberg > CC: David McCullough > Signed-off

Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n'

2014-02-13 Thread David Miller
From: liujunliang_...@163.com Date: Thu, 13 Feb 2014 12:22:19 +0800 > From: Liu Junliang > > > Signed-off-by: Liu Junliang I think it's more canonical to specify no default at all. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vg

Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, setting to 'n'

2014-02-13 Thread David Miller
From: Sergei Shtylyov Date: Fri, 14 Feb 2014 03:38:17 +0300 > Hello. > > On 02/14/2014 02:32 AM, David Miller wrote: > >>> From: Liu Junliang > >>> Signed-off-by: Liu Junliang > >> I think it's more canonical to specify no default at all.

Re: [PATCH Resend] net: asix: add missing flag to struct driver_info

2014-02-14 Thread David Miller
From: Emil Goode Date: Thu, 13 Feb 2014 19:30:39 +0100 > The struct driver_info ax88178_info is assigned the function > asix_rx_fixup_common as it's rx_fixup callback. This means that > FLAG_MULTI_PACKET must be set as this function is cloning the > data and calling usbnet_skb_return. Not setting

Re: [PATCH v2] usbnet: remove generic hard_header_len check

2014-02-17 Thread David Miller
From: Emil Goode Date: Thu, 13 Feb 2014 17:50:19 +0100 > This patch removes a generic hard_header_len check from the usbnet > module that is causing dropped packages under certain circumstances > for devices that send rx packets that cross urb boundaries. > > One example is the AX88772B which oc

Re: [PATCH] USB2NET : SR9800 : Use %zu to format size_t

2014-02-17 Thread David Miller
Already fixed in the net tree. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 00/14] r8152: improvement and new features

2014-02-18 Thread David Miller
From: Hayes Wang Date: Tue, 18 Feb 2014 21:48:57 +0800 > Change some flows or behavior to improve the efficiency or make the > code readable. Besides, support WOL and runtime suspend. Series applied, but as Florian mentioned you should seriously consider converting this driver to use phylib. --

Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

2014-02-26 Thread David Miller
From: Bjørn Mork Date: Wed, 26 Feb 2014 13:13:12 +0100 > fre...@asix.com.tw writes: > >> From: Freddy Xin >> >> Add VID:DID for Lenovo OneLinkDock Gigabit LAN > > This is the same patch Keith Packard sent, but with a slighly different > description. I take that as another proof that we should

Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

2014-02-26 Thread David Miller
From: Bjørn Mork Date: Wed, 26 Feb 2014 22:14:10 +0100 > David Miller writes: > >> From: Bjørn Mork >> Date: Wed, 26 Feb 2014 13:13:12 +0100 >> >>> fre...@asix.com.tw writes: >>> >>>> From: Freddy Xin >>>> >>>>

Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

2014-02-26 Thread David Miller
From: Bjørn Mork Date: Wed, 26 Feb 2014 22:44:18 +0100 > David Miller writes: >> From: Bjørn Mork >> >>> No, sorry for being confusing. The patch is fine. But Keith sent it >>> first... >> >> Did I apply Keith's patch? > > No, you d

Re: [PATCH] USB AX88179/178A: Support D-Link DUB-1312

2014-03-02 Thread David Miller
From: Gerry Demaret Date: Fri, 28 Feb 2014 18:50:46 +0100 > Add the USB device ID for the D-Link DUB-1312 USB 3.0 to Gigabit Ethernet > Adapter to the AX88179/178A driver. > > Signed-off-by: Gerry Demaret Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH net-next 07/12] r8152: support rx checksum

2014-03-04 Thread David Miller
From: Hayes Wang Date: Tue, 4 Mar 2014 20:00:59 +0800 > @@ -1453,11 +1491,19 @@ static void rx_bottom(struct r8152 *tp) > pkt_len -= CRC_SIZE; > rx_data += sizeof(struct rx_desc); > > + checksum = r8152_rx_csum(tp, rx_desc); > +

Re: [PATCH net-next v2 12/13] r8152: add additional parameter for non x86 platform

2014-03-05 Thread David Miller
From: Hayes Wang Date: Wed, 5 Mar 2014 14:49:27 +0800 > Add additional parameter for non x86 platform for better throughput. > > Signed-off-by: Hayes Wang This commit message tells me absolutely nothing. First of all, it doesn't say what the issue is, why is the chip slower on non-x86 platfor

Re: [PATCH net-next 0/3] r8152: cleanups

2014-03-06 Thread David Miller
From: Hayes Wang Date: Thu, 6 Mar 2014 15:07:15 +0800 > Deal with some empty lines and spaces, replace some tp->netdev with netdev, > and remove the unnecessary function. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message t

Re: [PATCH net-next 0/7] r8152: tx/rx improvement

2014-03-07 Thread David Miller
From: Hayes Wang Date: Fri, 7 Mar 2014 11:04:33 +0800 > - Select the suitable spin lock for each function. > - Add additional check to reduce the spin lock. > - Up the priority of the tx to avoid interrupted by rx. > - Support rx checksum, large send, and IPv6 hw checksum. Series applied, th

Re: [PATCH net-next v2 10/13] r8152: support IPv6

2014-03-09 Thread David Miller
From: Ben Hutchings Date: Sun, 09 Mar 2014 19:47:55 + > On Wed, 2014-03-05 at 14:49 +0800, Hayes Wang wrote: >> Support hw IPv6 checksum for TCP and UDP packets. >> >> Note that the hw has the limitation of the range of the transport >> offset. Besides, the TCP Pseudo Header of the IPv6 TSO

Re: [PATCH net-next] r8152: add skb_cow_head

2014-03-10 Thread David Miller
From: Hayes Wang Date: Mon, 10 Mar 2014 14:22:31 +0800 > Call skb_cow_head() before editing the tx packet header. The header > would be reallocated if it is shared. > > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions

Re: [PATCH net-next v2] r8152: add skb_cow_head

2014-03-10 Thread David Miller
From: Hayes Wang Date: Tue, 11 Mar 2014 10:20:32 +0800 > Call skb_cow_head() before editing the tx packet header. The header > would be reallocated if it is shared. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the bod

Re: [PATCH net-next] r8152: support dumping the hw counters

2014-03-11 Thread David Miller
From: Hayes Wang Date: Tue, 11 Mar 2014 16:24:19 +0800 > Add dumping the tally counter by ethtool. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net-next 8/9] lg-vl600: Convert uses of __constant_ to

2014-03-12 Thread David Miller
From: Joe Perches Date: Wed, 12 Mar 2014 10:22:37 -0700 > The use of __constant_ has been unnecessary for quite awhile now. > > Make these uses consistent with the rest of the kernel. > > Signed-off-by: Joe Perches Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH net-next v3 1/2] r8152: add RTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-13 Thread David Miller
From: David Laight Date: Thu, 13 Mar 2014 13:12:35 + > From: Hayes Wang > ... > > I should have spotted this before. > >> /* USB_RX_EARLY_AGG */ >> -#define EARLY_AGG_SUPPER0x0e832981 >> +#define EARLY_AGG_SUPER rx_buf_sz - 1522) / 4) << 16) | \ >> +(u32)(CONFIG_RTL8152_EAR

Re: [PATCH net-next v3 1/2] r8152: addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-13 Thread David Miller
From: hayeswang Date: Fri, 14 Mar 2014 10:37:21 +0800 > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, March 14, 2014 1:22 AM > [...] >> And I fundamentally disagree with this being a Kconfig parameter. >> >> Make it run-time calculated _or_ settab

Re: [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-14 Thread David Miller
From: hayeswang Date: Fri, 14 Mar 2014 15:24:50 +0800 > Besides, I don't wish to modify the setting by ethtool when re-loading > the driver or rebooting every time. You have code to reset the driver, you can do it when the user asks for the setting to be changed via ethtool. I do not see this a

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

2014-03-17 Thread David Miller
From: Ben Chan Date: Mon, 17 Mar 2014 17:46:27 -0700 > Thanks again for the review and tip. I've submitted patch v2 to > address the le16_to_cpu conversion. When you update a patch from a series, you should repost the entire patch set, rather than just the patch which changes. This avoids any a

Re: [PATCH net,stable] net: cdc_ncm: fix control message ordering

2014-03-18 Thread David Miller
From: Bjørn Mork Date: Mon, 17 Mar 2014 16:25:18 +0100 > This is a context modified revert of commit 6a9612e2cb22 > ("net: cdc_ncm: remove ncm_parm field") which introduced > a NCM specification violation, causing setup errors for > some devices. These errors resulted in the device and > host dis

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

2014-03-19 Thread David Miller
From: Ben Chan Date: Mon, 17 Mar 2014 21:00:06 -0700 > On Mon, Mar 17, 2014 at 6:41 PM, David Miller wrote: >> From: Ben Chan >> Date: Mon, 17 Mar 2014 17:46:27 -0700 >> >>> Thanks again for the review and tip. I've submitted patch v2 to >>> addres

Re: [PATCH v3 1/2] USB: cdc: add MBIM extended functional descriptor structure

2014-03-19 Thread David Miller
From: Bjørn Mork Date: Tue, 18 Mar 2014 09:35:57 +0100 > Or will patchwork keep track of tags across different patch > versions? It doesn't, and should not. It has no idea if the patch changed or not, the ACK'er might not still agree with the patch if any changes were made. -- To unsubscribe fr

Re: [PATCH net-next v4 0/2] adjust MTU as indicated by MBIM extended functional descriptor

2014-03-20 Thread David Miller
u conversion issue in patch 2/2 pointed out by > Bjørn Mork > v3: No code changes. Resubmitted to include patch 1/2 as suggested by > David Miller > v4: No code changes. Resubmitted as suggested by David Miller: > - Added a summary of the patch set > - Carried t

Re: [PATCH net] r8152: check RTL8152_UNPLUG

2014-04-11 Thread David Miller
From: Hayes Wang Date: Fri, 11 Apr 2014 17:54:31 +0800 > When the device is unplugged, the driver would try to disable the > device. Add checking the flag of RTL8152_UNPLUG to skip setting > the device when it is unplugged. This could shorten the time of > unloading the driver. > > Signed-off-by

Re: [PATCH net,stable 0/7] qmi_wwan: adding a few new devices

2014-04-27 Thread David Miller
From: Bjørn Mork Date: Fri, 25 Apr 2014 19:00:27 +0200 > Adding some new and some old QMI devices. A similar series for > usb-serial support will be posted as well. > > These new device ID patches should also go to all maintained stable kernels > where they apply. I believe that should be stabl

Re: [PATCH net,stable] net: cdc_ncm: fix buffer overflow

2014-05-05 Thread David Miller
From: Bjørn Mork Date: Fri, 2 May 2014 23:27:00 +0200 > Commit 4d619f625a60 ("net: cdc_ncm: no point in filling up the NTBs > if we send ZLPs") changed the padding logic for devices with the ZLP > flag set. This meant that frames of any size will be sent without > additional padding, except for

Re: [PATCH net,stable v2] net: cdc_mbim: __vlan_find_dev_deep need rcu_read_lock

2014-05-07 Thread David Miller
From: Bjørn Mork Date: Sat, 3 May 2014 16:12:47 +0200 > Fixes this warning introduced by commit 5b8f15f78e6f > ("net: cdc_mbim: handle IPv6 Neigbor Solicitations"): > > === > [ INFO: suspicious RCU usage. ] > 3.15.0-rc3 #213 Tainted: GW O > -

Re: [PATCH net,stable] net: cdc_mbim: handle unaccelerated VLAN tagged frames

2014-05-09 Thread David Miller
From: Bjørn Mork Date: Fri, 9 May 2014 14:45:00 +0200 > This driver maps 802.1q VLANs to MBIM sessions. The mapping is based on > a bogus assumption that all tagged frames will use the acceleration API > because we enable NETIF_F_HW_VLAN_CTAG_TX. This fails for e.g. frames > tagged in userspace

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe Date: Sun, 11 May 2014 00:12:32 + > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Mostly done via coccinelle script: > @@ > struct ethtool_ops *ops; > struct net_device *dev; > @@ > - SET_ET

Re: [PATCH net-next v2 0/4] cdc_mbim: cleanups and new features

2014-05-13 Thread David Miller
From: Bjørn Mork Date: Sun, 11 May 2014 10:47:11 +0200 > This series depends on commit 6b5eeb7f874b ("net: cdc_mbim: handle > unaccelerated VLAN tagged frames"), which is currently in "net" but > not yet in "net-next". Series applied, thanks a lot. -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.

2014-05-13 Thread David Miller
From: Evgeny Boger Date: Sun, 11 May 2014 17:34:14 +0400 > There might be 11 GPIOs in total. Last three GPIOs (offsets 8-11, 0-based) > are shared > with FDX, LNKA, SPD LEDs respectively. The LEDs are driven by chip by default > at startup time. Once the corresponding GPIO is requested, the chi

Re: [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool

2014-05-16 Thread David Miller
From: Bjørn Mork Date: Fri, 16 May 2014 21:48:17 +0200 > Quoting the previous description of this series (skip to the > changelog below if you only want a summary of the changes): Ok I'm fine with this, applied to net-next. Just make doubly sure that you will be ok, for a long time, with using

Re: [PATCH net-next v2 00/12] cdc_ncm: add buffer tuning and stats using ethtool

2014-05-18 Thread David Miller
From: Bjørn Mork Date: Sun, 18 May 2014 16:50:30 +0200 > I could be wrong, but my impression is that the userspace API > preferences for network devices are > > 1. ethtool > 2. sysfs > 3. module param > .. > 99. ioctl I would swap module param and ioctl, module params are the least desirab

Re: [PATCH net-next] net: cdc_ncm: fix 64bit division build error

2014-05-20 Thread David Miller
From: Bjørn Mork Date: Mon, 19 May 2014 09:21:09 +0200 > The upper timer_interval limit is arbitrary and much higher > than anything usable in the real world. Reducing it from 15s > to ~4s to make the timer_interval fit in an u32 does not make > much difference. The limit is still outside the p

Re: skbuff truesize incorrect.

2014-05-22 Thread David Miller
From: Jim Baxter Date: Thu, 22 May 2014 20:07:41 +0100 > My questions are: > > 1) Which buffer size does truesize represent, is it the total buffer or > just the data related to the relevant skb? > > 2) If truesize is for the skb it is contained within should it be > updated during the call to

Re: skbuff truesize incorrect.

2014-05-22 Thread David Miller
From: Jim Baxter Date: Thu, 22 May 2014 21:21:55 +0100 > If there are multiple clones for an skb all pointing at the same data, > will that distort the memory used when they all have the same truesize? What is distorted about it? Each clone references exactly that much backing memory. -- To uns

Re: skbuff truesize incorrect.

2014-05-22 Thread David Miller
From: Eric Dumazet Date: Thu, 22 May 2014 14:03:21 -0700 > On Thu, 2014-05-22 at 13:58 -0700, Eric Dumazet wrote: > >> I would set rx_max (rx_urb_size) to SKB_MAX_HEAD(0) so that you do not >> use high order allocations. > > Correction, that would need SKB_MAX_HEAD(NET_SKB_PAD + NET_IP_ALIGN),

Re: skbuff truesize incorrect.

2014-05-23 Thread David Miller
From: Jim Baxter Date: Fri, 23 May 2014 10:21:19 +0100 > On 22/05/14 21:58, David Miller wrote: >> From: Jim Baxter >> Date: Thu, 22 May 2014 21:21:55 +0100 >> >>> If there are multiple clones for an skb all pointing at the same data, >>> will that dis

Re: skbuff truesize incorrect.

2014-05-23 Thread David Miller
From: David Laight Date: Fri, 23 May 2014 08:52:13 + > The hardware will put multiple ethernet frames into a single USB bulk data > message. To handle this the driver generates a URB that is (hopefully) long > enough for the longest USB message (typically 32k is assumed to be enough). > The U

Re: skbuff truesize incorrect.

2014-05-27 Thread David Miller
From: David Laight Date: Tue, 27 May 2014 15:23:14 + > True, you still need to sort out how to handle multiple ethernet > frames in the same 4k page, and arbitrary page boundaries within a > frame. Multiple ethernet frames in the same 4K page is used by several ethernet drivers already. NIU

Re: [PATCH net-next 0/8] cdc_ncm: fixes and conversion to sysfs API

2014-05-29 Thread David Miller
From: Bjørn Mork Date: Thu, 29 May 2014 11:59:07 +0200 > I see that this series is now marked "Not Applicable" in patchwork. But > the reason is not obvious to me. May I ask why? I meant to mark it as "Changes Requested", because patch 8 had some feedback that you said you'd address. -- To unsu

Re: [PATCH 14/18] r8152: Use kmemdup instead of kmalloc + memcpy

2014-05-30 Thread David Miller
From: Benoit Taine Date: Mon, 26 May 2014 17:21:23 +0200 > This issue was reported by coccicheck using the semantic patch > at scripts/coccinelle/api/memdup.cocci > > Signed-off-by: Benoit Taine > --- > Tested by compilation without errors. Applied to net-next, thank you. -- To unsubscribe fr

Re: [PATCH] net: qmi_wwan: add Netgear AirCard 341U

2014-06-01 Thread David Miller
From: Aleksander Morgado Date: Wed, 28 May 2014 21:05:03 +0200 > Signed-off-by: Aleksander Morgado Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

Re: [PATCH] net: qmi_wwan: interface #11 in Sierra Wireless MC73xx is not QMI

2014-06-02 Thread David Miller
From: Aleksander Morgado Date: Thu, 29 May 2014 13:51:36 +0200 > This interface is unusable, as the cdc-wdm character device doesn't reply to > any QMI command. Also, the out-of-tree Sierra Wireless GobiNet driver fully > skips it. > > Signed-off-by: Aleksander Morgado Applied. -- To unsubscri

Re: [PATCH] net: qmi_wwan: add additional Sierra Wireless QMI devices

2014-06-02 Thread David Miller
From: Aleksander Morgado Date: Thu, 29 May 2014 13:44:45 +0200 > A set of new VID/PIDs retrieved from the out-of-tree GobiNet/GobiSerial > Sierra Wireless drivers. > > Signed-off-by: Aleksander Morgado Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH v2 net-next 0/8] cdc_ncm: fixes and conversion to sysfs API

2014-06-02 Thread David Miller
From: Bjørn Mork Date: Fri, 30 May 2014 09:31:02 +0200 > After considering the comments received after the ethtool coalesce > support was commited, I have ended up concluding that we should > remove it again, while we can, before it hits a release. The idea > was not well enough thought through,

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-11 Thread David Miller
From: Milos Vyletel Date: Tue, 10 Jun 2014 13:49:35 -0400 > On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger > wrote: >> On Tue, 10 Jun 2014 12:19:11 -0400 >> Milos Vyletel wrote: >> >>> As it is right now net.ipv6.conf.all.* are mostly ignored and instead >>> we're only making decisions base

Re: [PATCH V3] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-09 Thread David Miller
From: Enrico Mioso Date: Wed, 8 Jul 2015 13:05:57 +0200 > NCM specs are not actually mandating a specific position in the frame for > the NDP (Network Datagram Pointer). However, some Huawei devices will > ignore our aggregates if it is not placed after the datagrams it points > to. Add support

Re: [PATCH] cdc_ncm: update specs URL

2015-07-11 Thread David Miller
From: Enrico Mioso Date: Sat, 11 Jul 2015 17:30:01 +0200 > Update referenced specs link to reflect actual file version and location. > > Signed-off-by: Enrico Mioso Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vg

Re: [PATCH net-next] r8152: support the new RTL8153 chip

2015-07-22 Thread David Miller
From: Hayes Wang Date: Wed, 22 Jul 2015 15:27:41 +0800 > Support the new USB gigabit ethernet. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH net v2 0/3] r8152: issues fix

2015-07-27 Thread David Miller
From: Hayes Wang Date: Fri, 24 Jul 2015 13:54:22 +0800 > v2: > Replace patch #2 with "r8152: fix wakeup settings". > > v1: > These patches are used to fix issues. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to major

Re: [PATCH net v3 0/2] r8152: device reset

2015-07-30 Thread David Miller
From: Hayes Wang Date: Wed, 29 Jul 2015 20:39:07 +0800 > v3: > For patch #2, remove cancel_delayed_work(). > > v2: > For patch #1, remove usb_autopm_get_interface(), usb_autopm_put_interface(), > and > the checking of intf->condition. > > For patch #2, replace the original method with usb_queu

Re: [PATCH net-next] r8152: disable the capability of zero length

2015-07-31 Thread David Miller
From: Hayes Wang Date: Fri, 31 Jul 2015 11:23:39 +0800 > The UEFI driver would enable zero length, and the Linux driver doesn't > need it. Zero length let the hw complete the transfer with length 0, > when there is no received packet. It would add the load of USB host > controller and reduce the

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-18 Thread David Miller
From: Eugene Shatokhin Date: Fri, 14 Aug 2015 19:58:36 +0300 > 2. The second race is on dev->flags. > > dev->flags is set to 0 here: > *0 usbnet_stop (usbnet.c:816) > /* deferred work (task, timer, softirq) must also stop. > * can't flush_scheduled_work() until we drop rtnl (later), >

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread David Miller
From: Eugene Shatokhin Date: Wed, 19 Aug 2015 14:59:01 +0300 > So the following might be possible, although unlikely: > > CPU0 CPU1 > clear_bit: read dev->flags > clear_bit: clear EVENT_RX_KILL in the read value > > dev->flags=0; > >

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread David Miller
From: Alan Stern Date: Mon, 24 Aug 2015 14:06:15 -0400 (EDT) > On Mon, 24 Aug 2015, David Miller wrote: >> Atomic operations like clear_bit also will behave that way. > > Are you certain about that? I couldn't find any mention of it in > Documentation/atomic_ops.

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-08-25 Thread David Miller
From: Eugene Shatokhin Date: Mon, 24 Aug 2015 23:13:43 +0300 > The race may happen when a device (e.g. YOTA 4G LTE Modem) is > unplugged while the system is downloading a large file from the Net. > > Hardware breakpoints and Kprobes with delays were used to confirm that > the race does actually

Re: [PATCH 1/2] usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared

2015-08-25 Thread David Miller
From: Eugene Shatokhin Date: Mon, 24 Aug 2015 23:13:42 +0300 > It is needed to check EVENT_NO_RUNTIME_PM bit of dev->flags in > usbnet_stop(), but its value should be read before it is cleared > when dev->flags is set to 0. > > The problem was spotted and the fix was provided by > Oliver Neukum

Re: [PATCH] lan78xx: Fix ladv/radv error handling in lan78xx_link_reset()

2015-09-06 Thread David Miller
From: Geert Uytterhoeven Date: Fri, 4 Sep 2015 12:47:28 +0200 > net/usb/lan78xx.c: In function ‘lan78xx_link_reset’: > net/usb/lan78xx.c:1107: warning: comparison is always false due to limited > range of data type > net/usb/lan78xx.c:: warning: comparison is always false due to limited >

Re: [PATCH] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-08 Thread David Miller
From: Eugene Shatokhin Date: Tue, 1 Sep 2015 17:05:33 +0300 > The race may happen when a device (e.g. YOTA 4G LTE Modem) is > unplugged while the system is downloading a large file from the Net. > > Hardware breakpoints and Kprobes with delays were used to confirm that > the race does actually

Re: [PATCH 1/5] CDC: common parser for extra headers

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:38 +0200 > CDC drivers all implement their own parser for the extra headers. > This patch fixes the code duplication introducing a single common > parser in usbnet. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send

Re: [PATCH 4/5] qmi-wwan: use common parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:41 +0200 > This moves qmi-wwan to the common parser for CDC user > to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord..

Re: [PATCH 2/5] cdc-ncm: use common parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:39 +0200 > This moves cdc-ncm to the common parser for CDC user > to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...

Re: [PATCH 3/5] cdc-ether: switch to common CDC parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:40 +0200 > This patch uses the common parser to parse extra CDC > headers in order to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mes

Re: [PATCH 5/5] cdc-phonet: use common parser

2015-09-15 Thread David Miller
From: Oliver Neukum Date: Mon, 7 Sep 2015 16:05:42 +0200 > This moves cdc-phonet to the common parser for CDC users > to reduce code duplication. > > Signed-off-by: Oliver Neukum Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to major

Re: [PATCH 27/38] usbnet: remove invalid check

2015-09-22 Thread David Miller
From: Andrzej Hajda Date: Mon, 21 Sep 2015 15:33:59 +0200 > skb->len is always non-negative. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed

Re: [PATCH] ch9200: Convert to use module_usb_driver

2015-09-22 Thread David Miller
From: Tobias Klauser Date: Tue, 22 Sep 2015 09:29:49 +0200 > Converts the ch9200 driver to use the module_usb_driver() macro which > makes the code smaller and a bit simpler. > > Signed-off-by: Tobias Klauser Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-u

Re: [PATCH net-next v2] r8152: reduce the number of Tx

2014-08-29 Thread David Miller
From: Hayes Wang Date: Thu, 28 Aug 2014 10:24:18 +0800 > Because the Tx has the features of stopping queue and aggregation, > We don't need many tx buffers. Change the tx number from 10 to 4 > to reduce the usage of the memory. This could save 16K * 6 bytes > memory. > > Signed-off-by: Hayes Wan

Re: [PATCH net-next v2] r8152: reduce the number of Tx

2014-08-31 Thread David Miller
From: Hayes Wang Date: Mon, 1 Sep 2014 02:46:38 + > From: David Miller [mailto:da...@davemloft.net] > [...] >> This driver has a loop that iterates MAX_TX times to initialize both >> the RX and TX buffers. >> >> So if they are not equal, it can't pos

Re: [PATCH net-next] r8152: rename rx_buf_sz

2014-09-01 Thread David Miller
From: Hayes Wang Date: Tue, 2 Sep 2014 10:27:52 +0800 > The variable "rx_buf_sz" is used by both tx and rx buffers. Replace > it with "agg_buf_sz". > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord.

<    1   2   3   4   5   6   7   8   >