On 12/11/2014 09:47 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/11/2014 4:46 AM, Chanwoo Choi wrote:
>
>> I reviewed this patch quickly. This driver has just two gpio without any
>> registers for IP.
>
>Because there are no registers.
>
>> I wond
tate when interrupt
happen.
> + pdev->name, data);
> + if (ret < 0)
> + return ret;
Need to add error message.
> +
> + platform_set_drvdata(pdev, data);
> +
> + /* Perform initial detection */
&g
Thisp patchset remove unnecessary function call in of_extcon_get_extcon_dev()
which get the extcon device from devicetree. Also, this patchset move OF helper
func
to extcon core and change function name as following:
- of_extcon_get_extcon_dev() -> extcon_get_edev_by_phandle()
Chanwoo Choi
This patch remove unnecessary function call in of_extcon_get_extcon_dev()
by using the name of device_node structure.
Signed-off-by: Chanwoo Choi
---
drivers/extcon/of_extcon.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/extcon/of_extcon.c b/drivers
This patch move simply OF helper function to extcon core and change function
name as following:
- of_extcon_get_extcon_dev() -> extcon_get_edev_by_phandle()
Signed-off-by: Chanwoo Choi
---
drivers/extcon/Kconfig | 4 ---
drivers/extcon/Makefile | 2 --
drivers/extcon/ext
Hi,
On 03/19/2014 09:08 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Tuesday 18 March 2014 05:34 PM, Chanwoo Choi wrote:
>> This patch remove unnecessary function call in of_extcon_get_extcon_dev()
>> by using the name of device_node structure.
>>
>
Hi,
On 03/20/2014 02:20 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 20 March 2014 07:52 AM, Chanwoo Choi wrote:
>> Hi,
>>
>> On 03/19/2014 09:08 PM, Kishon Vijay Abraham I wrote:
>>> Hi,
>>>
>>> On Tuesday 18 March 2014 05:34 PM,
This patch uses devm_extcon_dev_{allocate, register} function for automatically
resource management of extcon device instead of legacy method and simplifies
the behavior of register/unregister for extcon device.
Signed-off-by: Chanwoo Choi
---
This patch has dependency about following patches[1
Hi Felipe,
On Mon, Jul 6, 2015 at 7:23 PM, Felipe Balbi wrote:
> On Wed, Jul 01, 2015 at 01:11:30PM +0900, Chanwoo Choi wrote:
>> This patch removes the deprecated notifier API of extcon framwork
>> and then use the new extcon API with the unique id to indicate
>> the ea
Hi Roger,
Thanks for your working.
I'll review, test and apply it on next week because I'm on vacation now.
Thanks,
Chanwoo Choi
On Tue, Jul 7, 2015 at 3:06 PM, Roger Quadros wrote:
> Users of find_cable_index_by_name() will cause a kernel hang
> as the while loop counter is n
Hi Roger,
On 07/27/2015 07:39 PM, Roger Quadros wrote:
> Chanwoo,
>
> On 10/07/15 18:54, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> Thanks for your working.
>>
>> I'll review, test and apply it on next week because I'm on vacation now.
>
> Can
Hi Roger,
I add minor comment about code clean.
After I modified it by myself, I applied it on extcon-fixes.
Best Regards,
Chanwoo Choi
On 07/07/2015 10:06 PM, Roger Quadros wrote:
> Users of find_cable_index_by_name() will cause a kernel hang
> as the while loop counter is never incre
he new state.
>
> Fix this by first changing the extcon state variable and then
> notifying listeners.
>
> Signed-off-by: Roger Quadros
> ---
> drivers/extcon/extcon.c | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
Applied it.
Thanks,
Chanwoo Ch
> initialization before IRQ handler registration fixes this problem.
>>
>> Signed-off-by: Robert Baldyga
>> Acked-by: Roger Quadros
>
> Can you please pick this patch for 4.1 (or 4.1-rc) as it fixes a bug. Thanks.
I already sent pull request for v4.1 and merged it.
ocate extcon device\n");
> - return -ENOMEM;
> - }
> -
> - ret = devm_extcon_dev_register(dev, info->edev);
> - if (ret < 0) {
> - dev_err(dev, "failed to register extcon device\n");
> - return ret;
> -
EXTCON_CABLE_USB], true);
> }
Looks good to me of this patch.
But, I have one question about case[3]
If id is low and vbus is high, this patch will update the state of both USB and
USB-HOST cable as attached state.
Is it possible that two different cables (both USB and USB-HOST) are connected
to one port s
Hi Robert,
On 04/09/2015 04:57 PM, Robert Baldyga wrote:
> Hi Chanwoo,
>
> On 04/09/2015 04:12 AM, Chanwoo Choi wrote:
>> Hi Robert,
>>
[snip]
>> But, I have one question about case[3]
>>
>> If id is low and vbus is high, this patch will update the stat
On 04/14/2015 07:02 PM, Roger Quadros wrote:
> Fixed Kishon's id.
>
> On 14/04/15 13:01, Roger Quadros wrote:
>> On 10/04/15 12:18, Chanwoo Choi wrote:
>>> On 04/10/2015 05:46 PM, Robert Baldyga wrote:
>>>> On 04/10/2015 10:10 AM, Chanwoo Choi wrote:
>
On 04/14/2015 07:38 PM, Roger Quadros wrote:
> On 14/04/15 13:31, Chanwoo Choi wrote:
>> On 04/14/2015 07:02 PM, Roger Quadros wrote:
>>> Fixed Kishon's id.
>>>
>>> On 14/04/15 13:01, Roger Quadros wrote:
>>>> On 10/04/15 12:18, Chanwoo Cho
Hi Roger and Peter,
On 04/15/2015 04:50 PM, Roger Quadros wrote:
> On 15/04/15 06:27, Peter Chen wrote:
>> On Tue, Apr 14, 2015 at 08:29:34PM +0900, Chanwoo Choi wrote:
>>> On 04/14/2015 07:38 PM, Roger Quadros wrote:
>>>> On 14/04/15 13:31, Chanwoo Choi wrote:
>&
Hi Peter,
On 04/16/2015 10:59 AM, Peter Chen wrote:
> On Wed, Apr 15, 2015 at 06:26:23PM +0900, Chanwoo Choi wrote:
>> Hi Roger and Peter,
>>
>> On 04/15/2015 04:50 PM, Roger Quadros wrote:
>>> On 15/04/15 06:27, Peter Chen wrote:
>>>> On Tue, Apr 14, 20
On 04/16/2015 04:13 PM, Ivan T. Ivanov wrote:
> Hi,
>
> On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote:
>> Hi Peter,
>>
>> On 04/16/2015 10:59 AM, Peter Chen wrote:
>>>
>
>>> Ok, from USB point, external id/vbus value can't decide
On 04/16/2015 05:01 PM, Peter Chen wrote:
> On Thu, Apr 16, 2015 at 04:59:31PM +0900, Chanwoo Choi wrote:
>> On 04/16/2015 04:13 PM, Ivan T. Ivanov wrote:
>>> Hi,
>>>
>>> On Thu, 2015-04-16 at 16:00 +0900, Chanwoo Choi wrote:
>>>> Hi Peter,
&g
Dear Felipe,
If you review this patch, I'll apply it on extcon tree.
Best Regards,
Chanwoo Choi
On 05/21/2015 06:39 PM, Arnd Bergmann wrote:
> Today, the API for the extcon drivers was changed, along
> with all drivers in drivers/extcon. However, one extcon driver
> instead lives
data->vbus_det_gpio = devm_gpiod_get(dev, "usb0_vbus_det", GPIOD_IN);
>> +if (IS_ERR(data->vbus_det_gpio)) {
>> +if (PTR_ERR(data->vbus_det_gpio) == -EPROBE_DEFER)
>> + return -EPROBE_DEFER;
>> +data->vbus_det_gpio = NULL;
>> +
Hi Hans,
On 06/11/2015 05:21 PM, Hans de Goede wrote:
> Hi Chanwoo,
>
> Thanks for the quick review.
>
> On 11-06-15 10:07, Chanwoo Choi wrote:
>> Hi Hans,
>>
>> I add the comment about extcon-related code.
>>
>> Firstly,
>> I'd like yo
Hi,
On 06/11/2015 05:59 PM, Hans de Goede wrote:
> Hi,
>
> On 11-06-15 10:29, Chanwoo Choi wrote:
>> Hi Hans,
>>
>> On 06/11/2015 05:21 PM, Hans de Goede wrote:
>>> Hi Chanwoo,
>>>
>>> Thanks for the quick review.
>>>
>>>
On 06/11/2015 06:33 PM, Chanwoo Choi wrote:
> Hi,
>
> On 06/11/2015 05:59 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 11-06-15 10:29, Chanwoo Choi wrote:
>>> Hi Hans,
>>>
>>> On 06/11/2015 05:21 PM, Hans de Goede wrote:
>>>> Hi Chanwo
Hi,
On 06/11/2015 06:38 PM, Hans de Goede wrote:
> Hi,
>
> On 11-06-15 11:33, Chanwoo Choi wrote:
>> Hi,
>>
>> On 06/11/2015 05:59 PM, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 11-06-15 10:29, Chanwoo Choi wrote:
>>>> Hi Hans,
>&
following header file which
includes the unique id of supported external connectors.
- include/dt-bindings/extcon/extcon.h
Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead
of string")
Signed-off-by: Chanwoo Choi
---
Dear Greg,
I sent pull-request[1] of
Dear Greg,
On 06/12/2015 01:27 PM, Greg KH wrote:
> On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote:
>> This patch just redefine the unique id of supported external connectors
>> without
>> 'enum extcon' type. Because unique id would be used
Dear Greg,
On 06/12/2015 01:29 PM, Greg KH wrote:
> On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote:
>> This patch just redefine the unique id of supported external connectors
>> without
>> 'enum extcon' type. Because unique id would be used
ret = devm_extcon_dev_register(dev, data->extcon);
> + if (ret) {
> + dev_err(dev, "failed to register extcon: %d\n", ret);
> + return ret;
> + }
> + }
> +
> for (i = 0; i < data->num_phys; i++) {
> struct sun4i_usb_phy *phy = data->phys + i;
> char name[16];
Looks good to me about or extcon part.
Acked-by: Chanwoo Choi
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch uses the devm_extcon_dev_[allocate|register]() to manage the
resource automatically and replace deprecated API as following:
- extcon_[set|get]_cable_state(*edev, char *) ->
extcon_[set|get]_cable_state_(*edev, id)
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Signed-off-by: Chanwoo C
ate(*edev, char *) -> extcon_get_cable_state_(*edev, id)
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Signed-off-by: Chanwoo Choi
---
drivers/usb/dwc3/dwc3-omap.c | 32 +---
1 file changed, 13 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drive
ate(*edev, char *) -> extcon_get_cable_state_(*edev, id)
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Signed-off-by: Chanwoo Choi
---
drivers/usb/phy/phy-msm-usb.c | 20 ++--
include/linux/usb/msm_hsusb.h | 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drive
Cc: Sergei Shtylyov
Cc: Yoshihiro Shimoda
Cc: Peter Chen
Cc: Varka Bhadram
Cc: Takeshi Kihara
Signed-off-by: Chanwoo Choi
---
drivers/usb/renesas_usbhs/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/renesas_usbhs/common.c
b/drivers/usb/renesas_us
, unsigned int id,
bool cable_state);
Depends on:
This patch-set is based on latest linux.git[1] because this patch-set have
the dependency of extcon patches for Linux v4.2.
[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
Chanwoo Choi (5):
usb: dwc3
ate(*edev, char *) -> extcon_get_cable_state_(*edev, id)
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Signed-off-by: Chanwoo Choi
---
drivers/usb/phy/phy-omap-otg.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/phy/phy-omap-otg.c b/drivers/u
Hi Sergei,
I think this patch is too much delay. I recommend you better to develop
this driver based on latest extcon-next branch[1].
[1]
https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next
Thanks,
Chanwoo Choi
On 2015년 10월 21일 03:20, Sergei Shtylyov wrote
>>>> +
>>>> +gpio = of_get_named_gpio(np, "maxim,id-gpio", 0);
>>
>>> Use of_get_gpio() or of_get_gpio_flags().
>>
>> OK, I'll use the first one.
>
>No, I won't due to not being able to use "gpios" anymo
con = extcon;
> otg_dev->id_nb.notifier_call = omap_otg_id_notifier;
> otg_dev->vbus_nb.notifier_call = omap_otg_vbus_notifier;
>
>
Thanks for your fixes.
Reviewed-by: Chanwoo Choi
Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello,
I received the reply from you after too long time (17~18day).
You better to reply it more a little more quickly
if you have the question or new patches.
On 2015년 11월 10일 03:24, Sergei Shtylyov wrote:
> Hello.
>
> On 10/23/2015 08:56 AM, Chanwoo Choi wrote:
>
>>
Hi,
The same patch was already reviewed and applied on usb.git repository[1]
[1]
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes&id=2c2025b41aeff57963f9ae2dd909fea704c625ab
Thanks,
Chanwoo Choi
On 2015년 11월 20일 08:43, Heinrich Schuchardt wrote:
> The
2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef _INTEL_USB_MUX_H
> +#define _INTEL_USB_MUX_H
> +
> +#include
> +
> +struct intel_usb_mux;
> +
> +#ifdef CONFIG_EXTCON_INTEL_USB
> +struct intel_usb_mux *intel_usb_mux_register(struc
Hi Roger,
On 01/20/2015 02:52 AM, Roger Quadros wrote:
> This driver observes the USB ID pin connected over a GPIO and
> updates the USB cable extcon states accordingly.
>
> The existing GPIO extcon driver is not suitable for this purpose
> as it needs to be taught to understand USB cable states
info->id_irq);
> + return 0;
> +}
> +
> +static int usb_extcon_resume(struct device *dev)
> +{
> + struct usb_extcon_info *info = dev_get_drvdata(dev);
> +
> + disable_irq_wake(info->id_irq);
ditto as following:
if (device_may_wakeup
Hi Roger,
On 01/27/2015 01:27 AM, Roger Quadros wrote:
> Hi Chanwoo,
>
> All your comments are valid. Need some clarification on one comment.
>
> On 26/01/15 15:56, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> This patch looks good to me. But I add some comment.
&g
Hi Roger,
On 01/28/2015 12:38 AM, Roger Quadros wrote:
> Chanwoo,
>
> On 27/01/15 03:54, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> On 01/27/2015 01:27 AM, Roger Quadros wrote:
>>> Hi Chanwoo,
>>>
>>> All your comments are valid. Need some c
+ info->id_irqwake = false;
> + }
ditto.
if (device_may_wakeup(dev))
disable_irq_wake(info->id_irq);
> +
> + enable_irq(info->id_irq);
> +
> + return 0;
> +}
> +#endif
> +
> +static SIMPLE_DEV_PM_OPS(usb_extcon_pm_ops,
> +
Hi Roger,
On 01/29/2015 08:26 PM, Roger Quadros wrote:
> Chanwoo,
>
> On 29/01/15 03:49, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> We need to discuss one point about 'id_irqwake'.
>> I don't recommend to use 'id_irqwake' field.
>>
&
nabled flag */
> +
> + unsigned long debounce_jiffies;
> + struct delayed_work wq_detcable;
> +};
> +
> +/* List of detectable cables */
> +enum {
> + EXTCON_CABLE_USB = 0,
> + EXTCON_CABLE_USB_HOST,
> +
> + EXTCON_CABLE_END,
> +};
> +
&
an that only the first patch needs to go through extcon tree as
>> Tony
>> will pick the rest.
>
> Hold on. Let's first decide what we really want to go ahead with
> "USB-Host" or "USB-HOST".
Currently, extcon driver have used the specific cable name(USB
Hi Roger,
On 01/30/2015 11:03 PM, Roger Quadros wrote:
> On 30/01/15 02:11, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> On 01/28/2015 09:15 PM, Roger Quadros wrote:
>>> This driver observes the USB ID pin connected over a GPIO and
>>> updates the USB cable
Hi Roger,
On 02/02/2015 06:09 PM, Roger Quadros wrote:
> Chanwoo,
>
> On 02/02/15 07:04, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> On 01/30/2015 11:05 PM, Roger Quadros wrote:
>>> Hi,
>>>
>>> On 30/01/15 13:04, Roger Quadros wrote:
>>>
On 02/02/2015 07:01 PM, Roger Quadros wrote:
> On 02/02/15 11:55, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> On 02/02/2015 06:09 PM, Roger Quadros wrote:
>>> Chanwoo,
>>>
>>> On 02/02/15 07:04, Chanwoo Choi wrote:
>>>> Hi Roger,
>
Hi Roger,
Looks good to me. Applied it on v3.21 queue.
Thanks,
Chanwoo Choi
On 02/02/2015 07:21 PM, Roger Quadros wrote:
> This driver observes the USB ID pin connected over a GPIO and
> updates the USB cable extcon states accordingly.
>
> The existing GPIO extcon driver is not
dex 00ef24b..9352adc 100644
> --- a/include/linux/mfd/syscon/exynos5-pmu.h
> +++ b/include/linux/mfd/syscon/exynos5-pmu.h
> @@ -36,6 +36,9 @@
> #define EXYNOS5420_MTCADC_PHY_CONTROL(0x724)
> #define EXYNOS5420_DPTX_PHY_CONTROL (0x728)
>
> +/* Exynos5433
[EXTCON_CABLE_USB_HOST] = "USB-HOST",
>>>> + NULL,
>>>> +};
>>
>> I'm not exactly sure how else it is supposed to work if we
>> support only a subset of cables from the global extcon_cable_name[][].
>
> I don't see issue tha
Hi Robert,
Did you test the extcon-odroid-otg driver on Odroid-U3?
Thanks,
Chanwoo Choi
On 03/18/2015 11:04 PM, Robert Baldyga wrote:
> Hello,
>
> This patchset introduces OTG feature in DWC3 DRD driver. This allows
> to change dynamically between host and peripheral mode
HOST cable by using
different way,
Because some board which detect USB/USB-HOST by gpio have a little
different pin composition
I think only one extcon driver can support all cases with optional properties.
Roger,
I'd like you to share your plan to extent the extcon-usb-gpio.c for
removing duplicate work.
[snip]
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Robert,
On 03/20/2015 04:25 PM, Robert Baldyga wrote:
> Hi Chanwoo,
>
> On 03/19/2015 09:50 PM, Chanwoo Choi wrote:
>> Hi Roger,
>>
>> On Thu, Mar 19, 2015 at 11:45 PM, Roger Quadros wrote:
>>> On 19/03/15 14:19, George Cherian wrote:
>>>>
C is only used on X86)
> -Use new acpi_dev_get_first_match_name() helper to get the INT3496 device-name
> -Add Heikki's Reviewed-by
> ---
> drivers/extcon/Kconfig | 3 +-
> drivers/extcon/extcon-axp288.c | 176
> +++++++--
&g
axp288.ko] undefined!
>>
>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>> driver Kconfig entry, but this would build more code in
>> drivers/usb/common/ than is necessary.
>
> Ah, that variant of fixing this got posted yesterday and I acke
44 --
> 4 files changed, 240 deletions(-)
> delete mode 100644
> Documentation/devicetree/bindings/clock/exynos5440-clock.txt
> delete mode 100644 drivers/clk/samsung/clk-exynos5440.c
> delete mode 100644 include/dt-bindings/clock/exynos5440.h
>
Looks good to me. Thanks.
> 4 files changed, 495 deletions(-)
> delete mode 100644
> Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt
> delete mode 100644 drivers/cpufreq/exynos5440-cpufreq.c
>
Reviewed-by: Chanwoo Choi
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
0644 drivers/pinctrl/samsung/pinctrl-exynos5440.c
Looks good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
se + tmu_intclear);
After removing it, looks good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
he property capability of each external connector
Cc: Felipe Balbi
Cc: Kishon Vijay Abraham I
Cc: Greg Kroah-Hartman
Acked-by: Sebastian Reichel
Acked-by: Chen-Yu Tsai
Acked-by: Charles Keepax
Acked-by: Lee Jones
Signed-off-by: Chanwoo Choi
---
Changes from v1:
- Don't touch drivers/usb/
Dear Kishon,
Could you please review this patch?
After that, I'll make the immutable brand and then send the pull request
for power_supply, mfd, phy, usb and extcon framework.
On 2017년 10월 10일 19:17, Chanwoo Choi wrote:
> The extcon has two type of extcon devices as following.
>
Gently Ping.
Dear Kishon,
Could you please review this patch for 'drivers/phy/*'?
Regards,
Chanwoo Choi
On 2017년 10월 12일 12:40, Chanwoo Choi wrote:
> Dear Kishon,
>
> Could you please review this patch?
> After that, I'll make the immutable brand and then
n, as we will now fail to
> compile on !X86
> -Minor code style tweaks
> ---
> drivers/extcon/Kconfig| 3 +-
> drivers/extcon/extcon-intel-int3496.c | 59
> +++
> 2 files changed, 61 insertions(+), 1 deletion(-)
Acked-by: C
/extcon/extcon.c | 44 ++--
> include/linux/extcon.h | 6 ++
> 2 files changed, 40 insertions(+), 10 deletions(-)
Looks good to me. Just I added the minor comment.
Acked-by: Chanwoo Choi
>
> diff --git a/drivers/extcon/extcon.c b/drivers/ext
On 2017년 10월 18일 18:14, Hans de Goede wrote:
> Hi,
>
> On 18-10-17 04:33, Chanwoo Choi wrote:
>> Hi Hans,
>>
>> On 2017년 09월 23일 03:37, Hans de Goede wrote:
>>> Cherry Trail SoCs have a built-in USB-role mux for switching between
>>> the host and devi
Dear all,
I got the reviews from all maintainers related to this patch.
So, I make the immutable branch on extcon.git and then send
the pull request in order to prevent the possible merge conflict.
Best Regards,
Chanwoo Choi
Samsung Electronics
The following changes since commit
Hi,
On 2018년 02월 27일 16:11, Andrzej Hajda wrote:
> Since extcon property is not allowed in DT, extcon subsystem requires
> another way to get extcon device. Lets try the simplest approach - get
> edev by of_node.
>
> Signed-off-by: Andrzej Hajda
> Acked-by: Chanwoo Choi
&g
);
>
> - disable_irq(to_i2c_client(ctx->dev)->irq);
> - sii8620_hw_off(ctx);
> + if (ctx->extcon) {
> + extcon_unregister_notifier(ctx->extcon, EXTCON_DISP_MHL,
> +&ctx->extcon_nb);
Don't need to unregister the notifier if using devm_extcon_register_notifier().
> + flush_work(&ctx->extcon_wq);
> + if (ctx->cable_state > 0)
> + sii8620_cable_out(ctx);
> + } else {
> + sii8620_cable_out(ctx);
> + }
> drm_bridge_remove(&ctx->bridge);
>
> return 0;
>
If you use the resource managed function (devm_extcon_register_notifier), Looks
good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On 2018년 02월 27일 21:05, Andrzej Hajda wrote:
> On 27.02.2018 12:08, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 02월 27일 16:11, Andrzej Hajda wrote:
>>> From: Maciej Purski
>>>
>>> Currently MHL chip must be turned on permanently to detect MHL
On 2018년 02월 28일 22:44, Andrzej Hajda wrote:
> On 27.02.2018 23:26, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 02월 27일 21:05, Andrzej Hajda wrote:
>>> On 27.02.2018 12:08, Chanwoo Choi wrote:
>>>> Hi,
>>>>
>>>> On 2
ct the USB_HOST connector
on one h/w device?
Best Regards,
Chanwoo Choi
Samsung Electronics
On 2018년 03월 01일 00:07, Hans de Goede wrote:
> The AXP288 BC1.2 charger detection / extcon code may seem like a strange
> place to add code to control the USB role-switch on devices with an AXP288,
>
sztof will merge dts via
> samsung-soc tree.
>
> Is it OK, for all? Better ideas?
Krzysztof picked the dts patches. I'll make the immutable branch based on
v4.16-rc1
and apply them except for dts patchs. And I'll send the immutable branch to Rob
and Andrzej.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
> Hi Rob and Andrzej,
>
> On 2018년 03월 06일 21:53, Andrzej Hajda wrote:
>> Hi Rob, Chanwoo, Krzysztof,
>>
>>
>> On 27.02.2018 08:11, Andrzej Hajda wrote:
>>> Hi,
>>>
>>> Thanks for reviews
Hi Andrzej, Archit,
On 2018년 03월 07일 20:13, Andrzej Hajda wrote:
> Hi Chanwoo, Archit,
>
> On 07.03.2018 05:48, Chanwoo Choi wrote:
>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote:
>>> Hi Rob and Andrzej,
>>>
>>> On 2018년 03월 06일 21:53, Andrzej Ha
Hi Andrzej and Rob,
On 2018년 03월 09일 18:20, Andrzej Hajda wrote:
> Hi Chanwoo,
>
> On 08.03.2018 02:52, Chanwoo Choi wrote:
>> Hi Andrzej, Archit,
>>
>> On 2018년 03월 07일 20:13, Andrzej Hajda wrote:
>>> Hi Chanwoo, Archit,
>>>
>>> On 07.03.20
\|/ \|/
+--+
| USB PHY|
+--+
|
\|/
USB PHY may determine how much current
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- (deprecated) extcon_get_cable_state_() -> extcon_get_state()
Acked-by: Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
---
drivers/phy/qualcomm/phy-qcom-
Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 626883d9d176..ef0330
These patches replace the deprecated extcon API
and remove them from extcon framework.
The patch1 and patch2 were already acked by Kishon Vijay Abraham I.
If patch3/patch4 are reviewed, I'll create the immutable branch
and send the pull request to both usb and phy maintainer.
Chanwoo Ch
This patch replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: Raviteja Garimella
Signed-off-by: Chanwoo Choi
---
drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++---
1 file changed, 3 insertions(+)
ble_state_() -> extcon_get_state()
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi
---
include/linux/extcon.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/include/linux/extcon.h b/include/linux/extcon.h
index 7e206a9f88db..3ba02eecba2e 1006
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_get_state()
Cc: Kishon Vijay Abraham I
Cc: Raviteja Garimella
Signed-off-by: Chanwoo Choi
---
drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 8
1 file changed, 4 insertions(+), 4 deleti
Dear Kishon and Felipe,
Please review the patch3/patch4.
On 2017년 07월 17일 10:20, Chanwoo Choi wrote:
> These patches replace the deprecated extcon API
> and remove them from extcon framework.
>
> The patch1 and patch2 were already acked by Kishon Vijay Abraham I.
> If pa
Hi,
On 2017년 08월 02일 14:12, Kishon Vijay Abraham I wrote:
>
>
> On Monday 17 July 2017 06:50 AM, Chanwoo Choi wrote:
>> This patch uses the resource-managed extcon API for
>> extcon_register_notifier()
>> and replaces the deprecated extcon API as following:
&
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- (deprecated) extcon_get_cable_state_() -> extcon_get_state()
Acked-by: Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
---
drivers/phy/qualcomm/phy-qcom-
ainer.
Changes from v1:
- Fix capital error for 'acked-by' tag on patch2
- Add the acked-by tag of 'Kishon Vijay Abraham I' to patch3
Chanwoo Choi (5):
phy: qcom-usb-hs: Replace the extcon API
phy: rockchip-inno-usb2: Replace the extcon API
phy: phy-bcm-ns2-usbdrd: Replace
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
- extcon_set_cable_state_() -> extcon_set_state_sync()
Acked-by: Kishon Vijay Abraham I
Signed-off-by: C
This patch replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: Raviteja Garimella
Signed-off-by: Chanwoo Choi
---
drivers/usb/gadget/udc/snps_udc_plat.c | 6 +++---
1 file changed, 3 insertions(+)
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_get_state()
Cc: Raviteja Garimella
Acked-by: Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
---
drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 8
1 file changed, 4 insertions(+)
ble_state_() -> extcon_get_state()
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi
---
include/linux/extcon.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/include/linux/extcon.h b/include/linux/extcon.h
index 7e206a9f88db..3ba02eecba2e 1006
Dear Felipe,
Could you please review this patch?
I hope to remove the deprecated extcon API.
Regards,
Chanwoo Choi
On 2017년 08월 03일 17:20, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_get_cable_state_() -> extcon_get_state()
>
> C
101 - 200 of 211 matches
Mail list logo
