writes:
> + if (strstr(dev->udev->product, "D6000")) {
Huh? Can you please test that on all USB devices ever made?
Bjørn
writes:
> +static int cdc_ncm_get_ethernet_address(struct usbnet *dev,
> + struct cdc_ncm_ctx *ctx)
Is this function called anywhere? Shouldn't it replace the
usbnet_get_ethernet_addr() call in cdc_ncm_bind_common()?
But do note that cdc_ncm_bind_common() i
On Thu, Sep 05, 2019 at 08:51:15PM -0500, Charles Hyde wrote:
> This change adds support to cdc_ncm for ACPI MAC address pass through
> functionality that also exists in the Realtek r8152 driver. This is in
> support of Dell's Universal Dock D6000, to give it the same feature
> capability as is cu
+ if (strstr(dev->udev->product, "D6000")) {
+ sa.sa_family = dev->net->type;
+ if (get_acpi_mac_passthru(sa.sa_data)) {
+ if (!memcmp(dev->net->dev_addr, sa.sa_data,
+ ETH_ALEN)) {
+ if (!cdc_ncm_set_ethernet_address(dev, &sa))
How about use one if-statement instead of these three if-state
On Wed, Sep 04, 2019 at 09:27:14AM -0700, Ajay Gupta wrote:
> From: Ajay Gupta
>
> CCGx controller used on NVIDIA GPU card has two separate display
> altmode for two DP pin assignments. UCSI specification doesn't
> prohibits using separate display altmode.
>
> Current UCSI Type-C framework expec
On Fri, 2019-09-06 at 09:59 +0200, Bjørn Mork wrote:
> writes:
>
> > + if (strstr(dev->udev->product, "D6000")) {
>
> Huh? Can you please test that on all USB devices ever made?
Yeah. Can't VID/PID be used as the filter here instead?
Dan
Hi Heikki,
> > CCGx controller used on NVIDIA GPU card has two separate display
> > altmode for two DP pin assignments. UCSI specification doesn't
> > prohibits using separate display altmode.
> >
> > Current UCSI Type-C framework expects only one display altmode for all
> > DP pin assignment. Thi
From: Ajay Gupta
CCGx controller used on NVIDIA GPU card has two separate display
altmode for two DP pin assignments. UCSI specification doesn't
prohibits using separate display altmode.
Current UCSI Type-C framework expects only one display altmode for
all DP pin assignment. This patch squashes
> > + ret = usbnet_read_cmd(dev, USB_CDC_GET_NET_ADDRESS,
> > + USB_DIR_IN | USB_TYPE_CLASS
> > + | USB_RECIP_INTERFACE, 0,
> > + USB_REQ_SET_ADDRESS, buf, ETH_ALEN);
>
> Where did that USB_REQ_SET_ADDRESS come from? Did y
On Fri, 6 Sep 2019 charles.h...@dellteam.com wrote:
>
> > > + ret = usbnet_read_cmd(dev, USB_CDC_GET_NET_ADDRESS,
> > > + USB_DIR_IN | USB_TYPE_CLASS
> > > + | USB_RECIP_INTERFACE, 0,
> > > + USB_REQ_SET_ADDRESS, buf, ETH_ALEN);
>
> >
> > > > + ret = usbnet_read_cmd(dev, USB_CDC_GET_NET_ADDRESS,
> > > > + USB_DIR_IN | USB_TYPE_CLASS
> > > > + | USB_RECIP_INTERFACE, 0,
> > > > + USB_REQ_SET_ADDRESS, buf, ETH_ALEN);
> > >
> > > Where did
writes:
> What better suggestion do folks have, instead of using USB_REQ_SET_ADDRESS?
The spec is clear: wIndex is supposed to be 'NCM Communications
Interface'. That's how you address a specific NCM function (a USB
device can have more than one...), and that's what you'll see in all the
other
> > What better suggestion do folks have, instead of using
> USB_REQ_SET_ADDRESS?
>
> The spec is clear: wIndex is supposed to be 'NCM Communications Interface'.
> That's how you address a specific NCM function (a USB device can have more
> than one...), and that's what you'll see in all the other
writes:
>> > What better suggestion do folks have, instead of using
>> USB_REQ_SET_ADDRESS?
>>
>> The spec is clear: wIndex is supposed to be 'NCM Communications Interface'.
>> That's how you address a specific NCM function (a USB device can have more
>> than one...), and that's what you'll see
Quoting Bjorn Andersson (2019-09-06 11:25:30)
> On Thu 05 Sep 22:26 PDT 2019, Stephen Boyd wrote:
>
> >
> > Yes this looks like the approach that should be taken. One question
> > though, is this a micro-b connector or a type-c connector on the board?
> > I thought it was a type-c, so then this U
> static int cdc_ncm_init(struct usbnet *dev) {
> struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0];
> u8 iface_no = ctx->control->cur_altsetting->desc.bInterfaceNumber;
> int err;
>
> err = usbnet_read_cmd(dev, USB_CDC_GET_NTB_PARAMETERS,
>
16 matches
Mail list logo
