Re: [PATCH] usb: storage: skip only when uas driver is loaded

2019-07-02 Thread Oliver Neukum
Am Dienstag, den 02.07.2019, 10:36 +0800 schrieb JC Kuo: > An user might want to completely disable uas for some reason so he/she adds > "blacklist uas" to modprobe conf file. I think in case of this, usb-storage > driver has to enable this device with the legacy Bulk-only protocol instead > of

Re: [PATCH] usb: storage: skip only when uas driver is loaded

2019-07-02 Thread Greg KH
On Tue, Jul 02, 2019 at 02:56:25PM +0800, JC Kuo wrote: > --- > This email message is for the sole use of the intended recipient(s) and may > contain > confidential information. Any unauthorized review, use, disclosur

Re: [PATCH] usb: storage: skip only when uas driver is loaded

2019-07-02 Thread JC Kuo
On 7/2/19 3:34 PM, Greg KH wrote: > > Footers like this are not allowed on public mailing lists, and forbid me > to respond to... > Hi Greg, I am truly sorry for that. I have just figured out how to tell mail server not to add the footer. Please allow me to query again. Since blacklisting uas k

Re: [PATCH] usb: storage: skip only when uas driver is loaded

2019-07-02 Thread Greg KH
On Tue, Jul 02, 2019 at 03:57:04PM +0800, JC Kuo wrote: > On 7/2/19 3:34 PM, Greg KH wrote: > > > > Footers like this are not allowed on public mailing lists, and forbid me > > to respond to... > > > > Hi Greg, > I am truly sorry for that. I have just figured out how to tell mail server > not to

[PATCH 4.19 31/72] usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup

2019-07-02 Thread Greg Kroah-Hartman
commit bd6742249b9ca918565e4e3abaa06665e587f4b5 upstream OUT endpoint requests may somtimes have this flag set when preparing to be submitted to HW indicating that there is an additional TRB chained to the request for alignment purposes. If that request is removed before the controller can execute

[PATCH 4.19 30/72] usb: dwc3: gadget: remove wait_end_transfer

2019-07-02 Thread Greg Kroah-Hartman
commit fec9095bdef4e7c988adb603d0d4f92ee735d4a1 upstream Now that we have a list of cancelled requests, we can skip over TRBs when END_TRANSFER command completes. Cc: Fei Yang Cc: Sam Protsenko Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org Cc: sta...@vger.kernel.org # 4.19.y Signed-off-by: Fe

RE: No carrier lost information with gadget RNDIS/ECM

2019-07-02 Thread Peter Chen
> > > > I suspect it is not related to USB, would you please disable USB node at > > DTS to > measure again? > > With USB disabled (&usbotg1 and &usbotg2), VBUS is available when I connect to > the host and properly discharged when I disconnect. > I also tried the OTG's host mode yesterday. Whe

Re: [PATCH] usb: storage: skip only when uas driver is loaded

2019-07-02 Thread Oliver Neukum
Am Dienstag, den 02.07.2019, 14:56 +0800 schrieb JC Kuo: > > Since blacklisting uas kernel module is not a good idea and could break UAS Then don't do it. If you don't want a driver loaded for a device blacklisting the driver must not magically assign another driver. > capable storage functional

Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-07-02 Thread Oliver Neukum
Am Montag, den 01.07.2019, 10:17 -0400 schrieb Alan Stern: > On Mon, 1 Jul 2019, Oliver Neukum wrote: > > > Am Donnerstag, den 27.06.2019, 09:52 -0400 schrieb Alan Stern: > > > > > > > > Or maybe the WAIT_FOR_RESUME ioctl returns because there was a remote > > > wakeup. In this case also you w

[PATCH 2/2] usb: gadget: aspeed: Cleanup EP0 state on port reset

2019-07-02 Thread Herrenschmidt, Benjamin
Otherwise, we can have a stale state after a disconnect and reconnect causing errors on the first SETUP packet to the device. Signed-off-by: Benjamin Herrenschmidt --- drivers/usb/gadget/udc/aspeed-vhub/dev.c | 3 +++ drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 9 + drivers/usb/gadget/u

[PATCH 1/2] usb: gadget: aspeed: Don't set port enable change bit on reset

2019-07-02 Thread Herrenschmidt, Benjamin
This bit should be only set when the port enable goes down, for example, on errors. Not when it gets set after a port reset. MacOS seems sensitive to this and fails enumeration. Signed-off-by: Benjamin Herrenschmidt --- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 9 - 1 file changed, 8 in

Aspeed vhub configuration

2019-07-02 Thread Benjamin Herrenschmidt
Hi folks ! The Aspeed USB gadget "vhub" implements a hub emulation with a number of UDCs representing the hub slots. It's working ok now and has been upstream for a bit, however, one thing that's been annoying to some users is that I've just hard coded the hub's device descriptor. IE, the vendor/p

Re: Aspeed vhub configuration

2019-07-02 Thread Greg KH
On Tue, Jul 02, 2019 at 09:33:11PM +1000, Benjamin Herrenschmidt wrote: > Hi folks ! > > The Aspeed USB gadget "vhub" implements a hub emulation with a number > of UDCs representing the hub slots. It's working ok now and has been > upstream for a bit, however, one thing that's been annoying to som

Re: Aspeed vhub configuration

2019-07-02 Thread Benjamin Herrenschmidt
On Tue, 2019-07-02 at 14:24 +0200, Greg KH wrote: > > > That leaves me with two approaches, that aren't mutually exclusive, but > > I'd like to run them past the folks here before I start coding: > > > > - The defaults, currently hard coded, could be replaced with Kconfig > > options. > > > >

[PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-07-02 Thread Charles Yeh
Prolific has developed a new USB to UART chip: PL2303HXN PL2303HXN : PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE/PL2303GB The Vendor request used by the PL2303HXN (TYPE_HXN) is different from the existing PL2303 series (TYPE_HX & TYPE_01). Therefore, different Vendor requests are used to issue rel

RE: No carrier lost information with gadget RNDIS/ECM

2019-07-02 Thread Kai Ruhnau
Hi Peter, >> > I suspect it is not related to USB, would you please disable USB >> > node at DTS to >> measure again? >> >> With USB disabled (&usbotg1 and &usbotg2), VBUS is available when I >> connect to the host and properly discharged when I disconnect. >> I also tried the OTG's host mode y

Re: Aspeed vhub configuration

2019-07-02 Thread Felipe Balbi
Hi, Benjamin Herrenschmidt writes: > On Tue, 2019-07-02 at 14:24 +0200, Greg KH wrote: >> >> > That leaves me with two approaches, that aren't mutually exclusive, but >> > I'd like to run them past the folks here before I start coding: >> > >> > - The defaults, currently hard coded, could b

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

2019-07-02 Thread Oliver Neukum
Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton: > This doesn't make much sense though. e387ef5c47dd should apply this > quirk to all Logitech UVC webcams, and this is definitely a UVC-based > Logitech webcam with the appropriate VID and interface descriptor. > Surely it shouldn'

Re: Aspeed vhub configuration

2019-07-02 Thread Benjamin Herrenschmidt
On Tue, 2019-07-02 at 15:56 +0300, Felipe Balbi wrote: > We already have an interface for disconnecting from the host > programatically by disconnecting data pullup. > > static ssize_t soft_connect_store(struct device *dev, > struct device_attribute *attr, const char *buf, > size_t

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

2019-07-02 Thread Greg Kroah-Hartman
On Tue, Jul 02, 2019 at 02:46:42PM +0200, Oliver Neukum wrote: > Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton: > > > This doesn't make much sense though. e387ef5c47dd should apply this > > quirk to all Logitech UVC webcams, and this is definitely a UVC-based > > Logitech webca

Re: [PATCH] usb: storage: skip only when uas driver is loaded

2019-07-02 Thread JC Kuo
On 7/2/19 5:11 PM, Oliver Neukum wrote: > Am Dienstag, den 02.07.2019, 14:56 +0800 schrieb JC Kuo: >> >> Since blacklisting uas kernel module is not a good idea and could break UAS > > Then don't do it. If you don't want a driver loaded for a device > blacklisting the driver must not magically ass

Re: [PATCH V3] usb: gadget: storage: Remove warning message

2019-07-02 Thread Alan Stern
On Tue, 2 Jul 2019, Thinh Nguyen wrote: > Hi, > > Alan Stern wrote: > > On Fri, 10 May 2019, EJ Hsu wrote: > > > >> This change is to fix below warning message in following scenario: > >> usb_composite_setup_continue: Unexpected call > >> > >> When system tried to enter suspend, the fsg_disable()

Re: [PATCH] usb: core: devio: add ioctls for suspend and resume

2019-07-02 Thread Alan Stern
On Tue, 2 Jul 2019, Oliver Neukum wrote: > Am Montag, den 01.07.2019, 10:17 -0400 schrieb Alan Stern: > > On Mon, 1 Jul 2019, Oliver Neukum wrote: > > > > > Am Donnerstag, den 27.06.2019, 09:52 -0400 schrieb Alan Stern: > > > > > > > > > > > Or maybe the WAIT_FOR_RESUME ioctl returns because th

Re: configfs on dwc3: msc enum failed if three functions defined

2019-07-02 Thread Bin Liu
Hi, Sorry for the delay getting back on this. I was offline for quite some time. On Thu, Apr 25, 2019 at 03:44:57PM -0700, Jack Pham wrote: > Hi Bin, > > On Mon, Apr 22, 2019 at 08:43:57AM -0500, Bin Liu wrote: > > Hi Felipe, > > > > I am having an issue with dwc3 on TI AM57x device, and would

Re: [PATCH] usb: storage: skip only when uas driver is loaded

2019-07-02 Thread Oliver Neukum
Am Dienstag, den 02.07.2019, 22:05 +0800 schrieb JC Kuo: Hi, > I don't see the uas issue myself. I was trying to describe a situation that > user having issue with UAS storage and would like to blacklist uas module when > the user is not aware of the usb-storage quirks parameter. > > https://mar

Re: [PATCH] [PATCH v6] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-07-02 Thread Charles Yeh
> > pl2303_update_reg(serial, PL2303_HXN_FLOWCTRL, > PL2303_HXN_FLOWCTRL_MASK, > PL2303_HXN_CTRL_RTS_CTS); > Indent continuation lines at least two tabs<<--Done. > I'm asking why you write the value 0 instead of 3 (or say, 0xfc)? Your > docu

Re: configfs on dwc3: msc enum failed if three functions defined

2019-07-02 Thread Jack Pham
Hi Bin, On Tue, Jul 02, 2019 at 09:48:42AM -0500, Bin Liu wrote: > Hi, > > Sorry for the delay getting back on this. I was offline for quite some > time. > > On Thu, Apr 25, 2019 at 03:44:57PM -0700, Jack Pham wrote: > > Hi Bin, > > > > On Mon, Apr 22, 2019 at 08:43:57AM -0500, Bin Liu wrote: >

Re: configfs on dwc3: msc enum failed if three functions defined

2019-07-02 Thread Bin Liu
On Tue, Jul 02, 2019 at 09:51:22AM -0700, Jack Pham wrote: > Hi Bin, > > On Tue, Jul 02, 2019 at 09:48:42AM -0500, Bin Liu wrote: > > Hi, > > > > Sorry for the delay getting back on this. I was offline for quite some > > time. > > > > On Thu, Apr 25, 2019 at 03:44:57PM -0700, Jack Pham wrote: >

Re: [PATCH V3] usb: gadget: storage: Remove warning message

2019-07-02 Thread Thinh Nguyen
Thinh Nguyen wrote: > Alan Stern wrote: >> On Tue, 2 Jul 2019, Thinh Nguyen wrote: >> >>> Hi, >>> >>> Alan Stern wrote: On Fri, 10 May 2019, EJ Hsu wrote: > This change is to fix below warning message in following scenario: > usb_composite_setup_continue: Unexpected call > >>>

Re: configfs on dwc3: msc enum failed if three functions defined

2019-07-02 Thread Bin Liu
On Tue, Jul 02, 2019 at 12:50:13PM -0500, Bin Liu wrote: > On Tue, Jul 02, 2019 at 09:51:22AM -0700, Jack Pham wrote: > > Hi Bin, > > > > On Tue, Jul 02, 2019 at 09:48:42AM -0500, Bin Liu wrote: > > > Hi, > > > > > > Sorry for the delay getting back on this. I was offline for quite some > > > tim

Re: configfs on dwc3: msc enum failed if three functions defined

2019-07-02 Thread Felipe Balbi
Hi, Bin Liu writes: > On Tue, Jul 02, 2019 at 12:50:13PM -0500, Bin Liu wrote: >> On Tue, Jul 02, 2019 at 09:51:22AM -0700, Jack Pham wrote: >> > Hi Bin, >> > >> > On Tue, Jul 02, 2019 at 09:48:42AM -0500, Bin Liu wrote: >> > > Hi, >> > > >> > > Sorry for the delay getting back on this. I wa

Re: Aspeed vhub configuration

2019-07-02 Thread Felipe Balbi
Hi, Benjamin Herrenschmidt writes: > On Tue, 2019-07-02 at 15:56 +0300, Felipe Balbi wrote: >> We already have an interface for disconnecting from the host >> programatically by disconnecting data pullup. >> >> static ssize_t soft_connect_store(struct device *dev, >> struct de

[GIT PULL] USB-serial updates for 5.3-rc1

2019-07-02 Thread Johan Hovold
The following changes since commit 9e0babf2c06c73cda2c0cd37a1653d823adb40ec: Linux 5.2-rc5 (2019-06-16 08:49:45 -1000) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-5.3-rc1 for you to fetch changes up to f8377ef