[PATCHv2 2/4] rio500: fix memeory leak in close after disconnect

2019-05-07 Thread Oliver Neukum
If a disconnected device is closed, rio_close() must free the buffers. Signed-off-by: Oliver Neukum --- drivers/usb/misc/rio500.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/rio500.c b/drivers/usb/misc/rio500.c index fa921ae60ffa..a1832

[PATCHv2 3/4] rio500: simplify locking

2019-05-07 Thread Oliver Neukum
Admitting that there can be only one device allows us to drop any pretense about locking one device or a table of devices. Signed-off-by: Oliver Neukum --- drivers/usb/misc/rio500.c | 43 --- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/

[PATCHv2 1/4] rio500: refuse more than one device at a time

2019-05-07 Thread Oliver Neukum
This driver is using a global variable. It cannot handle more than one device at a time. The issue has been existing since the dawn of the driver. V2: Fixed locking in probe() Fixed Documentation Signed-off-by: Oliver Neukum Reported-by: syzbot+35f04d136fc975a70...@syzkaller.appspotmail.com

[PATCHv2 4/4] USB: rio500: update Documentation

2019-05-07 Thread Oliver Neukum
Added the newly added limit and updated the text a bit Signed-off-by: Oliver Neukum --- Documentation/usb/rio.txt | 54 +-- 1 file changed, 15 insertions(+), 39 deletions(-) diff --git a/Documentation/usb/rio.txt b/Documentation/usb/rio.txt index ca9a

Re: [PATCH 2/2] usb: xhci-mtk: Do not create shared_hcd if no USB 3.0 port available

2019-05-07 Thread Chunfeng Yun
Hi Nicolas, On Thu, 2019-05-02 at 12:56 +0800, Nicolas Boichat wrote: > When the controller only supports USB 2.0, do not even create the > USB 3.0 hcd/root hub. > > Signed-off-by: Nicolas Boichat > --- > drivers/usb/host/xhci-mtk.c | 44 +++-- > 1 file changed, 2

Resend: [PATCH] usb: xhci: avoid null pointer deref when bos field is NULL

2019-05-07 Thread Schmid, Carsten
Hi, two weeks ago i sent this mail to the linux-usb mailing list but got no answer. Maybe this has fallen through your filters? So resending it and adding Mathias in CC. Best regards Carsten -Ursprüngliche Nachricht- Von: Schmid, Carsten Gesendet: Donnerstag, 25. April 2019 17:20 An: l

Re: [PATCHv2 4/4] USB: rio500: update Documentation

2019-05-07 Thread Sergei Shtylyov
On 07.05.2019 10:38, Oliver Neukum wrote: Added the newly added limit and updated the text a bit Signed-off-by: Oliver Neukum --- Documentation/usb/rio.txt | 54 +-- 1 file changed, 15 insertions(+), 39 deletions(-) diff --git a/Documentation/usb

Re: [PATCH V2 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-05-07 Thread Nagarjuna Kristam
On 25-04-2019 19:25, Thierry Reding wrote: > On Thu, Apr 25, 2019 at 04:00:05PM +0300, Felipe Balbi wrote: >> Nagarjuna Kristam writes: >> >>> This patch adds UDC driver for tegra XUSB 3.0 device mode controller. >>> XUSB device mode controller support SS, HS and FS modes >>> >>> Based on work

[PATCH] usb: dwc2: Use generic PHY width in params setup

2019-05-07 Thread Jules Maselbas
Hi, The patch 'usb: dwc2: gadget: Replace phyif with phy_utmi_width' changed a little the "behavior" of the platform lowlevel hw init. As setting the params.utmi_phy_width at that time is pointless, see the attached patch for detailed information. I think that's why the USB on Exynos4412 fails,

[PATCH] usb: dwc2: Use generic PHY width in params setup

2019-05-07 Thread Jules Maselbas
Setting params.phy_utmi_width in dwc2_lowlevel_hw_init() is pointless since it's value will be overwritten by dwc2_init_params(). This change make sure to take in account the generic PHY width information during parmas initialization, done in dwc2_set_param_phy_utmi_width(). By doing so, the phy_

Re: Resend: [PATCH] usb: xhci: avoid null pointer deref when bos field is NULL

2019-05-07 Thread Mathias Nyman
On 7.5.2019 11.15, Schmid, Carsten wrote: Hi, two weeks ago i sent this mail to the linux-usb mailing list but got no answer. Maybe this has fallen through your filters? So resending it and adding Mathias in CC. Thanks, I notice them better when I'm added as To or CC. Adding patch to queue W

Re: [PATCH] usb: dwc2: Use generic PHY width in params setup

2019-05-07 Thread Marek Szyprowski
Hi Jules, On 2019-05-07 12:08, Jules Maselbas wrote: > Setting params.phy_utmi_width in dwc2_lowlevel_hw_init() is pointless since > it's value will be overwritten by dwc2_init_params(). > > This change make sure to take in account the generic PHY width information > during parmas initialization,

merge usbhid-dump into usbutils repo?

2019-05-07 Thread Greg KH
Hi Nikolai, As you know, usbhid-dump has been part of the usbutils repo for a long time, as a git submodule. And that's been fine, a bit messy at times for when I forgot to update the submodule, but overall ok. However, I've changed the way usbutils is being released (with the 011 release that I

Re: merge usbhid-dump into usbutils repo?

2019-05-07 Thread Nikolai Kondrashov
Hi Greg, On 5/7/19 5:00 PM, Greg KH wrote: So, what do you think about the two options here? I would absolutely be glad if you could take usbhid-dump under your wing! I have little time for the DIGImend project these days, for which it was developed. I have a bit of financing from Patreon and

Re: merge usbhid-dump into usbutils repo?

2019-05-07 Thread Greg KH
On Tue, May 07, 2019 at 05:23:05PM +0300, Nikolai Kondrashov wrote: > Hi Greg, > > On 5/7/19 5:00 PM, Greg KH wrote: > > So, what do you think about the two options here? > > I would absolutely be glad if you could take usbhid-dump under your wing! > > I have little time for the DIGImend project

[PATCH] usb: gadget: storage: Remove warning message

2019-05-07 Thread EJ Hsu
This change is to fix below warning message in following scenario: usb_composite_setup_continue: Unexpected call When system tried to enter suspend, the fsg_disable() will be called to disable fsg driver and send a signal to fsg_main_thread. However, at this point, the fsg_main_thread has already

[PATCH] usb: dwc3: move core validation to be after clks enable

2019-05-07 Thread Jun Li
From: Jun Li Register access in core validation may hang before the bulk clks are enabled. Fixes: b873e2d0ea1e ("usb: dwc3: Do core validation early on probe") Signed-off-by: Jun Li --- drivers/usb/dwc3/core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dri

Re: [PATCH] usb: gadget: storage: Remove warning message

2019-05-07 Thread Greg KH
On Wed, May 08, 2019 at 11:24:00AM +0800, EJ Hsu wrote: > This change is to fix below warning message in following scenario: > usb_composite_setup_continue: Unexpected call > > When system tried to enter suspend, the fsg_disable() will be called to > disable fsg driver and send a signal to fsg_mai

Re: [PATCH] usb: gadget: storage: Remove warning message

2019-05-07 Thread Greg KH
On Wed, May 08, 2019 at 11:24:00AM +0800, EJ Hsu wrote: > --- a/drivers/usb/gadget/function/storage_common.h > +++ b/drivers/usb/gadget/function/storage_common.h > @@ -1,4 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. > +