On 25-04-2019 19:25, Thierry Reding wrote:
> On Thu, Apr 25, 2019 at 04:00:05PM +0300, Felipe Balbi wrote:
>> Nagarjuna Kristam <nkris...@nvidia.com> writes:
>>
>>> This patch adds UDC driver for tegra XUSB 3.0 device mode controller.
>>> XUSB device mode controller support SS, HS and FS modes
>>>
>>> Based on work by:
>>> Mark Kuo <m...@nvidia.com>
>>> Andrew Bresticker <abres...@chromium.org>
>>>
>>> Signed-off-by: Nagarjuna Kristam <nkris...@nvidia.com>
>>> ---
>>> drivers/usb/gadget/udc/Kconfig | 10 +
>>> drivers/usb/gadget/udc/Makefile | 1 +
>>> drivers/usb/gadget/udc/tegra_xudc.c | 3702
>>> +++++++++++++++++++++++++++++++++++
>>> 3 files changed, 3713 insertions(+)
>>> create mode 100644 drivers/usb/gadget/udc/tegra_xudc.c
>>>
>>> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
>>> index 0a16cbd..f6f469c 100644
>>> --- a/drivers/usb/gadget/udc/Kconfig
>>> +++ b/drivers/usb/gadget/udc/Kconfig
>>> @@ -439,6 +439,16 @@ config USB_GADGET_XILINX
>>> dynamically linked module called "udc-xilinx" and force all
>>> gadget drivers to also be dynamically linked.
>>>
>>> +config USB_TEGRA_XUDC
>>> + tristate "NVIDIA Superspeed USB 3.0 Device Controller"
>>> + depends on ARCH_TEGRA
>>
>> no compile_test?
>
> That's not possible right now. The driver depends on functions that
> don't have dummy implementations to support COMPILE_TEST. I suppose
> that's something that we could change, but does it need to be part
> of this initial submission?
>
> On that note:
>
> Nagarjuna, I think we have PHY_TEGRA_XUSB as at least one other
> dependency. Without that the driver could be enabled but fail to link
> because of the missing implementations that that driver would've
> provided.
>
Yes. Will add PHY_TEGRA_XUSB as dependecy for funtional dependency too.
- Nagarjuna
> Thierry
>
