[no subject]

2019-04-25 Thread 林敬樺
投資できる1億5000万ドル相当の取引があります あなたの国のどんなビジネスエリアでも、より多くの情報のために私に答えてください。 電子メール:normansbs1...@126.com ここにのみあなたの応答を転送する:normansbs1...@126.com I have a business deal worth $150 Million USD which can be invested in any business area in your country,

Re: [PATCH v4 0/7] usb: typec: ucsi: Remaining changes for v5.2

2019-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 23, 2019 at 05:21:44PM +0300, Heikki Krogerus wrote: > Hi Greg, > > Ajay noticed that I was not considering earlier releases of the UCSI > specification with a specific UCSI command, GET_CURRENT_CAM, in v3. > The definition for the command was changed in UCSI specification v1.1. > The

[PATCH] xhci: update bounce buffer with correct sg num

2019-04-25 Thread Henry Lin
This change fixes a data corruption issue occurred on USB hard disk for the case that bounce buffer is used during transferring data. While updating data between sg list and bounce buffer, current implementation passes mapped sg number (urb->num_mapped_sgs) to sg_pcopy_from_buffer() and sg_pcopy_t

Re: [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes.

2019-04-25 Thread Felipe Balbi
Artur Petrosyan writes: > This patch set, fixes and improves partial power down and hibernation power > saving modes. Also, adds support for entering/exiting hibernation by > system issued suspend/resume. > > This series contains patches which were submitted to LKML. However, a part > of those pat

Re: [PATCH 01/14] usb: dwc2: Fix dwc2_restore_device_registers() function.

2019-04-25 Thread Felipe Balbi
Artur Petrosyan writes: > - Added backup of DCFG register. > - Added Set the Power-On Programming done bit. > > Signed-off-by: Artur Petrosyan won't apply. -- balbi signature.asc Description: PGP signature

Re: USB fuzzing with syzbot

2019-04-25 Thread Andrey Konovalov
On Wed, Apr 24, 2019 at 6:05 PM Andrey Konovalov wrote: > > On Fri, Apr 19, 2019 at 10:35 AM Greg Kroah-Hartman > wrote: > > > > > 2. Is there an easy way to figure out which config options enable > > > drivers reachable over USB? > > > > Looking for all options that depend on USB is a good start

Re: [PATCH 1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer

2019-04-25 Thread Felipe Balbi
Jules Maselbas writes: > Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and > mask defines to improve readability. > > Signed-off-by: Jules Maselbas Doesn't apply. Please make sure to rebase on testing/next -- balbi signature.asc Description: PGP signature

Re: [PATCH V2 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-04-25 Thread Felipe Balbi
Nagarjuna Kristam writes: > This patch adds UDC driver for tegra XUSB 3.0 device mode controller. > XUSB device mode controller support SS, HS and FS modes > > Based on work by: > Mark Kuo > Andrew Bresticker > > Signed-off-by: Nagarjuna Kristam > --- > drivers/usb/gadget/udc/Kconfig

[balbi-usb:testing/next 19/42] drivers/usb/dwc2/core_intr.c:448:25: error: 'struct dwc2_hsotg' has no member named 'phy_reset_work'

2019-04-25 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: 2e3cfcbbb1403feeac5949f32dcd2724de3ff40c commit: a0a493835f9a2e4c690c41145def88223997db2b [19/42] usb: dwc2: optionally assert phy reset when waking up config: x86_64-randconfig-x000-201916 (attached as .co

Command ring abort xhci_handshake question

2019-04-25 Thread Bollinger, Seth
Hello All, Recently I’ve been troubleshooting a problem with the host controller dying and noticed that when the controller dies, the system was unresponsive for a _long_ period of time. When I explored the code a bit, I saw that xhci_handshake will spin with interrupts disabled for up to 5 se

Re: [PATCH V2 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller

2019-04-25 Thread Thierry Reding
On Thu, Apr 25, 2019 at 04:00:05PM +0300, Felipe Balbi wrote: > Nagarjuna Kristam writes: > > > This patch adds UDC driver for tegra XUSB 3.0 device mode controller. > > XUSB device mode controller support SS, HS and FS modes > > > > Based on work by: > > Mark Kuo > > Andrew Bresticker > >

Re: [PATCH V2 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-04-25 Thread Thierry Reding
On Mon, Mar 11, 2019 at 04:41:52PM +0530, Nagarjuna Kristam wrote: > Add device-tree binding documentation for the XUSB device mode controller > present on tegra210 SoC. This controller supports USB 3.0 specification > > Based on work by Andrew Bresticker . > > Signed-off-by: Nagarjuna Kristam >

Re: [PATCH v1 00/14] usb: dwc2: Fix and improve power saving modes.

2019-04-25 Thread Artur Petrosyan
Hi, On 4/25/2019 16:43, Felipe Balbi wrote: > Artur Petrosyan writes: >> This patch set, fixes and improves partial power down and hibernation power >> saving modes. Also, adds support for entering/exiting hibernation by >> system issued suspend/resume. >> >> This series contains patches which we

Re: [PATCH V2 1/8] phy: tegra: xusb: t210: add XUSB dual mode support

2019-04-25 Thread Thierry Reding
On Mon, Mar 11, 2019 at 04:41:49PM +0530, Nagarjuna Kristam wrote: > The device tree bindings document the "mode" property of "ports" > subnodes, but the driver was not parsing the property. In preparation > for adding role switching, parse the property at probe time and > confgiure the port capabi

Re: Command ring abort xhci_handshake question

2019-04-25 Thread Alan Stern
On Thu, 25 Apr 2019, Bollinger, Seth wrote: > Hello All, > > Recently I’ve been troubleshooting a problem with the host > controller dying and noticed that when the controller dies, the > system was unresponsive for a _long_ period of time. When I explored > the code a bit, I saw that xhci_hands

Re: USB fuzzing with syzbot

2019-04-25 Thread Greg Kroah-Hartman
On Thu, Apr 25, 2019 at 02:44:11PM +0200, Andrey Konovalov wrote: > On Wed, Apr 24, 2019 at 6:05 PM Andrey Konovalov > wrote: > > > > On Fri, Apr 19, 2019 at 10:35 AM Greg Kroah-Hartman > > wrote: > > > > > > > 2. Is there an easy way to figure out which config options enable > > > > drivers rea

Re: Command ring abort xhci_handshake question

2019-04-25 Thread Bollinger, Seth
> On Apr 25, 2019, at 9:22 AM, Alan Stern wrote: > > Are you certain that those places with the very long timeouts are > called with interrupts disabled? I must admit, I have not reviewed all uses of the long xhci_handshakes. :) I have reviewed the following instance. In usb/host/xhci-ring.c

Re: [PATCH V2 2/8] phy: tegra: xusb: t210: add usb3 port fake support

2019-04-25 Thread Thierry Reding
On Mon, Mar 11, 2019 at 04:41:50PM +0530, Nagarjuna Kristam wrote: > On Tegra210, usb2 only otg/peripheral ports dont work in device mode. > They need an assosciated usb3 port to work in device mode. Identify > an unused usb3 port and assign it as a fake USB3 port to USB2 only > port whose mode is

Re: [PATCH] xhci: update bounce buffer with correct sg num

2019-04-25 Thread Mathias Nyman
On 25.4.2019 13.43, Henry Lin wrote: This change fixes a data corruption issue occurred on USB hard disk for the case that bounce buffer is used during transferring data. While updating data between sg list and bounce buffer, current implementation passes mapped sg number (urb->num_mapped_sgs) t

Re: [balbi-usb:testing/next 19/42] drivers/usb/dwc2/core_intr.c:448:25: error: 'struct dwc2_hsotg' has no member named 'phy_reset_work'

2019-04-25 Thread Doug Anderson
Hi, On Thu, Apr 25, 2019 at 6:14 AM kbuild test robot wrote: > >439 /* >440 * If we've got this quirk then the PHY is > stuck upon >441 * wakeup. Assert reset. This will > propagate out and >442

Re: [PATCH V2 3/8] phy: tegra: xusb: t210: add vbus override support

2019-04-25 Thread Thierry Reding
On Mon, Mar 11, 2019 at 04:41:51PM +0530, Nagarjuna Kristam wrote: > Tegra XUSB device control driver needs to control vbus override > during its operations, add API for the support > > Signed-off-by: Nagarjuna Kristam > --- > drivers/phy/tegra/xusb-tegra210.c | 61 > +++

Re: [PATCH V2 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding

2019-04-25 Thread Thierry Reding
On Mon, Mar 11, 2019 at 04:41:52PM +0530, Nagarjuna Kristam wrote: > Add device-tree binding documentation for the XUSB device mode controller > present on tegra210 SoC. This controller supports USB 3.0 specification Tegra210, please. "... supports the USB 3.0 ...". Also end sentences with a fulls

[PATCH] usb: xhci: avoid null pointer deref when bos field is NULL

2019-04-25 Thread Schmid, Carsten
Hi, some weeks ago, when stabilizing a production kernel, i have fixed a bug in the xhci driver. Mathias (Nyman) was involved checking the patch, and he wrote: .. Subject: Re: help needed - kernel crash in USB driver Hi Zainie I can look at a upstream fix for usb core, but we

Re: [PATCH 1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer

2019-04-25 Thread Jules Maselbas
Hi Felipe, On Thu, Apr 25, 2019 at 03:52:16PM +0300, Felipe Balbi wrote: > Jules Maselbas writes: > > > Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and > > mask defines to improve readability. > > > > Signed-off-by: Jules Maselbas > > Doesn't apply. Please make sure to

Re: [balbi-usb:testing/next 19/42] drivers/usb/dwc2/core_intr.c:448:25: error: 'struct dwc2_hsotg' has no member named 'phy_reset_work'

2019-04-25 Thread Doug Anderson
Hi, On Thu, Apr 25, 2019 at 8:02 AM Doug Anderson wrote: > > Hi, > > On Thu, Apr 25, 2019 at 6:14 AM kbuild test robot wrote: > > > >439 /* > >440 * If we've got this quirk then the PHY is > > stuck upon > >441

[PATCH 5/5] USB: cdc-acm: clean up throttle handling

2019-04-25 Thread Johan Hovold
Clean up the throttle implementation by dropping the redundant throttle_req flag which was a remnant from back when USB serial had only a single read URB, something which was later carried over to cdc-acm. Also convert the throttled flag to an atomic bit flag. Signed-off-by: Johan Hovold --- dr

[PATCH 3/5] USB: serial: generic: drop unnecessary goto

2019-04-25 Thread Johan Hovold
Drop an unnecessary goto from a write-urb completion error path. Signed-off-by: Johan Hovold --- drivers/usb/serial/generic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c index 67cef3ef1e5f..1be8bea372a2 100644

[PATCH 0/5] USB: fix tty unthrottle races

2019-04-25 Thread Johan Hovold
This series fixes a couple of long-standing issues in USB serial and cdc-acm which essentially share the same implementation. As noted by Oliver a few years back, read-urb completion can race with unthrottle() running on another CPU and this can potentially lead to memory corruption. This particul

[PATCH 2/5] USB: serial: clean up throttle handling

2019-04-25 Thread Johan Hovold
Clean up the throttle implementation by dropping the redundant throttle_req flag which was a remnant from back when there was only a single read URB. Also convert the throttled flag to an atomic bit flag. Signed-off-by: Johan Hovold --- drivers/usb/serial/generic.c | 34

[PATCH 4/5] USB: cdc-acm: fix unthrottle races

2019-04-25 Thread Johan Hovold
Fix two long-standing bugs which could potentially lead to memory corruption or leave the port throttled until it is reopened (on weakly ordered systems), respectively, when read-URB completion races with unthrottle(). First, the URB must not be marked as free before processing is complete to prev

[PATCH 1/5] USB: serial: fix unthrottle races

2019-04-25 Thread Johan Hovold
Fix two long-standing bugs which could potentially lead to memory corruption or leave the port throttled until it is reopened (on weakly ordered systems), respectively, when read-URB completion races with unthrottle(). First, the URB must not be marked as free before processing is complete to prev

Re: Use device tree to disable U1/U2 in gadget devices based on DWC3

2019-04-25 Thread Rob Weber
Hi Everyone, On Wed, Apr 24, 2019 at 02:33:48PM -0400, Alan Stern wrote: > On Wed, 24 Apr 2019, Claus H. Stovgaard wrote: > > > Hi Balbi and other USB developers. > > > > I am developing camera devices based on Xilinx ZynqMP, using the > > gadget framework and the build-in dwc3 core of the ZynqM

[usb:usb-next 54/62] drivers/usb/misc/usb251xb.c:248:50: error: dereferencing pointer to incomplete type 'struct gpio_chip'

2019-04-25 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: a4d6a2989dc3f2f2bcd25ca53dd187a1de68ffac commit: 6e3c8beb4f92a18a65e521cc5fe75874b6e2c860 [54/62] usb: usb251xb: Lock i2c-bus segment the hub resides config: x86_64-randconfig-s5-04260238 (attached as .config)

[PATCH 1/2] usb: dwc3: Fix default lpm_nyet_threshold value

2019-04-25 Thread Thinh Nguyen
The max possible value for DCTL.LPM_NYET_THRES is 15 and not 255. Change the default value to 15. Cc: sta...@vger.kernel.org Fixes: 80caf7d21adc ("usb: dwc3: add lpm erratum support") Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH 0/5] USB: fix tty unthrottle races

2019-04-25 Thread Alan Stern
On Thu, 25 Apr 2019, Johan Hovold wrote: > This series fixes a couple of long-standing issues in USB serial and > cdc-acm which essentially share the same implementation. > > As noted by Oliver a few years back, read-urb completion can race with > unthrottle() running on another CPU and this can

[PATCH 2/2] usb: dwc3: Rename DWC3_DCTL_LPM_ERRATA

2019-04-25 Thread Thinh Nguyen
The macro name DWC3_DCTL_LPM_ERRATA is uninformative and does not do masking. Remove DWC3_DCTL_LPM_ERRATA_MASK and rename DWC3_DCTL_LPM_ERRATA to DWC3_DCTL_NYET_THRES with proper masking. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/core.h | 3 +-- drivers/usb/dwc3/gadget.c | 2 +- 2 files

[PATCH] usb: dwc3: debug: Print GET_STATUS(device) tracepoint

2019-04-25 Thread Thinh Nguyen
DWC3 is missing the printing of control request GET_STATUS(device) tracepoint. This patch prints that. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/debug.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h index 6759a7efd8d5..068259fdf

[PATCH] usb: dwc3: Do core validation early on probe

2019-04-25 Thread Thinh Nguyen
The setting of the dr_mode may need to check the controller's revision. The revision is set in the dwc3_core_is_valid(), which comes after dr_mode setting. Let's move it closer to the start of the dwc3_probe() function and before calling dwc3_get_dr_mode(). Signed-off-by: Thinh Nguyen --- driver

[PATCH] usb: dwc3: gadget: Set lpm_capable

2019-04-25 Thread Thinh Nguyen
All DWC3 controllers are LPM capable. Report that in the usb_gadget.lpm_capable for the gadget driver to properly output the bcdUSB value in the descriptor. Signed-off-by: Thinh Nguyen --- drivers/usb/dwc3/gadget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/gadget.c b/d

Re: configfs on dwc3: msc enum failed if three functions defined

2019-04-25 Thread Jack Pham
Hi Bin, On Mon, Apr 22, 2019 at 08:43:57AM -0500, Bin Liu wrote: > Hi Felipe, > > I am having an issue with dwc3 on TI AM57x device, and would like to ask > for your comments. > > I use configfs to create a multi-function gadget on dwc3, mass_storage > is the last function, it seems if I create

Re: [PATCH] usbip: stub_rx: tidy the indenting in is_clear_halt_cmd()

2019-04-25 Thread shuah
On 4/24/19 3:54 AM, Dan Carpenter wrote: There is an extra space character before the return statement. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c index 97b09a42a10c..f3230bed18af 100644 --- a/drivers/usb/usbip/stub_rx.c +++ b/drivers/us

Re: [PATCH 0/5] USB: fix tty unthrottle races

2019-04-25 Thread Johan Hovold
On Thu, Apr 25, 2019 at 04:58:20PM -0400, Alan Stern wrote: > On Thu, 25 Apr 2019, Johan Hovold wrote: > > > This series fixes a couple of long-standing issues in USB serial and > > cdc-acm which essentially share the same implementation. > > > > As noted by Oliver a few years back, read-urb comp

[PATCH] USB: serial: drop unused iflag macro

2019-04-25 Thread Johan Hovold
Drop the RELEVANT_IFLAG() macro which essentially hasn't been used for over a decade except in some remnant debug printks that were recently removed. Signed-off-by: Johan Hovold --- include/linux/usb/serial.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/usb/serial.h b/incl

Re: [PATCH 0/9] USB: serial: fix initial-termios handling

2019-04-25 Thread Johan Hovold
On Sun, Apr 21, 2019 at 02:21:45PM +0200, Johan Hovold wrote: > A few drivers override the default initial termios settings provided by > USB serial core, but due to a long-standing bug, the terminal settings > were being reset on every (first) open rather than on first use after > probe as intende