Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-04-02 Thread Johan Hovold
On Wed, Feb 13, 2019 at 08:30:00PM +0800, Charles Yeh wrote: > Prolific has developed a new USB to UART chip: PL2303HXN > (PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE) Ok, let's get back to this one. First a general comment; please make sure to address all review comments. I've already pointed

Re: [PATCH] [v2]USB:serial:pl2303:add new Pull-Up mode to support PL2303HXD (TYPE_HX)

2019-04-02 Thread Johan Hovold
On Tue, Feb 12, 2019 at 08:50:49PM +0800, Charles Yeh wrote: > Pull-Up mode is disabled (default) in PL2303HXD. > When the Pull-Up mode is activated, its TX/DTR/RTS external resistor will > start the output function. > > How to enable the Pull-Up mode of PL2303HXD > 1.TX/DTR/RTS external resistor

Re: [PATCH] usb: typec: Registering real device entries for the muxes

2019-04-02 Thread kbuild test robot
/linux/commits/Heikki-Krogerus/usb-typec-Registering-real-device-entries-for-the-muxes/20190402-030003 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG

Re: Mass Storage Gadget Device Falls from SuperSpeed to High Speed

2019-04-02 Thread Rob Weber
Hi Felipe, On Tue, Apr 02, 2019 at 08:46:16AM +0300, Felipe Balbi wrote: > Felipe Balbi writes: > >>> modphy is the USB PHY integrated in your SoC. There's no control for > >>> that from OS side, only BIOS unfortunately. There is, however, one thing > >>> we can try. DWC3 has several quirk flags

Re: problem with Synopsys DesignWare Core SuperSpeed USB driver

2019-04-02 Thread Minas Harutyunyan
Hi, On 4/1/2019 9:01 PM, Felipe Balbi wrote: > > Hi, > > (I can't answer private queries. Please, always Cc the public mailing > list) > > Antonio Santagiuliana writes: > >> Hello >> I am using RaspberryPI for a project and we want to connect 16 USB to UART >> bridges ( at the moment we are u

Re: Mass Storage Gadget Device Falls from SuperSpeed to High Speed

2019-04-02 Thread Felipe Balbi
Hi Rob, Rob Weber writes: > On Tue, Apr 02, 2019 at 08:46:16AM +0300, Felipe Balbi wrote: >> Felipe Balbi writes: >> >>> modphy is the USB PHY integrated in your SoC. There's no control for >> >>> that from OS side, only BIOS unfortunately. There is, however, one thing >> >>> we can try. DWC3 h

[PATCH 2/2] USB: serial: pl2303: fix tranceiver suspend mode

2019-04-02 Thread Johan Hovold
Add helper function to update register bits instead of overwriting the entire control register when updating the flow-control settings. This specifically avoids having the tranceiver suspend mode (bit 0) depend on the flow control setting. The tranceiver is currently configured at probe to be dis

[PATCH 1/2] USB: serial: pl2303: fix non-supported xon/xoff

2019-04-02 Thread Johan Hovold
Older pl2303 devices do not support automatic xon/xoff flow control, so add add a flag to prevent trying to enable it for legacy device types. Refactor the IXON test into a helper function to improve readability. Fixes: 7041d9c3f01b ("USB: serial: pl2303: add support for tx xon/xoff flow control

[PATCH 0/2] USB: serial: pl2303: fix flow-control handling

2019-04-02 Thread Johan Hovold
These patches fix two issues with the current flow-control implementation. Tested using an HXD device. Johan Johan Hovold (2): USB: serial: pl2303: fix non-supported xon/xoff USB: serial: pl2303: fix tranceiver suspend mode drivers/usb/serial/pl2303.c | 58 +++-

Re: [PATCH 2/2] USB: serial: pl2303: fix tranceiver suspend mode

2019-04-02 Thread Johan Hovold
On Tue, Apr 02, 2019 at 10:19:31AM +0200, Johan Hovold wrote: > Add helper function to update register bits instead of overwriting the > entire control register when updating the flow-control settings. > > This specifically avoids having the tranceiver suspend mode (bit 0) > depend on the flow con

Why there is a refcnt check when we change configfs property

2019-04-02 Thread Peter Chen
Hi Felipe, Do you know why? In that case, I can't change property, eg changing qmult at NCM like below: mkdir functions/ncm.0 ln -s functions/ncm.0 configs/c.1 echo 10 > functions/ncm.0/qmult The code: drivers/usb/gadget/function/u_ether_configfs.h static ssize_t _f_##_opts_qmult_store(struct

Re: drivers: usb: serial: ftdi_sio.c error flagging

2019-04-02 Thread Johan Hovold
Hi, and sorry about the late reply. On Fri, Mar 08, 2019 at 09:43:35AM -0700, egaugesyst...@gmail.com wrote: > [Resend with From address corrected. Sorry about that] > > Johan, > > Some of our customers are experiencing communication issues on RS485 > that could be solved quite nicely by turni

Re: Why there is a refcnt check when we change configfs property

2019-04-02 Thread Felipe Balbi
Hi, Peter Chen writes: > Hi Felipe, > > Do you know why? In that case, I can't change property, eg changing qmult at > NCM > like below: > > mkdir functions/ncm.0 > ln -s functions/ncm.0 configs/c.1 > echo 10 > functions/ncm.0/qmult > > The code: > drivers/usb/gadget/function/u_ether_configfs.h

[PATCH 0/5] usb: dwc2: Improve gadget phy init

2019-04-02 Thread Jules Maselbas
Hi, Theses patches tries to clean a bit dwc2's phy initialization and fix an issue in gadget mode where the utmi phy width is set regardless of utmi being used or not. I believe that when using ulpi a phy width of 8 bits must be used, but this wasn't the case as the variable phyif was set by defa

[PATCH 2/5] usb: dwc2: Move phy init into core

2019-04-02 Thread Jules Maselbas
As the phy initialization is almost the same in host and gadget mode. This only move the phy initialization functions into core.c for now, the goal is to share theses functions between the two modes. Signed-off-by: Jules Maselbas --- drivers/usb/dwc2/core.c | 190

[PATCH 1/5] usb: dwc2: Move UTMI_PHY_DATA defines closer

2019-04-02 Thread Jules Maselbas
Makes GHWCFG4_UTMI_PHY_DATA* defines closer to their relative shift and mask defines to improve readability. Signed-off-by: Jules Maselbas --- drivers/usb/dwc2/hw.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc2/hw.h index 98af9

[PATCH 5/5] usb: dwc2: gadget: Move gadget phy init into core phy init

2019-04-02 Thread Jules Maselbas
Most of the phy initialization is shared between host and gadget, this adds the turnaround configuration only used by gadgets to the global phy init. Signed-off-by: Jules Maselbas --- drivers/usb/dwc2/core.c | 9 + drivers/usb/dwc2/gadget.c | 21 +++-- 2 files changed,

[PATCH 4/5] usb: dwc2: gadget: Replace phyif with phy_utmi_width

2019-04-02 Thread Jules Maselbas
The phy utmi width information is already set in hsotg params, phyif is only used in few places and I don't see any reason to not use hsotg's params. Moreover the utmi width was being forced to 16 bits by platform initialization which doesn't take in account HW configuration. Signed-off-by: Jules

[PATCH 3/5] usb: dwc2: gadget: Remove duplicated phy init

2019-04-02 Thread Jules Maselbas
The function dwc2_hsotg_init is only called once just before calling dwc2_hsotg_core_init_disconnected which does the same initialization: setting the usbcfg register with turnaround time, timeout calibration and phy width. Signed-off-by: Jules Maselbas --- drivers/usb/dwc2/gadget.c | 13 ---

Re: problem with Synopsys DesignWare Core SuperSpeed USB driver

2019-04-02 Thread Antonio Santagiuliana
Hello, sending again in plain text mode.. On Tue, Apr 2, 2019 at 11:37 AM Antonio Santagiuliana wrote: > > Hello, > thank you for the reply. > We transmit at 46800 bps from 16 devices to the UART side of the UART to USB > bridges ( at the moment cp2105 UART to USB bridges ) . > If we transmit f

Re: [PATCH 1/2] USB: serial: pl2303: fix non-supported xon/xoff

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 10:19:30AM +0200, Johan Hovold wrote: > Older pl2303 devices do not support automatic xon/xoff flow control, so > add add a flag to prevent trying to enable it for legacy device types. > > Refactor the IXON test into a helper function to improve readability. > > Fixes: 704

Re: [PATCH 2/2] USB: serial: pl2303: fix tranceiver suspend mode

2019-04-02 Thread Greg KH
On Tue, Apr 02, 2019 at 10:22:06AM +0200, Johan Hovold wrote: > On Tue, Apr 02, 2019 at 10:19:31AM +0200, Johan Hovold wrote: > > Add helper function to update register bits instead of overwriting the > > entire control register when updating the flow-control settings. > > > > This specifically av

Re: [PATCH] usb: typec: Registering real device entries for the muxes

2019-04-02 Thread Heikki Krogerus
On Mon, Apr 01, 2019 at 02:45:11PM +0200, Hans de Goede wrote: > HI, > > On 01-04-19 14:40, Heikki Krogerus wrote: > > On Mon, Apr 01, 2019 at 12:34:29PM +0200, Greg KH wrote: > > > On Mon, Apr 01, 2019 at 01:15:53PM +0300, Heikki Krogerus wrote: > > > > Registering real device entries (struct dev

Re: Problem with USB2 devices connected to a hub

2019-04-02 Thread Mathias Nyman
On 28.3.2019 15.41, Mathias Nyman wrote: The issue happens when only a single hub and a single device is connected to the USB subsystem. On my previous board, I had two USB dongles and two sound devices connected to the same hub and it worked without issues. So I guess it is not a real bandwidt

Re: [PATCH 2/5] usb: dwc2: Move phy init into core

2019-04-02 Thread kbuild test robot
Hi Jules, Thank you for the patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v5.1-rc3 next-20190402] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] USB:serial:pl2303:Add new PID to support PL2303HXN (TYPE_HXN)

2019-04-02 Thread Charles Yeh
Hi Johan, Thanks for you check the patch.. I will reply to you on the next Monday. Because I am currently on a business trip in China (3/28~4/6) Johan Hovold 於 2019年4月2日 週二 下午3:22寫道: > > On Wed, Feb 13, 2019 at 08:30:00PM +0800, Charles Yeh wrote: > > Prolific has developed a new USB