On Tue, Apr 02, 2019 at 10:19:31AM +0200, Johan Hovold wrote:
> Add helper function to update register bits instead of overwriting the
> entire control register when updating the flow-control settings.
> 
> This specifically avoids having the tranceiver suspend mode (bit 0)
> depend on the flow control setting.
> 
> The tranceiver is currently configured at probe to be disabled during
> suspend, but this was overridden when disabling flow control or enabling
> xon/xoff.
> 
> Fixes: 715f9527c1c1 ("USB: flow control fix for pl2303")
> Fixes: 7041d9c3f01b ("USB: serial: pl2303: add support for tx xon/xoff flow 
> control")
> Signed-off-by: Johan Hovold <jo...@kernel.org>
> ---
> @@ -176,7 +178,7 @@ static const struct pl2303_type_data 
> pl2303_type_data[TYPE_COUNT] = {
>       [TYPE_01] = {
>               .max_baud_rate          = 1228800,
>               .quirks                 = PL2303_QUIRK_LEGACY,
> -             .no_autoxonxoff         = 1,
> +             .no_autoxonxoff         = true,

This chunk was supposed to go in the first patch. I'll fix that up
before applying (or resending).

Johan

Reply via email to