Apple Display bound to hid-generic driver instead of appledisplay

2018-12-02 Thread Alexander Theißen
>> On 1 Dec 2018, at 13:06, Alexander Theißen wrote: >> >> Hi Mattias, >> >> I am writing you because you edited the drivers/usb/misc/appledisplay.c >> driver and I am hoping that you are a user of that driver. >> >> How do you use that driver? For me the hid driver always claims the device. >>

Re: tusb1210 probe of dwc3.0.auto.ulpi fails with EBUSY on 4.19+

2018-12-02 Thread Hans de Goede
Hi, On 01-12-18 13:22, Stephan Gerhold wrote: Hi, I have been updating my Intel Baytrail tablet from 4.14 to 4.19 and noticed that the tusb1210 PHY driver now fails to probe on 4.19.x and 4.20-rc4: tusb1210: probe of dwc3.0.auto.ulpi failed with error -16 (EBUSY) The commit that broke this

Re: tusb1210 probe of dwc3.0.auto.ulpi fails with EBUSY on 4.19+

2018-12-02 Thread Stephan Gerhold
Hi, thanks for the quick reply! :) On Sun, Dec 02, 2018 at 03:41:29PM +0100, Hans de Goede wrote: > Hi, > > On 01-12-18 13:22, Stephan Gerhold wrote: > > Hi, > > > > I have been updating my Intel Baytrail tablet from 4.14 to 4.19 and > > noticed that the tusb1210 PHY driver now fails to probe o

Re: Apple Display bound to hid-generic driver instead of appledisplay

2018-12-02 Thread 2...@mok.nu
On 2 Dec 2018, at 12:40, Alexander Theißen wrote: >>> On 1 Dec 2018, at 13:06, Alexander Theißen wrote: [...] >>> How do you use that driver? For me the hid driver always claims the device. >>> I have to manually bind the driver to the display to have it bound to the >>> appledisplay driver. Shou

Re: [PATCH v2] usb: chipidea: imx: Allow OC polarity active low

2018-12-02 Thread Uwe Kleine-König
On Fri, Nov 30, 2018 at 11:29:13PM +, Matthew Starr wrote: > The implementation for setting the over current polarity has always been > the over-current-active-high property. The problem with this is there > is no way to enable over current active low polarity since the default > state of the

[PATCH v2 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-02 Thread Uwe Kleine-König
The status quo on i.MX6 is that if "over-current-active-high" is specified in the device tree this is configured as expected. If the property is missing polarity isn't changed and so the polarity is kept as setup by the bootloader. Reset default is active high, so active low can only be used with h

[PATCH v2 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

2018-12-02 Thread Uwe Kleine-König
The polarity of the over current detection pin isn't configured on i.MX6/7 if it's unspecified in the device tree. So the actual configuration depends on bootloader behavior which is bad. So encourage users to fix their device tree by issuing a warning in this case. Signed-off-by: Uwe Kleine-Köni

[PATCH v2 3/3] usb: chipidea: imx: allow to configure oc polarity on i.MX25

2018-12-02 Thread Uwe Kleine-König
Up to now the polarity of the over current pin was hard coded to active high. Use the already defined device tree properties to configure polarity on i.MX25, too. In difference to i.MX6/7 use active high behavior if the polarity is unspecified to keep compatibility to existing device trees. Signed

[PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-02 Thread Tony Lindgren
On Motorola Mapphone devices such as Droid 4 there are five USB ports that do not use the same layout as Gobi 1K/2K/etc devices listed in qcserial.c. So we should use qcaux.c or option.c as noted by Dan Williams . The ff/ff/ff interfaces seem to always be UARTs on Motorola devices. And we should n

RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low

2018-12-02 Thread Jun Li
Hi Peter, > -Original Message- > From: Matthew Starr > Sent: 2018年11月30日 23:09 > To: PETER CHEN ; linux-usb@vger.kernel.org; Jun Li > > Subject: RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low > > > -Original Message- > > From: PETER CHEN [mailto:peter.c...@nxp.com]

RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low

2018-12-02 Thread PETER CHEN
> > > -Original Message- > > From: Matthew Starr > > Sent: 2018年11月30日 23:09 > > To: PETER CHEN ; linux-usb@vger.kernel.org; Jun Li > > > > Subject: RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low > > > > > -Original Message- > > > From: PETER CHEN [mailto:peter.c.

[PATCH 1/1] usb: chipidea: imx: improve the over current handling

2018-12-02 Thread PETER CHEN
The current OC (Over Current) handling does not consider the default and bootloader OC setting well, in this commit, we reset OC setting according to dts value: - If property "disable-over-current" is set, we will disable OC at code; otherwise, we will enable OC. - Since most of USB power control c

RE: [RFC PATCH v2 10/15] usb:cdns3: Ep0 operations part of the API

2018-12-02 Thread Pawel Laszczak
>> Patch implements related to default endpoint callback functions >> defined in usb_ep_ops object >> >> Signed-off-by: Pawel Laszczak >> --- >> drivers/usb/cdns3/ep0.c| 191 - >> drivers/usb/cdns3/gadget.c | 8 ++ >> drivers/usb/cdns3/gadget.h | 10 ++

RE: [RFC PATCH v2 11/15] usb:cdns3: Implements ISR functionality.

2018-12-02 Thread Pawel Laszczak
Hi, >> Patch adds set of generic functions used for handling interrupts >> generated by controller. Interrupt related functions are divided >> into three groups. The first is related to ep0 and is placed in ep0.c. >> The second is responsible for non-default endpoints and is >> implemented in gadg

RE: [RFC PATCH v2 11/15] usb:cdns3: Implements ISR functionality.

2018-12-02 Thread Pawel Laszczak
>Hi, > >>> Patch adds set of generic functions used for handling interrupts >>> generated by controller. Interrupt related functions are divided >>> into three groups. The first is related to ep0 and is placed in ep0.c. >>> The second is responsible for non-default endpoints and is >>> implemented

Re: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-02 Thread Alan Stern
On Sat, 1 Dec 2018, Anurag Kumar Vulisha wrote: > In some corner cases the gadget controller may get out of sync > with host and may get into hang state, thus creating a dealock. > For example when bulk streams are enabled for an endpoint, there > can be a condition where the gadget controller wai

RE: [RFC PATCH v2 12/15] usb:cdns3: Adds enumeration related function.

2018-12-02 Thread Pawel Laszczak
>On 18/11/18 12:09, Pawel Laszczak wrote: >> Patch implements a set of function related to enumeration process. >> Some standard requests are handled on controller driver level and >> other are delegated to gadget core driver. >> All class requests are delegated to gadget core driver. >> >> Signed-

RE: [RFC PATCH v2 02/15] usb:cdns3: Device side header file.

2018-12-02 Thread Pawel Laszczak
Hi Peter >> + >> +/* >> + * USBSS-DEV register interface. >> + * This corresponds to the USBSS Device Controller Interface */ >> +/** >> + * struct xhci_cap_regs - xHCI Host Controller Capability Registers. > >struct cdns3_usb_regs - device controller registers thanks, I had this from beginning

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-02 Thread Pawel Laszczak
>> >> Patch adds core.c and core.h file that implements initialization >> of platform driver and adds function responsible for selecting, >> switching and running appropriate Device/Host mode. >> >> Signed-off-by: Pawel Laszczak >> --- >> drivers/usb/cdns3/Makefile | 2 + >> drivers/usb/cdns3/c

[PATCHv2] phy: mapphone-mdm6600: Improve phy related runtime PM calls

2018-12-02 Thread Tony Lindgren
I noticed that phy_pm_runtime_get_sync() and phy_pm_runtime_put() are not currently doing anything for phy-mapphone-mdm6600, only the sysfs interface for works for "auto" and "on". This is because of the shared GPIO pins between mdm6600 USB port and n_gsm port. We have not enabled runtime PM for t

[PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon

2018-12-02 Thread Yu Chen
This driver handles usb phy power on and shutdown for hi3660 Soc of Hisilicon. Cc: Kishon Vijay Abraham I Cc: "David S. Miller" Cc: Greg Kroah-Hartman Cc: Mauro Carvalho Chehab Cc: Andrew Morton Cc: Arnd Bergmann Cc: Shawn Guo Cc: Pengcheng Li Cc: Jianguo Sun Cc: Masahiro Yamada Cc: Jian

[PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform

2018-12-02 Thread Yu Chen
This driver handles the poweron and shutdown of dwc3 core on Hisilicon Soc Platform. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: "David S. Miller" Cc: Mauro Carvalho Chehab Cc: Andrew Morton Cc: Arnd Bergmann Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- MAINTAINERS

[PATCH v1 08/12] usb: roles: Add usb role switch notifier.

2018-12-02 Thread Yu Chen
This patch adds notifier for drivers want to be informed of the usb role switch. Cc: Greg Kroah-Hartman Cc: Heikki Krogerus Cc: Hans de Goede Cc: Andy Shevchenko Cc: John Stultz Signed-off-by: Heikki Krogerus Signed-off-by: Yu Chen -- v0: The patch is provided by Heikki Krogerus. I modifie

[PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-02 Thread Yu Chen
This driver handles usb hub power on and typeC port event of HiKey960 board: 1)DP&DM switching between usb hub and typeC port base on typeC port state 2)Control power of usb hub on Hikey960 3)Control vbus of typeC port Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: John Stultz Cc: Binghui Wang C

[PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only

2018-12-02 Thread Yu Chen
Currently the "match_existing_only" of usb_gadget_driver in configfs is set to one which is not flexible. Dwc3 udc will be removed when usb core switch to host mode. This causes failure of writing name of dwc3 udc to configfs's UDC attribuite. To fix this we need to add a way to change the config o

[PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code.

2018-12-02 Thread Yu Chen
The Type-C drivers use USB role switch API to inform the system about the negotiated data role, so registering a role switch in the DRD code in order to support platforms with USB Type-C connectors. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Signed-off-by: Yu Chen Signed-off-by: Heikki Krogerus

[PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node

2018-12-02 Thread Yu Chen
This patch adds code for supporting find usb role switch by matching against the device node described using of_graph. Cc: Greg Kroah-Hartman Cc: Heikki Krogerus Cc: Hans de Goede Cc: Andy Shevchenko Cc: John Stultz Signed-off-by: Yu Chen --- drivers/usb/common/roles.c | 40

[PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960

2018-12-02 Thread Yu Chen
This patch adds support for usb on Hikey960. Cc: Wei Xu Cc: Rob Herring Cc: Mark Rutland Cc: linux-arm-ker...@lists.infradead.org Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 56 ++ arch/arm64/boot/dts/hisili

[PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin Soc Platform

2018-12-02 Thread Yu Chen
There are tow quirks for DesignWare USB3 DRD Core of Hisilicon Kirin Soc. 1)SPLIT_BOUNDARY_DISABLE should be set for Host mode 2)A GCTL soft reset should be executed when switch mode Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen --- drivers/u

[PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2018-12-02 Thread Yu Chen
This patch adds binding documentation to support usb hub and usb data role switch of Hisilicon HiKey&HiKey960 Board. Cc: Sergei Shtylyov Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen -- v1: 1) Fix some format errors as suggested by Sergei. 2) Modify

[PATCH v1 00/12] Add support for usb on Hikey960

2018-12-02 Thread Yu Chen
The patchset adds support for usb functionality of Hikey960, includes: - dwc3 driver for Hisilicon Kirin Soc hi3660 - usb driver for HiKey960 board - some adjustment in dwc3, usb gadget and typec driver - dts for support usb of HiKey960 Yu Chen (12): dt-bindings: usb: add support for dwc3 contro

[PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-02 Thread Yu Chen
This patch adds binding descriptions to support the dwc3 controller on HiSilicon SoCs and boards like the HiKey960. Cc: Greg Kroah-Hartman Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Signed-off-by: Yu Chen --- .../devicetree/bindings/usb/dwc3-hisi.txt | 67 +

[PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2018-12-02 Thread Yu Chen
This patch adds binding documentation for supporting the hi3660 usb phy on boards like the HiKey960. Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Cc: Binghui Wang Signed-off-by: Yu Chen -- v1: Fix some format error as suggested by Rob. -- --- .../devicetree/bindings/phy/phy-hi3660-usb3.t