Re: [PATCH] Improve the accuracy of the baud rate generator by using round-to-closest instead of truncating when calculating baud rate divisors.

2018-11-15 Thread Johan Hovold
On Tue, Nov 13, 2018 at 08:19:44PM +0100, Nikolaj Fogh wrote: > On 11/12/18 10:54 AM, Johan Hovold wrote: > > On Wed, Oct 31, 2018 at 09:16:48PM +0100, Nikolaj Fogh wrote: > >> I have experienced that the ftdi_sio driver gives less-than-optimal > >> baud rates as the driver truncates instead of rou

Re: [balbi-usb:testing/next 17/22] drivers/usb/dwc3/drd.c:604: undefined reference to `usb_role_switch_unregister'

2018-11-15 Thread Heikki Krogerus
On Thu, Nov 15, 2018 at 09:46:26AM +0200, Felipe Balbi wrote: > > Hi Heikki, > > kbuild test robot writes: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git > > testing/next > > head: bad6c1502dac79c80ad5a7149fa308849c0191dd > > commit: 24e2238d8c102f242ece57f45fbeb

Re: [balbi-usb:testing/next 17/22] drivers/usb/dwc3/drd.c:604: undefined reference to `usb_role_switch_unregister'

2018-11-15 Thread Felipe Balbi
Hi, Heikki Krogerus writes: > On Thu, Nov 15, 2018 at 09:46:26AM +0200, Felipe Balbi wrote: >> >> Hi Heikki, >> >> kbuild test robot writes: >> >> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git >> > testing/next >> > head: bad6c1502dac79c80ad5a7149fa308849c0191d

[PATCH 1/1] xhci: Prevent bus suspend if a port connect change or polling state is detected

2018-11-15 Thread Mathias Nyman
USB3 roothub might autosuspend before a plugged USB3 device is detected, causing USB3 device enumeration failure. USB3 devices don't show up as connected and enabled until USB3 link trainig completes. On a fast booting platform with a slow USB3 link training the link might reach the connected enab

[PATCH 0/1] xhci fix for usb-linus

2018-11-15 Thread Mathias Nyman
Hi Greg A case was found where USB3 devices fail to enumerate at boot. If a USB3 link is trained slowly then the roothub might autosuspend while device is just getting enabled. This patch fixes the issue -Mathias Mathias Nyman (1): xhci: Prevent bus suspend if a port connect change or polling

Re: [PATCH] Improve the accuracy of the baud rate generator by using round-to-closest instead of truncating when calculating baud rate divisors.

2018-11-15 Thread Johan Hovold
On Thu, Nov 15, 2018 at 09:24:49AM +0100, Johan Hovold wrote: > On Tue, Nov 13, 2018 at 08:19:44PM +0100, Nikolaj Fogh wrote: > > On 11/12/18 10:54 AM, Johan Hovold wrote: > > > On Wed, Oct 31, 2018 at 09:16:48PM +0100, Nikolaj Fogh wrote: > > >> I have experienced that the ftdi_sio driver gives le

Re: Query on usb/core/devio.c

2018-11-15 Thread Mayuresh Kulkarni
On Mon, 2018-11-12 at 15:36 +0100, Oliver Neukum wrote: > On Mo, 2018-11-12 at 12:04 +, Mayuresh Kulkarni wrote: > > > > I think I now understand the disconnect between us this point. Below is an > > attempt to bridge that, so please bear with me: > > 1. In our use-case(s), the end user can "i

[PATCH v2 3/3] usb: dwc3: drd: Add support for DR detection through extcon

2018-11-15 Thread Andy Shevchenko
Allow extcon device, found by name, to provide DR status for USB. This is needed, for example, in case of Intel Merrifield platform, where the Intel Basin Cove PMIC provides an extcon device to communicate the detected role. Note, that the "linux,extcon-name" property name is only for kernel inter

[PATCH v2 1/3] staging: typec: fusb302: Rename fcs,extcon-name to linux,extcon-name

2018-11-15 Thread Andy Shevchenko
Since we are going to use the same in Designware USB 3 driver, rename the property to be consistent across the drivers. No functional change intended. Signed-off-by: Andy Shevchenko Cc: Hans de Goede Cc: Guenter Roeck Acked-by: Hans de Goede Acked-by: Guenter Roeck --- drivers/platform/x86/

[PATCH v2 2/3] usb: dwc3: drd: Switch to device property for 'extcon' handling

2018-11-15 Thread Andy Shevchenko
Switch to device property for 'extcon' handling. No functional change intended. Signed-off-by: Andy Shevchenko Acked-by: Hans de Goede --- drivers/usb/dwc3/drd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c index 218371

Re: Query on usb/core/devio.c

2018-11-15 Thread Oliver Neukum
On Do, 2018-11-15 at 12:45 +, Mayuresh Kulkarni wrote: > > Understood this for remote-wake part. > > But still unclear about step (1) for host-wake as below (please note, I am > refering to host-wake and remote-wake as per my previous comment) - > Pre-condition: device in suspend and link in

[PATCH] usb: dwc3: don't print error message on probe defer

2018-11-15 Thread Lucas Stach
dwc3_core_init() is requesting the PHYs, which may probe later than the USB host controller. This is a normal system operation state and thus should not print an error message into the logs. Signed-off-by: Lucas Stach --- drivers/usb/dwc3/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [PATCH] Improve the accuracy of the baud rate generator by using round-to-closest instead of truncating when calculating baud rate divisors.

2018-11-15 Thread Nikolaj Fogh
On 11/15/18 9:24 AM, Johan Hovold wrote: On Tue, Nov 13, 2018 at 08:19:44PM +0100, Nikolaj Fogh wrote: On 11/12/18 10:54 AM, Johan Hovold wrote: On Wed, Oct 31, 2018 at 09:16:48PM +0100, Nikolaj Fogh wrote: I have experienced that the ftdi_sio driver gives less-than-optimal baud rates as the d

Re: [PATCH v2 1/3] staging: typec: fusb302: Rename fcs,extcon-name to linux,extcon-name

2018-11-15 Thread Heikki Krogerus
On Thu, Nov 15, 2018 at 03:16:19PM +0200, Andy Shevchenko wrote: > Since we are going to use the same in Designware USB 3 driver, > rename the property to be consistent across the drivers. > > No functional change intended. > > Signed-off-by: Andy Shevchenko > Cc: Hans de Goede > Cc: Guenter Ro

Re: Query on usb/core/devio.c

2018-11-15 Thread Alan Stern
On Thu, 15 Nov 2018, Oliver Neukum wrote: > On Do, 2018-11-15 at 12:45 +, Mayuresh Kulkarni wrote: > > > > Understood this for remote-wake part. > > > > But still unclear about step (1) for host-wake as below (please note, I am > > refering to host-wake and remote-wake as per my previous com

[PATCH v3 2/2] usb: dwc3: gadget: Report isoc transfer frame number

2018-11-15 Thread Thinh Nguyen
Implement the new frame_number API to report the isochronous interval frame number. This patch checks and reports the interval in which the isoc transfer was transmitted or received via the Isoc-First TRB SOF number field. Signed-off-by: Thinh Nguyen --- Change in v3: - Implement the change with

[PATCH v3 1/2] usb: gadget: Introduce frame_number to usb_request

2018-11-15 Thread Thinh Nguyen
Add a field frame_number to the usb_request to report the interval number in (micro)frames in which the isochronous transfer was transmitted or received. The gadget driver can use this knowledge to synchronize with the host. Also, this option is useful for debugging purposes. Signed-off-by: Thinh

Re: [PATCH v2 RESEND] usb: dwc3: core: Fix ULPI PHYs and prevent phy_get/ulpi_init during suspend/resume

2018-11-15 Thread Felipe Balbi
Hi, Todor Tomov writes: > Hello, > > After I apply this patch on 4.14 (or receive it with 4.14.70) I see a > regression with > the Qualcomm QUSB2 phy driver. I'm testing on a Dragonboard 820c. > In boot log I get: > > [4.525502] phy phy-7412000.phy.6: QUSB2PHY pll lock failed: status reg

[PATCH] usb: hub: add I/O error retry & reset routine

2018-11-15 Thread Nicolas Saenz Julienne
An URB submission error in the HUB's endpoint completion function renders the whole HUB device unresponsive. This patch introduces a routine that retries the submission for 1s to then, as a last resort, reset the whole device. The implementation is based on usbhid/hid_core.c's, which implements th

RE: SMSC95xx driver updates (round 1)

2018-11-15 Thread Woojung.Huh
Hi Ben, > -Original Message- > From: netdev-ow...@vger.kernel.org On Behalf > Of Ben Dooks > Sent: Wednesday, November 14, 2018 6:50 AM > To: net...@vger.kernel.org > Cc: oneu...@suse.com; da...@davemloft.net; linux-usb@vger.kernel.org; linux- > ker...@vger.kernel.org; steve.glendinn...@

Re: [PATCH] usb: hub: add I/O error retry & reset routine

2018-11-15 Thread Alan Stern
On Thu, 15 Nov 2018, Nicolas Saenz Julienne wrote: > An URB submission error in the HUB's endpoint completion function > renders the whole HUB device unresponsive. This patch introduces a > routine that retries the submission for 1s to then, as a last resort, > reset the whole device. > > The imp

[PATCH v3 0/2] Add Embedded USB Debugger (EUD) driver

2018-11-15 Thread Prakruthi Deepak Heragu
This is a series of patches that implements a driver for the control peripheral, EUD (Embedded USB Debugger). The EUD is a mini-USB hub implemented on chip to support the USB-based debug and trace capabilities. Apart from debug capabilities, EUD has a control peripheral. Control Peripheral is on

[PATCH v3 1/2] dt-bindings: Documentation for qcom,eud

2018-11-15 Thread Prakruthi Deepak Heragu
Documentation for Embedded USB Debugger (EUD) device tree bindings. Signed-off-by: Satya Durga Srinivasu Prabhala Signed-off-by: Prakruthi Deepak Heragu --- .../devicetree/bindings/soc/qcom/qcom,msm-eud.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Docum

[PATCH v3 2/2] Embedded USB Debugger (EUD) driver

2018-11-15 Thread Prakruthi Deepak Heragu
Add support for control peripheral of EUD (Embedded USB Debugger) to listen to events such as USB attach/detach, charger enable/disable, pet EUD to indicate software is functional. Reusing the platform device kobj, sysfs entry 'enable' is created to enable or disable EUD. Signed-off-by: Satya Durg

Re: [PATCH v3 2/2] Embedded USB Debugger (EUD) driver

2018-11-15 Thread Greg KH
On Thu, Nov 15, 2018 at 11:32:54AM -0800, Prakruthi Deepak Heragu wrote: > Add support for control peripheral of EUD (Embedded USB Debugger) to > listen to events such as USB attach/detach, charger enable/disable, pet > EUD to indicate software is functional. Reusing the platform device kobj, > sys

Re: [PATCH v3 2/2] Embedded USB Debugger (EUD) driver

2018-11-15 Thread Greg KH
On Thu, Nov 15, 2018 at 11:32:54AM -0800, Prakruthi Deepak Heragu wrote: > +struct device_attribute eud_attribute = { > + .attr.name = "enable", > + .attr.mode = 0644, > + .show = eud_enable_show, > + .store = eud_enable_store, > +}; Please use: static DEVICE_ATTR_RW(enable

[PATCH] USB: serial: mos7840: Add a product ID for the new product

2018-11-15 Thread JackyChou
From: JackyChou Add a new PID 0x7843 to the driver. Let the new products be able to set up 3 serial ports with the driver. Because the development of new product is based on 4 serial ports, but some users only need 3 serial ports. There is no way to set it from the hardware, so let the driver