Re: [PATCH v13 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-10-23 Thread Heikki Krogerus
Hi Ajay, I still have a few more comments below.. On Wed, Oct 03, 2018 at 11:27:28AM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. >

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-10-23 Thread Lars-Peter Clausen
On 09/25/2018 02:46 PM, Vincent Pelletier wrote: > Hello, > > On Thu, 2 Aug 2018 14:23:51 +, Vincent Pelletier > wrote: >> On Thu, 2 Aug 2018 00:45:14 +, "He, Bo" wrote: >>> Your patch fix the issue BUG: scheduling while atomic: >> >> Yes, although from my understanding of Felipe's ans

Re: usb typec not doing handling in-kernel

2018-10-23 Thread Heiko Stuebner
Hi, Am Mittwoch, 15. August 2018, 16:46:36 CEST schrieb Heikki Krogerus: > On Tue, Aug 14, 2018 at 03:58:31PM +0200, Heiko Stuebner wrote: > > Am Montag, 13. August 2018, 15:36:37 CEST schrieb Heikki Krogerus: > > > On Mon, Aug 13, 2018 at 12:36:55PM +0200, Heiko Stuebner wrote:ß > > > > I'm curre

Re: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers

2018-10-23 Thread Lars-Peter Clausen
On 06/29/2018 08:32 AM, Felipe Balbi wrote: > > Hi, > > Alan Stern writes: >> On Thu, 21 Jun 2018, Roger Quadros wrote: >> > Can we avoid the spin_lock() and the work-queue and call usb_ep_dequeue() > directly from here? >> What is the purpose of the spin_lock()? I agree t

[PATCH] HID: add driver for U2F Zero built-in LED and RNG

2018-10-23 Thread Andrej Shadura
U2F Zero supports custom commands for blinking the LED and getting data from the internal hardware RNG. Expose the blinking function as a LED device, and the internal hardware RNG as an HWRNG so that it can be used to feed the enthropy pool. Signed-off-by: Andrej Shadura --- drivers/hid/Kconfig

RE: [PATCH v13 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-10-23 Thread Ajay Gupta
Hi Heikki, > I still have a few more comments below.. Thanks for reviewing. > On Wed, Oct 03, 2018 at 11:27:28AM -0700, Ajay Gupta wrote: > > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller over I2C > > interface. > > > > This UCSI I2C driver uses I2C bus driver interface for comm

Re: Logitech G27 leds no more supported

2018-10-23 Thread Simon Wood
On Sun, October 21, 2018 10:43 am, elrond...@protonmail.com wrote: > SOLVED that's due to this is compiled as modules: > CONFIG_LEDS_SYSCON > CONFIG_LEDS_SYSCON > > > and not as YES option I'm not seeing the connection between this being a module and breaking (specifically) the Logitech driver. We

Re: usb typec not doing handling in-kernel

2018-10-23 Thread Heikki Krogerus
Hi guys, On Tue, Oct 23, 2018 at 03:49:03PM +0200, Heiko Stuebner wrote: > > True, the graph parsing is indeed missing from that API. I'll see if I > > can propose something for that at one point (soon hopefully). > > as I'm just sitting next to Guenter at ELCE talking about that type-c > stuff,

Re: [PATCH 1/2] usb: xhci: fix uninitialized completion when USB3 port got wrong status

2018-10-23 Thread Mathias Nyman
On 22.10.2018 20:53, Aaron Ma wrote: On 10/22/18 9:12 PM, Mathias Nyman wrote: On 21.10.2018 20:08, Aaron Ma wrote: Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3, after clear port reset it works fine. Since th

Re: [PATCH v2 1/2] usb: xhci: fix uninitialized completion when USB3 port got wrong status

2018-10-23 Thread Mathias Nyman
On 22.10.2018 20:42, Aaron Ma wrote: Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3, after clear port reset it works fine. Since this device is registered on USB3 roothub at boot, when port status reports not super

Re: [PATCH v2 2/2] usb: xhci: fix timeout for transition from RExit to U0

2018-10-23 Thread Mathias Nyman
On 22.10.2018 20:42, Aaron Ma wrote: This definition is used by msecs_to_jiffies in milliseconds. According to the comments, max rexit timeout should be 20ms. Align with the comments to properly calculate the delay. Verified on Sunrise Point-LP and Cannon Lake. Cc: sta...@vger.kernel.org Signed

[PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling

2018-10-23 Thread John Keeping
By clearing the overrun flag as soon as the target frame is next incremented, we can end up incrementing the target frame more than expected in dwc2_gadget_handle_ep_disabled() when the endpoint's interval is greater than 1. This happens if the target frame has just wrapped at the point when the e