On Sun, October 21, 2018 10:43 am, elrond...@protonmail.com wrote: > SOLVED that's due to this is compiled as modules: > CONFIG_LEDS_SYSCON > CONFIG_LEDS_SYSCON > > > and not as YES option
I'm not seeing the connection between this being a module and breaking (specifically) the Logitech driver. We're only checking 'CONFIG_LEDS_CLASS'. Did you have 'CONFIG_LEDS_CLASS' compiled as a module as well? I did a workaround for this in the SteelSeries driver... https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/hid-steelseries.c?h=v4.19#n20 -- #if IS_BUILTIN(CONFIG_LEDS_CLASS) || \ (IS_MODULE(CONFIG_LEDS_CLASS) && IS_MODULE(CONFIG_HID_STEELSERIES)) #define SRWS1_NUMBER_LEDS 15 struct steelseries_srws1_data { __u16 led_state; /* the last element is used for setting all leds simultaneously */ struct led_classdev *led[SRWS1_NUMBER_LEDS + 1]; }; #endif -- Cheers, Simon https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/Kconfig?h=v4.19 -- config LEDS_SYSCON bool "LED support for LEDs on system controllers" depends on LEDS_CLASS=y depends on MFD_SYSCON depends on OF help This option enables support for the LEDs on syscon type devices. This will only work with device tree enabled devices. -- https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/Kconfig?h=v4.19#n548 -- config LOGIWHEELS_FF bool "Logitech wheels configuration and force feedback support" depends on HID_LOGITECH select INPUT_FF_MEMLESS default LOGITECH_FF help Say Y here if you want to enable force feedback and range setting(*) support for following Logitech wheels: - Logitech G25 (*) - Logitech G27 (*) - Logitech G29 (*) - Logitech Driving Force - Logitech Driving Force Pro (*) - Logitech Driving Force GT (*) - Logitech Driving Force EX/RX - Logitech Driving Force Wireless - Logitech Speed Force Wireless - Logitech MOMO Force - Logitech MOMO Racing Force - Logitech Formula Force GP - Logitech Formula Force EX/RX - Logitech Wingman Formula Force GP -- https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/hid-lg4ff.c?h=v4.19#n1087 -- #ifdef CONFIG_LEDS_CLASS static void lg4ff_set_leds(struct hid_device *hid, u8 leds) { --
