Re: [PATCH 10/15] usb: dwc3: gadget: Set maxpacket size for ep0 IN

2018-01-09 Thread Felipe Balbi
Hi, Thinh Nguyen writes: > Hi, > > On 1/8/2018 4:06 AM, Felipe Balbi wrote: >> >> Hi, >> >> Thinh Nguyen writes: >>> There are 2 control endpoint structures for DWC3. However, the driver >>> only updates the OUT direction control endpoint structure during >>> ConnectDone event. DWC3 driver ne

Re: [PATCH 14/15] usb: dwc3: Add disabling of start_transfer failure quirk

2018-01-09 Thread Felipe Balbi
Hi, Rob Herring writes: > On Fri, Jan 05, 2018 at 12:16:02PM -0800, Thinh Nguyen wrote: >> In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc >> START TRANSFER command failure. However, some affected versions may have >> RTL patches to fix this without a SW workaround. Add

Re: [GIT PULL] USB: changes for v4.16 merge window

2018-01-09 Thread Felipe Balbi
Hi, Alan Stern writes: > On Mon, 8 Jan 2018, Felipe Balbi wrote: > >> >> Hi Greg, >> >> Here are my changes for this merge window. Let me know if you want >> anything to be changed. >> >> Patches have been on linux-next for quite a while ;-) >> >> cheers >> >> The following changes since co

Re: [PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: Add support for RZ/A1

2018-01-09 Thread Simon Horman
On Mon, Jan 08, 2018 at 07:30:54AM -0500, Chris Brandt wrote: > Document support for RZ/A1 SoCs > > Signed-off-by: Chris Brandt > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman > --- > v4: > * Re-added "renesas,usbhs-r7s72100" > v3: > * Removed "renesas,usbhs-r7s72100" > v2: > *

Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

2018-01-09 Thread Simon Horman
On Mon, Jan 08, 2018 at 01:15:08PM +0100, Geert Uytterhoeven wrote: > Hi Chris, > > On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt > wrote: > > On Monday, January 08, 2018, Geert Uytterhoeven wrote: > >> Thanks for the update, but I think there has been a misunderstanding. > >> I didn't mean to d

Re: [GIT PULL] USB: changes for v4.16 merge window

2018-01-09 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 10:47:02AM +0200, Felipe Balbi wrote: > > Hi, > > Alan Stern writes: > > On Mon, 8 Jan 2018, Felipe Balbi wrote: > > > >> > >> Hi Greg, > >> > >> Here are my changes for this merge window. Let me know if you want > >> anything to be changed. > >> > >> Patches have been

Re: [usb_add_gadget_udc_release] BUG: KASAN: double-free or invalid-free in (null)

2018-01-09 Thread Felipe Balbi
Hi, Alan Stern writes: > On Sun, 17 Dec 2017, Fengguang Wu wrote: > >> Hello, >> >> FYI this happens in mainline kernel 4.15.0-rc3. >> It looks like a new regression. >> >> It occurs in 23 out of 36 boots. >> >> [ 38.592360] LUN: removable file: (no medium) >> [ 38.593442] no file given f

[PATCH] usb: xhci: Clean up error code in xhci_dbc_tty_register_device()

2018-01-09 Thread Dan Carpenter
tty_port_register_device() returns error pointers on error, never NULL. The IS_ERR_OR_NULL() function returns either 1 or 0 so it means we return 1 on error instead of a proper error code. The caller only checks for zero vs non-zero so this doesn't affect runtime. Signed-off-by: Dan Carpenter d

Re: Help needed debugging Motorola Solutions TETRA PEI interface

2018-01-09 Thread Johan Hovold
On Mon, Jan 08, 2018 at 07:56:51PM +0100, Max Schulze wrote: > Thanks Johan for taking a look. > > > Am 08.01.2018 um 17:30 schrieb Johan Hovold: > > Adding the device ids and a quirk to cdc_acm.c > >>> .driver_info = NO_UNION_NORMAL, > >> does only suppress the "Zero length" message. > > Do you

Re: [PATCH V2 1/5] usb: serial: f81534: add high baud rate support

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:17AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates > can be up to 1.5Mbits with 24MHz. > > This device may generate data overrun when baud rate setting to 921600bps > or higher with old UART trigger lev

Re: [PATCH V2 2/5] usb: serial: f81534: add auto RTS direction support

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:18AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had auto RTS direction support for RS485 mode. > We'll read it from internal Flash with address 0x2f01~0x2f04 for 4 ports. > There are 4 conditions below: > 0: F81534_PORT_CONF_RS232. > 1: F81534_P

Re: [PATCH V2 3/5] usb: serial: f81534: add output pin control

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:19AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 3 output pin (M0/SD, M1, M2) with open-drain mode to > control transceiver. We'll read it from internal Flash with address > 0x2f05~0x2f08 for 4 ports. The value is range from 0 to 7. The M0/SD is > MSB of

Re: [PATCH V2 4/5] usb: serial: f81534: add H/W disable port support

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:20AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 can be disable port by manufacturer with > following H/W design. > 1: Connect DCD/DSR/CTS/RI pin to ground. > 2: Connect RX pin to ground. > > In driver, we'll implements some detect method likes foll

Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate

2018-01-09 Thread Johan Hovold
On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates > can be up to 1.5Mbits with 24MHz. But on some baud rate (384~500kps), the > TX side will send the data frame too close to treat frame error on RX > si

Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case.

2018-01-09 Thread Johan Hovold
On Tue, Jan 09, 2018 at 12:45:30AM +0300, Mikhail Zaytsev wrote: > On Mon, 8 Jan 2018 16:28:58 +0100 Johan Hovold wrote: > > > On Mon, Jan 08, 2018 at 11:33:32AM +0100, Oliver Neukum wrote: > > > Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev: > > > > The patch removes unused T

Re: [PATCH v2 2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case to function.

2018-01-09 Thread Johan Hovold
On Sat, Jan 06, 2018 at 08:15:22PM +0300, Mikhail Zaytsev wrote: > The patch moves TIOCGSERIAL ioctl case to get_serial_info function. > > Signed-off-by: Mikhail Zaytsev > static int ark3116_ioctl(struct tty_struct *tty, >unsigned int cmd, unsigned long arg) > { >

Re: [PATCH] usb: xhci: Clean up error code in xhci_dbc_tty_register_device()

2018-01-09 Thread Mathias Nyman
On 09.01.2018 11:41, Dan Carpenter wrote: tty_port_register_device() returns error pointers on error, never NULL. The IS_ERR_OR_NULL() function returns either 1 or 0 so it means we return 1 on error instead of a proper error code. The caller only checks for zero vs non-zero so this doesn't affec

Re: [PATCH] The usbmon triggers a BUG in ./include/linux/mm.h

2018-01-09 Thread Greg Kroah-Hartman
On Mon, Jan 08, 2018 at 03:46:41PM -0600, Pete Zaitcev wrote: > Automated tests triggered this by opening usbmon and accessing the > mmap while simultaneously resizing the buffers. This bug was with > us since 2006, because typically applications only size the buffers > once and thus avoid racing.

Re: [PATCH] USB: core: Fix misuse of USB_DT_USB_SSP_CAP_SIZE()

2018-01-09 Thread Greg KH
On Wed, Dec 20, 2017 at 03:14:09AM +0900, Masakazu Mokuno wrote: > As USB_DT_USB_SSP_CAP_SIZE() takes SSAC value as an argument, the low > bound of the size for struct usb_ssp_cap_descriptor should be described > by USB_DT_USB_SSP_CAP_SIZE(0), not by USB_DT_USB_SSP_CAP_SIZE(1) > > The type-specifi

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Geert Uytterhoeven
Hi Rafael, CC usb On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki wrote: > On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven > wrote: >> On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki >> wrote: >>> From: Rafael J. Wysocki >>> >>> One of the limitations of pm_runtime_force_suspend/res

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven wrote: > Hi Rafael, > > CC usb > > On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki wrote: >> On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven >> wrote: >>> On Wed, Jan 3, 2018 at 12:06 PM, Rafael J. Wysocki >>> wrote: From: Rafael J.

Re: [PATCH v2] PM / runtime: Rework pm_runtime_force_suspend/resume()

2018-01-09 Thread Rafael J. Wysocki
On Tuesday, January 9, 2018 5:03:18 PM CET Rafael J. Wysocki wrote: > On Tue, Jan 9, 2018 at 4:30 PM, Geert Uytterhoeven > wrote: > > Hi Rafael, > > > > CC usb > > > > On Tue, Jan 9, 2018 at 4:00 PM, Rafael J. Wysocki wrote: > >> On Tue, Jan 9, 2018 at 2:37 PM, Geert Uytterhoeven > >> wrote: >

Aw: Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Josef Griebichler
Hi Linus, your patch works very good for me and others (please see https://forum.libreelec.tv/thread/4235-dvb-issue-since-le-switched-to-kernel-4-9-x/?postID=77006#post77006). No errors in recordings any more. The patch was also tested on x86_64 (Revo 3700) with positive effect. I agree with the

Re: Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Eric Dumazet
On Tue, Jan 9, 2018 at 8:51 AM, Josef Griebichler wrote: > Hi Linus, > > your patch works very good for me and others (please see > https://forum.libreelec.tv/thread/4235-dvb-issue-since-le-switched-to-kernel-4-9-x/?postID=77006#post77006). > No errors in recordings any more. > The patch was als

Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Mauro Carvalho Chehab
Em Mon, 8 Jan 2018 11:51:04 -0800 Linus Torvalds escreveu: > On Mon, Jan 8, 2018 at 11:15 AM, Alan Stern wrote: > > > > Both dwc2_hsotg and ehci-hcd use the tasklets embedded in the > > giveback_urb_bh member of struct usb_hcd. See usb_hcd_giveback_urb() > > in drivers/usb/core/hcd.c; the calls

Re: [PATCH V2] USBIP: return correct port ENABLE status

2018-01-09 Thread Shuah Khan
On 12/18/2017 11:00 PM, pei.zh...@intel.com wrote: > From: Pei Zhang > > USB system will clear port's ENABLE feature for some USB devices when > vdev is already assigned port address. This cause getPortStatus reports > to system that this device is not enabled, client OS will failed to use > this

Re: Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Linus Torvalds
On Tue, Jan 9, 2018 at 9:27 AM, Eric Dumazet wrote: > > So yes, commit 4cd13c21b207 ("softirq: Let ksoftirqd do its job") has > shown up multiple times in various 'regressions' > simply because it could surface the problem more often. > But even if you revert it, you can still make the faulty > dr

Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Linus Torvalds
On Tue, Jan 9, 2018 at 9:42 AM, Mauro Carvalho Chehab wrote: > > On my preliminar tests, writing to a file on an ext4 partition at a > USB stick loses data up to the point to make it useless (1/4 of the data > is lost!). However, writing to a class 10 microSD card is doable. Note that most USB st

Re: Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Eric Dumazet
On Tue, Jan 9, 2018 at 9:48 AM, Linus Torvalds wrote: > On Tue, Jan 9, 2018 at 9:27 AM, Eric Dumazet wrote: >> >> So yes, commit 4cd13c21b207 ("softirq: Let ksoftirqd do its job") has >> shown up multiple times in various 'regressions' >> simply because it could surface the problem more often. >>

Re: Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Linus Torvalds
On Tue, Jan 9, 2018 at 9:57 AM, Eric Dumazet wrote: > > Your patch considers TASKLET_SOFTIRQ being a candidate for 'immediate > handling', but TCP Small queues heavily use TASKLET, > so as far as I am concerned a revert would have the same effect. Does it actually? TCP ends up dropping packets o

[PATCH] Documentation: usb: fix typo in UVC gadgetfs config command

2018-01-09 Thread Bin Liu
This seems to be a copy&paste error. With the fix the uvc gadget now can be created by following the instrucitons. Signed-off-by: Bin Liu --- Documentation/usb/gadget-testing.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/usb/gadget-testing.txt b/Documenta

[PATCH] usb: dwc2: Fix endless deferral probe

2018-01-09 Thread Stefan Wahren
The dwc2 USB driver tries to find a generic PHY first and then look for an old style USB PHY. In case of a valid generic PHY node without a PHY driver, the PHY layer will return -EPROBE_DEFER forever. So dwc2 will never tries for an USB PHY. Fix this issue by finding a generic PHY and an old style

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2018-01-09 Thread Stefan Wahren
Hi Razmik, > Razmik Karapetyan hat am 8. Januar 2018 um > 13:40 geschrieben: > > > On 12/31/2017 9:19 PM, Stefan Wahren wrote: > > Hi Stefan, > > >> > >> Razmik Karapetyan (10): > >>usb: dwc2: Set AHB burst size to INCR > > > > The usage hsotg->params.ahbcfg instead of the defines is a

Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Jesper Dangaard Brouer
On Tue, 9 Jan 2018 15:42:35 -0200 Mauro Carvalho Chehab wrote: > Em Mon, 8 Jan 2018 11:51:04 -0800 Linus Torvalds > escreveu: > [...] > Patch makes sense to me, although I was not able to test it myself. The patch also make sense to me. I've done some basic testing with it on my high-end B

Re: [PATCH] usb: dwc2: Fix endless deferral probe

2018-01-09 Thread Arnd Bergmann
On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren wrote: > The dwc2 USB driver tries to find a generic PHY first and then look > for an old style USB PHY. In case of a valid generic PHY node without > a PHY driver, the PHY layer will return -EPROBE_DEFER forever. So dwc2 > will never tries for an USB

Error messages on USB 3.0 device removal: bug or feature?

2018-01-09 Thread Holger Hoffstätte
Hi, I recently started to use an USB 3.0 card to plug in an external drive (using 4.14.x). So xhci does its thing and everything works fine, but I get curious error messages after unmounting & removing a device, which don't appear when unplugging something from my internal USB2 port: [Jan 9 10:4

Re: Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Eric Dumazet
On Tue, Jan 9, 2018 at 10:58 AM, Linus Torvalds wrote: > On Tue, Jan 9, 2018 at 9:57 AM, Eric Dumazet wrote: >> >> Your patch considers TASKLET_SOFTIRQ being a candidate for 'immediate >> handling', but TCP Small queues heavily use TASKLET, >> so as far as I am concerned a revert would have the s

Re: [PATCH 08/15] usb: dwc3: Make RX/TX threshold configurable

2018-01-09 Thread Thinh Nguyen
Hi, On 1/8/2018 8:12 PM, Rob Herring wrote: > On Fri, Jan 05, 2018 at 12:14:48PM -0800, Thinh Nguyen wrote: >> DWC_usb31 periodic transfer at 48K+ bytes per interval may need >> modification to the TX/RX packet threshold to achieve optimal result. >> Add properties to make it configurable. > > I

[GIT PULL] usb: chipidea: updates for v4.16-rc1

2018-01-09 Thread Peter Chen
The following changes since commit 16e791e7659645e6d8ea6286d210a24ee473d6c2: doc: usb: chipidea: Fix typo in 'enumerate' (2017-12-08 17:43:53 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/ tags/usb-ci-v4.16-rc1 for you to fe

Attn: Email Owner,

2018-01-09 Thread IMF/WORLDBANK AUDITORS
IMF/World Bank Auditors Instructed Western Union to Release Your Sum of $1.5Million dollars, Email lottery Awards Held in Russia fortnight ago for the oncoming World Cup, 2018,So Kindly Contact Western Union Director Harry Morris: +22998220265, Email (emaillottoryfi...@gmail.com) with your Per

Re: dvb usb issues since kernel 4.9

2018-01-09 Thread Mike Galbraith
On Tue, 2018-01-09 at 22:26 +0100, Jesper Dangaard Brouer wrote: > > I've previously experienced that you can be affected by the scheduler > granularity, which is adjustable (with CONFIG_SCHED_DEBUG=y): > > $ grep -H . /proc/sys/kernel/sched_*_granularity_ns > /proc/sys/kernel/sched_min_granula

[PATCH 1/2] usb: xhci: Remove ep_trb from xhci_cleanup_halted_endpoint()

2018-01-09 Thread Lu Baolu
Function argument ep_trb for xhci_cleanup_halted_endpoint() isn't needed anymore. Cleanup it. Signed-off-by: Lu Baolu --- drivers/usb/host/xhci-ring.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

[PATCH 2/2] usb: xhci: Remove ep_trb from finish_td()

2018-01-09 Thread Lu Baolu
Function argument ep_trb for finish_td() isn't needed anymore. Cleanup it. Signed-off-by: Lu Baolu --- drivers/usb/host/xhci-ring.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 642a070..88071c4 10064

Re: [PATCH V2 1/5] usb: serial: f81534: add high baud rate support

2018-01-09 Thread Ji-Ze Hong (Peter Hong)
Hi Johan, Johan Hovold 於 2018/1/9 下午 07:08 寫道: On Thu, Jan 04, 2018 at 10:29:17AM +0800, Ji-Ze Hong (Peter Hong) wrote: The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates can be up to 1.5Mbits with 24MHz. This device may generate data overrun when baud rate setting to 9216

Re: [PATCH V2 5/5] usb: serial: f81534: fix tx error on some baud rate

2018-01-09 Thread Ji-Ze Hong (Peter Hong)
Hi Johan, Johan Hovold 於 2018/1/9 下午 07:32 寫道: On Thu, Jan 04, 2018 at 10:29:21AM +0800, Ji-Ze Hong (Peter Hong) wrote: + /* +* We'll make tx frame error when baud rate from 384~500kps. So we'll +* delay all tx data frame with 1bit. +*/ + port_priv->shadow_cl

[PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-09 Thread ShuFanLee
From: ShuFanLee Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Signed-off-by: ShuFanLee --- .../devicetree/bindings/usb/richtek,rt1711h.txt| 38 + arch/arm64/boot/dts/hisilicon/rt1711h.dtsi | 1

[PATCH] uas: Unblock scsi-requests on failure to alloc streams in post_reset

2018-01-09 Thread Hans de Goede
If we return 1 from our post_reset handler, then our disconnect handler will be called immediately afterwards. Since pre_reset blocks all scsi requests our disconnect handler will then hang in the scsi_remove_host call. This is esp. bad because our disconnect handler hanging for ever also stops th

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2018-01-09 Thread Razmik Karapetyan
On 1/9/2018 11:56 PM, Stefan Wahren wrote: Hi Stefan, > Hi Razmik, > >> Razmik Karapetyan hat am 8. Januar 2018 um >> 13:40 geschrieben: >> >> >> On 12/31/2017 9:19 PM, Stefan Wahren wrote: >> >> Hi Stefan, >> Razmik Karapetyan (10): usb: dwc2: Set AHB burst size to INCR >>>