Re: [PATCH v3] USB: Force disconnect Huawei 4G modem during suspend

2017-10-24 Thread Oliver Neukum
Am Dienstag, den 24.10.2017, 12:16 +0800 schrieb Daniel Drake: > Hi Oliver, > > On Wed, Oct 18, 2017 at 5:31 PM, Oliver Neukum wrote: > > > > Am Mittwoch, den 18.10.2017, 15:15 +0800 schrieb Daniel Drake: > > > > > > Notes: > > > v2: > > > - Handle quirk later in suspend, to avoid inter

Re: [PATCH] rndis_host: support Novatel Verizon USB730L — Linux USB

2017-10-24 Thread Oliver Neukum
Am Dienstag, den 24.10.2017, 00:56 +0300 schrieb Gal Shalif: > The following was used to switch the Novatel USB730L from user mode > (product ID 0x9030) into enterprise mode (product ID 0x9032): > * Tested with Linux kernel 3.14.15 on a 32bit ARM machine (kernel is > compiled without IPV6) and with

Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

2017-10-24 Thread Felipe Balbi
Hi, Yu Chen writes: > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 > Controller. > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on > board Hikey960. > > Signed-off-by: Yu Chen > Signed-off-by: Ning Fan > Signed-off-by: Di Yang > Signed-o

Re: [PATCH 2/3 v2] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

2017-10-24 Thread Minas Harutyunyan
On 10/24/2017 1:33 AM, John Stultz wrote: > We've found that while in host mode, using Android, if one runs > the command: >stop adbd > > The existing usb devices being utilized in host mode are disconnected. > This is most visible with usb networking devices. > > This seems to be due to adbd

Re: [PATCH 3/3 v2] usb: dwc2: Fix UDC state tracking

2017-10-24 Thread Minas Harutyunyan
On 10/24/2017 1:33 AM, John Stultz wrote: > It has been noticed that the dwc2 udc state reporting doesn't > seem to work (at least on HiKey boards). Where after the initial > setup, the sysfs /sys/class/udc/f72c.usb/state file would > report "configured" no matter the state of the OTG port. >

[PATCH RFC] usb: chipidea: imx: make over-current polarity configurable for i.MX25

2017-10-24 Thread Uwe Kleine-König
In commit 9dba516ed282 ("usb: chipidea: imx: set over current polarity per dts setting") i.MX6 and i.MX7 learned the dt property "over-current-active-high". The difference compared to i.MX25 is that on the latter the default in hardware and the driver is already active-high. For that reason the ove

Re: [PATCH 1/3 v2] usb: dwc2: Improve gadget state disconnection handling

2017-10-24 Thread Minas Harutyunyan
On 10/24/2017 1:33 AM, John Stultz wrote: > In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we > disconnect the gadget state"), I was trying to fix up the > fact that we somehow weren't disconnecting the gadget state, > so that when the OTG port was plugged in the second time we > would g

Re: [PATCH] drivers/net/usb: add device id for TP-LINK UE300 USB 3.0 Ethernet

2017-10-24 Thread David Miller
From: Ran Wang Date: Mon, 23 Oct 2017 18:10:23 +0800 > This product is named 'TP-LINK USB 3.0 Gigabit Ethernet Network > Adapter (Model No.is UE300)'. It uses chip RTL8153 and works with > driver drivers/net/usb/r8152.c > > Signed-off-by: Ran Wang Applied. -- To unsubscribe from this list: sen

Re: [PATCH] cdc_ether: flag the Huawei ME906/ME909 as WWAN

2017-10-24 Thread David Miller
From: Aleksander Morgado Date: Mon, 23 Oct 2017 17:16:41 +0200 > The Huawei ME906 (12d1:15c1) comes with a standard ECM interface that > requires management via AT commands sent over one of the control TTYs > (e.g. connected with AT^NDISDUP). > > Signed-off-by: Aleksander Morgado Applied. -- T

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

2017-10-24 Thread Felipe Balbi
Hi, Manu Gautam writes: > Hi Felipe, > > Let me know if patches in this series look fine to you. It does, I just don't have means to test this as intel's platform doesn't give SW access to PHYs. I was hoping someone from TI would give a tested-by, but it's too late. We'll just take this series

Re: [PATCH 25/25] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2017-10-24 Thread Felipe Balbi
Anna-Maria Gleixner writes: > From: Thomas Gleixner > > The tx_tasklet tasklet is used in invoke the hrtimer (task_timer) in > softirq context. This can be also achieved without the tasklet but with > CLOCK_MONOTONIC_SOFT as hrtimer base. > > Signed-off-by: Thomas Gleixner > Signed-off-by: Anna

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-24 Thread Minas Harutyunyan
On 10/24/2017 12:41 AM, John Stultz wrote: > On Mon, Oct 23, 2017 at 2:19 AM, Minas Harutyunyan > wrote: >> Could you please verify on your setup follow patches: >> 1. Vardan's patch. >> 2. Patch for TOUTCAL&USBTRDTIM programming (new version see below). >> 4. Your patch 2/3 to avoid "Mode Mismatc

[PATCH v3] arm64: dts: ls1088a: Add USB support

2017-10-24 Thread yinbo.zhu
From: "yinbo.zhu" Fix the issue that usb is not detected on ls1088ardb Signed-off-by: yinbo.zhu Signed-off-by: Ran Wang --- Change in v3: - Change status from "enable" to "disabled" then enable it on dts file. - Add the version history. arch/arm64/boot/dts/

[PATCH] usb: gadget: zero: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Adds a static tracking variable to match the timer global. Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: lin

[PATCH] usb: isp1760: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman Cc: "Gustavo A. R. Silva" Cc: Bhumika Goyal Cc: linux-usb@vger.kernel.org Signed-o

[PATCH] usb: musb: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Instead of a per-device static timer variable, a spare timer "dev_timer" is added to the musb structure for

[PATCH] usb: usbtest: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Also adds missing call to destroy_timer_on_stack(); Cc: Greg Kroah-Hartman Cc: Felipe Balbi Cc: Alan Stern

[PATCH] usb: r8a66597-hcd: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This rearranges the arrays of timers to minimize the need for a pointer back to the main structure. Cc: Greg

[PATCH] usb: usbatm: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Additionally corrects and on-stack timer usage. Cc: Greg Kroah-Hartman Cc: Duncan Sands Cc: Allen Pais Cc

[PATCH] usb: dwc2: host: Setting TOUTCAL and USBTRDTIM fields in host mode

2017-10-24 Thread Minas Harutyunyan
Added missing GUSBCFG programming in host mode. These fields even if was programmed in device mode (in function dwc2_hsotg_core_init_disconnected()) will be resetting to POR values after core soft reset applied. So, each time when switching to host mode required to set these fields to correct valu

[PATCH] usb: usbip: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Valentina Manea Cc: Shuah Khan Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Ke

[PATCH] usb: chipidea: fix trivial typo in Kconfig

2017-10-24 Thread Christoph Fritz
This patch fixes a trivial typo to get the module name ci_hdrc.ko correct. Signed-off-by: Christoph Fritz --- drivers/usb/chipidea/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig index 51f4157..785f0ed 100644

[GIT PULL] USB for v4.15 merge window

2017-10-24 Thread Felipe Balbi
Hi Greg, here's my pull request for v4.15 merge window. Let me know if you want anything to be changed. Cheers The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: git://git.kernel.

Re: [PATCH] usb: usbtest: Convert timers to use timer_setup()

2017-10-24 Thread Felipe Balbi
Kees Cook writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Also adds missing call to > destroy_timer_on_stack(); > > Cc: Greg Kroah-Hartman >

Re: [PATCH] usb: gadget: zero: Convert timers to use timer_setup()

2017-10-24 Thread Felipe Balbi
Kees Cook writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Adds a static tracking variable to > match the timer global. > > Cc: Felipe Balbi

Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

2017-10-24 Thread Philippe Ombredanne
Rob: On Sat, Oct 21, 2017 at 9:48 AM, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 10:26:22AM -0500, Rob Herring wrote: >> On Thu, Oct 19, 2017 at 3:38 AM, Greg Kroah-Hartman >> wrote: >> > It's good to have SPDX identifiers in all files to make it easier to >> > audit the kernel tree for

Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

2017-10-24 Thread Chen Yu
Hi, Felipe On 2017/10/24 16:25, Felipe Balbi wrote: > Hi, > > Yu Chen writes: >> > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 >> > Controller. >> > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub >> > on board Hikey960. >> > >> > Signed-of

[balbi-usb:testing/next 46/52] drivers/usb/phy/phy-tahvo.c:433:9: warning: 'ret' may be used uninitialized in this function

2017-10-24 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: f463883ae099b7e98e8ea0a6b9c8dbd05217d94a commit: 649e479cc765d18030b885796e8ee160b7247d40 [46/52] usb: phy: tahvo: fix error handling in tahvo_usb_probe() config: x86_64-randconfig-x018-201743 (attached as

[balbi-usb:testing/next 45/52] drivers/usb/gadget/function/f_ncm.c:1109:10: error: 'HRTIMER_MODE_REL_SOFT' undeclared

2017-10-24 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: f463883ae099b7e98e8ea0a6b9c8dbd05217d94a commit: 4e4a058b2f048b009b7826e6404ec5133563417e [45/52] usb/gadget/NCM: Replace tasklet with softirq hrtimer config: x86_64-randconfig-x014-201743 (attached as .con

Re: [GIT PULL] USB for v4.15 merge window

2017-10-24 Thread Greg Kroah-Hartman
On Tue, Oct 24, 2017 at 01:20:34PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my pull request for v4.15 merge window. Let me know if you want > anything to be changed. > > Cheers > > The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: > > Linux 4.14-rc4 (2017

RE: [PATCH] usb: gadget: goku_udc: mark expected switch fall-throughs

2017-10-24 Thread David Laight
From: Gustavo A. R. Silva > Sent: 24 October 2017 04:46 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 145713 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/gadget/udc/goku_udc.c | 14 +

usb/net/asix: kernel hang in asix_phy_reset

2017-10-24 Thread Andrey Konovalov
Hi! While fuzzing the kernel with syzkaller I've been getting kernel hangs within the asix driver. On commit 6cff0a118f23b98c604a3604ea9de11338e24fbe (4.14-rc6+). As far as I can tell the issue is that asix_phy_reset() doesn't enforce proper timeout. asix_phy_reset() calls asix_mdio_read() in a

[PATCH] mmc: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Ludovic Desroches Cc: Ulf Hansson Cc: Jaehoon Chung Cc: Carlo Caione Cc: Kevin Hilman Cc: Nicolas P

Re: usb/net/asix: kernel hang in asix_phy_reset

2017-10-24 Thread Andrey Konovalov
On Tue, Oct 24, 2017 at 4:59 PM, Andrey Konovalov wrote: > Hi! > > While fuzzing the kernel with syzkaller I've been getting kernel hangs > within the asix driver. > > On commit 6cff0a118f23b98c604a3604ea9de11338e24fbe (4.14-rc6+). > > As far as I can tell the issue is that asix_phy_reset() doesn'

[usb:usb-testing 54/61] drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used

2017-10-24 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing head: 2d5afd51fe6b469e09d8d63fff041cbf4a987278 commit: b6bb72cf0df128397312b6239d6c5f5702dfc6fc [54/61] usb: xhci-mtk: add optional mcu and dma bus clocks coccinelle warnings: (new ones prefixed by >>) >> driv

[PATCH] usb: xhci-mtk: fix ptr_ret.cocci warnings

2017-10-24 Thread kbuild test robot
drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: b6bb72cf0df1 ("usb: xhci-mtk: add optional mcu and dma bus clocks") CC: Chunfeng Yun Signed-off-by: Fen

[PATCH] usb: storage: uas: mark expected switch fall-through

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 115016 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/storage/uas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/

[PATCH] usb: serial: kobil_sct: mark expected switch fall-through

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 115014 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/serial/kobil_sct.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/kobil_sct.c b/dr

[PATCH] drivers/hid: Convert timers to use timer_setup()

2017-10-24 Thread Allen Pais
Switch to using the new timer_setup() and from_timer() for drivers/hid/* Cc: Kees Cook Signed-off-by: Allen Pais --- Note: This patch is only compile tested. drivers/hid/hid-appleir.c | 8 drivers/hid/hid-multitouch.c | 6 +++--- drivers/hid/hid-prodikeys.c| 7 +++ dri

Re: [PATCH] drivers/hid: Convert timers to use timer_setup()

2017-10-24 Thread Allen
Switch to using the new timer_setup() and from_timer() for drivers/hid/* Cc: Kees Cook Signed-off-by: Allen Pais Ignore the patch. I send out a wrong one by mistake. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel

[PATCH] drivers/hid: Convert timers to use timer_setup()

2017-10-24 Thread Allen Pais
Switch to using the new timer_setup() and from_timer() for drivers/hid/* Cc: Kees Cook Signed-off-by: Allen Pais --- Note:This patch is only compile tested. drivers/hid/hid-appleir.c | 8 drivers/hid/hid-prodikeys.c| 7 +++ drivers/hid/hid-wiimote-core.c | 6 +++--- driv

Re: [PATCH] drivers/hid: Convert timers to use timer_setup()

2017-10-24 Thread Kees Cook
On Tue, Oct 24, 2017 at 10:55 AM, Allen Pais wrote: > Switch to using the new timer_setup() and from_timer() > for drivers/hid/* > > Cc: Kees Cook > Signed-off-by: Allen Pais Yup, this matches what I'd expect for timer_setup() conversion in these files, thanks! -Kees -- Kees Cook Pixel Secur

[PATCH] usb: gadget: f_phonet: mark expected switch fall-throughs

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 115004 Addresses-Coverity-ID: 115005 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/function/f_phonet.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH] usb: host: isp116x-hcd: mark expected switch fall-throughs

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 115006 Addresses-Coverity-ID: 115007 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/host/isp116x-hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dr

Re: [PATCH] rndis_host: support Novatel Verizon USB730L — Linux USB

2017-10-24 Thread Gal Shalif
The option driver is compiled as a module. The option driver patch, and other related patches are listed within my previous email: > On 24/10/17 00:56, Gal Shalif wrote: The following was used to switch the Novatel USB730L from user mode (product ID 0x9030) into enterprise mode (product ID 0x903

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-24 Thread Uwe Kleine-König
Hello, On Sun, Oct 22, 2017 at 09:03:34PM -0400, Alan Stern wrote: > On Sun, 22 Oct 2017, Uwe [iso-8859-1] Kleine-K?nig wrote: > > On Sat, Oct 21, 2017 at 11:08:39AM -0400, Alan Stern wrote: > > > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-K?nig wrote: > > > > On Fri, Oct 20, 2017 at 03:47:37PM

Re: [PATCH v3] arm64: dts: ls1088a: Add USB support

2017-10-24 Thread Yang Li
On Tue, Oct 24, 2017 at 4:31 AM, wrote: > From: "yinbo.zhu" > > Fix the issue that usb is not detected on ls1088ardb You can only fix issue for a function after the function has been added previously. So like Shawn commented, this patch is about adding the USB support instead of fixing an issu

Re: [PATCH] usb: xhci-mtk: fix ptr_ret.cocci warnings

2017-10-24 Thread Chunfeng Yun
On Wed, 2017-10-25 at 00:33 +0800, kbuild test robot wrote: > drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes: b6bb72cf0df1 ("usb: xhci-mtk

[PATCH] usb: atm: cxacru: mark expected switch fall-throughs

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/atm/cxacru.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 600a670..e4

[PATCH] usb: class: usbtmc: mark expected switch fall-through

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/class/usbtmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 6ebfabf

Re: [PATCH] usb: usbatm: Convert timers to use timer_setup()

2017-10-24 Thread Allen
> In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Additionally corrects and on-stack > timer usage. > > Cc: Greg Kroah-Hartman > Cc: Duncan Sands > Cc: