[PATCH 1/1] sisusb_con: fix coccinelle warning

2017-05-12 Thread Jiri Slaby
After commit d705ff3818 (tty: vt, cleanup and document con_scroll), in the coccinelle output, we can see: drivers/usb/misc/sisusbvga/sisusb_con.c:852:8-9: WARNING: return of 0/1 in function 'sisusbcon_scroll_area' with return type bool Return true instead of 1 in the function returning bool which

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

2017-05-12 Thread Kishon Vijay Abraham I
Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by: Vivek

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2017-05-12 Thread Maxime Ripard
Hi, On Thu, May 11, 2017 at 02:45:11PM -0700, Bim Overbohm wrote: > Hi All, > > I had a similar problem running a mainline 4.11 kernel on an A33 tablet > (marked "Q8-2.4G 20140918". It came from a company called Trimeo and is > simply called 7". It contains an APX223 power controller, RTL8189ET

Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers

2017-05-12 Thread Vivek Gautam
On 05/12/2017 02:15 PM, Kishon Vijay Abraham I wrote: Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: Adding vendor specific directories in phy to group phy drivers under their respective vendor umbrella. Also updated the MAINTAINERS file to reflect the correct directory stru

[PATCH] mmc: vub3000: add missing USB-descriptor endianness conversions

2017-05-12 Thread Johan Hovold
Add the missing endianness conversions when printing the USB device-descriptor idVendor and idProduct fields during probe. Signed-off-by: Johan Hovold --- drivers/mmc/host/vub300.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/

[PATCH] uwb: fix device quirk on big-endian hosts

2017-05-12 Thread Johan Hovold
Add missing endianness conversion when using the USB device-descriptor idProduct field to apply a hardware quirk. Fixes: 1ba47da52712 ("uwb: add the i1480 DFU driver") Cc: stable # 2.6.28 Signed-off-by: Johan Hovold --- drivers/uwb/i1480/dfu/usb.c | 5 +++-- 1 file changed, 3 insertions(+),

[PATCH] net: ch9200: add missing USB-descriptor endianness conversions

2017-05-12 Thread Johan Hovold
Add the missing endianness conversions to a debug statement printing the USB device-descriptor idVendor and idProduct fields during probe. Signed-off-by: Johan Hovold --- drivers/net/usb/ch9200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/ch9200.c b/d

APPLY FOR YOUR URGENT LOAN AT 2%

2017-05-12 Thread Thomas Credit Firm
* Do you need an urgent loan? We offer all kinds of loan * Very fast and urgent transfer to your bank account. * Payment begins (6) months after you get the money in your bank account * Low interest rates 2% * Payment of long-term (1-30 years) duration For more information and loan application form

Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

2017-05-12 Thread Bin Liu
On Fri, May 12, 2017 at 09:53:55AM +0300, Peter Ujfalusi wrote: > Bin, > > On 2017-05-11 17:12, Bin Liu wrote: > >>which is valid. > > > >So will you update the patch to move the declaration to the beginning of > >the function to avoid this WARNING. I would just fix it locally if you > >prefer. >

[PATCH] usb: usbip: avoid the usb layer to kfree our allocated buffer

2017-05-12 Thread Michael Grzeschik
The usbip stack handles the kmalloc and kfree of the transfered buffers. Some USB-Stacks add the flag URB_FREE_BUFFER to their urbs, so the usb layer removes it in usb_free_urb. This can lead to double free situations as the usbip stack already removes its created buffers. To avoid that we remove t

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Bin Liu
On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote: > > Well maybe the minimal fix for now is just pretty much back to > square one of this thread. This should keep VBUS always on. > Then we can figure out some logic to cut VBUS later on. > > And yeah, the state machine is really hard

[PATCH] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

2017-05-12 Thread Peter Ujfalusi
We have one register for each EP to set the maximum packet size for both TX and RX. If for example an RX programming would happen before the previous TX transfer finishes we would reset the TX packet side. To fix this issue, only modify the TX or RX part of the register. Fixes: 550a7375fe72 ("USB

[PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

2017-05-12 Thread Peter Ujfalusi
For the DMA we have ch (channel), dmareq and sync_dev parameters both within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. By creating a common struct the code can be simplified when selecting between the shared or multichannel DMA parameters. Signed-off-by: Peter Ujfalusi Tested-by: Tony Lin

[PATCH v3 1/9] dmaengine: omap-dma: port_window support correction for both direction

2017-05-12 Thread Peter Ujfalusi
When the port_window support was verified it was done on setup where only the MEM_TO_DEV direction was enabled. This got un-noticed and thus only this direction worked. Now that I have managed to get a setup to verify both direction it turned out that the setup was incorrect: omap_desc members are

[PATCH v3 8/9] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines

2017-05-12 Thread Peter Ujfalusi
The external request lines are used by tusb6010 on OMAP24xx platforms. Update the map so the driver can use dmaengine API to request the DMA channel. At the same time add temporary map containing only the external DMA request numbers for DT booted case on omap24xx since the tusb6010 stack is not ye

[PATCH v3 2/9] usb: musb: Add quirk to avoid skb reserve in gadget mode

2017-05-12 Thread Peter Ujfalusi
For tusb6010 the DMA functionality only possible if the buffer is 32bit aligned (SYNC access to FIFO) since with ASYNC access the TX/RX offset registers will corrupt eventually. The MUSB_G_NO_SKB_RESERVE will set the quirk_avoids_skb_reserve flag in usb_gadget struct to provide correctly aligned bu

[PATCH v3 7/9] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well

2017-05-12 Thread Peter Ujfalusi
Handle the DMA TX in a similar way as we do for the RX: in the DMA completion callback. Since we are no longer using DMA completion interrupt for the TX we can as wall keep these interrupts disabled, but keep the handler for debug purposes. Signed-off-by: Peter Ujfalusi Tested-by: Tony Lindgren

[PATCH v3 9/9] usb: musb: tusb6010_omap: Convert to DMAengine API

2017-05-12 Thread Peter Ujfalusi
With the port_window support in DMAengine and the sDMA driver we can convert the driver to DMAengine. Signed-off-by: Peter Ujfalusi Tested-by: Tony Lindgren --- drivers/usb/musb/tusb6010_omap.c | 201 --- 1 file changed, 80 insertions(+), 121 deletions(-) di

[PATCH v3 0/9] usb: musb: tusb6010_omap: Convert to DMAengine

2017-05-12 Thread Peter Ujfalusi
Hi, Changes since v2: - patch 5 from the v1 has been sent separately (usb: musb: tusb6010_omap: Do not reset the other direction's packet size) - Added Tested-by from Tony. Changes since v1: - Fix the port_window support in omap-dma DMAengine driver - MUSB_G_NO_SKB_RESERVE quirk flag addition to

[PATCH v3 6/9] usb: musb: tusb6010_omap: Allocate DMA channels upfront

2017-05-12 Thread Peter Ujfalusi
Instead of requesting the DMA channel in tusb_omap_dma_allocate() do it when the controller is created and in runtime work from the DMA channel pool. This change is needed for the DMAengine conversion of the driver since the tusb_omap_dma_allocate() is called in interrupt context which might lead

[PATCH v3 4/9] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program

2017-05-12 Thread Peter Ujfalusi
Having one musb_ep_select() instead the two calls in if/else is the same thing, but makes the code a bit simpler to follow. Signed-off-by: Peter Ujfalusi Tested-by: Tony Lindgren --- drivers/usb/musb/tusb6010_omap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/u

[PATCH v3 3/9] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks

2017-05-12 Thread Peter Ujfalusi
When using the g_ncm for networking this flag will make sure that the buffer is alligned to 32bit so the DMA can be used to offload the data movement. Signed-off-by: Peter Ujfalusi Tested-by: Tony Lindgren --- drivers/usb/musb/tusb6010.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: usb 3-4: unable to get BOS descriptor

2017-05-12 Thread Alan Stern
On Thu, 11 May 2017, Cristian wrote: > Hi, > > 2017-05-11 20:45 GMT+00:00 Alan Stern : > > On Thu, 11 May 2017, Cristian wrote: > > > >> Hi, > >> > >> Attach dmesg > >> [ 968.998463] usb 3-4: unable to get BOS descriptor > >> [ 968.999477] usb 3-4: config 1 has an invalid descriptor of length >

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Tony Lindgren
* Bin Liu [170512 06:43]: > On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote: > > > > Well maybe the minimal fix for now is just pretty much back to > > square one of this thread. This should keep VBUS always on. > > Then we can figure out some logic to cut VBUS later on. > > > > An

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Bin Liu
On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote: > * Bin Liu [170512 06:43]: > > On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote: > > > > > > Well maybe the minimal fix for now is just pretty much back to > > > square one of this thread. This should keep VBUS always on

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Moreno Bartalucci
> Il giorno 12 mag 2017, alle ore 17:21, Bin Liu ha scritto: > > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote: >> * Bin Liu [170512 06:43]: >>> On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote: Well maybe the minimal fix for now is just pretty much back

Re: [PATCH] net: ch9200: add missing USB-descriptor endianness conversions

2017-05-12 Thread David Miller
From: Johan Hovold Date: Fri, 12 May 2017 12:13:26 +0200 > Add the missing endianness conversions to a debug statement printing > the USB device-descriptor idVendor and idProduct fields during probe. > > Signed-off-by: Johan Hovold Applied. -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Tony Lindgren
* Bin Liu [170512 08:24]: > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote: > > OK. No better ideas except I think we should probably have a separate > > timer for keeping VBUS on after state changes eventually. > > Currently with the patch below, VBUS is constantly on for host-onl

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Bin Liu
On Fri, May 12, 2017 at 10:21:35AM -0700, Tony Lindgren wrote: > * Bin Liu [170512 08:24]: > > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote: > > > OK. No better ideas except I think we should probably have a separate > > > timer for keeping VBUS on after state changes eventually.

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Tony Lindgren
* Bin Liu [170512 10:43]: > On Fri, May 12, 2017 at 10:21:35AM -0700, Tony Lindgren wrote: > > * Bin Liu [170512 08:24]: > > > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote: > > > > OK. No better ideas except I think we should probably have a separate > > > > timer for keeping VBU

Re: [PATCH] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

2017-05-12 Thread Bin Liu
On Fri, May 12, 2017 at 04:48:48PM +0300, Peter Ujfalusi wrote: > We have one register for each EP to set the maximum packet size for both > TX and RX. > If for example an RX programming would happen before the previous TX > transfer finishes we would reset the TX packet side. > > To fix this issu

Re: [PATCH] usb: dwc2: add support for the DWC2 controller on Meson8 SoCs

2017-05-12 Thread Rob Herring
On Sat, May 06, 2017 at 07:37:45PM +0200, Martin Blumenstingl wrote: > USB support in the Meson8 SoCs is provided by a DWC2 controller which > works with the same settings as Meson8b and GXBB. Using the generic > "snps,dwc2" binding results in an endless stream of "Overcurrent change > detected" me

Re: [RESEND PATCH v4 4/5] dt-bindings: usb: DT bindings documentation for Broadcom IPROC USB Device controller.

2017-05-12 Thread Rob Herring
On Wed, May 10, 2017 at 06:48:08PM +0530, Raviteja Garimella wrote: > The device node is used for UDCs integrated into Broadcom's > iProc family of SoCs'. The UDC is based on Synopsys Designware > Cores AHB Subsystem USB Device Controller IP. > > Signed-off-by: Raviteja Garimella > --- > Documen

[v1 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

2017-05-12 Thread Thang Q. Nguyen
XHCI specification 1.1 does not require xHCI 1.0 compliant controllers to always enable hardware USB2 LPM. However, the current xHCI driver always enable it by setting HLE=1 when seeing HLC=1. This makes certain xHCI controllers that have broken USB2 HW LPM fail to work as there is no way to disabl

[PATCH] USB: iowarrior: use memdup_user

2017-05-12 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/misc/iowarrior.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 7756953..816afad 10

[PATCH] usb: gadget: f_fs: use memdup_user

2017-05-12 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/gadget/function/f_fs.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index

[PATCH] usb: class: usblp: Fixed assignments inside if conditions

2017-05-12 Thread Alberto Ladron
Fixed coding style issues. Signed-off-by: Alberto Ladron --- drivers/usb/class/usblp.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c index fb87c17..b1879ff 100644 --- a/drivers/usb/clas