Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Sergei Shtylyov
Hello! On 1/13/2017 12:30 AM, Tony Lindgren wrote: Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") together with recent MUSB changes allowed USB and DMA on BeagleBone to idle when no cable is connected. But looks like few corner case issues still remain. Looks like just

Re: USB ExpressCard makes kworker process utilise 72-75% CPU infinitely

2017-01-13 Thread Mathias Nyman
On 12.01.2017 15:33, Christoph Anton Mitterer wrote: Hi. This is basically from: https://bugzilla.kernel.org/show_bug.cgi?id=108341 respectively https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805903 the later in which Ben Hutchings recommended me to ping this list as well. I bought a USB3.0

Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd

2017-01-13 Thread Roger Quadros
Hi, On 13/01/17 05:18, William Wu wrote: > From: William wu > > The commit 4ac53087d6d4 ("usb: xhci: plat: Create both > HCDs before adding them") move add hcd to the end of > probe, this cause hcc_params uninitiated, because xHCI > driver sets hcc_params in xhci_gen_setup() called from > usb_ad

Re: [PATCH v14 09/10] usbip: exporting devices: chage to documenattion

2017-01-13 Thread Krzysztof Opasiak
On 01/13/2017 01:17 AM, Shuah Khan wrote: > On 12/26/2016 12:08 AM, Nobuo Iwata wrote: >> This patch adds function and usage of new connect operation, disconnect >> operation and application(vhci)-side daemon to README and manuals. > > This should be the first patch for the series. That would h

Re: [PATCH 0/2] HID: corsair: fix DMA to stack and info leaks

2017-01-13 Thread Jiri Kosina
On Thu, 12 Jan 2017, Johan Hovold wrote: > These patches fix DMA buffers on stack and information leaks in the > corsair HID driver. > > Note that this series has only been compile tested. Adding Clément to CC, and applying to for-4.10/upstream-fixes branch. Thanks! -- Jiri Kosina SUSE Labs

Re: [PATCH v14 03/10] usbip: exporting devices: new connect operation

2017-01-13 Thread Krzysztof Opasiak
On 01/13/2017 01:06 AM, Shuah Khan wrote: > On 12/26/2016 12:08 AM, Nobuo Iwata wrote: >> Implementation of new connect operation. This is linked as a part of >> usbip command. With this patch, usbip command has following operations. >> >> bind >> unbind >> list (local/remote) >> attach >>

linux 4.9 breaks pctv452e

2017-01-13 Thread Wolfgang Rohdewald
this OOPS always happens with 4.9. up to 4.9.3 all 4.8.x versions work fine. Disabling VMAP_STACK does not fix it. [9.043616] dvb-usb: found a 'Technotrend TT Connect S2-3600' in warm state. [9.043619] pctv452e: pctv452e_power_ctrl: 1 [9.051329] BUG: unable to handle kernel NULL po

Re: linux 4.9 breaks pctv452e

2017-01-13 Thread Greg KH
On Fri, Jan 13, 2017 at 12:15:05PM +0100, Wolfgang Rohdewald wrote: > this OOPS always happens with 4.9. up to 4.9.3 > > all 4.8.x versions work fine. Ick. Any chance you can use 'git bisect' to determine which commit broke this for you? thanks, greg k-h -- To unsubscribe from this list: send

Re: [PATCH v14 02/10] usbip: exporting devices: modifications to host side libraries

2017-01-13 Thread Krzysztof Opasiak
On 01/12/2017 10:14 PM, Shuah Khan wrote: > On 12/26/2016 12:08 AM, Nobuo Iwata wrote: >> Modifications to host driver wrapper and its related operations (i.e. >> bind/unbind). > > Way too many changes in this one patch. > >> >> usbip_get_device() method was not used. The implementation of the

Re: [bug report] USB: opticon: switch to generic read implementation

2017-01-13 Thread Johan Hovold
On Thu, Jan 12, 2017 at 11:39:14PM +0300, Dan Carpenter wrote: > Hello Johan Hovold, > > The patch 7a6ee2b02751: "USB: opticon: switch to generic read > implementation" from Nov 18, 2012, leads to the following static > checker warning: > > drivers/usb/serial/opticon.c:146 opticon_open() >

[PATCH] USB: serial: opticon: fix CTS retrieval at open

2017-01-13 Thread Johan Hovold
The opticon driver used a control request at open to trigger a CTS status notification to be sent over the bulk-in pipe. When the driver was converted to using the generic read implementation, an inverted test prevented this request from being sent, something which could lead to TIOCMGET reporting

Re: [PATCH] USB: serial: opticon: fix CTS retrieval at open

2017-01-13 Thread Greg KH
On Fri, Jan 13, 2017 at 01:21:08PM +0100, Johan Hovold wrote: > The opticon driver used a control request at open to trigger a CTS > status notification to be sent over the bulk-in pipe. When the driver > was converted to using the generic read implementation, an inverted test > prevented this requ

Re: [PATCH 01/37] usb: host: xhci: dynamically allocate devs array

2017-01-13 Thread Mathias Nyman
On 29.12.2016 13:00, Felipe Balbi wrote: Instead of always defaulting to a 256-entry array, we can dynamically allocate devs based on what HW tells us it supports. Note that we can't, yet, purge MAX_HC_SLOTS completely because of struct xhci_device_context_array reliance on it. Signed-off-by: F

Re: [PATCH 00/37] usb: host: xhci: big cleanup series

2017-01-13 Thread Mathias Nyman
Hi On 29.12.2016 13:00, Felipe Balbi wrote: Hi Mathias, Here's a resend of my previous series. This time I've added a few more patches which I have been working on and also cherry-pick three old patches which have been pending since May this year. Note, in particular, the work done for XHCI tr

Re: [PATCH 06/37] usb: host: xhci: WARN on unexpected COMP_SUCCESS

2017-01-13 Thread Mathias Nyman
On 29.12.2016 13:00, Felipe Balbi wrote: COMP_SUCCESS should only be asserted on a *true* sucessful transfer. Any other cases are bogus and we should aim to catch them. One easy way to get bug reports is to trigger a WARN_ONCE() on such cases. Signed-off-by: Felipe Balbi Skipping 6/37 and 7/

Re: [PATCH 12/37] usb: host: xhci: major rewrite of process_ctrl_td()

2017-01-13 Thread Mathias Nyman
On 29.12.2016 13:00, Felipe Balbi wrote: process_ctrl_td() is too complex and difficult to read. We can clean it up a lot and maintain same functionality as before. Note that while cleaning up, one comment was introduced to explain the special case - it wasn't clear before from code. Much of the

[PATCH RFC 2/7] net: phy: make phy_(read|write)_mmd() generic MMD accessors

2017-01-13 Thread Russell King
Make phy_(read|write)_mmd() generic 802.3 clause 45 register accessors for both Clause 22 and Clause 45 PHYs, using either the direct register reading for Clause 45, or the indirect method for Clause 22 PHYs. Allow this behaviour to be overriden by PHY drivers where necessary. Signed-off-by: Russe

[PATCH RFC 3/7] net: lan78xx: update for phy_(read|write)_mmd_indirect() removal

2017-01-13 Thread Russell King
lan78xx appears to use phylib in a rather weird way, accessing the PHY partly through phylib, and partly by makign direct accesses to it, including to the Clause 45 registers. As the indirect MMD accessors are going away, update this driver to use the plain phy_(read|write)_mmd() accessors instead

[PATCH RFC 1/7] net: phy: move phy MMD accessors to phy-core.c

2017-01-13 Thread Russell King
Move the phy_(read|write)__mmd() helpers out of line, they will become our main MMD accessor functions, and so will be a little more complex. This complexity doesn't belong in an inline function. Also move the _indirect variants as well to keep like functionality together. Signed-off-by: Russell

[PATCH RFC 4/7] net: phy: switch remaining users to phy_(read|write)_mmd()

2017-01-13 Thread Russell King
Switch everyone over to using phy_read_mmd() and phy_write_mmd() now that they are able to handle both Clause 22 indirect addressing and Clause 45 direct addressing methods to the MMD registers. Signed-off-by: Russell King --- drivers/net/phy/bcm-phy-lib.c | 12 drivers/net/phy/dp83

[PATCH RFC 7/7] net: phy: clean up mmd_phy_indirect()

2017-01-13 Thread Russell King
Make mmd_phy_indirect() use the same terminology as the rest of the code, making clear what each address is - phy address, devad, and register number. While here, remove the "inline" from this static function, leaving it to the compiler to decide whether to inline this function, and get rid of unn

[PATCH RFC 6/7] net: phy: remove the indirect MMD read/write methods

2017-01-13 Thread Russell King
Remove the indirect MMD read/write methods which are now no longer necessary. Signed-off-by: Russell King --- drivers/net/phy/phy-core.c | 119 + include/linux/phy.h| 18 --- 2 files changed, 35 insertions(+), 102 deletions(-) diff --git

[PATCH RFC 5/7] net: phy: convert micrel to new read_mmd/write_mmd driver methods

2017-01-13 Thread Russell King
Convert micrel to the new read_mmd/write_mmd driver methods. This Clause 22 PHY does not support any MMD access method. Signed-off-by: Russell King --- drivers/net/phy/micrel.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/n

[PATCH RFC 0/7] Clean up PHY MMD accessors

2017-01-13 Thread Russell King - ARM Linux
This series cleans up phylib's MMD accessors, so that we have a common way of accessing the Clause 45 register set. The current situation is far from ideal - we have phy_(read|write)_mmd() which accesses Clause 45 registers over Clause 45 accesses, and we have phy_(read|write)_mmd_indirect(), whic

Re: [PATCH v14 02/10] usbip: exporting devices: modifications to host side libraries

2017-01-13 Thread Shuah Khan
On 01/13/2017 04:55 AM, Krzysztof Opasiak wrote: > > > On 01/12/2017 10:14 PM, Shuah Khan wrote: >> On 12/26/2016 12:08 AM, Nobuo Iwata wrote: >>> Modifications to host driver wrapper and its related operations (i.e. >>> bind/unbind). >> >> Way too many changes in this one patch. >> >>> >>> usbi

Re: USB ExpressCard makes kworker process utilise 72-75% CPU infinitely

2017-01-13 Thread Christoph Anton Mitterer
On Fri, 2017-01-13 at 11:43 +0200, Mathias Nyman wrote: > Does this kworker start to utilize the CPU immediately after a fresh > boot when the card is inserted, Yes. Once the card is inserted it immediately stops to consume the CPU at that high level, and it does not stop when the card is removed.

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Tony Lindgren
* Sergei Shtylyov [170113 01:25]: > > @@ -320,7 +323,8 @@ static irqreturn_t cppi41_irq(int irq, void *data) > > int error; > > > > error = pm_runtime_get(cdd->ddev.dev); > > - if (error < 0) > > + if (((error != -EINPROG

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Tony Lindgren
* Tony Lindgren [170112 16:04]: > * Grygorii Strashko [170112 15:43]: > > @@ -457,38 +449,36 @@ static void push_desc_queue(struct cppi41_channel *c) > > cppi_writel(reg, cdd->qmgr_mem + QMGR_QUEUE_D(c->q_num)); > > } > > > > -static void pending_desc(struct cppi41_channel *c) > > +sta

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Tony Lindgren
* Tony Lindgren [170113 08:27]: > @@ -316,11 +318,12 @@ static irqreturn_t cppi41_irq(int irq, void *data) > __iormb(); > > while (val) { > + unsigned long flags; > u32 desc, len; > int error; >

USB Touchscreen displaying cursor in Weston

2017-01-13 Thread Martyn Welch
I'm currently looking into an issue we are having with a USB touchscreen controller causing Weston to display a cursor when plugged in. The device is an "Elo TouchSystems 2216 AccuTouch USB Touchmonitor Interface", which is being handled by hid-generic. Weston (via libinput) is detecting this d

Re: [PATCH v14 02/10] usbip: exporting devices: modifications to host side libraries

2017-01-13 Thread Krzysztof Opasiak
On 01/13/2017 04:46 PM, Shuah Khan wrote: > On 01/13/2017 04:55 AM, Krzysztof Opasiak wrote: >> >> >> On 01/12/2017 10:14 PM, Shuah Khan wrote: >>> On 12/26/2016 12:08 AM, Nobuo Iwata wrote: Modifications to host driver wrapper and its related operations (i.e. bind/unbind). >>> >>> Way

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Grygorii Strashko
On 01/13/2017 10:17 AM, Tony Lindgren wrote: > * Tony Lindgren [170112 16:04]: >> * Grygorii Strashko [170112 15:43]: >>> @@ -457,38 +449,36 @@ static void push_desc_queue(struct cppi41_channel *c) >>> cppi_writel(reg, cdd->qmgr_mem + QMGR_QUEUE_D(c->q_num)); >>> } >>> >>> -static vo

Re: [PATCH v14 06/10] usbip: exporting devices: modifications to attach and detach

2017-01-13 Thread Krzysztof Opasiak
On 12/26/2016 08:08 AM, Nobuo Iwata wrote: > Refactoring to attach and detach operation to reuse common portion to > application(vhci)-side daemon. > > The new application(vhci)-side daemon executes same procedures as > attach and detach. Most of common code to access vhci has been > implemen

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Tony Lindgren
* Grygorii Strashko [170113 09:37]: > On 01/13/2017 10:17 AM, Tony Lindgren wrote: > > But anyways here's your basic idea plugged into my recent patch and > > it seems to work. I maybe have missed something though while reading > > so please check. > > > > The pm_runtime_get/mark_last_busy/put_au

Re: [PATCH v14 00/10] usbip: exporting devices

2017-01-13 Thread Krzysztof Opasiak
On 12/26/2016 08:08 AM, Nobuo Iwata wrote: > Dear all, > > This series of patches adds exporting device operation to USB/IP. > I run through most of your series and answered with couple of comments. I'm not checking all patches in detail because I see that there is a lot of remarks from previ

Re: [PATCH v8 0/2] usbip: vhci number of ports extension

2017-01-13 Thread Krzysztof Opasiak
On 12/26/2016 08:18 AM, Nobuo Iwata wrote: > This series of patches extends number of ports limitaion in application > (vhci) side. > (...) > 5. Dependencies > > This series depends on 'usbip: exporting devices' patch set because > this includes changes to application side daemon which intr

[PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Tony Lindgren
Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") together with recent MUSB changes allowed USB and DMA on BeagleBone to idle when no cable is connected. But looks like few corner case issues still remain. Looks like just by re-plugging USB cable about ten or so times on Beag

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Grygorii Strashko
On 01/13/2017 12:01 PM, Tony Lindgren wrote: > Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") > together with recent MUSB changes allowed USB and DMA on BeagleBone to idle > when no cable is connected. But looks like few corner case issues still > remain. > > Looks like

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Tony Lindgren
* Grygorii Strashko [170113 10:37]: > > > On 01/13/2017 12:01 PM, Tony Lindgren wrote: > > Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") > > together with recent MUSB changes allowed USB and DMA on BeagleBone to idle > > when no cable is connected. But looks like few co

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Grygorii Strashko
On 01/13/2017 01:01 PM, Tony Lindgren wrote: > * Grygorii Strashko [170113 10:37]: >> >> >> On 01/13/2017 12:01 PM, Tony Lindgren wrote: >>> Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") >>> together with recent MUSB changes allowed USB and DMA on BeagleBone to idle >>>

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Grygorii Strashko
On 01/13/2017 01:53 PM, Grygorii Strashko wrote: > > > On 01/13/2017 01:01 PM, Tony Lindgren wrote: >> * Grygorii Strashko [170113 10:37]: >>> >>> >>> On 01/13/2017 12:01 PM, Tony Lindgren wrote: Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") together with re

Re: [PATCH] Documentation: dt: dwc3: add reference to the usb-xhci properties

2017-01-13 Thread Rob Herring
On Wed, Jan 11, 2017 at 03:59:42PM +0100, Martin Blumenstingl wrote: > dwc3 internally creates a usb-xhci device which means that all > properties documented in usb-xhci.txt are supported as well. > > Signed-off-by: Martin Blumenstingl > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 4 +

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2017-01-13 Thread c400
kernel 4.9.3 still not working latest log: [ 196.984424] sd 7:0:0:0: [sdc] 31293440 512-byte logical blocks: (16.0 GB/14.9 GiB) [ 196.984564] sd 7:0:0:0: [sdc] Write Protect is off [ 196.984566] sd 7:0:0:0: [sdc] Mode Sense: 23 00 00 00 [ 196.984689] sd 7:0:0:0: [sdc] No Caching mode page foun

Re: [RFC PATCH 1/2] usb: host: add a generic platform USB roothub driver

2017-01-13 Thread Rob Herring
On Wed, Jan 11, 2017 at 04:29:46PM +0100, Martin Blumenstingl wrote: > Many SoC platforms have separate devices for the USB PHY which are > registered through the generic PHY framework. These PHYs have to be > enabled to make the USB controller actually work. They also have to be > disabled again o

Re: [RFC PATCH 1/2] usb: host: add a generic platform USB roothub driver

2017-01-13 Thread Martin Blumenstingl
Hi Rob, On Fri, Jan 13, 2017 at 9:08 PM, Rob Herring wrote: > On Wed, Jan 11, 2017 at 04:29:46PM +0100, Martin Blumenstingl wrote: >> Many SoC platforms have separate devices for the USB PHY which are >> registered through the generic PHY framework. These PHYs have to be >> enabled to make the US

Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero

2017-01-13 Thread Bin Liu
On Thu, Jan 12, 2017 at 06:39:38PM +0100, Maxime Ripard wrote: > Hi Bin, > > On Thu, Jan 12, 2017 at 08:50:14AM -0600, Bin Liu wrote: > > On Wed, Jan 11, 2017 at 10:06:38PM +0100, Maxime Ripard wrote: > > > On Wed, Jan 11, 2017 at 02:08:11PM -0600, Bin Liu wrote: > > > > On Thu, Jan 12, 2017 at 03

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2017-01-13 Thread Alan Stern
On Fri, 13 Jan 2017, c400 wrote: > kernel 4.9.3 > still not working > latest log: > > [ 196.984424] sd 7:0:0:0: [sdc] 31293440 512-byte logical blocks: > (16.0 GB/14.9 GiB) > [ 196.984564] sd 7:0:0:0: [sdc] Write Protect is off > [ 196.984566] sd 7:0:0:0: [sdc] Mode Sense: 23 00 00 00 > [ 196

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Grygorii Strashko
On 01/13/2017 01:57 PM, Grygorii Strashko wrote: > > > On 01/13/2017 01:53 PM, Grygorii Strashko wrote: >> >> >> On 01/13/2017 01:01 PM, Tony Lindgren wrote: >>> * Grygorii Strashko [170113 10:37]: On 01/13/2017 12:01 PM, Tony Lindgren wrote: > Commit fdea2d09b997 ("dmaengin

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

2017-01-13 Thread Tony Lindgren
* Grygorii Strashko [170113 13:37]: > > Simplified diff with fix on top of your patch: > > > > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c > > index ce37a1a..9e9403a 100644 > > --- a/drivers/dma/cppi41.c > > +++ b/drivers/dma/cppi41.c > > @@ -319,12 +319,6 @@ static irqreturn_t cppi4

[PATCH] tools: usb usbip - update README USB/IP driver location

2017-01-13 Thread Shuah Khan
Update USB/IP driver location in README. Signed-off-by: Shuah Khan --- tools/usb/usbip/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/usb/usbip/README b/tools/usb/usbip/README index 831f49f..f349ef4 100644 --- a/tools/usb/usbip/README +++ b/tools/usb/usbip/READM

Standard USB Descriptor question

2017-01-13 Thread bruce m beach
Hello everybody I have been stuck for ages trying to figure out something in the Standard USB Descriptor during the enumeration. It looks like it should should be quite simple but I am not getting it because maybe some mind block, maybe becuase the documentation is unclear, or maybe because I'm

Re: Standard USB Descriptor question

2017-01-13 Thread Greg KH
On Fri, Jan 13, 2017 at 07:24:10PM -0800, bruce m beach wrote: > Hello everybody > > I have been stuck for ages trying to figure out something > in the Standard USB Descriptor during the enumeration. It > looks like it should should be quite simple but I am not > getting it because maybe some mi