Hi,
Peter Chen writes:
> On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote:
>> From: Peter Chen
>> Date: Wed, 2 Nov 2016 14:02:02 +0800
>>
>> > Felipe, it may increase cpu utilization since more interrupts will be
>> > there,
>> > it may affect the SoC which has lower cpu frequency
Hi,
Bin Liu writes:
>> > On Mon, Oct 31, 2016 at 12:47:52PM +0200, Felipe Balbi wrote:
>> >> Hi guys,
>> >>
>> >> Sorry for the patch bomb, but I wanted to make sure everyoby knows which
>> >> patches are already queued up for the next window. They are still
>> >> sitting in my testing/next bra
Le 31/10/2016 à 11:48, Felipe Balbi a écrit :
> We have introduced a helper to calculate multiplier
> value from wMaxPacketSize. Start using it.
>
> Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
> Cc:
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
> 1 file
Le 31/10/2016 à 11:48, Felipe Balbi a écrit :
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Cc: Nicolas Ferre
Acked-by: Nicolas Ferre
> Cc:
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/gadget/
Hi Sekhar, David,
It might make sense to have this patch series,
squashed into a single patch, would you agree,
or do you prefer it as is: one-per-subsystem?
Regards
Axel.
On Wed, Nov 2, 2016 at 1:44 PM, Axel Haslam wrote:
> The usb ohci clock match is not working because the usb clock
> is reg
Hi,
Peter Chen writes:
>> Peter Chen writes:
>> >> >> diff --git a/drivers/usb/gadget/function/u_ether.c
>> >> >> b/drivers/usb/gadget/function/u_ether.c
>> >> >> index f4a640216913..119a2e5848e8 100644
>> >> >> --- a/drivers/usb/gadget/function/u_ether.c
>> >> >> +++ b/drivers/usb/gadget/func
Hi Felix,
Felix Hädicke writes:
> Hello Dan Carpenter,
>
> thanks for this. It is indeed a parentheses error. I am currently
> testing a patch to correct this.
Any chance your testing is done by now?
--
balbi
signature.asc
Description: PGP signature
Hi,
Peter Chen writes:
> For isoc endpoint descriptor, the wMaxPacketSize is not real max packet
> size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0 specifcation),
> it may contain the number of packet, so the real max packet should be
> ep->desc->wMaxPacketSize && 0x7ff.
>
> Cc: Felip
Hi,
Peter Chen writes:
> The current error handling flow uses incorrect goto label, fix it
>
> Cc:
> Fixes: d12a8727171c ("usb: gadget: function: Remove
> redundant usb_free_all_descriptors")
> Signed-off-by: Peter Chen
seems like there's more than one fix here.
> ---
> drivers/usb/ga
Hi,
Alexey Khoroshilov writes:
> mv_u3d_req_to_trb() does not check for dma mapping errors.
>
> By the way, the patch improves readability of mv_u3d_start_queue()
> by rearranging its code with two semantic modifications:
> - assignment zero to ep->processing if usb_gadget_map_request() fails;
>
Hi,
Peter Chen writes:
> Add clock operation at .set_suspend if the PHY has
> suspend requirement, it can be benefit of power saving for
> phy and the whole system (parent clock may also be disabled).
>
> Signed-off-by: Peter Chen
> ---
> drivers/usb/phy/phy-generic.c | 9 +
> 1 file c
Hi,
Johan Hovold writes:
> Make sure to drop the references taken by of_parse_phandle() and
> bus_find_device() before returning from am335x_get_phy_control().
>
> Note that there is no guarantee that the devres-managed struct
> phy_control will be valid for the lifetime of the sibling phy devic
On Thu, Nov 03, 2016 at 09:04:54AM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen writes:
> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote:
> >> From: Peter Chen
> >> Date: Wed, 2 Nov 2016 14:02:02 +0800
> >>
> >> > Felipe, it may increase cpu utilization since more interrup
On Thu, Nov 03, 2016 at 10:47:58AM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen writes:
> > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet
> > size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0 specifcation),
> > it may contain the number of packet, so the
On Thu, Nov 03, 2016 at 10:50:23AM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen writes:
> > The current error handling flow uses incorrect goto label, fix it
> >
> > Cc:
> > Fixes: d12a8727171c ("usb: gadget: function: Remove
> > redundant usb_free_all_descriptors")
> > Signed-off-by:
Hi,
Peter Chen writes:
>> Peter Chen writes:
>> > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet
>> > size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0 specifcation),
>> > it may contain the number of packet, so the real max packet should be
>> > ep->desc->wMa
Add super speed descriptors to f_hid.
Signed-off-by: Janusz Dziedzic
---
drivers/usb/gadget/function/f_hid.c | 67 -
1 file changed, 66 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_hid.c
b/drivers/usb/gadget/function/f_hid.c
index
On Thu, Nov 03, 2016 at 11:27:40AM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen writes:
> >> Peter Chen writes:
> >> > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet
> >> > size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0
> >> > specifcation),
> >> > it
On Thu, Nov 03, 2016 at 05:03:10PM +0800, Peter Chen wrote:
> On Thu, Nov 03, 2016 at 09:04:54AM +0200, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Peter Chen writes:
> > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote:
> > >> From: Peter Chen
> > >> Date: Wed, 2 Nov 2016 14:02:02 +0
On 11/3/2016 9:48 AM, Lu Baolu wrote:
cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is
Structure.
not used any more. This patch removes it.
Signed-off-by: Lu Baolu
[...]
MBR, Sergei
--
To unsubscribe
Hi Oliver,
finally got device which stops responding after while on my table...
On Mon, Jun 13, 2016 at 11:02:19AM +0200, Oliver Neukum wrote:
> On Mon, 2016-06-13 at 00:37 +0200, Ladislav Michl wrote:
> > On Sun, Jun 12, 2016 at 11:03:45PM +0200, Ladislav Michl wrote:
> > > Once ttyACM0 starts b
Hi,
Peter Chen writes:
>> Peter Chen writes:
>> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote:
>> >> From: Peter Chen
>> >> Date: Wed, 2 Nov 2016 14:02:02 +0800
>> >>
>> >> > Felipe, it may increase cpu utilization since more interrupts will be
>> >> > there,
>> >> > it may
Hi,
Peter Chen writes:
>> > Peter Chen writes:
>> > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote:
>> > >> From: Peter Chen
>> > >> Date: Wed, 2 Nov 2016 14:02:02 +0800
>> > >>
>> > >> > Felipe, it may increase cpu utilization since more interrupts will be
>> > >> > there,
>
Hi,
Peter Chen writes:
> On Thu, Nov 03, 2016 at 11:27:40AM +0200, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Peter Chen writes:
>> >> Peter Chen writes:
>> >> > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet
>> >> > size (see Table 9-13. Standard Endpoint Descriptor, USB 2
On 03.11.2016 08:48, Lu Baolu wrote:
cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is
not used any more. This patch removes it.
Signed-off-by: Lu Baolu
---
drivers/usb/host/xhci-mem.c | 1 -
drivers/usb/host/
On 03.11.2016 12:22, Sergei Shtylyov wrote:
On 11/3/2016 9:48 AM, Lu Baolu wrote:
cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is
Structure.
I'll fix that while applying the patch, no need to resend
-
Like many similar devices it needs a quirk to work.
Issuing the request gets the device into an irrecoverable state.
Signed-off-by: Oliver Neukum
CC: sta...@vger.kernel.org
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/usbhid/hid-quirks.c | 1 +
2 files changed, 2 insertions(+)
diff --
On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote:
> Hi Oliver,
> Device operates normally after reconnect. So it seems you were right,
> there's no handling for EPIPE and EPROTO errors reported to
> acm_read_bulk_callback.
> Following patch fixes it for me, if it looks okay for you, I'll r
On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote:
> To be consistent on the usb driver for the davinci
> platform follow the example of musb, and add the
> "-da8xx" postfix to the driver name.
>
> Signed-off-by: Axel Haslam
> ---
> drivers/usb/host/ohci-da8xx.c | 2 +-
> 1 file changed,
On Thursday 03 November 2016 01:54 PM, Axel Haslam wrote:
> Hi Sekhar, David,
>
> It might make sense to have this patch series,
> squashed into a single patch, would you agree,
> or do you prefer it as is: one-per-subsystem?
Patches in the current form are okay. Some coordination is required in
On Thu, Nov 03, 2016 at 12:44:20PM +0100, Oliver Neukum wrote:
> On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote:
> > Hi Oliver,
>
> > Device operates normally after reconnect. So it seems you were right,
> > there's no handling for EPIPE and EPROTO errors reported to
> > acm_read_bulk_ca
Hi Sekhar,
The baseline used was the branch usb-next, in Greg's tree:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
Linux next is missing this patch[1] which was applied last week,
but not yet pulled into linux-next. it will be there soon.
Sorry, i did not mention it, i thought it
On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote:
> On Thu, Nov 03, 2016 at 12:44:20PM +0100, Oliver Neukum wrote:
> > On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote:
> > > Hi Oliver,
> >
> > > Device operates normally after reconnect. So it seems you were right,
> > > there
mv_u3d_req_to_trb() does not check for dma mapping errors.
Found by Linux Driver Verification project (linuxtesting.org).
v2: split fix and clenup to separate patches.
Signed-off-by: Alexey Khoroshilov
---
drivers/usb/gadget/udc/mv_u3d_core.c | 6 ++
1 file changed, 6 insertions(+)
diff --
The patch improves readability of mv_u3d_start_queue()
by rearranging its code with two semantic modifications:
- assignment zero to ep->processing if usb_gadget_map_request() fails;
- propagation of error code from mv_u3d_req_to_trb() instead of
hardcoded -ENOMEM.
Signed-off-by: Alexey Khoroshi
On Thu, 2016-11-03 at 13:44 +0100, Ladislav Michl wrote:
> On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote:
Hi,
> > now I'm really confused. Just looked at drivers/usb/serial/generic.c
> > which just stops submitting urbs on -EPIPE. On contrary
> > drivers/usb/serial/ti_usb_3410_50
Finally get rid of dwc3_trace() hack. If any other
message is truly needed, we should add proper
tracepoints for them instead of hacking around with
dwc3_trace() or similar.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/Makefile | 2 +-
drivers/usb/dwc3/core.c | 15 +++--
drivers/u
instead of using a simple trace_printk() wrapper,
let's add an actual tracepoint and print further
details about the endpoint being operated upon.
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/gadget.c | 10 ++
drivers/usb/dwc3/trace.h | 51 +++
Hi,
Alexey Khoroshilov writes:
> mv_u3d_req_to_trb() does not check for dma mapping errors.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> v2: split fix and clenup to separate patches.
I'll fix this time when applying, but keep in mind we don't want these
notes in the co
On Thu, Nov 3, 2016 at 1:00 PM, Sekhar Nori wrote:
> On Thursday 03 November 2016 01:54 PM, Axel Haslam wrote:
>> Hi Sekhar, David,
>>
>> It might make sense to have this patch series,
>> squashed into a single patch, would you agree,
>> or do you prefer it as is: one-per-subsystem?
>
> Patches in
Currently, the USB OTG of the da8xx doesn't work.
This series intend to fix them.
Change in v2:
* Fix the error path da8xx_musb_init()
Changes in v3:
* Remove the host workaround that was not working on every platform
* Add a property to the devicetree node of phy to force the phy in a specific
The first attempt to read a register may fail because the clock may not
be enabled, and then the probe of musb driver will fail.
Call clk_prepare_enable() before the first register read.
Signed-off-by: Alexandre Bailon
---
drivers/usb/musb/da8xx.c | 17 -
1 file changed, 8 insert
The USB PHY is able to operate in OTG, host or peripheral.
Some board may be wired to work act only as host or peripheral.
In such case, the dr_mode property of controller must be set to
host or peripheral. But doing that will also configure the PHY
in host or peripheral mode whereas OTG is able to
The USB PHY is able to operate in OTG, host or peripheral.
Some board may be wired to work act only as host or peripheral.
In such case, the dr_mode property of controller must be set to
host or peripheral. But doing that will also configure the PHY
in host or peripheral mode whereas OTG is able to
The USB PHY is able to operate in OTG, host or peripheral.
Some board may be wired to work act only as host or peripheral.
In such case, the dr_mode property of controller must be set to
host or peripheral. But doing that will also configure the PHY
in host or peripheral mode whereas OTG is able to
If we configure the da8xx OTG phy in OTG mode, neither device or host
mode will work. That is because the PHY is not able to detect and notify
the driver that value of ID pin changed.
To work despite this hardware limitation, the da8xx glue implement a
workaround.
But to work, the workaround requir
Hi,
On Thu, Nov 03, 2016 at 02:12:58PM +0100, Oliver Neukum wrote:
> On Thu, 2016-11-03 at 13:44 +0100, Ladislav Michl wrote:
> > On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote:
>
> Hi,
>
> > > now I'm really confused. Just looked at drivers/usb/serial/generic.c
> > > which just
On Wed, Nov 02, 2016 at 10:45:59PM +0100, Ladislav Michl wrote:
> Hi,
>
> On Tue, Oct 25, 2016 at 02:02:50PM -0500, David Lechner wrote:
> > This suppresses printing the error message "failed to get phy" in the
> > kernel log when the error is -EPROBE_DEFER. This prevents usless noise
> > in the k
Changes in v2:
* Remove unrelated changes in patch 3
* Rename the device node in patch 4
Changes in v3:
* Fix few mistakes in DT binding sample
* Only build the device table if DT is enabled
Change in v4:
* Fix a nit
Alexandre Bailon (1):
ARM: dts: da850: Add the usb otg device node
Petr Kulh
From: Petr Kulhavy
This adds the function musb_get_mode() to get the DT property "dr_mode"
Signed-off-by: Petr Kulhavy
Acked-by: Sergei Shtylyov
Signed-off-by: Alexandre Bailon
Tested-by: David Lechner
Reviewed-by: Kevin Hilman
---
drivers/usb/musb/musb_core.c | 19 +++
dri
This adds the device tree node for the usb otg
controller present in the da850 family of SoC's.
This also enables the otg usb controller for the lcdk board.
Signed-off-by: Alexandre Bailon
---
arch/arm/boot/dts/da850-lcdk.dts | 8
arch/arm/boot/dts/da850.dtsi | 15 +++
From: Petr Kulhavy
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver.
Signed-off-by: Petr Kulhavy
Signed-off-by: Alexandre Bailon
Acked-by: Rob Herring
---
.../devicetree/bindings/usb/da8xx-usb.txt | 43 ++
1 file changed, 43 insertions(+)
create mo
From: Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver
Signed-off-by: Petr Kulhavy
Signed-off-by: Alexandre Bailon
Tested-by: David Lechner
---
drivers/usb/musb/da8xx.c | 46 ++
1 file changed, 46 insertions(+)
dif
The usb ohci clock match is not working because the usb clock
is registered as "ohci" instead of "ohci.0"
But since there is only a single ohci instance, lets pass -1 to
the platform data id parameter and avoid the extra ".0" matching.
while we are fixing this, rename the driver from "ohci" to
"o
While the clk lookup table is making reference to "ohci"
other subsystems (such as phy) are trying to match "ohci.0"
Since there is a single ohci instance, instead of changing
the clk name, change the dev id to -1, and add the "-da8xx"
postfix to match the driver name that will also be changed
in
The davinci ohci driver name (currently "ohci") is too generic.
To be consistent with other usb dirvers, append the "-da8xx" postfix
to the name.
Signed-off-by: Axel Haslam
---
drivers/usb/host/ohci-da8xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci
The ohci device name has changed in the board configuraion files,
hence, change the phy lookup table to match the new name.
Signed-off-by: Axel Haslam
---
drivers/phy/phy-da8xx-usb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-da8xx-usb.c b/drivers/ph
Hi,
On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote:
> The USB PHY is able to operate in OTG, host or peripheral.
> Some board may be wired to work act only as host or peripheral.
> In such case, the dr_mode property of controller must be set to
> host or peripheral. But doing that w
On 11/03/2016 11:03 AM, Axel Haslam wrote:
The usb ohci clock match is not working because the usb clock
is registered as "ohci" instead of "ohci.0"
But since there is only a single ohci instance, lets pass -1 to
the platform data id parameter and avoid the extra ".0" matching.
while we are fix
On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote:
> There is only one ohci on the da8xx series of chips,
> so remove the ".0" when creating the phy. Also add
> the "-da8xx" postfix to be consistent across davinci
> usb drivers.
>
> Signed-off-by: Axel Haslam
Acked-by: Kishon Vijay Abr
On 11/03/2016 10:26 AM, Alexandre Bailon wrote:
The USB PHY is able to operate in OTG, host or peripheral.
Some board may be wired to work act only as host or peripheral.
In such case, the dr_mode property of controller must be set to
host or peripheral. But doing that will also configure the PHY
On 11/03/2016 10:26 AM, Alexandre Bailon wrote:
If we configure the da8xx OTG phy in OTG mode, neither device or host
mode will work. That is because the PHY is not able to detect and notify
the driver that value of ID pin changed.
To work despite this hardware limitation, the da8xx glue implemen
From: Felipe Balbi
Date: Thu, 03 Nov 2016 09:04:54 +0200
> What Dave Miller is saying is that it's ALWAYS a bug to delay
> completion of SKBs. The only thing you're doing with chipidea is
> delaying interrupt by up to 125us; which is still a bug from the
> point of view of the networking layer, b
On 11/03/2016 10:26 AM, Alexandre Bailon wrote:
The USB PHY is able to operate in OTG, host or peripheral.
Some board may be wired to work act only as host or peripheral.
In such case, the dr_mode property of controller must be set to
host or peripheral. But doing that will also configure the PHY
On 11/03/2016 05:34 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote:
>> The USB PHY is able to operate in OTG, host or peripheral.
>> Some board may be wired to work act only as host or peripheral.
>> In such case, the dr_mode property of c
On Thu, Nov 03, 2016 at 12:18:53PM -0500, David Lechner wrote:
> On 11/03/2016 10:26 AM, Alexandre Bailon wrote:
> >The USB PHY is able to operate in OTG, host or peripheral.
> >Some board may be wired to work act only as host or peripheral.
> >In such case, the dr_mode property of controller must
On 11/03/2016 05:53 PM, David Lechner wrote:
> On 11/03/2016 10:26 AM, Alexandre Bailon wrote:
>> The USB PHY is able to operate in OTG, host or peripheral.
>> Some board may be wired to work act only as host or peripheral.
>> In such case, the dr_mode property of controller must be set to
>> host
On 11/03/2016 06:27 PM, Bin Liu wrote:
> On Thu, Nov 03, 2016 at 12:18:53PM -0500, David Lechner wrote:
>> On 11/03/2016 10:26 AM, Alexandre Bailon wrote:
>>> The USB PHY is able to operate in OTG, host or peripheral.
>>> Some board may be wired to work act only as host or peripheral.
>>> In such c
On 11/02/2016 12:38 AM, Sriram Dash wrote:
> From: Arnd Bergmann
>
> For xhci-hcd platform device, all the DMA parameters are not
> configured properly, notably dma ops for dwc3 devices.
>
> The idea here is that you pass in the parent of_node along with
> the child device pointer, so it would
Hi,
On Thursday 03 November 2016 10:56 PM, Alexandre Bailon wrote:
> On 11/03/2016 05:34 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote:
>>> The USB PHY is able to operate in OTG, host or peripheral.
>>> Some board may be wired to work
On 11/03/2016 12:33 PM, Alexandre Bailon wrote:
On 11/03/2016 05:53 PM, David Lechner wrote:
On 11/03/2016 10:26 AM, Alexandre Bailon wrote:
The USB PHY is able to operate in OTG, host or peripheral.
Some board may be wired to work act only as host or peripheral.
In such case, the dr_mode prope
On 03.11.2016 16:34, Felipe Balbi wrote:
>
> Hi,
>
> Alexey Khoroshilov writes:
>> mv_u3d_req_to_trb() does not check for dma mapping errors.
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> v2: split fix and clenup to separate patches.
>
> I'll fix this time when appl
On Thu, 3 Nov 2016, Oliver Neukum wrote:
> Like many similar devices it needs a quirk to work.
> Issuing the request gets the device into an irrecoverable state.
Applied to hid.git#for-4.9/upstream-fixes.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubs
On Thu, Nov 03, 2016 at 10:54:33AM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Johan Hovold writes:
> > Make sure to drop the references taken by of_parse_phandle() and
> > bus_find_device() before returning from am335x_get_phy_control().
> >
> > Note that there is no guarantee that the devres-manage
On Thu, Nov 03, 2016 at 02:12:58PM +0100, Oliver Neukum wrote:
[snip]
> I think the way usbnet handles -EPIPE is the best. We are a bit on thin
> ice because the CDC spec does not list under which conditions we should
> see a stall, thus by implication: never.
> But in general you cannot ignore a s
* Ladislav Michl [161101 14:14]:
> Hi,
>
> On Mon, Oct 24, 2016 at 11:07:08AM -0700, Tony Lindgren wrote:
> > Hi,
> >
> > * Tony Lindgren [161021 00:18]:
> > > * Ladislav Michl [161020 12:37]:
> > > > [ 186.457519] musb-hdrc musb-hdrc.0.auto: VBUS_ERROR in a_wait_bcon
> > > > (90, > > >
>
Hello guys! Did you have any progress on this? Do you still have the
affected machine and devices?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
* Johan Hovold [161031 04:50]:
> On Fri, Oct 28, 2016 at 11:13:19AM -0700, Tony Lindgren wrote:
> > * Johan Hovold [161028 02:45]:
> > > On Thu, Oct 27, 2016 at 12:15:52PM -0700, Tony Lindgren wrote:
> > > > * Johan Hovold [161027 11:46]:
> > > > > But then this looks like it could trigger an AB
On Thu, Nov 03, 2016 at 02:26:35PM -0700, Tony Lindgren wrote:
[snip]
> Here's the patch updated to use the existing finish_resume_work.
> Is that along the lines you were thinking?
>
> Adding also Ladis to Cc too.
Just gave it a try. Sure it wasn't supposed to fix "musb with hub"
issue, but at l
* Tony Lindgren [161103 13:59]:
> * Ladislav Michl [161101 14:14]:
> > > cacaaf80c3a6 ("usb: musb: Call pm_runtime from musb_gadget_queue")
> > > d8e5f0eca1e8 ("usb: musb: Fix hardirq-safe hardirq-unsafe lock order
> > > error")
> >
> > tested with v4.9-rc3 which have these included.
>
> OK th
Properly check the return code of ffs_func_revmap_intf() and
ffs_func_revmap_ep() for a non-negative value.
Instead of checking the return code, the comparison was performed for the last
parameter of the function calls, because of wrong parenthesis.
This also fixes the following static checker wa
On Thu, Nov 03, 2016 at 03:55:32PM -0700, Tony Lindgren wrote:
> * Tony Lindgren [161103 13:59]:
> > * Ladislav Michl [161101 14:14]:
> > > > cacaaf80c3a6 ("usb: musb: Call pm_runtime from musb_gadget_queue")
> > > > d8e5f0eca1e8 ("usb: musb: Fix hardirq-safe hardirq-unsafe lock order
> > > > er
Hi,
On 11/03/2016 07:36 PM, Mathias Nyman wrote:
> On 03.11.2016 12:22, Sergei Shtylyov wrote:
>> On 11/3/2016 9:48 AM, Lu Baolu wrote:
>>
>>> cmd_completion in struct xhci_virt_device is legacy. With command
>>> strutcture and command queue introduced in xhci, cmd_completion is
>>
>> Structur
Add a params.c file and move all driver parameter code there, including
all the static parameter definitions.
Signed-off-by: John Youn
---
drivers/usb/dwc2/Makefile |1 +
drivers/usb/dwc2/core.c | 918 +--
drivers/usb/dwc2/core.h |5 +
drivers/u
This makes it consistent with the hw_params struct and simplifies the
memory management for future refactoring. Fix up usage in all files.
Signed-off-by: John Youn
---
drivers/usb/dwc2/core.c | 12 +--
drivers/usb/dwc2/core.h | 2 +-
drivers/usb/dwc2/core_intr.c | 6 +-
drivers/us
This patch series cleans up and simplifies the parameter handling in
the dwc2 driver so that it is easier to set these parameters and
easier to maintain the driver and support more platforms in the long
run.
The long-term goal is to remove all static and legacy parameters in
favor of autodetection
This shouldn't be freed by the HCD as it is owned by the core and
allocated with devm_kzalloc.
Signed-off-by: John Youn
---
drivers/usb/dwc2/hcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index df5a065..1b6f5e1 100644
--- a/drivers/usb/dw
The dma_desc_fs_enable does not correspond to any hardware parameter and
is unused. Remove it.
Signed-off-by: John Youn
---
drivers/usb/dwc2/core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index 2a21a04..086bbdf 100644
--- a/drivers/usb
Replace this by statically defining a function with defaults, and just
assigning it. This will allow us to use parameters of any type and any
default value.
Signed-off-by: John Youn
---
drivers/usb/dwc2/core.h | 2 --
drivers/usb/dwc2/params.c | 78 +---
Move the gadget devicetree settings into the core_params structure and
document them. Then set and check them in params.c, with the addition of
some helper functions, and remove the equivalent code in gadget.c.
Because these parameters came from the standalone s3c driver, they have
a fixed default
From: Vahram Aharonyan
Add device parameters handling in dwc2-pci similar what is done in dwc3.
Signed-off-by: Vahram Aharonyan
Signed-off-by: John Youn
---
drivers/usb/dwc2/pci.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc
Remove the unnecessary prototypes for all the parameter setting
functions and declare those functions 'static' in the params.c file.
Also remove the duplicate documentation that went along with them. They
are already documented as part of the params structure definition.
Then move the constants t
Consolidate and move all the parameter initialization code from the
probe function to params.c.
Signed-off-by: John Youn
---
drivers/usb/dwc2/core.h | 3 +++
drivers/usb/dwc2/params.c | 29 +
drivers/usb/dwc2/platform.c | 27 ---
3 files
Add the snps,host-dma-disable binding. This controls whether to disable
DMA in host mode.
Signed-off-by: John Youn
---
Documentation/devicetree/bindings/usb/dwc2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt
b/Documentation/devicetree/bin
The driver will automatically enable host DMA and use it if available.
This is consistent with the behavior of all existing platforms.
Read in the "snps,host-dma-disable" device property to disable it.
Signed-off-by: John Youn
---
drivers/usb/dwc2/core.h | 6 +-
drivers/usb/dwc2/params.c
Rename it so that it is more consistent with the gadget dma parameter.
It only affects host-mode operation so prefix it with "host".
Signed-off-by: John Youn
---
drivers/usb/dwc2/core.h | 4 ++--
drivers/usb/dwc2/hcd.c | 54 ++---
drivers/usb/dwc
This hardware parameter is not host specific. It also applies to device
mode. Drop the "host" from the name to make that clear.
Signed-off-by: John Youn
---
drivers/usb/dwc2/core.h | 2 +-
drivers/usb/dwc2/params.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
On Thu, Nov 03, 2016 at 12:42:11PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen writes:
> >> Peter Chen writes:
> >> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote:
> >> >> From: Peter Chen
> >> >> Date: Wed, 2 Nov 2016 14:02:02 +0800
> >> >>
> >> >> > Felipe, it may incr
On Thu, Nov 03, 2016 at 12:42:11PM +0200, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen writes:
> >> Peter Chen writes:
> >> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote:
> >> >> From: Peter Chen
> >> >> Date: Wed, 2 Nov 2016 14:02:02 +0800
> >> >>
> >> >> > Felipe, it may incr
Add a function to check properties and call it from probe. This will
allow us to add check code without bloating the probe function. This
needs to be done after dwc3_get_properties() and dwc3_core_init() so
that all the properties and hardware configs are available.
Signed-off-by: John Youn
---
1 - 100 of 110 matches
Mail list logo
