Re: [PATCH v3] usb: dwc3: OCTEON: add support for device tree

2016-09-12 Thread Felipe Balbi
"Steven J. Hill" writes: > This patch adds support to parse probe data for > the dwc3-octeon driver using device tree. The > DWC3 IP core is found on OCTEON III processors. > > Signed-off-by: Steven J. Hill > > Changes in v3: > - Massive simplification of glue logic. Almost all the > work is d

Re: [PATCH] usb: dwc3: OCTEON: add support for device tree

2016-09-12 Thread Felipe Balbi
Hi, "Steven J. Hill" writes: > On 09/08/2016 02:54 AM, Felipe Balbi wrote: > [...] >> >> octeon is going to be freed when ->remove() gets executed. You really >> don't need to do these. In fact, setting usbctl to NULL will break >> iounmap(). It seems to be me you don't need a remove at all. >>

Re: [usb:usb-next 124/126] ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined!

2016-09-12 Thread Peter Chen
On Mon, Sep 12, 2016 at 12:34:20PM +0800, Fengguang Wu wrote: > On Mon, Sep 12, 2016 at 11:36:20AM +0800, Peter Chen wrote: > >On Mon, Sep 12, 2016 at 07:16:07AM +0800, kbuild test robot wrote: > >>tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > >>usb-next > >>head: ab57

[PATCH 1/1] usb: Kconfig: let USB_ULPI_BUS depends on USB_COMMON

2016-09-12 Thread Peter Chen
Since ulpi bus driver is located at usb/common/ulpi.c, whether it is compiled or not depends on CONFIG_USB_COMMON which needs either USB Host or USB Gadget is enabled, so even CONFIG_USB_ULPI_BUS is chosen, its source may still not be compiled when both USB HOST and USB gadget are disabled. It fix

Re: [PATCH 1/1] USB: serial: usb-serial-simple: add support for another Infineon flashloader

2016-09-12 Thread Johan Hovold
On Fri, Sep 02, 2016 at 10:37:56AM +0200, Daniele Palmas wrote: > This patch adds support for Infineon flashloader 0x8087/0x0801. > > The flashloader is used in Telit LE940B modem family with Telit > flashing application. > > Signed-off-by: Daniele Palmas Now applied, thanks. Johan -- To unsub

Re: [PATCH 1/1] usb: Kconfig: let USB_ULPI_BUS depends on USB_COMMON

2016-09-12 Thread Greg KH
On Mon, Sep 12, 2016 at 04:14:02PM +0800, Peter Chen wrote: > Since ulpi bus driver is located at usb/common/ulpi.c, whether it > is compiled or not depends on CONFIG_USB_COMMON which needs either > USB Host or USB Gadget is enabled, so even CONFIG_USB_ULPI_BUS is > chosen, its source may still not

[PATCH v2 1/1] usb: Kconfig: let USB_ULPI_BUS depends on USB_COMMON

2016-09-12 Thread Peter Chen
Since ulpi bus driver is located at usb/common/ulpi.c, whether it is compiled or not depends on CONFIG_USB_COMMON which needs either USB Host or USB Gadget is enabled, so even CONFIG_USB_ULPI_BUS is chosen, its source may still not be compiled when both USB HOST and USB gadget are disabled. It fix

Re: [PATCH] usb: chipidea: host: fix NULL ptr dereference during shutdown

2016-09-12 Thread Peter Chen
On Sat, Sep 10, 2016 at 12:53:21PM +, Stefan Wahren wrote: > After commit b09b5224fe86 ("usb: chipidea: implement platform shutdown > callback") and commit 43a404577a93 ("usb: chipidea: host: set host to > be null after hcd is freed") a NULL pointer dereference is caused > on i.MX23 during sh

Re: musb: isoc pkt loss with pwc

2016-09-12 Thread Matwey V. Kornilov
2016-09-12 6:28 GMT+03:00 Bin Liu : > Hi, > > On Tue, Aug 30, 2016 at 11:44:33PM +0300, Matwey V. Kornilov wrote: >> 2016-08-30 21:30 GMT+03:00 Bin Liu : >> > Hi, >> > >> > On Sun, Aug 28, 2016 at 01:13:55PM +0300, Matwey V. Kornilov wrote: >> >> Hello Bin, >> >> >> >> I would like to start new thr

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents but: > > 1. You *can* use a static an

[PATCH 1/1] usb: imx53 - Allow to configure ULPI mode for usb host 2 and 3

2016-09-12 Thread Fabien Lahoudere
In order to use ULPI phy (smsc 3315) we have to configure imx53 ULPI mode in usbmisc_imx.c. It takes configuration from device tree through ci_hdrc_imx.*. ... usbphy2: usbphy@2 { compatible = "usb-nop-xceiv"; reset-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;

Re: ULPI phy issue with

2016-09-12 Thread Fabien Lahoudere
Hi, On 10/09/16 05:35, Peter Chen wrote: On Fri, Sep 09, 2016 at 12:50:45PM +0200, Fabien Lahoudere wrote: Hi, Thanks for your reply. On 09/09/16 09:42, Peter Chen wrote: On Thu, Sep 08, 2016 at 10:00:22AM +0200, Fabien Lahoudere wrote: Hi, I have an imx53 based boards with an ULPI phy (sm

Re: ULPI phy issue with

2016-09-12 Thread Peter Chen
On Mon, Sep 12, 2016 at 11:13:01AM +0200, Fabien Lahoudere wrote: > Hi, > > >Yes, please send the patch and tell me which dts and ULPI code you are > >using. We need to understand why the system is hang when configure the > >PHY mode at portsc for your case, afaik, the PHY mode needs to be > >conf

Re: ULPI phy issue with

2016-09-12 Thread Fabien Lahoudere
On 12/09/16 11:46, Peter Chen wrote: On Mon, Sep 12, 2016 at 11:13:01AM +0200, Fabien Lahoudere wrote: Hi, Yes, please send the patch and tell me which dts and ULPI code you are using. We need to understand why the system is hang when configure the PHY mode at portsc for your case, afaik, th

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-12 Thread Mathias Nyman
On 10.09.2016 17:19, Greg KH wrote: On Sat, Sep 10, 2016 at 04:33:05PM +0300, c400 wrote: my DMESG file [ 13.331618] usb 3-1: device descriptor read/64, error -110 [ 28.535180] usb 3-1: device descriptor read/64, error -110 [ 28.737931] usb 3-1: new high-speed USB device number 3 using

[PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Roger Quadros
If dma_pfn_offset is not inherited correctly from the host controller, it might result in sub-optimal configuration as bounce buffer limit might be set to less than optimal level. Consider the mass storage device case. USB storage driver creates a scsi host for the mass storage interface in driver

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

2016-09-12 Thread Roger Quadros
Hi Santosh & Russell, On 19/08/16 19:38, Santosh Shilimkar wrote: > > On 8/19/2016 12:30 AM, Roger Quadros wrote: >> Hi Santosh, >> > So I'm 99.9% convinced that the proposed change is correct. >>> I will got with that then :-) and take my objection back. Just >>> saying that if there

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

2016-09-12 Thread Binyamin Sharet (bsharet)
> On 8 Sep 2016, at 23:24, Alan Stern wrote: > > On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: > >> >>> On 8 Sep 2016, at 22:20, Alan Stern wrote: >>> >>> On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: >>> > I was thinking more like: > > struct usb_gadgetfs_ioctl_a

Re: [PATCHv9 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

2016-09-12 Thread Heikki Krogerus
On Fri, Sep 09, 2016 at 01:19:57PM -0700, Guenter Roeck wrote: > On Fri, Sep 09, 2016 at 04:48:33PM +0300, Heikki Krogerus wrote: > > This adds driver for the USB Type-C PHY on Intel WhiskeyCove > > PMIC which is available on some of the Intel Broxton SoC > > based platforms. > > > > Signed-off-by

Re: [uas] ORICO 2588US3 USB HDD enclosure goes offline after idle

2016-09-12 Thread Oliver Neukum
On Fri, 2016-09-09 at 04:03 +0300, Dmitry Gutov wrote: > On 06.09.2016 12:56, Oliver Neukum wrote: > > > Could you apply the attached patch, > > Thanks, will do as soon as I have a chance to reboot. > > > enable SCSI logging (with > > scsi_logging_level) and retest? > > What command line invoca

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-09-12 Thread Mark Brown
On Sat, Sep 10, 2016 at 07:57:26AM +1000, NeilBrown wrote: > On Fri, Sep 09 2016, Mark Brown wrote: > > The wm831x driver in the patch series is an example of such hardware - > > it is purely a power manager, it has no USB PHY hardware at all. It's a > The "probe" routine calls > +

[PATCH] USB: wusbcore: add in missing white space in error message text

2016-09-12 Thread Colin King
From: Colin Ian King A dev_err message spans two lines and the literal string is missing a white space between words. Add the white space. Signed-off-by: Colin Ian King --- drivers/usb/wusbcore/cbaf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/wusbcore/cbaf

Re: [PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Alan Stern
On Mon, 12 Sep 2016, Roger Quadros wrote: > If dma_pfn_offset is not inherited correctly from the host controller, > it might result in sub-optimal configuration as bounce > buffer limit might be set to less than optimal level. > > Consider the mass storage device case. > USB storage driver creat

Re: [PATCH 1/3] usb: gadgetfs: introduce feature control mechanism

2016-09-12 Thread Alan Stern
On Mon, 12 Sep 2016, Binyamin Sharet (bsharet) wrote: > > On 8 Sep 2016, at 23:24, Alan Stern wrote: > > > > On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: > > > >> > >>> On 8 Sep 2016, at 22:20, Alan Stern wrote: > >>> > >>> On Thu, 8 Sep 2016, Binyamin Sharet (bsharet) wrote: > >>>

Re: [PATCH] USB: wusbcore: add in missing white space in error message text

2016-09-12 Thread Sergei Shtylyov
On 9/12/2016 4:01 PM, Colin King wrote: From: Colin Ian King A dev_err message spans two lines and the literal string is missing a white space between words. Add the white space. Signed-off-by: Colin Ian King --- drivers/usb/wusbcore/cbaf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > Constify local structures. > > > > > > The semantic patch that makes this change is as follows: > > > (http://

[PATCH][V2] USB: wusbcore: add in missing white space in error message text

2016-09-12 Thread Colin King
From: Colin Ian King A dev_err message spans two lines and the literal string is missing a white space between words. Add the white space and reformat the message to not span multiple lines. Signed-off-by: Colin Ian King --- drivers/usb/wusbcore/cbaf.c | 3 +-- 1 file changed, 1 insertion(+),

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > > Constify local structures. > > > > > > > > The seman

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-09-12 Thread NeilBrown
On Mon, Sep 12 2016, Mark Brown wrote: > [ Unknown signature status ] > On Sat, Sep 10, 2016 at 07:57:26AM +1000, NeilBrown wrote: >> On Fri, Sep 09 2016, Mark Brown wrote: > >> > The wm831x driver in the patch series is an example of such hardware - >> > it is purely a power manager, it has no US

[PATCH] scsi: introduce a quirk for false cache reporting

2016-09-12 Thread Oliver Neukum
Some SATA to USB bridges fail to cooperate with some drives resulting in no cache being present being reported to the host. That causes the host to skip sending a command to synchronize caches. That causes data loss when the drive is powered down. Signed-off-by: Oliver Neukum Reviewed-by: Martin

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Felipe Balbi
Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >> > > The semantic patch that makes

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > >> > > Constify l

Re: unusual_devs addition for Kingston DT100G3/32GB 0951:1666

2016-09-12 Thread Wolfgang Breyha
Wolfgang Breyha wrote on 09/09/16 00:26: > On 08/09/16 17:47, David Laight wrote: >> Try writing with: >> dd if=768MB.test of=/dev/sdb oflag=direct bs=1M seek_bytes seek=$((n*512)) >> for several small values of 'n' so that the writes are misaligned. >> >> It may also be worth finding out what the

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Geert Uytterhoeven
On Mon, Sep 12, 2016 at 3:43 PM, Felipe Balbi wrote: > Jarkko Sakkinen writes: >> On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >>> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >>> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >>> > > Constify local structures. >>

Re: [PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Roger Quadros
Hi Alan, On 12/09/16 16:09, Alan Stern wrote: > On Mon, 12 Sep 2016, Roger Quadros wrote: > >> If dma_pfn_offset is not inherited correctly from the host controller, >> it might result in sub-optimal configuration as bounce >> buffer limit might be set to less than optimal level. >> >> Consider t

Re: [PATCH 1/2] usb: dwc3: Add ref clock period setting

2016-09-12 Thread Rob Herring
On Thu, Sep 01, 2016 at 02:32:30PM -0700, John Youn wrote: > From: Thinh Nguyen > > Added ref_clk_per for writing to GUCTL.RefClkPer which > sets the period of ref_clk in nano second. > > Signed-off-by: Thinh Nguyen > Signed-off-by: John Youn > --- > Documentation/devicetree/bindings/usb/dwc3

[PATCH v3] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Roger Quadros
If dma_pfn_offset is not inherited correctly from the host controller, it might result in sub-optimal configuration as bounce buffer limit might be set to less than optimal level. Consider the mass storage device case. USB storage driver creates a scsi host for the mass storage interface in driver

Re: [PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Arnd Bergmann
On Monday, September 12, 2016 9:09:16 AM CEST Alan Stern wrote: > > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c > > index 0406a59..66364ea 100644 > > --- a/drivers/usb/core/message.c > > +++ b/drivers/usb/core/message.c > > @@ -1863,6 +1863,12 @@ free_interfaces: > >

Re: [v2] musb: omap2430: do not assume balanced enable()/disable()

2016-09-12 Thread Tony Lindgren
* Laurent Pinchart [160911 02:06]: > Hi Tony, > > On Saturday 10 Sep 2016 06:07:50 Tony Lindgren wrote: > > * Andreas Kemnade [160910 04:27]: > > > On Fri, 9 Sep 2016 16:40:15 -0700 Tony Lindgren wrote: > > >> * Tony Lindgren [160909 14:33]: > > >>> * Andreas Kemnade [160909 14:22]: > > W

Re: [PATCH resend v4 0/1] musb: sunxi: Add support for platform_set_mode

2016-09-12 Thread Bin Liu
Hi, On Sun, Sep 11, 2016 at 08:18:51PM +0200, Hans de Goede wrote: > Hi Bin Liu, > > I believe this patch is ready for merging now (the sun4i-usb-phy bits have > been merged already), please merge. Done. Sorry for missing it. > > Thanks & Regards, > > Hans Regards, -Bin. -- To unsubscribe fr

Re: [Bug] System reboots instead of shutting down if xhci is enabled in BIOS and USB hub is connected

2016-09-12 Thread Mathias Nyman
On 05.09.2016 19:46, Hasan Mahmood wrote: System reboots instead of shutting down if xhci is enabled in BIOS and USB hub is connected When I connect the usb hub built into my monitor (http://www.samsung.com/uk/support/model/LS27D85KTSN/XU), the system will reboot instead of shutting down when I

Re: [PATCH resend v4] musb: sunxi: Add support for platform_set_mode

2016-09-12 Thread Bin Liu
Hi, On Sun, Sep 11, 2016 at 08:18:52PM +0200, Hans de Goede wrote: > This allows run-time dr_mode switching support via the "mode" musb > sysfs attribute. > > Signed-off-by: Hans de Goede Signed-off-by: Bin Liu Regards, -Bin. -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 2/3] cdc-acm: cleanup debugging in submission path

2016-09-12 Thread Oliver Neukum
On Fri, 2016-09-09 at 14:15 +0200, Greg KH wrote: > On Wed, Sep 07, 2016 at 02:30:02PM +0200, Oliver Neukum wrote: > > Actually make it retutn useful information. > > > > Signed-off-by: Oliver Neukum > > --- > > drivers/usb/class/cdc-acm.c | 8 > > 1 file changed, 4 insertions(+), 4 del

Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-09-12 Thread Mark Brown
On Mon, Sep 12, 2016 at 03:27:18PM +0200, NeilBrown wrote: > On Mon, Sep 12 2016, Mark Brown wrote: > > It's no worse than any other board file situation - if someone has that > > problem they get to fix it. > My point is that the present design does not appear to scale beyond a > single USB powe

[PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling for 2430 glue layer") moved PHY enable/disable calls to happen from omap2430_musb_enable/disable(). That broke enumeration for several devices as PM runtime in the PHY will never enable it. The root cause of the problem is unpair

[PATCH] usb: gadget: uvc: add V4L2 dependency

2016-09-12 Thread Arnd Bergmann
Building the UVC gadget into the kernel fails to build when CONFIG_VIDEO_V4L2 is a loadable module: drivers/usb/gadget/function/usb_f_uvc.o: In function `uvc_function_ep0_complete': uvc_configfs.c:(.text.uvc_function_ep0_complete+0x84): undefined reference to `v4l2_event_queue' drivers/usb/gadge

[PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-12 Thread Arnd Bergmann
Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file means that we can enable it without any of the other USB support, leading to a build error because Kbuild never enters the drivers/usb/common/ directory without CONFIG_USB_COMMON: ERROR: "ulpi_unregister_driver" [drivers/phy/phy-t

Re: [PATCH 2/2] usb: dwc3: Added a property to set GFLADJ register

2016-09-12 Thread Rob Herring
On Thu, Sep 01, 2016 at 02:32:33PM -0700, John Youn wrote: > From: Thinh Nguyen > > Added gfladj variable to control the core behavior with respect to > SOF, ITP, and frame timer functionality. > > Currently there is dwc->fladj that holds a single field in GFLADJ > register (GFLADJ.GFLADJ_30MHZ)

Re: [PATCH] usb: dwc3: OCTEON: add support for device tree

2016-09-12 Thread Steven J. Hill
On 09/12/2016 02:04 AM, Felipe Balbi wrote: > > > Seems like you're not describing your DTS properly. Can you show me how > you're describing dwc3-octeon and dwc3? > Attached. Octeon sff7000# fdt print / / { model = "cavium,sff7000"; compatible = "cavium,sff7000"; #addres

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
Hi Tony, On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > for 2430 glue layer") moved PHY enable/disable calls to happen from > omap2430_musb_enable/disable(). That broke enumeration for several > devices as PM

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-12 Thread Dave Jiang
On 09/12/2016 03:56 AM, Mathias Nyman wrote: > On 10.09.2016 17:19, Greg KH wrote: >> On Sat, Sep 10, 2016 at 04:33:05PM +0300, c400 wrote: >>> my DMESG file >> >>> [ 13.331618] usb 3-1: device descriptor read/64, error -110 >>> [ 28.535180] usb 3-1: device descriptor read/64, error -110 >>> [

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Bin Liu [160912 09:55]: > Hi Tony, > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > for 2430 glue layer") moved PHY enable/disable calls to happen from > > omap2430_musb_enable/disable(). That broke e

Re: [PATCH v6 2/3] usb: musb: da8xx: Use devm in probe

2016-09-12 Thread Bin Liu
Hi, On Tue, Sep 06, 2016 at 02:17:03PM -0500, Bin Liu wrote: > Hi, > > On Mon, Sep 05, 2016 at 03:00:32PM -0500, David Lechner wrote: > > Simplify things a bit by using devm functions where possible. > > > > Signed-off-by: David Lechner > > --- > > drivers/usb/musb/da8xx.c | 19 +--

Re: [PATCH v6 0/3] da8xx USB PHY platform devices and clocks

2016-09-12 Thread Bin Liu
Hi, On Tue, Sep 06, 2016 at 02:19:52PM -0500, Bin Liu wrote: > Hi Greg and Alan, > > On Mon, Sep 05, 2016 at 03:00:30PM -0500, David Lechner wrote: > > Just resending to get these merged into usb. The phy parts of this patch > > series > > have already been merged into Linus' tree. > > > > I ha

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Tony Lindgren [160912 10:26]: > * Bin Liu [160912 09:55]: > > Hi Tony, > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > > for 2430 glue layer") moved PHY enable/disable calls to happen from > >

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-12 Thread Kevin Hilman
Martin Blumenstingl writes: > On Fri, Sep 9, 2016 at 10:36 PM, Martin Blumenstingl > wrote: >> On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >>> Martin Blumenstingl writes: >>> On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks wrote: > On 08/09/16 21:42, Kevin Hilman wrote:

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
On Mon, Sep 12, 2016 at 10:19:40AM -0700, Tony Lindgren wrote: > * Bin Liu [160912 09:55]: > > Hi Tony, > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy handling > > > for 2430 glue layer") moved PHY enable/di

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
On Mon, Sep 12, 2016 at 12:32:42PM -0500, Bin Liu wrote: > On Mon, Sep 12, 2016 at 10:19:40AM -0700, Tony Lindgren wrote: > > * Bin Liu [160912 09:55]: > > > Hi Tony, > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > > Commit a83e17d0f73b ("usb: musb: Improve PM run

Re: [PATCH -next] usb: musb: am35x: fix error return code in am35x_probe()

2016-09-12 Thread Bin Liu
Hi, On Sat, Sep 10, 2016 at 11:54:23AM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the usb_phy_generic_register() > error handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Signed-off-by: Bin Liu Rega

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-12 Thread c400
[182047.000570] xhci_hcd :02:00.0: remove, state 4 [182047.000577] usb usb4: USB disconnect, device number 1 [182047.023980] xhci_hcd :02:00.0: Host not halted after 16000 microseconds. [182047.023982] xhci_hcd :02:00.0: Host controller not halted, aborting reset. [182047.023996] xhci_h

[PATCH] usb: cleanup with list_first_entry_or_null()

2016-09-12 Thread Masahiro Yamada
The combo of list_empty() check and return list_first_entry() can be replaced with list_first_entry_or_null(). Signed-off-by: Masahiro Yamada --- drivers/usb/dwc2/gadget.c| 6 ++ drivers/usb/dwc3/gadget.h| 5 + drivers/usb/renesas_usbhs/fifo.c | 5 + 3 files changed,

Re: [PATCH v6 0/3] da8xx USB PHY platform devices and clocks

2016-09-12 Thread Kevin Hilman
Bin Liu writes: > On Tue, Sep 06, 2016 at 02:19:52PM -0500, Bin Liu wrote: >> Hi Greg and Alan, >> >> On Mon, Sep 05, 2016 at 03:00:30PM -0500, David Lechner wrote: >> > Just resending to get these merged into usb. The phy parts of this patch >> > series >> > have already been merged into Linus

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Andreas Kemnade
On Mon, 12 Sep 2016 10:34:08 -0700 Tony Lindgren wrote: > * Tony Lindgren [160912 10:26]: > > * Bin Liu [160912 09:55]: > > > Hi Tony, > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > > Commit a83e17d0f73b ("usb: musb: Improve PM runtime and phy > > > > handling

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Andreas Kemnade [160912 11:05]: > On Mon, 12 Sep 2016 10:34:08 -0700 > Tony Lindgren wrote: > > > * Tony Lindgren [160912 10:26]: > > > * Bin Liu [160912 09:55]: > > > > Hi Tony, > > > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > > > > > Commit a83e17d0f73b ("u

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-12 Thread Alan Stern
On Mon, 12 Sep 2016, Oliver Neukum wrote: > Some SATA to USB bridges fail to cooperate with some > drives resulting in no cache being present being reported > to the host. That causes the host to skip sending > a command to synchronize caches. That causes data loss > when the drive is powered down

Re: [PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

2016-09-12 Thread Alan Stern
On Mon, 12 Sep 2016, Arnd Bergmann wrote: > On Monday, September 12, 2016 9:09:16 AM CEST Alan Stern wrote: > > > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c > > > index 0406a59..66364ea 100644 > > > --- a/drivers/usb/core/message.c > > > +++ b/drivers/usb/core/message.c >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Tony Lindgren [160912 11:13]: > * Andreas Kemnade [160912 11:05]: > > On Mon, 12 Sep 2016 10:34:08 -0700 > > Tony Lindgren wrote: > > > > > > Oh I see davinci_musb_disable and am35x_musb_disable reset devctl and > > > clear interrupts. I'll try to check on am3517 here today, don't have > > >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Bin Liu
On Mon, Sep 12, 2016 at 08:05:30PM +0200, Andreas Kemnade wrote: > On Mon, 12 Sep 2016 10:34:08 -0700 > Tony Lindgren wrote: > > > * Tony Lindgren [160912 10:26]: > > > * Bin Liu [160912 09:55]: > > > > Hi Tony, > > > > > > > > On Mon, Sep 12, 2016 at 08:39:49AM -0700, Tony Lindgren wrote: > >

Re: [PATCH] usb: musb: remove redundant stack buffers

2016-09-12 Thread Bin Liu
Hi, On Thu, Aug 04, 2016 at 08:58:18PM +0200, Rasmus Villemoes wrote: > aDate is always the empty string, so entirely pointless. The aRevision > formatting might as well be done as part of the pr_debug() call - that > also avoids it altogether if pr_debug is compiled out. > > Signed-off-by: Rasmu

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 03:52:08PM +0200, Julia Lawall wrote: > > > On Mon, 12 Sep 2016, Felipe Balbi wrote: > > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > >>

Question about suspend/resume clock handling in dwc3-of-simple.c

2016-09-12 Thread Guenter Roeck
Hi folks, In dwc3-of-simple.c:dwc3_of_simple_remove(), I see the following code. for (i = 0; i < simple->num_clocks; i++) { clk_unprepare(simple->clks[i]); clk_put(simple->clks[i]); } What I don't understand is why clk_unprepare() is called instead

Re: musb: isoc pkt loss with pwc

2016-09-12 Thread Bin Liu
Hi, On Mon, Sep 12, 2016 at 11:52:46AM +0300, Matwey V. Kornilov wrote: > 2016-09-12 6:28 GMT+03:00 Bin Liu : > > Hi, > > > > On Tue, Aug 30, 2016 at 11:44:33PM +0300, Matwey V. Kornilov wrote: > >> 2016-08-30 21:30 GMT+03:00 Bin Liu : > >> > Hi, > >> > > >> > On Sun, Aug 28, 2016 at 01:13:55PM +0

Re: Question about suspend/resume clock handling in dwc3-of-simple.c

2016-09-12 Thread Felipe Balbi
Hi Guenter, Guenter Roeck writes: > Hi folks, > > In dwc3-of-simple.c:dwc3_of_simple_remove(), I see the following code. > > for (i = 0; i < simple->num_clocks; i++) { > clk_unprepare(simple->clks[i]); > clk_put(simple->clks[i]); > } > > What I don't und

[RFT PATCH 2/2] usb: dwc3: of-simple: add compatible for Calvium

2016-09-12 Thread Felipe Balbi
Add necessary compatible flag for Calvium's DWC3 so dwc3-of-simple will probe. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-of-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index f740ff45a733..cd8ceb3b

[RFT PATCH 0/2] usb: dwc3: of-simple: add support for Calvium's dwc3

2016-09-12 Thread Felipe Balbi
Hi Steven, Here's my take on adding support for your DWC3 implementation. Note that for this to work you need to properly describe your core with proper dma-ranges and dma-coherent properties. With that, OF core will (or should) be able to call dma_coerce_mask_and_coherent() with appropriate argum

[RFT PATCH 1/2] usb: dwc3: of-simple: allow glues without clocks

2016-09-12 Thread Felipe Balbi
Instead of erroring out when we don't have clocks, let's just avoid any calls to the clk API. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-of-simple.c | 44 +-- 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-of-s

Re: musb: isoc pkt loss with pwc

2016-09-12 Thread Matwey V. Kornilov
2016-09-12 21:57 GMT+03:00 Bin Liu : > Hi, > > On Mon, Sep 12, 2016 at 11:52:46AM +0300, Matwey V. Kornilov wrote: >> 2016-09-12 6:28 GMT+03:00 Bin Liu : >> > Hi, >> > >> > On Tue, Aug 30, 2016 at 11:44:33PM +0300, Matwey V. Kornilov wrote: >> >> 2016-08-30 21:30 GMT+03:00 Bin Liu : >> >> > Hi, >>

Re: Question about suspend/resume clock handling in dwc3-of-simple.c

2016-09-12 Thread Guenter Roeck
Hi Felipe, On Mon, Sep 12, 2016 at 10:05:00PM +0300, Felipe Balbi wrote: > > Hi Guenter, > > Guenter Roeck writes: > > Hi folks, > > > > In dwc3-of-simple.c:dwc3_of_simple_remove(), I see the following code. > > > > for (i = 0; i < simple->num_clocks; i++) { > > clk_unprepar

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wro

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > >> > >

Re: [PATCH v4 03/22] usb: ulpi: Support device discovery via DT

2016-09-12 Thread Stephen Boyd
Quoting Stephen Boyd (2016-09-07 14:35:00) > @@ -174,6 +219,21 @@ static int ulpi_register(struct device *dev, struct ulpi > *ulpi) > ulpi->id.product = ulpi_read(ulpi, ULPI_PRODUCT_ID_LOW); > ulpi->id.product |= ulpi_read(ulpi, ULPI_PRODUCT_ID_HIGH) << 8; > > + /* Some ULP

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-12 Thread Peter Chen
On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote: > Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file > means that we can enable it without any of the other USB support, > leading to a build error because Kbuild never enters the > drivers/usb/common/ directory without

[PATCH 8/9] usb: musb: am35x: fix error return code in am35x_probe()

2016-09-12 Thread Bin Liu
From: Wei Yongjun Fix to return a negative error code from the usb_phy_generic_register() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Signed-off-by: Bin Liu --- drivers/usb/musb/am35x.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[PATCH 2/9] usb: musb: Prepare dsps glue layer for PM runtime support

2016-09-12 Thread Bin Liu
From: Tony Lindgren We want to be polling the state when nothing is connected. Let's change the polling logic in preparation for PM runtime support. Signed-off-by: Tony Lindgren [b-...@ti.com: undo unnecessary line leading whitespace change] Signed-off-by: Bin Liu --- drivers/usb/musb/musb_ds

[PATCH 7/9] usb: musb: da8xx: Remove mach code

2016-09-12 Thread Bin Liu
From: David Lechner Use the new phy-da8xx-usb driver to take the place of the mach code that pokes CFGCHIP2 in the da8xx musb glue driver. This unbreaks the driver. Signed-off-by: David Lechner Signed-off-by: Bin Liu --- drivers/usb/musb/Kconfig | 2 +- drivers/usb/musb/da8xx.c | 135 ++

[PATCH 6/9] usb: musb: da8xx: Use devm in probe

2016-09-12 Thread Bin Liu
From: David Lechner Simplify things a bit by using devm functions where possible. Signed-off-by: David Lechner [b-...@ti.com: fixed merge conflict] Signed-off-by: Bin Liu --- drivers/usb/musb/da8xx.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/driv

[PATCH 0/9] musb patches for v4.9-rc1

2016-09-12 Thread Bin Liu
Hi Greg, This musb patch set is for next v4.9-rc. It is mainly for driver improvement and cleanup. Please let me know if any change is needed. Regards, -Bin. David Lechner (2): usb: musb: da8xx: Use devm in probe usb: musb: da8xx: Remove mach code Hans de Goede (1): musb: sunxi: Add sup

[PATCH 5/9] musb: sunxi: Add support for platform_set_mode

2016-09-12 Thread Bin Liu
From: Hans de Goede This allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede Signed-off-by: Bin Liu --- drivers/usb/musb/sunxi.c | 61 1 file changed, 57 insertions(+), 4 deletions(-) dif

[PATCH 1/9] usb: musb: Implement session bit based runtime PM for musb-core

2016-09-12 Thread Bin Liu
From: Tony Lindgren We want to keep musb enabled always when the session bit is set. This simplifies the PM runtime and allows making it more generic across the various glue layers. So far the only exception to just following the session bit is host mode disconnect where the session bit stays se

[PATCH 9/9] usb: musb: remove redundant stack buffers

2016-09-12 Thread Bin Liu
From: Rasmus Villemoes aDate is always the empty string, so entirely pointless. The aRevision formatting might as well be done as part of the pr_debug() call - that also avoids it altogether if pr_debug is compiled out. Signed-off-by: Rasmus Villemoes Signed-off-by: Bin Liu --- drivers/usb/mu

[PATCH 4/9] usb: musb: Add PM runtime support for MUSB DSPS glue layer

2016-09-12 Thread Bin Liu
From: Tony Lindgren We can now just use PM runtime autoidle support as musb core keeps things enabled when the devctl session bit is set. And there's no need for dsps_musb_try_idle() so let's just remove it. Note that as cppi41 dma is clocked by musb, this only makes PM work for dsps glue layer

[PATCH 3/9] usb: musb: Simplify PM runtime for 2430 glue layer

2016-09-12 Thread Bin Liu
From: Tony Lindgren With musb core now blocking PM based on the devctl status bit, we can remove related quirks from the 2430 glue layer and simplify PM runtime further. Lets's also use musb->controller instead of dev to make it clear we make the PM runtime calls for the core, not the glue layer

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Tony Lindgren
* Bin Liu [160912 11:36]: > On Mon, Sep 12, 2016 at 08:05:30PM +0200, Andreas Kemnade wrote: > > Hmm, then the question is: Couldn't the X_musb_disable simply be called > > from X_probe if needed to be an the safe side? > > In general, we try not to do so if all possible. We want to put common >

Re: [RFT PATCH 0/2] usb: dwc3: of-simple: add support for Calvium's dwc3

2016-09-12 Thread Steven J. Hill
On 09/12/2016 02:18 PM, Felipe Balbi wrote: > > Please give this a shot. Patches are still RFT > because, well, they need testing. Note also that I > haven't, yet, added a binding documentation for your > compatible flag. I'll do that on V2 of the patchset. > Hey Felipe. Using your changes, the

Mapping USB-ports "by slot" rather than by "usb attributes"

2016-09-12 Thread Ajay Garg
Hi All. Till now, we had a single usb-serial-cable, that we needed to associate to a static tty-name. http://hintshop.ludvig.co.nz/show/persistent-names-usb-serial-devices/ worked perfect for our purpose (till now). However, we now require that multiple "identical" usb-serial-cables be inserted

Re: Question about suspend/resume clock handling in dwc3-of-simple.c

2016-09-12 Thread Felipe Balbi
Hi, Guenter Roeck writes: >> > Should it be clk_disable_unprepare(), or maybe something like the >> > following >> > >> >if (!pm_runtime_status_suspended(dev)) >> >clk_disable_unprepare(); >> >else >> >clk_unprepare(); >> >> I'm not sure how balanced those calls

Re: [PATCH 2/2] usb: dwc3: Added a property to set GFLADJ register

2016-09-12 Thread Felipe Balbi
Hi, Rob Herring writes: >> Synopsys HW setup (HAPS DX and phy board) requires a preset to this >> register to improve interoperablitity. For example, the value for >> GFLADJ_REFCLK_LPM_SEL should be set to 0 with ref_clk period of 50. > > This sounds like it should be handled in the driver. Is i

Re: [RFT PATCH 0/2] usb: dwc3: of-simple: add support for Calvium's dwc3

2016-09-12 Thread Felipe Balbi
"Steven J. Hill" writes: > On 09/12/2016 02:18 PM, Felipe Balbi wrote: >> >> Please give this a shot. Patches are still RFT >> because, well, they need testing. Note also that I >> haven't, yet, added a binding documentation for your >> compatible flag. I'll do that on V2 of the patchset. >> >

Re: [PATCH] usb: cleanup with list_first_entry_or_null()

2016-09-12 Thread Felipe Balbi
Hi Masahiro, Masahiro Yamada writes: > The combo of list_empty() check and return list_first_entry() > can be replaced with list_first_entry_or_null(). > > Signed-off-by: Masahiro Yamada > --- Care to split this into two patches (one for dwc2 and one for dwc3)? thanks -- balbi signature.a

Re: Mapping USB-ports "by slot" rather than by "usb attributes"

2016-09-12 Thread Greg KH
On Tue, Sep 13, 2016 at 11:02:52AM +0530, Ajay Garg wrote: > Hi All. > > Till now, we had a single usb-serial-cable, that we needed to > associate to a static tty-name. > http://hintshop.ludvig.co.nz/show/persistent-names-usb-serial-devices/ > worked perfect for our purpose (till now). > > > How

  1   2   >