Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-25 Thread Peter Chen
On Thu, Aug 25, 2016 at 07:06:12AM +0200, Stefan Wahren wrote: > Hi Alan, > > > Alan Stern hat am 24. August 2016 um 20:55 > > geschrieben: > > > > > > On Wed, 24 Aug 2016, Stefan Wahren wrote: > > > > > Hi, > > > > > > [add Li Jun to CC] > > > > > > > Alan Stern hat am 24. August 2016 um 1

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-25 Thread Stefan Wahren
Am 25.08.2016 um 08:44 schrieb Peter Chen: > On Thu, Aug 25, 2016 at 07:06:12AM +0200, Stefan Wahren wrote: >> Hi Alan, >> >> i tried the following patch: >> --- a/drivers/usb/chipidea/host.c >> +++ b/drivers/usb/chipidea/host.c >> @@ -185,6 +185,8 @@ static void host_stop(struct ci_hdrc *ci) >>

[PATCH 4/4] usb: dwc3: gadget: always decrement by 1

2016-08-25 Thread Felipe Balbi
We need to decrement in both cases (enq > deq and enq < deq) Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 594e82595634..e4ef9ed1a143 100644 --- a/drive

[PATCH 1/4] usb: gadget: udc: core: don't starve DMA resources

2016-08-25 Thread Felipe Balbi
Always unmap all SG entries as required by DMA API Fixes: a698908d3b3b ("usb: gadget: add generic map/unmap request utilities") Cc: # v3.4+ Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/co

[PATCH 3/4] usb: dwc3: gadget: don't consume non-started requests

2016-08-25 Thread Felipe Balbi
If a request wasn't started, don't give it back. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 122e64df2f4d..594e82595634 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/d

[PATCH 2/4] usb: dwc3: debug: fix ep name on trace output

2016-08-25 Thread Felipe Balbi
There was a typo when generating endpoint name which would be very confusing when debugging. Fix it. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h index 22dfc3dd6a13

Re: [PATCH v2 4/6] usb: dwc3: gadget: add remaining sg entries to ring

2016-08-25 Thread Felipe Balbi
Hi, John Youn writes: > Hi Felipe, > > On 8/15/2016 4:02 AM, Felipe Balbi wrote: >> Upon transfer completion after a full ring, let's >> add more TRBs to our ring in order to complete our >> request successfully. >> >> Signed-off-by: Felipe Balbi >> --- >> drivers/usb/dwc3/gadget.c | 36 +

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Rafał Miłecki
On 24 August 2016 at 23:04, Greg KH wrote: > On Wed, Aug 24, 2016 at 11:29:51AM +0200, Rafał Miłecki wrote: >> On 24 August 2016 at 11:22, Greg KH wrote: >> > On Wed, Aug 24, 2016 at 12:03:29AM +0200, Rafał Miłecki wrote: >> >> +static ssize_t ports_show(struct device *dev, struct device_attribut

Re: [PATCH v2 4/6] usb: dwc3: gadget: add remaining sg entries to ring

2016-08-25 Thread Felipe Balbi
Hi, Felipe Balbi writes: >> On your testing/next, I see considerable slow down and file >> corruption in mass storage. >> >> After bisecting, this patch seems to be the first one that shows >> problems. The device fails even enumeration here. >> >> I haven't looked in detail at the changes but,

[PATCH V4] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Rafał Miłecki
From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the specified USB port. This can can useful for various home routers that have USB port(s) and a proper LED telling user a device is connected. The trigger gets its documentation f

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Jacek Anaszewski
zOn 08/24/2016 07:52 PM, Rafał Miłecki wrote: From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the specified USB port. This can can useful for various home routers that have USB port(s) and a proper LED telling user a device is

Re: [PATCH v2 4/6] usb: dwc3: gadget: add remaining sg entries to ring

2016-08-25 Thread Felipe Balbi
Hi, Felipe Balbi writes: > Felipe Balbi writes: >>> On your testing/next, I see considerable slow down and file >>> corruption in mass storage. >>> >>> After bisecting, this patch seems to be the first one that shows >>> problems. The device fails even enumeration here. >>> >>> I haven't looked

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Matthias Brugger
On 25/08/16 10:03, Jacek Anaszewski wrote: zOn 08/24/2016 07:52 PM, Rafał Miłecki wrote: From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the specified USB port. This can can useful for various home routers that have USB port

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Rafał Miłecki
On 25 August 2016 at 10:03, Jacek Anaszewski wrote: > On 08/24/2016 07:52 PM, Rafał Miłecki wrote: >> >> From: Rafał Miłecki >> >> This commit adds a new trigger responsible for turning on LED when USB >> device gets connected to the specified USB port. This can can useful for >> various home rou

Re: [RESEND PATCH, v5 4/5] usb: Add MediaTek USB3 DRD Driver

2016-08-25 Thread Oliver Neukum
On Thu, 2016-08-25 at 11:05 +0800, Chunfeng Yun wrote: > This patch adds support for the MediaTek USB3 controller > integrated into MT8173. It can be configured as Dual-Role > Device (DRD), Peripheral Only and Host Only (xHCI) modes. > > +/** > + * General Purpose Descriptor (GPD): > + * The fo

Re: [PATCH] usb: renesas_usbhs: add a compatible string for r8a7796

2016-08-25 Thread Geert Uytterhoeven
On Wed, Aug 24, 2016 at 9:39 AM, Yoshihiro Shimoda wrote: > This patch adds support for r8a7796 (R-Car M3-W). > > Signed-off-by: Yoshihiro Shimoda Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Rafał Miłecki
On 25 August 2016 at 10:03, Jacek Anaszewski wrote: > On 08/24/2016 07:52 PM, Rafał Miłecki wrote: >> >> From: Rafał Miłecki >> >> This commit adds a new trigger responsible for turning on LED when USB >> device gets connected to the specified USB port. This can can useful for >> various home rou

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Jacek Anaszewski
On 08/25/2016 10:29 AM, Rafał Miłecki wrote: On 25 August 2016 at 10:03, Jacek Anaszewski wrote: On 08/24/2016 07:52 PM, Rafał Miłecki wrote: From: Rafał Miłecki This commit adds a new trigger responsible for turning on LED when USB device gets connected to the specified USB port. This can

Re: [PATCH v2 4/6] usb: dwc3: gadget: add remaining sg entries to ring

2016-08-25 Thread Felipe Balbi
Hi, Felipe Balbi writes: > Felipe Balbi writes: >> Felipe Balbi writes: On your testing/next, I see considerable slow down and file corruption in mass storage. After bisecting, this patch seems to be the first one that shows problems. The device fails even enumeration

[PATCH v3] usb: dwc3: gadget: add remaining sg entries to ring

2016-08-25 Thread Felipe Balbi
Upon transfer completion after a full ring, let's add more TRBs to our ring in order to complete our request successfully. Signed-off-by: Felipe Balbi --- Changes since v1: - none Changes since v2: - fix regression found by John Youn drivers/usb/dwc3/gadget.c | 33

Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

2016-08-25 Thread Oliver Neukum
On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote: > On Wed, 24 Aug 2016 16:30:39 +0200 > Oliver Neukum wrote: > > > On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote: > > > + if (block != data) > > > + kfree(block); > > > > And if block == dta, what frees the memory

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-25 Thread Peter Chen
On Thu, Aug 25, 2016 at 08:27:03AM +0200, Stefan Wahren wrote: > Am 25.08.2016 um 08:44 schrieb Peter Chen: > > On Thu, Aug 25, 2016 at 07:06:12AM +0200, Stefan Wahren wrote: > >> Hi Alan, > >> > >> i tried the following patch: > >> --- a/drivers/usb/chipidea/host.c > >> +++ b/drivers/usb/chipidea/

[GIT PULL] Fixes for v4.8-rc3

2016-08-25 Thread Felipe Balbi
Hi Greg, here's the second round of fixes for v4.8-rc3. Nothing really major this time, seems like things are already winding down (famous last words). Let me know if you want anything to be changed. cheers The following changes since commit fa8410b355251fd30341662a40ac6b22d3e38468: Linux 4

Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

2016-08-25 Thread Alban Bedel
On Thu, 25 Aug 2016 11:16:36 +0200 Oliver Neukum wrote: > On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote: > > On Wed, 24 Aug 2016 16:30:39 +0200 > > Oliver Neukum wrote: > > > > > On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote: > > > > > + if (block != data) > > > > +

Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

2016-08-25 Thread Oliver Neukum
On Thu, 2016-08-25 at 12:07 +0200, Alban Bedel wrote: > On Thu, 25 Aug 2016 11:16:36 +0200 > Oliver Neukum wrote: > > > On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote: > > > On Wed, 24 Aug 2016 16:30:39 +0200 > > > Oliver Neukum wrote: > > > > > > > On Wed, 2016-08-24 at 15:52 +0200, Al

Re: [RFT PATCH v2 3/4] usb: dwc2: Properly account for the force mode delays

2016-08-25 Thread Heiko Stübner
Hi John, Am Mittwoch, 24. August 2016, 16:20:01 schrieb John Youn: > When a force mode bit is set and the IDDIG debounce filter is enabled, > there is a delay for the forced mode to take effect. This delay is due > to the IDDIG debounce filter and is variable depending on the platform's > PHY cloc

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-25 Thread Mathias Nyman
On 24.08.2016 17:14, Alan Stern wrote: On Wed, 24 Aug 2016, Mathias Nyman wrote: The sleep() worked as it delayed freeing the primary hcd, changing the order to first release usb3 hcd and then usb2 hcd. Does this mean that the patch you already posted is the proper fix? Not sure, still just

Re: [RFT PATCH v2 1/4] usb: dwc2: gadget: Only initialize device if in device mode

2016-08-25 Thread Heiko Stübner
Am Mittwoch, 24. August 2016, 16:19:54 schrieb John Youn: > In dwc2_hsotg_udc_start(), don't initialize the controller for device > mode unless we are actually in device mode. > > Signed-off-by: John Youn On rk3188 with both host and (ethernet-)gadget Tested-by: Heiko Stuebner -- To unsubscrib

Re: [PATCHv6 1/3] usb: USB Type-C connector class

2016-08-25 Thread Heikki Krogerus
Hi, On Wed, Aug 24, 2016 at 04:08:23PM +0200, Vincent Palatin wrote: > Sorry if I'm making redundant comments with previous discussions, I > might have missed a few threads. > > > On Mon, Aug 22, 2016 at 2:05 PM, Heikki Krogerus > wrote: > > The purpose of USB Type-C connector class is to provi

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Greg KH
On Thu, Aug 25, 2016 at 07:14:52AM +0200, Rafał Miłecki wrote: > On 24 August 2016 at 23:04, Greg KH wrote: > > On Wed, Aug 24, 2016 at 11:29:51AM +0200, Rafał Miłecki wrote: > >> On 24 August 2016 at 11:22, Greg KH wrote: > >> > On Wed, Aug 24, 2016 at 12:03:29AM +0200, Rafał Miłecki wrote: > >>

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Greg KH
On Thu, Aug 25, 2016 at 10:03:52AM +0200, Rafał Miłecki wrote: > +static void usbport_trig_activate(struct led_classdev *led_cdev) > +{ > + struct usbport_trig_data *usbport_data; > + int err; > + > + usbport_data = kzalloc(sizeof(*usbport_data), GFP_KERNEL); > + if (!usbport_data)

Re: [GIT PULL] Fixes for v4.8-rc3

2016-08-25 Thread Greg KH
On Thu, Aug 25, 2016 at 12:38:18PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the second round of fixes for v4.8-rc3. Nothing really major this > time, seems like things are already winding down (famous last words). > > Let me know if you want anything to be changed. > > cheers > > The

Re: xhci_hcd crash on linux 4.7.0

2016-08-25 Thread Mathias Nyman
On 29.07.2016 17:41, Alex Damian wrote: On Fri, Jul 29, 2016 at 2:53 PM, Greg KH wrote: On Fri, Jul 29, 2016 at 10:58:03AM +0100, Alex Damian wrote: Hi Greg, I managed to reproduce with a untainted kernel, see dmesg paste below. The stack seemed corrupted as well ? I refered to it as a crash

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-25 Thread Oliver Neukum
On Wed, 2016-08-17 at 15:26 +0200, Oliver Neukum wrote: > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: > > Kernel version: raspberrypi 4.4.6-v7+ #871 > > Driver source file: drivers/usb/class/cdc-acm.c > > Umap2 command line: umap2vsscan -P -s 22b8:2d93 > > Hi, > > could you retest

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-25 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, On Wed, 2016-08-24 at 10:10 -0400, Alan Stern wrote: > On Wed, 24 Aug 2016, Ritesh Raj Sarraf wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > >  > > On Tue, 2016-08-23 at 15:14 -0400, Alan Stern wrote: > > > Okay, go

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-25 Thread Binyamin Sharet (bsharet)
> > On 25 Aug 2016, at 15:59, Oliver Neukum wrote: > > On Wed, 2016-08-17 at 15:26 +0200, Oliver Neukum wrote: >> On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: >>> Kernel version: raspberrypi 4.4.6-v7+ #871 >>> Driver source file: drivers/usb/class/cdc-acm.c >>> Umap2 command line: u

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-25 Thread Oliver Neukum
On Thu, 2016-08-25 at 13:53 +, Binyamin Sharet (bsharet) wrote: > > > It’s a good thing you asked, as I forgot to test this one… > > Just to be sure - which tag should I use for testing this one? > Is v4.4 OK? Yes, perfect. Thanks Oliver -- To unsubscribe from thi

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Alan Stern
On Thu, 25 Aug 2016, Jacek Anaszewski wrote: > I'd see it as follows: > > #cat available_ports > #1-1 1-2 2-1 > > #echo "1-1" > new_port > > #cat observed_ports > #1-1 > > #echo "2-1" > new_port > > #cat observed_ports > #1-1 2-1 > > We've already had few discussions about the sysfs designs

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

2016-08-25 Thread Binyamin Sharet (bsharet)
> On 25 Aug 2016, at 17:24, Oliver Neukum wrote: > > On Thu, 2016-08-25 at 13:53 +, Binyamin Sharet (bsharet) wrote: >>> > >> It’s a good thing you asked, as I forgot to test this one… >> >> Just to be sure - which tag should I use for testing this one? >> Is v4.4 OK? > > Yes, perfect. >

[PATCH] usb-storage: MAINTAINERS: Alan Stern is the new maintainer

2016-08-25 Thread Alan Stern
At Matt Dharm's request, I am taking over maintainership of the usb-storage driver. Signed-off-by: Alan Stern CC: Matthew Dharm --- [as1811] MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: usb-4.x/MAINTAINERS

Re: [PATCH] usb-storage: MAINTAINERS: Alan Stern is the new maintainer

2016-08-25 Thread Matthew Dharm
On Thu, Aug 25, 2016 at 8:30 AM, Alan Stern wrote: > At Matt Dharm's request, I am taking over maintainership of the > usb-storage driver. Alan is being too modest. I think he's been the de facto maintainer already for quite some time; he's certainly much more active with responding to questions

Re: Bug 153551: Kernel panic on Nexus 5X USB unplug while tethering

2016-08-25 Thread Jose Marino
On 08/25/2016 05:09 AM, Mathias Nyman wrote: On 24.08.2016 17:14, Alan Stern wrote: On Wed, 24 Aug 2016, Mathias Nyman wrote: The sleep() worked as it delayed freeing the primary hcd, changing the order to first release usb3 hcd and then usb2 hcd. Does this mean that the patch you already po

[GIT PULL] USB-serial fixes for v4.8-rc4

2016-08-25 Thread Johan Hovold
Hi Greg, Here's a second set of fixes for 4.8-rc. All have been in linux-next. Thanks, Johan The following changes since commit 647024a7df36014bbc4479d92d88e6b77c0afcf6: USB: serial: fix memleak in driver-registration error path (2016-08-08 13:41:17 +0200) are available in the git reposito

Re: usb: chipidea: hdc: kernel panic during shutdown

2016-08-25 Thread Stefan Wahren
Hi, > Peter Chen hat am 25. August 2016 um 11:16 > geschrieben: > > > On Thu, Aug 25, 2016 at 08:27:03AM +0200, Stefan Wahren wrote: > > Am 25.08.2016 um 08:44 schrieb Peter Chen: > > > On Thu, Aug 25, 2016 at 07:06:12AM +0200, Stefan Wahren wrote: > > >> Hi Alan, > > >> > > >> i tried the foll

Re: [PATCH] usb: musb: Fix locking errors for host only mode

2016-08-25 Thread Bin Liu
Hi, On Thu, Aug 18, 2016 at 03:40:38PM -0700, Tony Lindgren wrote: > If we have USB gadgets disabled and USB_MUSB_HOST set, we get > errors "possible irq lock inverssion dependency detected" > errors during boot. > > Let's fix the issue by adding start_musb flag and start > the controller after w

Re: [RFT PATCH v2 2/4] usb: dwc2: Add delay to core soft reset

2016-08-25 Thread Heiko Stübner
Am Mittwoch, 24. August 2016, 16:19:58 schrieb John Youn: > Add a delay to the core soft reset function to account for the IDDIG > debounce filter. > > If the current mode is host, either due to the force mode bit being > set (which persists after core reset) or the connector id pin, a core > soft

[PATCH 01/44] usb: atm: cxacru: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/cxacru.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 18b281d73a39ee..f9fe86b6f7b5b6 100644 --- a/

[PATCH 04/44] usb: atm: usbatm: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/usbatm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c index 5e4f46c5a30046..4dec9df8764b9a 100644 ---

[PATCH 34/44] usb: musb: am35x: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/musb/am35x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c index c41fe588d14d97..c14577dbedf71a 100644 --- a/

[PATCH 44/44] usb: wusbcore: wa-nep: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/wa-nep.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/wusbcore/wa-nep.c b/drivers/usb/wusbcore/wa-nep.c index 6140100ad50e41..ed4622279c63

[PATCH 16/44] usb: host: uhci-hcd: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/uhci-hcd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c index a7de8e8bb4582b..5d3d914ab4fb44 100

[PATCH 40/44] usb: storage: sddr09: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/storage/sddr09.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/usb/storage/sddr09.c b/drivers/usb/storage/sddr09.c index c5797fa2125e94..3ae

[PATCH 12/44] usb: gadget: udc: goku_udc: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/udc/goku_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index d2205d9e0c8b43..1

[PATCH 28/44] usb: misc: lvstest: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/lvstest.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c index 961faae62ea087..af2952b918b843 100644

[PATCH 42/44] usb: wusbcore: crypto: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/crypto.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/crypto.c b/drivers/usb/wusbcore/crypto.c index 33acd1599e99e9..79b2b628066d8

[PATCH 32/44] usb: misc: uss720: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/uss720.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index 256d02da444d0f..356d312add5779 100644 ---

[PATCH 09/44] usb: core: urb: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/urb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c index c601e25b609fb5..a9039696476e68 100644 --- a/driver

[PATCH 14/44] usb: host: fhci-hcd: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/fhci-hcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c index 0960f41f945aba..55a0ae6f2d7430 1006

[PATCH 37/44] usb: renesas_usbhs: mod_host: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/renesas_usbhs/mod_host.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c index

[PATCH 24/44] usb: misc: idmouse: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/idmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c index 5105397e62fc76..2975e80b7a56f9 100644 --- a/drivers/usb/mi

[PATCH 22/44] usb: misc: cytherm: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/cytherm.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers/usb/misc/cytherm.c b/drivers/usb/misc/cytherm.c index 9bab1a3

[PATCH 20/44] usb: misc: appledisplay: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/appledisplay.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index f7c48703347fb7..0b2617fe1c9b6f 100644 --

[PATCH 26/44] usb: misc: ldusb: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/ldusb.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index 84890791c2f830..9ca595632

[PATCH 17/44] usb: host: xhci-tegra: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/xhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c index 0f53ae0f464e6d..d39b37be71f01f 100644 --- a/drive

[PATCH 00/44] usb: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
Here is my next series to save memory by removing unneeded strings. It removes in the usb subsystem all unspecific error messages after calling malloc-based functions, i.e. (devm_)k[zcm]alloc. kmalloc prints enough information in that case. If the message was specific (e.g. "can't save CLEAR_TT_BUF

[PATCH 29/44] usb: misc: trancevibrator: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/trancevibrator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c index 4145314a515b95..9

[PATCH 36/44] usb: renesas_usbhs: mod_gadget: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index

[PATCH 41/44] usb: usb-skeleton: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/usb-skeleton.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c index 89e02a7529b785..5133a0792eb041 1

[PATCH 18/44] usb: host: xhci: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/xhci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 01d96c9b3a75b9..1a4ca02729c274 100644 --- a/dri

[PATCH 05/44] usb: class: usbtmc: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/class/usbtmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 22c235adacb3ad..da4f2509f56775 100644

[PATCH 25/44] usb: misc: iowarrior: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/iowarrior.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 7defa34dd4fa8

[PATCH 13/44] usb: gadget: udc: udc-xilinx: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/udc/udc-xilinx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c index f8bf290f18

[PATCH 38/44] usb: renesas_usbhs: pipe: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/renesas_usbhs/pipe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/renesas_usbhs/pipe.c b/drivers/usb/renesas_usbhs/pipe.c index c238772b9e9e1a..9396

[PATCH 11/44] usb: gadget: udc: fsl_qe_udc: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/gadget/udc/fsl_qe_udc.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c i

[PATCH 43/44] usb: wusbcore: security: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/security.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/security.c b/drivers/usb/wusbcore/security.c index b66faaf3e842e8..8c9421b

[PATCH 10/44] usb: dwc2: gadget: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/dwc2/gadget.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index af46adfae41ca5..2ff03ae08e144d 10064

[PATCH 02/44] usb: atm: speedtch: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/speedtch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/atm/speedtch.c b/drivers/usb/atm/speedtch.c index 0270d1312f834f..5083eb5b0d5ed9 100644 --- a/drivers/usb/at

[PATCH 15/44] usb: host: max3421-hcd: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/host/max3421-hcd.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c index 2f7690092a7ffb..36986

[PATCH 31/44] usb: misc: usbsevseg: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/usbsevseg.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/usbsevseg.c b/drivers/usb/misc/usbsevseg.c index 1fe6b73c22f300..a0ba5298160

[PATCH 03/44] usb: atm: ueagle-atm: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/atm/ueagle-atm.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index f198291630d7dd..df67815f74

[PATCH 33/44] usb: misc: yurex: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/yurex.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/yurex.c b/drivers/usb/misc/yurex.c index bb606bdc25e558..54e53ac4c08fd7 100644 -

[PATCH 27/44] usb: misc: legousbtower: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/legousbtower.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 52b41fb6

[PATCH 23/44] usb: misc: ftdi-elan: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/ftdi-elan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index 45f303c1cc49ef..9beba9748d0f24 100644 --- a/drivers/

[PATCH 39/44] usb: storage: alauda: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/storage/alauda.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index 1d8b03c8103053..878b4b8

[PATCH 21/44] usb: misc: cypress_cy7c63: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/cypress_cy7c63.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/misc/cypress_cy7c63.c b/drivers/usb/misc/cypress_cy7c63.c index 402b94dd253159.

[PATCH 08/44] usb: core: message: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/message.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 0406a59f05510c..5ab5c1a81462b6 100644

[PATCH 19/44] usb: misc: adutux: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/adutux.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index c34a0b6980cdcd..564268fca07a0

[PATCH 30/44] usb: misc: usblcd: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/misc/usblcd.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index 1184390508e983..9f48419abc46b9 1006

[PATCH 35/44] usb: musb: da8xx: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/musb/da8xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index b03d3b867fca2f..3c4dd1658f28db 100644 --- a/

[PATCH 06/44] usb: core: hcd: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/hcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index d2e3f655c26f6c..a0c87b617eddea 100644 --- a/driver

[PATCH 07/44] usb: core: hub: don't print on ENOMEM

2016-08-25 Thread Wolfram Sang
All kmalloc-based functions print enough information on failures. Signed-off-by: Wolfram Sang --- drivers/usb/core/hub.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 1d5fc32d06d007..b48dc76385b652 100644 --- a/

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-25 Thread Alan Stern
Ulf: Ritesh has collected logs showing that his Realtek RTS5129 USB card reader (drivers/mfd/rtsx_usb.c, drivers/mmc/host/rtsx_usb_sdmmc.c) goes into runtime autosuspend every 3 seconds and then immediately resumes. This sounds like something is failing to call pm_runtime_mark_last_busy(). He's

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-25 Thread Hans de Goede
Hi, On 22-08-16 18:10, Bin Liu wrote: On Mon, Aug 22, 2016 at 05:55:50PM +0200, Hans de Goede wrote: Hi, On 22-08-16 17:38, Bin Liu wrote: On Mon, Aug 22, 2016 at 05:32:57PM +0200, Hans de Goede wrote: When switching from host to peripheral mode, if an usb device is still plugged and enu

[PATCH v4 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-25 Thread Hans de Goede
This allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede --- Changes in v2: -No changes Changes in v3: -Fix switch-case code style Changes in v4: -Call musb_root_disconnect() before role change to make sure any attached devices get seen as

Re: [PATCH v3] usb: dwc3: gadget: add remaining sg entries to ring

2016-08-25 Thread John Youn
On 8/25/2016 2:20 AM, Felipe Balbi wrote: > Upon transfer completion after a full ring, let's > add more TRBs to our ring in order to complete our > request successfully. > > Signed-off-by: Felipe Balbi > --- > > Changes since v1: > - none > > Changes since v2: > - fix regression fo

Re: [RESEND PATCH 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-08-25 Thread John Youn
On 8/24/2016 1:54 AM, Randy Li wrote: > > > On 08/24/2016 04:46 AM, John Youn wrote: >> On 8/21/2016 12:32 PM, Randy Li wrote: >>> On the rk3288 USB host-only port (the one that's not the OTG-enabled >>> port) the PHY can get into a bad state when a wakeup is asserted (not >>> just a wakeup from

Re: [PATCH v2 4/6] usb: dwc3: gadget: add remaining sg entries to ring

2016-08-25 Thread John Youn
On 8/25/2016 12:45 AM, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: >>> On your testing/next, I see considerable slow down and file >>> corruption in mass storage. >>> >>> After bisecting, this patch seems to be the first one that shows >>> problems. The device fails even enumeration her

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Jacek Anaszewski
On 08/25/2016 04:30 PM, Alan Stern wrote: On Thu, 25 Aug 2016, Jacek Anaszewski wrote: I'd see it as follows: #cat available_ports #1-1 1-2 2-1 #echo "1-1" > new_port #cat observed_ports #1-1 #echo "2-1" > new_port #cat observed_ports #1-1 2-1 We've already had few discussions about the s

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Bjørn Mork
Greg KH writes: > On Thu, Aug 25, 2016 at 07:14:52AM +0200, Rafał Miłecki wrote: >> >> Good question. I would like to extend this USB port trigger in the >> future by reacting to USB activity. This involves playing with URBs >> and I believe that at that point it'd be getting too much USB specific

Re: [RFT PATCH v2 3/4] usb: dwc2: Properly account for the force mode delays

2016-08-25 Thread John Youn
On 8/25/2016 3:01 AM, Heiko Stübner wrote: > Hi John, > > Am Mittwoch, 24. August 2016, 16:20:01 schrieb John Youn: >> When a force mode bit is set and the IDDIG debounce filter is enabled, >> there is a delay for the forced mode to take effect. This delay is due >> to the IDDIG debounce filter an

  1   2   >