Re: [PATCH] usb: core: Add runtime resume checking

2016-08-11 Thread Peter Chen
On Thu, Aug 11, 2016 at 11:08:52AM +0800, Baolin Wang wrote: > Hi Alan, > > On 10 August 2016 at 22:25, Alan Stern wrote: > > On Wed, 10 Aug 2016, Baolin Wang wrote: > > > >> >> >> For example: No slave attached> usb interface runtime suspend > >> >> >> > usb device runtime suspend ->

Re: [PATCH v2] usb: core: Add runtime resume checking in choose_wakeup()

2016-08-11 Thread Peter Chen
On Thu, Aug 11, 2016 at 11:11:08AM +0800, Baolin Wang wrote: > On 10 August 2016 at 22:31, Alan Stern wrote: > > On Wed, 10 Aug 2016, Baolin Wang wrote: > > > >> Considering strict power management for mobile device, we should also power > >> off the usb controller if there are no slaves attached

Re: [PATCH V2] usb: chipidea: udc: Use direction flags consequently

2016-08-11 Thread Peter Chen
On Wed, Aug 10, 2016 at 05:58:26PM +0200, Stefan Wahren wrote: > > >I have already queued it at local tree for testing, and make > >the similar changes: > > > > > >commit c95b4427b7328b2618ca70fea65de0427f5d5734 > >Author: Stefan Wahren > >Date: Sat Jul 9 14:16:40 2016 + > > > >usb: chi

Re: [PATCH 3/3] usb: gadget: u_ether: fix dereference after null check coverify warning

2016-08-11 Thread Peter Chen
On Wed, Aug 10, 2016 at 02:20:18PM +0300, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Fri, Jul 01, 2016 at 03:33:30PM +0800, Peter Chen wrote: > >> skb is checked for null pointer at above code, so skb might be null. > >> eem_wrap uses it without checking null pointer, fix it by ad

Re: [PATCH v2] usb: core: Add runtime resume checking in choose_wakeup()

2016-08-11 Thread Baolin Wang
Hi Peter, On 11 August 2016 at 14:52, Peter Chen wrote: > On Thu, Aug 11, 2016 at 11:11:08AM +0800, Baolin Wang wrote: >> On 10 August 2016 at 22:31, Alan Stern wrote: >> > On Wed, 10 Aug 2016, Baolin Wang wrote: >> > >> >> Considering strict power management for mobile device, we should also >

Re: [PATCH v4 2/3] usbip: vhci extension: modifications to userspace

2016-08-11 Thread Greg KH
On Wed, Aug 10, 2016 at 07:25:09AM +, fx IWATA NOBUO wrote: > Dear Greg, > > I remembered the dependency. > > --- from the cover letter --- > 5. Dependencies > > This series depends on 'usbip: exporting devices' patch set because this > includes changes to application side daemon which intro

[PATCH v2 1/4] usb: gadget: composite: fix dereference after null check coverify warning

2016-08-11 Thread Peter Chen
cdev->config is checked for null pointer at above code, so cdev->config might be null, fix it by adding null pointer check. Signed-off-by: Peter Chen --- drivers/usb/gadget/composite.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/compo

[PATCH v2 0/4] usb: gadget: fix several coverity warnings

2016-08-11 Thread Peter Chen
Hi Felipe, Below patches are fixes for warning which are found during coverity code scan. Changes for v2: - Drop the patch 3/3 in v1 which will break ncm function due to its socket buffer may be NULL. - Add patch 3/4 and patch 4/4 for individual function drivers which do not check null pointe

[PATCH v2 4/4] usb: gadget: function: f_rndis: socket buffer may be NULL

2016-08-11 Thread Peter Chen
In eth_start_xmit, the socket buffer may be NULL. So, add NULL pointer check at .wrap API. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/f_rndis.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/function/f_rndis.c b/drivers/usb/gadget/function/f_rndis.c ind

[PATCH v2 3/4] usb: gadget: function: f_eem: socket buffer may be NULL

2016-08-11 Thread Peter Chen
In eth_start_xmit, the socket buffer may be NULL. So, add NULL pointer check at .wrap API. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/f_eem.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/function/f_eem.c b/drivers/usb/gadget/fu

[PATCH v2 2/4] usb: gadget: u_ether: fix dereference after null check coverify warning

2016-08-11 Thread Peter Chen
dev->port_usb is checked for null pointer at above code, so dev->port_usb might be null, fix it by adding null pointer check. Signed-off-by: Peter Chen --- drivers/usb/gadget/function/u_ether.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_et

Re: [PATCH] usb: core: Add runtime resume checking

2016-08-11 Thread Baolin Wang
Hi Peter, On 11 August 2016 at 14:54, Peter Chen wrote: > On Thu, Aug 11, 2016 at 11:08:52AM +0800, Baolin Wang wrote: >> Hi Alan, >> >> On 10 August 2016 at 22:25, Alan Stern wrote: >> > On Wed, 10 Aug 2016, Baolin Wang wrote: >> > >> >> >> >> For example: No slave attached> usb interface r

Re: [PATCH] usb: core: Add runtime resume checking

2016-08-11 Thread Peter Chen
On Thu, Aug 11, 2016 at 04:07:21PM +0800, Baolin Wang wrote: > Hi Peter, > > On 11 August 2016 at 14:54, Peter Chen wrote: > > On Thu, Aug 11, 2016 at 11:08:52AM +0800, Baolin Wang wrote: > >> Hi Alan, > >> > >> On 10 August 2016 at 22:25, Alan Stern wrote: > >> > On Wed, 10 Aug 2016, Baolin Wan

Re: [PATCH 2/4] usb: gadget: f_midi: defaults buflen sizes to 512

2016-08-11 Thread Felipe Ferreri Tonello
Hi Balbi, On 10/08/16 12:25, Felipe Balbi wrote: > > Hi, > > "Felipe F. Tonello" writes: >> 512 is the value used by wMaxPacketSize, as specified by the USB Spec. This > > this is only true for HS :-) FS and SS use different sizes. Do you want > to use 1024 (SS maxp) by default instead? Then a

Re: [PATCH 1/4] usb: gadget: f_midi: fixed endianness when using wMaxPacketSize

2016-08-11 Thread Felipe Ferreri Tonello
Hi Balbi, On 10/08/16 12:24, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> On 26 July 2016 at 07:15, Felipe F. Tonello wrote: >>> USB spec specifies wMaxPacketSize to be little endian (as other properties), >>> so when using this variable in the driver we should convert to the current

Re: [PATCH] usb: core: Add runtime resume checking

2016-08-11 Thread Baolin Wang
On 11 August 2016 at 16:19, Peter Chen wrote: > On Thu, Aug 11, 2016 at 04:07:21PM +0800, Baolin Wang wrote: >> Hi Peter, >> >> On 11 August 2016 at 14:54, Peter Chen wrote: >> > On Thu, Aug 11, 2016 at 11:08:52AM +0800, Baolin Wang wrote: >> >> Hi Alan, >> >> >> >> On 10 August 2016 at 22:25, Al

Re: [PATCH] usb: core: Add runtime resume checking

2016-08-11 Thread Peter Chen
On Thu, Aug 11, 2016 at 04:41:27PM +0800, Baolin Wang wrote: > >> >> > >> >> OK. But that is a real problem. It will pm_runtime_resume() falied > >> >> (issued in choose_wakeup()), cause usb controller has powered-off and > >> >> xHCI controller has suspended and we have no method to notify the use

Re: [PATCH] usb: core: Add runtime resume checking

2016-08-11 Thread Baolin Wang
On 11 August 2016 at 16:44, Peter Chen wrote: > On Thu, Aug 11, 2016 at 04:41:27PM +0800, Baolin Wang wrote: >> >> >> >> >> >> OK. But that is a real problem. It will pm_runtime_resume() falied >> >> >> (issued in choose_wakeup()), cause usb controller has powered-off and >> >> >> xHCI controller

[PATCH 1/3] usb: dwc3: gadget: retire LST bit completely

2016-08-11 Thread Felipe Balbi
The only endpoint which actually requires LST bit and XferComplete is ep0/1. Let's save some time by completely removing LST bit support and XferComplete. This simplifies and consolidates endpoint handling for all other 3 transfer types while also avoiding extra interrupts. Signed-off-by: Felipe

[PATCH 3/3] usb: dwc3: gadget: simplify dwc3_ep_prev_trb()

2016-08-11 Thread Felipe Balbi
We always need to decrement our index by at least one. Simplify the implementation by using a temporary local variable and making sure that we will always decrement one extra if tmp == 0. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 10 +- 1 file changed, 5 insertions(+),

[PATCH 2/3] usb: dwc3: gadget: increment dequeue pointer on completion

2016-08-11 Thread Felipe Balbi
Instead of waiting until giveback before incrementing the dequeue pointer, we can increment it from dwc3_cleanup_done_reqs(), that way we avoid an extra loop over all TRBs during giveback. While at that, also avoid using req->first_trb_index as that's completely unnecessary. A follow-up patch will

[PATCH] usb: chipidea: udc: don't touch DP when controller is in host mode

2016-08-11 Thread Li Jun
When the controller is configured to be dual role and it's in host mode, if bind udc and gadgt driver, those gadget operations will do gadget disconnect and finally pull down DP line, which will break host function. Signed-off-by: Li Jun --- drivers/usb/chipidea/udc.c | 7 +-- 1 file changed

Re: [RESEND PATCH v5 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-08-11 Thread Linus Walleij
On Fri, Jul 22, 2016 at 12:33 PM, Martyn Welch wrote: > This patch adds support for the GPIO found on the CP2105. Unlike the GPIO > provided by some of the other devices supported by the cp210x driver, the > GPIO on the CP2015 is muxed on pins otherwise used for serial control > lines. The GPIO h

[PATCH 2/2] usb: dwc3: gadget: avoid while (1) loop on completion

2016-08-11 Thread Felipe Balbi
We know that we have to iterate over the list of started requests. Instead of looping forever, we can rely on list_for_each_entry(). Likewise, instead of a do {} while loop over all, maybe available, scatterlist entries, we can detect if $this request uses scatterlist and rely on for_each_sg(). Th

[PATCH 1/2] usb: dwc3: gadget: simplify __dwc3_gadget_ep_queue()

2016-08-11 Thread Felipe Balbi
Many of the comments in that function are really outdated and don't match what the driver is doing. Moreover, recent patches combined programming model for all non-control endpoints, this gives us an opportunity to get rid of our special cases in __dwc3_gadget_ep_queue(). Signed-off-by: Felipe Bal

[GIT PULL] usb: fixes for v4.8-rc2

2016-08-11 Thread Felipe Balbi
Hi Greg, here's the first series of fixes for current -rc cycle. Patches have been in mainling list for a while. I've tested important patches with SKL and BXT devices. Let me know if you want anything to be changed. cheers The following changes since commit 29b4817d4018df78086157ea3a55c1d942

Re: [PATCH] usb: dwc2: Add reset control to dwc2

2016-08-11 Thread Dinh Nguyen
On 08/09/2016 02:05 PM, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > Allow for platforms that have a reset controller driver in place to bring > the USB IP out of reset. > > Signed-off-by: Dinh Nguyen > Acked-by: John Youn > Tested-by: Stefan Wahren > --- > Hi Felipe, > >

Re: [GIT PULL] usb: fixes for v4.8-rc2

2016-08-11 Thread Greg Kroah-Hartman
On Thu, Aug 11, 2016 at 03:17:53PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the first series of fixes for current -rc cycle. Patches have > been in mainling list for a while. I've tested important patches with > SKL and BXT devices. Let me know if you want anything to be changed. Now

[PATCH 3/3] ARM: dts: imx6q-evi: Fix onboard hub reset line

2016-08-11 Thread Joshua Clayton
Previously the onboard hub was made to work by treating its reset gpio as a regulator enable. Get rid of that kludge now that pwseq has added reset gpio support Move pin muxing the hub reset pin into the usbh1 group Signed-off-by: Joshua Clayton --- arch/arm/boot/dts/imx6q-evi.dts | 25 +++--

[PATCH 2/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2016-08-11 Thread Joshua Clayton
From: Peter Chen The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Signed-off-by: Peter Chen Signed-off-by: Joshua Clayton --- arch/arm/boot/dts/imx6qdl

[PATCHES] ARM: dts: update udoo and evi hubs to use pwrseq

2016-08-11 Thread Joshua Clayton
Hi Peter, Consider this my attempt to squeeze my own dts into your patch series. These patches repalce patch 6 in V5. of the usb pwrseq series I adding a #address and #size to imx6qdl.dtsi in patch 1 and remove those lines from imx6qdl-udoo.dtsi in patch 2 (formerly patch 6) Finally I make the ch

[PATCH 1/3] ARM: dts: imx6qdl: Enable usb node children with

2016-08-11 Thread Joshua Clayton
Give usb nodes #address and #size attributes, so that a child node representing a permanently connected device such as an onboard hub may be addressed with a attribute Signed-off-by: Joshua Clayton --- arch/arm/boot/dts/imx6qdl.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch

Re: Erratic USB device behavior and device loss

2016-08-11 Thread Alan Stern
On Thu, 11 Aug 2016, Ritesh Raj Sarraf wrote: > Hello Alan, > > > On Wed, 2016-08-10 at 17:20 -0400, Alan Stern wrote: > > On Wed, 10 Aug 2016, Ritesh Raj Sarraf wrote: > > > > The device was disconnected electronically. > > > > How often does this happen?  After the disconnect occurs, does th

[PATCH V3] usb: chipidea: udc: Use direction flags consequently

2016-08-11 Thread Stefan Wahren
This driver make assumptions about the value of the direction flags. So better use them in comparisons to improve the readability. Signed-off-by: Stefan Wahren --- drivers/usb/chipidea/udc.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) Changes in V3: - always

Re: Erratic USB device behavior and device loss

2016-08-11 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Thu, 2016-08-11 at 13:01 -0400, Alan Stern wrote: > > I guess so. I get frequent resets on my USB port for some of the hardware. > >  > > kernel: usb 2-1: reset high-speed USB device number 17 using xhci_hcd > >  > > I initially thought of this to

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-11 Thread Tony Lindgren
* Andreas Kemnade [160808 22:36]: > Calls to musb_platform_enable() occur at only 1 place. > musb_platform_disable() is called at 4 places. > > about balancing: > There is musb_start() and musb_stop(). They are called from > musb_gadget_start/stop() > These call musb_platform_enable() and musb_pl

USB Networking

2016-08-11 Thread Patrick Doyle
I have two embedded Linux devices connected via USB. Both show usb0 devices. One shows the network as RUNNING: device1# ifconfig usb0 usb0 Link encap:Ethernet HWaddr 96:2E:28:4C:23:7C inet addr:192.168.186.2 Bcast:192.168.186.255 Mask:255.255.255.0 UP BROADCAST RUNNIN

Re: Slow writes with dd on Lexar JumpDrive P20 64GB flash drives connected via Intel USB 3.0 host controllers

2016-08-11 Thread Alan Stern
On Tue, 31 May 2016, Michael Schaller wrote: > Is there anything else I can do to debug this issue further? > Are there any quirks I could try? > > On Wed, May 18, 2016 at 3:41 PM, Michael Schaller wrote: > > [1.] One line summary of the problem: > > Slow writes with dd on Lexar JumpDrive P20 64

Re: mceusb xhci issue?

2016-08-11 Thread Alan Stern
I never received any replies to this message. Should the patch I suggested be merged? Alan Stern On Tue, 12 Jul 2016, Alan Stern wrote: > On Sat, 9 Jul 2016, Mauro Carvalho Chehab wrote: > > > C/C linux-usb Mailing list: > > > > > > Em Wed, 18 May 2016 08:52:28 -0600 > > Wade Berrier escr

[PATCH] ALSA: usb: caiaq: audio: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- sound/usb/caiaq/audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c index 327f8642ca80e6..8f66ba730d69d9 100644 --- a/sound/usb/caiaq/audio.c +++ b/s

[PATCH] ALSA: usb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
From: Wolfram Sang This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approac

[PATCH] bluetooth: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
From: Wolfram Sang This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approac

[PATCH] bluetooth: bcm203x: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
From: Wolfram Sang kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/bluetooth/bcm203x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c index 5b0ef7bbe8ac87..5ce6d4

[PATCH] bluetooth: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approach when we talked abou

[PATCH] bluetooth: bcm203x: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/bluetooth/bcm203x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c index 5b0ef7bbe8ac87..5ce6d4176dc302 100644 --- a

Re: [PATCH] bluetooth: bcm203x: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
On Thu, Aug 11, 2016 at 10:51:34PM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > kmalloc will print enough information in case of failure. > > Signed-off-by: Wolfram Sang Sorry for the noise. This one was sent from the wrong email address :( signature.asc Description: PGP signature

[PATCH] mmc: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approach when we talked abou

[PATCH] mmc: host: vub300: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/mmc/host/vub300.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index 1e819f98b94f52..bb3e0d1dd35501 100644 --- a/drivers/mmc/host/vub300

[PATCH] uwb: hwa-rc: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/uwb/hwa-rc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/uwb/hwa-rc.c b/drivers/uwb/hwa-rc.c index 0257f35cfb9d01..0aa6c3c29d1726 100644 --- a/drivers/uwb/hwa-rc.c

[PATCH] uwb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approach when we talked abou

[PATCH 00/28] media: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approach when we talked abou

[PATCH 01/28] media: dvb-frontends: rtl2832_sdr: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/dvb-frontends/rtl2832_sdr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-frontends/rtl2832_sdr.c index 6e22af36b637b7..e038

[PATCH 24/28] media: usb: stkwebcam: stk-webcam: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/stkwebcam/stk-webcam.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c index c21

[PATCH 21/28] media: usb: pwc: pwc-if: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/pwc/pwc-if.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c index b51b27a3fd6108..c4454c928776f7 100644 --- a/drivers/me

[PATCH 14/28] media: usb: em28xx: em28xx-core: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/em28xx/em28xx-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c index 37456079f490d9..eebd5d7088d00

[PATCH 03/28] media: rc: imon: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/rc/imon.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c index 65f80b8b9f7ab9..86cc70fe25348f 100644 --- a

[PATCH 27/28] media: usb: usbvision: usbvision-core: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/usbvision/usbvision-core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-cor

[PATCH 28/28] media: usb: zr364xx: zr364xx: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/zr364xx/zr364xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/zr364xx/zr364xx.c b/drivers/media/usb/zr364xx/zr364xx.c index 7433ba5c4bad8b..cc

[PATCH 12/28] media: usb: dvb-usb: dib0700_core: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/dvb-usb/dib0700_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c index bf8

[PATCH 20/28] media: usb: msi2500: msi2500: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/msi2500/msi2500.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c index e7f167d44c61ce..367eb7e2a31dbc 100644

[PATCH 13/28] media: usb: em28xx: em28xx-audio: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/em28xx/em28xx-audio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-audio.c b/drivers/media/usb/em28xx/em28xx-audio.c index 49a5f9532bd8d8..78f3687772

[PATCH 25/28] media: usb: tm6000: tm6000-dvb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/tm6000/tm6000-dvb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/tm6000/tm6000-dvb.c b/drivers/media/usb/tm6000/tm6000-dvb.c index 095f5db1a790

[PATCH 18/28] media: usb: hackrf: hackrf: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/hackrf/hackrf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c index b1e229a44192d3..c2c8d12e949868 100644 --- a/

[PATCH 22/28] media: usb: s2255: s2255drv: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/s2255/s2255drv.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index 43ba71a7d02b8f.

[PATCH 11/28] media: usb: cx231xx: cx231xx-vbi: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/cx231xx/cx231xx-vbi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-vbi.c b/drivers/media/usb/cx231xx/cx231xx-vbi.c index 15bb573b78ac82..76e90192

[PATCH 08/28] media: usb: cpia2: cpia2_usb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/cpia2/cpia2_usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c index c1aa1ab2ece9ff..13620cdf05996f 100644

[PATCH 06/28] media: usb: as102: as102_usb_drv: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/as102/as102_usb_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/as102/as102_usb_drv.c b/drivers/media/usb/as102/as102_usb_drv.c index 0e8030c071b8e7..68c3a80c

[PATCH 03/19] usb: atm: usbatm: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/atm/usbatm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c index db322d9ccb6e59..5e4f46c5a30046 100644 --- a/drivers/usb/atm/usbatm.c +++

[PATCH 17/19] usb: usbip: stub_rx: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/usbip/stub_rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/usbip/stub_rx.c b/drivers/usb/usbip/stub_rx.c index 2df63e305722e4..191b176ffedfda 100644 --- a/drivers/usb/usbip/s

[PATCH 07/28] media: usb: au0828: au0828-video: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/au0828/au0828-video.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index 82b02698586835..13b8387082

[PATCH 02/16] net: can: usb: esd_usb2: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/can/usb/esd_usb2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c index 784a9002fbb930..be928ce62d32e0 100644 --- a/drivers

[PATCH 15/28] media: usb: gspca: benq: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/gspca/benq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/gspca/benq.c b/drivers/media/usb/gspca/benq.c index 790baed339639d..5fa67b78ad49b1 100

[PATCH 19/28] media: usb: hdpvr: hdpvr-video: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/hdpvr/hdpvr-video.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c index 2a3a8b470555

[PATCH 01/16] net: can: usb: ems_usb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/can/usb/ems_usb.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c index 71f0e791355b9c..b3d02759c226bb

[PATCH 09/16] net: usb: usbnet: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/usb/usbnet.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 3bfb592093263b..d5071e364d40e1 100644 --- a/drivers

[PATCH 09/28] media: usb: cx231xx: cx231xx-audio: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/cx231xx/cx231xx-audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-audio.c b/drivers/media/usb/cx231xx/cx231xx-audio.c index a6a9508418f8ee..4c

[PATCH 00/16] net: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses kmalloc which already prints enough information on failure. So, let's simply remove those "allocation failed" messages from drivers like we did already for other -ENOMEM cases. gkh acked this approach when we talked abou

[PATCH 17/28] media: usb: gspca: konica: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/gspca/konica.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/gspca/konica.c b/drivers/media/usb/gspca/konica.c index 0712b1bc90b4dd..409c5f30

[PATCH 05/28] media: usb: airspy: airspy: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/airspy/airspy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c index fe031b06935fbb..3c556ee306cd33 100644 --- a/

[PATCH 10/28] media: usb: cx231xx: cx231xx-core: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/cx231xx/cx231xx-core.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c index 630f4fc5155f12..8ec

[PATCH 12/16] net: wireless: broadcom: brcm80211: brcmfmac: usb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wirel

[PATCH 04/19] usb: class: usbtmc: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/class/usbtmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 917a55c4480dc4..22c235adacb3ad 100644 --- a/dr

[PATCH 01/19] usb: atm: cxacru: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/atm/cxacru.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 0a866e90b49c80..18b281d73a39ee 100644 --- a/drivers/usb/atm/cxacru.c +

[PATCH 18/19] usb: wusbcore: wa-nep: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/wa-nep.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/wa-nep.c b/drivers/usb/wusbcore/wa-nep.c index 60a10d21947d46..6140100ad50e41 100644

[PATCH 23/28] media: usb: stk1160: stk1160-video: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/stk1160/stk1160-video.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c index

[PATCH 15/19] usb: storage: usb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/storage/usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c index ef2d8cde6ef700..719f089dd891bd 100644 --- a/drive

[PATCH 06/19] usb: misc: appledisplay: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/misc/appledisplay.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index a0a3827b4aff75..f7c48703347fb7 100644 --- a/drivers

[PATCH 19/19] usb: wusbcore: wa-xfer: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/wusbcore/wa-xfer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 69af4fd9e07220..167fcc71f5f6e9 100

[PATCH 12/19] usb: misc: sisusbvga: sisusb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/misc/sisusbvga/sisusb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c index 02abfcdfbf7bc8..05bd39d6256819 1006

[PATCH 07/19] usb: misc: ftdi-elan: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/misc/ftdi-elan.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index 52c27cab78c3e4..c0c00e7f989e

[PATCH 16/28] media: usb: gspca: gspca: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/usb/gspca/gspca.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c index b17bd7ebcb47f7..af2395a76d8bf9

[PATCH 04/16] net: can: usb: kvaser_usb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/can/usb/kvaser_usb.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c index 6f1f3b675ff553..d51e0c401

[PATCH 08/19] usb: misc: iowarrior: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/misc/iowarrior.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 1950e87b421904..7defa34dd4fa8b 100644

[PATCH 02/28] media: radio: si470x: radio-si470x-usb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/media/radio/si470x/radio-si470x-usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio-si470x-usb.c index 091d793f

[PATCH 09/19] usb: misc: ldusb: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/misc/ldusb.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index cce22ff1c2eb42..84890791c2f830 100644 --- a/dri

[PATCH 07/16] net: usb: hso: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/usb/hso.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 4b4458616693f9..c5544d36c54f96 100644 ---

[PATCH 05/16] net: can: usb: peak_usb: pcan_usb_core: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_co

[PATCH 02/19] usb: atm: ueagle-atm: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/atm/ueagle-atm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 4333dc576a1232..f198291630d7dd 100644 --

[PATCH 05/19] usb: misc: adutux: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/usb/misc/adutux.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index 3071c0ef909bf0..c34a0b6980cdcd 100644 --- a/

[PATCH 08/16] net: usb: lan78xx: don't print error when allocating urb fails

2016-08-11 Thread Wolfram Sang
kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang --- drivers/net/usb/lan78xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 6a9d474b08b21c..432b8a3ae35491 100644 --- a/drive

  1   2   >