Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support

2016-07-18 Thread Felipe Balbi
Hi, Bin Gao writes: >> > +int pd_sink_queue_msg(struct pd_sink_msg *msg) >> > +{ >> > + unsigned long flags; >> > + struct pd_sink_port *port; >> > + >> > + if (msg->port < 0 || msg->port >= MAX_NR_SINK_PORTS) { >> > + pr_err("Invalid port number\n"); >> > + return -EINVAL;

Re: [PATCH 2/2] usb: chipidea: usbmisc: set over current polarity for imx6 and imx7

2016-07-18 Thread Peter Chen
On Mon, Jul 18, 2016 at 07:04:57AM +, Jun Li wrote: > Hi Peter, > > > -Original Message- > > From: Peter Chen [mailto:hzpeterc...@gmail.com] > > Sent: Friday, July 15, 2016 5:21 PM > > To: Jun Li > > Cc: Peter Chen ; linux-usb@vger.kernel.org > > Subject: Re: [PATCH 2/2] usb: chipidea

Re: [PATCH v7 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-07-18 Thread Frank Wang
Hi Heiko, On 2016/6/25 3:58, Heiko Stuebner wrote: Am Dienstag, 21. Juni 2016, 18:30:05 schrieb Frank Wang: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is requir

RE: [PATCH 2/2] usb: chipidea: usbmisc: set over current polarity for imx6 and imx7

2016-07-18 Thread Jun Li
Hi Peter, > -Original Message- > From: Peter Chen [mailto:hzpeterc...@gmail.com] > Sent: Friday, July 15, 2016 5:21 PM > To: Jun Li > Cc: Peter Chen ; linux-usb@vger.kernel.org > Subject: Re: [PATCH 2/2] usb: chipidea: usbmisc: set over current polarity > for imx6 and imx7 > > On Fri, Ju

[PATCH 1/4] doc: usb: usbmisc-imx: add imx7d compatible string

2016-07-18 Thread Li Jun
Add compatible string for imx7d-usbmisc. Signed-off-by: Li Jun --- Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt index 3539d4

Re: [PATCH v7 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-07-18 Thread Heiko Stübner
Hi Frank, Am Montag, 18. Juli 2016, 18:02:28 schrieb Frank Wang: > On 2016/6/25 3:58, Heiko Stuebner wrote: > > Am Dienstag, 21. Juni 2016, 18:30:05 schrieb Frank Wang: > >> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > >> than rk3288 and before, and most of phy-related regis

[PATCH 4/4] usb: chipidea: imx: set over current polarity per dts setting

2016-07-18 Thread Li Jun
With over-current-polarity property added, imx usb over current polarity can be configed to be low or high active, since the default setting value(0) is for active high, so keep this setting for those legacy platforms without this property specified. Signed-off-by: Li Jun --- drivers/usb/chipide

[PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Kristian Evensen
The firmware in the ZTE MF823/831/910 modems/mifis use OS fingerprinting to determine which type of device to export. In addition, these devices export a REST API which can also be used to control the type of device. So far, on Linux, the devices have been seen as RNDIS or CDC Ether. When CDC Ethe

drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?

2016-07-18 Thread David Binderman
Hello there, drivers/usb/usbip/vudc_rx.c:145:27: warning: result of ‘11 << 30’ requires 35 bits to represent, but ‘int’ only has 32 bits [-Wshift-overflow=] Source code is urb_p->urb->pipe &= ~(11 << 30); Maybe better code urb_p->urb->pipe &= ~(11UL << 30); Regards David Binderman --

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Oliver Neukum
On Mon, 2016-07-18 at 14:24 +0200, Kristian Evensen wrote: > The firmware in the ZTE MF823/831/910 modems/mifis use OS fingerprinting to > determine which type of device to export. In addition, these devices export > a REST API which can also be used to control the type of device. So far, on > Linu

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Kristian Evensen
Hi, On Mon, Jul 18, 2016 at 3:01 PM, Oliver Neukum wrote: > On Mon, 2016-07-18 at 14:24 +0200, Kristian Evensen wrote: >> The firmware in the ZTE MF823/831/910 modems/mifis use OS fingerprinting to >> determine which type of device to export. In addition, these devices export >> a REST API which

[PATCH 2/4] doc: usb: ci-hdrc-usb2: add property over-current-polarity

2016-07-18 Thread Li Jun
Adding over-current-polarity to indicate the over current flag is low active or high active. Signed-off-by: Li Jun --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentat

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Oliver Neukum
On Mon, 2016-07-18 at 15:23 +0200, Kristian Evensen wrote: > Hi, > > On Mon, Jul 18, 2016 at 3:01 PM, Oliver Neukum wrote: > > On Mon, 2016-07-18 at 14:24 +0200, Kristian Evensen wrote: > >> The firmware in the ZTE MF823/831/910 modems/mifis use OS fingerprinting to > >> determine which type of d

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Kristian Evensen
On Mon, Jul 18, 2016 at 3:50 PM, Oliver Neukum wrote: > No, you misunderstand me. I don't want quirks if we can avoid it. > But if you need to do this for rndis_host and cdc_ether and maybe other > drivers you should not be touching drivers. This belongs into the core > ethernet code. Your code is

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Oliver Neukum
On Mon, 2016-07-18 at 16:10 +0200, Kristian Evensen wrote: > On Mon, Jul 18, 2016 at 3:50 PM, Oliver Neukum wrote: > > No, you misunderstand me. I don't want quirks if we can avoid it. > > But if you need to do this for rndis_host and cdc_ether and maybe other > > drivers you should not be touchin

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Kristian Evensen
On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum wrote: >> Ok, sounds good. So far, I have only seen the random MAC issue with >> the three previously mentioned devices, but who knows how many else is >> out there with the same error ... I don't think it should be in the >> core ethernet code, at le

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Kristian Evensen
On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum wrote: >> Ok, sounds good. So far, I have only seen the random MAC issue with >> the three previously mentioned devices, but who knows how many else is >> out there with the same error ... I don't think it should be in the >> core ethernet code, at le

Re: [PATCH 2/4] doc: usb: ci-hdrc-usb2: add property over-current-polarity

2016-07-18 Thread Joshua Clayton
Greetings, On 07/18/2016 04:15 AM, Li Jun wrote: > Adding over-current-polarity to indicate the over current flag > is low active or high active. > > Signed-off-by: Li Jun > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Doc

Re: Fwd: USB HID problem

2016-07-18 Thread Bruce Korb
On Sun, Jul 17, 2016 at 12:43 PM, Alan Stern wrote: > A USB-3.1 device should work okay with a USB-3 driver. However, it > would help if you upgrade to the latest available kernel version. It is the latest available openSUSE release. I've downloaded the latest Slackware release. I'll try it la

[PATCH 3/4] ARM: dts: imx7d-sdb: Set OTG2 oc polarity to be active low

2016-07-18 Thread Li Jun
Set OTG2 over current flag to be active low, OTG1 OC is not used by default. Signed-off-by: Li Jun --- arch/arm/boot/dts/imx7d-sdb.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts index b267f79..44ed399 100644 --- a

Re: Fwd: USB HID problem

2016-07-18 Thread Alan Stern
On Mon, 18 Jul 2016, Bruce Korb wrote: > On Sun, Jul 17, 2016 at 12:43 PM, Alan Stern > wrote: > > A USB-3.1 device should work okay with a USB-3 driver. However, it > > would help if you upgrade to the latest available kernel version. > > It is the latest available openSUSE release. The rele

Re: Fwd: USB HID problem

2016-07-18 Thread Bruce Korb
On Mon, Jul 18, 2016 at 2:24 PM, Alan Stern wrote: > This is not surprising, because the problem probably stems from the > xHCI host controller in your computer, not from the hub. Gigabyte is supposed to make reliable motherboards. Haven't been trying to use USB3 until now, but still Given t

Re: Fwd: USB HID problem

2016-07-18 Thread Alan Stern
On Mon, 18 Jul 2016, Bruce Korb wrote: > On Mon, Jul 18, 2016 at 2:24 PM, Alan Stern wrote: > > This is not surprising, because the problem probably stems from the > > xHCI host controller in your computer, not from the hub. > > Gigabyte is supposed to make reliable motherboards. > Haven't been

Re: [PATCH 2/4] doc: usb: ci-hdrc-usb2: add property over-current-polarity

2016-07-18 Thread Peter Chen
On Mon, Jul 18, 2016 at 08:24:50AM -0700, Joshua Clayton wrote: > Greetings, > On 07/18/2016 04:15 AM, Li Jun wrote: > > Adding over-current-polarity to indicate the over current flag > > is low active or high active. > > > > Signed-off-by: Li Jun > > --- > > Documentation/devicetree/bindings/usb

Re: [PATCH 4/4] usb: chipidea: imx: set over current polarity per dts setting

2016-07-18 Thread Peter Chen
On Mon, Jul 18, 2016 at 07:15:47PM +0800, Li Jun wrote: > With over-current-polarity property added, imx usb over current > polarity can be configed to be low or high active, since the default > setting value(0) is for active high, so keep this setting for those > legacy platforms without this prop

Re: [PATCH 4/4] usb: chipidea: imx: set over current polarity per dts setting

2016-07-18 Thread Peter Chen
On Tue, Jul 19, 2016 at 02:31:41AM +, Jun Li wrote: > Hi > > > -Original Message- > > From: Peter Chen [mailto:hzpeterc...@gmail.com] > > Sent: Tuesday, July 19, 2016 9:57 AM > > To: Jun Li > > Cc: Peter Chen ; robh...@kernel.org; > > shawn...@kernel.org; devicet...@vger.kernel.org; l

RE: [PATCH 4/4] usb: chipidea: imx: set over current polarity per dts setting

2016-07-18 Thread Jun Li
Hi > -Original Message- > From: Peter Chen [mailto:hzpeterc...@gmail.com] > Sent: Tuesday, July 19, 2016 9:57 AM > To: Jun Li > Cc: Peter Chen ; robh...@kernel.org; > shawn...@kernel.org; devicet...@vger.kernel.org; linux-usb@vger.kernel.org; > linux-arm-ker...@lists.infradead.org > Subje

Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support

2016-07-18 Thread Bin Gao
On Sat, Jul 16, 2016 at 08:49:53AM +0900, Greg Kroah-Hartman wrote: > On Fri, Jul 15, 2016 at 03:41:10PM -0700, Bin Gao wrote: > > On Fri, Jul 15, 2016 at 02:21:48PM +0300, Felipe Balbi wrote: > > > Greg Kroah-Hartman writes: > > > > On Fri, Jul 15, 2016 at 01:38:12PM +0300, Felipe Balbi wrote: >

Re: [PATCH 1/2] usb: typec: Add USB Power Delivery sink port support

2016-07-18 Thread Bin Gao
On Mon, Jul 18, 2016 at 10:07:24AM +0300, Felipe Balbi wrote: > > Hi, > > Bin Gao writes: > >> > +int pd_sink_queue_msg(struct pd_sink_msg *msg) > >> > +{ > >> > +unsigned long flags; > >> > +struct pd_sink_port *port; > >> > + > >> > +if (msg->port < 0 || msg->port >= MA

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Oliver Neukum
On Mon, 2016-07-18 at 17:04 +0200, Kristian Evensen wrote: > On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum wrote: > >> Ok, sounds good. So far, I have only seen the random MAC issue with > >> the three previously mentioned devices, but who knows how many else is > >> out there with the same error

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-18 Thread Kristian Evensen
On Tue, Jul 19, 2016 at 8:20 AM, Oliver Neukum wrote: >> I had a look at some other drivers, and I think we need to be very >> careful about making setting a random MAC too generic. For example, we >> might be unlucky and break the possibly_iphdr()-code/assumption in >> qmi_wwan.c. And there is pr