RE: [PATCH] option.c: Support for Gemalto's Cinterion PH8 and AHxx products added

2016-04-27 Thread Schemmel Hans-Christoph
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Sonntag, 24. April 2016 12:15 > To: Schemmel Hans-Christoph > Cc: Johan Hovold; gre...@linuxfoundation.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH] option.c: Support for Gemalto's

Re: [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path

2016-04-27 Thread Felipe Balbi
Hi, Jisheng Zhang writes: > Dear Felipe, > > On Wed, 27 Apr 2016 08:33:52 +0300 Felipe Balbi wrote: > >> Jisheng Zhang writes: >> > Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to >> > clk_{unprepare, disable}()") allows NULL or error pointer to be passed >> > unconditionall

Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

2016-04-27 Thread Felipe Balbi
Hi, Jisheng Zhang writes: >> > +static void xhci_plat_phy_exit(struct usb_hcd *hcd) >> > +{ >> > + if (hcd->phy) { >> > + phy_power_off(hcd->phy); >> > + phy_exit(hcd->phy); >> > + } else { >> > + usb_phy_shutdown(hcd->usb_phy); >> > + } >> > +} >> > + >> > static

Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

2016-04-27 Thread Heikki Krogerus
Hi, On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote: > @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device *pdev) > if (HCC_MAX_PSA(xhci->hcc_params) >= 4) > xhci->shared_hcd->can_do_streams = 1; > > + hcd->phy = devm_phy_get(&pdev->dev,

[PATCH] usb: dwc3: usb/dwc3: fake dissconnect event when turn off pullup

2016-04-27 Thread changbin . du
From: "Du, Changbin" The dwc3 controller can't generate a disconnect event after it is stopped. Thus gadget dissconnect callback is not invoked when do soft dissconnect. Call dissconnect here to workaround this issue. Note, most time we still see disconnect be called that because it is invoked b

Re: [PATCH] usb: dwc3: usb/dwc3: fake dissconnect event when turn off pullup

2016-04-27 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > From: "Du, Changbin" > > The dwc3 controller can't generate a disconnect event after it is > stopped. Thus gadget dissconnect callback is not invoked when do not generating disconnect IRQ after you drop Run/Stop is expected. > soft dissconnect. Call dissconn

Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

2016-04-27 Thread Felipe Balbi
Hi, Heikki Krogerus writes: > On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote: >> @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device >> *pdev) >> if (HCC_MAX_PSA(xhci->hcc_params) >= 4) >> xhci->shared_hcd->can_do_streams = 1; >> >> +hc

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: > Jisheng Zhang writes: > > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > devm_regulator_get_optional() ?? Does USB work without a VBUS? Unless the answer is yes then I'd expect this to be just a normal regulator_get(). > >

RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Jun Li
Hi > > + > +static struct otg_hcd_ops otg_hcd_intf = { > + .add = usb_add_hcd, > + .remove = usb_remove_hcd, > + .usb_bus_start_enum = usb_bus_start_enum, Build break if CONFIG_USB_OTG is not enabled: drivers/built-in.o:(.data+0x1db30): undefined reference to `usb_bus_start_enum' Ma

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Felipe Balbi
Hi, Mark Brown writes: > On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: >> Jisheng Zhang writes: > >> > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > >> devm_regulator_get_optional() ?? > > Does USB work without a VBUS? Unless the answer is yes then I'd expect it can, ju

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Jisheng Zhang
Dear Mark, On Wed, 27 Apr 2016 10:57:39 +0100 Mark Brown wrote: > On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: > > Jisheng Zhang writes: > > > > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > > > devm_regulator_get_optional() ?? > > Does USB work without a VBUS? Un

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 01:25:27PM +0300, Felipe Balbi wrote: > Mark Brown writes: > > this to be just a normal regulator_get(). > jokes aside, this regulator is optional because not all platforms > require a SW controlled regulator, no ? Will normal regulator_get() give > us a dummy regulator i

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Felipe Balbi
Hi, Mark Brown writes: > On Wed, Apr 27, 2016 at 01:25:27PM +0300, Felipe Balbi wrote: >> Mark Brown writes: > >> > this to be just a normal regulator_get(). > >> jokes aside, this regulator is optional because not all platforms >> require a SW controlled regulator, no ? Will normal regulator_g

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-27 Thread Roger Quadros
Hi, On 27/04/16 06:15, Peter Chen wrote: > On Tue, Apr 26, 2016 at 04:21:07PM +0800, Peter Chen wrote: >> On Tue, Apr 26, 2016 at 07:00:22AM +, Jun Li wrote: >>> Hi >>> -Original Message- From: Peter Chen [mailto:hzpeterc...@gmail.com] Sent: Tuesday, April 26, 2016 2:28

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Roger Quadros
On 27/04/16 13:16, Jun Li wrote: > Hi > >> >> + >> +static struct otg_hcd_ops otg_hcd_intf = { >> +.add = usb_add_hcd, >> +.remove = usb_remove_hcd, >> +.usb_bus_start_enum = usb_bus_start_enum, > > Build break if CONFIG_USB_OTG is not enabled: > > drivers/built-in.o:(.data+0x1db30):

Re: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Roger Quadros
On 27/04/16 14:00, Roger Quadros wrote: > On 27/04/16 13:16, Jun Li wrote: >> Hi >> >>> >>> + >>> +static struct otg_hcd_ops otg_hcd_intf = { >>> + .add = usb_add_hcd, >>> + .remove = usb_remove_hcd, >>> + .usb_bus_start_enum = usb_bus_start_enum, >> >> Build break if CONFIG_USB_OTG is not en

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-27 Thread Roger Quadros
Hi Jun, On 26/04/16 05:07, Jun Li wrote: > Hi Roger > >> -Original Message- >> From: Roger Quadros [mailto:rog...@ti.com] >> Sent: Tuesday, April 05, 2016 10:05 PM >> To: st...@rowland.harvard.edu; ba...@kernel.org; >> gre...@linuxfoundation.org; peter.c...@freescale.com >> Cc: dan.j.will

Re: [PATCH v6 09/12] usb: gadget: udc: adapt to OTG core

2016-04-27 Thread Roger Quadros
On 26/04/16 03:07, Jun Li wrote: > Hi > >> -Original Message- >> From: Roger Quadros [mailto:rog...@ti.com] >> Sent: Monday, April 25, 2016 10:04 PM >> To: Jun Li ; st...@rowland.harvard.edu; ba...@kernel.org; >> gre...@linuxfoundation.org; peter.c...@freescale.com >> Cc: dan.j.willi...@in

RE: [PATCH] usb: dwc3: usb/dwc3: fake dissconnect event when turn off pullup

2016-04-27 Thread Du, Changbin
Hi, Balbi, The step to reproduce this issue is: 1) connect device to a host and wait its enumeration. 2) trigger software disconnect by calling function usb_gadget_disconnect(), which finally call dwc3_gadget_pullup(false). Do not reconnect device (I mean no enumeration go on, keep bit Ru

Re: [PATCH] usb: dwc3: omap: get rid of dma_status

2016-04-27 Thread Roger Quadros
Felipe, On 11/04/16 17:18, Roger Quadros wrote: > dma_status bit flag is set but never really used > so get rid of it. > > Reported-by: Felipe Balbi > Signed-off-by: Roger Quadros Gentle ping on this one for -next. Thanks. cheers, -roger > --- > drivers/usb/dwc3/dwc3-omap.c | 6 -- > 1

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Grygorii Strashko
On 04/27/2016 08:41 AM, Felipe Balbi wrote: > > Hi, > > Grygorii Strashko writes: >> On 04/26/2016 09:17 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Grygorii Strashko writes: Now not all DMA paremters configured properly for "xhci-hcd" platform device which is created manually. For ex

Re: [PATCH] usb: dwc3: usb/dwc3: fake dissconnect event when turn off pullup

2016-04-27 Thread Sergei Shtylyov
Hello. On 4/27/2016 11:29 AM, changbin...@intel.com wrote: From: "Du, Changbin" The dwc3 controller can't generate a disconnect event after it is stopped. Thus gadget dissconnect callback is not invoked when do soft dissconnect. Call dissconnect here to workaround this issue. "Disconnect

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 09:54:10AM +0800, Lu Baolu wrote: > Please refer to Documentation/acpi/gpio-properties.txt. That's not visibly what your driver is doing, that is also recommending using a static name which is what I'm asking for. > > Why does the device care?It's requesting the GPIO in >

RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Jun Li
Hi > -Original Message- > From: Roger Quadros [mailto:rog...@ti.com] > Sent: Wednesday, April 27, 2016 7:12 PM > To: Jun Li ; st...@rowland.harvard.edu; ba...@kernel.org; > gre...@linuxfoundation.org; peter.c...@freescale.com > Cc: dan.j.willi...@intel.com; jun...@freescale.com; > mathias.n

Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

2016-04-27 Thread Mark Brown
On Wed, Apr 27, 2016 at 06:25:16PM +0800, Jisheng Zhang wrote: > On Wed, 27 Apr 2016 10:57:39 +0100 Mark Brown wrote: > > On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote: > > > > + vbus = devm_regulator_get(&pdev->dev, "vbus"); > > > devm_regulator_get_optional() ?? > > Do

RE: [PATCH v6 08/12] usb: hcd: Adapt to OTG core

2016-04-27 Thread Jun Li
Hi, > -Original Message- > From: Jun Li [mailto:jun...@nxp.com] > Sent: Wednesday, April 27, 2016 8:50 PM > To: Roger Quadros ; st...@rowland.harvard.edu; > ba...@kernel.org; gre...@linuxfoundation.org; peter.c...@freescale.com > Cc: dan.j.willi...@intel.com; jun...@freescale.com; > mathia

Re: [PATCH] usb: hub: fix panic caused by NULL bos pointer during reset device

2016-04-27 Thread Tony Battersby
On 04/26/2016 10:53 PM, Du, Changbin wrote: >> On Tue, Mar 08, 2016 at 05:15:17PM +0800, changbin...@intel.com wrote: >>> From: "Du, Changbin" >>> >>> This is a reworked patch based on reverted commit d8f00cd685f5 ("usb: >>> hub: do not clear BOS field during reset device"). >>> >>> The privious o

Re: Clear the host side toggle manually when endpoint is 'soft reset'

2016-04-27 Thread Mathias Nyman
Hi On 26.04.2016 12:23, Julien D'ascenzio wrote: Hi, I see you make this patch in the kernel mainline: xhci: Clear the ho27082e2654dc148078b0abdfc3c8e5ccbde0ebfa: st side: toggle manually when endpoint is 'soft reset' then you revert it: d0167ad2954ee2d1c70704c454c646086b6653d6: Revert "xhci

Re: [PATCH 0/2] musb fixes for v4.6-rc5

2016-04-27 Thread Bin Liu
Greg, On Tue, Apr 26, 2016 at 02:57:05PM -0700, Greg KH wrote: > On Mon, Apr 18, 2016 at 11:38:23AM -0500, Bin Liu wrote: > > Hi Greg, > > > > Here are a couple fixes for musb for v4.6-rc5. > > Sorry for the delay, I picked these up with the request for 4.6-rc6, > right? Yes, for -rc6. Thanks,

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 14:59:00 Catalin Marinas wrote: > > I would be in favour of a dma_inherit() function as well. We could hack > something up in the arch code (like below) but I would rather prefer an > explicit dma_inherit() call by drivers creating such devices. > > diff --git a/arch/ar

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Catalin Marinas
On Wed, Apr 27, 2016 at 08:41:06AM +0300, Felipe Balbi wrote: > Grygorii Strashko writes: > > On 04/26/2016 09:17 AM, Felipe Balbi wrote: > >> Grygorii Strashko writes: > >>> Now not all DMA paremters configured properly for "xhci-hcd" platform > >>> device which is created manually. For example:

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Grygorii Strashko
On 04/27/2016 04:59 PM, Catalin Marinas wrote: On Wed, Apr 27, 2016 at 08:41:06AM +0300, Felipe Balbi wrote: Grygorii Strashko writes: On 04/26/2016 09:17 AM, Felipe Balbi wrote: Grygorii Strashko writes: Now not all DMA paremters configured properly for "xhci-hcd" platform device which is

Re: [PATCH v6 11/12] usb: core: hub: Notify OTG fsm when A device sets b_hnp_enable

2016-04-27 Thread Roger Quadros
On 18/04/16 10:08, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:16PM +0300, Roger Quadros wrote: >> This is the a_set_b_hnp_enable flag in the OTG state machine >> diagram and must be set when the A-Host has successfully set >> the b_hnp_enable feature of the OTG-B-Peripheral attached to it. >

Re: [PATCH v3] usb: core: hub: hub_port_init lock controller instead of bus

2016-04-27 Thread Mathias Nyman
On 25.04.2016 15:48, Chris Bainbridge wrote: The XHCI controller presents two USB buses to the system - one for USB2 and one for USB3. The hub init code (hub_port_init) is reentrant but only locks one bus per thread, leading to a race condition failure when two threads attempt to simultaneously i

Re: Bug 116821 - Regression: System freeze when unplugging unmounted USB flash drive from powered hub

2016-04-27 Thread Alan Stern
On Thu, 21 Apr 2016, John wrote: > jbMacAZ 2016-04-20 22:39:07 UTC > > System hangs requiring hard reboot. System behaves normally with earlier > kernels upto 4.6-rc3. Reverting all edits to drivers/USB/ between rc3 > and rc4 does NOT fix the problem. Problem firs

Re: Clear the host side toggle manually when endpoint is 'soft reset'

2016-04-27 Thread Julien D'ascenzio
On 27/04/2016 16:07, Mathias Nyman wrote: > Hi > > On 26.04.2016 12:23, Julien D'ascenzio wrote: >> Hi, >> >> I see you make this patch in the kernel mainline: >> >> xhci: Clear the ho27082e2654dc148078b0abdfc3c8e5ccbde0ebfa: st side: >> toggle manually when endpoint is 'soft reset' >> >> then you

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-27 Thread Bin Liu
Hi, On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > Fix soft lockup when resetting remote device attached > to usb host. Configuration: > pppd -> musb hub -> usb-serial -> gsm modem I have heard a few reports similar to this symptom, but never been able to reproduce it on my side.

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Catalin Marinas
On Wed, Apr 27, 2016 at 04:11:17PM +0200, Arnd Bergmann wrote: > On Wednesday 27 April 2016 14:59:00 Catalin Marinas wrote: > > > > I would be in favour of a dma_inherit() function as well. We could hack > > something up in the arch code (like below) but I would rather prefer an > > explicit dma_i

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 16:50:19 Catalin Marinas wrote: > On Wed, Apr 27, 2016 at 04:11:17PM +0200, Arnd Bergmann wrote: > > On Wednesday 27 April 2016 14:59:00 Catalin Marinas wrote: > > > > > > I would be in favour of a dma_inherit() function as well. We could hack > > > something up in the a

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Felipe Balbi
Hi, Arnd Bergmann writes: > On Wednesday 27 April 2016 16:50:19 Catalin Marinas wrote: >> On Wed, Apr 27, 2016 at 04:11:17PM +0200, Arnd Bergmann wrote: >> > On Wednesday 27 April 2016 14:59:00 Catalin Marinas wrote: >> > > >> > > I would be in favour of a dma_inherit() function as well. We cou

Re: [PATCH 07/12] usbip: vudc: Add UDC specific ops

2016-04-27 Thread Krzysztof Opasiak
Hi On 04/27/2016 07:18 AM, Felipe Balbi wrote: > > Hi, > > Krzysztof Opasiak writes: >> From: Igor Kotrasinski >> >> Add endpoints definitions and ops for both endpoints and gadget. >> Add also a suitable platform driver and functions for handling >> usbip events. >> >> This commit is a result

[PATCH] usb: usbip: vudc: Fix WARN_ON() usage

2016-04-27 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- drivers/usb/usbip/vudc_dev.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c index 43047f4..0523f29 100644 --- a/drivers/usb/usbip/vudc_dev.c +++ b/drivers/usb/usbip/vudc_d

[PATCH] Documentation: ABI: Add doc for usbip-vudc attributes

2016-04-27 Thread Krzysztof Opasiak
Signed-off-by: Krzysztof Opasiak --- .../ABI/testing/sysfs-platform-usbip-vudc | 35 1 file changed, 35 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-platform-usbip-vudc diff --git a/Documentation/ABI/testing/sysfs-platform-usbip-vudc b/Docume

[PATCH] usb/host/: const data must use __initconst not __initdata

2016-04-27 Thread Nicolas Pitre
Init data marked const should be annotated with __initconst for correctness and not __initdata. This also fixes LTO builds that otherwise fail with section mismatch errors. Signed-off-by: Nicolas Pitre diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index df538fd10

Re: [PATCH 07/12] usbip: vudc: Add UDC specific ops

2016-04-27 Thread Greg KH
On Wed, Apr 27, 2016 at 07:03:52PM +0200, Krzysztof Opasiak wrote: > > Hi > On 04/27/2016 07:18 AM, Felipe Balbi wrote: > > > > Hi, > > > > Krzysztof Opasiak writes: > >> From: Igor Kotrasinski > >> > >> Add endpoints definitions and ops for both endpoints and gadget. > >> Add also a suitable

Re: [PATCH] Documentation: ABI: Add doc for usbip-vudc attributes

2016-04-27 Thread Greg KH
On Wed, Apr 27, 2016 at 07:12:47PM +0200, Krzysztof Opasiak wrote: > Signed-off-by: Krzysztof Opasiak No description of why this patch is needed? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH] usb: usbip: vudc: Fix WARN_ON() usage

2016-04-27 Thread Greg KH
On Wed, Apr 27, 2016 at 07:13:50PM +0200, Krzysztof Opasiak wrote: > Signed-off-by: Krzysztof Opasiak I can't take a patch with no changelog text :( -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] Documentation: ABI: Add doc for usbip-vudc attributes

2016-04-27 Thread Krzysztof Opasiak
On 04/27/2016 07:37 PM, Greg KH wrote: > On Wed, Apr 27, 2016 at 07:12:47PM +0200, Krzysztof Opasiak wrote: >> Signed-off-by: Krzysztof Opasiak > > No description of why this patch is needed? > Sorry, though that title line is enough self-descriptive. I will resend this with suitable descript

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 19:53:51 Felipe Balbi wrote: > Arnd Bergmann writes: > > On Wednesday 27 April 2016 16:50:19 Catalin Marinas wrote: > >> On Wed, Apr 27, 2016 at 04:11:17PM +0200, Arnd Bergmann wrote: > >> > On Wednesday 27 April 2016 14:59:00 Catalin Marinas wrote: > >> > > > >> > > I

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Alan Stern
On Wed, 27 Apr 2016, Arnd Bergmann wrote: > I've looked at the usb HCD code now and see this: > > struct usb_hcd *usb_create_shared_hcd(const struct hc_driver *driver, > struct device *dev, const char *bus_name, > struct usb_hcd *primary_hcd) > { > ... >

[PATCH v2] Documentation: ABI: Add doc for usbip-vudc attributes

2016-04-27 Thread Krzysztof Opasiak
As vudc provides some new attributes using sysfs infrastructure, add a suitable documentation file for those attributes. Signed-off-by: Krzysztof Opasiak --- Changes since v1: - Update commit message --- .../ABI/testing/sysfs-platform-usbip-vudc | 35 1 file chan

[PATCH v2] usb: usbip: vudc: Fix WARN_ON() usage pattern

2016-04-27 Thread Krzysztof Opasiak
Fix WARN_ON() macro usage as suggested by Felipe. Instead of using: if (cond) { WARN_ON(1); do_stuff(); } Use a better pattern with WARN_ON() placed in if condition: if (WARN_ON(cond)) do_stuff(); Signed-off-by: Krzysztof Opasiak --- Changes since v1: - Update commit message --- drive

[PATCH] usb: usbip: vudc: Rename find_endpoint() to vudc_find_endpoint()

2016-04-27 Thread Krzysztof Opasiak
As find_endpoint() is a global funcion rename it to vudc_find_endpoint() to clearly mark where does it come from. Signed-off-by: Krzysztof Opasiak --- drivers/usb/usbip/vudc.h |2 +- drivers/usb/usbip/vudc_dev.c |2 +- drivers/usb/usbip/vudc_rx.c |2 +- drivers/us

Re: [PATCH] Documentation: ABI: Add doc for usbip-vudc attributes

2016-04-27 Thread Krzysztof Opasiak
On 04/27/2016 07:37 PM, Greg KH wrote: > On Wed, Apr 27, 2016 at 07:12:47PM +0200, Krzysztof Opasiak wrote: >> Signed-off-by: Krzysztof Opasiak > > No description of why this patch is needed? > > I have just sent an updated v2 version but unfortunately I used wrong message-Id to which I repl

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 13:59:13 Alan Stern wrote: > On Wed, 27 Apr 2016, Arnd Bergmann wrote: > > > I've looked at the usb HCD code now and see this: > > > > struct usb_hcd *usb_create_shared_hcd(const struct hc_driver *driver, > > struct device *dev, const char *bus_name, > >

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-27 Thread Maxim Uvarov
2016-04-27 18:46 GMT+03:00 Bin Liu : > Hi, > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: >> Fix soft lockup when resetting remote device attached >> to usb host. Configuration: >> pppd -> musb hub -> usb-serial -> gsm modem > > I have heard a few reports similar to this symptom, b

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-27 Thread Bin Liu
Hi, On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: > 2016-04-27 18:46 GMT+03:00 Bin Liu : > > Hi, > > > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > >> Fix soft lockup when resetting remote device attached > >> to usb host. Configuration: > >> pppd -> musb hub ->

[PATCH] usb: devio: declare usbdev_vm_ops as static

2016-04-27 Thread Michele Curti
usbdev_vm_ops is used in devio.c only, so declare it as static Signed-off-by: Michele Curti --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 52c4461..73ce871 100644 --- a/drivers/usb/core/de

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Felipe Balbi
Hi, Arnd Bergmann writes: > On Wednesday 27 April 2016 13:59:13 Alan Stern wrote: >> On Wed, 27 Apr 2016, Arnd Bergmann wrote: >> >> > I've looked at the usb HCD code now and see this: >> > >> > struct usb_hcd *usb_create_shared_hcd(const struct hc_driver *driver, >> > struct d

RE: [EXT] Re: [PATCH RESEND 3/5] USB: serial: cp210x: Added comments to CRTSCT flag code.

2016-04-27 Thread Konstantin Shkolnyy
> -Original Message- > From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold > Sent: Tuesday, April 26, 2016 02:26 > To: Konstantin Shkolnyy > Cc: Johan Hovold; Konstantin Shkolnyy; linux-usb@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [EXT] Re: [PATCH

Re: [PATCH v2] xhci: Cleanup only when releasing primary hcd.

2016-04-27 Thread Joe Lawrence
Hello Mathias, Roger, Gabriel I've been chasing strange MSI / legacy IRQ behavior from xHCI for a couple days and wanted to report a few things that may be effected by Gabriel's recent "xhci: Cleanup only when releasing primary hcd" patch (more on this at the bottom). After 8c24d6d7b09d "usb: xhc

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Felipe Balbi
Hi, Arnd Bergmann writes: > On Wednesday 27 April 2016 19:53:51 Felipe Balbi wrote: >> Arnd Bergmann writes: >> > On Wednesday 27 April 2016 16:50:19 Catalin Marinas wrote: >> >> On Wed, Apr 27, 2016 at 04:11:17PM +0200, Arnd Bergmann wrote: >> >> > On Wednesday 27 April 2016 14:59:00 Catalin M

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 23:05:42 Felipe Balbi wrote: > Arnd Bergmann writes: > > On Wednesday 27 April 2016 13:59:13 Alan Stern wrote: > >> On Wed, 27 Apr 2016, Arnd Bergmann wrote: > >> > >> > I've looked at the usb HCD code now and see this: > >> > > >> > struct usb_hcd *usb_create_shared_h

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-27 Thread Bin Liu
Hi, On Wed, Apr 27, 2016 at 02:13:56PM -0500, Bin Liu wrote: > Hi, > > On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: > > 2016-04-27 18:46 GMT+03:00 Bin Liu : > > > Hi, > > > > > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov wrote: > > >> Fix soft lockup when resetting rem

我的主页在

2016-04-27 Thread 我的主页在
你的朋友给你分享了一个支付宝红包口令:加群有红包赶快打开支付宝APP,输入红包口令,抢红包,手慢无。

Re: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-27 Thread Peter Chen
On Wed, Apr 27, 2016 at 01:59:44PM +0300, Roger Quadros wrote: > Hi, > > On 27/04/16 06:15, Peter Chen wrote: > > On Tue, Apr 26, 2016 at 04:21:07PM +0800, Peter Chen wrote: > >> On Tue, Apr 26, 2016 at 07:00:22AM +, Jun Li wrote: > >>> Hi > >>> > -Original Message- > From: P

[PATCH 0/5] usb: dwc2: Various fixes

2016-04-27 Thread John Youn
Hi Felipe, These are some various patches for dwc2 for next. Thanks, John John Youn (1): usb: dwc2: Proper cleanup on dr_mode failure Sevak Arakelyan (1): usb: dwc2: Fixed SOF interrupt enabling/disabling Vahram Aharonyan (1): usb: dwc2: gadget: Check for ep0 in enable Vardan Mikayelyan

[PATCH 3/5] usb: dwc2: host: Setting qtd to NULL after freeing it

2016-04-27 Thread John Youn
From: Vardan Mikayelyan This is safety change added while doing slub debugging. Affected functions: dwc2_hcd_qtd_unlink_and_free() _dwc2_hcd_urb_enqueue() Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn --- drivers/usb/dwc2/hcd.c | 1 + drivers/usb/dwc2/hcd.h | 1 + 2 files changed

[PATCH 4/5] usb: dwc2: Fixed SOF interrupt enabling/disabling

2016-04-27 Thread John Youn
From: Sevak Arakelyan In case of DDMA mode we don't need to get an SOF interrupt so disable the unmasking of SOF interrupt in DDMA mode. Signed-off-by: Sevak Arakelyan Signed-off-by: John Youn --- drivers/usb/dwc2/hcd_queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/5] usb: dwc2: gadget: Prevent handling of host interrupts

2016-04-27 Thread John Youn
From: Vardan Mikayelyan In host slave mode, the core asserts the rxready, txfifoempty interrupts that get serviced in the gadget irq handler. Prevent servicing of these when not in the gadget mode of operation. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn --- drivers/usb/dwc2/gad

[PATCH 5/5] usb: dwc2: Proper cleanup on dr_mode failure

2016-04-27 Thread John Youn
Cleanup in probe if we fail to get dr_mode. Signed-off-by: John Youn --- drivers/usb/dwc2/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 88629be..fc6f525 100644 --- a/drivers/usb/dwc2/platform.c +++ b

[PATCH 1/5] usb: dwc2: gadget: Check for ep0 in enable

2016-04-27 Thread John Youn
From: Vahram Aharonyan Replaced the WARN_ON with a check and return of -EINVAL in the dwc2_hsotg_ep_enable function if ep0 is passed in. Signed-off-by: Vahram Aharonyan Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/2] usb: core: buffer: avoid NULL pointer dereferrence

2016-04-27 Thread Chunfeng Yun
NULL pointer dereferrence will happen when class driver wants to allocate zero length buffer and pool_max[0] can't be used, so simply returns NULL in the case. Signed-off-by: Chunfeng Yun --- drivers/usb/core/buffer.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/buf

[PATCH v2 2/2] usb: misc: usbtest: fix error of urb allocation

2016-04-27 Thread Chunfeng Yun
urb allocation will fail when usbtest_alloc_urb() tries to allocate zero length buffer, but it doesn't need it in fact, so just skips buffer allocation in the case. Signed-off-by: Chunfeng Yun --- drivers/usb/misc/usbtest.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/mi

Re: [PATCH v2 2/2] phy: Group vendor specific phy drivers

2016-04-27 Thread Kishon Vijay Abraham I
Hi, On Tuesday 26 April 2016 11:36 AM, Vivek Gautam wrote: > Hi Kishon, > > > On Wed, Apr 6, 2016 at 7:37 PM, Vivek Gautam wrote: >> Adding vendor specific directories in phy to group >> phy drivers under their respective vendor umbrella. >> >> Also updated the MAINTAINERS file to reflect the c

Re: [PATCH v2 2/2] phy: Group vendor specific phy drivers

2016-04-27 Thread Vivek Gautam
Hi Kishon, On Thu, Apr 28, 2016 at 10:28 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 26 April 2016 11:36 AM, Vivek Gautam wrote: >> Hi Kishon, >> >> >> On Wed, Apr 6, 2016 at 7:37 PM, Vivek Gautam >> wrote: >>> Adding vendor specific directories in phy to group >>> phy drivers under

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-27 Thread Lu Baolu
Hi, On 04/27/2016 08:33 PM, Mark Brown wrote: > On Wed, Apr 27, 2016 at 09:54:10AM +0800, Lu Baolu wrote: > >> Please refer to Documentation/acpi/gpio-properties.txt. > That's not visibly what your driver is doing, that is also recommending > using a static name which is what I'm asking for. Yes,

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

2016-04-27 Thread Felipe Balbi
Hi, Arnd Bergmann writes: > On Wednesday 27 April 2016 23:05:42 Felipe Balbi wrote: >> Arnd Bergmann writes: >> > On Wednesday 27 April 2016 13:59:13 Alan Stern wrote: >> >> On Wed, 27 Apr 2016, Arnd Bergmann wrote: >> >> >> >> > I've looked at the usb HCD code now and see this: >> >> > >> >>

RE: [PATCH] usb: dwc3: usb/dwc3: fake dissconnect event when turn off pullup

2016-04-27 Thread Felipe Balbi
Hi, (we don't top-post on this forum ;-) "Du, Changbin" writes: > Hi, Balbi, > > The step to reproduce this issue is: > 1) connect device to a host and wait its enumeration. > 2) trigger software disconnect by calling function > usb_gadget_disconnect(), which finally call >dwc3_gadget_p

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-04-27 Thread Maxim Uvarov
2016-04-28 0:28 GMT+03:00 Bin Liu : > Hi, > > On Wed, Apr 27, 2016 at 02:13:56PM -0500, Bin Liu wrote: >> Hi, >> >> On Wed, Apr 27, 2016 at 09:26:10PM +0300, Maxim Uvarov wrote: >> > 2016-04-27 18:46 GMT+03:00 Bin Liu : >> > > Hi, >> > > >> > > On Wed, Apr 27, 2016 at 09:51:58AM +0300, Max Uvarov w