On Wed, Apr 27, 2016 at 07:03:52PM +0200, Krzysztof Opasiak wrote:
>
> Hi
> On 04/27/2016 07:18 AM, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Krzysztof Opasiak <k.opas...@samsung.com> writes:
> >> From: Igor Kotrasinski <i.kotrasi...@samsung.com>
> >>
> >> Add endpoints definitions and ops for both endpoints and gadget.
> >> Add also a suitable platform driver and functions for handling
> >> usbip events.
> >>
> >> This commit is a result of cooperation between Samsung R&D Institute
> >> Poland and Open Operating Systems Student Society at University
> >> of Warsaw (O2S3@UW) consisting of:
> >>
> >> Igor Kotrasinski <ikotrasi...@gmail.com>
> >> Karol Kosik <ka...@interia.eu>
> >> Ewelina Kosmider <3w3l...@gmail.com>
> >> Dawid Lazarczyk <lazarczyk.da...@gmail.com>
> >> Piotr Szulc <ps347...@students.mimuw.edu.pl>
> >>
> >> Tutor and project owner:
> >> Krzysztof Opasiak <k.opas...@samsung.com>
> >>
> >> Signed-off-by: Igor Kotrasinski <i.kotrasi...@samsung.com>
> >> Signed-off-by: Karol Kosik <ka...@interia.eu>
> >> [Various bug fixes, improvements and commit msg update]
> >> Signed-off-by: Krzysztof Opasiak <k.opas...@samsung.com>
> >
> > just a couple minor nits below. Nice work
> >
> >> +struct vep *find_endpoint(struct vudc *udc, u8 address)
> >
> > polluting namespace. Care to add 'static'?
>
> Unfortunately this cannot be static as it is used in different files.
>
> $ cd $KERN_DIR/drivers/usb/usbip
> $ git grep -l find_endpoint
> vudc.h
> vudc_dev.c
> vudc_rx.c
> vudc_transfer.c
>
> of course I can make it static inline and put it into header but I'm not
> sure if this makes any sense for this function?
For a global function, please use a sane prefix on the function to make
it obvious where it is coming from:
vep_find_endpoint()
would be a good idea.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
