[PATCH 1/1] dm9601: enable EP3 interrupt and enhance eeprom functions

2016-03-09 Thread Joseph CHANG
Enable chip's EP3 interrupt to get the link-up notify soon immediately. Add to maintain variant eeprom adapters which may have not right dm9620x's format. Add function dm9601_set_eeprom which tested good with ethtool utility. Signed-off-by: Joseph CHANG --- drivers/net/usb/dm9601.c | 127 +

Re: [PATCH 1/1] dm9601: enable EP3 interrupt and enhance eeprom functions

2016-03-09 Thread Peter Korsgaard
> "Joseph" == Joseph CHANG writes: Hi Joseph, > Enable chip's EP3 interrupt to get the link-up notify soon > immediately. > Add to maintain variant eeprom adapters which may have not right > dm9620x's format. > Add function dm9601_set_eeprom which tested good with ethtool > utility.

[PATCH 1/5 v9] dt/bindings: Add binding for the DA8xx MUSB driver

2016-03-09 Thread Petr Kulhavy
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy --- v1: v2: - using standard properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" - using "ti," prefix instead of "da8xx," for specific property names - no w

[PATCH 3/5 v9] usb: musb: core: added missing const qualifier to musb_hdrc_platform_data::config

2016-03-09 Thread Petr Kulhavy
The musb_hdrc_platform_data::config was defined as a non-const pointer. However some drivers (e.g. the ux500) set up this pointer to point to a static structure, which is potentially dangerous. Since the musb core uses the pointer in a read-only manner the const qualifier was added to protect the c

[PATCH 2/5 v9] usb: musb: core: added helper function for parsing DT

2016-03-09 Thread Petr Kulhavy
This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy --- v4: - created musb_get_dr_mode() v5: - musb_get_dr_mode() renamed to musb_get_mode() - added musb_get_power() v6: - musb_get_power() : added missing boundary check for the maximum value

[PATCH 4/5 v9] ARM: davinci: defined missing CFGCHIP2_REFFREQ_* macros for MUSB PHY

2016-03-09 Thread Petr Kulhavy
Only few MUSB PHY reference clock frequencies were defined. This patch defines macros for the missing frequencies: 19.2MHz, 38.4MHz, 13MHz, 26MHz, 20MHz, 40MHz Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Bin Liu --- v5: v6: v7: v8: v9: include/linux/platform_dat

[PATCH 5/5 v9] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-09 Thread Petr Kulhavy
This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Tested-by: Petr Kulhavy --- v1: v2: - using standard MUSB properties "dr_mode", "mentor,power", "mentor,num-eps", "mentor,multipoint", "mentor,ram-bits" - using "ti," prefix instead of "da8xx,"

Re: [PATCH] usb: gadget: f_midi: added spinlock on transmit function

2016-03-09 Thread Felipe Ferreri Tonello
Hi Balbi, On 09/03/16 07:20, Felipe Balbi wrote: > > Hi, > > "Felipe F. Tonello" writes: >> [ text/plain ] >> Since f_midi_transmit is called by both ALSA and USB sub-systems, it can >> potentially cause a race condition between both calls because f_midi_transmit >> is not reentrant nor thread-

Re: [PATCH] usb: gadget: f_midi: added spinlock on transmit function

2016-03-09 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: > [ text/plain ] > Hi Balbi, > > On 09/03/16 07:20, Felipe Balbi wrote: >> >> Hi, >> >> "Felipe F. Tonello" writes: >>> [ text/plain ] >>> Since f_midi_transmit is called by both ALSA and USB sub-systems, it can >>> potentially cause a race condition between

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Yoshihiro Shimoda
Hi Mathias, Would you review this patch? This patch could be applied into the latest usb.git / usb-next branch. Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Tuesday, February 16, 2016 12:26 PM > To: mathias.ny...@intel.com; gre...@linuxfoundation

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > [ text/plain ] > Hi Mathias, > > Would you review this patch? > This patch could be applied into the latest usb.git / usb-next branch. > > Best regards, > Yoshihiro Shimoda > >> -Original Message- >> From: Yoshihiro Shimoda >> Sent: Tuesday, February 16, 2

[ANNOUNCE] permanent email

2016-03-09 Thread Felipe Balbi
Hi guys, so this will be the email I'll actually be using in the list. It's okay to continue to send emails to ba...@kernel.org as my notmuch searches will include that account, plus I don't want to update MAINTAINERS yet again :-) If you want to update your contact list and send me emails to fe

Re: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Felipe Balbi
Hi Yoshihiro, Yoshihiro Shimoda writes: > [ text/plain ] > When unexpected situation happened (e.g. tx/rx irq happened while > DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL > pointer dereference like the followings: > > Unable to handle kernel NULL pointer dereference at vir

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-09 Thread Felipe Balbi
Hi, "Nicholas A. Bellinger" writes: > [ text/plain ] > Hi Felipe + usb-gadget folks, > > On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote: >> Dan Carpenter writes: >> > We need to move the kfree() down a line so we don't dereference a freed >> > variable. >> > >> > Fixes: 1b418a8fcbc0 ('ta

Re: [PATCH 2/5 v9] usb: musb: core: added helper function for parsing DT

2016-03-09 Thread Sergei Shtylyov
Hello. On 3/9/2016 12:25 PM, Petr Kulhavy wrote: This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to m

Re: [PATCH 5/5 v9] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-09 Thread Sergei Shtylyov
Hello. On 3/9/2016 12:25 PM, Petr Kulhavy wrote: This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Tested-by: Petr Kulhavy [...] diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index b03d3b8..aabd33a 100644 --- a/drivers/usb/

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Yoshihiro Shimoda
Hi Felipe, > Hi Yoshihiro, > > Yoshihiro Shimoda writes: > > [ text/plain ] > > When unexpected situation happened (e.g. tx/rx irq happened while > > DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL > > pointer dereference like the followings: > > > > Unable to handle kernel NU

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Yoshihiro Shimoda
Hi Felipe, > Sent: Wednesday, March 09, 2016 8:00 PM < snip > > >> On xHCI controllers of R-Car Gen2 and Gen3, the AC64 bit (bit 0) of > >> HCCPARAMS1 is set to 1. However, these SoCs don't support 64-bit address > >> memory pointers. So, this driver should call dma_set_coherent_mask(dev, > >> DMA

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: >> Yoshihiro Shimoda writes: >> > [ text/plain ] >> > When unexpected situation happened (e.g. tx/rx irq happened while >> > DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL >> > pointer dereference like the followings: >> > >> > Unable to handle

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-09 Thread Andrzej Pietrasiewicz
Hi Nicholas, W dniu 05.03.2016 o 08:26, Nicholas A. Bellinger pisze: Hi Felipe + usb-gadget folks, On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote: usb-gadget/tcm: Conversion to percpu_ida tag pre-allocation http://www.spinics.net/lists/target-devel/msg11777.html usb-gadget/tcm: Co

Re: [RFC 7/7] USB: usbatm: avoid fragile and inefficient snprintf use

2016-03-09 Thread Sergei Shtylyov
Hello. On 3/8/2016 11:40 PM, Rasmus Villemoes wrote: Passing overlapping source and destination is fragile, and in this case we can even simplify the code and avoid the huge stack buffer by using the %p extension for printing a small hex dump. Signed-off-by: Rasmus Villemoes --- drivers/usb

Re: [PATCH 2/2] usb: renesas_usbhs: disable tx irq before starting TX DMAC transfer

2016-03-09 Thread Sergei Shtylyov
Hello. On 3/8/2016 8:58 AM, Yoshihiro Shimoda wrote: This patch adds a code to surely disable tx irq of the pipe before TX IRQ. starting TX DMAC transfer. Otherwise, a lot of unnecessary tx irqs TX IRQs. Mixing "TX" and "tx" on a single line is... inconsistent. :-) may heppen in r

Re: [PATCH] usb: gadget: f_midi: refactor state machine

2016-03-09 Thread Felipe Ferreri Tonello
Hi Balbi, On 09/03/16 07:04, Felipe Balbi wrote: > > Hi, > > "Felipe F. Tonello" writes: >> [ text/plain ] >> This refactor results in a cleaner state machine code and promotes >> consistency, readability, and maintanability of this driver. >> >> Signed-off-by: Felipe F. Tonello > > while wor

Re: [PATCH] usb: gadget: f_midi: added spinlock on transmit function

2016-03-09 Thread Felipe Ferreri Tonello
Hi Balbi, On 09/03/16 10:33, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: >> [ text/plain ] >> Hi Balbi, >> >> On 09/03/16 07:20, Felipe Balbi wrote: >>> >>> Hi, >>> >>> "Felipe F. Tonello" writes: [ text/plain ] Since f_midi_transmit is called by both ALSA and USB

[PATCH] usb: gadget: f_midi: added spinlock on transmit function

2016-03-09 Thread Felipe F. Tonello
Since f_midi_transmit is called by both ALSA and USB sub-systems, it can potentially cause a race condition between both calls because f_midi_transmit is not reentrant nor thread-safe. This is due to an implementation detail that the transmit function looks for the next available usb request from t

Bug ID: 114111

2016-03-09 Thread Peter Maciejko
https://bugzilla.kernel.org/show_bug.cgi?id=114111 Bug ID: 114111 Summary: Reboot after shutdown, when USB 3.0 controller is enabled PM -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH] usb: gadget: f_midi: added spinlock on transmit function

2016-03-09 Thread Felipe Ferreri Tonello
Hi, On 09/03/16 16:17, Felipe F. Tonello wrote: > Since f_midi_transmit is called by both ALSA and USB sub-systems, it can > potentially cause a race condition between both calls because f_midi_transmit > is not reentrant nor thread-safe. This is due to an implementation detail that > the transmit

Re: Bug ID: 114111

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 05:47:00PM +0100, Peter Maciejko wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=114111 > > Bug ID: 114111 > Summary: Reboot after shutdown, when USB 3.0 controller is enabled Please send us the full details so we don't have to dig them out on the website... -- To uns

Re: Bug ID: 114111

2016-03-09 Thread Felipe Ferreri Tonello
Hi, On 09/03/16 17:12, Greg KH wrote: > On Wed, Mar 09, 2016 at 05:47:00PM +0100, Peter Maciejko wrote: >> https://bugzilla.kernel.org/show_bug.cgi?id=114111 >> >> Bug ID: 114111 >> Summary: Reboot after shutdown, when USB 3.0 controller is enabled > > Please send us the full details so we don't

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-09 Thread Stefan Wahren
> Doug Anderson hat am 7. März 2016 um 22:30 > geschrieben: > > > Stefan, > > On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren wrote: > > Hi Doug, > > > >> Douglas Anderson hat am 4. März 2016 um 19:23 > >> geschrieben: > >> > >> > >> This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe proble

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-09 Thread Doug Anderson
Stefan, On Wed, Mar 9, 2016 at 11:01 AM, Stefan Wahren wrote: > >> Doug Anderson hat am 7. März 2016 um 22:30 >> geschrieben: >> >> >> Stefan, >> >> On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren >> wrote: >> > Hi Doug, >> > >> >> Douglas Anderson hat am 4. März 2016 um 19:23 >> >> geschriebe

[PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize

2016-03-09 Thread Felipe F. Tonello
buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed devices. That caused the OUT endpoint to freeze if the host send any data packet of length greater than 256 bytes. This is an example dump of what happended on that enpoint: HOST: [DATA][Length=260][...] DEVICE: [NAK] HO

Re: usb: musb: tx fifo flush warning

2016-03-09 Thread Bin Liu
Hi, On Fri, Mar 04, 2016 at 11:51:19AM +0100, John Ogness wrote: > On 2016-03-04, John Ogness wrote: > > Using v4.5-rc6, I modified musb_h_tx_flush_fifo() to allow infinite > > looping and kept a log of the number of loops that were executed. For > > my test I am regularly seeing 3000-3200 loops

Re: [PATCH 5/5 v9] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-03-09 Thread Bin Liu
Hi, On Wed, Mar 09, 2016 at 10:25:27AM +0100, Petr Kulhavy wrote: > This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver > > Signed-off-by: Petr Kulhavy > Tested-by: Petr Kulhavy > --- > v1: > > v2: > - using standard MUSB properties "dr_mode", "mentor,power", > "mentor,num-

Re: Bug ID: 114111

2016-03-09 Thread Peter Maciejko
The problem is a bit complicated, that is why I put a video containing a description of the problem on kernel bug tracker. Motherboard: ASRock H87 PRO 4 Processor: Intel Core i5 4570 Haswell If USB 3.0 controller is enabled in UEFI Setup then three, maybe four seconds after shutdown, my computer

Re: USB host port {,performance} issues with Beaglebone

2016-03-09 Thread Bin Liu
Hi, On Tue, Mar 08, 2016 at 10:57:41AM +0200, Felipe Balbi wrote: > > Hi, > > Victor Dodon writes: > > [ text/plain ] > > Hi Felipe, > > > > On Mon, Mar 7, 2016 at 11:13 PM, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Victor Dodon writes: > >>> [ text/plain ] > >>> Sorry, I accidentally press

Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize

2016-03-09 Thread Steve Calfee
On Wed, Mar 9, 2016 at 11:39 AM, Felipe F. Tonello wrote: > buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed > devices. > > That caused the OUT endpoint to freeze if the host send any data packet of > length greater than 256 bytes. > > This is an example dump of what hap

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-03-09 Thread Li Yang
On Tue, Mar 8, 2016 at 9:40 PM, Bjorn Andersson wrote: > On Tue, Mar 8, 2016 at 11:52 AM, Li Yang wrote: >> On Wed, Mar 2, 2016 at 4:59 PM, Li Yang wrote: >>> On Mon, Feb 22, 2016 at 4:07 PM, Bjorn Andersson >>> wrote: On Mon 22 Feb 02:03 PST 2016, Srinivas Kandagatla wrote: > >>>

Re: Minor xhci issues (failed to peer) on Dell XPS 13 9350 (Skylake)

2016-03-09 Thread Mario Limonciello
On 03/07/2016 02:42 PM, Andy Lutomirski wrote: > On Mon, Mar 7, 2016 at 12:13 PM, Greg Kroah-Hartman > wrote: > I'm adding a couple Dell people. > > Hi, Dell people- > > Your latest DSDT has this blatantly buggy method: > > Method (_Q66, 0, NotSerialized) // _Qxx: EC Query >

RE: [PATCH 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Yoshihiro Shimoda
Hi, > > Yoshihiro Shimoda writes: > >> Yoshihiro Shimoda writes: > >> > This patch adds a condition to avoid the dereference. > >> > > >> > Signed-off-by: Yoshihiro Shimoda > >> > >> is this a regression fix ? Do we need it in current -rc (it's getting > >> late for that, actually), do we need

RE: [PATCH 2/2] usb: renesas_usbhs: disable tx irq before starting TX DMAC transfer

2016-03-09 Thread Yoshihiro Shimoda
Hello, > Hello. > > On 3/8/2016 8:58 AM, Yoshihiro Shimoda wrote: > > > This patch adds a code to surely disable tx irq of the pipe before > > TX IRQ. > > > starting TX DMAC transfer. Otherwise, a lot of unnecessary tx irqs > > TX IRQs. Mixing "TX" and "tx" on a single line is... inco

hello,

2016-03-09 Thread jack
My name is Jack, from the US. I'm in Syria right now fighting IS. I want to get to know you better, if I may be so bold. I consider myself an easy-going man, and I am currently looking for a relationship in which I feel loved. Please tell me more about yourself, if you don't mind. -- To unsubscr

[PATCH] watchdog: add driver for StreamLabs USB watchdog device

2016-03-09 Thread Alexey Klimov
This patch creates new driver that supports StreamLabs usb watchdog device. This device plugs into 9-pin usb header and connects to reset pin and reset button on common PC. USB commands used to communicate with device were reverse engineered using usbmon. Signed-off-by: Alexey Klimov --- driver

[PATCH v2 0/2] usb: renesas_usbhs: fix to avoid unexpected condition

2016-03-09 Thread Yoshihiro Shimoda
This patch set is based on the latest Felipe's usb.git / testing/next branch. (commit id = ac5706631325ae3695bfa1527101ab2b2f64859f) Changes from v1: - Add "Fixes" and "Cc: . - Revise the commit log of patch 2. - consistent words: tx -> TX, irq -> IRQ - typo: heppen -> happen Yoshihiro Shim

[PATCH v2 1/2] usb: renesas_usbhs: avoid NULL pointer derefernce in usbhsf_pkt_handler()

2016-03-09 Thread Yoshihiro Shimoda
When unexpected situation happened (e.g. tx/rx irq happened while DMAC is used), the usbhsf_pkt_handler() was possible to cause NULL pointer dereference like the followings: Unable to handle kernel NULL pointer dereference at virtual address pgd = c0004000 [] *pgd= Interna

[PATCH v2 2/2] usb: renesas_usbhs: disable TX IRQ before starting TX DMAC transfer

2016-03-09 Thread Yoshihiro Shimoda
This patch adds a code to surely disable TX IRQ of the pipe before starting TX DMAC transfer. Otherwise, a lot of unnecessary TX IRQs may happen in rare cases when DMAC is used. Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support") Cc: # v3.1+ Signed-off-by: Yoshihiro Shimoda --- drivers

[PATCH v2 0/2] usb: host: xhci: add a new quirk and fix an issue for R-Car Gen2/3

2016-03-09 Thread Yoshihiro Shimoda
This patch set is based on the latest usb.git / usb-next branch. (commit id = ace53bfc4374cada8b645765e2b4ad5831e760932) Changes from v1: - Add a new quirk "XHCI_CLEAR_AC64" for using it on some PCIe card. http://thread.gmane.org/gmane.linux.kernel.renesas-soc/858/focus=1694 Yoshihiro Shimoda

[PATCH v2 1/2] usb: host: xhci: add a new quirk XHCI_CLEAR_AC64

2016-03-09 Thread Yoshihiro Shimoda
On some xHCI controllers (e.g. R-Car SoCs), the AC64 bit (bit 0) of HCCPARAMS1 is set to 1. However, the xHCs don't support 64-bit address memory pointers actually. So, in this case, this driver should call dma_set_coherent_mask(dev, DMA_BIT_MASK(32)) in xhci_gen_setup(). Otherwise, the xHCI contro

[PATCH v2 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

2016-03-09 Thread Yoshihiro Shimoda
This patch fixes an issue that cannot work if R-Car Gen2/3 run on above 4GB physical memory environment to use a quirk XHCI_CLEAR_AC64. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci-plat.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/driv

Re: [PATCH] watchdog: add driver for StreamLabs USB watchdog device

2016-03-09 Thread Guenter Roeck
On 03/09/2016 06:29 PM, Alexey Klimov wrote: This patch creates new driver that supports StreamLabs usb watchdog device. This device plugs into 9-pin usb header and connects to reset pin and reset button on common PC. USB commands used to communicate with device were reverse engineered using usb

RE: [PATCH v2 1/2] usb:dwc3: Enable support for 64-bit system

2016-03-09 Thread Thang Q. Nguyen
Hi, I would like to ask if I need to update anything else for this change? Thanks, Thang Q. Nguyen - -Original Message- From: Thang Q. Nguyen [mailto:tqngu...@apm.com] Sent: Monday, January 25, 2016 9:26 PM To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-o...@vger.ke

Re: [PATCH] watchdog: add driver for StreamLabs USB watchdog device

2016-03-09 Thread kbuild test robot
Hi Alexey, [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on v4.5-rc7 next-20160309] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Alexey-Klimov/watchdog-add-driver-for

RE: [PATCH v2 2/2] usb:dwc3: pass arch data to xhci-hcd child

2016-03-09 Thread Thang Q. Nguyen
Hi, I would like to ask if I need to update anything else for this change? Thanks, Thang Q. Nguyen - -Original Message- From: Thang Q. Nguyen [mailto:tqngu...@apm.com] Sent: Monday, January 25, 2016 9:26 PM To: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-o...@vger.ke

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-09 Thread Nicholas A. Bellinger
Hi Andrzej, On Wed, 2016-03-09 at 13:53 +0100, Andrzej Pietrasiewicz wrote: > Hi Nicholas, > > W dniu 05.03.2016 o 08:26, Nicholas A. Bellinger pisze: > > Hi Felipe + usb-gadget folks, > > > > On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote: > > > > > > > usb-gadget/tcm: Conversion to pe

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-09 Thread Nicholas A. Bellinger
On Wed, 2016-03-09 at 13:38 +0200, Felipe Balbi wrote: > Hi, > > "Nicholas A. Bellinger" writes: > > [ text/plain ] > > Hi Felipe + usb-gadget folks, > > > > On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote: > >> Dan Carpenter writes: > >> > We need to move the kfree() down a line so we don