> On Sun, 2016-01-03 at 20:50 +0100, Bjørn Mork wrote:
>
>> But like you, I cannot find the commit supposed to fix this. There is
>> no such commit in net, net-next, usb or usb-next AFAICS. And I can't
>> find any other relevant commit after the one introducing this bug
>> either. Did you forget
From: Steinar H. Gunderson [mailto:se...@google.com]
> Sent: 26 November 2015 00:19
There is still a problem with this code, not sure how to fix it.
...
> +static void dec_usb_memory_use_count(struct usb_memory *usbm, int *count)
> +{
> + struct usb_dev_state *ps = usbm->ps;
> + unsigned
We added a new error path to this function and we forgot to drop the
lock.
Fixes: e1e3d7ec5da3 ('usb: gadget: f_midi: pre-allocate IN requests')
Signed-off-by: Dan Carpenter
---
v2: Felipe asked for this to be fixed a different way.
diff --git a/drivers/usb/gadget/function/f_midi.c
b/drivers/us
Nobuo Iwata writes:
> Originally, USB/IP transmits requests and response PDUs for preparation
> to transfer URBs in user space, after the preparation, URBs are
> transmitted in kernel space.
>
> To make easy to introduce application network protocols like WebSocket
> and so on, the driver, usb
Hi Dan,
[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.4-rc8 next-20160105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Dan-Carpenter/usb-gadget-f_midi-missing
Nobuo Iwata writes:
> This patch extends number of ports limitation in application (vhci)
> side.
>
> To do so, vhci driver supports multiple host controllers. The number of
> controllers can be specified as a module parameter 'num_controllers'.
> The default is 1.
>
> ex) # insmod vhci_hcd.ko
On Monday, January 04, 2016 06:27:18 PM Derek Basehore wrote:
> On Mon, Nov 02, 2015 at 02:50:40AM +0100, Rafael J. Wysocki wrote:
> >
> > I've queued up this series for the second half of the v4.4 merge window.
> >
> > Thanks,
> > Rafael
> >
> >
> >
On Tue, 5 Jan 2016, kbuild test robot wrote:
> Hi Dan,
>
> [auto build test WARNING on balbi-usb/next]
> [also build test WARNING on v4.4-rc8 next-20160105]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system]
&g
It's a false positive, if midi is NULL then i starts as zero so it
won't go inside the for loop. Smatch has the same false positive.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo
On Tue, Jan 05 2016, Peter Chen wrote:
> Why -EINTR, the kernel-doc said it should return -ECONNRESET for
> active request, see include/linux/usb/gadget.h.
Because EINTR is what read returns to the user if the operation has been
interrupted by a signal, see ‘man 2 read’:
EINTR The call was
On Tue, Jan 05, 2016 at 01:28:11PM +0100, Julia Lawall wrote:
>
>
> On Tue, 5 Jan 2016, kbuild test robot wrote:
>
> > Hi Dan,
> >
> > [auto build test WARNING on balbi-usb/next]
> > [also build test WARNING on v4.4-rc8 next-20160105]
> > [if your patc
On Tue, Jan 05 2016, Dan Carpenter wrote:
> We added a new error path to this function and we forgot to drop the
> lock.
>
> Fixes: e1e3d7ec5da3 ('usb: gadget: f_midi: pre-allocate IN requests')
> Signed-off-by: Dan Carpenter
Acked-by: Michal Nazarewicz
> ---
> v2: Felipe asked for this to be f
On Tue, Jan 05, 2016 at 02:55:31PM +0100, Michal Nazarewicz wrote:
> @@ -568,12 +568,12 @@ static int f_midi_in_open(struct snd_rawmidi_substream
> *substream)
> {
> struct f_midi *midi = substream->rmidi->private_data;
>
> - if (!midi->in_port[substream->number])
> + if (substrea
Hi Michal,
[auto build test WARNING on v4.4-rc8]
[cannot apply to balbi-usb/next next-20160105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Michal-Nazarewicz/usb-gadget-f_midi-use-flexible
On Mon, Dec 21, 2015 at 2:33 AM, Peter Chen wrote:
> On Fri, Dec 18, 2015 at 11:38 PM, Alan Stern
> wrote:
>> On Fri, 18 Dec 2015, Peter Chen wrote:
>>
>>> On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern
>>> wrote:
>>
>>> > It's not clear (to me, anyway) how this is meant to work. USB is a
>>> >
On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci,
> >> __hc32 token)
> >> return '/';
> >> }
> >>
> >> -static void qh_lines(
> >> - struct ehci_hcd *ehci,
> >> - struct ehci_qh *qh,
> >> - char **nextp,
> >
On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> 2016-01-04 18:01 GMT-03:00 Alan Stern :
> > On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> >
> >> This patch fixes a coding style issue reported by checkpatch related to
> >> many leading tabs, removing a 'do while' loop and making use of goto tag
> >> ins
2016-01-04 23:40 GMT-03:00 Joe Perches :
> On Mon, 2016-01-04 at 19:07 -0300, Geyslan G. Bem wrote:
>> 2016-01-04 18:52 GMT-03:00 Sergei Shtylyov :
>> > > > > > This patch fixes coding style issues reported by checkpatch
>> > > > > > concerning
>> > > > > > to unnecessary space after a cast.
>> >
On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct
> ehci_hcd *ehci, __hc32 token)
> > >> return '/';
> > >> }
> > >>
> > >> -static void qh_lines(
> > >> - struct ehci_hcd *
On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
> > >> *ehci, __hc32 token)
> > >> return '/';
> > >> }
> > >>
> > >> -static void qh_lines(
> > >> - struct ehci
2016-01-05 12:23 GMT-03:00 Joe Perches :
> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>
>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
>> > >> *ehci, __hc32 token)
>> > >> return '/';
>> > >> }
>> > >>
>> >
2016-01-05 12:27 GMT-03:00 Geyslan G. Bem :
> 2016-01-05 12:23 GMT-03:00 Joe Perches :
>> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>>
>>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
>>> > >> *ehci, __hc32 token)
2016-01-05 12:15 GMT-03:00 Alan Stern :
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> 2016-01-04 18:01 GMT-03:00 Alan Stern :
>> > On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>> >
>> >> This patch fixes a coding style issue reported by checkpatch related to
>> >> many leading tabs, removing a 'do
On Tue, 5 Jan 2016, David Laight wrote:
> From: Steinar H. Gunderson [mailto:se...@google.com]
> > Sent: 26 November 2015 00:19
>
> There is still a problem with this code, not sure how to fix it.
>
> ...
> > +static void dec_usb_memory_use_count(struct usb_memory *usbm, int *count)
> > +{
> > +
On Tue, 5 Jan 2016, Rob Herring wrote:
> >>> > It's not clear (to me, anyway) how this is meant to work. USB is a
> >>> > completely discoverable bus: There is no way to represent devices
> >>> > statically; they have to be discovered. But a device can't be
> >>> > discovered unless it is functi
On Tue, 5 Jan 2016, Joe Perches wrote:
> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> > On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> >
> > > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
> > > >> *ehci, __hc32 token)
> > > >>�� return '/';
> > > >>� }
> > > >
On Tue, 2016-01-05 at 11:06 -0500, Alan Stern wrote:
> Trying to come up with hard-and-fast rules for this sort of thing is
> pretty hopeless. Even "Maximize readability" doesn't work too well,
> because different people find different things most readable.
Readability is mostly habituation.
A
Hello:
Question: The vm_operations_struct structure contains lots of callback
pointers. Is there any mechanism to prevent the callback routines and
the structure itself being unloaded from memory (if they are built into
modules) while the relevant VMAs are still in use?
Consider a simple example
On Tue, 5 Jan 2016, Joe Perches wrote:
> On Tue, 2016-01-05 at 11:06 -0500, Alan Stern wrote:
> > Trying to come up with hard-and-fast rules for this sort of thing is�
> > pretty hopeless.� Even "Maximize readability" doesn't work too well,�
> > because different people find different things most
On Tue, Jan 5, 2016 at 4:57 PM, Alan Stern wrote:
> On Tue, 5 Jan 2016, David Laight wrote:
>
>> From: Steinar H. Gunderson [mailto:se...@google.com]
>> > Sent: 26 November 2015 00:19
>>
>> There is still a problem with this code, not sure how to fix it.
>>
>> ...
>> > +static void dec_usb_memory_
On Mon, 4 Jan 2016, Joe Perches wrote:
> On Mon, 2016-01-04 at 19:07 -0300, Geyslan G. Bem wrote:
> > 2016-01-04 18:52 GMT-03:00 Sergei Shtylyov :
> > > > > > > This patch fixes coding style issues reported by checkpatch
> > > > > > > concerning
> > > > > > > to unnecessary space after a cast.
>
On Mon, 4 Jan 2016, Joe Perches wrote:
> measuring only kernel casts to a pointer, (because there are
> too many false positives otherwise) casts without a space
> are preferred ~3:1 over casts followed by a space.
>
> (without space)
> $�grep -rP --include=*.[ch] -oh "\(\s*(\w{3,}\s+){0,2}\w{3,}
The file
drivers/usb/misc/sisusbvga/sisusb.c
had many (192) coding style issues reported by checkpatch. This file also had a
problematic error path in the probe function that could result in dereferencing
a null pointer.
This patch series fix coding style issues and fix the problematic error pat
From: Peter Senna Tschudin
The file drivers/usb/misc/sisusbvga/sisusb.c contained coding style
issues reported by checkpatch. This patch fixes the following
errors:
- 12 WARNING: braces {} are not necessary for single statement blocks
- 4 ERROR: return is not a function, parentheses are not req
From: Peter Senna Tschudin
The file drivers/usb/misc/sisusbvga/sisusb.c had 6 assignments inside if
tests. This patch move the assignement outside the test.
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only.
drivers/usb/misc/sisusbvga/sisusb.c | 18 --
1 file
From: Peter Senna Tschudin
This patch remove four calls to dev_err() from sisusb_probe() as
reporting memory allocation failures is redundant:
- Remove a call to dev_err() that was reporting unsuccesful call to
kzalloc().
- Remove two calls to dev_err() that were reporting unsuccesful call
From: Peter Senna Tschudin
This patch removes null test before calls to kfree() as kfree() can
handle null pointers safely.
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only.
drivers/usb/misc/sisusbvga/sisusb.c | 12
1 file changed, 4 insertions(+), 8 deletions(-
From: Peter Senna Tschudin
This patch change only spaces, tabs, and newlines.
The file drivers/usb/misc/sisusbvga/sisusb.c contained entire statements
using 4 spaces for the last level of indetantion, and many other space
and tab related issues. This patch fixes the following issues:
- 83 ERROR
2016-01-05 13:29 GMT-03:00 Alan Stern :
> On Tue, 5 Jan 2016, Joe Perches wrote:
>
>> On Tue, 2016-01-05 at 11:06 -0500, Alan Stern wrote:
>> > Trying to come up with hard-and-fast rules for this sort of thing is
>> > pretty hopeless. Even "Maximize readability" doesn't work too well,
>> > because
From: Alan Stern [mailto:st...@rowland.harvard.edu]
> Sent: 05 January 2016 15:58
> On Tue, 5 Jan 2016, David Laight wrote:
>
> > From: Steinar H. Gunderson [mailto:se...@google.com]
> > > Sent: 26 November 2015 00:19
> >
> > There is still a problem with this code, not sure how to fix it.
> >
> >
This patchset removes all errors reported by checkpatch in addition to
some refactoring.
v2:
- changes:
* usb: host: ehci-dbg: fix up function definitions
- adds:
* usb: host: ehci-dbg: use scnprintf() in qh_lines()
- removes:
* usb: host: ehci-dbg: fix unsigned comparison
* usb: ho
This patch fixes coding style issues reported by checkpatch. The vast
majority of changes in this patch are removing spaces before opening
parenthesis, but in some cases, a few additional changes are made to fix
other coding style issues.
These additional changes are:
- Spaces around >> on line
This patch puts the closing parenthesis at the statement end removing
unnecessary "new line".
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
i
This patch fixes coding style issues reported by checkpatch concerning
to missing spaces around operators.
There is an additional change on line 49 that removes unnecessary
parentheses around ternary operands.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers/us
This patch fixes coding style issues reported by checkpatch concerning
to switch case statements. There are few additional changes made to fix
other coding styles issues.
These additional changes are:
- The compound statement "({...})" on line 474 is pulled out from
snprintf parameters.
- O
This patch fixes coding style issues reported by checkpatch.
Coding style demands usage of C89-style comments and a specific format
when it's multiline.
This also removes the Free Software Foundation address because FSF can
change it again.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/eh
This patch fixes coding style issues reported by checkpatch. The only
change in this patch that isn't just removing spaces before opening
square brackets is at line 213 where the initialization of fls_strings[]
is placed in same line.
Signed-off-by: Geyslan G. Bem
---
Notes:
Before this patc
This patch indents not empty functions to have the opening brace at the
beginning of the next line and body conforming coding style.
This also makes the function definition consistent with the file coding
style aligning parameters in sequential lines and indenting them with
two tabs.
Signed-off-b
This patch replaces two snprintf() calls with scnprintf() in qh_lines()
and hence removes the unneeded sequential truncation tests.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers/usb/host/ehci-dbg.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
This patch fixes coding style issues reported by checkpatch concerning
to missing line after variable declarations.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 9e
This patch fixes coding style issues reported by checkpatch concerning
to missing line after struct declarations.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 4
This patch converts macros into inline functions since the usage of
second is encouraged by Coding Style instead of the first.
Macros converted to functions:
- dbg_status
- dbg_cmd
- dbg_port
- speed_char
The size after changes remains the same.
Before:
text data bss dec hex filename
369
This patch fixes coding style issue reported by checkpatch concerning to
an unnecessary line before close brace.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 8c55d9
This patch fixes a coding style issue reported by checkpatch concerning
to usage of sizeof operand as a variable instead the type.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drive
This patch fixes coding style issues reported by checkpatch concerning
to conditional blocks without braces.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only
drivers/usb/host/ehci-dbg.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/
This patch fixes a coding style issue reported by checkpatch related to
kmalloc_array usage.
On the same line the sizeof operand was enclosed in parentheses.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertio
This patch fixes a coding style issue reported by checkpatch related to
too many leading tabs.
This moves part of the fill_periodic_buffer() to the new function
output_buf_tds_dir().
Because it's inline, the file size has not changed.
Before:
text data bssdec hex filename
3692081
On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote:
[]
> Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used
>
> $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c
>
> to verify that this patch do not change any visible character. If the
On Tue, 5 Jan 2016, Geyslan G. Bem wrote:
> This patchset removes all errors reported by checkpatch in addition to
> some refactoring.
>
> v2:
> - changes:
>* usb: host: ehci-dbg: fix up function definitions
> - adds:
>* usb: host: ehci-dbg: use scnprintf() in qh_lines()
> - removes:
>
Hi Graeme,
Here is the USBMon trace of the timeout:
https://sourceforge.net/p/dispcalgui/bug-reports/_discuss/thread/73a10891/735c/attachment/1.mon.out.txt
I also uploaded a video on youtube to show when I get the timeout:
https://www.youtube.com/watch?v=_W7j8j4pKKQ&feature=youtu.be
It manages t
Hi Geyslan,
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on next-20160105]
[cannot apply to v4.4-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Geyslan-G-Bem/usb
2016-01-05 16:23 GMT-03:00 kbuild test robot :
> Hi Geyslan,
>
> [auto build test ERROR on usb/usb-testing]
> [also build test ERROR on next-20160105]
> [cannot apply to v4.4-rc8]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improvin
This patch fixes coding style issues reported by checkpatch concerning
to switch case statements. There are few additional changes made to fix
other coding styles issues.
These additional changes are:
- The compound statement "({...})" on line 474 is pulled out from
snprintf parameters.
- O
This patchset removes all errors reported by checkpatch in addition to
some refactoring.
v2:
- changes:
* usb: host: ehci-dbg: fix up function definitions
- adds:
* usb: host: ehci-dbg: use scnprintf() in qh_lines()
- removes:
* usb: host: ehci-dbg: fix unsigned comparison
* usb: ho
This patch puts the closing parenthesis at the statement end removing
unnecessary "new line".
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
i
This patch fixes coding style issues reported by checkpatch.
Coding style demands usage of C89-style comments and a specific format
when it's multiline.
This also removes the Free Software Foundation address because FSF can
change it again.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/eh
This patch fixes coding style issues reported by checkpatch. The only
change in this patch that isn't just removing spaces before opening
square brackets is at line 213 where the initialization of fls_strings[]
is placed in same line.
Signed-off-by: Geyslan G. Bem
---
Notes:
Before this patc
This patch fixes coding style issues reported by checkpatch. The vast
majority of changes in this patch are removing spaces before opening
parenthesis, but in some cases, a few additional changes are made to fix
other coding style issues.
These additional changes are:
- Spaces around >> on line
This patch replaces two snprintf() calls with scnprintf() in qh_lines()
and hence removes the unneeded sequential truncation tests.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers/usb/host/ehci-dbg.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
This patch fixes coding style issues reported by checkpatch concerning
to missing line after variable declarations.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 9e
This patch converts macros into inline functions since the usage of
second is encouraged by Coding Style instead of the first.
Macros converted to functions:
- dbg_status
- dbg_cmd
- dbg_port
- speed_char
The size after changes remains the same.
Before:
text data bss dec hex filename
369
This patch fixes coding style issues reported by checkpatch concerning
to missing line after struct declarations.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 4
This patch fixes a coding style issue reported by checkpatch related to
kmalloc_array usage.
On the same line the sizeof operand was enclosed in parentheses.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertio
This patch fixes a coding style issue reported by checkpatch related to
too many leading tabs.
This moves part of the fill_periodic_buffer() to the new function
output_buf_tds_dir().
Because it's inline, the file size has not changed.
Before:
text data bssdec hex filename
3692081
This patch fixes coding style issues reported by checkpatch concerning
to missing spaces around operators.
There is an additional change on line 49 that removes unnecessary
parentheses around ternary operands.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only.
drivers/us
This patch fixes coding style issues reported by checkpatch concerning
to conditional blocks without braces.
Signed-off-by: Geyslan G. Bem
---
Notes:
Tested by compilation only
drivers/usb/host/ehci-dbg.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/
This patch fixes a coding style issue reported by checkpatch concerning
to usage of sizeof operand as a variable instead the type.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drive
This patch indents not empty functions to have the opening brace at the
beginning of the next line and body conforming coding style.
This also makes the function definition consistent with the file coding
style aligning parameters in sequential lines and indenting them with
two tabs.
Signed-off-b
On Tue, 5 Jan 2016, [iso-8859-1] Niccol� Belli wrote:
> Hi Graeme,
> Here is the USBMon trace of the timeout:
> https://sourceforge.net/p/dispcalgui/bug-reports/_discuss/thread/73a10891/735c/attachment/1.mon.out.txt
> I also uploaded a video on youtube to show when I get the timeout:
> https://w
This patch fixes coding style issue reported by checkpatch concerning to
an unnecessary line before close brace.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
index 8c55d9
I am Mr. Wang Zhiqiang working with Wing Lung Bank Hong Kong; I have a
highly mutual and legitimate Bequest for you to handle with me. This fund
was deposited in our bank by an Oil Magnate who lived in Hong Kong for
Twenty Eight years. He died along with his family during the Tsunami which
occur
On 1/2/2016 4:00 PM, Stefan Wahren wrote:
> Hi Remi,
>
>> Remi Pommarel hat am 2. Januar 2016 um 14:55 geschrieben:
>>
>>
>> Hi Stefan, Hi John,
>>
>> On Mon, Dec 28, 2015 at 3:16:47AM -0800, Stefan Wharen wrote:
> ...
>>
>> I came up with the same patch, but it does not seem to fix everything. I
Hi Dan,
On 05/01/16 12:44, Dan Carpenter wrote:
> On Tue, Jan 05, 2016 at 01:28:11PM +0100, Julia Lawall wrote:
>>
>>
>> On Tue, 5 Jan 2016, kbuild test robot wrote:
>>
>>> Hi Dan,
>>>
>>> [auto build test WARNING on balbi-usb/next]
>>&
On Tue, Jan 05, 2016 at 11:27:45AM -0500, Alan Stern wrote:
> Hello:
>
> Question: The vm_operations_struct structure contains lots of callback
> pointers. Is there any mechanism to prevent the callback routines and
> the structure itself being unloaded from memory (if they are built into
> modul
;>> Hi Dan,
> >>>
> >>> [auto build test WARNING on balbi-usb/next]
> >>> [also build test WARNING on v4.4-rc8 next-20160105]
> >>> [if your patch is applied to the wrong git tree, please drop us a note to
> >>> help improving the sy
On Tue, 5 Jan 2016, Kirill A. Shutemov wrote:
> On Tue, Jan 05, 2016 at 11:27:45AM -0500, Alan Stern wrote:
> > Hello:
> >
> > Question: The vm_operations_struct structure contains lots of callback
> > pointers. Is there any mechanism to prevent the callback routines and
> > the structure itself
On Tue, Jan 05, 2016 at 08:51:18PM +, Felipe Ferreri Tonello wrote:
> This case is not a matter of been pretty but a matter of been less error
> prone.
>
> What would you suggest?
Normally it's better to unwind in the reverse order from how we
allocated so it would be:
lock
a
On Tue, Jan 5, 2016 at 4:48 AM, Rafael J. Wysocki wrote:
> On Monday, January 04, 2016 06:27:18 PM Derek Basehore wrote:
>> On Mon, Nov 02, 2015 at 02:50:40AM +0100, Rafael J. Wysocki wrote:
>> >
>> > I've queued up this series for the second half of the v4.4 merge window.
>> >
>> > Thanks,
>> > R
Add a new interface for userspace to preallocate memory that can be
used with usbfs. This gives two primary benefits:
- Zerocopy; data no longer needs to be copied between the userspace
and the kernel, but can instead be read directly by the driver from
userspace's buffers. This works for a
On Tue, Jan 05, 2016 at 04:31:09PM -0500, Alan Stern wrote:
> Thank you. So it looks like I was worried about nothing.
>
> Steinar, you can remove the try_module_get/module_put lines from your
> patch. Also, the list_del() and comment in usbdev_release() aren't
> needed -- at that point we know
On Wed, Jan 06 2016, Dan Carpenter wrote:
> On Tue, Jan 05, 2016 at 08:51:18PM +, Felipe Ferreri Tonello wrote:
>> This case is not a matter of been pretty but a matter of been less error
>> prone.
>>
>> What would you suggest?
>
> Normally it's better to unwind in the reverse order from how w
On Thu, Nov 26, 2015 at 01:19:13AM +0100, Steinar H. Gunderson wrote:
> Add a new interface for userspace to preallocate memory that can be
> used with usbfs. This gives two primary benefits:
Please 'version' your patches, so that I have a chance to figure out
what patch is what, and what changed
On Tue, Jan 05, 2016 at 04:11:43PM -0800, Greg Kroah-Hartman wrote:
>> Add a new interface for userspace to preallocate memory that can be
>> used with usbfs. This gives two primary benefits:
> Please 'version' your patches, so that I have a chance to figure out
> what patch is what, and what chang
Add a new interface for userspace to preallocate memory that can be
used with usbfs. This gives two primary benefits:
- Zerocopy; data no longer needs to be copied between the userspace
and the kernel, but can instead be read directly by the driver from
userspace's buffers. This works for a
On Tue, Jan 05, 2016 at 08:36:31AM -0600, Rob Herring wrote:
> > 2. There are MFD USB devices, which includes several interfaces under
> > USB device,
> > like i2c, gpios, etc. Due to lack of device tree support, USB
> > class/device driver doesn't know
> > which kinds of interfaces are needed for
This is a completely broken usage of the mmap interface. if you use
mmap on a device file you must use the actual mmap for the data
transfer.
Our interface for zero copy reads/writes is O_DIRECT, and that requires
not special memory allocation, just proper alignment.
--
To unsubscribe from this l
For Intel 7260 modem, it is needed for host side to send zero
packet if the BULK OUT size is equal to USB endpoint max packet
length. Otherwise, modem side may still wait for more data and
cannot give response to host side.
Signed-off-by: Konrad Leszczynski
Signed-off-by: Lu Baolu
Cc: sta...@vge
97 matches
Mail list logo
