On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote: [] > Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used > > $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c > > to verify that this patch do not change any visible character. If the size of > this patch is a problem, please let me know in how many patches to split it.
Thanks. Maybe for future series, but not one in particular unless you feel like respinning it: As porcelain is meant for script consumption, I think a good mechanism for human review is to separate patch 1 into 2 patches. 1: Only horizontal line whitespace changes git diff -w shouldn't show any changes and git blame -w would not show any change either. 2: Only vertical line changes additions/reformatting This makes it easy to use git diff -w on patch 1 and patch 2 can be more easily scanned visually. It's also nice to use objdiff and show no object changes. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
