Re: [PATCH] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-08 Thread Eugene Shatokhin
01.09.2015 17:05, Eugene Shatokhin пишет: The race may happen when a device (e.g. YOTA 4G LTE Modem) is unplugged while the system is downloading a large file from the Net. Hardware breakpoints and Kprobes with delays were used to confirm that the race does actually happen. The race is on skb_q

Re: [PATCH v4 0/22] On-demand device probing

2015-09-08 Thread Tomeu Vizoso
On 7 September 2015 at 22:50, Rob Herring wrote: > On Mon, Sep 7, 2015 at 7:23 AM, Tomeu Vizoso > wrote: >> Hello, >> >> I have a problem with the panel on my Tegra Chromebook taking longer >> than expected to be ready during boot (Stéphane Marchesin reported what >> is basically the same issue

Re: [PATCH] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-08 Thread Bjørn Mork
Eugene Shatokhin writes: > I resent the patch to make it separate. What is the status of this now? One of the many nice features of patchwork is that you don't need to ask those questions :) See http://patchwork.ozlabs.org/patch/512856/ I really don't think it's appropriate for me to ack this,

Re: [PATCH] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-08 Thread Oliver Neukum
On Tue, 2015-09-08 at 09:37 +0200, Bjørn Mork wrote: > Eugene Shatokhin writes: > > > I resent the patch to make it separate. What is the status of this now? > > One of the many nice features of patchwork is that you don't need to ask > those questions :) > > See http://patchwork.ozlabs.org/pat

Re: [PATCH v4 04/13] otg-fsm: move usb_bus_start_enum into otg-fsm->ops

2015-09-08 Thread Peter Chen
On Mon, Sep 07, 2015 at 12:57:21PM +0300, Roger Quadros wrote: > On 07/09/15 04:24, Peter Chen wrote: > > On Mon, Aug 24, 2015 at 04:21:15PM +0300, Roger Quadros wrote: > >> This is to prevent missing symbol build error if OTG is > >> enabled (built-in) and HCD core (CONFIG_USB) is module. > >> > >

Re: [PATCH v4 04/13] otg-fsm: move usb_bus_start_enum into otg-fsm->ops

2015-09-08 Thread Roger Quadros
On 08/09/15 09:54, Peter Chen wrote: > On Mon, Sep 07, 2015 at 12:57:21PM +0300, Roger Quadros wrote: >> On 07/09/15 04:24, Peter Chen wrote: >>> On Mon, Aug 24, 2015 at 04:21:15PM +0300, Roger Quadros wrote: This is to prevent missing symbol build error if OTG is enabled (built-in) and H

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-08 Thread Oliver Neukum
On Mon, 2015-09-07 at 18:23 +0200, Mian Yousaf Kaukab wrote: > urb completion callback is executed in host controllers interrupt > context. To keep preempt disable time short, add urbs to a list on > completion and schedule work to process the list. > > Moreover, save timestamp and sof number in t

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-08 Thread Peter Chen
On Mon, Sep 07, 2015 at 01:23:01PM +0300, Roger Quadros wrote: > On 07/09/15 04:23, Peter Chen wrote: > > On Mon, Aug 24, 2015 at 04:21:18PM +0300, Roger Quadros wrote: > >> + * This is used by the USB Host stack to register the Host controller > >> + * to the OTG core. Host controller must not be

Re: "Tell linux-usb@vger.kernel.org to add your device to a proper driver"

2015-09-08 Thread Albino B Neto
2015-09-04 17:53 GMT-03:00 Greg KH : > On Fri, Sep 04, 2015 at 08:47:40PM +, Katarína Križáni wrote: >> So how should I install it correctly so that it "just runs" on Ubuntu? I did >> it first time: I am learning. > > Install what? > > The driver should "just work", no need to install anything

Re: [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller

2015-09-08 Thread Mathias Nyman
Hi On 08.09.2015 09:18, Chunfeng Yun wrote: There some vendor quirks for MTK xhci host controller: 1. It defines some extra SW scheduling parameters for HW to minimize the scheduling effort for synchronous and interrupt endpoints. The parameters are put into reseved DWs of slot context

Re: [PATCH v4] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-09-08 Thread Peter Chen
On Mon, Sep 07, 2015 at 02:45:25PM +0300, Ivan T. Ivanov wrote: > On recent Qualcomm platforms VBUS and ID lines are not routed to > USB PHY LINK controller. Use extcon framework to receive connect > and disconnect ID and VBUS notification. > > Signed-off-by: Ivan T. Ivanov I will queue it for n

[PATCH] xhci: create one unified function to calculate TRB TD remainder.

2015-09-08 Thread Mathias Nyman
xhci versions 1.0 and later report the untransferred data remaining in a TD a bit differently than older hosts. We used to have separate functions for these, and needed to check host version before calling the right function. Now Mediatek host has an additional quirk on how it uses the TD Size f

Re: [PATCH] xhci: create one unified function to calculate TRB TD remainder.

2015-09-08 Thread Oliver Neukum
On Tue, 2015-09-08 at 14:09 +0300, Mathias Nyman wrote: > Now Mediatek host has an additional quirk on how it uses the TD Size > field for remaining data. To prevent yet another function for > calculating > remainder we instead want to make one quirk friendly unified function. Could you clarify wh

Re: [PATCH] xhci: create one unified function to calculate TRB TD remainder.

2015-09-08 Thread Mathias Nyman
On 08.09.2015 14:46, Oliver Neukum wrote: On Tue, 2015-09-08 at 14:09 +0300, Mathias Nyman wrote: Now Mediatek host has an additional quirk on how it uses the TD Size field for remaining data. To prevent yet another function for calculating remainder we instead want to make one quirk friendly un

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-08 Thread Roger Quadros
On 08/09/15 11:31, Peter Chen wrote: > On Mon, Sep 07, 2015 at 01:23:01PM +0300, Roger Quadros wrote: >> On 07/09/15 04:23, Peter Chen wrote: >>> On Mon, Aug 24, 2015 at 04:21:18PM +0300, Roger Quadros wrote: + * This is used by the USB Host stack to register the Host controller + * to

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-08 Thread Hans de Goede
Hi, On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion and schedule work to process the list. Moreover, save timestamp and sof number in the urb complet

Re: PROBLEM: lsusb -v freezes kernel on Acer ES1-111M

2015-09-08 Thread Alan Stern
On Mon, 7 Sep 2015, Roland Weber wrote: > Hi Alan, > > just a quick heads-up before I go to sleep, > more detailed info to follow later this week. > The freeze is triggered from hcd.c, function usb_remove_hcd: > > /* Prevent any more root-hub status calls from the timer. > * The HCD might still

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-08 Thread Alan Stern
On Tue, 8 Sep 2015, Roger Quadros wrote: > On 08/09/15 11:31, Peter Chen wrote: > > On Mon, Sep 07, 2015 at 01:23:01PM +0300, Roger Quadros wrote: > >> On 07/09/15 04:23, Peter Chen wrote: > >>> On Mon, Aug 24, 2015 at 04:21:18PM +0300, Roger Quadros wrote: > + * This is used by the USB Host

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-08 Thread Alan Stern
On Tue, 8 Sep 2015, Hans de Goede wrote: > Hi, > > On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: > > urb completion callback is executed in host controllers interrupt > > context. To keep preempt disable time short, add urbs to a list on > > completion and schedule work to process the list. >

Re: similar files: fusbh200-hcd.c and fotg210-hcd.c

2015-09-08 Thread Felipe Balbi
On Mon, Sep 07, 2015 at 04:47:45PM +0200, Peter Senna Tschudin wrote: > I executed a clone detection tool* on drivers source code and I found > that the files > > drivers/usb/host/fusbh200-hcd.c > > and > > drivers/usb/host/fotg210-hcd.c > > are very similar. The main difference between the two

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-08 Thread Roger Quadros
Alan, On 08/09/15 17:34, Alan Stern wrote: > On Tue, 8 Sep 2015, Roger Quadros wrote: > >> On 08/09/15 11:31, Peter Chen wrote: >>> On Mon, Sep 07, 2015 at 01:23:01PM +0300, Roger Quadros wrote: On 07/09/15 04:23, Peter Chen wrote: > On Mon, Aug 24, 2015 at 04:21:18PM +0300, Roger Quadro

Re: [PATCH v2] usb: phy: msm: Unregister VBUS and ID events notifiers

2015-09-08 Thread Tim Bird
On 09/07/2015 01:07 AM, Ivan T. Ivanov wrote: > Right now even if driver failed to probe extcon framework will > still deliver its VBUS and ID events, which will lead to random > exception codes. > > Fix this by removing VBUS and ID events notifiers when probe fail. > > Fixes: 591fc116f330 ("us

Re: [PATCH] usbnet: Fix a race between usbnet_stop() and the BH

2015-09-08 Thread David Miller
From: Eugene Shatokhin Date: Tue, 1 Sep 2015 17:05:33 +0300 > The race may happen when a device (e.g. YOTA 4G LTE Modem) is > unplugged while the system is downloading a large file from the Net. > > Hardware breakpoints and Kprobes with delays were used to confirm that > the race does actually

[PATCH 1/2] usb: musb: set the controller speed based on the config setting

2015-09-08 Thread Bin Liu
Set the Power register HSENAB bit based on musb->config->maximum_speed, so that the glue layer can control MUSB to work in high- or full-speed. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 10 +- include/linux/usb/musb.h | 2 +- 2 files changed, 6 insertions(+), 6 delet

[PATCH 2/2] usb: musb: dsps: control musb speed based on dts setting

2015-09-08 Thread Bin Liu
Set musb config->maximum_speed based on the dts setting to control musb speed. By default musb works in high-speed mode. Adding maximum-speed = "full-speed"; to dts usb node will force musb to full-speed mode. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_dsps.c | 5 + 1 file c

Re: [PATCH 1/2] usb: musb: set the controller speed based on the config setting

2015-09-08 Thread Bin Liu
Hi, On 09/08/2015 04:10 PM, Bin Liu wrote: Set the Power register HSENAB bit based on musb->config->maximum_speed, so that the glue layer can control MUSB to work in high- or full-speed. Signed-off-by: Bin Liu Sorry, please discard this patch. I forgot to rebase it to 4.1.x. Thanks, -Bin.

Re: [PATCH 2/2] usb: musb: dsps: control musb speed based on dts setting

2015-09-08 Thread Bin Liu
Hi, On 09/08/2015 04:10 PM, Bin Liu wrote: Set musb config->maximum_speed based on the dts setting to control musb speed. By default musb works in high-speed mode. Adding maximum-speed = "full-speed"; to dts usb node will force musb to full-speed mode. Signed-off-by: Bin Liu Sorry

Re: [PATCH 2/2] usb: musb: dsps: control musb speed based on dts setting

2015-09-08 Thread Felipe Balbi
On Tue, Sep 08, 2015 at 04:10:12PM -0500, Bin Liu wrote: > Set musb config->maximum_speed based on the dts setting to control musb > speed. > > By default musb works in high-speed mode. Adding > > maximum-speed = "full-speed"; > > to dts usb node will force musb to full-speed mode. > > Si

Re: qcserial: AT unsolicited response codes missing with Dell Wireless 5808e

2015-09-08 Thread Reinhard Speyerer
On Mon, Aug 31, 2015 at 07:18:05PM +, Ward, David - 0665 - MITLL wrote: > On 01/06/2015 03:58 AM, Bjørn Mork wrote: > > Johan Hovold writes: > > > >> Ok, let's move the PID to option and if it turns out that more of these > >> devices require the modem-control signals (e.g. with more recent >

Re: [PATCH 2/2] usb: musb: dsps: control musb speed based on dts setting

2015-09-08 Thread Bin Liu
Hi, On 09/08/2015 04:16 PM, Felipe Balbi wrote: On Tue, Sep 08, 2015 at 04:10:12PM -0500, Bin Liu wrote: Set musb config->maximum_speed based on the dts setting to control musb speed. By default musb works in high-speed mode. Adding maximum-speed = "full-speed"; to dts usb node will

Re: [PATCH 2/2] usb: musb: dsps: control musb speed based on dts setting

2015-09-08 Thread Felipe Balbi
On Tue, Sep 08, 2015 at 04:18:14PM -0500, Bin Liu wrote: > Hi, > > On 09/08/2015 04:16 PM, Felipe Balbi wrote: > >On Tue, Sep 08, 2015 at 04:10:12PM -0500, Bin Liu wrote: > >>Set musb config->maximum_speed based on the dts setting to control musb > >>speed. > >> > >>By default musb works in high-s

[PATCH 1/2] usb: chipidea: Add support for 'phy-clkgate-delay-us' property

2015-09-08 Thread Fabio Estevam
From: Fabio Estevam Add support for the optional 'phy-clkgate-delay-us' property that is used to describe the delay time between putting PHY into low power mode and turning off the PHY clock. Signed-off-by: Li Jun Signed-off-by: Fabio Estevam --- drivers/usb/chipidea/core.c | 7 +++ incl

[PATCH 2/2] Doc: usb: ci-hdrc-usb2: Add phy-clkgate-delay-us entry

2015-09-08 Thread Fabio Estevam
From: Fabio Estevam Add an entry for the optional 'phy-clkgate-delay-us' property that is used to describe the delay time between putting PHY into low power mode and turning off the PHY clock. Signed-off-by: Li Jun Signed-off-by: Fabio Estevam --- Documentation/devicetree/bindings/usb/ci-hdrc

[PATCH 2/2] usb: chipidea: imx: fix a typo for imx6sx

2015-09-08 Thread Li Jun
Use imx6sx instead of imx6sl's platform flags for imx6sx. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index f9deea5..1becd33 100644 ---

RE: [PATCH 2/2] usb: musb: dsps: control musb speed based on dts setting

2015-09-08 Thread Liu, Bin
Hi, > -Original Message- > From: Balbi, Felipe > Sent: Tuesday, September 08, 2015 4:25 PM > To: Liu, Bin > Cc: Balbi, Felipe; linux-usb@vger.kernel.org > Subject: Re: [PATCH 2/2] usb: musb: dsps: control musb speed based on dts > setting > > On Tue, Sep 08, 2015 at 04:18:14PM -0500, Bin

[PATCH 1/2] usb: chipidea: imx: add usb support for imx7d

2015-09-08 Thread Li Jun
Add imx7d usb support. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c |7 drivers/usb/chipidea/usbmisc_imx.c | 62 2 files changed, 69 insertions(+) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.

[PATCH v2 1/2] usb: chipidea: imx: add usb support for imx7d

2015-09-08 Thread Li Jun
From: Peter Chen Add imx7d usb support. Signed-off-by: Peter Chen Signed-off-by: Li Jun --- change for v2: - update author and signed-off drivers/usb/chipidea/ci_hdrc_imx.c |7 drivers/usb/chipidea/usbmisc_imx.c | 62 2 files changed, 69 insert

[PATCH v2 2/2] usb: chipidea: imx: fix a typo for imx6sx

2015-09-08 Thread Li Jun
Use imx6sx instead of imx6sl's platform flags for imx6sx. Signed-off-by: Li Jun --- drivers/usb/chipidea/ci_hdrc_imx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index f9deea5..1becd33 100644 ---

Re: [PATCH v4 07/13] usb: otg: add OTG core

2015-09-08 Thread Peter Chen
On Tue, Sep 08, 2015 at 03:25:25PM +0300, Roger Quadros wrote: > > > On 08/09/15 11:31, Peter Chen wrote: > > On Mon, Sep 07, 2015 at 01:23:01PM +0300, Roger Quadros wrote: > >> On 07/09/15 04:23, Peter Chen wrote: > >>> On Mon, Aug 24, 2015 at 04:21:18PM +0300, Roger Quadros wrote: > + * Th

Re: [PATCH v4 10/13] usb: hcd: Adapt to OTG core

2015-09-08 Thread Peter Chen
On Mon, Aug 24, 2015 at 04:21:21PM +0300, Roger Quadros wrote: > The existing usb_add/remove_hcd() functionality > remains unchanged for non-OTG devices. For OTG > devices they only register the HCD with the OTG core. > > Introduce usb_otg_add/remove_hcd() for use by OTG core. > These functions ac

Re: [PATCH 2/2] Doc: usb: ci-hdrc-usb2: Add phy-clkgate-delay-us entry

2015-09-08 Thread Peter Chen
On Tue, Sep 08, 2015 at 10:18:15PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Add an entry for the optional 'phy-clkgate-delay-us' property that is > used to describe the delay time between putting PHY into low power > mode and turning off the PHY clock. > > Signed-off-by: Li Jun > S

Re: [PATCH 1/2] usb: chipidea: imx: add usb support for imx7d

2015-09-08 Thread Peter Chen
On Wed, Sep 09, 2015 at 10:18:39AM +0800, Li Jun wrote: > Add imx7d usb support. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/ci_hdrc_imx.c |7 > drivers/usb/chipidea/usbmisc_imx.c | 62 > > 2 files changed, 69 insertions(+) > > diff --

Re: [PATCH 2/2] usb: chipidea: imx: fix a typo for imx6sx

2015-09-08 Thread Peter Chen
On Wed, Sep 09, 2015 at 10:18:40AM +0800, Li Jun wrote: > Use imx6sx instead of imx6sl's platform flags for imx6sx. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/ci_hdrc_imx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c

Re: [PATCH v7 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller

2015-09-08 Thread Rob Herring
On 09/08/2015 01:18 AM, Chunfeng Yun wrote: > add a DT binding documentation of xHCI host controller for the > MT8173 SoC from Mediatek. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mt8173-xhci.txt| 52 > ++ > 1 file changed, 52 insertions(+) >

Re: [PATCH v4 0/22] On-demand device probing

2015-09-08 Thread Rob Herring
On 09/08/2015 02:30 AM, Tomeu Vizoso wrote: > On 7 September 2015 at 22:50, Rob Herring wrote: >> On Mon, Sep 7, 2015 at 7:23 AM, Tomeu Vizoso >> wrote: >>> Hello, >>> >>> I have a problem with the panel on my Tegra Chromebook taking longer >>> than expected to be ready during boot (Stéphane Mar

Re: [PATCH v7 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-09-08 Thread Rob Herring
On 09/08/2015 01:17 AM, Chunfeng Yun wrote: > add a DT binding documentation of usb3.0 phy for MT65xx > SoCs from Mediatek. > > Signed-off-by: Chunfeng Yun One comment, otherwise: Acked-by: Rob Herring > --- > .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 69 > ++

Re: [PATCH 1/2] usb: chipidea: imx: add usb support for imx7d

2015-09-08 Thread Li Jun
On Wed, Sep 09, 2015 at 10:35:59AM +0800, Peter Chen wrote: ... ... > > > > +static const struct ci_hdrc_imx_platform_flag imx7d_usb_data = { > > + .flags = CI_HDRC_SUPPORTS_RUNTIME_PM | > > + CI_HDRC_TURN_VBUS_EARLY_ON | > > + CI_HDRC_DISABLE_HOST_STREAMING, > > +}; > > +