Re: [PATCH v2 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()

On Wed, Jul 08 2015, Robert Baldyga wrote: > Since maxpacket_limit was introduced all UDC drivers should use > usb_ep_set_maxpacket_limit() function instead of setting maxpacket value > manually. ep.maxpacket_limit contains actual maximum maxpacket value > supported by hardware which is needed by e

Re: [PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

On Wed, Jul 08 2015, Robert Baldyga wrote: > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga > Acked-by: Nicolas Ferre Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 4 > 1 file

Re: [PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit()

On Wed, Jul 08 2015, Robert Baldyga wrote: > Since maxpacket_limit was introduced all UDC drivers should use > usb_ep_set_maxpacket_limit() function instead of setting maxpacket value > manually. ep.maxpacket_limit contains actual maximum maxpacket value > supported by hardware which is needed by e

Re: [PATCH v3 4/5] usb: gadget: mass_storage: Use static array for luns

On Tue, Jul 07 2015, Krzysztof Opasiak wrote: > This patch replace dynamicly allocated luns array with static one. > This simplifies the code of mass storage function and modules. > > It also fix issue with reporting wrong number of LUNs in GET_MAX_LUN > request. According to MS spec we should retu

Re: [PATCH v3 5/5] usb: gadget: mass_storage: Warn if LUNs ids are not contiguous

On Tue, Jul 07 2015, Krzysztof Opasiak wrote: > According to mass storage specification: > > "Logical Unit Numbers on the device shall be numbered contiguously > starting from LUN 0 to a maximum LUN of 15 (Fh)" > > So let's at least print a warning message that LUNs ids should be > contiguous. > >

Re: USB: OOPS 4.1.0-rc5-next-20150527 after lsusb -v

Hi Chris, On Thu, May 28, 2015 at 4:45 AM, Chris Ruehl wrote: > FIXED by set the correct clock in the dts file, for the main_clk enabled in > phy-generic.c Could you please share your dts change? I see the same issue on a imx27-pdk board. Thanks -- To unsubscribe from this list: send the line

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

On Wed, Jul 08, 2015 at 12:48:04PM +0200, Glasswall Information Point wrote: > I found the bad commit. > > git bisect gave me the following: > > -- > ab94e562ed45c99914fe874b7feaf75b80ceea84 is the first bad commit > commit ab94e562ed45c99914fe874b7feaf75b80ceea84 > Author

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

On Wed, 8 Jul 2015, Greg KH wrote: > > > On Wed, 1 Jul 2015, Glasswall Information Point wrote: > > > > > >> Bug as submitted on: https://bugzilla.kernel.org/show_bug.cgi?id=100631 > > >> > > >> Mailing it to this mailing list on advice of greg k-h > > >> > > >> --

[PATCH v6 0/4] musb: sunxi: Add support for the Allwinner sunxi musb

Hi Felipe, As requested here is a new version of my "musb: sunxi: Add support for the Allwinner sunxi musb controller" patch, fixing the "Should it be static?" compiler warning. While working on this I noticed that sun4i_usb_phy_set_squelch_detect() from phy-sun4i-usb.c is missing an EXPORT_SYMBO

[PATCH v6 2/4] musb: sunxi: Add support for the Allwinner sunxi musb controller

This is based on initial code to get the Allwinner sunxi musb controller supported by Chen-Yu Tsai and Roman Byshko. This adds support for the Allwinner sunxi musb controller in both host only and otg mode. Peripheral only mode is not supported, as no boards use that. This has been tested on a cu

[PATCH v6 3/4] musb: sunxi: Add support for musb controller in A31 SoC

The A31 SoC uses the same musb controller as found in earlier SoCs, but it is hooked up slightly different. Its SRAM is private and no longer controlled through the SRAM controller, and its reset is controlled via a separate reset controller. This commit adds support for this setup. Signed-off-by:

[PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

sun4i_usb_phy_set_squelch_detect is used by other code, which may be built as a module, so it should be exported. Signed-off-by: Hans de Goede --- Changes in v6: -New patch in v6 of the sunxi musb support series --- drivers/phy/phy-sun4i-usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCH v6 4/4] musb: sunxi: Add support for musb controller in A33 SoC

The A33 SoC uses the same musb controller as found on the A31 and later, but allwinner has removed the configdata register, this commit adds special handling for this. Signed-off-by: Hans de Goede --- .../devicetree/bindings/usb/allwinner,sun4i-a10-musb.txt | 3 ++- drivers/usb/musb/sunxi.c

Re: [PATCH v3 4/9] usb: dwc3: core: Adapt to named interrupts

Hi, On 08/07/15 16:06, Sergei Shtylyov wrote: > Hello. > > On 7/8/2015 1:36 PM, Roger Quadros wrote: > >> From: Felipe Balbi > >> Add support to use interrupt names, > >> Following are the interrupt names > >> Peripheral Interrupt - peripheral >> HOST Interrupt - host >> OTG Interrupt - otg

Re: [PATCH v3 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

On 08/07/15 16:11, Sergei Shtylyov wrote: > Hello. > > On 7/8/2015 1:37 PM, Roger Quadros wrote: > >> We can't rely just on dr_mode to decide if we're in host or gadget >> mode when we're configured as otg/dual-role. So while dr_mode is >> OTG, we find out from the otg state machine if we're in

Re: linux-4.2-rc1/drivers/usb/host/ohci-tmio.c:104: possible missing break ?

On Wed, 8 Jul 2015, David Binderman wrote: > Hello there, > > [linux-4.2-rc1/drivers/usb/host/ohci-tmio.c:104]: (warning) Redundant bitwise > operation on 'pm' in 'switch' statement. 'break;' missing? > > ��� case 3: > ��� pm |= CCR_PM_USBPW3; > ��� case 2: > ��� pm |= C

Re: [PATCH] usb: gadget: dummy_hcd: fix status in transfer

On Wed, 8 Jul 2015, Rui Miguel Silva wrote: > >> --- a/drivers/usb/gadget/udc/dummy_hcd.c > >> +++ b/drivers/usb/gadget/udc/dummy_hcd.c > >> @@ -1367,8 +1367,10 @@ top: > >>/* many requests terminate without a short packet */ > >>} else { > >>if (req->re

Re: Re: [USB][OHCI]BugFix:Insert new ed at end of ohci->ed_rm_list to accomdate race condition

On Wed, 8 Jul 2015, AMAN DEEP wrote: > >Your analysis is correct, but I don't like the solution. The code you > >quoted above uses *last after finish_urb(), which is not a good idea. > > > >In my opinion, it would be better to go back to the way things were > >before commit 977dcfdc6031 and rem

Re: Cannot use the logitech k520 (046d:c52b) to unlock my luks disk at boot time

On Wed, 8 Jul 2015, Jiri Kosina wrote: > > > >> Bug as submitted on: https://bugzilla.kernel.org/show_bug.cgi?id=100631 > > > >> > > > >> Mailing it to this mailing list on advice of greg k-h > > > >> > > > >> -- > > > >>

[PATCH] usb: phy: qcom: New APQ8016/MSM8916 USB transceiver driver

Driver handles PHY initialization, clock management, power management and workarounds required after resetting the hardware. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/qcom,usb-8x16-phy.txt | 76 drivers/usb/phy/Kconfig| 14 + drivers/usb/ph

Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled

On Tue, 7 Jul 2015, Julius Werner wrote: > > Doug, how would you feel about reworking the patch that exports > > usb_wakeup_enabled_descendants()? Instead of doing it that way, create > > and export a new subroutine in hcd.c called > > usb_hcd_wakeup_not_needed(), or something similar. > > We ha

Re: [PATCH] usb: gadget: dummy_hcd: fix status in transfer

Hi Alan, On Wed, Jul 08, 2015 at 10:43:48AM -0400, Alan Stern wrote: On Wed, 8 Jul 2015, Rui Miguel Silva wrote: >> --- a/drivers/usb/gadget/udc/dummy_hcd.c >> +++ b/drivers/usb/gadget/udc/dummy_hcd.c >> @@ -1367,8 +1367,10 @@ top: >>/* many requests terminate without a short pa

[PATCH] cdc-acm: Destroy acm_minors IDR on module exit

Destroy acm_minors IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez ) @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@ module_init(init); @ defines_modul

[PATCH] USB: serial: Destroy serial_minors IDR on module exit

Destroy serial_minors IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez ) @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@ module_init(init); @ defines_mo

RE: linux-4.2-rc1/drivers/usb/host/ohci-tmio.c:104: possible missing break ?

Hello there Alan, > Instead of suggesting an incorrect fix, why don't you submit a patch > that fixes this correctly? I have a 0.0% (approx) success rate at submitting patches, so it would be pointless to try again for the umpteenth time. Mind you, I'm

[PATCH] USB: OHCI: fix bad #define in ohci-tmio.c

An incorrect definition of CCR_PM_USBPW3 in ohci-tmio.c is a perennial source of invalid diagnoses from static scanners, such as in . This patch fixes the definition. Signed-off-by: Alan Stern Reported-by: David Binderman CC: Dmitry Eremin-So

RE: [PATCH] USB: OHCI: fix bad #define in ohci-tmio.c

Hello there, > An incorrect definition of CCR_PM_USBPW3 in ohci-tmio.c is a perennial > source of invalid diagnoses from static scanners, such as in > . This patch > fixes the definition. Sure the patch

RE: [PATCH] USB: OHCI: fix bad #define in ohci-tmio.c

On Wed, 8 Jul 2015, David Binderman wrote: > Hello there, > > > > An incorrect definition of CCR_PM_USBPW3 in ohci-tmio.c is a perennial > > source of invalid diagnoses from static scanners, such as in > >

RE: [PATCH] USB: OHCI: fix bad #define in ohci-tmio.c

Hello there, > Are you certain of that? The analyzer output you posted says > "Redundant bitwise operation on 'pm' in 'switch' statement" -- that > "redundant" seems to refer to the fact that the macro values are the > same. Agreed - the macro values being

Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

Hi, On Wed, Jul 08, 2015 at 09:50:47AM +, Subbaraya Sundeep Bhatta wrote: > > > > > In any case, can you run on your setup with g_zero and > > > > > test.sh/testusb [1]/[2] just to verify that it really works for you ? > > Can you please send test.sh and testusb.c in attachment. I guess am >

Re: [PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support

Robert Baldyga writes: > Convert endpoint configuration to new capabilities model. The commit message is very short to judge the patch's correctness. I'll side up with Felipe's opinion. If it's fine by him, so it is by me. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsu

Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled

> But I don't see how you will make it work when the root hub itself is > not enabled for wakeup and a non-hub device plugged into one of the > root hub's ports is enabled. > > It seems like you would need a usb_hcd_wakeup_not_needed(hcd, port) > subroutine. We'd just put that in the Tegra platfor

Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled

On Wed, 8 Jul 2015, Julius Werner wrote: > > But I don't see how you will make it work when the root hub itself is > > not enabled for wakeup and a non-hub device plugged into one of the > > root hub's ports is enabled. > > > > It seems like you would need a usb_hcd_wakeup_not_needed(hcd, port) >

Re: [PATCH v6] usb: common: add API to set usb otg capabilities by device tree

On 06/23/2015 05:56 AM, Roger Quadros wrote: + Kukjin, Stephen, for board specific USB question. On Tue, 23 Jun 2015 16:35:49 +0800 Li Jun wrote: On Tue, Jun 23, 2015 at 10:43:28AM +0300, Roger Quadros wrote: If the dr_mode was "otg" for such case and we want OTG disabled then it is reall

Re: USB: OOPS 4.1.0-rc5-next-20150527 after lsusb -v

On Wednesday, July 08, 2015 10:24 PM, Fabio Estevam wrote: Hi Chris, On Thu, May 28, 2015 at 4:45 AM, Chris Ruehl wrote: FIXED by set the correct clock in the dts file, for the main_clk enabled in phy-generic.c Could you please share your dts change? I see the same issue on a imx27-pdk bo

Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

On 07/08/2015 02:11 AM, Hans de Goede wrote: Hi, On 07-07-15 18:47, Jeremy White wrote: Well, the checkpatch.pl reports were all style (and mostly whitespace); roughly 3000 of them against 3000 lines of code :-/. I did review the code, looking for areas where I thought it would badly cram i

Re: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

Hi Phil, On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote: > On 08 July 2015 00:08, Laurent wrote: > > On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: > > > These changes allow a PHY driver to trigger a VBUS interrupt and > > > to provide the value of VBUS. > > > > > > Signed-off-by:

[PATCH V3 1/1] usb:serial:f81534 add F81532/534 driver

This driver is for Fintek F81532/F81534 USB to Serial Ports IC. Features: 1. F81534 is 1-to-4 & F81532 is 1-to-2 serial ports IC 2. Support Baudrate from B50 to B150 (excluding B100). 3. The RTS signal can be transformed their behavior with configuration by default ioctl TIOCGRS485/TIOC

[PATCH] HID: usbhid: quirks for Corsair RGB keyboard & mice (K70R, K95RGB, M65RGB, K70RGB, K65RGB)

Review note (patch commit message starts below ---): I am currently setting HID_QUIRK_NO_INIT_REPORTS for these devices (which works), however this seems to largely to be the same as HID_QUIRK_NOGET that is otherwise automatically set on all boot-class interfaces, just the submission is skipped fur

Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

Hi, On 07-07-15 18:47, Jeremy White wrote: Well, the checkpatch.pl reports were all style (and mostly whitespace); roughly 3000 of them against 3000 lines of code :-/. I did review the code, looking for areas where I thought it would badly cram into the kernel, and I adjusted the few I found

Re: [PATCH 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

On Tue, Jul 07, 2015 at 06:00:27PM +0200, Robert Baldyga wrote: > Decrement is done in ffs_func_unbind() which is not called in this > error path. Oh. Duh. I got functionfs_unbind() and ffs_func_unbind() mixed up. Sorry. regards, dan carpenter -- To unsubscribe from this list: send the line "u

<    1   2