On Wed, 8 Jul 2015, David Binderman wrote: > Hello there, > > [linux-4.2-rc1/drivers/usb/host/ohci-tmio.c:104]: (warning) Redundant bitwise > operation on 'pm' in 'switch' statement. 'break;' missing? > > ������� case 3: > ����������� pm |= CCR_PM_USBPW3; > ������� case 2: > ����������� pm |= CCR_PM_USBPW2; > ������� case 1: > ����������� pm |= CCR_PM_USBPW1; > > Suggest add missing break.
I seem to recall receiving this same email from you a few times in the past. Instead of suggesting an incorrect fix, why don't you submit a patch that fixes this correctly? The real problem isn't a missing break; the problem is that CCR_PM_USBPW3 should be defined as 0x0010, not 0x0008. (This is pretty obvious when you look at the definitions of these preprocessor symbols.) Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
