RE: [PATCH 00/19] usb: third series of updates for dwc2 driver

2015-03-17 Thread Kaukab, Yousaf
> -Original Message- > From: zhangfei [mailto:zhangfei@linaro.org] > Sent: Monday, March 16, 2015 3:26 AM > To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; > john.y...@synopsys.com > Cc: Herrero, Gregory; r.bald...@samsung.com; > dingu...@opensource.altera.com > Subject: Re

Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c

2015-03-17 Thread gre...@linuxfoundation.org
On Tue, Mar 17, 2015 at 03:37:42AM +, Peter Chen wrote: > > > > > Greetings All, > > I have been getting the below build warnings: > > drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’: > > drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to > > integer of

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-03-17 Thread Ivan T. Ivanov
Hi, On Tue, 2015-03-17 at 11:01 +0900, Chanwoo Choi wrote: > Hi Ivan, > > On 03/16/2015 11:23 PM, Ivan T. Ivanov wrote: > > Hi Roger, > > > > On Mon, 2015-03-16 at 15:11 +0200, Roger Quadros wrote: > > > Hi Ivan, > > > > > > On 16/03/15 14:32, Ivan T. Ivanov wrote: > > > > Hi, > > > > > > > >

Re: [PATCH v4 1/1] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-03-17 Thread Ivan T. Ivanov
Fixed spelling error. On Tue, 2015-03-17 at 09:52 +0200, Ivan T. Ivanov wrote: > Hi, > > On Tue, 2015-03-17 at 11:01 +0900, Chanwoo Choi wrote: > > Hi Ivan, > > > > On 03/16/2015 11:23 PM, Ivan T. Ivanov wrote: > > > Hi Roger, > > > > > > On Mon, 2015-03-16 at 15:11 +0200, Roger Quadros wrote:

Re: [PATCH v2 7/7] ARM: omap2plus_defconfig: Enable EXTCON_GPIO_USB

2015-03-17 Thread Roger Quadros
On 16/03/15 19:53, Tony Lindgren wrote: > * Roger Quadros [150126 04:19]: >> This driver is needed for USB cable type detection on dra7-evm, >> dra72-evm and am57xx-beagle-x15. >> >> Signed-off-by: Roger Quadros > > Applying this into omap-for-v4.1/defconfig. I think it's all > queued up after t

[PATCH V9 07/10] USB: f81232: implement set_termios()

2015-03-17 Thread Peter Hung
The original driver had do not any h/w change in driver. This patch implements with configure H/W for baud/parity/word length/stop bits functional in f81232_set_termios(). This patch also implement DTR/RTS control when baudrate B0. We drop DTR/RTS when B0, otherwise enable it. We are checking bau

[PATCH V9 10/10] USB: f81232: modify/add author

2015-03-17 Thread Peter Hung
Add me to co-author and fix no '>' in greg kh's email Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index a0e0b9d..54cc707 100644 --- a/drivers/usb/serial/f

[PATCH V9 09/10] USB: f81232: cleanup non-used define

2015-03-17 Thread Peter Hung
We remove non-used define in this patch to avoid wrong usage. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index 0da16ce..a0e0b9d 100644 --- a/drivers/usb/ser

[PATCH V9 08/10] USB: f81232: clarify f81232_ioctl() and fix

2015-03-17 Thread Peter Hung
We extract TIOCGSERIAL section in f81232_ioctl() to f81232_get_serial_info() to make it clarify. Also we fix device type from 16654 to 16550A, and set it's baud_base to 115200 (1.8432MHz/16). Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 30 +++--- 1 file c

[PATCH V9 06/10] USB: f81232: implement port enable/disable method

2015-03-17 Thread Peter Hung
We put FCR/IER initial step to f81232_port_enable()/f81232_port_disable(). When port is open, it set MSR interrupt on. Otherwise set it off. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 49 + 1 file changed, 49 insertions(+) diff --git

[PATCH V9 05/10] USB: f81232: implement MCR/MSR function

2015-03-17 Thread Peter Hung
This patch implement relative MCR/MSR function, such like tiocmget()/tiocmset()/dtr_rts()/carrier_raised() original f81232_carrier_raised() compared with wrong value UART_DCD. It's should compared with UART_MSR_DCD. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 139 +++

[PATCH v1 00/20] usb: third series of updates for dwc2 driver

2015-03-17 Thread Mian Yousaf Kaukab
Hi, This patchset consists of some bug fixes and feature enhancements for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus of testing was with dma enabled. Although basic testing without dma was also done. This is based on testing/next branch in Felipe's

[PATCH v1 01/20] usb: dwc2: move debugfs code to a separate file

2015-03-17 Thread Mian Yousaf Kaukab
Prepare to add more debug code. Moreover, don't save dentry * for each file in struct dwc2_hsotg as clean up is done with debugfs_remove_recursive(). s3c_hsotg_delete_debug() is removed altogether for the same reason. Signed-off-by: Mian Yousaf Kaukab --- drivers/usb/dwc2/Makefile | 4 + dri

[PATCH v1 18/20] usb: dwc2: host: don't use dma_alloc_coherent with irqs disabled

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero Align buffer must be allocated using kmalloc since irqs are disabled. Coherency is handled through dma_map_single which can be used with irqs disabled. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd.c | 7 --- drivers/usb/dwc2/hcd_intr.c | 10

[PATCH v1 16/20] usb: dwc2: host: resume root hub on port connect

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero Once hub is runtime suspended, dwc2 must resume it on port connect event. Else, roothub will stay in suspended state and will not resume transfers. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd_intr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driver

[PATCH v1 14/20] usb: dwc2: host: register handle to the phy

2015-03-17 Thread Mian Yousaf Kaukab
If phy driver is present register hcd handle to it. Signed-off-by: Mian Yousaf Kaukab --- drivers/usb/dwc2/hcd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index a387e9f..130e9a2 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/

Re: [PATCH v2 3/3] ARM: mvebu: armada-385-ap: Enable USB3 port

2015-03-17 Thread Maxime Ripard
On Tue, Mar 03, 2015 at 06:12:44PM +0200, Mathias Nyman wrote: > On 03.03.2015 11:59, Maxime Ripard wrote: > > On Mon, Mar 02, 2015 at 08:23:37PM +0100, Gregory CLEMENT wrote: > >> Hi Maxime, > >> > >> On 19/01/2015 14:01, Maxime Ripard wrote: > >>> The Armada 385 AP board has a USB3 port exposed t

[PATCH v1 03/20] usb: dwc2: add controller hibernation support

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero When suspending usb bus, phy driver may disable controller power. In this case, registers need to be saved on suspend and restored on resume. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/core.c | 382 drivers/usb/dwc

[PATCH v1 09/20] usb: dwc2: gadget: ignore pm suspend/resume in L2

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero Nothing to be done in pm suspend/resume when controller is in L2. Don't disconnect or reset. State is already saved when putting controller in hibernation and will be restored on USB bus resume. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/gadget.c | 6 ++ 1 fi

[PATCH v1 06/20] usb: dwc2: add external_id_pin_ctl core parameter

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero This is required due to an Intel specific hardware issue. Where id- pin setup causes glitches on the interrupt line when CONIDSTSCHG interrupt is enabled. Specify external_id_pin_ctl when an external driver (for example phy) can handle id change, so that CONIDSTSCHG interru

[PATCH v1 04/20] usb: dwc2: implement hibernation during bus suspend/resume

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero Allow controller to enter in hibernation during usb bus suspend and inform both phy and gadget about the suspended state. While in hibernation, the controller can't detect the resume condition. An external mechanism must call usb_phy_set_suspend on resume. Exit hibernation w

[PATCH v1 05/20] usb: dwc2: controller must update lx_state before releasing lock

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero During suspend, there could a race condition between ep_queue and suspend interrupt if lx_state is updated after releasing spinlock in call_gadget(hsotg, suspend). Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/core_intr.c | 11 --- 1 file changed, 8 insertio

[PATCH v1 20/20] usb: dwc2: remove dwc2_platform.ko

2015-03-17 Thread Mian Yousaf Kaukab
Ac dwc2 pci module is now exporting dwc2 platform device, include platform.o in dwc2-y and remove USB_DWC2_PLATFORM configuration option. Driver will be built as two modules, dwc2.ko and dwc2_pci.ko. dwc2.ko is the new platform driver. Remove all EXPORT_SYMBOL_GPL as they are not needed any more.

[PATCH v1 13/20] usb: dwc2: gadget: remove s3c_hsotg_ep_disable_force

2015-03-17 Thread Mian Yousaf Kaukab
Force argument is not used anymore. Clean up leftovers from https://lkml.org/lkml/2014/12/9/283 Signed-off-by: Mian Yousaf Kaukab --- drivers/usb/dwc2/gadget.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 2e2

[PATCH v1 15/20] usb: dwc2: host: add bus_suspend/bus_resume callback

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 130e9a2..23a8f2f 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -23

[PATCH v1 02/20] usb: dwc2: debugfs: add support for complete register dump

2015-03-17 Thread Mian Yousaf Kaukab
Dump all registers to take a complete snapshot of dwc2 state. Code is inspired by dwc3/debugfs.c Signed-off-by: Mian Yousaf Kaukab --- drivers/usb/dwc2/core.h| 1 + drivers/usb/dwc2/debugfs.c | 356 + 2 files changed, 357 insertions(+) diff --gi

[PATCH v1 17/20] usb: dwc2: host: spinlock urb_enqueue

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero During urb_enqueue, if the urb can't be queued to the endpoint, the urb is freed without any spinlock protection. This leads to memory corruption when concurrent urb_dequeue try to free same urb->hcpriv. Thus, ensure the whole urb_enqueue in spinlocked. Signed-off-by: Grego

[PATCH v1 07/20] usb: dwc2: set parameter values in probe function

2015-03-17 Thread Mian Yousaf Kaukab
So the parameters can be used in both host and gadget modes. Also consolidate param functions in the core.h Signed-off-by: Mian Yousaf Kaukab --- drivers/usb/dwc2/core.c | 19 +++ drivers/usb/dwc2/core.h | 13 ++--- drivers/usb/dwc2/hcd.c | 34 +--

[PATCH v1 11/20] usb: dwc2: gadget: powerup controller if needed

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero During vbus session, usb controller needs to exit hibernation if it was previously in suspend state. Since controller will be resetted and configured, there is no need to restore registers. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/gadget.c | 8 1 file

[PATCH v1 19/20] usb: dwc2: host: implement test mode

2015-03-17 Thread Mian Yousaf Kaukab
From: Jingwu Lin Add support for SetPortFeature(PORT_TEST) for root port. Signed-off-by: Jingwu Lin --- drivers/usb/dwc2/hcd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 54f58c1..f8f3f5b 100644 --- a/drivers/usb/dwc2/hcd.c

[PATCH v1 10/20] usb: dwc2: gadget: prevent new request submission during suspend

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero If usb controller is in partial power down, any write to registers may cause unpredictable behavior. Thus, prevent any new request submission once controller is in partial power down. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/gadget.c | 7 +++ 1 file changed

[PATCH V9 00/10] usb: serial: F81232 V9 patches

2015-03-17 Thread Peter Hung
This series patch V9 is changed from V8 as following: 1. add comments for read URB 1byte LSR when port open. 2. change error handle flow of set_register()/get_register() V8 (old change): 1. The V7 MSR strange delta value is checked with locking problem. We changed f81232_set_mctrl() & f81232_r

[PATCH v1 08/20] usb: dwc2: gadget: use reset detect interrupt

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero ResetDet interrupt is used to detect a reset of the bus while the controller is suspended. This may happens for example when using Command Verifier. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/gadget.c | 19 --- 1 file changed, 16 insertions(+), 3

[PATCH V9 02/10] USB: f81232: implement RX bulk-in EP

2015-03-17 Thread Peter Hung
The F81232 bulk-in is RX data + LSR channel, data format is [LSR+Data][LSR+Data]. , We had implemented in f81232_process_read_urb(). Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 73 + 1 file changed, 40 insertions(+), 33 deletions(-)

[PATCH v1 12/20] usb: dwc2: gadget: enable otg flag in dual role configuration

2015-03-17 Thread Mian Yousaf Kaukab
From: Gregory Herrero Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index bb83826..2e27bfd 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -3524,

[PATCH V9 01/10] USB: f81232: rename private struct member name

2015-03-17 Thread Peter Hung
Change private struct member name from line_status to modem_status. It will store MSR for some functions used Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81

[PATCH V9 03/10] USB: f81232: change lock mechanism

2015-03-17 Thread Peter Hung
The original driver lock with spin_lock_irqsave()/spin_unlock_irqrestore() because of it's maybe used in interrupt context f81232_process_read_urb(). We had remove it from previous patch "implement RX bulk-in EP", so we can change it from busying loop spin_lock to sleepable mutex_lock. Signed-off

[PATCH V9 04/10] USB: f81232: implement read IIR/MSR with endpoint

2015-03-17 Thread Peter Hung
The interrupt endpoint will report current IIR. If we got IIR with MSR changed , We will do read MSR with interrupt_work worker to do f81232_read_msr() function. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 126 +--- 1 file changed, 118 inse

Re: [PATCH] phy: omap-usb2: Fix missing clk_prepare call when using old dt name

2015-03-17 Thread Roger Quadros
+stable, v3.16+ On 11/03/15 03:41, Axel Lin wrote: > Current code does not call clk_prepare(phy->optclk) when using the old > usb_otg_ss_refclk960m name. Fix it. > > Signed-off-by: Axel Lin Acked-by: Roger Quadros cheers, -roger > --- > drivers/phy/phy-omap-usb2.c | 5 +++-- > 1 file change

Re: [PATCH v2 2/5] usb: chipidea: udc: add OTG status request handling

2015-03-17 Thread Li Jun
On Tue, Mar 17, 2015 at 10:06:44AM +0800, Peter Chen wrote: > On Mon, Mar 16, 2015 at 12:21:53PM -0500, Felipe Balbi wrote: > > On Mon, Mar 16, 2015 at 05:34:43PM +0800, Li Jun wrote: > > > On Mon, Mar 16, 2015 at 05:03:17PM +0800, Peter Chen wrote: > > > > On Mon, Mar 16, 2015 at 04:15:22PM +0800,

Re: keyboard/trackpad combo unusable on MacBookPro4,1 with bcm5974.ko

2015-03-17 Thread Alan Stern
On Mon, 2 Mar 2015, Alan Stern wrote: > On Fri, 27 Feb 2015, Christian Böhme wrote: > > > Alan Stern writes: > > > > > > Specifically, HID_QUIRK_IGNORE_MOUSE existed in 2.6.27 > > > > and was dealt with in drivers/hid/usbhid/hid-core.c:730, > > > > thereby somehow "fixing things". But those li

[PATCH v3 6/8] usb: chipidea: otg: set host_request_flag for gadget

2015-03-17 Thread Li Jun
Set host_request_flag if the current peripheral wants to take host role via changing a_bus_req or b_bus_req by user application. Signed-off-by: Li Jun --- drivers/usb/chipidea/otg_fsm.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/otg_f

[PATCH v3 3/8] usb: common: otg-fsm: add HNP polling support

2015-03-17 Thread Li Jun
Adds HNP polling timer when transits to host state, the OTG status request will be sent to peripheral after timeout, if host request flag is set, it will switch to peripheral state, otherwise it will repeat HNP polling every 1.5s and maintain the current session. Signed-off-by: Li Jun --- driver

[PATCH v3 4/8] usb: chipidea: udc: bypass otg status selector request handling to gadget driver

2015-03-17 Thread Li Jun
Since gadget driver will handle this request, so controller driver bypass it. Signed-off-by: Li Jun --- drivers/usb/chipidea/udc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 4254792..a65cdaf 100644 --- a/

[PATCH v3 5/8] usb: gadget: composite: handle otg status selector request from OTG host

2015-03-17 Thread Li Jun
If gadget with HNP polling support receives GetStatus request of otg status selector, it feedback to host with host request flag to indicate if it wants to take host role. Signed-off-by: Li Jun --- drivers/usb/gadget/composite.c | 25 + 1 file changed, 17 insertions(+),

[PATCH v3 0/8] add HNP polling support for usb otg fsm

2015-03-17 Thread Li Jun
HNP polling is a mechanism which allows the OTG device currently acting as host to determine when the other attached OTG device wishes to take the host role. When an OTG host, which supports HNP, is connected to an OTG peripheral which also supports HNP it shall poll the peripheral regularly to det

[PATCH v3 7/8] usb: chipidea: otg: enable HNP polling support for gadget

2015-03-17 Thread Li Jun
Enable HNP polling support for chipidea gadget when otg fsm init. Signed-off-by: Li Jun --- drivers/usb/chipidea/otg_fsm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/chipidea/otg_fsm.c index 2ec90dc..82b1e23 100644 --- a/drivers/usb/chipid

[PATCH v3 1/8] usb: gadget: add hnp_polling_support and host_request_flag in usb_gadget

2015-03-17 Thread Li Jun
From: Li Jun Add 2 flags for USB OTG HNP polling, hnp_polling_support is to indicate if the gadget can support HNP polling, host_request_flag is used for gadget to store host request information from application, which can be used to respond to HNP polling from host. Signed-off-by: Li Jun ---

[PATCH v3 8/8] Documentation: usb: chipidea: Update test procedure for HNP polling

2015-03-17 Thread Li Jun
From: Li Jun Update HNP test procedure as HNP polling is supported. Signed-off-by: Li Jun --- Documentation/usb/chipidea.txt |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Documentation/usb/chipidea.txt b/Documentation/usb/chipidea.txt index 3f848c1..95d9170 10

[PATCH v3 2/8] usb: add OTG status selector definition for HNP polling

2015-03-17 Thread Li Jun
A host is required to use the GetStatus command, with wIndex set to the OTG status selector(F000H) to request the Host request flag from the peripheral. Signed-off-by: Li Jun --- include/uapi/linux/usb/ch9.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/usb/ch9.h b/

Re: keyboard/trackpad combo unusable on MacBookPro4,1 with bcm5974.ko

2015-03-17 Thread Jiri Slaby
On 03/17/2015, 03:20 PM, Alan Stern wrote: > On Mon, 2 Mar 2015, Alan Stern wrote: > >> On Fri, 27 Feb 2015, Christian Böhme wrote: >> >>> Alan Stern writes: >>> > Specifically, HID_QUIRK_IGNORE_MOUSE existed in 2.6.27 > and was dealt with in drivers/hid/usbhid/hid-core.c:730, > there

Re: [PATCH v2 1/1] usb: xhci: apply XHCI_AVOID_BEI quirk to all Intel xHCI controllers

2015-03-17 Thread Alistair Grant
On Mon, Mar 16, 2015 at 5:29 PM, Mathias Nyman wrote: > On 16.03.2015 17:21, Alistair Grant wrote: >> On Mon, Mar 16, 2015 at 3:47 PM, Mathias Nyman >> wrote: >>> On 16.03.2015 16:31, Alistair Grant wrote: On Mon, Mar 16, 2015 at 1:55 PM, Mathias Nyman wrote: > On 15.03.2015 21:18

Re: [Spice-devel] Questions on usbredir + XSpice

2015-03-17 Thread Hans de Goede
Hi, On 17-03-15 15:50, Jeremy White wrote: Hey Hans, I'm coming back around to this; we've been tasked to actually make this work. It seems as though adding usbredir support to the kernel, either as a flavor of usbip, or as a parallel solution is the best approach. But I realize I'm really ig

Re: USB 3.0 storage keep reconnecting after safely removed

2015-03-17 Thread Mathias Nyman
On 16.03.2015 22:17, Alan Stern wrote: > On Wed, 7 Jan 2015, Hans de Goede wrote: > >> Hi, >> >> On 07-01-15 16:19, Alan Stern wrote: >>> On Tue, 6 Jan 2015, Taegil Bae wrote: >>> Hi all, Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=90791 My machine is Thinkpad Yo

Re: cdc_mbim with Huawei E3372, nothing works

2015-03-17 Thread Sami Farin
On Mon, Feb 23, 2015 at 11:59:14 +0100, Bjørn Mork wrote: > So my conclusion is that there is some higher level USB communication > problem here, not directly involving neither usbnet nor the minidriver. Do you have new ideas as to where the problem might be? I have now used the cdc_ether driver t

[PATCH 5/5] ARM: at91/dt: remove useless usb clock

2015-03-17 Thread Boris Brezillon
The ohci driver now calls clk_set_rate on the uhpck clock (which forwards set_rate requests to its parent: the usb clock). Remove useless references to usb clocks from ohci definitions. Signed-off-by: Boris Brezillon --- arch/arm/boot/dts/at91rm9200.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9260.

[PATCH 4/5] ARM: at91/dt: remove useless uhpck clock references from ehci defintions

2015-03-17 Thread Boris Brezillon
The uhpck is useless for High-Speed communications, remove the reference to this clock in all ehci definitions. Signed-off-by: Boris Brezillon --- arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++-- arch/arm/boot/dts/sama5d3.dtsi | 4 ++-- arch/arm/boot/

[PATCH 3/5] USB: atmel: update DT bindings documentation

2015-03-17 Thread Boris Brezillon
Add documentation for the missing clocks, clock-names, reg and interrupts properties. Signed-off-by: Boris Brezillon --- .../devicetree/bindings/usb/atmel-usb.txt | 25 ++ 1 file changed, 25 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.

[PATCH 1/5] USB: ehci-atmel: rework clk handling

2015-03-17 Thread Boris Brezillon
The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) clocks to work properly. Remove the useless system clock (fclk). Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remove useless IS_ENABLED(CONFIG_COMMON_CLK) tests (all at91 platforms have been moved to the CCF). T

[PATCH 0/5] USB: atmel: rework clock handling

2015-03-17 Thread Boris Brezillon
Hello, This series reworks clock handling in atmel USB host drivers, and while doing so fixes a regression introduced by 3440ef1 (ARM: at91/dt: fix USB high-speed clock to select UTMI). Best Regards, Boris Boris Brezillon (5): USB: ehci-atmel: rework clk handling USB: host: ohci-at91: remov

[PATCH 2/5] USB: host: ohci-at91: remove useless uclk clock

2015-03-17 Thread Boris Brezillon
Now that the system clock driver is forwarding set_rate request to the parent clock, we can safely call clk_set_rate on the system clk and get rid of the uclk field. Signed-off-by: Boris Brezillon --- drivers/usb/host/ohci-at91.c | 18 +++--- 1 file changed, 3 insertions(+), 15 delet

[PATCH 0/2] xhci features for usb-next

2015-03-17 Thread Mathias Nyman
Hi Greg Two xhci patches for usb-next, one to add usb phy support to xhci-plat needed by Marvell Armada 385 AP to get its USB3 VBUS up. The other one is a tiny code consistency cleanup. -Mathias Lin Wang (1): xhci: unify cycle state toggling operation with 'XOR' Maxime Ripard (1): usb: xhci

[PATCH 1/2] xhci: unify cycle state toggling operation with 'XOR'

2015-03-17 Thread Mathias Nyman
From: Lin Wang Some toggling operation in xHCI driver still use conditional toggling: ring->cycle_state = (ring->cycle_state ? 0 : 1); Use XOR to invert the cycle state instead of a conditional toggle to unify cycle state toggling operation in xHCI driver. Signed-off-by: Lin Wang Signed-off-by

[PATCH 2/2] usb: xhci: plat: Add USB phy support

2015-03-17 Thread Mathias Nyman
From: Maxime Ripard The Marvell Armada 385 AP needs a dumb phy in order to enable the USB3 VBUS. Add a call to retrieve a USB PHY to XHCI plat in order to support this. Signed-off-by: Maxime Ripard Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-plat.c | 19 ++- 1 file

Re: [PATCH 00/12] Remove mach-msm and associated code

2015-03-17 Thread dwalker
On Fri, Mar 13, 2015 at 01:45:36PM -0700, Stephen Boyd wrote: > On 03/13/15 12:55, Arnd Bergmann wrote: > > On Friday 13 March 2015 11:09:33 Stephen Boyd wrote: > >> The maintainers for mach-msm no longer have any plans to support > >> or test the platforms supported by this architecture[1]. Most l

Re: [PATCH v2 3/3] ARM: mvebu: armada-385-ap: Enable USB3 port

2015-03-17 Thread Maxime Ripard
On Tue, Mar 17, 2015 at 06:34:21PM +0200, Mathias Nyman wrote: > On 17.03.2015 11:51, Maxime Ripard wrote: > > On Tue, Mar 03, 2015 at 06:12:44PM +0200, Mathias Nyman wrote: > >> On 03.03.2015 11:59, Maxime Ripard wrote: > >>> On Mon, Mar 02, 2015 at 08:23:37PM +0100, Gregory CLEMENT wrote: >

Re: [PATCH v2 2/5] usb: chipidea: udc: add OTG status request handling

2015-03-17 Thread Felipe Balbi
On Tue, Mar 17, 2015 at 10:06:44AM +0800, Peter Chen wrote: > On Mon, Mar 16, 2015 at 12:21:53PM -0500, Felipe Balbi wrote: > > On Mon, Mar 16, 2015 at 05:34:43PM +0800, Li Jun wrote: > > > On Mon, Mar 16, 2015 at 05:03:17PM +0800, Peter Chen wrote: > > > > On Mon, Mar 16, 2015 at 04:15:22PM +0800,

Re: [PATCH v2 3/3] ARM: mvebu: armada-385-ap: Enable USB3 port

2015-03-17 Thread Mathias Nyman
On 17.03.2015 11:51, Maxime Ripard wrote: > On Tue, Mar 03, 2015 at 06:12:44PM +0200, Mathias Nyman wrote: >> On 03.03.2015 11:59, Maxime Ripard wrote: >>> On Mon, Mar 02, 2015 at 08:23:37PM +0100, Gregory CLEMENT wrote: Hi Maxime, On 19/01/2015 14:01, Maxime Ripard wrote: > The

Re: Build failure: -next 20150316

2015-03-17 Thread John Youn
On 3/16/2015 8:53 PM, Felipe Balbi wrote: > Hi, > > On Mon, Mar 16, 2015 at 07:59:04PM +, Alan Cox wrote: >> drivers/built-in.o: In function `dwc2_pci_remove': >> /rotating/Kernel/next/drivers/usb/dwc2/pci.c:70: undefined reference to >> `usb_phy_generic_unregister' drivers/built-in.o: In func

Re: Build failure: -next 20150316

2015-03-17 Thread Felipe Balbi
On Tue, Mar 17, 2015 at 10:41:52AM -0700, John Youn wrote: > On 3/16/2015 8:53 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Mar 16, 2015 at 07:59:04PM +, Alan Cox wrote: > >> drivers/built-in.o: In function `dwc2_pci_remove': > >> /rotating/Kernel/next/drivers/usb/dwc2/pci.c:70: undefined r

[PATCH] usb: dwc2: pci: Correctly compile dwc2-pci as a module or built-in

2015-03-17 Thread John Youn
The dwc2-pci driver should be compiled as a module when configured to do so. If the dwc2-pci is configured as a module but actually built-in, it can cause build errors due to the fact that the generic-phy will be allowed to compile as a module causing undefined references. Reported-by: Alan Cox S

Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

2015-03-17 Thread Alan Stern
On Tue, 17 Mar 2015, Boris Brezillon wrote: > The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) > clocks to work properly. Remove the useless system clock (fclk). > > Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remove > useless IS_ENABLED(CONFIG_COMMON_CLK) te

Re: [PATCH 2/5] USB: host: ohci-at91: remove useless uclk clock

2015-03-17 Thread Alan Stern
On Tue, 17 Mar 2015, Boris Brezillon wrote: > Now that the system clock driver is forwarding set_rate request to the > parent clock, we can safely call clk_set_rate on the system clk and get > rid of the uclk field. > > Signed-off-by: Boris Brezillon Acked-by: Alan Stern -- To unsubscribe fro

Re: [PATCH v2 0/2] usb: dwc2: add support for big-endian Lantiq SoCs

2015-03-17 Thread John Youn
On 3/16/2015 7:24 PM, John Youn wrote: > On 3/12/2015 9:53 AM, Antti Seppälä wrote: >> Here are two patches needed to add support for mips based >> big-endian SoCs made by Lantiq to dwc2 driver. >> >> The first patch converts the readl/writel io-accessors of dwc2 to >> big-endian friendly versions

Re: cdc_mbim with Huawei E3372, nothing works

2015-03-17 Thread Bjørn Mork
Sami Farin writes: > On Mon, Feb 23, 2015 at 11:59:14 +0100, Bjørn Mork wrote: >> So my conclusion is that there is some higher level USB communication >> problem here, not directly involving neither usbnet nor the minidriver. > > Do you have new ideas as to where the problem might be? > I have no

[PATCH v2] phy: Add a driver for dm816x USB PHY

2015-03-17 Thread Tony Lindgren
Add a minimal driver for dm816x USB. This makes USB work on dm816x without any other changes needed as it can use the existing musb_dsps glue layer for the USB controller. Note that this phy is different from dm814x and am335x. Cc: Bin Liu Cc: Brian Hutchinson Cc: Felipe Balbi Cc: Matthijs van

Re: [PATCH v2 0/2] usb: dwc2: add support for big-endian Lantiq SoCs

2015-03-17 Thread Felipe Balbi
On Tue, Mar 17, 2015 at 12:23:03PM -0700, John Youn wrote: > On 3/16/2015 7:24 PM, John Youn wrote: > > On 3/12/2015 9:53 AM, Antti Seppälä wrote: > >> Here are two patches needed to add support for mips based > >> big-endian SoCs made by Lantiq to dwc2 driver. > >> > >> The first patch converts th

Re: [PATCH v2 2/5] usb: chipidea: udc: add OTG status request handling

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 12:09:22PM -0500, Felipe Balbi wrote: > On Tue, Mar 17, 2015 at 10:06:44AM +0800, Peter Chen wrote: > > On Mon, Mar 16, 2015 at 12:21:53PM -0500, Felipe Balbi wrote: > > > On Mon, Mar 16, 2015 at 05:34:43PM +0800, Li Jun wrote: > > > > On Mon, Mar 16, 2015 at 05:03:17PM +080

Re: [PATCH v3 2/8] usb: add OTG status selector definition for HNP polling

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:46PM +0800, Li Jun wrote: > A host is required to use the GetStatus command, with wIndex set to the OTG > status selector(F000H) to request the Host request flag from the peripheral. Small comment, "Host request flag" you may use all words in capital letter or lower l

Re: [PATCH v3 1/8] usb: gadget: add hnp_polling_support and host_request_flag in usb_gadget

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:45PM +0800, Li Jun wrote: > From: Li Jun > > Add 2 flags for USB OTG HNP polling, hnp_polling_support is to indicate if > the gadget can support HNP polling, host_request_flag is used for gadget > to store host request information from application, which can be used

Re: [PATCH v1 03/20] usb: dwc2: add controller hibernation support

2015-03-17 Thread John Youn
On 3/17/2015 2:54 AM, Mian Yousaf Kaukab wrote: > From: Gregory Herrero > > When suspending usb bus, phy driver may disable controller power. > In this case, registers need to be saved on suspend and restored > on resume. > > Signed-off-by: Gregory Herrero > --- > drivers/usb/dwc2/core.c | 382

Re: [PATCH v1 12/20] usb: dwc2: gadget: enable otg flag in dual role configuration

2015-03-17 Thread John Youn
On 3/17/2015 2:54 AM, Mian Yousaf Kaukab wrote: > From: Gregory Herrero > > Signed-off-by: Gregory Herrero > --- > drivers/usb/dwc2/gadget.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c > index bb83826..2e27bfd 100644 > --- a

Re: [PATCH v1 17/20] usb: dwc2: host: spinlock urb_enqueue

2015-03-17 Thread John Youn
On 3/17/2015 2:54 AM, Mian Yousaf Kaukab wrote: > From: Gregory Herrero > > During urb_enqueue, if the urb can't be queued to the endpoint, > the urb is freed without any spinlock protection. > This leads to memory corruption when concurrent urb_dequeue try to free > same urb->hcpriv. > Thus, ens

Re: [PATCH v1 00/20] usb: third series of updates for dwc2 driver

2015-03-17 Thread John Youn
On 3/17/2015 2:54 AM, Mian Yousaf Kaukab wrote: > Hi, > This patchset consists of some bug fixes and feature enhancements for > the dwc2 driver. All the patches are verified on dwc2 v3.0a with > dedicated fifos. Main focus of testing was with dma enabled. Although > basic testing without dma was al

Re: [PATCH v1 02/20] usb: dwc2: debugfs: add support for complete register dump

2015-03-17 Thread John Youn
On 3/17/2015 2:54 AM, Mian Yousaf Kaukab wrote: > Dump all registers to take a complete snapshot of dwc2 state. > Code is inspired by dwc3/debugfs.c > > Signed-off-by: Mian Yousaf Kaukab > --- > drivers/usb/dwc2/core.h| 1 + > drivers/usb/dwc2/debugfs.c | 356 > +++

Re: [PATCH v3 3/8] usb: common: otg-fsm: add HNP polling support

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:47PM +0800, Li Jun wrote: > Adds HNP polling timer when transits to host state, the OTG status request > will be sent to peripheral after timeout, if host request flag is set, it will > switch to peripheral state, otherwise it will repeat HNP polling every 1.5s > and

Re: [PATCH v3 4/8] usb: chipidea: udc: bypass otg status selector request handling to gadget driver

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:48PM +0800, Li Jun wrote: > Since gadget driver will handle this request, so controller driver bypass it. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/udc.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea

Re: [PATCH v3 5/8] usb: gadget: composite: handle otg status selector request from OTG host

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:49PM +0800, Li Jun wrote: > If gadget with HNP polling support receives GetStatus request of otg status > selector, it feedback to host with host request flag to indicate if it wants > to take host role. > > Signed-off-by: Li Jun > --- > drivers/usb/gadget/composite

Re: [PATCH v3 6/8] usb: chipidea: otg: set host_request_flag for gadget

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:50PM +0800, Li Jun wrote: > Set host_request_flag if the current peripheral wants to take host role > via changing a_bus_req or b_bus_req by user application. %s/changing/setting After changing avoid, add: Acked-by: Peter Chen > > Signed-off-by: Li Jun > --- > d

Re: [PATCH v3 7/8] usb: chipidea: otg: enable HNP polling support for gadget

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:51PM +0800, Li Jun wrote: > Enable HNP polling support for chipidea gadget when otg fsm init. > > Signed-off-by: Li Jun > --- > drivers/usb/chipidea/otg_fsm.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/c

Re: [PATCH v3 8/8] Documentation: usb: chipidea: Update test procedure for HNP polling

2015-03-17 Thread Peter Chen
On Tue, Mar 17, 2015 at 10:37:52PM +0800, Li Jun wrote: > From: Li Jun > > Update HNP test procedure as HNP polling is supported. > > Signed-off-by: Li Jun > --- > Documentation/usb/chipidea.txt |9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/Documentation