Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-24 Thread Roger Quadros
Hi Zhangfei, On 22/02/15 05:10, zhangfei wrote: > Hi, Balbi > > On 02/22/2015 12:21 AM, Felipe Balbi wrote: >> Hi, >> >> On Sat, Feb 21, 2015 at 11:03:05PM +0800, zhangfei wrote: >>> +static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) >>> +{ >>> +struct usb_otg

[PATCH V7 11/11] USB: f81232: modify/add author

2015-02-24 Thread Peter Hung
Add me to co-author and fix no '>' in greg kh's email Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index ee9a2a2..23f0a17 100644 --- a/drivers/usb/serial/f

[PATCH V7 09/11] USB: f81232: clarify f81232_ioctl() and fix

2015-02-24 Thread Peter Hung
We extract TIOCGSERIAL section in f81232_ioctl() to f81232_get_serial_info() to make it clarify. Also we fix device type from 16654 to 16550A, and set it's baud_base to 115200 (1.8432MHz/16). Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 30 +++--- 1 file c

[PATCH V7 10/11] USB: f81232: cleanup non-used define

2015-02-24 Thread Peter Hung
We remove non-used define in this patch to avoid wrong usage. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index 3b0da70..ee9a2a2 100644 --- a/drivers/usb/ser

[PATCH V7 07/11] USB: f81232: implement port_enable function

2015-02-24 Thread Peter Hung
We put FCR/IER initial step to f81232_port_enable(). When port is open, it set MSR interrupt on. Otherwise set it off. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/usb/serial/f81232.

[PATCH V7 08/11] USB: f81232: implement set_termios()

2015-02-24 Thread Peter Hung
The original driver had do not any h/w change in driver. This patch implements with configure H/W for baud/parity/word length/stop bits functional in f81232_set_termios(). This patch also implement DTR/RTS control when baudrate B0. We drop DTR/RTS when B0, otherwise enable it. Signed-off-by: Pete

[PATCH V7 05/11] USB: f81232: implement read IIR/MSR with endpoint

2015-02-24 Thread Peter Hung
The interrupt endpoint will report current IIR. If we got IIR with MSR changed , We will do read MSR with interrupt_work worker to do f81232_read_msr() function. We also confirmd MSR strange delta value is not locking-issue. The issue is set MCR & get MSR before IIR notice with MSR changed (Loopba

[PATCH V7 01/11] USB: f81232: rename private struct member name

2015-02-24 Thread Peter Hung
Change private struct member name from line_status to modem_status. It will store MSR for some functions used Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81

[PATCH V7 02/11] USB: f81232: add preparatory functions

2015-02-24 Thread Peter Hung
We add f81232_get_register()/f81232_set_register() and necessary defines for future patch with communication with F81232 USB control endpoint. Because of this is a preparatory patch, there are unused function warning with compiling. The functions will used with following patches. Signed-off-by: P

[PATCH V7 03/11] USB: f81232: implement RX bulk-in EP

2015-02-24 Thread Peter Hung
The F81232 bulk-in is RX data + LSR channel, data format is [LSR+Data][LSR+Data]. , We had implemented in f81232_process_read_urb(). Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 69 +++-- 1 file changed, 36 insertions(+), 33 deletions(-)

[PATCH V7 04/11] USB: f81232: change lock mechanism

2015-02-24 Thread Peter Hung
The original driver lock with spin_lock_irqsave()/spin_unlock_irqrestore() because of it's maybe used in interrupt context f81232_process_read_urb(). We had remove it from previous patch "implement RX bulk-in EP", so we can change it from busying loop spin_lock to sleepable mutex_lock. Signed-off

[PATCH V7 06/11] USB: f81232: implement MCR/MSR function

2015-02-24 Thread Peter Hung
This patch implement relative MCR/MSR function, such like tiocmget()/tiocmset()/dtr_rts()/carrier_raised() original f81232_carrier_raised() compared with wrong value UART_DCD. It's should compared with UART_MSR_DCD. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 103 +++

[PATCH V7 00/11] USB: f81232: V7 patches

2015-02-24 Thread Peter Hung
This series patch V7 is changed from V6 as following: 1. The buffer of usb_control_msg() in set_register()/get_register() are change from local variable to kmalloc(). (PATCH V7 02/11) 2. Change all set_register()/get_register() return value 0 is success, otherwise are failed. ( return 0 of

Re: MUSB dual-role on AM335x behaving weirdly

2015-02-24 Thread Maxime Ripard
On Thu, Feb 05, 2015 at 02:21:42PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Jan 22, 2015 at 08:37:45AM +0100, Yegor Yefremov wrote: > > I have the same experience with 3.15. The switching is working when > > CONFIG_USB_MUSB_DUAL_ROLE is set and dr_mode = "otg". But since 3.16 > > it seems to

Re: XHCI, "brain-dead scanner", and microframe rounding

2015-02-24 Thread Hans-Peter Jansen
On Donnerstag, 19. Februar 2015 16:07:41 Mathias Nyman wrote: > On 18.02.2015 14:27, Hans-Peter Jansen wrote: > > Mathias Nyman writes: > >> On 27.01.2015 13:57, Hans-Peter Jansen wrote: > >>> What about a stable backport? Do you think, it's feasible, too much > >>> work, or too risky? > >> > >>

[PATCH v4] xhci: fix reporting of 0-sized URBs in control endpoint

2015-02-24 Thread Aleksander Morgado
When a control transfer has a short data stage, the xHCI controller generates two transfer events: a COMP_SHORT_TX event that specifies the untransferred amount, and a COMP_SUCCESS event. But when the data stage is not short, only the COMP_SUCCESS event occurs. Therefore, xhci-hcd must set urb->act

Re: MUSB dual-role on AM335x behaving weirdly

2015-02-24 Thread Felipe Balbi
Hi, On Tue, Feb 24, 2015 at 11:39:11AM +0100, Maxime Ripard wrote: > On Thu, Feb 05, 2015 at 02:21:42PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Thu, Jan 22, 2015 at 08:37:45AM +0100, Yegor Yefremov wrote: > > > I have the same experience with 3.15. The switching is working when > > > CONFI

Re: [PATCH 00/29] Equivalent of g_printer with configfs

2015-02-24 Thread Felipe Balbi
On Tue, Feb 24, 2015 at 08:15:48AM +0100, Andrzej Pietrasiewicz wrote: > W dniu 23.02.2015 o 16:01, Andrzej Pietrasiewicz pisze: > >This series aims at integrating configfs into hid, the way > > Of course I meant printer. Sorry about confusion. no problem :-) -- balbi signature.asc Descriptio

[PATCH] usb: storage: Fix trivial typo in isd200_log_config()

2015-02-24 Thread Yannick Guerrini
Change 'Supsend' to 'Suspend' Signed-off-by: Yannick Guerrini --- drivers/usb/storage/isd200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c index 599d8bf..0761786 100644 --- a/drivers/usb/storage/isd200.c +++ b/dr

[PATCH 2/3] xhci: Allocate correct amount of scratchpad buffers

2015-02-24 Thread Mathias Nyman
Include the high order bit fields for Max scratchpad buffers when calculating how many scratchpad buffers are needed. I'm suprised this hasn't caused more issues, we never allocated more than 32 buffers even if xhci needed more. Either we got lucky and xhci never really used past that area, or the

[PATCH 1/3] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks

2015-02-24 Thread Mathias Nyman
From: Maxime Ripard The commit 973747928514 ("usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers") extended the xhci-plat driver to support the Armada 375/38x SoCs, mostly by adding a quirk configuring the MBUS window. However, that quirk was run before the clock the contr

Re: XHCI, "brain-dead scanner", and microframe rounding

2015-02-24 Thread Mathias Nyman
On 24.02.2015 12:41, Hans-Peter Jansen wrote: > On Donnerstag, 19. Februar 2015 16:07:41 Mathias Nyman wrote: >> On 18.02.2015 14:27, Hans-Peter Jansen wrote: >>> Mathias Nyman writes: On 27.01.2015 13:57, Hans-Peter Jansen wrote: > What about a stable backport? Do you think, it's feasibl

[PATCH 3/3] xhci: Clear the host side toggle manually when endpoint is 'soft reset'

2015-02-24 Thread Mathias Nyman
Main benefit of this is to get xhci connected USB scanners to work. Some devices use a clear endpoint halt request as a 'soft reset' even if the endpoint is not halted. This will clear the toggle and sequence on the device side. xHCI however refuses to reset a non-halted endpoint, so instead we ne

[PATCH 0/3] xhci fixes for 4.0-rc2

2015-02-24 Thread Mathias Nyman
Hi Greg Three xhci patches for usb-linus this time. Fixing issues like allocating the correct amount of DMA memory for xhci controller (not less like it sometimes did), fix Armada 375/38x XHCI support by making sure clocks are on before touching the xhci controller, and finally fixing an issue wh

Re: [PATCH 0/3] xhci fixes for 4.0-rc2

2015-02-24 Thread Mathias Nyman
On 24.02.2015 17:48, Mathias Nyman wrote: > Hi Greg > > Three xhci patches for usb-linus this time. And I just noticed they are missing the proper Tested-by and other credits, Sorry about that. I'll resend -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

[GIT PULL] USB fixes for v4.0-rc2

2015-02-24 Thread Felipe Balbi
Hi Greg, Here's my first set of fixes for this -rc. Let me know if you need anything to be changed. cheers The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14 -0800) are available in the git repository at: git://git.kernel.org/pu

Re: [PATCH 0/3] xhci fixes for 4.0-rc2

2015-02-24 Thread Greg KH
On Tue, Feb 24, 2015 at 06:17:10PM +0200, Mathias Nyman wrote: > On 24.02.2015 17:48, Mathias Nyman wrote: > > Hi Greg > > > > Three xhci patches for usb-linus this time. > > And I just noticed they are missing the proper Tested-by and other credits, > Sorry about that. > > I'll resend Thanks,

[PATCH v2 1/3] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks

2015-02-24 Thread Mathias Nyman
From: Maxime Ripard The commit 973747928514 ("usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers") extended the xhci-plat driver to support the Armada 375/38x SoCs, mostly by adding a quirk configuring the MBUS window. However, that quirk was run before the clock the contr

[PATCH v2 2/3] xhci: Allocate correct amount of scratchpad buffers

2015-02-24 Thread Mathias Nyman
Include the high order bit fields for Max scratchpad buffers when calculating how many scratchpad buffers are needed. I'm suprised this hasn't caused more issues, we never allocated more than 32 buffers even if xhci needed more. Either we got lucky and xhci never really used past that area, or the

[PATCH v2 3/3] xhci: Clear the host side toggle manually when endpoint is 'soft reset'

2015-02-24 Thread Mathias Nyman
Main benefit of this is to get xhci connected USB scanners to work. Some devices use a clear endpoint halt request as a 'soft reset' even if the endpoint is not halted. This will clear the toggle and sequence on the device side. xHCI however refuses to reset a non-halted endpoint, so instead we ne

[PATCH v2 0/3] xhci fixes for 4.0-rc2

2015-02-24 Thread Mathias Nyman
Hi Greg Second try, only change is adding testing credits to commit messages. Three xhci patches for usb-linus this time. Fixing issues like allocating the correct amount of DMA memory for xhci controller (not less like it sometimes did), fix Armada 375/38x XHCI support by making sure clocks are

Re: [GIT PULL] USB fixes for v4.0-rc2

2015-02-24 Thread Greg KH
On Tue, Feb 24, 2015 at 10:22:59AM -0600, Felipe Balbi wrote: > Hi Greg, > > Here's my first set of fixes for this -rc. Let me know if you > need anything to be changed. > > cheers > > The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: > > Linux 4.0-rc1 (2015-02-22 1

Re: XHCI, "brain-dead scanner", and microframe rounding

2015-02-24 Thread Hans-Peter Jansen
On Dienstag, 24. Februar 2015 17:53:25 Mathias Nyman wrote: > On 24.02.2015 12:41, Hans-Peter Jansen wrote: > > On Donnerstag, 19. Februar 2015 16:07:41 Mathias Nyman wrote: > >> On 18.02.2015 14:27, Hans-Peter Jansen wrote: > >>> Mathias Nyman writes: > On 27.01.2015 13:57, Hans-Peter Jansen

Re: MUSB dual-role on AM335x behaving weirdly

2015-02-24 Thread Maxime Ripard
Hi Felipe, On Tue, Feb 24, 2015 at 08:54:01AM -0600, Felipe Balbi wrote: > Hi, > > On Tue, Feb 24, 2015 at 11:39:11AM +0100, Maxime Ripard wrote: > > On Thu, Feb 05, 2015 at 02:21:42PM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Thu, Jan 22, 2015 at 08:37:45AM +0100, Yegor Yefremov wrot

Re: MUSB dual-role on AM335x behaving weirdly

2015-02-24 Thread Felipe Balbi
Hi, On Tue, Feb 24, 2015 at 05:50:50PM +0100, Maxime Ripard wrote: > Hi Felipe, > > On Tue, Feb 24, 2015 at 08:54:01AM -0600, Felipe Balbi wrote: > > Hi, > > > > On Tue, Feb 24, 2015 at 11:39:11AM +0100, Maxime Ripard wrote: > > > On Thu, Feb 05, 2015 at 02:21:42PM +0100, Maxime Ripard wrote: >

[PATCH] usb: isp1760: fix peripheral/device controller chip id

2015-02-24 Thread Sudeep Holla
As per the ISP1761 data sheet, the DcChipID register represents the hardware version number (0015h) and the chip ID (8210h) for the Peripheral Controller. This patch fixes the chip ID value used to verify the controller. Cc: Felipe Balbi Cc: Laurent Pinchart Signed-off-by: Sudeep Holla --- dr

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-24 Thread David Cohen
Hi, [snip] > Felipe suggested to "divide to conquer" instead of having a single > extcon driver to handle all these functions: > > - The mux functions would be controlled by a possible new pinctrl-gpio > driver (Linus, your input here would be nice :) > - The VBUS would be a fixed regulator > -