Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Johan Hovold
On Mon, Oct 27, 2014 at 08:40:51PM +0100, Oliver Neukum wrote: > On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: > > > I guess we could use that quirk, but I'm actually leaning towards just > > removing that quirk and reducing the log level of the message to info. > > > > Oliver, what do y

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Bjørn Mork
Johan Hovold writes: > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one > message during probe), and most devices are simply matched on the > interface class fields anyway. I'm not sure we want to start registering > devices with broken bmCapabilities in the driver (rather

[PATCH] cdc-acm: Drop the warning for unusual capabilities

2014-10-28 Thread Oliver Neukum
Let's drop the warning for modems with unusual capabilities, the associated quirk and blacklist. They made little sense. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 7 --- drivers/usb/class/cdc-acm.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/usb/class/cd

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Tue, 2014-10-28 at 08:03 +0100, Johan Hovold wrote: > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent > one > message during probe), and most devices are simply matched on the > interface class fields anyway. I'm not sure we want to start > registering > devices with broken

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Tue, 2014-10-28 at 10:05 +0100, Bjørn Mork wrote: > Johan Hovold writes: > > > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one > > message during probe), and most devices are simply matched on the > > interface class fields anyway. I'm not sure we want to start registe

[PATCH] xhci: Disable streams on Asmedia 1042 xhci controllers

2014-10-28 Thread Hans de Goede
Streams seem to be broken on the Asmedia 1042. An uas capable Seagate disk which is known to work fine with other controllers causes the system to freeze when connected over usb-3 with this controller, where as it works fine with uas in usb-2 ports, indicating a problem with streams. This is a bit

Re: [PATCH] cdc-acm: Drop the warning for unusual capabilities

2014-10-28 Thread Karl Palsson
On Tue, Oct 28, 2014 at 10:20:29AM +0100, Oliver Neukum wrote: > Let's drop the warning for modems with unusual capabilities, > the associated quirk and blacklist. They made little sense. > [snip] > @@ -1796,11 +1794,6 @@ static const struct usb_device_id acm_ids[] = { > > /* NOTE: non-Nok

Re: [PATCH] cdc-acm: Drop the warning for unusual capabilities

2014-10-28 Thread Johan Hovold
On Tue, Oct 28, 2014 at 10:12:08AM +, Karl Palsson wrote: > On Tue, Oct 28, 2014 at 10:20:29AM +0100, Oliver Neukum wrote: > > Let's drop the warning for modems with unusual capabilities, > > the associated quirk and blacklist. They made little sense. > > > [snip] > > @@ -1796,11 +1794,6 @@ st

Re: [PATCH] cdc-acm: Drop the warning for unusual capabilities

2014-10-28 Thread Oliver Neukum
On Tue, 2014-10-28 at 11:17 +0100, Johan Hovold wrote: > On Tue, Oct 28, 2014 at 10:12:08AM +, Karl Palsson wrote: > > On Tue, Oct 28, 2014 at 10:20:29AM +0100, Oliver Neukum wrote: > > > Let's drop the warning for modems with unusual capabilities, > > > the associated quirk and blacklist. They

Re: [PATCH] cdc-acm: Drop the warning for unusual capabilities

2014-10-28 Thread Johan Hovold
On Tue, Oct 28, 2014 at 11:37:15AM +0100, Oliver Neukum wrote: > On Tue, 2014-10-28 at 11:17 +0100, Johan Hovold wrote: > > On Tue, Oct 28, 2014 at 10:12:08AM +, Karl Palsson wrote: > > > On Tue, Oct 28, 2014 at 10:20:29AM +0100, Oliver Neukum wrote: > > > > Let's drop the warning for modems wi

Re: [PATCH] cdc-acm: Drop the warning for unusual capabilities

2014-10-28 Thread Johan Hovold
On Tue, Oct 28, 2014 at 11:50:48AM +0100, Johan Hovold wrote: > On Tue, Oct 28, 2014 at 11:37:15AM +0100, Oliver Neukum wrote: > > On Tue, 2014-10-28 at 11:17 +0100, Johan Hovold wrote: > > > On Tue, Oct 28, 2014 at 10:12:08AM +, Karl Palsson wrote: > > > > On Tue, Oct 28, 2014 at 10:20:29AM +0

[PATCH] usb: gadget: don't create new string_container if already exist

2014-10-28 Thread Neil Zhang
Don't create new usb_gadget_string_container if the current strings are already exist in the usb_composite_dev. Otherwise the ids_tab will overflow soon if we bind / unbind usb functions frequently like android does. Signed-off-by: Neil Zhang --- drivers/usb/gadget/composite.c |6 ++ 1 f

[PATCH v3 17/19] PCI: Add support for AMD Nolan USB3 DRD

2014-10-28 Thread Huang Rui
This patch adds PCI id for USB3 Dual-Role Device of AMD Nolan (NL) SoC. It will be used for PCI quirks and DWC3 device driver. Signed-off-by: Jason Chang Signed-off-by: Huang Rui --- include/linux/pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/pci_ids.h b/include/li

[PATCH v3 18/19] PCI: Add quirk to prevent AMD NL USB3 DRD to bind with xHCI driver

2014-10-28 Thread Huang Rui
The AMD Nolan (NL) SoC contains a DesignWare USB3 Dual-Role Device that can be operated either as a USB Host or a USB Device. In the AMD NL platform, this device ([1022:7912]) has a class code of PCI_CLASS_SERIAL_USB_XHCI (0x0c0330), which means the xhci driver will claim it. But the dwc3 driver

[PATCH v3 15/19] usb: dwc3: add disable usb3 suspend phy quirk

2014-10-28 Thread Huang Rui
This patch adds disable usb3 suspend phy quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/platform_data.h | 1 + 3 files changed, 9 insertions(

[PATCH v3 13/19] usb: dwc3: add tx demphasis quirk

2014-10-28 Thread Huang Rui
This patch adds Tx demphasis quirk, and the Tx demphasis value is configurable according to PIPE3 specification. Value Description 0 -6dB de-emphasis 1 -3.5dB de-emphasis 2 No de-emphasis 3 Reserved It can be configured on DT or pl

[PATCH v3 12/19] usb: dwc3: add rx_detect to polling lfps quirk

2014-10-28 Thread Huang Rui
This patch adds RX_DETECT to Polling.LFPS control quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/platform_data.h | 1 + 3 files changed, 10

[PATCH v3 16/19] usb: dwc3: add disable usb2 suspend phy quirk

2014-10-28 Thread Huang Rui
This patch adds disable usb2 suspend phy quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/platform_data.h | 1 + 3 files changed, 9 insertions(

[PATCH v3 19/19] usb: dwc3: add support for AMD NL platform

2014-10-28 Thread Huang Rui
This patch adds support for AMD Nolan (NL) FPGA and SoC platform. Cc: Jason Chang Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 9 + drivers/usb/dwc3/core.h | 2 ++ drivers/usb/dwc3/dwc3-pci.c | 19 +++ drivers/usb/dwc3/platform_data.h |

[PATCH v3 10/19] usb: dwc3: add delay phy power change quirk

2014-10-28 Thread Huang Rui
This patch adds delay PHY power change from P0 to P1/P2/P3 when link state changing from U0 to U1/U2/U3 respectively, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 3 +++

[PATCH v3 14/19] usb: dwc3: set SUSPHY bit for all cores

2014-10-28 Thread Huang Rui
It is recommended to set USB3 and USB2 SUSPHY bits to '1' after the core initialization is completed above the dwc3 revision 1.94a. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers

[PATCH v3 06/19] usb: dwc3: add u2exit lfps quirk

2014-10-28 Thread Huang Rui
This patch adds u2exit lfps quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/platform_data.h | 1 + 3 files changed, 10 insertions(+) diff --

[PATCH v3 09/19] usb: dwc3: add delay p1p2p3 quirk

2014-10-28 Thread Huang Rui
This patch adds delay P0 to P1/P2/P3 quirk for U2/U2/U3, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 5 + drivers/usb/dwc3/platform_data.h | 1 + 3 files changed, 1

[PATCH v3 11/19] usb: dwc3: add lfps filter quirk

2014-10-28 Thread Huang Rui
This patch adds LFPS filter quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/platform_data.h | 1 + 3 files changed, 10 insertions(+) diff --

[PATCH v3 07/19] usb: dwc3: add P3 in U2 SS inactive quirk

2014-10-28 Thread Huang Rui
This patch adds P3 in U2 SS inactive quirk, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 23 +++ drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/platform_data.h | 1 + 3 files chang

[PATCH v3 08/19] usb: dwc3: add request p1p2p3 quirk

2014-10-28 Thread Huang Rui
This patch adds request P1/P2/P3 quirk for U2/U2/U3, and some special platforms can configure that if it is needed. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 6 ++ drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/platform_data.h | 1 + 3 files changed, 10 inse

[PATCH v3 00/19] usb: dwc3: add support for AMD Nolan SoC

2014-10-28 Thread Huang Rui
Hi, The series of patches add AMD Nolan (NL) SoC support for DesignWare USB3 OTG IP with PCI bus glue layer. This controller supported hibernation, LPM erratum and used the 2.80a IP version and amd own phy. Current implementation support both simulation and SoC platform. And already tested with ga

[PATCH v3 02/19] usb: dwc3: add a flag to check if it is fpga board

2014-10-28 Thread Huang Rui
Some chip vendor is on pre-silicon phase, which needs to use the simulation board. It should have the same product and vendor id with the true soc, but might have some minor different configurations. Below thread discussion proposes to find a method to distinguish between simulation board and soc.

[PATCH v3 03/19] usb: dwc3: initialize platform data at pci glue layer

2014-10-28 Thread Huang Rui
This patch initializes platform data at pci glue layer, and SoCs x86-based platform vendor is able to define their flags in platform data at bus glue layer. Then do some independent behaviors at dwc3 core level. Signed-off-by: Huang Rui --- drivers/usb/dwc3/dwc3-pci.c | 9 + 1 file chang

[PATCH v3 04/19] usb: dwc3: add disscramble quirk

2014-10-28 Thread Huang Rui
This patch adds disscramble quirk, and it only needs to be enabled at fpga board on some vendor platforms. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 14 +- drivers/usb/dwc3/core.h | 3 +++ drivers/usb/dwc3/platform_data.h | 2 ++ 3 files changed, 18 i

[PATCH v3 05/19] usb: dwc3: add lpm erratum support

2014-10-28 Thread Huang Rui
When parameter DWC_USB3_LPM_ERRATA_ENABLE is enabled in Andvanced Configuration of coreConsultant, it supports of xHCI BESL Errata Dated 10/19/2011 is enabled in host mode. In device mode it adds the capability to send NYET response threshold based on the BESL value received in the LPM token, and t

[PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Huang Rui
It enables hibernation if the function is set in coreConsultant. Suggested-by: Felipe Balbi Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index fa396fc..bf77509 100644 --- a/drivers/usb/

Re: [PATCH v3 18/19] PCI: Add quirk to prevent AMD NL USB3 DRD to bind with xHCI driver

2014-10-28 Thread Sergei Shtylyov
Hello. On 10/28/2014 2:54 PM, Huang Rui wrote: The AMD Nolan (NL) SoC contains a DesignWare USB3 Dual-Role Device that can be operated either as a USB Host or a USB Device. In the AMD NL platform, this device ([1022:7912]) has a class code of PCI_CLASS_SERIAL_USB_XHCI (0x0c0330), which means t

Re: [PATCH v3 18/19] PCI: Add quirk to prevent AMD NL USB3 DRD to bind with xHCI driver

2014-10-28 Thread Huang Rui
On Tue, Oct 28, 2014 at 03:06:31PM +0300, Sergei Shtylyov wrote: > Hello. > > On 10/28/2014 2:54 PM, Huang Rui wrote: > > >The AMD Nolan (NL) SoC contains a DesignWare USB3 Dual-Role Device that can > >be operated either as a USB Host or a USB Device. In the AMD NL platform, > >this device ([102

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-10-28 Thread Andrzej Pietrasiewicz
Hi, W dniu 28.10.2014 o 12:33, Neil Zhang pisze: Don't create new usb_gadget_string_container if the current strings are already exist in the usb_composite_dev. Otherwise the ids_tab will overflow soon if we bind / unbind usb functions frequently like android does. The problem you are describi

Re: [PATCH v9 1/4] mfd: add support for Diolan DLN-2 devices

2014-10-28 Thread Octavian Purdila
On Mon, Oct 27, 2014 at 6:57 PM, Joe Perches wrote: > On Mon, 2014-10-27 at 18:31 +0200, Octavian Purdila wrote: >> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO >> Master Adapter DLN-2. Details about the device can be found here: > > trivia: > Thanks for the review Joe. >> d

Re: kernel 3.17.1: fail to use USB3 device after resuming from suspend

2014-10-28 Thread Mathias Nyman
On 24.10.2014 00:13, Rafael J. Wysocki wrote: > On Thursday, October 23, 2014 10:15:50 PM Francis Moreau wrote: >> Hello, >> >> After resuming from a suspend (to RAM), I can't use an external USB hard >> drive anymore, the kernel seems to fail to detect it. >> >> Here is the kernel log when doing a

Re: [PATCH v3 18/19] PCI: Add quirk to prevent AMD NL USB3 DRD to bind with xHCI driver

2014-10-28 Thread Bjorn Helgaas
I suggest a subject like this: PCI: Prevent xHCI driver from claiming AMD Nolan USB3 DRD device On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui wrote: > The AMD Nolan (NL) SoC contains a DesignWare USB3 Dual-Role Device that can > be operated either as a USB Host or a USB Device. In the AMD NL platf

Re: [PATCH v3 17/19] PCI: Add support for AMD Nolan USB3 DRD

2014-10-28 Thread Bjorn Helgaas
On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui wrote: > This patch adds PCI id for USB3 Dual-Role Device of AMD Nolan (NL) SoC. > It will be used for PCI quirks and DWC3 device driver. > > Signed-off-by: Jason Chang > Signed-off-by: Huang Rui Acked-by: Bjorn Helgaas Please merge along with the re

Re: [PATCH v3 19/19] usb: dwc3: add support for AMD NL platform

2014-10-28 Thread Felipe Balbi
Hi, almost there... On Tue, Oct 28, 2014 at 07:54:40PM +0800, Huang Rui wrote: > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index 8b94ad5..b08a2f9 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -699,6 +699,7 @@ struct dwc3_scratchpad_array { >

Re: [PATCH v3 19/19] usb: dwc3: add support for AMD NL platform

2014-10-28 Thread Huang Rui
On Tue, Oct 28, 2014 at 08:38:56AM -0500, Felipe Balbi wrote: > Hi, > > almost there... > > On Tue, Oct 28, 2014 at 07:54:40PM +0800, Huang Rui wrote: > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > > index 8b94ad5..b08a2f9 100644 > > --- a/drivers/usb/dwc3/core.h > > +++ b/d

Re: [PATCH v3 00/19] usb: dwc3: add support for AMD Nolan SoC

2014-10-28 Thread Felipe Balbi
Hi, On Tue, Oct 28, 2014 at 07:54:21PM +0800, Huang Rui wrote: > Hi, > > The series of patches add AMD Nolan (NL) SoC support for DesignWare USB3 > OTG IP with PCI bus glue layer. This controller supported hibernation, LPM > erratum and used the 2.80a IP version and amd own phy. Current > impleme

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Mon, 2014-10-27 at 15:35 -0500, Dan Williams wrote: > so whenever that flag gets exported, we also need to make sure that > things that the kernel says *aren't* modems, actually aren't modems. > Which we apparently get wrong right now for various Nokia devices. I > don't really trust the manufa

Re: [PATCH v3 00/19] usb: dwc3: add support for AMD Nolan SoC

2014-10-28 Thread Huang Rui
On Tue, Oct 28, 2014 at 09:41:56AM -0500, Felipe Balbi wrote: > Hi, > > On Tue, Oct 28, 2014 at 07:54:21PM +0800, Huang Rui wrote: > > Hi, > > > > The series of patches add AMD Nolan (NL) SoC support for DesignWare USB3 > > OTG IP with PCI bus glue layer. This controller supported hibernation, LP

Re: [PATCH v3 00/19] usb: dwc3: add support for AMD Nolan SoC

2014-10-28 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 11:17:16PM +0800, Huang Rui wrote: > On Tue, Oct 28, 2014 at 09:41:56AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Tue, Oct 28, 2014 at 07:54:21PM +0800, Huang Rui wrote: > > > Hi, > > > > > > The series of patches add AMD Nolan (NL) SoC support for DesignWare USB3 > >

differing sector sizes between USB enclosures.

2014-10-28 Thread Dave Jones
I had a USB2 enclosure that I put a disk into and used for a few years. It reports my 3TB drive like so.. usb 1-3.1: New USB device found, idVendor=152d, idProduct=2329 usb 1-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=5 usb 1-3.1: Product: USB to ATA/ATAPI bridge usb 1-3.1: Manufa

Re: [PATCH v3 13/19] usb: dwc3: add tx demphasis quirk

2014-10-28 Thread Bjorn Helgaas
On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui wrote: > This patch adds Tx demphasis quirk, and the Tx demphasis value is "demphasis" (above and in subject) should be "de-emphasis" as used in the code and comments below. > configurable according to PIPE3 specification. > > Value Descriptio

Re: [PATCH v3 05/19] usb: dwc3: add lpm erratum support

2014-10-28 Thread Bjorn Helgaas
On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui wrote: > When parameter DWC_USB3_LPM_ERRATA_ENABLE is enabled in Andvanced "Advanced" > Configuration of coreConsultant, it supports of xHCI BESL Errata Dated I can't parse "is supports of" and I don't know enough to suggest an alternate wording. > 10

[PATCH v7 1/7] usb: move the OTG state from the USB PHY to the OTG structure

2014-10-28 Thread Antoine Tenart
Before using the PHY framework instead of the USB PHY one, we need to move the OTG state into another place, since it won't be available when USB PHY isn't used. This patch moves the OTG state into the OTG structure, and makes all the needed modifications in the drivers using the OTG state. Signed

[PATCH v7 2/7] usb: rename phy to usb_phy in OTG

2014-10-28 Thread Antoine Tenart
This patch prepares the introduction of the generic PHY support in the USB OTG common functions. The USB PHY member of the OTG structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Renaming this pointer will allow to keep the compatibility for USB PHY drivers. S

[PATCH v7 3/7] usb: add support to the generic PHY framework in OTG

2014-10-28 Thread Antoine Tenart
This patch adds support of the PHY framework in OTG and keeps the USB PHY compatibility. Here the only modification is to add PHY member in the OTG structure, along with the USB PHY one. Signed-off-by: Antoine Tenart --- include/linux/usb/otg.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH v7 5/7] usb: rename transceiver and phy to usb_phy in ChipIdea

2014-10-28 Thread Antoine Tenart
This patch prepares the introduction of the generic PHY support in the USB ChipIdea common functions. The USB PHY member of the ChipIdea structure ('transceiver') is renamed to 'usb_phy', the 'phy' member of the ChipIdea pdata structure is renamed to 'usb_phy' and modifications are done in all driv

[PATCH v7 4/7] usb: allow to supply the PHY in the drivers when using HCD

2014-10-28 Thread Antoine Tenart
This patch modify the generic code handling PHYs to allow them to be supplied from the drivers. This adds checks to ensure no PHY was already there when looking for one in the generic code. This also makes sure we do not modify its state in the generic HCD functions, it was provided by the driver.

[PATCH v7 7/7] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-10-28 Thread Antoine Tenart
This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by taking care of it in the code. Signed-off-by: Antoine Tenart --- driv

[PATCH v7 0/7] usb: add support for the generic PHY framework

2014-10-28 Thread Antoine Tenart
The series can be found at: git://git.free-electrons.com:users/antoine-tenart/linux.git usb-phy Changes since v6: - rebased on top of v3.18-rc2 Changes since v5: - rebased on the latest version of Sergei's series[1] - fixed one modifiaction made in the wrong patch Changes

[PATCH v7 6/7] usb: chipidea: move usb_otg into struct ci_hdrc

2014-10-28 Thread Antoine Tenart
Move the usb_otg member from struct usb_phy to struct ci_hdrc. Rework its initialization taking in account this modification. Signed-off-by: Antoine Tenart Acked-by: Peter Chen --- drivers/usb/chipidea/ci.h | 1 + drivers/usb/chipidea/debug.c | 2 +- drivers/usb/chipidea/host.c| 5

Re: [PATCH v3 04/19] usb: dwc3: add disscramble quirk

2014-10-28 Thread Bjorn Helgaas
On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui wrote: > This patch adds disscramble quirk, and it only needs to be enabled at fpga "disscramble" (in subject and above) is not a real word. I see that DWC3_GCTL_DISSCRAMBLE is already defined in drivers/usb/dwc3/core.h even before your patches, so I su

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Dan Williams
On Tue, 2014-10-28 at 10:26 +0100, Oliver Neukum wrote: > On Tue, 2014-10-28 at 10:05 +0100, Bjørn Mork wrote: > > Johan Hovold writes: > > > > > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one > > > message during probe), and most devices are simply matched on the > > >

Re: btusb_intr_complete returns -EPIPE

2014-10-28 Thread Alan Stern
On Tue, 28 Oct 2014, Naveen Kumar Parna wrote: > >> You should also run a similar test when you connect the device through > >> a USB-2 hub. In fact, you should run two tests. In one test, connect > >> the analyzer to the cable segment between the computer and the hub; in > >> the other test, co

Re: differing sector sizes between USB enclosures.

2014-10-28 Thread Alan Stern
On Tue, 28 Oct 2014, Dave Jones wrote: > I had a USB2 enclosure that I put a disk into and used for a few years. > It reports my 3TB drive like so.. > > usb 1-3.1: New USB device found, idVendor=152d, idProduct=2329 > usb 1-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=5 > usb 1-3.1

Re: [PATCH v7 6/7] usb: chipidea: move usb_otg into struct ci_hdrc

2014-10-28 Thread Sergei Shtylyov
Hello. On 10/28/2014 07:35 PM, Antoine Tenart wrote: Move the usb_otg member from struct usb_phy to struct ci_hdrc. Rework You're not reallky touching 'struct usb_phy'. ;-) its initialization taking in account this modification. Signed-off-by: Antoine Tenart Acked-by: Peter Chen W

Re: differing sector sizes between USB enclosures.

2014-10-28 Thread Dave Jones
On Tue, Oct 28, 2014 at 01:38:07PM -0400, Alan Stern wrote: > > usb 1-3.1: New USB device found, idVendor=152d, idProduct=2329 > > usb 1-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=5 > > usb 1-3.1: Product: USB to ATA/ATAPI bridge > > usb 1-3.1: Manufacturer: JMicron > > usb 1

Re: differing sector sizes between USB enclosures.

2014-10-28 Thread Alan Stern
On Tue, 28 Oct 2014, Dave Jones wrote: > On Tue, Oct 28, 2014 at 01:38:07PM -0400, Alan Stern wrote: > > > > usb 1-3.1: New USB device found, idVendor=152d, idProduct=2329 > > > usb 1-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=5 > > > usb 1-3.1: Product: USB to ATA/ATAPI bridg

Re: [PATCH v3 04/19] usb: dwc3: add disscramble quirk

2014-10-28 Thread Felipe Balbi
Hi, On Tue, Oct 28, 2014 at 10:39:26AM -0600, Bjorn Helgaas wrote: > On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui wrote: > > This patch adds disscramble quirk, and it only needs to be enabled at fpga > > "disscramble" (in subject and above) is not a real word. > > I see that DWC3_GCTL_DISSCRAMBLE

Re: [PATCH v3 13/19] usb: dwc3: add tx demphasis quirk

2014-10-28 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 10:27:27AM -0600, Bjorn Helgaas wrote: > On Tue, Oct 28, 2014 at 5:54 AM, Huang Rui wrote: > > This patch adds Tx demphasis quirk, and the Tx demphasis value is > > "demphasis" (above and in subject) should be "de-emphasis" as used in > the code and comments below. +1 --

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Huang Rui [mailto:ray.hu...@amd.com] > Sent: Tuesday, October 28, 2014 4:54 AM > > It enables hibernation if the function is set in coreConsultant. > > Suggested-by: Felipe Balbi > Signed-off-by: Huang Rui > --- > drivers/usb/dwc3/core.c | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 06:47:08PM +, Paul Zimmerman wrote: > > From: Huang Rui [mailto:ray.hu...@amd.com] > > Sent: Tuesday, October 28, 2014 4:54 AM > > > > It enables hibernation if the function is set in coreConsultant. > > > > Suggested-by: Felipe Balbi > > Signed-off-by: Huang Rui > >

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, October 28, 2014 11:51 AM > > On Tue, Oct 28, 2014 at 06:47:08PM +, Paul Zimmerman wrote: > > > From: Huang Rui [mailto:ray.hu...@amd.com] > > > Sent: Tuesday, October 28, 2014 4:54 AM > > > > > > It enables hibernation if the functio

Re: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 06:55:50PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, October 28, 2014 11:51 AM > > > > On Tue, Oct 28, 2014 at 06:47:08PM +, Paul Zimmerman wrote: > > > > From: Huang Rui [mailto:ray.hu...@amd.com] > > > > Sent: Tuesday

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, October 28, 2014 12:01 PM > > On Tue, Oct 28, 2014 at 06:55:50PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Tuesday, October 28, 2014 11:51 AM > > > > > > On Tue, Oct 28, 2014 at 06:47:08PM +00

Re: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Felipe Balbi
On Tue, Oct 28, 2014 at 07:15:29PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, October 28, 2014 12:01 PM > > > > On Tue, Oct 28, 2014 at 06:55:50PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Tuesday,

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-28 Thread Randy Dunlap
On 10/27/14 06:13, Tomi Valkeinen wrote: > On 27/10/14 13:59, Jani Nikula wrote: > >>> While doing 'depends on' instead of 'select' is an "easy" fix for this, >>> I do dislike it quite a bit. It's a major pain to go around the kernel >>> config, trying to find all the dependencies that a particula

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Tue, 2014-10-28 at 11:49 -0500, Dan Williams wrote: > > Well, then I guess it is up to Dan. Would you use the exported > > capabilities? > > From a practical standpoint, I'm not it would be as useful as we all > would like, mainly because the capabilities can be wrong and kernel > changes filte

[PATCH RESEND V4 1/9] of: Add NVIDIA Tegra XUSB mailbox binding

2014-10-28 Thread Andrew Bresticker
Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra xHCI controller's firmware and the host processor. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- No changes from v3. Changes from v2: - Dropped channel specifier. - Add

[PATCH RESEND V4 9/9] ARM: tegra: venice2: Add xHCI support

2014-10-28 Thread Andrew Bresticker
Assign ports previously owned by the EHCI controllers to the xHCI controller. There are two external USB ports (UTMI ports 0/2 and USB3 ports 0/1) and an internal USB port (UTMI port 1). PCIe lanes 0 and 1 are used by the USB3 ports. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren

[PATCH RESEND V4 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-10-28 Thread Andrew Bresticker
In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. The xHCI controller will also send messages intended for the PHY driver, so request and listen

[PATCH RESEND V4 5/9] of: Add NVIDIA Tegra xHCI controller binding

2014-10-28 Thread Andrew Bresticker
Add device-tree binding documentation for the xHCI controller present on Tegra124 and later SoCs. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- No changes from v3. Changes from v2: - Added mbox-names property. Changes from v1: - Updated to use common mailbox bindings. - Add

[PATCH RESEND V4 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2014-10-28 Thread Andrew Bresticker
Add support for the on-chip xHCI host controller present on Tegra SoCs. The driver is currently very basic: it loads the controller with its firmware, starts the controller, and is able to service messages sent by the controller's firmware. The hardware also supports device mode as well as powerg

[PATCH RESEND V4 8/9] ARM: tegra: jetson-tk1: Add xHCI support

2014-10-28 Thread Andrew Bresticker
Assign USB ports previously owned by the EHCI controllers to the xHCI controller. There is a mini-PCIe USB port (UTMI port 1) and a USB A connector (UTMI port 2, USB3 port 0). PCIe lane 0 is used for USB3 port 0. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- Changes from v3:

[PATCH RESEND V4 7/9] ARM: tegra: Add Tegra124 XUSB mailbox and xHCI controller

2014-10-28 Thread Andrew Bresticker
Add nodes for the Tegra XUSB mailbox and Tegra xHCI controller and add the PHY mailbox channel to the XUSB padctl node. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- No changes from v3. Changes from v2: - Dropped channel specifier from mailbox bindings. - Added mbox-names pr

[PATCH RESEND V4 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-10-28 Thread Andrew Bresticker
Add new bindings used for USB support by the Tegra XUSB pad controller. This includes additional PHY types, USB-specific pinconfig properties, etc. Signed-off-by: Andrew Bresticker Reviewed-by: Stephen Warren --- Changes from v2: - Added nvidia,otg-hs-curr-level-offset property. - Dropped "-ot

[PATCH RESEND V4 0/9] Tegra xHCI support

2014-10-28 Thread Andrew Bresticker
This series adds support for xHCI on NVIDIA Tegra SoCs. This includes: - patches 1 and 2: adding a driver for the mailbox used to communicate with the xHCI controller's firmware, - patches 3 and 4: extending the XUSB pad controller driver to support the USB PHY types (UTMI, HSIC, and USB3)

[PATCH RESEND V4 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-10-28 Thread Andrew Bresticker
The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single physical channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intended for the host-controller

Re: gadgetfs: fops change not preserved on return from dev_config()

2014-10-28 Thread Andre Wolokita
Hi Felipe, On 28/10/14 01:26, Felipe Balbi wrote: > Hi, > > On Mon, Oct 27, 2014 at 10:31:42AM +1100, Andre Wolokita wrote: >> I'm noticing some strange behaviour in the gadgetfs driver when >> running gadgetfs-test; the program fails with the error "ep0 read >> after poll: Invalid argument". >>

[PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-28 Thread dinguyen
From: Dinh Nguyen Since the dwc2 hcd driver is currently not looking for a clock node during init, we should not completely fail if there isn't a clock provided. For dual-role mode, we will only fail init for a non-clock node error. We then update the HCD to only call gadget funtions if there is

[PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only

2014-10-28 Thread dinguyen
From: Dinh Nguyen Now that platform.c will get built for both Host and Gadget, if we leave the usb_disabled() call in platform.c, it results in the following build error when (!USB && USB_GADGET) condition is met. ERROR: "usb_disabled" [drivers/usb/dwc2/dwc2_platform.ko] undefined! Since usb_di

[PATCHv6 7/8] usb: dwc2: Update Kconfig to support dual-role

2014-10-28 Thread dinguyen
From: Dinh Nguyen Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the controller is directly connected to the CPU. So for loadable modules, dwc2.ko is built for host, peripheral, and dual-role mode. The PCI bus interface wi

[PATCHv6 2/8] usb: dwc2: Move gadget probe function into platform code

2014-10-28 Thread dinguyen
From: Dinh Nguyen This patch will aggregate the probing of gadget/hcd driver into platform.c. The gadget probe funtion is converted into gadget_init that is now only responsible for gadget only initialization. All the gadget resources is now handled by platform.c Since the host workqueue will no

[PATCHv6 5/8] usb: dwc2: Add call_gadget functions for perpheral mode interrupts

2014-10-28 Thread dinguyen
From: Dinh Nguyen Update the dwc2 wakeup and suspend interrupt functions to use call_gadget when the IP is in peripheral mode. Signed-off-by: Dinh Nguyen Acked-by: Paul Zimmerman --- drivers/usb/dwc2/core_intr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc2/core_intr.

[PATCHv6 4/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-10-28 Thread dinguyen
From: Dinh Nguyen Make dwc2_handle_common_intr call the gadget interrupt function when operating in peripheral mode. Remove the spinlock functions in s3c_hsotg_irq as dwc2_handle_common_intr() already has the spinlocks. Move the registeration of the IRQ to common code for platform and PCI. Remo

[PATCHv6 1/8] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-10-28 Thread dinguyen
From: Dinh Nguyen Adds the gadget data structure and appropriate data structure pointers to the common dwc2_hsotg data structure. To keep the driver data dereference code looking clean, the gadget variable declares are only available for peripheral and dual-role mode. This is needed so that the d

[PATCHv6 3/8] usb: dwc2: Initialize the USB core for peripheral mode

2014-10-28 Thread dinguyen
From: Dinh Nguyen Initialize the USB driver to peripheral mode when a B-Device connector is attached. Signed-off-by: Dinh Nguyen Acked-by: Paul Zimmerman --- v5: move the export of s3c_hsotg_core_init into this patch --- drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/gadget.c | 2 +- driv

[PATCH] cdc-acm: ensure that termios get set when the port is opened

2014-10-28 Thread Jim Paris
Do what other drivers like ftdi_sio do, and ensure that termios are written to the device when the port is first opened. Signed-off-by: Jim Paris --- Tested on v3.16.5. I've seen a problem on two CDC-ACM systems based on a Segger J-Link where the port does not get initialized at the correct bau

[PATCHv6 0/8] usb: dwc2: Add support for dual-role

2014-10-28 Thread dinguyen
From: Dinh Nguyen Hello, This is version 6 of the patch series that combines the dwc2 gadget and host driver into a single dual role driver. Here are the main differences from V5: - Added a new patch 8/8 - usb: dwc2: move usb_disabled() call to host driver only. This patch is needed to avoid

Re: [PATCH] cdc-acm: ensure that termios get set when the port is opened

2014-10-28 Thread Peter Hurley
Hi Jim, On 10/28/2014 07:26 PM, Jim Paris wrote: > Do what other drivers like ftdi_sio do, and ensure that termios are > written to the device when the port is first opened. > > Signed-off-by: Jim Paris > --- > > Tested on v3.16.5. > > I've seen a problem on two CDC-ACM systems based on a Segg

RE: [PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only

2014-10-28 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 28, 2014 4:26 PM > > Now that platform.c will get built for both Host and Gadget, if we leave the > usb_disabled() call in platform.c, it results in the following build error > when (!USB && USB

RE: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-28 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 28, 2014 4:26 PM > > Since the dwc2 hcd driver is currently not looking for a clock node during > init, we should not completely fail if there isn't a clock provided. > For dual-role mode, we wi

Re: [PATCH v3 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-10-28 Thread RR
On Mon, Oct 27, 2014 at 9:00 PM, Linus Walleij wrote: > On Thu, Oct 9, 2014 at 1:46 AM, RR wrote: >> On Wed, Oct 8, 2014 at 12:18 AM, Alexandre Courbot wrote: >>> On Wed, Oct 8, 2014 at 4:09 PM, Muthu Mani wrote: > > > +static int cy_gpio_direction_output(struct gpio_chip *chip, > > +

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-28 Thread Michael Ellerman
On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote: > On 10/27/14 06:13, Tomi Valkeinen wrote: > > I also think the 'depends on BACKLIGHT_CLASS_DEVICE || > > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds > > like a hack to me =). > > It does exactly what is needed and i

[PATCH net 2/3] r8152: reset tp->speed before autoresuming in open function

2014-10-28 Thread Hayes Wang
If (tp->speed & LINK_STATUS) is not zero, the rtl8152_resume() would call rtl_start_rx() before enabling the tx/rx. Avoid this by resetting it to zero. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers

  1   2   >