On Mon, Oct 27, 2014 at 08:40:51PM +0100, Oliver Neukum wrote: > On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: > > > I guess we could use that quirk, but I'm actually leaning towards just > > removing that quirk and reducing the log level of the message to info. > > > > Oliver, what do you say? > > Now that I think about this, I'd say that we should actually > export the flag via sysfs and ask the ModemManager people > to honour it.
That sounds like it could be useful if manufacturers actually set those bits (see Dan's mail). Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one message during probe), and most devices are simply matched on the interface class fields anyway. I'm not sure we want to start registering devices with broken bmCapabilities in the driver (rather than in say ModemManager). Either way, we should remove the current NOT_A_MODEM quirk as it is completely useless and appears to only be used for a device which is in fact *correctly* identified as "not a modem". :) Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
