Re: [PATCH 2/2] usb: gadget: f_uvc: Move to video_ioctl2

2014-08-20 Thread Michael Grzeschik
On Mon, Aug 18, 2014 at 11:16:36PM +0200, Laurent Pinchart wrote: > Hi Hans, > > On Monday 18 August 2014 18:24:26 Hans Verkuil wrote: > > On 08/18/2014 05:06 PM, Laurent Pinchart wrote: > > > Simplify ioctl handling by using video_ioctl2. > > > > Are you able to test this on actual hardware? And

Re: [PATCH 2/2] USB: serial: add Novatel Wireless GPS driver

2014-08-20 Thread Johan Hovold
On Tue, Aug 19, 2014 at 02:21:25PM -0600, Kirk Madsen wrote: > I applied your two patches to current Fedora core 20 kernel sources, > built, remembered to remove the work-around boot-params and run > grub2-mkconfig, and rebooted. My Novatel GPS is recognized on plug-in > to my USB2 ports and appea

[PATCH net-next 0/4] r8152: firmware support

2014-08-20 Thread Hayes Wang
Parsing, checking, and writing the firmware. Hayes Wang (4): r8152: check code with checkpatch.pl r8152: replace strncpy with strlcpy r8152: remove clear_bp function r8152: support firmware files drivers/net/usb/r8152.c | 961 +--- 1 file chang

[PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-20 Thread Hayes Wang
The functions are used to update the firmware. Move the actions into the firmware files. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 33dcc97..937d132 100

[PATCH net-next 2/4] r8152: replace strncpy with strlcpy

2014-08-20 Thread Hayes Wang
Replace the strncpy with strlcpy, and use sizeof to determine the length. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 2470d9c..33dcc97 100644 --- a/drivers/ne

[PATCH net-next 4/4] r8152: support firmware files

2014-08-20 Thread Hayes Wang
The firmware file is composed of the fw header and the commands. Each command has the following type. cmd(2 bytes) + length(2 bytes) + data(variable bytes) Before applying the firmware, the driver would check the fw header and each command. Signed-off-by: Hayes Wang --- drivers/net/usb

[PATCH net-next 1/4] r8152: check code with checkpatch.pl

2014-08-20 Thread Hayes Wang
626: CHECK: Alignment should match open parenthesis 646: CHECK: Alignment should match open parenthesis 655: CHECK: Alignment should match open parenthesis 695: CHECK: Alignment should match open parenthesis 729: CHECK: Alignment should match open parenthesis 739: CHECK: Alignment should matc

Re: [linux-usb] Is UAC1 (USB Audio Class 1.0) broken?

2014-08-20 Thread Xuebing Wang
In order to get UAC1 working with my Ubuntu 12.04 LTS host, I have to make a few changes to driver/usb/gadget/f_uac1.c what changes ? care to send a patch ? Why do you need such change ? Are you fixing a bug ? Felipe, Thanks. I have to apply below patch to fix the "-22" issue. From: Xueb

Re: [linux-usb] Is UAC1 (USB Audio Class 1.0) broken?

2014-08-20 Thread Peter Chen
On Wed, Aug 20, 2014 at 05:29:57PM +0800, Xuebing Wang wrote: > > >>In order to get UAC1 working with my Ubuntu 12.04 LTS host, I have to make a > >>few changes to driver/usb/gadget/f_uac1.c > >what changes ? care to send a patch ? Why do you need such change ? Are > >you fixing a bug ? > > Felip

[PATCH 1/3] usb: add support for Diolan DLN-2 devices

2014-08-20 Thread Daniel Baluta
From: Octavian Purdila This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Information about the USB protocol can be found in the Programmer's Reference Manual [1], see

[PATCH 0/3] dln-2: Add support for Diolan DLN-2 devices

2014-08-20 Thread Daniel Baluta
This patch series adds support for Diolan USB-I2C/GPIO Master Adapter DLN-2. Details about device can be found here: https://www.diolan.com/i2c/i2c_interface.html. There is no support for SPI part yet. Daniel Baluta (1): gpio: add support for the Diolan DLN-2 USB-GPIO driver Laurentiu Palcu (

[PATCH 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-08-20 Thread Daniel Baluta
From: Laurentiu Palcu This patch adds support for the Diolan DLN-2 I2C master module. Due to hardware limitations it does not support SMBUS quick commands. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 6.2.2 for the I2C master mod

[PATCH 3/3] gpio: add support for the Diolan DLN-2 USB-GPIO driver

2014-08-20 Thread Daniel Baluta
This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 2.9 for the GPIO module commands and responses. [1] https://www.diolan.com/downloads/dln-api-manual.pdf Signed-of

Re: [PATCH v4 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-08-20 Thread Sergei Shtylyov
Hello. On 8/20/2014 9:46 AM, Robert Baldyga wrote: This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which returns endpoint descriptor to userspace. It works only if function is active. Signed-off-by: Robert Baldyga [...] diff --git a/include/uapi/linux/usb/functionfs.h b/inc

Re: [PATCH net-next 4/4] r8152: support firmware files

2014-08-20 Thread Daniele Forsi
2014-08-20 10:58 GMT+02:00 Hayes Wang: > The firmware file is composed of the fw header and the commands. Each > command has the following type. > > cmd(2 bytes) + length(2 bytes) + data(variable bytes) > +static bool rtl_fw_format_ok(struct rtl_fw *rtl_fw) > + start = le32_to_cpu(

RE: [PATCH net-next 4/4] r8152: support firmware files

2014-08-20 Thread Hayes Wang
Daniele Forsi [mailto:dfo...@gmail.com] > Sent: Wednesday, August 20, 2014 8:01 PM > To: Hayes Wang > Cc: net...@vger.kernel.org; nic_swsd; > linux-ker...@vger.kernel.org; USB list > Subject: Re: [PATCH net-next 4/4] r8152: support firmware files [...] > > + start = le32_to_cpu(fw_header->

Re: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-20 Thread Sergei Shtylyov
Hello. On 8/20/2014 12:58 PM, Hayes Wang wrote: The functions are used to update the firmware. Move the actions into the firmware files. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/net/usb/r8

Re: USB reset xhci_hcd for ELAN touchscreen

2014-08-20 Thread Jiri Kosina
On Mon, 14 Jul 2014, Johan Hovold wrote: > From 8101c0dfd42a232f1d2872de4f412d8d61d5646f Mon Sep 17 00:00:00 2001 > From: Johan Hovold > Date: Mon, 14 Jul 2014 18:43:31 +0200 > Subject: [PATCH] HID: usbhid: add HID_QUIRK_IN > > Add quirk to submit the interrupt-in urb already at start() rather t

[PATCH 4/7] xhci: Remove "FIXME - check all the stream rings for pending cancellations"

2014-08-20 Thread Mathias Nyman
From: Hans de Goede Even though a Set TR deq ptr command operates on a ring, and an endpoint can have multiple rings, we can have only one Set TR deq ptr command pending. When an endpoint with streams halts or is stopped to unlink urbs, there will only be at most one ring active / one td being e

[PATCH 7/7] usb: xhci_suspend is not stopping the root hub timer for the shared HCD

2014-08-20 Thread Mathias Nyman
From: Al Cooper V2 - Restart polling (which will restart the timer) for the shared HCD in xhci_resume(). xhci_suspend() will stop the primary HCD's root hub timer, but leaves the shared HCD's timer running. This change adds stopping of the shared HCD timer. Signed-off-by: Al Cooper Signed-off-

Re: [PATCH net-next 4/4] r8152: support firmware files

2014-08-20 Thread Daniele Forsi
2014-08-20 14:35 GMT+02:00 Hayes Wang: > Is this necessary? Besides the check of the "start", > there are checks of the "size" and rtl_fw_data_ok(). > I think they cover the situations which you indicate. it's not necessary and it's better checked later as you did! -- Daniele Forsi -- To unsubs

[PATCH 5/7] xhci: Always ring the doorbell for active eps when a Set TR deq ptr cmd completes

2014-08-20 Thread Mathias Nyman
From: Hans de Goede Even if the stream for which the command was intended has been freed in the mean time. This ensures that things start rolling again after an unlink / halt. Signed-off-by: Hans de Goede Acked-by: Mathias Nyman Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c |

[PATCH 1/7] xhci: Log extra info on "ERROR Transfer event TRB DMA ptr not part of current TD"

2014-08-20 Thread Mathias Nyman
From: Hans de Goede Lately (with the use of uas / bulk-streams) we have been seeing several cases where this error triggers (which should never happen). Add some extra logging to make debugging these errors easier. Signed-off-by: Hans de Goede Signed-off-by: Mathias Nyman --- drivers/usb/hos

[PATCH 2/7] xhci: Move allocating of command for new_dequeue_state to queue_set_tr_deq()

2014-08-20 Thread Mathias Nyman
From: Hans de Goede There are multiple reasons for this: 1) This fixes a missing check for xhci_alloc_command failing in xhci_handle_cmd_stop_ep() 2) This adds a warning when we cannot set the new dequeue state because of xhci_alloc_command failing 3) It puts the allocation of the command

[PATCH 0/7] xhci: patches for usb-next

2014-08-20 Thread Mathias Nyman
Hi Greg These xhci patches are for usb-next and apply on top of 3.17-rc1 It contains Hans De Goede's xhci cleanups, and one small xhci suspend improvement. I'll be out hiking and unable to respond (no network whatsoeever) until mid next week, 27.8. -Mathias Al Cooper (1): usb: xhci_suspend i

[PATCH 3/7] xhci: Fold queue_set_tr_deq into xhci_queue_new_dequeue_state

2014-08-20 Thread Mathias Nyman
From: Hans de Goede xhci_queue_new_dequeue_state is the only caller of queue_set_tr_deq and queue_set_tr_deq checks for SET_DEQ_PENDING, where as xhci_queue_new_dequeue_state sets it which is inconsistent. Simply fold the 2 into one is a nice cleanup and fixes the inconsistency. Signed-off-by:

[PATCH 6/7] xhci: xhci_ring_device: Ring stream ring bells for endpoints with streams

2014-08-20 Thread Mathias Nyman
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-hub.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index aa79e87..bb54783 100644 --- a/drive

Re: [PATCH v5] phy: Renesas R-Car Gen2 PHY driver

2014-08-20 Thread Kishon Vijay Abraham I
Hi, On Wednesday 23 July 2014 12:57 AM, Sergei Shtylyov wrote: . . . . > Index: linux-phy/drivers/phy/phy-rcar-gen2.c > === > --- /dev/null > +++ linux-phy/drivers/phy/phy-rcar-gen2.c > @@ -0,0 +1,341 @@ > +/* > + * Renesas R-Car Ge

Re: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000

2014-08-20 Thread Felipe Balbi
Hi Greg, On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote: > From: Bryan O'Donoghue > > This patch is to enable the USB gadget device for Intel Quark X1000 > > Signed-off-by: Bryan O'Donoghue > Signed-off-by: Bing Niu > Signed-off-by: Alvin (Weike) Chen this patch is basically ju

Re: [PATCH 1/5] ARM: dts: remove old USB2 PHY node hook for Arndale

2014-08-20 Thread Kishon Vijay Abraham I
On Thursday 14 August 2014 07:55 PM, Bartlomiej Zolnierkiewicz wrote: > drivers/usb/phy/phy-samsung-usb2 driver got replaced by > drivers/phy/phy-samsung-usb2 one. Remove the leftover hook > from Arndale dts file. > > Cc: Mark Brown > Cc: Kamil Debski > Cc: Vivek Gautam > Signed-off-by: Bart

Re: [PATCH 4/5] usb: phy: samsung: remove old USB 3.0 PHY driver

2014-08-20 Thread Kishon Vijay Abraham I
On Thursday 14 August 2014 07:55 PM, Bartlomiej Zolnierkiewicz wrote: > drivers/usb/phy/phy-samsung-usb3 driver got replaced by > drivers/phy/phy-samsung-usb3 one and is no longer used. > > Cc: Kamil Debski > Cc: Vivek Gautam > Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Kyungmin Par

Re: [PATCH 2/5] ARM: dts: remove old USB2 PHY node for Exynos5250

2014-08-20 Thread Kishon Vijay Abraham I
On Thursday 14 August 2014 07:55 PM, Bartlomiej Zolnierkiewicz wrote: > drivers/usb/phy/phy-samsung-usb2 driver got replaced by > drivers/phy/phy-samsung-usb2 one. Remove the leftover > USB2 PHY node (EHCI/OHCI USB nodes are using the new one > already) from Exynos5250 dtsi file. > > Cc: Mark B

Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

2014-08-20 Thread Kishon Vijay Abraham I
On Thursday 14 August 2014 07:55 PM, Bartlomiej Zolnierkiewicz wrote: > drivers/usb/phy/phy-samsung-usb2 driver got replaced by > drivers/phy/phy-samsung-usb2 one and is no longer used. > > Cc: Kamil Debski > Cc: Vivek Gautam > Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Kyungmin Par

Re: [PATCH 5/5] usb: phy: samsung: remove old common USB PHY code

2014-08-20 Thread Kishon Vijay Abraham I
On Thursday 14 August 2014 07:55 PM, Bartlomiej Zolnierkiewicz wrote: > drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by > drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung > USB PHY code is no longer used. > > Cc: Kamil Debski > Cc: Vivek Gautam > Signed-off-by: Bar

Re: [PATCH 0/7] g_webcam: Preparation for configfs

2014-08-20 Thread Felipe Balbi
Hi, On Mon, Aug 18, 2014 at 09:45:08PM +0200, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patches. The series looks good, I only had a few comments. > > I have rebased the patches on top of my UVC gadget branch, addressed my > comments (the modified patches are marked as such in

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-20 Thread Felipe Balbi
Hi, On Fri, Jul 18, 2014 at 11:39:46AM +0200, Richard Leitner wrote: > Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with > the hardcoded ttyGS string. > > This macro was mostly used in a few debug/warning messages and a lot of > hardcoded ttyGS existed beneath. It may

Re: [PATCH] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-08-20 Thread Felipe Balbi
Hi, On Fri, Jul 18, 2014 at 11:11:21AM +0200, Richard Leitner wrote: > Replace the VDBG and DBG macro with the kernels "proper" debug macros > (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c & f_serial.c > > Signed-off-by: Richard Leitner please rebase this one on top of v3.17-rc1 -- balbi sign

Re: [PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-08-20 Thread Felipe Balbi
On Thu, Jul 17, 2014 at 09:16:40PM +0100, Srinivas Kandagatla wrote: > This patch makes the phy reset clk and reset line optional as this clk > is not available on boards like IFC6410 with APQ8064. > > phy-reset clk is only used as argument to the mach level callbacks, so > this patch adds conditi

Re: [PATCH v3 4/6] usb: common: add API to get if the platform supports TPL

2014-08-20 Thread Felipe Balbi
Hi, On Tue, Aug 19, 2014 at 09:51:55AM +0800, Peter Chen wrote: > The TPL (Targeted Peripheral List) is used for targeted hosts > (non-PC hosts), and it can be used at USB OTG & EH certification > and some specific products which need white list. > > Signed-off-by: Peter Chen > --- > drivers/us

Re: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000

2014-08-20 Thread Greg KH
On Wed, Aug 20, 2014 at 09:54:46AM -0500, Felipe Balbi wrote: > Hi Greg, > > On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote: > > From: Bryan O'Donoghue > > > > This patch is to enable the USB gadget device for Intel Quark X1000 > > > > Signed-off-by: Bryan O'Donoghue > > Signed-of

Re: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000

2014-08-20 Thread Felipe Balbi
On Wed, Aug 20, 2014 at 11:15:05AM -0500, Greg KH wrote: > On Wed, Aug 20, 2014 at 09:54:46AM -0500, Felipe Balbi wrote: > > Hi Greg, > > > > On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote: > > > From: Bryan O'Donoghue > > > > > > This patch is to enable the USB gadget device for In

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-20 Thread Sergei Shtylyov
Hello. On 08/20/2014 07:54 PM, Felipe Balbi wrote: Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded ttyGS string. This macro was mostly used in a few debug/warning messages and a lot of hardcoded ttyGS existed beneath. It may have been used for rena

Re: [PATCH 0/7] g_webcam: Preparation for configfs

2014-08-20 Thread Laurent Pinchart
Hi Felipe, On Wednesday 20 August 2014 10:39:43 Felipe Balbi wrote: > On Mon, Aug 18, 2014 at 09:45:08PM +0200, Laurent Pinchart wrote: > > Hi Andrzej, > > > > Thank you for the patches. The series looks good, I only had a few > > comments. > > > > I have rebased the patches on top of my UVC gad

Re: [PATCH 2/2] usb: gadget: f_uvc: Move to video_ioctl2

2014-08-20 Thread Laurent Pinchart
Hi Michael, On Wednesday 20 August 2014 09:55:10 Michael Grzeschik wrote: > On Mon, Aug 18, 2014 at 11:16:36PM +0200, Laurent Pinchart wrote: > > On Monday 18 August 2014 18:24:26 Hans Verkuil wrote: > > > On 08/18/2014 05:06 PM, Laurent Pinchart wrote: > > > > Simplify ioctl handling by using vid

Re: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000

2014-08-20 Thread Greg KH
On Wed, Aug 20, 2014 at 11:20:09AM -0500, Felipe Balbi wrote: > On Wed, Aug 20, 2014 at 11:15:05AM -0500, Greg KH wrote: > > On Wed, Aug 20, 2014 at 09:54:46AM -0500, Felipe Balbi wrote: > > > Hi Greg, > > > > > > On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote: > > > > From: Bryan O'D

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-20 Thread Laurent Pinchart
Hi Hans and Michael, On Wednesday 20 August 2014 02:06:54 Hans Verkuil wrote: > On 08/19/2014 05:01 PM, Laurent Pinchart wrote: > > Hi Michael, > > > > Thank you for the patch. > > > > (CC'ing Hans Verkuil and the linux-media mailing list) > > > > On Friday 08 August 2014 17:38:58 Michael Grzes

Re: [PATCH 0/7] g_webcam: Preparation for configfs

2014-08-20 Thread Felipe Balbi
On Wed, Aug 20, 2014 at 07:02:29PM +0200, Laurent Pinchart wrote: > Hi Felipe, > > On Wednesday 20 August 2014 10:39:43 Felipe Balbi wrote: > > On Mon, Aug 18, 2014 at 09:45:08PM +0200, Laurent Pinchart wrote: > > > Hi Andrzej, > > > > > > Thank you for the patches. The series looks good, I only

[GIT PULL] USB fixes for v3.17-rc2

2014-08-20 Thread Felipe Balbi
Hi Greg, Here's my first set of fixes for this merge window. All patches have soaked in mailing list for a while, and what I could, I tested on the platforms I have. Please consider merging on top of your usb-linus branch. cheers The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b

[GIT PULL] USB-serial fixes for v3.17-rc2

2014-08-20 Thread Johan Hovold
Hi Greg, Here are some fixes and new device IDs for v3.17-rc2 for you to pull. All have been in linux-next. Thanks, Johan The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9: Linux 3.17-rc1 (2014-08-16 10:40:26 -0600) are available in the git repository at: git:/

Re: [PATCH v2] usb: gadget/uvc: remove DRIVER_VERSION{,_NUMBER}

2014-08-20 Thread Felipe Balbi
On Thu, Aug 14, 2014 at 02:10:38PM +0200, Laurent Pinchart wrote: > Hi Michael, > > Thank you for the patch. > > On Thursday 14 August 2014 13:09:44 Michael Grzeschik wrote: > > As the driver is mainline we can remove the version numbers. > > > > Signed-off-by: Michael Grzeschik > > Acked-by:

RE: [PATCH] usb: dwc2: gadget: Set the default EP max packet value as 8 bytes

2014-08-20 Thread Paul Zimmerman
> From: Jingoo Han [mailto:jg1@samsung.com] > Sent: Tuesday, August 19, 2014 8:04 PM > > Set the default EP max packet value as 8 bytes, because in the case > of low-speed, 'ep_mps' is not set. Thus, the default value of 'ep_mps' > should be considered for the case of low-speed. > > Signed-of

Re: [PATCH v4 3/3] MAINTAINERS: Add dwc3-st.c file to ARCH/STI architecture

2014-08-20 Thread Felipe Balbi
On Wed, Jul 30, 2014 at 04:28:11PM +0100, Peter Griffin wrote: -ENOLOG > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 702ca10..269ad3b 100644 > --- a/MAINTAINERS > +++ b/MAINTA

Re: [PATCH v4 2/3] usb: dwc3: dwc3-st: Add st-dwc3 devicetree bindings documentation

2014-08-20 Thread Felipe Balbi
On Wed, Jul 30, 2014 at 04:28:10PM +0100, Peter Griffin wrote: > This patch documents the device tree documentation required for > the ST usb3 controller glue layer found in STiH407 devices. > > Signed-off-by: Giuseppe Cavallaro > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > --- > Docu

Re: [PATCH v4 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-08-20 Thread Felipe Balbi
Hi, On Wed, Jul 30, 2014 at 04:28:09PM +0100, Peter Griffin wrote: > This patch adds the ST glue logic to manage the DWC3 HC > on STiH407 SoC family. It manages the powerdown signal, > and configures the internal glue logic and syscfg registers. > > Signed-off-by: Giuseppe Cavallaro > Signed-off

Re: [PATCH v4] usb: gadget: at91_udc: move prepare clk into process context

2014-08-20 Thread Felipe Balbi
Hi, On Fri, Aug 08, 2014 at 11:42:42AM +0200, Ronald Wahl wrote: > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc: > prepare clk before calling enable) added clock preparation in interrupt > context. This is not allowed as it might sleep. Also setting the clock > rate is un

Re: [PATCH 0/5] usb: phy: samsung: remove old USB PHY code

2014-08-20 Thread Felipe Balbi
Hi, On Thu, Aug 14, 2014 at 04:25:22PM +0200, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patch series removes the old Samsung USB PHY drivers that > got replaced by the new ones using the generic PHY layer. > > Depends on: > - next-20140813 branch of linux-next kernel this thread seems to

Re: [PATCH 0/7] usb-phy: samsung: Cleanup the unused drivers

2014-08-20 Thread Felipe Balbi
Hi, On Thu, Aug 14, 2014 at 07:53:53PM +0530, Vivek Gautam wrote: > - This series is based on 'usb-next' branch. > > Now that we have support for USB PHY controllers for Exynos SoC series, > we are free to remove the older usb-phy support. > In the process, we are removing the entire phy-samsung-

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-20 Thread Felipe Balbi
On Tue, Jul 15, 2014 at 10:07:40PM +0800, Li Jun wrote: > This patch try to dequeue the cdev->req to guarantee the request is not queued > before free it. > > Signed-off-by: Li Jun > --- > drivers/usb/gadget/composite.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gad

Re: usb_gadget_state_work not triggering sysfs_notify

2014-08-20 Thread Felipe Balbi
Hi, On Mon, Jul 07, 2014 at 12:53:45PM +0200, Michael Grzeschik wrote: > Hi, > > I am currently working with an udc where the userspace should react on > plugging which udc is that ? which kernel version are you using ? > and unplugging of the device. The layers used trigger the > usb_gadget_

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-08-20 Thread Felipe Balbi
On Wed, Jul 23, 2014 at 03:33:23PM +0100, Peter Griffin wrote: > > > > > + reset_control_assert(dwc3_data->rstc_pwrdn); > > > > > + > > > > > + pinctrl_pm_select_sleep_state(dev); > > > > pinctrl will select sleep and default states automatically for you. > > I've left this in v3, as grep

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-20 Thread Alan Stern
On Wed, 20 Aug 2014, Felipe Balbi wrote: > On Tue, Jul 15, 2014 at 10:07:40PM +0800, Li Jun wrote: > > This patch try to dequeue the cdev->req to guarantee the request is not > > queued > > before free it. > > > > Signed-off-by: Li Jun > > --- > > drivers/usb/gadget/composite.c |1 + > > 1

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-20 Thread Felipe Balbi
On Wed, Aug 20, 2014 at 03:06:28PM -0400, Alan Stern wrote: > On Wed, 20 Aug 2014, Felipe Balbi wrote: > > > On Tue, Jul 15, 2014 at 10:07:40PM +0800, Li Jun wrote: > > > This patch try to dequeue the cdev->req to guarantee the request is not > > > queued > > > before free it. > > > > > > Signed

Re: [PATCH V4 0/2] usb: gadget: zero: Add support for interrupt EP

2014-08-20 Thread Felipe Balbi
Hi, On Mon, Jul 21, 2014 at 12:16:36PM +0530, Amit Virdi wrote: > This patchset adds support for interrupt EP and the corresponding test cases > to > gadget zero. The code has been rebased and tested on Kernel v3.15-rc5 this doesn't apply anymore. Can you rebase on my testing/next (or v3.17-rc1)

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-20 Thread Alan Stern
On Tue, 19 Aug 2014, Christoph Hellwig wrote: > On Thu, Aug 07, 2014 at 11:58:37AM -0400, Alan Stern wrote: > > > On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: > > > > > I doubt either of them forces users to hack up flags for these cases. > > > > > > > > Why was this change needed

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-20 Thread Alan Stern
On Wed, 20 Aug 2014, Felipe Balbi wrote: > > > > --- a/drivers/usb/gadget/composite.c > > > > +++ b/drivers/usb/gadget/composite.c > > > > @@ -1956,6 +1956,7 @@ void composite_dev_cleanup(struct > > > > usb_composite_dev *cdev) > > > > } > > > > if (cdev->req) { > > > >

Re: [PATCH 1/3] usb: add support for Diolan DLN-2 devices

2014-08-20 Thread Arnd Bergmann
On Wednesday 20 August 2014, Daniel Baluta wrote: > From: Octavian Purdila > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > Master Adapter DLN-2. Details about the device can be found here: > > https://www.diolan.com/i2c/i2c_interface.html. > > Information about the USB p

RE: Transient USB disconnects

2014-08-20 Thread Alan Stern
On Wed, 20 Aug 2014, David Laight wrote: > > On Tue, 19 Aug 2014, David Laight wrote: > > > > > From: Alan Stern > > > > > > > Since the device is plugged into a hub, the hub knows about the > > > > disconnection. But it can't inform the kernel until the host > > > > controller polls it, which o

Re: [PATCH 3/3] xhci: rework cycle bit checking for new dequeue pointers

2014-08-20 Thread Joseph Salisbury
On 08/19/2014 08:17 AM, Mathias Nyman wrote: > When we manually need to move the TR dequeue pointer we need to set the > correct cycle bit as well. Previously we used the trb pointer from the > last event received as a base, but this was changed in > commit 1f81b6d22a59 ("usb: xhci: Prefer endpoint

Re: Problem with USB-to-SATA adapters

2014-08-20 Thread James Bottomley
On Wed, 2014-08-20 at 16:18 -0400, Dale R. Worley wrote: > I don't know if this is the correct place for this problem, but you > people can probably tell me the correct place. linux-usb can probably also help (cc'd). > I have two "USB to SATA adapter" dongles. In general, they work fine. > Howev

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup

2014-08-20 Thread Peter Chen
On Wed, Aug 20, 2014 at 03:18:47PM -0400, Alan Stern wrote: > On Wed, 20 Aug 2014, Felipe Balbi wrote: > > > > > > --- a/drivers/usb/gadget/composite.c > > > > > +++ b/drivers/usb/gadget/composite.c > > > > > @@ -1956,6 +1956,7 @@ void composite_dev_cleanup(struct > > > > > usb_composite_dev *cde

RE: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-20 Thread Hayes Wang
: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Wednesday, August 20, 2014 8:01 PM > To: Hayes Wang; net...@vger.kernel.org > Cc: nic_swsd; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH net-next 3/4] r8152: remove clear_bp function [...] > >

Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

2014-08-20 Thread Vivek Gautam
Hi Tomasz and Bartlomiej, On Mon, Aug 18, 2014 at 4:52 PM, Tomasz Figa wrote: > On 18.08.2014 13:02, Bartlomiej Zolnierkiewicz wrote: >> On Thursday, August 14, 2014 08:07:40 PM Vivek Gautam wrote: >>> On Thursday, August 14, 2014 7:55 PM, Bartlomiej Zolnierkiewicz >>> wrote >> >>> There's one

Re: [PATCH 0/5] usb: phy: samsung: remove old USB PHY code

2014-08-20 Thread Vivek Gautam
On Thu, Aug 14, 2014 at 7:55 PM, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patch series removes the old Samsung USB PHY drivers that > got replaced by the new ones using the generic PHY layer. > > Depends on: > - next-20140813 branch of linux-next kernel > > Best regards, > -- > Bartlomiej Z

Re: [PATCH 0/7] usb-phy: samsung: Cleanup the unused drivers

2014-08-20 Thread Vivek Gautam
Hi Felipe, On Wed, Aug 20, 2014 at 11:44 PM, Felipe Balbi wrote: > Hi, > > On Thu, Aug 14, 2014 at 07:53:53PM +0530, Vivek Gautam wrote: >> - This series is based on 'usb-next' branch. >> >> Now that we have support for USB PHY controllers for Exynos SoC series, >> we are free to remove the olde

Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

2014-08-20 Thread Jingoo Han
On Thursday, August 21, 2014 1:31 PM, Vivek Gautam wrote: > On Mon, Aug 18, 2014 at 4:52 PM, Tomasz Figa wrote: > > On 18.08.2014 13:02, Bartlomiej Zolnierkiewicz wrote: > >> On Thursday, August 14, 2014 08:07:40 PM Vivek Gautam wrote: > >>> On Thursday, August 14, 2014 7:55 PM, Bartlomiej Zolnier

Re: [PATCH 0/5] usb: phy: samsung: remove old USB PHY code

2014-08-20 Thread Jingoo Han
On Thursday, August 21, 2014 1:34 PM, Vivek Gautam wrote: > On Thu, Aug 14, 2014 at 7:55 PM, Bartlomiej Zolnierkiewicz > wrote: > > Hi, > > > > This patch series removes the old Samsung USB PHY drivers that > > got replaced by the new ones using the generic PHY layer. > > > > Depends on: > > - nex

[PATCH v2] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-08-20 Thread Richard Leitner
Replace the VDBG and DBG macro with the kernels "proper" debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c & f_serial.c Signed-off-by: Richard Leitner --- v2: - rebased on Linux v3.17-rc1 - fixed some PARENTHESIS_ALIGNMENT checkpatch.pl warnings --- drivers/usb/gadget/function/f_acm.c

Re: [PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-08-20 Thread Srinivas Kandagatla
Thanks Felipe, On 20/08/14 16:57, Felipe Balbi wrote: On Thu, Jul 17, 2014 at 09:16:40PM +0100, Srinivas Kandagatla wrote: This patch makes the phy reset clk and reset line optional as this clk is not available on boards like IFC6410 with APQ8064. phy-reset clk is only used as argument to the

[PATCH v3] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-08-20 Thread Srinivas Kandagatla
This patch makes the phy reset clk and reset line optional as this clk is not available on boards like IFC6410 with APQ8064. phy-reset clk is only used as argument to the mach level callbacks, so this patch adds condition before clk_get calls so that the driver wouldn't fail on SOCs which do not h

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-20 Thread sundeep subbaraya
Hi Daniel, On Tue, Aug 19, 2014 at 3:26 PM, Daniel Mack wrote: > Hi, > > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: >> This patch adds xilinx usb2 device driver support > > Add some more information here, please. Copying the text from the > Kconfig option is already a good start. > >

[PATCH] usb: gadget: serial: remove PREFIX macro

2014-08-20 Thread Richard Leitner
Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded ttyGS string. This macro was mostly used in a few debug/warning messages and a lot of hardcoded ttyGS existed beneath. It may have been used for renaming the tty, but if done so most debug messages would ha