Re: What is the command line commands to use UAC2 at USB client side?

2014-08-19 Thread Daniel Mack
On 08/19/2014 02:01 AM, Xuebing Wang wrote: > On 08/19/2014 01:11 AM, Daniel Mack wrote: >> On 08/15/2014 05:49 AM, Xuebing Wang wrote: >>> root@imx6slevk:~# >>> root@imx6slevk:~# arecord -f dat -t wav -D hw:2,0 | aplay -D hw:0,0 >>> Recording WAVE 'stdin' : Signed 16 bit Little Endian, Rate 48000

Re: [RFC] usb issue on imx27: 3 clocks are needed

2014-08-19 Thread gwenhael.goavec
On Tue, 19 Aug 2014 08:18:17 +0800 Peter Chen wrote: > On Mon, Aug 18, 2014 at 01:49:03PM +0200, gwenhael.goavec wrote: > > On Mon, 18 Aug 2014 10:35:53 + > > Peter Chen wrote: > > > > > > > > > On Mon, Aug 18, 2014 at 05:00:59PM +0800, Peter Chen wrote: > > > > > On Sat, Aug 16, 2014 at

Re: What is the command line commands to use UAC2 at USB client side?

2014-08-19 Thread Xuebing Wang
Thanks. You were trying UAC2, right? Yes. Thanks Daniel. Did you hear noise (hear with ear phone, not speaker) especially when playing music from Ubuntu host? I am hearing slight noise here. -- Thanks, Xuebing Wang -- To unsubscribe from this list: send the line "unsubscribe linux-usb" i

[PATCH RESEND v3 03/12] usb: dwc2/gadget: move phy bus legth initialization

2014-08-19 Thread Robert Baldyga
From: Kamil Debski This patch moves the part of code that initializes the PHY bus width. This results in simpler code and removes the need to check whether the Generic PHY Framework is used. Signed-off-by: Kamil Debski Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers

[PATCH RESEND v3 01/12] usb: dwc2/gadget: fix phy disable sequence

2014-08-19 Thread Robert Baldyga
From: Kamil Debski When the driver is removed s3c_hsotg_phy_disable is called three times instead of once. This results in decreasing of the phy reference counter below zero and thus consecutive inserts of the module fails. This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove

[PATCH RESEND v3 00/12] usb: dwc2/gadget: fix series

2014-08-19 Thread Robert Baldyga
Hi Paul, I'm resending this patchset rebased on linux-next. Now it should apply. Thanks, Robert Baldyga Changelog: v3: https://lkml.org/lkml/2014/8/4/617 - use endpoint index instead of FIFO index for EPFIFO - extend patch description v2: https://lkml.org/lkml/2014/7/16/199 - add patch usb: dwc

Re: What is the command line commands to use UAC2 at USB client side?

2014-08-19 Thread Daniel Mack
On 08/19/2014 10:54 AM, Xuebing Wang wrote: > >>> Thanks. You were trying UAC2, right? >> Yes. > > Thanks Daniel. Did you hear noise (hear with ear phone, not speaker) > especially when playing music from Ubuntu host? I am hearing slight > noise here. > Not that I noticed. I'd suggest recordi

[PATCH RESEND v3 02/12] usb: dwc2/gadget: fix phy initialization sequence

2014-08-19 Thread Robert Baldyga
From: Kamil Debski In the Generic PHY Framework a NULL phy is considered to be a valid phy thus the "if (hsotg->phy)" check does not give us the information whether the Generic PHY Framework is used. In addition to the above this patch also removes phy_init from probe and phy_exit from remove. T

[PATCH RESEND v3 04/12] usb: dwc2/gadget: Fix comment text

2014-08-19 Thread Robert Baldyga
From: Andrzej Pietrasiewicz Adjust the debug text to the name of the printed variable. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/d

Re: What is the command line commands to use UAC2 at USB client side?

2014-08-19 Thread Jassi Brar
On Tue, Aug 19, 2014 at 2:15 PM, Daniel Mack wrote: > On 08/19/2014 02:01 AM, Xuebing Wang wrote: > root@imx6slevk:~# root@imx6slevk:~# arecord -f dat -t wav -D hw:2,0 | aplay -D hw:0,0 Recording WAVE 'stdin' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo Playing WAVE 'st

[PATCH RESEND v3 09/12] usb: dwc2/gadget: delay enabling irq once hardware is configured properly

2014-08-19 Thread Robert Baldyga
From: Marek Szyprowski This patch fixes kernel panic/interrupt storm/etc issues if bootloader left s3c-hsotg module in enabled state. Now interrupt handler is enabled only after proper configuration of hardware registers. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drive

[PATCH RESEND v3 06/12] usb: dwc2/gadget: ensure that all fifos have correct memory buffers

2014-08-19 Thread Robert Baldyga
From: Marek Szyprowski Print warning if FIFOs are configured in such a way that they don't fit into the SPRAM available on the s3c hsotg module. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c | 15 ++-

[PATCH RESEND v3 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

2014-08-19 Thread Robert Baldyga
Because we have not enough memory to have each TX FIFO of size at least 3072 bytes (the maximum single packet size with 3 transactions per microframe), we create four FIFOs of lenght 1024, and four of length 3072 bytes, and assing them to endpoints dynamically according to maxpacket size value of g

[PATCH RESEND v3 05/12] usb: dwc2/gadget: hide some not really needed debug messages

2014-08-19 Thread Robert Baldyga
From: Marek Szyprowski Some DWC2/s3c-hsotg debug messages are really useless for typical user, so hide them behind dev_dbg(). Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

Re: What is the command line commands to use UAC2 at USB client side?

2014-08-19 Thread Daniel Mack
On 08/19/2014 11:01 AM, Jassi Brar wrote: > On Tue, Aug 19, 2014 at 2:15 PM, Daniel Mack wrote: >> On 08/19/2014 02:01 AM, Xuebing Wang wrote: >> > root@imx6slevk:~# > root@imx6slevk:~# arecord -f dat -t wav -D hw:2,0 | aplay -D hw:0,0 > Recording WAVE 'stdin' : Signed 16 bit Little En

[PATCH RESEND v3 07/12] usb: dwc2/gadget: break infinite loop in endpoint disable code

2014-08-19 Thread Robert Baldyga
From: Marek Szyprowski This patch fixes possible freeze caused by infinite loop in interrupt context. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/ga

[PATCH RESEND v3 11/12] usb: dwc2/gadget: disable clock when it's not needed

2014-08-19 Thread Robert Baldyga
When device is stopped or suspended clock is not needed so we can disable it for this time. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index b914365..148ef3c 100644

[PATCH RESEND v3 12/12] usb: dwc2/gadget: avoid disabling ep0

2014-08-19 Thread Robert Baldyga
Endpoint 0 should not be disabled, so we start loop counter from number 1. Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 148ef3c..3c1dfe1 100644 --- a/dri

[PATCH RESEND v3 08/12] usb: dwc2/gadget: do not call disconnect method in pullup

2014-08-19 Thread Robert Baldyga
From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --

Re: [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-19 Thread gre...@linuxfoundation.org
On Tue, Aug 19, 2014 at 06:33:04AM +, Sharma, Sanjeev wrote: > Hi Greg, > > Any feedback on this patch ? The merge window ended 2 days ago, _and_ I'm at the kernel summit this week, _and_ my queue is currently sitting at: $ mdfrm -c ~/mail/todo/ 1317 messages in /home/gregkh/m

Re: [PATCH v4] usb: hcd: add generic PHY support

2014-08-19 Thread Greg KH
On Tue, Aug 19, 2014 at 02:34:59AM +0400, Sergei Shtylyov wrote: > Hello. > > On 07/23/2014 02:17 AM, Sergei Shtylyov wrote: > > >Add the generic PHY support, analogous to the USB PHY support. Intended it > >to be > >used with the PCI EHCI/OHCI drivers and the xHCI platform driver. > > >Signed-

RE: [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-19 Thread Sharma, Sanjeev
Thanks for letting me know. Sanjeev Sharma -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Tuesday, August 19, 2014 3:01 PM To: Sharma, Sanjeev Cc: kra...@redhat.com; mdharm-...@one-eyed-alien.net; linux-usb@vger.kernel.org; linux-ker...@vge

Re: What is the command line commands to use UAC2 at USB client side?

2014-08-19 Thread Jassi Brar
On Tue, Aug 19, 2014 at 2:39 PM, Daniel Mack wrote: > On 08/19/2014 11:01 AM, Jassi Brar wrote: >> On Tue, Aug 19, 2014 at 2:15 PM, Daniel Mack wrote: >>> On 08/19/2014 02:01 AM, Xuebing Wang wrote: >>> >> root@imx6slevk:~# >> root@imx6slevk:~# arecord -f dat -t wav -D hw:2,0 | aplay -D h

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-19 Thread Daniel Mack
Hi, On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: > This patch adds xilinx usb2 device driver support Add some more information here, please. Copying the text from the Kconfig option is already a good start. > drivers/usb/gadget/Kconfig | 14 + > drivers/usb/gadget/Makefile

Re: [linux-usb] USB Gadget drivers Windows 7/8 support and .bAlternateSetting in interface descriptor

2014-08-19 Thread Xuebing Wang
On 08/19/2014 12:58 PM, Peter Chen wrote: My environment is Freescale i.MX6SL EVK board (as USB peripheral device), which is based on kernel 3.10.17. i.MX6SL uses ChipIdea dual-role controller. My problem is that gadget drivers g_ether and g_audio (UAC1 enabled) can NOT be detected by Window

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-08-19 Thread Daniel Mack
On 08/19/2014 11:56 AM, Daniel Mack wrote: > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: >> drivers/usb/gadget/Kconfig | 14 + >> drivers/usb/gadget/Makefile |1 + >> drivers/usb/gadget/udc-xilinx.c | 2261 >> +++ >> 3 files changed,

RE: [BUG] usb_dev_resume returns -113 due to work items queued by usb on pm_wq is not executed before suspending.

2014-08-19 Thread Du, ChangbinX
> Commit d6236f6d1d88 prevents the roothub resuming work item from being > queued. > > > 4) We force system suspending process aborted (by modifying code) just > after the usb > > Device suspend callback is invoked. > > 5) Then PM core will call resume callback of the usb device to recovery. On

RE: Transient USB disconnects

2014-08-19 Thread David Laight
From: Alan Stern > On Fri, 15 Aug 2014, David Laight wrote: > > > With all the usb dynamic-debug enabled the first errors I see are 'detected > > XactErr' > > len 0/1522 and len 2048/18944 (all 32 retries). > > Then some '3strikes' messages (75 in total split between the endpoints). > > > > I've

[PATCH] usb: use kcalloc instead of kzalloc

2014-08-19 Thread Arjun Sreedharan
kcalloc has protection from integer overflows which could arise from the multiplication of number of elements and size. Signed-off-by: Arjun Sreedharan --- drivers/usb/core/config.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/core/config.c b/driver

Re: [PATCH] usb: use kcalloc instead of kzalloc

2014-08-19 Thread Clemens Ladisch
Arjun Sreedharan wrote: > kcalloc has protection from integer overflows > which could arise from the multiplication of > number of elements and size. You are implying that such an overflow could arise in this code. This is false. > @@ -380,8 +380,7 @@ static int usb_parse_interface(struct device

Re: [PATCH v4] usb: hcd: add generic PHY support

2014-08-19 Thread Sergei Shtylyov
Hello. On 8/19/2014 1:33 PM, Greg KH wrote: Add the generic PHY support, analogous to the USB PHY support. Intended it to be used with the PCI EHCI/OHCI drivers and the xHCI platform driver. Signed-off-by: Sergei Shtylyov Signed-off-by: Yoshihiro Shimoda --- This patch is against the 'u

[PATCH 0/3] xhci: fixes for usb-linus

2014-08-19 Thread Mathias Nyman
Hi Greg These following xhci fixes for usb-linus apply on top of 3.17-rc1 It includes the first patch of Hans de Goede's xhci UAS fixes. I'll send the rest of his xhci cleanup patches to usb-next. The rework cycle bit patch has a bit more code, primary goal was to fix a issue introduced in comm

[PATCH 2/3] usb: xhci: amd chipset also needs short TX quirk

2014-08-19 Thread Mathias Nyman
From: Huang Rui AMD xHC also needs short tx quirk after tested on most of chipset generations. That's because there is the same incorrect behavior like Fresco Logic host. Please see below message with on USB webcam attached on xHC host: [ 139.262944] xhci_hcd :00:10.0: WARN Successful compl

[PATCH 1/3] xhci: Treat not finding the event_seg on COMP_STOP the same as COMP_STOP_INVAL

2014-08-19 Thread Mathias Nyman
From: Hans de Goede When using a Renesas uPD720231 chipset usb-3 uas to sata bridge with a 120G Crucial M500 ssd, model string: Crucial_ CT120M500SSD1, together with a the integrated Intel xhci controller on a Haswell laptop: 00:14.0 USB controller [0c03]: Intel Corporation 8 Series USB xHCI HC

[PATCH 3/3] xhci: rework cycle bit checking for new dequeue pointers

2014-08-19 Thread Mathias Nyman
When we manually need to move the TR dequeue pointer we need to set the correct cycle bit as well. Previously we used the trb pointer from the last event received as a base, but this was changed in commit 1f81b6d22a59 ("usb: xhci: Prefer endpoint context dequeue pointer") to use the dequeue pointer

Re: xhci driver causes Kernel-Oops starting with kernel 3.16

2014-08-19 Thread Mathias Nyman
On 08/18/2014 06:59 PM, Manuel Reimer wrote: > Hello, > > I already opened a bug report for my problem here: > > https://bugzilla.kernel.org/show_bug.cgi?id=82731#c1 > > Starting with Kernel 3.16 I get kernel Oops from time to time when booting my > desktop system. > > A reset helps to bring t

[PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce failures of the same port] added the check of the reliable port, but it also replaced the device argument to dev_err() wrongly, which leads to a NULL dereference. This patch restores the right device, port_dev->dev. [The fix sug

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2014 15:13:24 +0200, Takashi Iwai wrote: > > The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce > failures of the same port] added the check of the reliable port, but > it also replaced the device argument to dev_err() wrongly, which leads > to a NULL dereference.

Re: [PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

2014-08-19 Thread Felipe Balbi
Hi, On Fri, Aug 08, 2014 at 05:38:57PM +0200, Michael Grzeschik wrote: > If the pending buffers in the queue could not be pushed to the udc > endpoint we have to cancel the uvc_queue. Otherwise the gadget will get > stuck on this error. This patch calls uvc_queue_cancel if usb_ep_queue > failed. >

Re: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000

2014-08-19 Thread Felipe Balbi
Hi, On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote: > From: Bryan O'Donoghue > > This patch is to enable the USB gadget device for Intel Quark X1000 > > Signed-off-by: Bryan O'Donoghue > Signed-off-by: Bing Niu > Signed-off-by: Alvin (Weike) Chen Can someone confirm to me this

Re: [PATCH] USB: pch_udc: Add support for Intel Quark X1000 USB gadget device

2014-08-19 Thread Felipe Balbi
On Mon, Aug 04, 2014 at 11:00:07AM -0700, Chen, Alvin wrote: > From: "Alvin (Weike) Chen" > > Hi, > Intel Quark X1000 consists of one USB gadget device which can be PCI > enumerated. > pch_udc layer doesn't support it. Thus, we add support for Intel Quark X1000 > USB > gadget device as well.

Re: [PATCH v3 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-08-19 Thread Felipe Balbi
On Wed, Jul 30, 2014 at 07:28:24PM +0400, Sergei Shtylyov wrote: > On 07/30/2014 01:43 PM, Robert Baldyga wrote: > > >This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which > >returns endpoint descriptor to userspace. It works only if function > >is active. > > >Signed-off-by: Robert B

Re: [PATCH 02/13] usb: udc: set the udc is ready to pullup dp when it needs

2014-08-19 Thread Peter Chen
On Tue, Aug 19, 2014 at 01:46:17AM +, Paul Zimmerman wrote: > > From: Peter Chen [mailto:peter.c...@freescale.com] > > Sent: Sunday, August 17, 2014 9:14 PM > > > > Except for chipidea driver, all other udc drivers will tell the > > gadget driver that they are ready to pullup dp at udc_start,

Re: [linux-usb] USB Gadget drivers Windows 7/8 support and .bAlternateSetting in interface descriptor

2014-08-19 Thread Peter Chen
On Tue, Aug 19, 2014 at 06:05:27PM +0800, Xuebing Wang wrote: > > On 08/19/2014 12:58 PM, Peter Chen wrote: > >>My environment is Freescale i.MX6SL EVK board (as USB peripheral device), > >>which is based on kernel 3.10.17. i.MX6SL uses ChipIdea dual-role > >>controller. > >> > >>My problem is tha

Re: [PATCH resend] Revert "usb: gadget: u_ether: synchronize with transmit when stopping queue"

2014-08-19 Thread Tony Lindgren
* roy.qing...@gmail.com [140819 17:24]: > From: Li RongQing > > This reverts commit a9232076374334ca2bc2a448dfde96d38a54349a. > > It introduced a dead lock, and did not fix anything. > > it made netif_tx_lock() be called in IRQ context, but in softirq context, > the same lock is locked without

Re: What is the command line commands to use UAC2 at USB client side?

2014-08-19 Thread Peter Chen
On Tue, Aug 19, 2014 at 11:09:44AM +0200, Daniel Mack wrote: > On 08/19/2014 11:01 AM, Jassi Brar wrote: > > On Tue, Aug 19, 2014 at 2:15 PM, Daniel Mack wrote: > >> On 08/19/2014 02:01 AM, Xuebing Wang wrote: > >> > > root@imx6slevk:~# > > root@imx6slevk:~# arecord -f dat -t wav -D hw:2,0

Re: [PATCH] Newer Technology uSCSI SCSI-USB converter

2014-08-19 Thread Greg KH
On Fri, Aug 15, 2014 at 08:11:19PM +0100, Mark wrote: > The uSCSI from Newer Technology is a SCSI-USB converter with USB ID > 06ca:2003. Like several other SCSI-USB products, it's a Shuttle Technology > OEM device. Copying the unusual-devs.h entry for device 04e6:0002 allows it > to work with Li

Re: [linux-usb] Is UAC1 (USB Audio Class 1.0) broken?

2014-08-19 Thread Felipe Balbi
On Sun, Aug 17, 2014 at 05:52:55PM +0800, Xuebing Wang wrote: > Hi Community, Felipe, > > I am trying to get UAC1 working on Freescale i.MX6SL EVK board (as USB > peripheral device), which is based on kernel 3.10.17. v3.10 ? Unless you test on something more recent (like v3.16 or v3.17-rc1) you'r

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Alan Stern
On Tue, 19 Aug 2014, Takashi Iwai wrote: > The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce > failures of the same port] added the check of the reliable port, but > it also replaced the device argument to dev_err() wrongly, which leads > to a NULL dereference. > > This patch r

Re: [linux-usb] USB Gadget drivers Windows 7/8 support and .bAlternateSetting in interface descriptor

2014-08-19 Thread Felipe Balbi
On Tue, Aug 19, 2014 at 10:27:39PM +0800, Peter Chen wrote: > On Tue, Aug 19, 2014 at 06:05:27PM +0800, Xuebing Wang wrote: > > > > On 08/19/2014 12:58 PM, Peter Chen wrote: > > >>My environment is Freescale i.MX6SL EVK board (as USB peripheral device), > > >>which is based on kernel 3.10.17. i.MX

Re: [PATCH] usb: use kcalloc instead of kzalloc

2014-08-19 Thread Alan Stern
On Tue, 19 Aug 2014, Arjun Sreedharan wrote: > kcalloc has protection from integer overflows > which could arise from the multiplication of > number of elements and size. > > Signed-off-by: Arjun Sreedharan As Clemens pointed out, integer overflows cannot occur here. This patch is not needed.

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2014 10:35:58 -0400 (EDT), Alan Stern wrote: > > On Tue, 19 Aug 2014, Takashi Iwai wrote: > > > The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce > > failures of the same port] added the check of the reliable port, but > > it also replaced the device argument to

RE: Transient USB disconnects

2014-08-19 Thread Alan Stern
On Tue, 19 Aug 2014, David Laight wrote: > I think I've discovered our underlying problem. > > I scoped the USB data lines (NFI why the hardware guys hadn't looked at > them!). > As well as the SOF (every 125us) there is a rather nasty decaying transient > every 41us that is almost 400mV and las

Re: Bug 82571 - Mouse erratic and polling issues with USB 3.0 port and Logitech G9x mouse.

2014-08-19 Thread Alan Stern
On Mon, 18 Aug 2014, Commander wrote: > > Currently there is no way to change the polling rate, unless you use a > > USB-2 port. > I see. > > Any ideas why the USB 3.0 port should affect the game Witcher 2 like > in the video if that is an hardware/driver issue or SDL or maybe > combination? I d

Re: [PATCH v3 0/3] usb: gadget: f_fs: userspace API fixes and improvements

2014-08-19 Thread Felipe Balbi
On Wed, Jul 30, 2014 at 11:43:40AM +0200, Robert Baldyga wrote: > This patchset contains changes in FunctionFS making it easier and > safer to use. It fixes bug in endpoint files handling code, adds new > ioctl allowing to obtain endpoint descriptor, and introduces virtual > address mapping which a

Re: [PATCH 01/13] usb: gadget: introduce .connect gadget driver API

2014-08-19 Thread Alan Stern
On Tue, 19 Aug 2014, Peter Chen wrote: > > > --- a/include/linux/usb/gadget.h > > > +++ b/include/linux/usb/gadget.h > > > @@ -873,12 +873,39 @@ struct usb_gadget_driver { > > > void(*disconnect)(struct usb_gadget *); > > > void(*suspend)(struct usb_gadg

Re: [PATCH v2 2/3] usb: core: fix below build warning

2014-08-19 Thread Alan Stern
On Tue, 19 Aug 2014, Peter Chen wrote: > linux-2.6/drivers/usb/core/hub.c: In function 'usb_disconnect': > linux-2.6/drivers/usb/core/hub.c:2110: warning: 'hub' may be used > uninitialized in this function > linux-2.6/drivers/usb/core/hub.c:2111: warning: 'port1' may be used > uninitialized in t

Re: xhci driver causes Kernel-Oops starting with kernel 3.16

2014-08-19 Thread Mathias Nyman
On 08/18/2014 06:59 PM, Manuel Reimer wrote: > Hello, > > I already opened a bug report for my problem here: > > https://bugzilla.kernel.org/show_bug.cgi?id=82731#c1 > > Starting with Kernel 3.16 I get kernel Oops from time to time when booting my > desktop system. > > A reset helps to bring t

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Greg Kroah-Hartman
On Tue, Aug 19, 2014 at 04:46:31PM +0200, Takashi Iwai wrote: > At Tue, 19 Aug 2014 10:35:58 -0400 (EDT), > Alan Stern wrote: > > > > On Tue, 19 Aug 2014, Takashi Iwai wrote: > > > > > The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce > > > failures of the same port] added the

Re: xhci driver causes Kernel-Oops starting with kernel 3.16

2014-08-19 Thread Manuel Reimer
On 08/19/2014 03:18 PM, Mathias Nyman wrote: Did the same machine work with previous kernel versions? Yes. I use Arch Linux so I get kernel updates regularly. I can't tell you exactly in which kernel the problem first occurred. I can only tell that Kernel 3.16 is the first kernel where I got

[PATCH] usbcore: Reduce redundant error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
Alan Stern pointed out that the port number shown in the error message from hub_port_connect() is redundant. This patch removes it, essentially reverts to the state before the commit 5ee0f803cc3a. Signed-off-by: Takashi Iwai --- I wasn't sure whether this deserves Cc to stable. Feel free to que

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Greg Kroah-Hartman
On Tue, Aug 19, 2014 at 10:15:37AM -0500, Greg Kroah-Hartman wrote: > On Tue, Aug 19, 2014 at 04:46:31PM +0200, Takashi Iwai wrote: > > At Tue, 19 Aug 2014 10:35:58 -0400 (EDT), > > Alan Stern wrote: > > > > > > On Tue, 19 Aug 2014, Takashi Iwai wrote: > > > > > > > The commit [5ee0f803cc3a: usbc

[PATCH v2] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
The commit [5ee0f803cc3a: usbcore: don't log on consecutive debounce failures of the same port] added the check of the reliable port, but it also replaced the device argument to dev_err() wrongly, which leads to a NULL dereference. This patch restores the right device, port_dev->dev. Also, since

Re: [PATCH] usbcore: Fix wrong device in an error message in hub_port_connect()

2014-08-19 Thread Takashi Iwai
At Tue, 19 Aug 2014 10:25:20 -0500, Greg Kroah-Hartman wrote: > > On Tue, Aug 19, 2014 at 10:15:37AM -0500, Greg Kroah-Hartman wrote: > > On Tue, Aug 19, 2014 at 04:46:31PM +0200, Takashi Iwai wrote: > > > At Tue, 19 Aug 2014 10:35:58 -0400 (EDT), > > > Alan Stern wrote: > > > > > > > > On Tue, 1

RE: [PATCH RESEND v3 00/12] usb: dwc2/gadget: fix series

2014-08-19 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Tuesday, August 19, 2014 1:54 AM > > Hi Paul, > > I'm resending this patchset rebased on linux-next. Now it should apply. > > Thanks, > Robert Baldyga > > Changelog: > v3: https://lkml.org/lkml/2014/8/4/617 > - use endpoint index ins

Re: [PATCH RESEND v3 00/12] usb: dwc2/gadget: fix series

2014-08-19 Thread gre...@linuxfoundation.org
On Tue, Aug 19, 2014 at 03:46:58PM +, Paul Zimmerman wrote: > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > Sent: Tuesday, August 19, 2014 1:54 AM > > > > Hi Paul, > > > > I'm resending this patchset rebased on linux-next. Now it should apply. > > > > Thanks, > > Robert Baldyga >

Re: [PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

2014-08-19 Thread Laurent Pinchart
On Tuesday 19 August 2014 09:11:57 Felipe Balbi wrote: > On Fri, Aug 08, 2014 at 05:38:57PM +0200, Michael Grzeschik wrote: > > If the pending buffers in the queue could not be pushed to the udc > > endpoint we have to cancel the uvc_queue. Otherwise the gadget will get > > stuck on this error. Thi

Re: [PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

2014-08-19 Thread Felipe Balbi
On Tue, Aug 19, 2014 at 06:33:07PM +0200, Laurent Pinchart wrote: > On Tuesday 19 August 2014 09:11:57 Felipe Balbi wrote: > > On Fri, Aug 08, 2014 at 05:38:57PM +0200, Michael Grzeschik wrote: > > > If the pending buffers in the queue could not be pushed to the udc > > > endpoint we have to cancel

Re: [PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

2014-08-19 Thread Laurent Pinchart
Hi Michael, Thank you for the patch. On Friday 08 August 2014 17:38:57 Michael Grzeschik wrote: > If the pending buffers in the queue could not be pushed to the udc > endpoint we have to cancel the uvc_queue. Otherwise the gadget will get > stuck on this error. This patch calls uvc_queue_cancel i

[PATCH v3 4/4] xhci: Allow xHCI drivers to be built as separate modules

2014-08-19 Thread Andrew Bresticker
Instead of building all of the xHCI code into a single module, separate it out into the core (xhci-hcd), PCI (xhci-pci, now selected by the new config option CONFIG_USB_XHCI_PCI), and platform (xhci-plat) drivers. Also update the PCI/platform drivers with module descriptions/licenses and have them

[PATCH v3 3/4] xhci: Export symbols used by host-controller drivers

2014-08-19 Thread Andrew Bresticker
In preparation for allowing the xHCI host controller drivers to be built as separate modules, export symbols from the xHCI core that may be used by the host controller drivers. Signed-off-by: Andrew Bresticker --- Changes from v2: - exported xhci_dbg_quirks tracepoint Changes from v1: - exporte

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-19 Thread Laurent Pinchart
Hi Michael, Thank you for the patch. (CC'ing Hans Verkuil and the linux-media mailing list) On Friday 08 August 2014 17:38:58 Michael Grzeschik wrote: > This patch adds ENUM_FMT as possible ioctl to the uvc v4l2 device. > That makes userspace applications with a generic IOCTL calling > conventio

[PATCH v3 2/4] xhci: Check for XHCI_COMP_MODE_QUIRK when disabling D3cold

2014-08-19 Thread Andrew Bresticker
Instead of calling xhci_compliance_mode_recovery_timer_quirk_check() again in the PCI suspend path, just check for XHCI_COMP_MODE_QUIRK which will have been set based on xhci_compliance_mode_recovery_timer_quirk_check() in xhci_init(). Signed-off-by: Andrew Bresticker --- No change from v1/v2. --

Re: [PATCH v2 1/4] xhci: Introduce xhci_init_driver()

2014-08-19 Thread Andrew Bresticker
On Mon, Aug 18, 2014 at 11:10 PM, Yoshihiro Shimoda wrote: > Hi, > > (2014/08/19 1:12), Andrew Bresticker wrote: >> Since the struct hc_driver is mostly the same across the xhci-pci, >> xhci-plat, and the upcoming xhci-tegra driver, introduce the function >> xhci_init_driver() which will populate

[PATCH v3 1/4] xhci: Introduce xhci_init_driver()

2014-08-19 Thread Andrew Bresticker
Since the struct hc_driver is mostly the same across the xhci-pci, xhci-plat, and the upcoming xhci-tegra driver, introduce the function xhci_init_driver() which will populate the hc_driver with the default xHCI operations. The caller must supply a setup function which will be used as the hc_drive

Re: [PATCH v2 3/3] usb: gadget/uvc: bump isoc requests from 4 to 16

2014-08-19 Thread Laurent Pinchart
Hi Michael, Thank you for the patch. On Friday 08 August 2014 17:38:59 Michael Grzeschik wrote: > While sending bigger images it is better to use more isochronous > requests in flight. This patch bumps the default from 4 to 16. What does this fix ? Does it increase throughput or decrease CPU loa

Re: [PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

2014-08-19 Thread Laurent Pinchart
On Tuesday 19 August 2014 11:35:12 Felipe Balbi wrote: > On Tue, Aug 19, 2014 at 06:33:07PM +0200, Laurent Pinchart wrote: > > On Tuesday 19 August 2014 09:11:57 Felipe Balbi wrote: > > > On Fri, Aug 08, 2014 at 05:38:57PM +0200, Michael Grzeschik wrote: > > > > If the pending buffers in the queue

[PATCH v3 0/4] Allow xHCI drivers to be built as separate modules

2014-08-19 Thread Andrew Bresticker
It was suggested in the review of the Tegra xHCI driver [1] that we allow xHCI drivers to be built as individual modules (like EHCI) instead of building them all into the single xhci-hcd module as they are today. Patches 1-3 prepare for making the xHCI PCI and platform drivers able to be built as

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-19 Thread Christoph Hellwig
On Thu, Aug 07, 2014 at 11:58:37AM -0400, Alan Stern wrote: > > On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: > > > > I doubt either of them forces users to hack up flags for these cases. > > > > > > Why was this change needed in the first place? There's no explanation > > > in the

RE: [PATCH RESEND v3 00/12] usb: dwc2/gadget: fix series

2014-08-19 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, August 19, 2014 9:16 AM > > On Tue, Aug 19, 2014 at 03:46:58PM +, Paul Zimmerman wrote: > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > > Sent: Tuesday, August 19, 2014 1:54 AM > > > > > > Hi

Re: [PATCH 2/3] usbip: move usbip kernel code out of staging

2014-08-19 Thread Greg KH
On Thu, Aug 07, 2014 at 08:10:28AM +0300, Valentina Manea wrote: > At this point, USB/IP kernel code is fully functional > and can be moved out of staging. > > Signed-off-by: Valentina Manea This patch moves the code, but now it's "gone" from the build system as it is not hooked up and can not b

Re: [PATCH v4 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-19 Thread Doug Anderson
Kever, On Tue, Aug 5, 2014 at 6:01 PM, Kever Yang wrote: > According to the "dr_mode", the otg controller can work as > device role and host role. Some boards always want to use host mode > and some other boards want to use gadget mode. We use the dts setting > to set dwc2's mode, rather than fix

Re: [PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

2014-08-19 Thread Felipe Balbi
Hi, On Tue, Aug 19, 2014 at 07:10:10PM +0200, Laurent Pinchart wrote: > On Tuesday 19 August 2014 11:35:12 Felipe Balbi wrote: > > On Tue, Aug 19, 2014 at 06:33:07PM +0200, Laurent Pinchart wrote: > > > On Tuesday 19 August 2014 09:11:57 Felipe Balbi wrote: > > > > On Fri, Aug 08, 2014 at 05:38:57

Re: [PATCH RESEND] usb: chipidea: msm: Use USB PHY API to control PHY state

2014-08-19 Thread Felipe Balbi
On Fri, Aug 15, 2014 at 12:21:19PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > PHY drivers keep track of the current state of the hardware, > so don't change PHY settings under it. > > Signed-off-by: Ivan T. Ivanov looks correct to me from a PHY API perspective, so: Acked-by: Fe

[PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Felipe Balbi
When we're debugging hard-to-reproduce and time-sensitive use cases, printk() poses too much overhead. That's when the kernel's tracing infrastructure comes into play. This patch implements a few initial tracepoints for the dwc3 driver. More traces can be added as necessary in order to ease the ta

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, August 19, 2014 12:09 PM > > When we're debugging hard-to-reproduce and time-sensitive > use cases, printk() poses too much overhead. That's when > the kernel's tracing infrastructure comes into play. > > This patch implements a few init

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Felipe Balbi
On Tue, Aug 19, 2014 at 08:00:27PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, August 19, 2014 12:09 PM > > > > When we're debugging hard-to-reproduce and time-sensitive > > use cases, printk() poses too much overhead. That's when > > the kernel's t

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, August 19, 2014 1:10 PM > > On Tue, Aug 19, 2014 at 08:00:27PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Tuesday, August 19, 2014 12:09 PM > > > > > > When we're debugging hard-to-reproduce an

RE: [PATCH 2/2] USB: serial: add Novatel Wireless GPS driver

2014-08-19 Thread Kirk Madsen
I applied your two patches to current Fedora core 20 kernel sources, built, remembered to remove the work-around boot-params and run grub2-mkconfig, and rebooted. My Novatel GPS is recognized on plug-in to my USB2 ports and appears to work correctly. Thank you. If you want more detail than

[PATCH] [RESEND] Newer Technology uSCSI SCSI-USB converter

2014-08-19 Thread Mark
Hi, Re-sending as requested. I also added a couple of lines to the explanation. The uSCSI from Newer Technology is a SCSI-USB converter with USB ID 06ca:2003. Like several other SCSI-USB products, it's a Shuttle Technology OEM device. Without a suitable entry in unusual-devs.h, the converter can

RE: [PATCH 02/13] usb: udc: set the udc is ready to pullup dp when it needs

2014-08-19 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Peter Chen > Sent: Tuesday, August 19, 2014 7:26 AM > > On Tue, Aug 19, 2014 at 01:46:17AM +, Paul Zimmerman wrote: > > > From: Peter Chen [mailto:peter.c...@freescale.com] > > > Sent: Sunday, Augu

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Felipe Balbi
Hi, On Tue, Aug 19, 2014 at 08:14:11PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, August 19, 2014 1:10 PM > > > > On Tue, Aug 19, 2014 at 08:00:27PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Tuesda

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, August 19, 2014 3:02 PM > > I didn't have time to test this yet (other than build testing), but how > does this one look ? Now we will print cute little strings for all > events and we still have proper link state tracking. > > 8<---

Re: [linux-usb] USB Gadget drivers Windows 7/8 support and .bAlternateSetting in interface descriptor

2014-08-19 Thread Peter Chen
On Tue, Aug 19, 2014 at 09:36:19AM -0500, Felipe Balbi wrote: > On Tue, Aug 19, 2014 at 10:27:39PM +0800, Peter Chen wrote: > > On Tue, Aug 19, 2014 at 06:05:27PM +0800, Xuebing Wang wrote: > > > > > > On 08/19/2014 12:58 PM, Peter Chen wrote: > > > >>My environment is Freescale i.MX6SL EVK board

RE: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000

2014-08-19 Thread Chen, Alvin
> Hi, > > On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote: > > From: Bryan O'Donoghue > > > > This patch is to enable the USB gadget device for Intel Quark X1000 > > > > Signed-off-by: Bryan O'Donoghue > > Signed-off-by: Bing Niu > > Signed-off-by: Alvin (Weike) Chen > > Can some

Re: [PATCH 1/3] usb: dwc2: gadget: fix below build warning

2014-08-19 Thread Jingoo Han
On Tuesday, August 19, 2014 8:08 AM, Paul Zimmerman wrote: > > > From: Paul Zimmerman > > Sent: Monday, August 18, 2014 11:03 AM > > > > > From: Jingoo Han [mailto:jg1@samsung.com] > > > Sent: Monday, August 18, 2014 2:17 AM > > > > > > On Monday, August 18, 2014 5:32 PM, Peter Chen wrote: > >

Re: [PATCH v2 1/3] usb: dwc2: gadget: fix below build warning

2014-08-19 Thread Jingoo Han
On Tuesday, August 19, 2014 9:56 AM, Peter Chen wrote: > > linux-2.6/drivers/usb/dwc2/gadget.c: In function 's3c_hsotg_irq_enumdone': > linux-2.6/drivers/usb/dwc2/gadget.c:1904: warning: 'ep_mps' may be used > uninitialized in this function > > Acked-by: Paul Zimmerman > Signed-off-by: Peter Ch

RE: [PATCH 1/3] usb: dwc2: gadget: fix below build warning

2014-08-19 Thread Paul Zimmerman
> From: Jingoo Han [mailto:jg1@samsung.com] > Sent: Tuesday, August 19, 2014 6:16 PM > > On Tuesday, August 19, 2014 8:08 AM, Paul Zimmerman wrote: > > > > > From: Paul Zimmerman > > > Sent: Monday, August 18, 2014 11:03 AM > > > > > > > From: Jingoo Han [mailto:jg1@samsung.com] > > > > Se

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-19 Thread Hans Verkuil
On 08/19/2014 05:01 PM, Laurent Pinchart wrote: > Hi Michael, > > Thank you for the patch. > > (CC'ing Hans Verkuil and the linux-media mailing list) > > On Friday 08 August 2014 17:38:58 Michael Grzeschik wrote: >> This patch adds ENUM_FMT as possible ioctl to the uvc v4l2 device. >> That makes

[PATCH] usb: dwc2: gadget: Set the default EP max packet value as 8 bytes

2014-08-19 Thread Jingoo Han
Set the default EP max packet value as 8 bytes, because in the case of low-speed, 'ep_mps' is not set. Thus, the default value of 'ep_mps' should be considered for the case of low-speed. Signed-off-by: Jingoo Han --- - Based on the latest 'usb-linus' branch. drivers/usb/dwc2/gadget.c | 2 +- 1

  1   2   >