Re: [PATCH -next] usb: gadget: Fix return value check in r8a66597_probe()

Hi Wei, Thank you for the patch. On Sunday 20 July 2014 11:41:53 weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Si

Re: [PATCH v2] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-20 8:38 GMT+02:00 Wang YanQing: > PL2303HX has two GPIOs, this patch add interface for it. checkpatch.pl shows 2 errors: ERROR: space required before the open parenthesis '(' #218: FILE: drivers/usb/serial/pl2303.c:309: + if(pl2303_vendor_read(gpio->serial, 0x0081, buf) < 1) ERROR: that

[PATCH -next] usb: gadget: Remove redundant dev_err call in r8a66597_sudmac_ioremap()

From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/usb/gadget/udc/r8a66597-udc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/

Re: [PATCH -next] usb: gadget: Remove redundant dev_err call in r8a66597_sudmac_ioremap()

Hi Wei, Thank you for the patch. On Sunday 20 July 2014 20:30:14 weiyj...@163.com wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun Acked-by: Laurent Pi

[GIT PULL] USB driver fixes for 3.16-rc6

The following changes since commit 1795cd9b3a91d4b5473c97f491d63892442212ab: Linux 3.16-rc5 (2014-07-13 14:04:33 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.16-rc6 for you to fetch changes up to bb86cf569bbd7ad4dce

Re: [PATCH] gpio:gpio-pl2303: add gpio driver for GPIOs on PL2303

Hi, > +#include > +#include > +#include > + pl2303_gpio_write(&pl2303_gpio->gpio_chip); > + > + ret = gpiochip_add(&pl2303_gpio->gpio_chip); > + if (ret < 0) { AFAICS that stuff is conditional:ed by #ifdef CONFIG_GPIOLIB in gpio.h (or rather, its internally included asm-generic

[PATCH] USB: core: hcd-pci: free IRQ before disabling PCI device when shutting down

The assigned IRQ should be freed before calling pci_disable_device() when shutting down system, otherwise it will cause following warning. [ 568.879482] [ cut here ] [ 568.884236] WARNING: CPU: 1 PID: 3300 at /home/konrad/ssd/konrad/xtt-i386/bootstrap/linux-usb/fs/proc/ge

[PATCH v3] usb:serial:pl2303: add GPIOs interface on PL2303

PL2303HX has two GPIOs, this patch add interface for it. Signed-off-by: Wang YanQing --- Changes v2-v3: 1: fix errors and warnings reported by Daniele Forsi checked with checkpatch.pl 2: fix missing GPIOLIB dependence in Kconfig 3: fix pl2303_gpio_get can't work Known issue: If gpios are i

[PATCH V2] usb: lvstest: Fix sparse warnings generated by kbuild test bot

Following sparse warnings were reported by kbuild test bot drivers/usb/misc/lvstest.c:314:28: sparse: incorrect type in assignment (different base types) drivers/usb/misc/lvstest.c:314:28:expected unsigned short [unsigned] [usertype] portchange drivers/usb/misc/lvstest.c:314:28:got

Re: [PATCH V2] usb: lvstest: Fix sparse warnings generated by kbuild test bot

On Mon, Jul 21, 2014 at 09:47:30AM +0530, Pratyush Anand wrote: > Following sparse warnings were reported by kbuild test bot > > drivers/usb/misc/lvstest.c:314:28: sparse: incorrect type in assignment > (different base types) >drivers/usb/misc/lvstest.c:314:28:expected unsigned short [uns

[Resend PATCH V2] usb: lvstest: Fix sparse warnings generated by kbuild test bot

Following sparse warnings were reported by kbuild test bot drivers/usb/misc/lvstest.c:314:28: sparse: incorrect type in assignment (different base types) drivers/usb/misc/lvstest.c:314:28:expected unsigned short [unsigned] [usertype] portchange drivers/usb/misc/lvstest.c:314:28:got

Re: [PATCH] usb: core: allow zero packet flag for interrupt urbs

On 7/18/2014 8:09 PM, Alan Stern wrote: On Fri, 18 Jul 2014, Amit Virdi wrote: On 7/17/2014 8:25 PM, Alan Stern wrote: I can't say this is actually wrong, but have you ever encountered a situation where this would be needed? How often does anyone need to do a multi-packet transfer over an int

[PATCH V2] usb: core: allow zero packet flag for interrupt urbs

Section 4.4.7.2 "Interrupt Transfer Bandwidth Requirements" of the USB3.0 spec says: A zero-length data payload is a valid transfer and may be useful for some implementations. So, extend the logic of allowing URB_ZERO_PACKET to interrupt urbs too. Otherwise, the kernel throws warni

Re: [PATCH v3] usb:serial:pl2303: add GPIOs interface on PL2303

Hi, Did some more review, sorry ;) On Mon, Jul 21, 2014 at 10:46:24AM +0800, Wang YanQing wrote: > +static struct gpio_chip template_chip = { > + .label = "pl2303-gpio", > + .owner = THIS_MODULE, > + .direction_input= pl2303_gpio_direction_in,

[PATCH V4 0/2] usb: gadget: zero: Add support for interrupt EP

This patchset adds support for interrupt EP and the corresponding test cases to gadget zero. The code has been rebased and tested on Kernel v3.15-rc5 V3->V4 - Edited the commit message to provide more information regarding the new test cases added - Rebased the code in Kernel v3.16-rc5 - No

[PATCH V4 2/2] usbtest: Add interrupt EP testcases

Two simple test cases for interrupt endpoints are added to the usbtest.c file. These are simple non-queued interrupt IN and interrupt OUT transfers. Currently, only gadget zero is capable of executing the interrupt EP test cases. However, extending the same to other gadgets is extremely simple and

[PATCH V4 1/2] usb: gadget: zero: Add support for interrupt EP

Interrupt endpoints behave quite similar to the bulk endpoints with the difference that the endpoints expect data sending/reception request at particular intervals till the whole data has not been transmitted. The interrupt EP support is added to gadget zero. A new alternate setting (=2) has been