Hi Wei,

Thank you for the patch.

On Sunday 20 July 2014 11:41:53 weiyj...@163.com wrote:
> From: Wei Yongjun <yongjun_...@trendmicro.com.cn>
> 
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>

Acked-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>

> ---
>  drivers/usb/gadget/udc/r8a66597-udc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c
> b/drivers/usb/gadget/udc/r8a66597-udc.c index 4600842..de2a871 100644
> --- a/drivers/usb/gadget/udc/r8a66597-udc.c
> +++ b/drivers/usb/gadget/udc/r8a66597-udc.c
> @@ -1868,8 +1868,8 @@ static int r8a66597_probe(struct platform_device
> *pdev)
> 
>       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>       reg = devm_ioremap_resource(&pdev->dev, res);
> -     if (!reg)
> -             return -ENODEV;
> +     if (IS_ERR(reg))
> +             return PTR_ERR(reg);
> 
>       ires = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>       irq = ires->start;

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to